On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote:
> > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds);
> > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds);
> > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds);
>
> I don't think the in_cmds metric sho
Hi,
The commit summary has a typo (cmd_puds). That said, this change
isn't iSCSI specific, so using "pdu" here doesn't make much sense IMO.
On Wed, 21 Mar 2018 17:52:43 +0800, Zhang Zhuoyu wrote:
> Separate tx/rx cmd_pdus in order to distinguish LUN read/write IOPS.
>
> Signed-off-by: Zhang Zhu
t for
compare_and_write_do_cmp(). One minor suggestion would be to name it
sgl_equal() or similar, to perhaps better reflect the bool return and
avoid memcmp() confusion. Either way:
Reviewed-by: David Disseldorp
Cheers, David
size_t n_bytes, size_t *miscompare_idx);
> >
> >
> > This patch looks good and works fine as a replacement for
> > compare_and_write_do_cmp(). One minor suggestion would be to name it
> > sgl_equal() or similar, to perhaps better reflect the bool return
On Wed, 16 Oct 2013 18:36:19 -0500
Steve French wrote:
> cp --reflink opens the target file for O_WRONLY before invoking the
> (BTRFS) ioctl for clone file, but for copy offload over the network
> the SMB2 specification requires that the target file be open O_RDWR.
>
> I may be able to upgrade t
with open(path, 'r') as file_fd:
> > PermissionError: [Errno 13] Permission denied:
> > '/sys/kernel/config/target/core/fileio_28/xxx/attrib/pi_prot_format'
>
> This looks like an intentional behavior change with
>
> commit 6baca7601bdee2e57f20
6 matches
Mail list logo