Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-08-16 Thread David Herrmann
Hi Jiri On Thu, Jun 27, 2013 at 11:47 AM, Jiri Kosina wrote: > On Wed, 26 Jun 2013, Dmitry Torokhov wrote: > >> On Sat, Jun 15, 2013 at 03:32:44PM +0200, David Herrmann wrote: >> > --- a/include/uapi/linux/input.h >> > +++ b/include/uapi/linux/input.h >

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2013-07-15 Thread David Herrmann
Hi On Sun, Jul 7, 2013 at 12:10 PM, Samuel Thibault wrote: > This permits to reassign keyboard LEDs to something else than keyboard "leds" > state, by adding keyboard led and modifier triggers connected to a series > of VT input LEDs, themselves connected to VT input triggers, which > per-input d

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2013-07-17 Thread David Herrmann
Hi On Mon, Jul 15, 2013 at 9:08 PM, Samuel Thibault wrote: > Hello, > > David Herrmann, le Mon 15 Jul 2013 17:03:08 +0200, a écrit : >> > @@ -13,6 +13,10 @@ >> > bool "Virtual terminal" if EXPERT >> > depends on !S390 && !UML

Re: [PATCH v2 03/14] x86: provide platform-devices for boot-framebuffers

2013-07-17 Thread David Herrmann
Hi Any comments on this? On Thu, Jul 4, 2013 at 2:25 PM, David Herrmann wrote: > The current situation regarding boot-framebuffers (VGA, VESA/VBE, EFI) on > x86 causes troubles when loading multiple fbdev drivers. The global > "struct screen_info" does not provide any state-t

Re: [PATCH v2 2/2] input/uinput: add UI_GET_SYSPATH ioctl to retrieve the sysfs path

2013-07-27 Thread David Herrmann
y the device-name. I don't know why you want the full syspath. It's just overhead in the kernel that we could easily let user-space do. And the path /sys/class/input/ can be put together by user-space. Anyway, Dmitry has to decide on that. Apart from some style-issues I mentioned

[PATCH RESEND 1/8] fbdev: simplefb: add init through platform_data

2013-08-02 Thread David Herrmann
it is not needed. The headers provide proper dummies for the case OF is disabled. Furthermore, we move the FORMAT-definitions to the common platform header so initialization code can use it to transform "struct screen_info" to the right format-name. Signed-off-by: David Herrmann R

[PATCH RESEND 0/8] x86 platform framebuffers

2013-08-02 Thread David Herrmann
dd your tested-by there. And I changed patch #5 so I dropped it there, too. Thanks for testing! Thanks David David Herrmann (8): fbdev: simplefb: add init through platform_data fbdev: simplefb: mark as fw and allocate apertures x86: provide platform-devices for boot-framebuffers x86: sysfb:

[PATCH RESEND 7/8] fbdev: efifb: bind to efi-framebuffer

2013-08-02 Thread David Herrmann
Instead of creating a dummy device, we now bind to the efi-fb device which is provided by x86 initialization code. Signed-off-by: David Herrmann --- drivers/video/efifb.c | 68 +-- 1 file changed, 22 insertions(+), 46 deletions(-) diff --git a

[PATCH RESEND 4/8] x86: sysfb: move EFI quirks from efifb to sysfb

2013-08-02 Thread David Herrmann
The EFI FB quirks from efifb.c are useful for simple-framebuffer devices as well. Apply them by default so we can convert efifb.c to use efi-framebuffer platform devices. Signed-off-by: David Herrmann --- arch/x86/include/asm/sysfb.h | 57 +++ arch/x86/kernel/Makefile | 1 + arch

[PATCH RESEND 8/8] fbdev: fbcon: select VT_HW_CONSOLE_BINDING

2013-08-02 Thread David Herrmann
and I couldn't figure out why. Hence, lets just require console-unbinding so fbdev hotplugging works with fbcon. Signed-off-by: David Herrmann --- drivers/video/console/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/console/Kconfig b/drivers/

[PATCH RESEND 6/8] fbdev: vesafb: bind to platform-framebuffer device

2013-08-02 Thread David Herrmann
x86 creates platform-framebuffer platform devices for every system framebuffer. Use these instead of creating a dummy device. This requires us to remove the __init annotations as hotplugging may occur during runtime. Signed-off-by: David Herrmann --- drivers/video/vesafb.c | 55

[PATCH RESEND 2/8] fbdev: simplefb: mark as fw and allocate apertures

2013-08-02 Thread David Herrmann
for VGA/vesa/EFI framebuffers, but is also of great use for all other systems. Especially with x86 support for simplefb, this information is needed to unload simplefb before a real hw-driver (like i915, radeon, nouveau) is loaded. Signed-off-by: David Herrmann Tested-by: Stephen Warren

[PATCH RESEND 3/8] x86: provide platform-devices for boot-framebuffers

2013-08-02 Thread David Herrmann
and provide a generic simple-framebuffer. For backwards-compatibility (if strange formats are used), we still allow vesafb/efifb to be loaded simultaneously and pick up all remaining devices. Signed-off-by: David Herrmann Tested-by: Stephen Warren --- arch/x86/Kconfig | 26

[PATCH RESEND 5/8] fbdev: simplefb: add common x86 RGB formats

2013-08-02 Thread David Herrmann
32bit XRGB and ARGB are used by modern x86 systems for EFI and VESA framebuffers. The other formats were reported by hpa to be most common. Add these so simplefb works on most common x86 systems. Signed-off-by: David Herrmann --- include/linux/platform_data/simplefb.h | 7 +++ 1 file

Re: [PATCH RESEND 0/8] x86 platform framebuffers

2013-08-03 Thread David Herrmann
Hi On Sat, Aug 3, 2013 at 1:39 AM, H. Peter Anvin wrote: > On 08/02/2013 05:05 AM, David Herrmann wrote: >> Hi >> >> I cut down my previous series to no longer include the SimpleDRM driver. If >> anyone is interested, you can find it here: >> http://lwn.net/Art

Re: [PATCH RESEND 0/8] x86 platform framebuffers

2013-08-03 Thread David Herrmann
Hi On Fri, Aug 2, 2013 at 10:46 PM, Stephen Warren wrote: > On 08/02/2013 06:05 AM, David Herrmann wrote: >> Hi >> >> I cut down my previous series to no longer include the SimpleDRM driver. If >> anyone is interested, you can find it here: >> http://lwn.net/

[PATCH] fbdev: suppress warning when assigning vga-save/restore base

2013-08-04 Thread David Herrmann
ue to size differences. As IO addresses are always low addresses, we can safely drop the higher part of the address. This is what these drivers did before, anyway. Signed-off-by: David Herrmann Reported-by: H. Peter Anvin --- Hi hpa reported build-warnings on i386+PAE: /home/hpa/kernel/distwork

Re: [PATCH RESEND 0/8] x86 platform framebuffers

2013-08-04 Thread David Herrmann
to linux-fbdev (I put you on CC). The (long)-cast should be sufficient, I guess. Were there any other build warnings you encountered? Thanks David > David Herrmann wrote: >>Hi >> >>On Sat, Aug 3, 2013 at 1:39 AM, H. Peter Anvin wrote: >>> On 08/02/2013 05:05

Re: [PATCH v2 1/2] input: document gamepad API and add extra keycodes

2013-08-20 Thread David Herrmann
Hi On Tue, Aug 20, 2013 at 12:32 PM, Jiri Kosina wrote: > On Fri, 16 Aug 2013, David Herrmann wrote: > >> Hm, I just noticed that this got merged without the >> Documentation/input/gamepad.txt description. Was this intentional? >> https://git.kernel.org/cgit/linux/kerne

Re: drm/agp linux-next build broken for non-AGP platform

2013-08-08 Thread David Herrmann
Hi On Thu, Aug 8, 2013 at 12:01 PM, Vincent Stehlé wrote: > Hi, > > Linux next-20130808 link breaks for me with ARM config multi_v7defconfig. > > It seems this is due to the following commit: > > 28ec711 drm/agp: move AGP cleanup paths to drm_agpsupport.c > > ...which calls drm_agp_clear() with

Re: [PATCH 1/2] anon_inodes: allow external inode allocations

2013-07-24 Thread David Herrmann
Hi Al Any comment on this? Regards David On Thu, Jul 11, 2013 at 1:45 AM, David Herrmann wrote: > DRM core shares a single address_space across all inodes that belong to > the same DRM device. This allows efficient unmapping of user-space > mappings during buffer destruction. However,

Re: [rtc-linux] Re: [PATCH 2/2 RESEND] rtc: rtc-hid-sensor-time: enable HID input processing early

2013-08-09 Thread David Herrmann
Hi Alexander On Fri, Aug 9, 2013 at 6:33 PM, Alexander Holler wrote: > Am 09.08.2013 18:21, schrieb Alexander Holler: > >> I've now also verified if hid-sensor-hub receives an event with >> sensor_hub_raw_event() in the error-path (hid_device_io_stop() called >> and probe() failed), and this stil

[PATCH v2 0/4] Anonymous Inode Allocations

2013-08-13 Thread David Herrmann
hared anon_inode_inode, I'd be happy to implement it. However, I didn't succeed and I am actually not sure that separate "struct address_space" are actually supported. For instance, DRM core uses code like: container_of(dev_mapping, struct inode, i_data) which would break in thi

[PATCH v2 3/4] drm: init TTM dev_mapping in ttm_bo_device_init()

2013-08-13 Thread David Herrmann
Ben Skeggs Cc: Maarten Lankhorst Cc: Alex Deucher Cc: Thomas Hellstrom Signed-off-by: David Herrmann --- drivers/gpu/drm/ast/ast_ttm.c | 4 +++- drivers/gpu/drm/cirrus/cirrus_ttm.c| 4 +++- drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +++- drivers/gpu/drm/nouveau/nouveau_gem.c

[PATCH v2 4/4] drm/omap: remove useless if() in evict_entry()

2013-08-13 Thread David Herrmann
anon_inode->i_mapping is always set. This was needed before we introduced anon_inodes. We can safely remove it now. Cc: Rob Clark Signed-off-by: David Herrmann --- drivers/gpu/drm/omapdrm/omap_gem.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) d

[PATCH v2 2/4] DRM: use anon_inode instead of delayed inode init

2013-08-13 Thread David Herrmann
r what reason?), but I remember Daniel told me that i810 might. Tested with nouveau on x86_64. Signed-off-by: David Herrmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 1 - drivers/gpu/drm/drm_fops.c | 24 +++- driver

[PATCH v2 1/4] anon_inodes: allow external inode allocations

2013-08-13 Thread David Herrmann
mount, we extend it to also provide anonymous inodes for use in drivers like DRM. Signed-off-by: David Herrmann Wanted-by: Daniel Vetter --- fs/anon_inodes.c| 36 +--- include/linux/anon_inodes.h | 1 + 2 files changed, 30 insertions(+), 7 deletions

Re: linux-next: manual merge of the tip tree with the omap_dss2 tree

2013-08-14 Thread David Herrmann
Hi On Wed, Aug 14, 2013 at 6:31 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tip tree got a conflict in > drivers/video/simplefb.c between commit dbb5ff4c2300 ("simplefb: add > support for a8b8g8r8 pixel format") from the omap_dss2 tree and commit > 5ef76da644bf ("fbd

[PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-13 Thread David Herrmann
r pushing and investigating on this. Cc: Jiri Kosina Cc: Anton Vorontsov Cc: David Woodhouse Reported-by: Daniel Nicoletti Signed-off-by: David Herrmann --- Hi I really dislike the way power_supply core calls into the drivers during the "add" uevent. If a driver holds an I/O mutex (o

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-15 Thread David Herrmann
Hi Anton On Tue, May 14, 2013 at 1:20 AM, Anton Vorontsov wrote: > On Mon, May 13, 2013 at 05:01:30PM +0200, David Herrmann wrote: > [..] >> I really dislike the way power_supply core calls into the drivers during the >> "add" uevent. If a driver holds an I/O mutex

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-16 Thread David Herrmann
Hi On Wed, May 15, 2013 at 4:58 PM, David Herrmann wrote: > Hi Anton > > On Tue, May 14, 2013 at 1:20 AM, Anton Vorontsov wrote: >> On Mon, May 13, 2013 at 05:01:30PM +0200, David Herrmann wrote: >> [..] >>> I really dislike the way power_supply core calls into t

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-24 Thread David Herrmann
Hi On Mon, May 13, 2013 at 11:17 PM, Daniel Nicoletti wrote: > 2013/5/13 David Herrmann : >> Anyway, I'd still like to see this patch applied so we have this annoying >> bug fixed. I'd be willing to change the power_supply core, too, if one of the >> maintain

Re: [PATCH v2] video: simplefb: add mode parsing function

2013-05-27 Thread David Herrmann
Hi On Mon, May 27, 2013 at 5:53 AM, Alexandre Courbot wrote: > The naming scheme of simplefb's mode is precise enough to allow building > the mode structure from it instead of using a static list of modes. This > patch introduces a function that does this. In case exotic modes that > cannot be re

Re: [PATCH regression/bisected] Revert "brcmsmac: support 4313iPA"

2013-03-27 Thread David Herrmann
Hi John On Wed, Mar 27, 2013 at 3:56 PM, John W. Linville wrote: > On Tue, Mar 26, 2013 at 10:31:00AM +0100, Piotr Haber wrote: >> On 03/25/13 19:58, John W. Linville wrote: >> > On Mon, Mar 18, 2013 at 02:58:08PM +0100, David Herrmann wrote: >> >> Hi Piotr >>

Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2

2012-08-02 Thread David Herrmann
Hi Shea On Thu, Aug 2, 2012 at 2:45 PM, wrote: > From: Shea Levy > > > Signed-off-by: Shea Levy Why is this patch missing a commit-message? Please add one. And also include the output of "usb-devices" or the contents of /sys/kernel/debug/usb/devices in this commit-message. Regards David > -

Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2

2012-08-02 Thread David Herrmann
Hi Shea On Thu, Aug 2, 2012 at 3:39 PM, Shea Levy wrote: > Hi David, > > On Aug 2, 2012, at 9:32 AM, David Herrmann wrote: > >> Hi Shea >> >> On Thu, Aug 2, 2012 at 2:45 PM, wrote: >>> From: Shea Levy >>> >>> >>> Signed-o

[PATCH v2 3/3] input: evdev: use dynamic-minors if running out of static minors

2012-09-20 Thread David Herrmann
these devices aren't visible, either, so this is no problem at all. Signed-off-by: David Herrmann --- drivers/input/evdev.c | 95 --- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c

[PATCH v2 0/3] input: Dynamic Minor Numbers

2012-09-20 Thread David Herrmann
ding-style issues since version 1 and a NULL-dereference in input_minor_alloc(). Regards David David Herrmann (3): input: add dynamic-minor allocation helpers input: increase INPUT_DEVICES to 512 to allow dynamic minors input: evdev: use dynamic-minors if running out of static minors dri

[PATCH v2 2/3] input: increase INPUT_DEVICES to 512 to allow dynamic minors

2012-09-20 Thread David Herrmann
e and wouldn't loose any performance here. Signed-off-by: David Herrmann --- drivers/input/input.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/input.c b/drivers/input/input.c index 2741ce1..f8d985f 100644 --- a/drivers/input/input.c +++ b/drivers/inp

[PATCH v2 1/3] input: add dynamic-minor allocation helpers

2012-09-20 Thread David Herrmann
might not be visible to old user-space programs that do not use libudev or similar. Signed-off-by: David Herrmann --- drivers/input/input.c | 162 +- include/linux/input.h | 5 ++ 2 files changed, 166 insertions(+), 1 deletion(-) diff --git a

[PATCH 00/11] fblog: Framebuffer kernel log driver v4

2012-08-12 Thread David Herrmann
12/killing-off-config_vt/ I am still looking for someone who is willing to push this to linux-next through his or her tree. Feedback is much appreciated! Thanks David David Herrmann (11): fbcon: move update_attr() into separate source file fbcon: move bit_putcs() into separate source file f

[PATCH 07/11] fblog: allow selecting fbs via sysfs and module-parameters

2012-08-12 Thread David Herrmann
ot;activate_on_hotplug" is false. Otherwise, if this is true then only fb0 will be activated on hotplug. This is false by default. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(

[PATCH 09/11] fblog: register console driver

2012-08-12 Thread David Herrmann
object. We destroy the buffer during close() so we do not waste memory if it is not used. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 150 ++ 1 file changed, 150 insertions(+) diff --git a/drivers/video/console/fblog.c b/drivers/video

[PATCH 11/11] MAINTAINERS: add fblog entry

2012-08-12 Thread David Herrmann
Add myself as maintainer for the fblog driver to the MAINTAINERS file. Signed-off-by: David Herrmann --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 375b1fd..40a10b54 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2895,6 +2895,12 @@ F

[PATCH 10/11] fblog: draw console to framebuffers

2012-08-12 Thread David Herrmann
If not disabled or suspended, we now blit the console data to each framebuffer. We only redraw on changes to avoid consuming too much CPU power. This isn't optimized for speed, currently. However, fblog is mainly used for debugging purposes so this can be optimized later. Signed-off-by:

[PATCH 08/11] fblog: cache framebuffer BLANK and SUSPEND states

2012-08-12 Thread David Herrmann
We must cache these states so we will never draw to the framebuffer while it is suspended or blanked. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/video/console/fblog.c b

[PATCH 02/11] fbcon: move bit_putcs() into separate source file

2012-08-12 Thread David Herrmann
er platforms we can add the buffer to the vc-struct so we can reuse it. Signed-off-by: David Herrmann --- drivers/video/console/bitblit.c | 127 drivers/video/console/fbdraw.c | 125 +++ drivers/video/console/fbdraw

[PATCH 01/11] fbcon: move update_attr() into separate source file

2012-08-12 Thread David Herrmann
ntend to use them in the coming code so there is no need to split them off. Signed-off-by: David Herrmann --- drivers/video/console/Makefile | 3 ++- drivers/video/console/bitblit.c | 26 +++ drivers/video/console/fbcon.h | 5 + drivers/video/console/fbdraw.c

[PATCH 06/11] fblog: open fb on registration

2012-08-12 Thread David Herrmann
lock it _after_ taking the fblog_registration_lock. Therefore, we require the caller to make sure the fb-mutex is held. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 94 ++- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a

[PATCH 05/11] fblog: register one fblog object per framebuffer

2012-08-12 Thread David Herrmann
dies and leave it alone. When the last reference is dropped, it will be automatically freed. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 195 ++ 1 file changed, 195 insertions(+) diff --git a/drivers/video/console/fblog.c b/drivers/

[PATCH 03/11] fblog: new framebuffer kernel log dummy driver

2012-08-12 Thread David Herrmann
font and fb functions I placed it in drivers/video/console. However, this means that we need to move the check for CONFIG_VT in Makefile/Kconfig from drivers/video into drivers/video/console as fblog does not depend on CONFIG_VT. Signed-off-by: David Herrmann --- drivers/video/Kconfig | 5

[PATCH 04/11] fbdev: export get_fb_info()/put_fb_info()

2012-08-12 Thread David Herrmann
When adding other internal users of the framebuffer subsystem, we need a way to get references to framebuffers. These two functions already exist so export them. Signed-off-by: David Herrmann --- drivers/video/fbmem.c | 6 -- include/linux/fb.h| 3 +++ 2 files changed, 7 insertions

Re: [PATCH 03/11] fblog: new framebuffer kernel log dummy driver

2012-08-14 Thread David Herrmann
Hi Ryan On Mon, Aug 13, 2012 at 1:34 AM, Ryan Mallon wrote: > > config VGA_CONSOLE > > bool "VGA text console" if EXPERT || !X86 > > - depends on !4xx && !8xx && !SPARC && !M68K && !PARISC && !FRV && > > !SUPERH && !BLACKFIN && !AVR32 && !MN10300 && (!ARM || ARCH_FOOTBRIDGE || > > ARCH

Re: [PATCH 05/11] fblog: register one fblog object per framebuffer

2012-08-14 Thread David Herrmann
Hi Ryan On Mon, Aug 13, 2012 at 1:54 AM, Ryan Mallon wrote: > On 13/08/12 00:53, David Herrmann wrote: >> drivers/video/console/fblog.c | 195 >> ++ >> 1 file changed, 195 insertions(+) >> >> diff --git a/drivers/vide

Re: [PATCH 06/11] fblog: open fb on registration

2012-08-14 Thread David Herrmann
Hi Ryan On Mon, Aug 13, 2012 at 2:00 AM, Ryan Mallon wrote: > On 13/08/12 00:53, David Herrmann wrote: >> /* >> + * fblog_open/close() >> + * These functions manage access to the underlying framebuffer. While >> opened, we >> + * have a valid reference to

Re: [PATCH 07/11] fblog: allow selecting fbs via sysfs and module-parameters

2012-08-14 Thread David Herrmann
Hi Ryan On Mon, Aug 13, 2012 at 2:04 AM, Ryan Mallon wrote: > On 13/08/12 00:53, David Herrmann wrote: >> +static ssize_t fblog_dev_active_show(struct device *dev, >> + struct device_attribute *attr, >> +

Re: [PATCH v2 04/11] fbdev: export get_fb_info()/put_fb_info()

2012-07-09 Thread David Herrmann
Hi Geert On Mon, Jul 9, 2012 at 9:34 AM, Geert Uytterhoeven wrote: > On Sun, Jul 8, 2012 at 11:56 PM, David Herrmann > wrote: >> --- a/drivers/video/fbmem.c >> +++ b/drivers/video/fbmem.c >> @@ -46,7 +46,7 @@ static DEFINE_MUTEX(registration_lock); >> struct

Re: [PATCH v2 05/11] fblog: register one fblog object per framebuffer

2012-07-09 Thread David Herrmann
Hi Joe On Mon, Jul 9, 2012 at 12:13 AM, Joe Perches wrote: > On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote: >> > > Hi David. Trivial comments only: > >> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c > [] >> @@ -23,15 +23,

Re: [PATCH v2 09/11] fblog: register console driver

2012-07-09 Thread David Herrmann
Hi Joe On Mon, Jul 9, 2012 at 12:09 AM, Joe Perches wrote: > On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote: >> We want to print the kernel log to all FBs so we need a console driver. >> This registers the driver on startup and writes all messages to all >> regis

Re: [PATCH v2 11/11] MAINTAINERS: add fblog entry

2012-07-09 Thread David Herrmann
Hi Geert On Mon, Jul 9, 2012 at 9:33 AM, Geert Uytterhoeven wrote: > On Sun, Jul 8, 2012 at 11:56 PM, David Herrmann > wrote: >> Add myself as maintainer for the fblog driver to the MAINTAINERS file. >> >> Signed-off-by: David Herrmann >> --- >> MAINTAIN

Re: uhid: broken interface: 32/64-bit compatibility

2013-02-15 Thread David Herrmann
Hi Kirill On Fri, Feb 15, 2013 at 12:29 PM, Kirill A. Shutemov wrote: > Hi David and all, > > There's claim in uhid.h that the interface is "compatible even between > architectures". But it obviously is not true: struct uhid_create_req > contains pointer which breaks everything. > > The easy way

[PATCH 1/9] video: introduce system framebuffer bus

2013-02-17 Thread David Herrmann
From: David Herrmann For a long time now we have the problem that there are multiple drivers available that try to use system framebuffers (like EFI, VESA/VBE, ...). There is no way to control which driver gets access to the devices, but instead works on a first-come-first-serve basis

[PATCH 4/9] video: vesafb: allow building as module

2013-02-17 Thread David Herrmann
From: David Herrmann Fix the vesafb module to no longer use any static __init data. Also add a module_exit() function that destroys the platform device. Note that fbdev hotplugging is broken and the self-reference actually prevents sane module-unloading. Anyway, this at least allows delayed

[PATCH 6/9] drm: new sysfb DRM bus module

2013-02-17 Thread David Herrmann
This provides a new DRM bus helper for the system framebuffer bus. It is very similar in its functionality to the DRM_USB helper. It allows to write DRM drivers that register as SYSFB drivers to the system. Signed-off-by: David Herrmann --- drivers/gpu/drm/Kconfig | 5 ++ drivers/gpu/drm

[PATCH 7/9] drm: new VESA BIOS Extension DRM driver stub

2013-02-17 Thread David Herrmann
into the framebuffer. All buffer objects are backed by shmem so we can later add PRIME support. Signed-off-by: David Herrmann --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/dvbe/Kconfig | 28 +++ drivers/gpu/drm/dvbe/Makefile| 4

[PATCH 8/9] drm: dvbe: implement VBE/VESA blitting backend

2013-02-17 Thread David Herrmann
pixel from the user's buffer format into the target format while blitting. Fast-paths for xrgb32/etc. could be implemented if we want to improve blitting performance. Signed-off-by: David Herrmann --- drivers/gpu/drm/dvbe/Kconfig | 1 + drivers/gpu/drm/dvbe/Makefile| 2 +- dr

[PATCH 9/9] drm: dvbe: add optional fbdev frontend

2013-02-17 Thread David Herrmann
. Signed-off-by: David Herrmann --- drivers/gpu/drm/dvbe/Kconfig | 18 +++ drivers/gpu/drm/dvbe/Makefile | 1 + drivers/gpu/drm/dvbe/dvbe.h | 23 drivers/gpu/drm/dvbe/dvbe_fbdev.c | 235 ++ drivers/gpu/drm/dvbe/dvbe_main.c | 2 + 5 files

[PATCH 5/9] video: vesafb: use sysfb bus

2013-02-17 Thread David Herrmann
because the sysfb bus provides all devices now. Signed-off-by: David Herrmann --- drivers/video/Kconfig | 1 + drivers/video/vesafb.c | 49 +++-- 2 files changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig

[PATCH 3/9] video: sysfb: always provide vbefb device

2013-02-17 Thread David Herrmann
From: David Herrmann HACK: This should be provided by architecture setup code. But to show how it is supposed to work, we now simply add a "vbefb" device during initialization. The better way to do this is by moving this into arch-code. So for instance the x86 boot initialization sho

[PATCH 0/9] System Framebuffer Bus (sysfb)

2013-02-17 Thread David Herrmann
to see the system-framebuffer platform-devices being registered during architecture initialization. I haven't worked much there so any comments are welcome. Otherwise, I will keep the HACK to add the devices during sysfb module-init. Regards David David Herrmann (9): video: introduce syste

[PATCH 2/9] video: sysfb: new vbefb device type

2013-02-17 Thread David Herrmann
From: David Herrmann This adds the VESA BIOS Extension (VBE) device type. Platform code needs to provide the "vbefb" platform-device with a screen_info structure as platform code. All drivers that depend on VBE can now register as bus drivers and bind to SYSFB_VBE devices. T

Re: [PATCH 0/9] System Framebuffer Bus (sysfb)

2013-02-17 Thread David Herrmann
Hi Dave On Sun, Feb 17, 2013 at 11:02 PM, Dave Airlie wrote: >> >> This series tries to fix the mess with global system framebuffer access in >> device drivers. Currently, architecture initialization sets the "screen_info" >> object according to the system framebuffer that was detected during boo

[PATCH v2 00/11] fblog: framebuffer kernel log driver

2012-07-08 Thread David Herrmann
kernel and make it much smaller. In combination with user-space terminals like "kmscon" there is actually no need for in-kernel terminals anymore. This patchset is built based on linux-next as I have no idea whose tree this is going through. Feedback is appreciated. Regards David David He

[PATCH v2 01/11] fbcon: move update_attr() into separate source file

2012-07-08 Thread David Herrmann
ntend to use them in the coming code so there is no need to split them off. Signed-off-by: David Herrmann --- drivers/video/console/Makefile | 3 ++- drivers/video/console/bitblit.c | 26 +++ drivers/video/console/fbcon.h | 5 + drivers/video/console/fbdraw.c

[PATCH v2 04/11] fbdev: export get_fb_info()/put_fb_info()

2012-07-08 Thread David Herrmann
When adding other internal users of the framebuffer subsystem, we need a way to get references to framebuffers. These two functions already exist so export them. Signed-off-by: David Herrmann --- drivers/video/fbmem.c | 6 -- include/linux/fb.h| 3 +++ 2 files changed, 7 insertions

[PATCH v2 09/11] fblog: register console driver

2012-07-08 Thread David Herrmann
object. We destroy the buffer during close() so we do not waste memory if it is not used. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 150 ++ 1 file changed, 150 insertions(+) diff --git a/drivers/video/console/fblog.c b/drivers/video

[PATCH v2 10/11] fblog: draw console to framebuffers

2012-07-08 Thread David Herrmann
If not disabled or suspended, we now blit the console data to each framebuffer. We only redraw on changes to avoid consuming too much CPU power. This isn't optimized for speed, currently. However, fblog is mainly used for debugging purposes so this can be optimized later. Signed-off-by:

[PATCH v2 11/11] MAINTAINERS: add fblog entry

2012-07-08 Thread David Herrmann
Add myself as maintainer for the fblog driver to the MAINTAINERS file. Signed-off-by: David Herrmann --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ae8fe46..249b02a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2854,6 +2854,12 @@ F

[PATCH v2 06/11] fblog: open fb on registration

2012-07-08 Thread David Herrmann
without it. We cannot release it in the notifier as this might confuse other registered callbacks if they actually depend on the lock to be continously held (such a callback is currently no available in the kernel, but may be added some time later). Signed-off-by: David Herrmann --- drivers

[PATCH v2 07/11] fblog: allow selecting fbs via sysfs

2012-07-08 Thread David Herrmann
ting it opens/closes the framebuffer. This allows runtime control which fbs are used. For instance, init can set these to 0 after bootup. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 50 ++- 1 file changed, 49 insertions(+), 1 delet

[PATCH v2 08/11] fblog: cache framebuffer BLANK and SUSPEND states

2012-07-08 Thread David Herrmann
We must cache these states so we will never draw to the framebuffer while it is suspended or blanked. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/video/console/fblog.c b

[PATCH v2 05/11] fblog: register one fblog object per framebuffer

2012-07-08 Thread David Herrmann
dies and leave it alone. When the last reference is dropped, it will be automatically freed. Signed-off-by: David Herrmann --- drivers/video/console/fblog.c | 189 ++ 1 file changed, 189 insertions(+) diff --git a/drivers/video/console/fblog.c b/drivers/

[PATCH v2 02/11] fbcon: move bit_putcs() into separate source file

2012-07-08 Thread David Herrmann
er platforms we can add the buffer to the vc-struct so we can reuse it. Signed-off-by: David Herrmann --- drivers/video/console/bitblit.c | 127 drivers/video/console/fbdraw.c | 125 +++ drivers/video/console/fbdraw

[PATCH v2 03/11] fblog: new framebuffer kernel log dummy driver

2012-07-08 Thread David Herrmann
font and fb functions I placed it in drivers/video/console. However, this means that we need to move the check for CONFIG_VT in Makefile/Kconfig from drivers/video into drivers/video/console as fblog does not depend on CONFIG_VT. Signed-off-by: David Herrmann --- drivers/video/Kconfig | 5

Re: drm: NULL pointer dereference in drm_mode_object_find()

2016-09-20 Thread David Herrmann
Hi On Mon, Sep 5, 2016 at 10:30 AM, Dmitry Vyukov wrote: > On Fri, Aug 19, 2016 at 7:10 PM, Alexander Potapenko > wrote: >> Hello, >> >> the program below triggers a NULL deref in DRM code when ran on QEMU: >> >> === >> BUG: unable to handle kerne

Re: drm: NULL pointer dereference in drm_mode_object_find()

2016-09-21 Thread David Herrmann
Hi On Tue, Sep 20, 2016 at 11:25 AM, Alexander Potapenko wrote: > On Tue, Sep 20, 2016 at 11:21 AM, David Herrmann > wrote: >> Hi >> >> On Mon, Sep 5, 2016 at 10:30 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 19, 2016 at 7:10 PM, Alexander Potapenko >>>

Re: drm: NULL pointer dereference in drm_mode_object_find()

2016-09-21 Thread David Herrmann
Hi On Fri, Aug 19, 2016 at 7:10 PM, Alexander Potapenko wrote: > Hello, > > the program below triggers a NULL deref in DRM code when ran on QEMU: > > === > BUG: unable to handle kernel NULL pointer dereference at (null) > IP: [< inline

Re: [PATCH v4 3/5] drm: add SimpleDRM driver

2016-09-01 Thread David Herrmann
. > diff --git a/drivers/gpu/drm/simpledrm/Makefile > b/drivers/gpu/drm/simpledrm/Makefile > new file mode 100644 > index 000..f6a62dc > --- /dev/null > +++ b/drivers/gpu/drm/simpledrm/Makefile > @@ -0,0 +1,4 @@ > +simpledrm-y := simpledrm_drv.o simpledrm_kms.o simpledr

Re: drm: WARNING in ioremap_wc

2016-09-02 Thread David Herrmann
Hey On Fri, Sep 2, 2016 at 2:23 PM, Dmitry Vyukov wrote: > On Mon, Aug 29, 2016 at 8:05 AM, Daniel Vetter wrote: >> On Sun, Aug 28, 2016 at 07:36:59PM +0200, Dmitry Vyukov wrote: >>> Hello, >>> >>> The following program triggers WARNING in ioremap_wc: >> >> Yup, that should also be fixed in linu

Re: [PATCH 0/2] drm: add SimpleDRM driver

2016-08-04 Thread David Herrmann
Hi On Thu, Aug 4, 2016 at 5:34 PM, Luc Verhaegen wrote: > Do we really want to recreate a 400+ email thread again, or are we > capable of learning from the past? No we don't. And no-one intends to. I am fully aware of the discussion that introduced the clock-dependencies to simplefb, and I gladl

Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-03 Thread David Herrmann
ke a wrong thing to do because it basically induces >> > unpredictable latency to the call because draining is not for free >> > (especially on larger machines with many cpus). >> > >> > Let's simply drop the call to lru_add_drain_all to address both issues. >> >

Re: [PATCH 4/6] hugetlbfs: implement memfd sealing

2017-11-03 Thread David Herrmann
Hi On Tue, Oct 31, 2017 at 7:40 PM, Marc-André Lureau wrote: > Implements memfd sealing, similar to shmem: > - WRITE: deny fallocate(PUNCH_HOLE). mmap() write is denied in > memfd_add_seals(). write() doesn't exist for hugetlbfs. > - SHRINK: added similar check as shmem_setattr() > - GROW: adde

Re: [PATCH 4/6] hugetlbfs: implement memfd sealing

2017-11-03 Thread David Herrmann
Hi On Fri, Nov 3, 2017 at 6:12 PM, Mike Kravetz wrote: > On 11/03/2017 10:03 AM, David Herrmann wrote: >> Hi >> >> On Tue, Oct 31, 2017 at 7:40 PM, Marc-André Lureau >> wrote: >>> Implements memfd sealing, similar to shmem: >>> - WRITE: deny fal

Re: [PATCH 4/6] hugetlbfs: implement memfd sealing

2017-11-05 Thread David Herrmann
Hi On Sat, Nov 4, 2017 at 12:31 AM, Mike Kravetz wrote: > On 11/03/2017 10:56 AM, Mike Kravetz wrote: >> On 11/03/2017 10:41 AM, David Herrmann wrote: >>> Hi >>> >>> On Fri, Nov 3, 2017 at 6:12 PM, Mike Kravetz >>> wrote: >>>&g

Re: kdbus_proc_permission (Re: [GIT PULL] kdbus updates for Greg)

2015-08-31 Thread David Herrmann
Hi On Mon, Aug 31, 2015 at 5:37 PM, Andy Lutomirski wrote: > On Mon, Aug 24, 2015 at 2:52 AM, David Herrmann wrote: >> On Mon, Aug 10, 2015 at 4:42 AM, Andy Lutomirski wrote: >>> I haven't checked the context in which it's used, but in order for >>> kdbus

Re: [PATCH 01/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

2015-09-08 Thread David Herrmann
> > Signed-off-by: Paul Osmialowski > --- > ipc/kdbus/metadata.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: David Herrmann Thanks David > diff --git a/ipc/kdbus/metadata.h b/ipc/kdbus/metadata.h > index dba7cc7..3f9ba38 100644 > --- a/ipc/kdbus/metadata.h

[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2015-10-21 Thread David Herrmann
are supported by the i915 driver just fine. Downgrade the error message to a normal pr_info() and stop telling people to report it to IBM. Signed-off-by: David Herrmann --- drivers/platform/x86/thinkpad_acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform

[PATCH 0/3] Introduce inotify_update_watch(2)

2015-09-03 Thread David Herrmann
implements inotify_update_watch() to extend the inotify API with a way to explicity modify watch-descriptors, instead of going via the file-system path-API of inotify_add_watch(). Thanks David David Herrmann (3): inotify: move wd lookup out of update_existing_watch() inotify: add inotify_update_watch

[PATCH 1/3] inotify: move wd lookup out of update_existing_watch()

2015-09-03 Thread David Herrmann
Currently, inotify_update_existing_watch() first looks up the requested wd before modifying it. This makes the function unsuitable for cases where we already know the wd. Change the behavior to directly accept wd as input and make the only caller do the lookup themself. Signed-off-by: David

[PATCH 2/3] inotify: add inotify_update_watch() syscall

2015-09-03 Thread David Herrmann
ORMING TO This system call is Linux-specific. SEE ALSO inotify(7), inotify_init(2), inotify_add_watch(2), inotify_rm_watch(2) Signed-off-by: David Herrmann --- arch/x86/entry/syscalls/syscall_32.tbl | 1 + arch/x86/entry/syscalls/syscall_64.tbl | 1 + fs/notify/inotify/inotify_user.c | 37

<    1   2   3   4   5   6   7   8   9   >