Re: [build bug] ./net/rxrpc/ar-key.c fails to build

2007-11-22 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: on the latest kernel (2.6.24-rc3-git1) the attached config triggers the following build error: net/built-in.o: In function `rxrpc_destroy_s': ar-key.c:(.text+0x9c50d): undefined reference to `crypto_free_tfm' net/built-in.o: In function

[PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-28 Thread David Howells
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO. Signed-off-by: David Howells [EMAIL PROTECTED] --- net/rxrpc/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig index e662f1d..0d3103c 100644 --- a/net

Re: nommu: Add new vmalloc_user() and remap_vmalloc_range() interfaces.

2007-11-28 Thread David Howells
permit the remap or not, which means that we also have to rework the vmalloc_user() code to grovel for the VMA and set the flag. Acked-by: David Howells [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-28 Thread David Howells
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO. Signed-off-by: David Howells [EMAIL PROTECTED] --- net/rxrpc/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig index e662f1d..0d3103c 100644 --- a/net

Re: How to manage shared persistent local caching (FS-Cache) with NFS?

2007-12-07 Thread David Howells
Chuck Lever [EMAIL PROTECTED] wrote: Why not encode the local mounted-on directory in the key? Can't. Namespaces. chroot. Meaning your cache is at quota all the time, and to continue operation it must eject items constantly. I've thought about that, thank you. Go and read the

Re: [PATCH 5/7] Security: Change current-fs[ug]id to current_fs[ug]id()

2007-12-07 Thread David Howells
Serge E. Hallyn [EMAIL PROTECTED] wrote: Could you resend patch 6? As I said in the cover note: A tarball of the patches is available at: http://people.redhat.com/~dhowells/fscache/patches/nfs+fscache-25.tar.bz2 David -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-10 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: + tsec-create_sid = SECINITSID_UNLABELED; + tsec-keycreate_sid = SECINITSID_UNLABELED; + tsec-sockcreate_sid = SECINITSID_UNLABELED; Cleared means what? Setting to 0? Or is there some other constant I should use for that? David -- To

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-10 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: Otherwise, only other issue I have with this interface is it won't generalize to dealing with nfsd, where we want to set the acting context to a context we obtain from or determine based upon the client. Are you speaking of security_kernel_act_as() and

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-10 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: From a config file whose pathname would be provided by libselinux (ala the way in which dbusd imports contexts), or directly as a context returned by a libselinux function. That sounds too SELinux specific. How do I do it so that it works for any LSM?

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-10 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: That happens to me when interfaces are described in SELinux terms. I still don't care much for multiple contexts, and I don't have a good grasp of how you'll deal with Smack, or any LSM other than SELinux. Me neither. I understand SELinux somewhat,

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-11 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: That sounds too SELinux specific. How do I do it so that it works for any LSM? You can't. There is no LSM for userspace; LSM specifically disavowed any common userspace API, and that was one of our original objections/concerns about it. So,

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-11 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: All your code has to do is invoke a function provided by libselinux. Calling libselinux means it's a special case for a specific LSM. I think the best way to do this, then, has to be to dlopen the appropriate LSM library. That way I don't need to do

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Karl MacMillan [EMAIL PROTECTED] wrote: That's what I remember as well - I suggested the transition idea and then, after discussion, agreed that it wasn't the best approach. Sigh. Can you tell me then how to do it now? I don't know very much about using SELinux userspace stuff libraries or

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: You may need to have an application, say cachefileselinuxcontext, that will read the current policy and spit out an appropriate value of whatever, but that can be separate and LSM specific without mucking up your basic infrastructure applications.

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: That sounds workable, although I think he will want a more specific hook than security_secctx_to_secid(), or possibly a second hook call, that would not only validate the context but authorize the use of it by the cachefilesd process. And then the

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: What sort of authorization are you thinking of? I would expect that to have been done by cachefileselinuxcontext (or cachefilesspiffylsmcontext) up in userspace. If you're going to rely on userspace applications for policy enforcement they need to be

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: Put the result into /etc/cachefiles.conf. Ewww. Runtime mangling of the configuration. I suppose it doesn't have to be in that file with the rest of the config. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: Yes, but we're talking about writing the configuration information to the kernel, not actually making any access checks with it. I think. What I think we're talking about (and please correct me David if I've stepped into the wrong theatre) is getting

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: This fd selects the particular cache context that a particular instance of a running daemon is using. Yes, but forgive me being slow, I don't see the problem. I mean that it's not particularly sensible to have an auxiliary interface (say a

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: More likely, run it at build time in your .spec file to generate cachefiles.conf, I don't think sticking it in cachefiles.conf is a good idea necessarily. That has to be an administrator modifiable file. Is there a program I could make cachefiles run

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Casey Schaufler [EMAIL PROTECTED] wrote: It would seem to me that security_secctx_to_secid() ought to suffice if the application code was written correctly. That's not quite sufficient as there still needs to be a verification step to make sure the caller is allowed to do this. Be aware that

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-12 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: Have you example code for the security hook you mention? I'm not sure I understand why security_secctx_to_secid() is not sufficient. security_secctx_to_secid() would just validate and map a context string to a secid. Validate as in check it's a

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-13 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: It is just a way of carving up the permission space, typically based on object type, but it can essentially be arbitrary. The check in this case seems specific to cachefiles since it is controlling an operation on the /dev/cachefiles interface that

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-13 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: Yes, we could easily make a simple program that just invokes a libselinux function that in turn grabs the proper context from some context configuration file under /etc/selinux/$SELINUXTYPE/contexts/ and outputs it. Dan can help with that. That

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-13 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: They would correspond with the operations provided by the /dev/cachefiles interface, at the granularity you want to support distinctions to be made. Can this be made simpler by the fact that /dev/cachefiles has its own unique label (cachefiles_dev_t).

Re: [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions [try #2]

2007-12-13 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: Do any of the interfaces allow a task to act on a cache other than one it has created? No. How does the task identify the desired cache? Each file descriptor opened creates one separate cache instance. Any commands sent over that filedescriptor

[PATCH] KEYS: fix macro

2008-01-02 Thread David Howells
From: Sebastian Siewior [EMAIL PROTECTED] Commit 664cceb0093b755739e56572b836a99104ee8a75 changed the parameters of the function make_key_ref(). The macros that are used in case CONFIG_KEY is not defined did not change. Cc: David Howells [EMAIL PROTECTED] Signed-off-by: Sebastian Siewior [EMAIL

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2008-01-02 Thread David Howells
James Morris [EMAIL PROTECTED] wrote: I suspect it may be useful ensure all global identifiers for the key subsystem are prefixed with key_, as 'copy_keys' does seem a little generic. Many of the fork helpers are called copy_xxx(). David -- To unsubscribe from this list: send the line

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-02 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: Then make a PG_private2 bit and use that. To what end? Are you suggesting I should have: PG_private2 = PG_private | PG_fscache That's redundant information and doesn't help anything really. My suggestion (PG_private and PG_fscache separate and

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-04 Thread David Howells
: David Howells [EMAIL PROTECTED] Add some more fixes to ISOFS error handling on top of Al Viro's patch: (1) Use IS_ERR() rather than ERR_PTR() to test for errors. (2) Return the error from isofs_iget() in parse_rock_ridge_inode_internal(). (3) In isofs_export_get_parent() return -ENOMEM

Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1)

2008-01-04 Thread David Howells
Al Viro [EMAIL PROTECTED] wrote: My apologies, should've had coffee before posting. Me too, probably. FWIW, this patch pile is getting ridiculous - it's what, original + 2 fixes in -mm + mine + this one? Could you post the updated patch with all fixes and fixes to fixes folded into it? I

[PATCH] Fix pointer mismatches in proc_sysctl.c

2007-10-25 Thread David Howells
Fix pointer mismatches in proc_sysctl.c. The proc_handler() method returns a size_t through an arg pointer, but is given a pointer to a ssize_t to return into. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/proc/proc_sysctl.c |6 -- 1 files changed, 4 insertions(+), 2 deletions

[PATCH 00/31] Remove iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Here's a set of patches that remove all calls to iget() and all read_inode() functions. They should be removed for two reasons: firstly they don't lend themselves to good error handling, and secondly their presence is a temptation for code outside a filesystem to call iget() to access inodes

[PATCH 01/31] Add an ERR_CAST() macro to complement ERR_PTR and co. [try #5]

2007-10-25 Thread David Howells
Add an ERR_CAST() macro to complement ERR_PTR and co. for the purposes of casting an error entyped as one pointer type to an error of another pointer type whilst making it explicit as to what is going on. This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct. Signed-off-by: David

[PATCH 02/31] Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) [try #5]

2007-10-25 Thread David Howells
Convert instances of ERR_PTR(PTR_ERR(p)) to ERR_CAST(p) using: perl -spi -e 's/ERR_PTR[(]PTR_ERR[(](.*)[)][)]/ERR_CAST(\1)/' `grep -rl 'ERR_PTR[(]*PTR_ERR' fs crypto net security` Signed-off-by: David Howells [EMAIL PROTECTED] --- crypto/cbc.c |2 +- crypto/cryptd.c

[PATCH 03/31] IGET: Introduce a function to register iget failure [try #5]

2007-10-25 Thread David Howells
Introduce a function to register failure in an inode construction path. This includes marking the inode under construction as bad, unlocking it and releasing it. Signed-off-by: David Howells [EMAIL PROTECTED] --- Documentation/filesystems/porting | 18 +- fs/bad_inode.c

[PATCH 04/31] IGET: Use iget_failed() in AFS [try #5]

2007-10-25 Thread David Howells
Use iget_failed() in AFS to kill a failed inode. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/afs/inode.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/fs/afs/inode.c b/fs/afs/inode.c index d196840..ca9b02f 100644 --- a/fs/afs/inode.c +++ b/fs/afs/inode.c

[PATCH 05/31] IGET: Use iget_failed() in GFS2 [try #5]

2007-10-25 Thread David Howells
Use iget_failed() in GFS2 to kill a failed inode. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/gfs2/inode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 5f6dc32..c5285e2 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2

[PATCH 06/31] IGET: Stop AFFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/affs/affs.h |2 +- fs/affs/amigaffs.c |6 -- fs/affs/inode.c| 20 +--- fs/affs/namei.c| 10 -- fs/affs/super.c| 12

[PATCH 07/31] IGET: Stop autofs from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the autofs filesystem from using iget() and read_inode(). Replace autofs_read_inode() with autofs_iget(), and call that instead of iget(). autofs_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an error. Signed-off-by: David

[PATCH 08/31] IGET: Stop BEFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Will Dyson [EMAIL PROTECTED] --- fs/befs/linuxvfs.c | 39 +-- 1 files changed, 25 insertions(+), 14 deletions(-) diff --git a/fs/befs/linuxvfs.c

[PATCH 09/31] IGET: Stop BFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/bfs/bfs.h |2 ++ fs/bfs/dir.c |6 +++--- fs/bfs/inode.c | 32 ++-- 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/fs/bfs/bfs.h b/fs

[PATCH 10/31] IGET: Stop CIFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
error incurred when getting the root inode instead of ENOMEM. cifs_iget() needs examining. The comment can not call macro FreeXid here since in a void func is no longer true. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/cifs/cifsfs.c |8 fs/cifs/cifsfs.h |1 + fs/cifs

[PATCH 11/31] IGET: Stop EFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EACCES. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/efs/inode.c | 25 + fs/efs/namei.c | 25 + fs/efs/super.c | 18 -- include/linux/efs_fs.h |2

[PATCH 12/31] IGET: Stop EXT2 from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Theodore Ts'o [EMAIL PROTECTED] --- fs/ext2/ext2.h |2 +- fs/ext2/inode.c | 29 + fs/ext2/namei.c | 12 ++-- fs/ext2/super.c | 32

[PATCH 13/31] IGET: Stop EXT3 from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Theodore Ts'o [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/ext3/ialloc.c| 58 --- fs/ext3/inode.c | 25

[PATCH 14/31] IGET: Stop EXT4 from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Theodore Ts'o [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/ext4/ialloc.c| 58 --- fs/ext4/inode.c | 25

[PATCH 19/31] IGET: Stop ISOFS from using read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the ISOFS filesystem from using read_inode(). Make isofs_read_inode() return an error code, and make isofs_iget() pass it on. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/isofs/inode.c | 25 + 1 files changed, 17 insertions(+), 8 deletions(-) diff --git

[PATCH 15/31] IGET: Stop FAT from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the FAT filesystem from using iget() and read_inode(). Replace the call to iget() with a call to ilookup(). Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/fat/inode.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index

[PATCH 20/31] IGET: Stop JFFS2 from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
any error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/jffs2/dir.c |6 +++-- fs/jffs2/fs.c | 56 --- fs/jffs2/os-linux.h |2 +- fs/jffs2/super.c|1 - 4

[PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/freevxfs/vxfs_extern.h |2 +- fs/freevxfs/vxfs_inode.c | 45 + fs/freevxfs/vxfs_lookup.c |6 +++--- fs/freevxfs/vxfs_super.c

[PATCH 21/31] IGET: Stop JFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Dave Kleikamp [EMAIL PROTECTED] --- fs/jfs/inode.c | 20 fs/jfs/jfs_inode.h |2 +- fs/jfs/namei.c | 34 ++ fs/jfs

[PATCH 22/31] IGET: Stop the MINIX filesystem from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/minix/inode.c | 43 +-- fs/minix/minix.h |1 + fs/minix/namei.c |7 +++ 3 files changed, 33 insertions(+), 18 deletions

[PATCH 18/31] IGET: Stop HFSPLUS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
() returns any error incurred when getting the root inode. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/hfsplus/btree.c |6 -- fs/hfsplus/dir.c|6 +++--- fs/hfsplus/hfsplus_fs.h |3 +++ fs/hfsplus/super.c | 47

[PATCH 17/31] IGET: Stop FUSE from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the FUSE filesystem from using read_inode(), which it doesn't use anyway. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/fuse/inode.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 9a68d69..e50be15 100644

[PATCH 25/31] IGET: Stop ROMFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/romfs/inode.c | 45 +++-- 1 files changed, 31 insertions(+), 14 deletions(-) diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c index

[PATCH 24/31] IGET: Stop QNX4 from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/qnx4/inode.c | 45 ++--- fs/qnx4/namei.c |8 +--- include/linux/qnx4_fs.h |1 + 3 files changed, 36 insertions

[PATCH 26/31] IGET: Stop the SYSV filesystem from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the SYSV filesystem from using iget() and read_inode(). Replace sysv_read_inode() with sysv_iget(), and call that instead of iget(). sysv_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an error. Signed-off-by: David Howells [EMAIL

[PATCH 27/31] IGET: Stop UFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/ufs/inode.c | 34 -- fs/ufs/namei.c |6 +++--- fs/ufs/super.c | 14 +- fs/ufs/ufs.h |2 +- 4 files changed, 33 insertions(+), 23

[PATCH 28/31] IGET: Stop OPENPROMFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
. openpromfs_fill_super() returns any error incurred when getting the root inode instead of ENOMEM (not that it currently incurs any other error). Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/openpromfs/inode.c | 45 ++--- 1 files changed, 30 insertions

[PATCH 23/31] IGET: Stop PROCFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
Stop the PROCFS filesystem from using iget() and read_inode(). Merge procfs_read_inode() into procfs_get_inode(), and have that call iget_locked() instead of iget(). Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/proc/inode.c | 60

[PATCH 29/31] IGET: Stop HOSTFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
with inode number 0 - which forms the lookup key. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/hostfs/hostfs_kern.c | 59 +++ 1 files changed, 39 insertions(+), 20 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index

[PATCH 30/31] IGET: Stop HPPFS from using iget() and read_inode() [try #5]

2007-10-25 Thread David Howells
if the inode goes away. (*) hppfs_iget() should perhaps subsume init_inode() and hppfs_read_inode(). (*) It would appear that all hppfs inodes are the same inode because iget() was being called with inode number 0, which forms the lookup key. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs

[PATCH 31/31] IGET: Remove iget() and the read_inode() super op as being obsolete [try #5]

2007-10-25 Thread David Howells
)) { ret = PTR_ERR(inode); goto error; } Note that is_bad_inode() does not need to be called. The error returned by thingyfs_iget() should render it unnecessary. Signed-off-by: David Howells [EMAIL PROTECTED] --- Documentation/filesystems/Locking |3

[PATCH] Add an ERR_CAST() function to complement ERR_PTR and co. [try #5.1]

2007-10-25 Thread David Howells
Add an ERR_CAST() function to complement ERR_PTR and co. for the purposes of casting an error entyped as one pointer type to an error of another pointer type whilst making it explicit as to what is going on. This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct. Signed-off-by: David

[PATCH] Add an ERR_CAST() function to complement ERR_PTR and co. [try #5.2]

2007-10-26 Thread David Howells
Add an ERR_CAST() function to complement ERR_PTR and co. for the purposes of casting an error entyped as one pointer type to an error of another pointer type whilst making it explicit as to what is going on. This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct. Signed-off-by: David

[PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel

2007-10-26 Thread David Howells
These patches add the MEI/Panasonic MN10300/AM33 architecture to the Linux kernel. The first patch makes it possible to suppress AOUT support in the ELF binfmt. MN10300 does not support the AOUT binfmt, so the ELF binfmt should not be permitted to go looking for AOUT libraries to load. The

[PATCH 1/2] MN10300: Permit AOUT library support to be suppressed in ELF binfmt

2007-10-26 Thread David Howells
should not be permitted to go looking for AOUT libraries to load. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/Kconfig.binfmt |3 ++- fs/binfmt_elf.c | 30 ++ include/linux/a.out.h |6 ++ 3 files changed, 30 insertions(+), 9 deletions

Re: [PATCH 1/2] MN10300: Permit AOUT library support to be suppressed in ELF binfmt

2007-10-26 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: hm, seems a bit ungainly. Why can't we just make all the aout things in binfmt_elf.c depend upon CONFIG_BINFMT_AOUT? That works too, I guess. I'll change it. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

[PATCH 1/2] MN10300: Suppress AOUT library support in ELF binfmt if !CONFIG_BINFMT_AOUT [try #2]

2007-10-29 Thread David Howells
Suppress AOUT library support in ELF binfmt if CONFIG_BINFMT_AOUT is not set. The MN10300 architecture does not support the AOUT binfmt, so the ELF binfmt should not be permitted to go looking for AOUT libraries to load. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/binfmt_elf.c

[PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #2]

2007-10-29 Thread David Howells
These patches add the MEI/Panasonic MN10300/AM33 architecture to the Linux kernel. The first patch makes it possible to suppress AOUT support in the ELF binfmt. MN10300 does not support the AOUT binfmt, so the ELF binfmt should not be permitted to go looking for AOUT libraries to load. The

Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one

2007-10-29 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: This patch fixes an off-by-one error spotted by the Coverity checker. NAK. Why do you assume it's a NUL-terminated string? It's not. It's a fixed length character array that gets padded out with NULs. Look 9 lines further down in the file from the change

Re: [PATCH] scatterlist fallout: frv

2007-10-29 Thread David Howells
Yeah... I haven't got around to updating FRV yet after the last merge window. Acked-by: David Howells [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: Working frv toolchain?

2007-10-29 Thread David Howells
Jan Dittmer [EMAIL PROTECTED] wrote: With gcc 4.0.0 and binutils 2.15.94 I get: I'm using gcc 4.1.2. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] NOMMU: mm/nommu.c needs linux/module.h

2007-10-29 Thread David Howells
From: David Howells [EMAIL PROTECTED] mm/nommu.c needs to #include linux/module.h for it to understand EXPORT_*() macros. Signed-off-by: David Howells [EMAIL PROTECTED] --- mm/nommu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index 8f09333

Re: [PATCH] FRV: Move DMA macros to scatterlist.h for consistency.

2007-10-29 Thread David Howells
Robert P. J. Day [EMAIL PROTECTED] wrote: To be consistent with other architectures, these two DMA macros should be defined in scatterlist.h as opposed to dma-mapping.h Why have you discarded the comment? David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

[PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode

2007-10-29 Thread David Howells
From: David Howells [EMAIL PROTECTED] Permit the memory to be located somewhere other than address 0xC000 in NOMMU mode. The configuration options are already present, it just requires wiring up in the linker script. Note that only a limited set of locations of runtime addresses

Re: [PATCH] FRV: Move DMA macros to scatterlist.h for consistency.

2007-10-29 Thread David Howells
Robert P. J. Day [EMAIL PROTECTED] wrote: To be consistent with other architectures, these two DMA macros should be defined in scatterlist.h as opposed to dma-mapping.h Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Acked-by: David Howells [EMAIL PROTECTED] - To unsubscribe from

Re: [2.6 patch] fs/afs/vlocation.c: fix off-by-one

2007-10-29 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: Check the last line of the patch I sent: if (vl-vldb.name[namesz] != '\0') Seems I forgotten some of what my own code does:-) Actually, you're right. I added in a gap for the NUL. Okay, I retract my NAK. Consider it ACK'd instead. David - To

Re: [PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode

2007-10-29 Thread David Howells
Linus Torvalds [EMAIL PROTECTED] wrote: Do them in the Kconfig language where it belongs, and where it makes much more sense. That's what I wanted to do, I just didn't realise I could do it. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

[PATCH] FRV: Permit the memory to be located elsewhere in NOMMU mode [try #2]

2007-10-29 Thread David Howells
From: David Howells [EMAIL PROTECTED] Permit the memory to be located somewhere other than address 0xC000 in NOMMU mode. The configuration options are already present, it just requires wiring up in the linker script. Note that only a limited set of locations of runtime addresses

Re: [Linux-am33-list] [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #2]

2007-10-30 Thread David Howells
Suzuki Takashi [EMAIL PROTECTED] wrote: Why don't you use `am33' for the arch name? History and the fact that 'mn10300' is what MEI called their arch when they originally gave us (RH) their kernel. There are kernels already out there running on consumer devices for which it is the mn10300

Re: Working frv toolchain?

2007-10-30 Thread David Howells
Jan Dittmer [EMAIL PROTECTED] wrote: Known bug or toolchain problem? Ah... I'd forgotten about that. I'm not sure all the ASM constraint changes are upstream yet, and gcc bz 28583 also gets incurred. Are you particularly interested in building your own compiler, or would one of ours do?

Re: Working frv toolchain?

2007-10-30 Thread David Howells
David Howells [EMAIL PROTECTED] wrote: Ah... I'd forgotten about that. I'm not sure all the ASM constraint changes are upstream yet, and gcc bz 28583 also gets incurred. Are you particularly interested in building your own compiler, or would one of ours do? Look in: ftp

Re: [Linux-am33-list] [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #2]

2007-10-30 Thread David Howells
Suzuki Takashi [EMAIL PROTECTED] wrote: But the arch name change does not affect running kernels on consumer devices. uname says mn10300. Drastic changes in the directory and file structures will have a much greater impact than that. Like renaming the arch/mn10300 and include/asm-mn10300

Re: [Linux-am33-list] [PATCH 2/2] MN10300: Add the MN10300/AM33 architecture to the kernel [try #2]

2007-10-30 Thread David Howells
Suzuki Takashi [EMAIL PROTECTED] wrote: Does this mean cpu-am33v3, cpu-am33v4, etc. will be created when a new core comes up? Yes. Note that the headers in a later one can 'inherit' from those of an earlier one simply by #including that earlier one, much like archs do with asm-generic

Re: [Linux-am33-list] [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #2]

2007-10-30 Thread David Howells
Suzuki Takashi [EMAIL PROTECTED] wrote: But is there any utility that depends on that uname says mn10300? autoconf:-) I know existing developers should learn the arch name change. But how many developers? I don't know. MEI probably does. That's the point. They must always be told or

Re: [Linux-am33-list] [PATCH 2/2] MN10300: Add the MN10300/AM33 architecture to the kernel [try #2]

2007-10-31 Thread David Howells
Suzuki Takashi [EMAIL PROTECTED] wrote: But people aren't, are they? On the other hand, these particular header files are of interest to arch maintainers. If there are variances between CPUs that mandate different sets of registers or different usage protocols for equivalent modules, then you

[PATCH 03/37] KEYS: Allow the callout data to be passed as a blob rather than a string

2008-02-08 Thread David Howells
() request_key_async() request_key_async_with_auxdata() Signed-off-by: David Howells [EMAIL PROTECTED] --- Documentation/keys-request-key.txt | 11 +--- Documentation/keys.txt | 14 +++--- include/linux/key.h|9 --- security/keys/internal.h

Re: [PATCH 07/37] Security: De-embed task security record from task and use refcounting

2008-02-11 Thread David Howells
James Morris [EMAIL PROTECTED] wrote: Remove the temporarily embedded task security record from task_struct. Instead it is made to dangle from the task_struct::sec and task_struct::act_as pointers with references counted for each. ... These patches are kind of huge. Yeah, I know.

Re: [PATCH 2/4] KEYS: Check starting keyring as part of search

2008-02-13 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: + (keyring-expiry now.tv_sec = keyring-expiry)) time_after()? Possibly. tv_sec oughtn't to wrap, though. I thought time_after() is really for comparing jiffies which might wrap. David -- To unsubscribe from this list: send the line

[PATCH] FRV: Fix up parse error in linker script

2008-02-13 Thread David Howells
Fix up parse error in FRV linker script, presumably introduced through changes to the INIT_TEXT and EXIT_TEXT macros. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/frv/kernel/vmlinux.lds.S |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/frv/kernel

Re: Compiler for mn10300?

2008-02-13 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: How can I get a compiler suitable for mn10300? ftp://ftp.redhat.com/pub/redhat/gnupro/AM33/am33-04r2-5/tools David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Linux-am33-list] Cross-Compiling mn10300: Assembler messages: junk at end of line: 0

2008-02-15 Thread David Howells
Jan Dittmer [EMAIL PROTECTED] wrote: + make ARCH=mn10300 HOSTCC=gcc-4.0 CROSS_COMPILE=mn10300-elf- CROSS32_COMPILE= O=../2.6.25-rc1-mn10300/ Hmmm... There seems to be some confusion somewhere, probably because the documentation there doesn't say which compiler you should use for what. Can

[PATCH 1/2] MN10300: Define HZ as a config option

2008-02-15 Thread David Howells
Define HZ as a config option. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/mn10300/Kconfig|4 include/asm-mn10300/param.h |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/mn10300/Kconfig b/arch/mn10300/Kconfig index eedc3a5..6a6409a

[PATCH 2/2] MN10300: Define SO_MARK

2008-02-15 Thread David Howells
Define SO_MARK for MN10300. Signed-off-by: David Howells [EMAIL PROTECTED] --- include/asm-mn10300/socket.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/asm-mn10300/socket.h b/include/asm-mn10300/socket.h index 99ca648..80af9c4 100644 --- a/include/asm

[PATCH 01/23] KEYS: Rename public key parameter name arrays

2012-10-30 Thread David Howells
Rename the arrays of public key parameters (public key algorithm names, hash algorithm names and ID type names) so that the array name ends in _name. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/public_key.c | 14 +++--- crypto/asymmetric_keys

[PATCH 02/23] KEYS: Move the algorithm pointer array from x509 to public_key.c

2012-10-30 Thread David Howells
Move the public-key algorithm pointer array from x509_public_key.c to public_key.c as it isn't X.509 specific. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/public_key.c |8 crypto/asymmetric_keys/x509_public_key.c | 11 +-- include

[PATCH 06/23] x509: struct x509_certificate needs struct tm declaring

2012-10-30 Thread David Howells
struct x509_certificate needs struct tm declaring by #inclusion of linux/time.h prior to its definition. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/x509_parser.h |1 + 1 file changed, 1 insertion(+) diff --git a/crypto/asymmetric_keys/x509_parser.h b

[PATCH 09/23] X.509: Handle certificates that lack an authorityKeyIdentifier field

2012-10-30 Thread David Howells
Handle certificates that lack an authorityKeyIdentifier field by assuming they're self-signed and checking their signatures against themselves. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/x509_public_key.c |9 + 1 file changed, 5 insertions(+), 4

<    1   2   3   4   5   6   7   8   9   10   >