Stop the PROCFS filesystem from using iget() and read_inode(). Merge
procfs_read_inode() into procfs_get_inode(), and have that call iget_locked()
instead of iget().
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/proc/inode.c | 60
error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/romfs/inode.c | 45 +++--
1 files changed, 31 insertions(+), 14 deletions(-)
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/qnx4/inode.c | 45 ++---
fs/qnx4/namei.c |8 +---
include/linux/qnx4_fs.h |1 +
3 files changed, 36 insertions
Stop the SYSV filesystem from using iget() and read_inode(). Replace
sysv_read_inode() with sysv_iget(), and call that instead of iget().
sysv_iget() then uses iget_locked() directly and returns a proper error code
instead of an inode in the event of an error.
Signed-off-by: David Howells [EMAIL
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ufs/inode.c | 34 --
fs/ufs/namei.c |6 +++---
fs/ufs/super.c | 14 +-
include/linux/ufs_fs.h |2 +-
4 files
.
openpromfs_fill_super() returns any error incurred when getting the root inode
instead of ENOMEM (not that it currently incurs any other error).
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/openpromfs/inode.c | 45 ++---
1 files changed, 30 insertions
with inode number 0 - which forms the lookup key.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/hostfs/hostfs_kern.c | 58 ---
1 files changed, 39 insertions(+), 19 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index
if the inode goes away.
(*) hppfs_iget() should perhaps subsume init_inode() and hppfs_read_inode().
(*) It would appear that all hppfs inodes are the same inode because iget()
was being called with inode number 0, which forms the lookup key.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs
() to find an inode by
number in a filesystem from code outside that filesystem.
iget_locked() should be used instead. A new function is added (iget_failed)
that is to be called to mark an inode as bad, unlock it and release it should
the get routine fail.
Signed-off-by: David Howells [EMAIL
Nick Piggin [EMAIL PROTECTED] wrote:
[ This is true for x86's sfence/lfence, but raises a question about Linux's
memory barriers. Does anybody expect that a sequence of smp_wmb and smp_rmb
would ever provide a full smp_mb barrier? I've always assumed no, but I
don't know if it is actually
Zach Brown [EMAIL PROTECTED] wrote:
/* haha, continuing the fine tradition of terrible names in this api.. */
static inline void *PTR_PTR(void *err_ptr) {
BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
return err_ptr;
}
How about ERR_CAST() instead? Or maybe CAST_ERR()?
Jan Kara [EMAIL PROTECTED] wrote:
Hmm, why don't you use the return value from raw_inode? It can be
either -EIO or -EINVAL if 'ino' was invalid...
Good point. Altered.
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Jan Kara [EMAIL PROTECTED] wrote:
But if you 'goto out' in some branches, we loose the ext3_warning()
which we probably don't want.
Ugh. Okay, I need to rework the changes to that function.
return ERR_PTR(-EACCES);
Wouldn't here -EIO be more appropriate?
I would
Dave Kleikamp [EMAIL PROTECTED] wrote:
Of course, the cast is unnecessary,
The cast is necessary as the argument is a const pointer and the return type
is not.
and I'm sure you meant to return error:
Oops. Yes, I changed my mind and renamed the argument to be 'error', but
forgot to change
Jan Kara [EMAIL PROTECTED] wrote:
Same comments as for ext3 - I think you reversed ext4_test_bit() test
and also the warning won't be issued in some cases which is wrong.
Same replies as for ext3 too. Blech.
You should find altered patches landing in your inbox if you'd care to inspect
Hi Christoph, Al,
Here's a set of patches that remove all calls to iget() and all read_inode()
functions. They should be removed for two reasons: firstly they don't lend
themselves to good error handling, and secondly their presence is a temptation
for code outside a filesystem to call iget()
Introduce a function to register failure in an inode construction path. This
includes marking the inode under construction as bad, unlocking it and
releasing it.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
Documentation/filesystems/porting | 18 +-
fs/bad_inode.c
Convert instances of ERR_PTR(PTR_ERR(p)) to ERR_CAST(p) using:
perl -spi -e 's/ERR_PTR[(]PTR_ERR[(](.*)[)][)]/ERR_CAST(\1)/' `grep -rl
'ERR_PTR[(]*PTR_ERR' fs crypto net security`
Signed-off-by: David Howells [EMAIL PROTECTED]
---
crypto/cbc.c |2 +-
crypto/cryptd.c
Add an ERR_CAST() macro to complement ERR_PTR and co. for the purposes of
casting an error entyped as one pointer type to an error of another pointer
type whilst making it explicit as to what is going on.
This provides a replacement for the ERR_PTR(PTR_ERR(p)) construct.
Signed-off-by: David
Use iget_failed() in GFS2 to kill a failed inode.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/gfs2/inode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 34f7bcd..498844f 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2
Use iget_failed() in AFS to kill a failed inode.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/afs/inode.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index d196840..ca9b02f 100644
--- a/fs/afs/inode.c
+++ b/fs/afs/inode.c
);
if (IS_ERR(inode)) {
ret = PTR_ERR(inode);
goto error;
}
Signed-off-by: David Howells [EMAIL PROTECTED]
---
Documentation/filesystems/Exporting |5 -
Documentation/filesystems/Locking |3 ---
Documentation/filesystems/vfs.txt | 16
Stop the autofs filesystem from using iget() and read_inode(). Replace
autofs_read_inode() with autofs_iget(), and call that instead of iget().
autofs_iget() then uses iget_locked() directly and returns a proper error code
instead of an inode in the event of an error.
Signed-off-by: David
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
Acked-by: Will Dyson [EMAIL PROTECTED]
---
fs/befs/linuxvfs.c | 39 +--
1 files changed, 25 insertions(+), 14 deletions(-)
diff --git a/fs/befs/linuxvfs.c
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/bfs/bfs.h |2 ++
fs/bfs/dir.c |6 +++---
fs/bfs/inode.c | 32 ++--
3 files changed, 27 insertions(+), 13 deletions(-)
diff --git a/fs/bfs/bfs.h b/fs
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/affs/affs.h |2 +-
fs/affs/amigaffs.c |6 --
fs/affs/inode.c| 20 +---
fs/affs/namei.c| 10 --
fs/affs/super.c| 12
error incurred when getting the root inode
instead of ENOMEM.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/cifs/cifsfs.c |8
fs/cifs/cifsfs.h |1 +
fs/cifs/inode.c | 35 ++-
3 files changed, 31 insertions(+), 13 deletions(-)
diff --git
incurred when getting the root inode
instead of EACCES.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/efs/inode.c | 25 +
fs/efs/namei.c | 23 ---
fs/efs/super.c | 18 --
include/linux/efs_fs.h |2
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ext2/ext2.h |2 +-
fs/ext2/inode.c | 30 ++
fs/ext2/namei.c | 12 ++--
fs/ext2/super.c | 32 ++--
4 files
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ext3/ialloc.c| 58 ---
fs/ext3/inode.c | 25 +++-
fs/ext3/namei.c | 29
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ext4/ialloc.c| 58 ---
fs/ext4/inode.c | 25 +++-
fs/ext4/namei.c | 29
Stop the FAT filesystem from using iget() and read_inode(). Replace
the call to iget() with a call to ilookup().
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/fat/inode.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index
error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/freevxfs/vxfs_extern.h |2 +-
fs/freevxfs/vxfs_inode.c | 45 +
fs/freevxfs/vxfs_lookup.c |6 +++---
fs/freevxfs/vxfs_super.c
Stop the FUSE filesystem from using read_inode(), which it doesn't use anyway.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/fuse/inode.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 5448f62..2986654 100644
Stop the ISOFS filesystem from using read_inode(). Make isofs_read_inode()
return an error code, and make isofs_iget() pass it on.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/isofs/inode.c | 25 +
1 files changed, 17 insertions(+), 8 deletions(-)
diff --git
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
Acked-by: Dave Kleikamp [EMAIL PROTECTED]
---
fs/jfs/inode.c | 20
fs/jfs/jfs_inode.h |2 +-
fs/jfs/namei.c | 34 ++
fs/jfs
error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/minix/inode.c | 43 +--
fs/minix/minix.h |1 +
fs/minix/namei.c |7 +++
3 files changed, 33 insertions(+), 18 deletions
Stop the PROCFS filesystem from using iget() and read_inode(). Merge
procfs_read_inode() into procfs_get_inode(), and have that call iget_locked()
instead of iget().
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/proc/inode.c | 60
() returns any error incurred when getting the root inode.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/hfsplus/btree.c |6 --
fs/hfsplus/dir.c|6 +++---
fs/hfsplus/hfsplus_fs.h |3 +++
fs/hfsplus/super.c | 44
4
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/qnx4/inode.c | 45 ++---
fs/qnx4/namei.c |8 +---
include/linux/qnx4_fs.h |1 +
3 files changed, 36 insertions
error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/romfs/inode.c | 45 +++--
1 files changed, 31 insertions(+), 14 deletions(-)
diff --git a/fs/romfs/inode.c b/fs/romfs/inode.c
index
any error incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/jffs2/dir.c |6 +++--
fs/jffs2/fs.c | 56 ---
fs/jffs2/os-linux.h |2 +-
fs/jffs2/super.c|1 -
4
Stop the SYSV filesystem from using iget() and read_inode(). Replace
sysv_read_inode() with sysv_iget(), and call that instead of iget().
sysv_iget() then uses iget_locked() directly and returns a proper error code
instead of an inode in the event of an error.
Signed-off-by: David Howells [EMAIL
incurred when getting the root inode
instead of EINVAL.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ufs/inode.c | 34 --
fs/ufs/namei.c |6 +++---
fs/ufs/super.c | 14 +-
include/linux/ufs_fs.h |2 +-
4 files
.
openpromfs_fill_super() returns any error incurred when getting the root inode
instead of ENOMEM (not that it currently incurs any other error).
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/openpromfs/inode.c | 45 ++---
1 files changed, 30 insertions
if the inode goes away.
(*) hppfs_iget() should perhaps subsume init_inode() and hppfs_read_inode().
(*) It would appear that all hppfs inodes are the same inode because iget()
was being called with inode number 0, which forms the lookup key.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs
with inode number 0 - which forms the lookup key.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/hostfs/hostfs_kern.c | 58 ---
1 files changed, 39 insertions(+), 19 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index
() to find an inode by
number in a filesystem from code outside that filesystem.
iget_locked() should be used instead. A new function is added (iget_failed)
that is to be called to mark an inode as bad, unlock it and release it should
the get routine fail.
Signed-off-by: David Howells [EMAIL
David Howells [EMAIL PROTECTED] wrote:
A tarball of the patches can be retrieved from:
http://people.redhat.com/~dhowells/iget-remove.tar.bz2
I've updated that to actually reflect this set of patches and not the old set.
David
-
To unsubscribe from this list: send the line unsubscribe
David Howells [EMAIL PROTECTED] wrote:
Why do you move it out of line?
Because otherwise every file that gets compiled that includes linux/fs.h will
emit a warning that the implementation of that function is deprecated.
Or, rather, that read_inode() is deprecated.
David
-
To unsubscribe
Christoph Hellwig [EMAIL PROTECTED] wrote:
Why do you move it out of line?
Because otherwise every file that gets compiled that includes linux/fs.h will
emit a warning that the implementation of that function is deprecated.
David
-
To unsubscribe from this list: send the line unsubscribe
Christoph Hellwig [EMAIL PROTECTED] wrote:
I don't like this one very much, I'd rather take the variant Linus
outline in his last post on that topic..
I'd rather not take that variant.
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Sam Ravnborg [EMAIL PROTECTED] wrote:
One like one variant, another like another variant.
Both fails to say why.
It's shorter, more compact, and of course requires the least amount of change
(especially as I can automate it with a command line perl script).
David
-
To unsubscribe from this
Trond Myklebust [EMAIL PROTECTED] wrote:
- the NFSv4 delegation model breaks: the client will be using
OPEN when it could use cached opens. More importantly, when
performing an operation that requires it to return the
delegation on the aliased file, it won't
Bill Davidsen [EMAIL PROTECTED] wrote:
mount /base on point1 - rw[ hopefully really r/w ]
mount /base on point2 - ro[ hopefully r/o ]
I think Al Viro probably has the right idea as to how to fix this: Move the
R/O R/W flag into vfsmount and count the number of R/W vfsmounts in the
Linus Torvalds [EMAIL PROTECTED] wrote:
In other words, let's assume that the user has /some/nfs/mount mounted
over NFS, and wants to re-mount it (or even just a subset of it) somewhere
else, the sane thing to do is not to mount it again, but to just do
What about a superset? What about
Linus Torvalds [EMAIL PROTECTED] wrote:
In other words, let's assume that the user has /some/nfs/mount mounted
over NFS, and wants to re-mount it (or even just a subset of it) somewhere
else, the sane thing to do is not to mount it again, but to just do
That helps one case, yes, but what
From: David Howells [EMAIL PROTECTED]
Make BSG function declarations dependent on CONFIG_BLOCK as they are not
compilable if the block layer is compiled out.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
include/linux/bsg.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff
Bill Davidsen [EMAIL PROTECTED] wrote:
I think Al had a good idea there, that is nice and clean. What about bind
mounts, will that just fall out?
I don't see that it should be a problem since the vfsmount is copied.
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
Ian Kent [EMAIL PROTECTED] wrote:
But what about mounting with different protocol, tcp vs udp for example.
I was referring specifically to the R/O / R/W variants of the same mount. Any
flag variation that varies the way the NFS client talks to the NFS server must
either result in a new
Jens Axboe [EMAIL PROTECTED] wrote:
It's a bit of a sledge hammer... Since get_user_pages() appears to work
on nummu, we can just disable the vmsplice-to-userspace bits and leave
the (working) vmsplice-from-userspace in place.
That sounds about right. I don't think you can do the latter
Jens Axboe [EMAIL PROTECTED] wrote:
It's a bit of a sledge hammer... Since get_user_pages() appears to work
on nummu, we can just disable the vmsplice-to-userspace bits and leave
the (working) vmsplice-from-userspace in place.
That sounds about right. I don't think you can do the
+ *
+ * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved.
+ * Written by David Howells ([EMAIL PROTECTED])
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public Licence
+ * as published by the Free Software Foundation
From: David Howells [EMAIL PROTECTED]
Make it possible to use __start_notes and __stop_notes without getting a GPREL
overflow error from the FRV linker.
Small variables that would otherwise be in .data or .bss may, depending on the
arch, be placed in special sections (.sdata or .sbss
Linus Torvalds [EMAIL PROTECTED] wrote:
I thought we long long since removed the volatiles.
They're certainly still there in i386 and x86_64.
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Linus Torvalds [EMAIL PROTECTED] wrote:
So, using the + constraint modifier for memory, like +m is bogus.
We must simply specify =m which handles the case correctly.
No. This is wrong.
Agreed.
=m means that the new value of the memory location is *set*.
Which means that gcc will
Satyam Sharma [EMAIL PROTECTED] wrote:
OTOH, as per Linus' review it seems we can drop the memory clobber
and specify the output operand for the extended asm as +m. But I
must admit I didn't quite understand that at all.
As I understand it, the +m indicates to the compiler a restriction on
Al Viro [EMAIL PROTECTED] wrote:
Where do you see passing label to assembly? More interesting question
is whether gcc believes it to be const...
Passing labels like that to assembly didn't used to work, which is a pity as
we could speed up things like get_user() if it could be made to.
David
From: David Howells [EMAIL PROTECTED]
Fix the SYSV IPC SHM to work with the changes applied by the new fault handler
patches when CONFIG_MMU=n.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/ramfs/file-nommu.c |7 ++-
ipc/shm.c |2 ++
2 files changed, 8
(), which from my reading
of the code, seems to do what flush_tlb_ptables() does, which is
to clear the cached PGE.
Yeah... I hadn't got around to killing myself yet.
Acked-By: David Howells [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Yoann Padioleau [EMAIL PROTECTED] wrote:
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Can you make them of style:
if (!x)
instead?
Thanks,
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Segher Boessenkool [EMAIL PROTECTED] wrote:
This simply isn't true. The compiler *can* combine asm stuff:
typedef struct { int counter; } atomic_t;
static inline __attribute__((pure)) int atomic_read(const atomic_t *v)
{
int x;
asm(ld %0,@%1 : =r(x) : r(v-counter),
Andreas Gruenbacher [EMAIL PROTECTED] wrote:
dput must be called before mntput here. Please consider for 2.6.24 and stable.
Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED]
Fine by me.
Acked-By: David Howells [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe
From: Andreas Gruenbacher [EMAIL PROTECTED]
dput must be called before mntput here. Please consider for 2.6.24 and stable.
Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED]
Acked-By: David Howells [EMAIL PROTECTED]
---
fs/afs/mntpt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
From: David Howells [EMAIL PROTECTED]
Initialise s_flags in get_sb_mtd_aux() from the flags parameter.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
drivers/mtd/mtdsuper.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd
Casey Schaufler [EMAIL PROTECTED] wrote:
Sigh. So it's not only SELinux specific, but RedHat specific as well.
*Blink*. How did you come to that conclusion?
(3) The cache driver wants to access the files in the cache, but it's
running in the security context of either the
Casey Schaufler [EMAIL PROTECTED] wrote:
I haven't looked into the issues at all and I bet there are plenty,
maybe in audit and places outside of the security realm, but this
looks like a clean approach from the LSM interface standpoint. Do
you want the entire task or just task-security?
It
Stephen Smalley [EMAIL PROTECTED] wrote:
Seems like over-design - we don't need to support LSM stacking, and we
don't need to support pushing/popping more than one level of context.
It will, at some point hopefully, be possible for someone to try, say, NFS
exporting a cached ISO9660 mount
Casey Schaufler [EMAIL PROTECTED] wrote:
(1) int security_get_context(void **_context);
This allocates and gives the caller a blob that describes the current
context of all the LSM module states attached to the current task and
stores a pointer to it in *_context.
Is
Casey Schaufler [EMAIL PROTECTED] wrote:
The specification of your push interface that the push operation
not affect how others access the process is OK for SELinux, but
not for any other MAC scheme that I've dealt with, and I think
that's most of them. Nuts. Smack, for example, uses exactly
Casey Schaufler [EMAIL PROTECTED] wrote:
With Smack you can leave the label alone, raise CAP_MAC_OVERRIDE,
do your business of setting the label correctly, and then drop
the capability. No new hooks required.
That sounds like a contradiction. How can you both leave it alone and set it?
Chris Snook [EMAIL PROTECTED] wrote:
Use volatile consistently in atomic.h on frv.
Acked-By: David Howells [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
Casey Schaufler [EMAIL PROTECTED] wrote:
Whoops, sorry. You leave the process label alone and explicitly
set the file label using the xattr interfaces.
That's the wrong way to do things. There'd then be a window in which
cachefilesd (the userspace daemon) could attempt to view the file when
Hi Linus, Al,
Would you object greatly to functions like vfs_mkdir() gaining a security
parameter? What I'm thinking of is this:
int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode,
struct security *security)
Where the security context is the state
Casey Schaufler [EMAIL PROTECTED] wrote:
Could you describe how this compares to the proposal that the
AppArmor developers suggested recently? I expect that we can
reduce the amount of discussion required, and maybe avoid some
confusion if you could do that.
I don't know what that is.
Herbert Xu [EMAIL PROTECTED] wrote:
Let's turn this around. Can you give a single example where
the volatile semantics is needed in a legitimate way?
Accessing H/W registers? But apart from that...
David
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of
Linus Torvalds [EMAIL PROTECTED] wrote:
Would you object greatly to functions like vfs_mkdir() gaining a security
parameter? What I'm thinking of is this:
...
Why the *hell* would mkdir() be so magical as to need something like that?
If you look again, you'll notice that I said functions
Bernd Schmidt [EMAIL PROTECTED] wrote:
In do_mmap_private, I've commented out the logic to free excess pages, as it
fragments terribly
I wonder if there's a good heuristic for this. The problem is that whilst
not releasing excess pages _may_ seem like a good idea, if your system is
something
David Howells [EMAIL PROTECTED] wrote:
Yes. I found the major leak this morning. There may be a minor leak, but I'm
not convinced it's in the mmap stuff. See revised patch.
Oops. That was the old patch. Try this one instead.
David
[PATCH] NOMMU: Make VMAs per MM as for MMU-mode linux
Bernd Schmidt [EMAIL PROTECTED] wrote:
This probably wants to be dependent on something like MAP_TRIM_EXCESS.
Hmmm... In the interests of not adding more flags, I wonder if mremap()
should be used for that, with a global setting for mmaps made by binfmts as
they can't really be shrunk
order allocation.
David
---
[PATCH] NOMMU: Make VMAs per MM as for MMU-mode linux
From: David Howells [EMAIL PROTECTED]
Make VMAs per mm_struct as for MMU-mode linux. This solves the nattch problem
for SYSV SHM where nattch for a segment does not reflect the number of shmat's
(and forks) done
to detect this.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
fs/splice.c|2 +-
include/linux/page-flags.h | 30 +-
include/linux/pagemap.h| 11 +++
mm/filemap.c | 16
mm/migrate.c
This one-line patch fixes the missing export of copy_page introduced
by the cachefile patches. This patch is not yet upstream, but is required
for cachefile on ia64. It will be pushed upstream when cachefile goes
upstream.
Signed-off-by: Prarit Bhargava [EMAIL PROTECTED]
Signed-Off-By: David
These patches add local caching for network filesystems such as NFS and AFS.
FS-Cache now runs fully asynchronously as required by Trond Myklebust for NFS.
--
Changes:
(*) The CacheFiles module no longer accepts directory fds in its cull and
inuse commands from cachefilesd. Instead it
) to do the honours.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
mm/readahead.c | 40 ++--
1 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/mm/readahead.c b/mm/readahead.c
index 39bf45d..12d1378 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
Provide an add_wait_queue_tail() function to add a waiter to the back of a
wait queue instead of the front.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
include/linux/wait.h |1 +
kernel/wait.c| 18 ++
2 files changed, 19 insertions(+), 0 deletions(-)
diff
an NFS filesystem to use caching, add an fsc option to the mount:
mount warthog:/ /a -o fsc
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/Kconfig |8 +
fs/nfs/Makefile|1
fs/nfs/client.c| 11 +
fs/nfs/file.c | 38
Export a number of functions for CacheFiles's use.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
fs/super.c |2 ++
kernel/auditsc.c |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index fc8ebed..c0d99dd 100644
--- a/fs/super.c
-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/pagemap.h |5 +
mm/filemap.c| 19 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index d1049b6..452fdcf 100644
--- a/include/linux
Permit an inode's security ID to be obtained by the CacheFiles module. This is
then used as the SID with which files and directories will be created in the
cache.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/security.h | 13 +
security/dummy.c |6
801 - 900 of 13793 matches
Mail list logo
