On Fri, Jun 22, 2007 at 04:06:15PM +0200, Andreas Herrmann wrote:
> Avoid kernel build error (as DLM depends on SYSFS)
>
> LD vmlinux
> fs/built-in.o: In function `dlm_lockspace_init':
> : undefined reference to `kernel_subsys'
> fs/built-in.o: In function `configfs_init':
> mou
On Fri, May 04, 2007 at 09:49:45PM +0530, Satyam Sharma wrote:
> Hi,
>
> There are the following two trivially-fixed races in fs/dlm/config.c:
>
> 1. The configfs subsystem semaphore must be held by the caller when
> calling config_group_find_obj(). It's needed to walk the subsystem
> hierarchy
tions(+), 191 deletions(-)
Adrian Bunk (1):
dlm: proper prototypes
David Teigland (13):
dlm: don't print common non-errors
dlm: use dlm prefix on alloc and free functions
dlm: use fixed errno values in messages
dlm: clear ast_type when removing from astqueue
ors to "fix" their systems or use clever routing
tricks.
Signed-off-by: Lon Hohberger <[EMAIL PROTECTED]>
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lowcomms.c | 13 -
1 files chan
Change log_error() to log_debug() for conditions that can occur in
large number in normal operation.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 7bc6ad9..6
The dlm functions in memory.c should use the dlm_ prefix. Also, use
kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 10 +-
fs/dlm/lock.c | 26 +--
platform-specific ones at the other end.
Many thanks to Fabio for testing this patch.
Initial patch from Patrick.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs
econd
time.
Appears when process calls libdlm dlm_release_lockspace() which first
closes the ls dev triggering clear_proc_locks, and then removes the ls
(a write to control dev) causing release_lockspace().
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |1 +
1 files
che `dlm_conn': Can't free all
objects"
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
From: Fabio M. Di Nitto <[EMAIL PROTECTED]>
DLM_RCOM_LOCK_REPLY messages need byte swapping.
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/util.c |9 ++---
1 files changed, 6 insertions(+), 3 deletion
From: Fabio M. Di Nitto <[EMAIL PROTECTED]>
gcc does not guarantee that a static buffer is 64bit aligned. This change
allows sparc64 to work.
Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/midcomms.c |2 +
start doing recovery in the presence of a many overlapping
unlock/cancel ops.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c | 37 -
1 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 4
error message, and could in some cases change some state, causing
problems.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |9 -
fs/dlm/member.c |4 ++--
fs/dlm/member.h |3 ++-
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of
retried, there may be other lkb's waiting on the rsb_lookup list for it
to complete. A call to confirm_master() is needed to move on to the next
waiting lkb since the current one won't be retried.
Signed-off
The dlm_put_lkb() can free the lkb and its associated ua structure,
so we can't depend on using the ua struct after the put.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/user.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/user
an old message to be processed and caught
by these checks.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c | 139 ++--
1 files changed, 104 insertions(+), 35 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
p rsb's in their
toss list that they are the master of. These rsb's need to be included
when the resource directory is rebuilt during recovery.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 66 +---
fs/dlm/l
o the field).
This patch restricts the length of the name to the amount of data
actually passed into the call.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/user.c | 12 +---
1 files changed, 9 insertions(+), 3 d
The invalid lockspace messages are normal and can appear relatively
often. They should be suppressed without debugging enabled.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/
ssary, the infinite loop is dangerous since some other
unknown condition may appear causing the loop to never break.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/l
From: Adrian Bunk <[EMAIL PROTECTED]>
This patch adds a proper prototype for some functions in
fs/dlm/dlm_internal.h
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h | 16
fs/dlm/loc
Non-forced unlocks should be rejected if the lock is waiting on the
rsb_lookup list for another lock to establish the master node.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/lo
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
> > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> > void dlm_rcom_in(struct dlm_rcom *rc)
> > {
> > struct dlm_header *hd = (struct dlm_header *) rc;
>
&g
On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote:
> Greetings,
>
> There's a memory leak in fs/dlm/member.c::dlm_add_member().
>
> If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then
> we'll return without freeing the memory allocated to the (at
> that point yet unused) 'memb
On Wed, Jul 04, 2007 at 11:30:08PM -0700, Joel Becker wrote:
> On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote:
> > From: Satyam Sharma <[EMAIL PROTECTED]>
> >
> > [0/3] configfs: Miscellaneous cleanups
> >
> > Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable).
On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote:
> device_write only checks whether the request size is big enough, but it
> doesn't
> check if the size is too big.
>
> At that point, it also tries to allocate as much memory as the user has
> requested
> even if it's too much. This c
On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote:
> Since add_sock() always returns a success code - 0, its return
> value type should be changed from integer to void.
Thanks, I've pushed those to my next branch.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
On Mon, Aug 13, 2012 at 02:29:55PM +0800, Ying Xue wrote:
> But I have submitted another patch:
> https://lkml.org/lkml/2012/8/9/668
Yes I got it, to see all the patches I've pushed out, check here:
http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/teigland/linux-dlm.git;a=shortlog;h=refs/heads
On Mon, Oct 29, 2012 at 12:07:10PM -0400, Mathieu Desnoyers wrote:
> I'm fine with turning a direct + modulo mapping into a dispersed hash as
> long as there are no underlying assumptions about sequentiality of value
> accesses.
>
> If the access pattern would happen to be typically sequential, th
both access configfs data simultaneously. The
second reworks some code to get around a long standing, but intentional,
unlock balance warning. The userland daemon no longer takes a lock that
is later released from the kernel. The other commits are minor fixes and
changes.
Thanks,
Dave
David
Hi Linus,
Please pull dlm updates from tag:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.8
This set fixes some conditions in which value blocks are invalidated,
and includes two trivial cleanups.
Thanks,
Dave
David Teigland (1):
dlm: fix lvb invalidation
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote:
> > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> > void dlm_rcom_in(struct dlm_rcom *rc)
> > {
> > struct dlm_header *hd = (struct dlm_header *) rc;
>
&g
s are mostly relevant for other applications.
There are no new features, only fixes for various bugs or problems. They
stem mainly from mixed architecture testing, and new tests that overlap
recovery with userland stress tests.
Thanks,
Dave
Adrian Bunk (1):
dlm: proper prototypes
patch is made possible by the dirtbl removal, and
fixes a long standing race between resource removal and lookup by
reworking how removal is done. At the same time it improves the shrink
function efficiency by avoiding repeated searches through hash buckets.
David Teigland (6):
dlm: use
r.
Signed-off-by: David Teigland
---
fs/dlm/lock.c | 70 +++--
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 04e3f15..b569507 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -4000,12 +4000,70
The process of rebuilding locks on a new master during
recovery could re-order the locks on the convert queue,
creating an "in place" conversion deadlock that would
not be resolved. Fix this by not considering queue
order when granting conversions after recovery.
Signed-off-by: Davi
Use wait_event_timeout to avoid using a timer
directly.
Signed-off-by: David Teigland
---
fs/dlm/recover.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c
index ff6f276..12702cc 100644
--- a/fs/dlm
has
been sent. A lookup checks if this in-progress
remove matches the name it is looking up.
Signed-off-by: David Teigland
---
fs/dlm/dlm_internal.h | 13
fs/dlm/lock.c | 181 +++--
fs/dlm/lockspace.c| 21 +-
3 files changed
When a large number of resources are being recovered,
a linear search of the recover_list takes a long time.
Use an idr in place of a list.
Signed-off-by: David Teigland
---
fs/dlm/dlm_internal.h |3 ++
fs/dlm/lockspace.c|3 ++
fs/dlm/rcom.c |2 +-
fs/dlm/recover.c
through a hash bucket.
The other commits include minor fixes and changes.
Thanks,
Dave
David Teigland (6):
dlm: use rsbtbl as resource directory
dlm: use idr instead of list for recovered rsbs
dlm: fix race between remove and lookup
dlm: use wait_event_timeout
dlm: fix
dlm: dlm/user.c input validation fixes
David Teigland (2):
dlm: proper types for asts and basts
dlm: eliminate astparam type casting
Denis Cheng (1):
dlm: add __init and __exit marks to init and exit functions
fs/dlm/ast.c |9 ++--
fs/dlm/config.c |2
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h |6 +++---
fs/dlm/rcom.c | 15 ---
fs/dlm/util.c | 20
3 files chan
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
inde
From: Al Viro <[EMAIL PROTECTED]>
* check that length is large enough to cover the non-variable part of message or
rcom resp. (after checking that it's large enough to cover the header, of
course).
* kill more pointless casts
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Sig
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h | 22 +++---
fs/dlm/lock.c | 34 +++---
fs/dlm/rcom.c | 14
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |3 +++
fs/dlm/rcom.c | 12 +++-
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/f
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/rcom.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c
index 3f9b96f..a312f1d 1
From: Al Viro <[EMAIL PROTECTED]>
a) in device_write(): add sentinel NUL byte, making sure that lspace.name will
be NUL-terminated
b) in compat_input() be keep it simple about the amounts of data we are copying.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teig
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c |2 +-
fs/dlm/dlm_internal.h |2 +-
fs/dlm/rcom.c | 11 ++-
fs/dlm/recover.c |4 ++--
4
t alignment.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |2 +-
fs/dlm/requestqueue.c | 12 ++--
fs/dlm/requestqueue.h |2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/dlm
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6c605fc..0593dd8 1
tually oops before
that while calculating hash of up to 64Kb worth of data - with data
actually being 64 _bytes_ in kmalloc()'ed struct.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |6 +-
1 files chan
From: Al Viro <[EMAIL PROTECTED]>
... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is
not a good way to handle them.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c |3 +++
1 files cha
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6d98cf9..5b82187 1
Put lkb_astparam in a union with a dlm_user_args pointer to
eliminate a lot of type casting.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/debug_fs.c |6 ++
fs/dlm/dlm_internal.h |5 -
fs/dlm/lock.c | 14 ++
fs/dlm/memory.c
Use proper types for ast and bast functions, and use
consistent type for ast param.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/ast.c |9 +++
fs/dlm/dlm_internal.h | 14 +---
fs/dlm/lock.c
From: Denis Cheng <[EMAIL PROTECTED]>
it moves 365 bytes from .text to .init.text, and 30 bytes from .text to
.exit.text, saves memory.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/config.c|2 +-
fs/dlm/
dlm: receive_rcom_lock_args() overflow check
dlm: make find_rsb() fail gracefully when namelen is too large
dlm: fix overflows when copying from ->m_extra to lvb
dlm: fix dlm_dir_lookup() handling of too long names
dlm: dlm/user.c input validation fixes
David Teigland (2):
On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote:
> On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> > default_groups was allocated with kcalloc, so initialize to NULL
> > is unnecessary.
>
> NACK - this isn't a performance critical section of code and that line makes
> t
On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote:
> dlm_print_rsb() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Thanks, added to dlm.git.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PR
On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
> cluster_set is only called from the macro CLUSTER_ATTR which defines
> read/write
> access functions. Make the signedness match to avoid sparse warnings every
> time
> CLUSTER_ATTR is used (lines 149-159) all of the form:
>
> fs
On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote:
> We are up to 26 trees, more are welcome (even if they are currently empty).
dlm (distributed lock manager) tree:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next
Dave
--
To unsubscribe from this list: send t
On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> >
> > dlm (distributed lock manager) tree:
> >
> > git://git.kernel.org/pub/scm/linux/kerne
insertions(+), 2 deletions(-)
commit d7c2feaf88df39124e278b9e775b245b057ac99e
Author: David Teigland <[EMAIL PROTECTED]>
Date: Thu Feb 21 15:27:09 2008 -0600
dlm: update git tree in MAINTAINERS
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
diff --git a/MAINTAINERS b
On Sat, Nov 03, 2007 at 01:04:30AM +0100, Adrian Bunk wrote:
> This patch adds a proper prototype for some functions in
> fs/dlm/dlm_internal.h
Acked-by: David Teigland <[EMAIL PROTECTED]>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> ---
>
&
Hi, GFS (Global File System) is a cluster file system that we'd like to
see added to the kernel. The 14 patches total about 900K so I won't send
them to the list unless that's requested. Comments and suggestions are
welcome. Thanks
http://redhat.com/~teigland/gfs2/20050801/gfs2-full.patch
http:
On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote:
> * The on disk structures are defined in terms of uint32_t and friends,
> which are NOT endian neutral. Why are they not le32/be32 and thus
> endian-defined? Did you run bitwise-sparse on GFS yet ?
GFS has had proper endian handli
On Tue, Aug 02, 2005 at 01:16:53PM +0300, Pekka Enberg wrote:
> > +void *gmalloc_nofail_real(unsigned int size, int flags, char *file,
> > + unsigned int line)
> > +{
> > + void *x;
> > + for (;;) {
> > + x = kmalloc(size, flags);
> > + if (x)
> > +
On Wed, Aug 03, 2005 at 11:17:09AM +0200, Arjan van de Ven wrote:
> On Wed, 2005-08-03 at 11:56 +0800, David Teigland wrote:
> > The point is you can define GFS2_ENDIAN_BIG to compile gfs to be BE
> > on-disk instead of LE which is another useful way to verify endian
> > c
On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote:
> * +static const uint32_t crc_32_tab[] = .
> why do you duplicate this? The kernel has a perfectly good set of
> generic crc32 tables/functions just fine
The gfs2_disk_hash() function and the crc table on which it's based are
On Fri, Aug 05, 2005 at 09:34:38AM +0200, Arjan van de Ven wrote:
> On Fri, 2005-08-05 at 15:14 +0800, David Teigland wrote:
> > On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote:
> >
> > > * +static const uint32_t crc_32_tab[] = .
> > > why
On Fri, Aug 05, 2005 at 12:07:50PM +0200, J?rn Engel wrote:
> On Fri, 5 August 2005 17:44:52 +0800, David Teigland wrote:
> > Do we go a step beyond this and use say the crc32() function from
> > linux/crc32.h? Is this _function_ as standard and unchanging as the table
> >
On Fri, Aug 05, 2005 at 03:14:15PM +0800, David Teigland wrote:
> On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote:
> > * +++ b/fs/gfs2/fixed_div64.h 2005-08-01 14:13:08.009808200 +0800
> > e why?
>
> I'm not sure, actually, apart from the com
On Wed, Aug 03, 2005 at 09:44:06AM +0300, Pekka Enberg wrote:
> > +uint32_t gfs2_hash(const void *data, unsigned int len)
> > +{
> > + uint32_t h = 0x811C9DC5;
> > + h = hash_more_internal(data, len, h);
> > + return h;
> > +}
>
> Is there a reason why you cannot use or ?
See gfs2_h
On Mon, Aug 08, 2005 at 01:18:45PM +0300, Pekka J Enberg wrote:
> gfs2-02.patch:+ RETRY_MALLOC(ip = kmem_cache_alloc(gfs2_inode_cachep,
> -> GFP_NOFAIL.
Already gone, inode_create() can return an error.
if (create) {
RETRY_MALLOC(page = grab_cache_page(aspace->i_mapping, index),
On Mon, Aug 08, 2005 at 01:57:55PM +0300, Pekka J Enberg wrote:
> David Teigland writes:
> >> but why can't you return NULL here on failure like you do for
> >> find_lock_page()?
> >
> >because create is set
>
> Yes, but looking at (some of the) top-
On Mon, Aug 08, 2005 at 05:14:45PM +0300, Pekka J Enberg wrote:
if (!dumping)
down_read(&mm->mmap_sem);
> >+
> >+ for (vma = find_vma(mm, start); vma; vma = vma->vm_next) {
> >+ if (end <= vma->vm_start)
> >+
A variety of things including bug fixes, cleanups, and a couple
enhancements. Some of these updates are broad enough to cross the current
dlm patch divisions in -mm.
Dave
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Mo
Use node weights in directory mapping. Allows nodes to be configured to
be responsible for more or less of the directory.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/dir.c
===
---
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/lock.c
===
--- linux-2.6.12-mm1.orig
An extra refcount was being left on devices.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux/drivers/dlm/device.c
===
--- linux.orig/drivers/dlm/device
When a lockspace on a remote node is not found for a recovery status
request, an error needs to be returned so the requesting node can
distinguish it from a normal reply with a zero status.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux/drivers/dlm/
The list of root rsb's created during recovery needs to be released if
recovery is aborted early.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux/drivers/dlm/recoverd.c
===
--- linux.orig/drivers/dlm
If recover_locks() on an rsb doesn't find any locks to recover, we need to
clear the NEW_MASTER flag since it won't be cleared by
dlm_recovered_lock().
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux/drive
Rework recovery control, simplifying the process significantly and
removing a lot of code. This also makes it easier for different
user-space infrastructures to drive the dlm.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm
Per-lockspace option for dlm to run without using a resource
directory. What would be the directory node for a resource is
statically assigned to be the master node instead.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux/drivers/dlm
: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/debug_fs.c
===
--- linux-2.6.12-mm1.orig/drivers/dlm/debug_fs.c
+++ linux-2.6.12-mm1/drivers/dlm/debug_fs.c
@@ -99,11 +99,16 @@ static int print_resource(
Replace test/set/clear_bit of rsb flags with new inline functions that use
the less expense non-atomic bit ops.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/debug_fs.c
===
--- linux-
Fix potential race in lowcomms.
Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/lowcomms.c
===
--- linux-2.6.12-mm1.orig
During recovery, set the RESEND flag on locks waiting for a lookup so
they'll be resent when recovery completes.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
Index: linux-2.6.12-mm1/drivers/dlm/lock.c
===
--- linux
Some of the comments about the dlm concerned how it's configured (from
user space.) In particular, there was interest in seeing the dlm and
ocfs2 use common methods for their configuration.
The first area I'm looking at is how we get addresses/ids of other nodes.
Currently, the dlm uses an ioctl
On Tue, Jul 19, 2005 at 05:52:14PM +0200, Lars Marowsky-Bree wrote:
> The nodeid, I thought, was relative to a given DLM namespace, no? This
> concept seems to be missing here, or are you suggesting the nodeid to be
> global across namespaces?
I'm not sure I understand what you mean. A node woul
On Tue, Jul 19, 2005 at 05:48:26PM -0700, Mark Fasheh wrote:
> For OCFS2 that would mean that an ocfs2_nodemanager would still exist,
> but as a much smaller module sitting on top of 'nodemanager'.
Yep, factoring out the common bits.
> So no port attribute. The OCFS2 network code normally takes p
On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote:
> * + if (create)
> + down_write(&ip->i_rw_mutex);
> + else
> + down_read(&ip->i_rw_mutex);
>
> why do you use a rwsem and not a regular semaphore? You are aware that
> rwsems are far more expensive th
Thanks for all the review and comments. This is a new set of patches that
incorporates the suggestions we've received.
http://redhat.com/~teigland/gfs2/20050811/gfs2-full.patch
http://redhat.com/~teigland/gfs2/20050811/broken-out/
Dave
-
To unsubscribe from this list: send the line "unsubscribe
On Thu, Aug 11, 2005 at 04:21:04PM +0800, Michael wrote:
> I have the same question as I asked before, how can I see GFS in "make
> menuconfig", after I patch gfs2-full.patch into a 2.6.12.2 kernel?
You need to select the dlm under drivers. It's in -mm, or apply
http://redhat.com/~teigland/dlm.
On Thu, Aug 11, 2005 at 10:32:38AM +0200, Arjan van de Ven wrote:
> On Thu, 2005-08-11 at 16:17 +0800, David Teigland wrote:
> > Thanks for all the review and comments. This is a new set of patches that
> > incorporates the suggestions we've received.
>
> all of t
On Thu, Aug 11, 2005 at 10:50:32AM +0200, Arjan van de Ven wrote:
> > > > Thanks for all the review and comments. This is a new set of
> > > > patches that incorporates the suggestions we've received.
> > >
> > > all of them or only a subset?
>
> with them I meant the suggestions not the patche
Use configfs to configure lockspace members and node addresses. This was
previously done with sysfs and ioctl.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
drivers/dlm/Makefile |1
drivers/dlm/config.c | 759 -
drive
The reduced member_sysfs.c is no longer related to lockspace members.
Move what's left into lockspace.c which is the only file that uses the
remaining functions.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
Makefile |1
lockspace.
1 - 100 of 201 matches
Mail list logo
