Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

2008-01-29 Thread David Teigland
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote: On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland [EMAIL PROTECTED] wrote: void dlm_rcom_in(struct dlm_rcom *rc) { struct dlm_header *hd = (struct dlm_header *) rc; aww, c'mon guys, this is nonsense. struct

[GIT PULL] dlm updates for 2.6.25

2008-01-30 Thread David Teigland
are mostly relevant for other applications. There are no new features, only fixes for various bugs or problems. They stem mainly from mixed architecture testing, and new tests that overlap recovery with userland stress tests. Thanks, Dave Adrian Bunk (1): dlm: proper prototypes David

[PATCH 00/19] dlm patches for 2.6.25

2008-01-24 Thread David Teigland
(+), 191 deletions(-) Adrian Bunk (1): dlm: proper prototypes David Teigland (13): dlm: don't print common non-errors dlm: use dlm prefix on alloc and free functions dlm: use fixed errno values in messages dlm: clear ast_type when removing from astqueue dlm

[PATCH 01/19] dlm: bind connections from known local address when using TCP

2008-01-24 Thread David Teigland
to fix their systems or use clever routing tricks. Signed-off-by: Lon Hohberger [EMAIL PROTECTED] Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lowcomms.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git

[PATCH 03/19] dlm: don't print common non-errors

2008-01-24 Thread David Teigland
Change log_error() to log_debug() for conditions that can occur in large number in normal operation. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 7bc6ad9..63fe74d

[PATCH 04/19] dlm: use dlm prefix on alloc and free functions

2008-01-24 Thread David Teigland
The dlm functions in memory.c should use the dlm_ prefix. Also, use kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/dir.c | 10 +- fs/dlm/lock.c | 26 +- fs/dlm

[PATCH 08/19] dlm: use fixed errno values in messages

2008-01-24 Thread David Teigland
the platform-specific ones at the other end. Many thanks to Fabio for testing this patch. Initial patch from Patrick. Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/util.c | 57

[PATCH 09/19] dlm: clear ast_type when removing from astqueue

2008-01-24 Thread David Teigland
time. Appears when process calls libdlm dlm_release_lockspace() which first closes the ls dev triggering clear_proc_locks, and then removes the ls (a write to control dev) causing release_lockspace(). Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |1 + 1 files changed, 1

[PATCH 05/19] dlm: close othercons

2008-01-24 Thread David Teigland
all objects and the DLM cannot be restarted without a system reboot. See bz#428119 Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lowcomms.c |2 ++ 1 files changed, 2 insertions

[PATCH 07/19] dlm: swap bytes for rcom lock reply

2008-01-24 Thread David Teigland
From: Fabio M. Di Nitto [EMAIL PROTECTED] DLM_RCOM_LOCK_REPLY messages need byte swapping. Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/util.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/dlm

[PATCH 06/19] dlm: align midcomms message buffer

2008-01-24 Thread David Teigland
From: Fabio M. Di Nitto [EMAIL PROTECTED] gcc does not guarantee that a static buffer is 64bit aligned. This change allows sparc64 to work. Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/midcomms.c |2 +- 1 files changed, 1

[PATCH 10/19] dlm: recover locks waiting for overlap replies

2008-01-24 Thread David Teigland
start doing recovery in the presence of a many overlapping unlock/cancel ops. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 43ca2a3

[PATCH 12/19] dlm: reject messages from non-members

2008-01-24 Thread David Teigland
an error message, and could in some cases change some state, causing problems. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |9 - fs/dlm/member.c |4 ++-- fs/dlm/member.h |3 ++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/fs/dlm/lock.c b

[PATCH 11/19] dlm: another call to confirm_master in receive_request_reply

2008-01-24 Thread David Teigland
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of retried, there may be other lkb's waiting on the rsb_lookup list for it to complete. A call to confirm_master() is needed to move on to the next waiting lkb since the current one won't be retried. Signed-off-by: David

[PATCH 16/19] dlm: fix possible use-after-free

2008-01-24 Thread David Teigland
The dlm_put_lkb() can free the lkb and its associated ua structure, so we can't depend on using the ua struct after the put. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/user.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/dlm/user.c b/fs/dlm/user.c

[PATCH 13/19] dlm: validate messages before processing

2008-01-24 Thread David Teigland
for an old message to be processed and caught by these checks. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c | 139 ++-- 1 files changed, 104 insertions(+), 35 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index c3b9fca

[PATCH 18/19] dlm: keep cached master rsbs during recovery

2008-01-24 Thread David Teigland
in their toss list that they are the master of. These rsb's need to be included when the resource directory is rebuilt during recovery. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/dir.c | 66 +--- fs/dlm/lock.c |6 - fs/dlm

[PATCH 19/19] dlm: Sanity check namelen before copying it

2008-01-24 Thread David Teigland
). This patch restricts the length of the name to the amount of data actually passed into the call. Signed-off-by: Patrick Caulfield [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/user.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/fs

[PATCH 17/19] dlm: change error message to debug

2008-01-24 Thread David Teigland
The invalid lockspace messages are normal and can appear relatively often. They should be suppressed without debugging enabled. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm

[PATCH 15/19] dlm: limit dir lookup loop

2008-01-24 Thread David Teigland
, the infinite loop is dangerous since some other unknown condition may appear causing the loop to never break. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index fa68e9b

[PATCH 02/19] dlm: proper prototypes

2008-01-24 Thread David Teigland
From: Adrian Bunk [EMAIL PROTECTED] This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/dlm_internal.h | 16 fs/dlm/lock.c |1 - fs

[PATCH 14/19] dlm: reject normal unlock when lock is waiting for lookup

2008-01-24 Thread David Teigland
Non-forced unlocks should be rejected if the lock is waiting on the rsb_lookup list for another lock to establish the master node. Signed-off-by: David Teigland [EMAIL PROTECTED] --- fs/dlm/lock.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/dlm/lock.c b/fs

Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

2008-01-28 Thread David Teigland
On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote: On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland [EMAIL PROTECTED] wrote: void dlm_rcom_in(struct dlm_rcom *rc) { struct dlm_header *hd = (struct dlm_header *) rc; aww, c'mon guys, this is nonsense. struct

Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization

2008-02-18 Thread David Teigland
On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote: On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote: default_groups was allocated with kcalloc, so initialize to NULL is unnecessary. NACK - this isn't a performance critical section of code and that line makes the

Re: [2.6 patch] make dlm_print_rsb() static

2008-02-19 Thread David Teigland
On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote: dlm_print_rsb() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Thanks, added to dlm.git. Dave -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set

2008-02-19 Thread David Teigland
On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote: cluster_set is only called from the macro CLUSTER_ATTR which defines read/write access functions. Make the signedness match to avoid sparse warnings every time CLUSTER_ATTR is used (lines 149-159) all of the form:

Re: linux-next: Tree for Feb 19

2008-02-19 Thread David Teigland
On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote: We are up to 26 trees, more are welcome (even if they are currently empty). dlm (distributed lock manager) tree: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next Dave -- To unsubscribe from this list: send

Re: linux-next: Tree for Feb 19

2008-02-19 Thread David Teigland
On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote: Hi David, On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland [EMAIL PROTECTED] wrote: dlm (distributed lock manager) tree: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next Thanks, added. Does

[GIT PULL] dlm fixes for 2.6.25-rc2

2008-02-21 Thread David Teigland
insertions(+), 2 deletions(-) commit d7c2feaf88df39124e278b9e775b245b057ac99e Author: David Teigland [EMAIL PROTECTED] Date: Thu Feb 21 15:27:09 2008 -0600 dlm: update git tree in MAINTAINERS Signed-off-by: David Teigland [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [2.6 patch] fs/dlm/: proper prototypes

2007-11-05 Thread David Teigland
On Sat, Nov 03, 2007 at 01:04:30AM +0100, Adrian Bunk wrote: This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h Acked-by: David Teigland [EMAIL PROTECTED] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- fs/dlm/dlm_internal.h | 16 fs

[PATCH 0/6] dlm patches for 3.6

2012-07-23 Thread David Teigland
patch is made possible by the dirtbl removal, and fixes a long standing race between resource removal and lookup by reworking how removal is done. At the same time it improves the shrink function efficiency by avoiding repeated searches through hash buckets. David Teigland (6): dlm: use

[PATCH 6/6] dlm: fix missing dir remove

2012-07-23 Thread David Teigland
-off-by: David Teigland teigl...@redhat.com --- fs/dlm/lock.c | 70 +++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 04e3f15..b569507 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -4000,12

[PATCH 5/6] dlm: fix conversion deadlock from recovery

2012-07-23 Thread David Teigland
The process of rebuilding locks on a new master during recovery could re-order the locks on the convert queue, creating an in place conversion deadlock that would not be resolved. Fix this by not considering queue order when granting conversions after recovery. Signed-off-by: David Teigland

[PATCH 4/6] dlm: use wait_event_timeout

2012-07-23 Thread David Teigland
Use wait_event_timeout to avoid using a timer directly. Signed-off-by: David Teigland teigl...@redhat.com --- fs/dlm/recover.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c index ff6f276..12702cc 100644

[PATCH 3/6] dlm: fix race between remove and lookup

2012-07-23 Thread David Teigland
has been sent. A lookup checks if this in-progress remove matches the name it is looking up. Signed-off-by: David Teigland teigl...@redhat.com --- fs/dlm/dlm_internal.h | 13 fs/dlm/lock.c | 181 +++-- fs/dlm/lockspace.c| 21

[PATCH 2/6] dlm: use idr instead of list for recovered rsbs

2012-07-23 Thread David Teigland
When a large number of resources are being recovered, a linear search of the recover_list takes a long time. Use an idr in place of a list. Signed-off-by: David Teigland teigl...@redhat.com --- fs/dlm/dlm_internal.h |3 ++ fs/dlm/lockspace.c|3 ++ fs/dlm/rcom.c |2 +- fs

[GIT PULL] dlm updates for 3.8

2012-12-11 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.8 This set fixes some conditions in which value blocks are invalidated, and includes two trivial cleanups. Thanks, Dave David Teigland (1): dlm: fix lvb invalidation

[GIT PULL] dlm updates for 3.7

2012-10-01 Thread David Teigland
both access configfs data simultaneously. The second reworks some code to get around a long standing, but intentional, unlock balance warning. The userland daemon no longer takes a lock that is later released from the kernel. The other commits are minor fixes and changes. Thanks, Dave David

Re: [patch] DLM: fix kconfig dependency

2007-06-22 Thread David Teigland
On Fri, Jun 22, 2007 at 04:06:15PM +0200, Andreas Herrmann wrote: Avoid kernel build error (as DLM depends on SYSFS) LD vmlinux fs/built-in.o: In function `dlm_lockspace_init': : undefined reference to `kernel_subsys' fs/built-in.o: In function `configfs_init':

Re: [PATCH -mm 0/3] configfs: Miscellaneous cleanups

2007-07-05 Thread David Teigland
On Wed, Jul 04, 2007 at 11:30:08PM -0700, Joel Becker wrote: On Wed, Jul 04, 2007 at 04:37:01PM +0530, Satyam Sharma wrote: From: Satyam Sharma [EMAIL PROTECTED] [0/3] configfs: Miscellaneous cleanups Simple cleanups for configfs (plus DLM and OCFS2, wherever applicable). This is

Re: [PATCH] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero

2007-07-19 Thread David Teigland
On Thu, Jul 19, 2007 at 12:27:43AM +0200, Jesper Juhl wrote: Greetings, There's a memory leak in fs/dlm/member.c::dlm_add_member(). If dlm_node_weight(ls-ls_name, nodeid) returns 0, then we'll return without freeing the memory allocated to the (at that point yet unused) 'memb'. This

Re: [PATCH] DLM: fix a couple of races

2007-05-04 Thread David Teigland
On Fri, May 04, 2007 at 09:49:45PM +0530, Satyam Sharma wrote: Hi, There are the following two trivially-fixed races in fs/dlm/config.c: 1. The configfs subsystem semaphore must be held by the caller when calling config_group_find_obj(). It's needed to walk the subsystem hierarchy

Re: linux-next: manual merge of the dlm tree with Linus' tree

2013-08-16 Thread David Teigland
On Fri, Aug 16, 2013 at 11:40:50AM +1000, Stephen Rothwell wrote: Hi David, Today's linux-next merge of the dlm tree got a conflict in fs/dlm/user.c between commit 201d3dfa4da1 (dlm: kill the unnecessary and wrong device_close()-recalc_sigpending()) from Linus' tree and commit c6ca7bc91d51

Re: [PATCH 03/10] idr: Rewrite ida

2013-06-21 Thread David Teigland
On Wed, Jun 19, 2013 at 04:38:36PM -0700, Kent Overstreet wrote: On Wed, Jun 19, 2013 at 10:40:22AM +0100, Steven Whitehouse wrote: Millions of IDs is something that is fairly normal for DLM, since there will be two DLM locks per cached inode with GFS2 and people tend to use it on pretty

[GIT PULL] dlm updates for 3.13

2013-11-11 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.13 This set includes a single fix to resolve to a race that could cause lockspace shutdown to incorrectly return -EBUSY. Thanks, Dave Bart Van Assche (1): dlm: Avoid

Re: linux-next: Tree for May 8 (dlm)

2013-05-09 Thread David Teigland
On Thu, May 09, 2013 at 09:47:45AM +1000, Stephen Rothwell wrote: [Just forwarding to David ...] On Wed, 08 May 2013 11:04:45 -0700 Randy Dunlap rdun...@infradead.org wrote: on x86_64: when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m: fs/built-in.o: In function `gfs2_lock':

[GIT PULL] dlm updates for 3.10

2013-04-30 Thread David Teigland
activity, even when no posix locks had been used. This patch copies the nfs approach, and skips the full posix unlock if there is no plock found during the vfs unlock phase. Signed-off-by: David Teigland teigl...@redhat.com --- fs/dlm/plock.c | 18 +++--- 1 file changed, 15 insertions

[GIT PULL] dlm updates for 3.12

2013-09-04 Thread David Teigland
the unnecessary and wrong device_close()-recalc_sigpending() Let me know if you'd like me to send a resolved patch. Thanks, Dave David Teigland (1): dlm: remove signal blocking Tejun Heo (1): dlm: WQ_NON_REENTRANT is meaningless and going away fs/dlm/ast.c | 5 + fs/dlm/user.c

[GIT PULL] dlm updates for 3.16

2014-06-13 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.16 This set includes one small fix related to resending SCTP messages. Thanks, Dave Lidong Zhong (1): dlm: keep listening connection alive with sctp mode

[GIT PULL] dlm updates for 3.14

2014-01-21 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.14 This set includes a single change to speed up recovery times when using SCTP connections. Thanks, Dave Dongmao Zhang (1): dlm: set zero linger time on sctp socket

Re: [PATCH 1/1] dlm: kill the unnecessary and wrong device_close()-recalc_sigpending()

2013-08-12 Thread David Teigland
; it was there when the code was added seven years ago. I agree that if there's something we cannot interrupt, we should use uninterruptible, but I don't see any cases of that either. I think we should just remove it all (untested): From: David Teigland teigl...@redhat.com Date: Mon, 12 Aug 2013 15:22

[GIT PULL] dlm updates for 3.15

2014-04-02 Thread David Teigland
free warning David Teigland (1): dlm: use INFO for recovery messages Rashika Kheria (1): fs: Include appropriate header file in dlm/ast.c fs/dlm/ast.c | 3 ++- fs/dlm/dir.c | 4 ++-- fs/dlm/dlm_internal.h | 2 ++ fs/dlm/lock.c | 7 --- fs/dlm

[GIT PULL] dlm updates for 3.11

2013-07-01 Thread David Teigland
David Teigland (1): dlm: log an error for unmanaged lockspaces Mike Christie (6): dlm: clear correct init bit during sctp setup dlm: set sctp assoc id during setup dlm: clear correct bit during sctp init failure handling dlm: try other IPs when sctp init assoc fails

Re: [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: On Tue, 01 Jul 2014 06:20:10 -0700 Joe Perches j...@perches.com wrote: While doing a bit of adding argument names to fs.h, I looked at lm_grant and it seems the 2nd argument is always NULL. How about removing it? This

Re: [Cluster-devel] [RFC PATCH] dlm: Remove unused conf from lm_grant

2014-07-01 Thread David Teigland
On Tue, Jul 01, 2014 at 01:16:32PM -0400, Bob Peterson wrote: - Original Message - On Tue, Jul 01, 2014 at 10:43:13AM -0400, Jeff Layton wrote: On Tue, 01 Jul 2014 06:20:10 -0700 Joe Perches j...@perches.com wrote: While doing a bit of adding argument names to fs.h, I

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread David Teigland
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches j...@perches.com wrote: op-info.rv is an s32, but it's only used as a u8. I don't understand this patch. info.rv is s32 (and I assume that rv stands for return value). What I

[GIT PULL] dlm updates for 3.18

2014-10-17 Thread David Teigland
(v2: add cc lkml) Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.18 This includes a single commit fixing a missing endian conversion. Thanks, Dave Neale Ferguson (1): dlm: fix missing endian conversion of

Re: [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-11-04 Thread David Teigland
On Tue, Nov 04, 2014 at 08:08:52AM -0500, Steven Rostedt wrote: On Wed, 29 Oct 2014 17:56:07 -0400 Steven Rostedt rost...@goodmis.org wrote: From: Joe Perches j...@perches.com [ REQUEST FOR ACKS ] Can any of the DLM maintainers give me an Acked-by for this? Looks ok, Dave -- To

[GIT PULL] dlm updates for 3.19

2014-12-10 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.19 This set includes one feature, which allows locks that have been orphaned to be reacquired. Thanks, Dave David Teigland (1): dlm: adopt orphan locks fs/dlm/lock.c

clustered MD

2015-06-09 Thread David Teigland
I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list for review? Dave -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: On 06/09/2015 01:22 PM, David Teigland wrote: I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list

Re: clustered MD

2015-06-09 Thread David Teigland
On Tue, Jun 09, 2015 at 03:08:11PM -0500, Goldwyn Rodrigues wrote: Hi David, On 06/09/2015 02:45 PM, David Teigland wrote: On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: On 06/09/2015 01:22 PM, David Teigland wrote: I've just noticed the existence of clustered MD

Re: clustered MD

2015-06-10 Thread David Teigland
On Tue, Jun 09, 2015 at 10:33:08PM -0500, Goldwyn Rodrigues wrote: some real world utility to warrant the potential maintenance effort. We do have a valid real world utility. It is to provide high-availability of RAID1 storage over the cluster. The distributed locking is required only

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 10:27:27AM -0500, Goldwyn Rodrigues wrote: I thought I answered that: To use a software RAID1 across multiple nodes of a cluster. Let me explain in more words.. In a cluster with multiple nodes with a shared storage, such as a SAN. The shared device becomes a single

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 12:05:33PM -0500, David Teigland wrote: Separate bitmaps for each node sounds like a much better design than the cmirror design which used a single shared bitmap (I argued for using a single bitmap when cmirror was being designed.) Sorry misspoke, I argued for one

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:23:25AM -0500, Goldwyn Rodrigues wrote: To start with, the goal of (basic) MD RAID1 is to keep the two mirrored device consistent _all_ of the time. In case of a device failure, it should degrade the array pointing to the failed device, so it can be

Re: clustered MD

2015-06-10 Thread David Teigland
On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote: What is your interest in this? I'm always happy for open discussion and varied input, but it would help to know to what extent you are a stake holder? Using the dlm correctly is non-trivial and should be reviewed. If the dlm is

Re: clustered MD

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 04:07:44PM -0500, David Teigland wrote: Also a slightly less adversarial tone would make me feel more comfortable, though maybe I'm misreading your intent. You're probably misreading concerned. The initial responses to my inquiry were severely lacking in any

Re: clustered MD

2015-06-12 Thread David Teigland
When a node fails, its dirty areas get special treatment from other nodes using the area_resyncing() function. Should the suspend_list be created before any reads or writes from the file system are processed by md? It seems to me that gfs journal recovery could read/write to dirty regions (from

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread David Teigland
On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: The remove_from_waiters could only be invoked after failed to create_message, right? Since send_message always returns 0, this patch doesn't touch anything about the failure path, and it also doesn't change the original semantic.

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-11 Thread David Teigland
On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: Do you consider take the following clean up? If yes, I will send a formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. - to_nodeid =

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote: - Some watchdogs have a very short maximum timeout, in the range of just a few seconds. Such low timeouts are difficult if not impossible to support from user space. Drivers supporting such watchdog hardware need to implement

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 10:41:51AM -0700, Guenter Roeck wrote: Not really. The heartbeats will be generated such that the watchdog expires no later that last heartbeat from userspace + configured timeout. I discussed this already with Uwe; he had the same concern. This isn't in the current

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

2015-08-05 Thread David Teigland
On Wed, Aug 05, 2015 at 12:01:38PM -0700, Guenter Roeck wrote: I think I can understand why Wim was reluctant to accept your patch; I must admit I don't understand your use case either. Very breifly, sanlock is a shared storage based lease manager, and the expiration of a lease is tied to the

[GIT PULL] dlm updates for 4.4

2015-11-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.4 This includes one simple fix to make posix locks interruptible by signals in cases where a signal handler is used. Thanks, Dave Eric Ren (1): dlm: make posix locks

[GIT PULL] dlm updates for 4.3

2015-08-31 Thread David Teigland
are also included. The other notable fix is for a long standing regression in the behavior of lock value blocks for user space locks. Thanks, Dave Bob Peterson (1): dlm: print error from kernel_sendpage David Teigland (1): dlm: fix lvb copy for user locks Marcelo Ricardo Leitner (6

[GIT PULL] dlm updates for 4.6

2016-03-18 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6 Previous changes introduced the use of socket error reporting for dlm sockets. This set includes two fixes in how the socket error callbacks are used. Thanks, Dave Bob

[GIT PULL] dlm fixes for 4.6

2016-03-29 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6-fixes This fixes a bug from the configfs cleanup. Thanks, Dave Andrew Price (1): dlm: config: Fix ENOMEM failures in make_cluster() fs/dlm/config.c | 3 +-- 1 file

[GIT PULL] dlm updates for 4.8

2016-07-27 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8 This set includes two trivial changes, one to use kmemdup and another to control the log level of recovery messages. Thanks, Dave Amitoj Kaur Chawla (1): dlm: Use

[GIT PULL] dlm fixes for 4.8

2016-08-26 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8-fixes This fixes a bug introduced by recent debugfs cleanup. Thanks, Dave Eric Ren (1): dlm: fix malfunction of dlm_tool caused by debugfs changes fs/dlm/debug_fs.c

[GIT PULL] dlm fixes for 4.9

2016-10-10 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.9 This includes a bug fix for a bad memory access during workqueue cleanup, which can happen while shutting down the dlm networking layer. (This was found and fixed in the past

[GIT PULL] dlm fixes for 4.10

2016-12-12 Thread David Teigland
Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes.

Re: linux-next: Signed-off-by missing for commits in the dlm tree

2017-09-18 Thread David Teigland
On Tue, Sep 19, 2017 at 07:49:19AM +1000, Stephen Rothwell wrote: > Hi David, > > Commits > > bcc976a145c9 ("DLM: Eliminate CF_CONNECT_PENDING flag") > c071b28b2bd5 ("DLM: Eliminate CF_WRITE_PENDING flag") > 782551aac851 ("DLM: Fix saving of NULL callbacks") > > are missing a

Re: [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-09 Thread David Teigland
On Sat, Oct 07, 2017 at 03:26:11AM +0100, Al Viro wrote: > On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > > and the function call path is: > > dlm_master_lookup (acquire the spinlock) > >

[GIT PULL] dlm updates for 4.14

2017-09-05 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.14 This set includes a bunch of minor code cleanups that have accumulated, probably from code analyzers people like to run. There is one nice fix that avoids some socket leaks

[GIT PULL] dlm updates for 4.15

2017-11-13 Thread David Teigland
, starting, and stopping. Thanks, Dave Bob Peterson (3): DLM: Eliminate CF_CONNECT_PENDING flag DLM: Eliminate CF_WRITE_PENDING flag DLM: Fix saving of NULL callbacks David Teigland (1): dlm: remove dlm_send_rcom_lookup_dump Guoqing Jiang (1): dlm: recheck

[GIT PULL] dlm updates for 4.18

2018-06-04 Thread David Teigland
Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.18 These three commits fix and clean up the flags dlm was using on its SCTP sockets. The result improves the performance and fixes some bad connection delays. Thanks, Dave

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-04-02 Thread David Teigland
On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: > Hello David, > > Do you agree to add this prompt to the user? > Since sometimes customers attempted to setup SCTP protocol with two rings, > but they could not get the expected result, then it maybe bring some concerns > to the

[PATCH 00/14] GFS

2005-08-02 Thread David Teigland
Hi, GFS (Global File System) is a cluster file system that we'd like to see added to the kernel. The 14 patches total about 900K so I won't send them to the list unless that's requested. Comments and suggestions are welcome. Thanks http://redhat.com/~teigland/gfs2/20050801/gfs2-full.patch

Re: [PATCH 00/14] GFS

2005-08-02 Thread David Teigland
On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: > * The on disk structures are defined in terms of uint32_t and friends, > which are NOT endian neutral. Why are they not le32/be32 and thus > endian-defined? Did you run bitwise-sparse on GFS yet ? GFS has had proper endian

Re: [PATCH 00/14] GFS

2005-08-03 Thread David Teigland
On Tue, Aug 02, 2005 at 01:16:53PM +0300, Pekka Enberg wrote: > > +void *gmalloc_nofail_real(unsigned int size, int flags, char *file, > > + unsigned int line) > > +{ > > + void *x; > > + for (;;) { > > + x = kmalloc(size, flags); > > + if (x) > > +

Re: [PATCH 00/14] GFS

2005-08-03 Thread David Teigland
On Wed, Aug 03, 2005 at 11:17:09AM +0200, Arjan van de Ven wrote: > On Wed, 2005-08-03 at 11:56 +0800, David Teigland wrote: > > The point is you can define GFS2_ENDIAN_BIG to compile gfs to be BE > > on-disk instead of LE which is another useful way to verify endian

Re: [PATCH 00/14] GFS

2005-08-05 Thread David Teigland
On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: > * +static const uint32_t crc_32_tab[] = . > why do you duplicate this? The kernel has a perfectly good set of > generic crc32 tables/functions just fine The gfs2_disk_hash() function and the crc table on which it's based are

Re: [PATCH 00/14] GFS

2005-08-05 Thread David Teigland
On Fri, Aug 05, 2005 at 09:34:38AM +0200, Arjan van de Ven wrote: > On Fri, 2005-08-05 at 15:14 +0800, David Teigland wrote: > > On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: > > > > > * +static const uint32_t crc_32_tab[] = . > > > why

Re: [PATCH 00/14] GFS

2005-08-05 Thread David Teigland
On Fri, Aug 05, 2005 at 12:07:50PM +0200, J?rn Engel wrote: > On Fri, 5 August 2005 17:44:52 +0800, David Teigland wrote: > > Do we go a step beyond this and use say the crc32() function from > > linux/crc32.h? Is this _function_ as standard and unchanging as the table > >

Re: [PATCH 00/14] GFS

2005-08-08 Thread David Teigland
On Fri, Aug 05, 2005 at 03:14:15PM +0800, David Teigland wrote: > On Tue, Aug 02, 2005 at 09:45:24AM +0200, Arjan van de Ven wrote: > > * +++ b/fs/gfs2/fixed_div64.h 2005-08-01 14:13:08.009808200 +0800 > > e why? > > I'm not sure, actually, apart from the

Re: [PATCH 00/14] GFS

2005-08-08 Thread David Teigland
On Wed, Aug 03, 2005 at 09:44:06AM +0300, Pekka Enberg wrote: > > +uint32_t gfs2_hash(const void *data, unsigned int len) > > +{ > > + uint32_t h = 0x811C9DC5; > > + h = hash_more_internal(data, len, h); > > + return h; > > +} > > Is there a reason why you cannot use or ? See

Re: GFS

2005-08-08 Thread David Teigland
On Mon, Aug 08, 2005 at 01:18:45PM +0300, Pekka J Enberg wrote: > gfs2-02.patch:+ RETRY_MALLOC(ip = kmem_cache_alloc(gfs2_inode_cachep, > -> GFP_NOFAIL. Already gone, inode_create() can return an error. if (create) { RETRY_MALLOC(page = grab_cache_page(aspace->i_mapping, index),

Re: GFS

2005-08-08 Thread David Teigland
On Mon, Aug 08, 2005 at 01:57:55PM +0300, Pekka J Enberg wrote: > David Teigland writes: > >> but why can't you return NULL here on failure like you do for > >> find_lock_page()? > > > >because create is set > > Yes, but looking at (some of the) top-level

Re: GFS

2005-08-09 Thread David Teigland
On Mon, Aug 08, 2005 at 05:14:45PM +0300, Pekka J Enberg wrote: if (!dumping) down_read(>mmap_sem); > >+ > >+ for (vma = find_vma(mm, start); vma; vma = vma->vm_next) { > >+ if (end <= vma->vm_start) > >+

<    1   2   3   4   >