[PATCH 03/19] dlm: don't print common non-errors

Change log_error() to log_debug() for conditions that can occur in large number in normal operation. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 7bc6ad9..6

[PATCH 04/19] dlm: use dlm prefix on alloc and free functions

The dlm functions in memory.c should use the dlm_ prefix. Also, use kzalloc/kfree directly for dlm_direntry's, removing the wrapper functions. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c | 10 +- fs/dlm/lock.c | 26 +-

[PATCH 08/19] dlm: use fixed errno values in messages

the platform-specific ones at the other end. Many thanks to Fabio for testing this patch. Initial patch from Patrick. Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]> Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs

[PATCH 09/19] dlm: clear ast_type when removing from astqueue

time. Appears when process calls libdlm dlm_release_lockspace() which first closes the ls dev triggering clear_proc_locks, and then removes the ls (a write to control dev) causing release_lockspace(). Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |1 + 1 files chan

[PATCH 05/19] dlm: close othercons

onn': Can't free all objects" and the DLM cannot be restarted without a system reboot. See bz#428119 Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]> Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lowcom

[PATCH 07/19] dlm: swap bytes for rcom lock reply

From: Fabio M. Di Nitto <[EMAIL PROTECTED]> DLM_RCOM_LOCK_REPLY messages need byte swapping. Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/util.c |9 ++--- 1 files changed, 6 insertions(+), 3 deleti

[PATCH 06/19] dlm: align midcomms message buffer

From: Fabio M. Di Nitto <[EMAIL PROTECTED]> gcc does not guarantee that a static buffer is 64bit aligned. This change allows sparc64 to work. Signed-off-by: Fabio M. Di Nitto <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/midcomms.c |2 +

[PATCH 10/19] dlm: recover locks waiting for overlap replies

start doing recovery in the presence of a many overlapping unlock/cancel ops. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 4

[PATCH 12/19] dlm: reject messages from non-members

an error message, and could in some cases change some state, causing problems. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |9 - fs/dlm/member.c |4 ++-- fs/dlm/member.h |3 ++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/fs/dlm/

[PATCH 11/19] dlm: another call to confirm_master in receive_request_reply

When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of retried, there may be other lkb's waiting on the rsb_lookup list for it to complete. A call to confirm_master() is needed to move on to the next waiting lkb since the current one won't be retried. Signed-off-by: David

[PATCH 16/19] dlm: fix possible use-after-free

The dlm_put_lkb() can free the lkb and its associated ua structure, so we can't depend on using the ua struct after the put. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/user.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/dlm/user.c b/

[PATCH 13/19] dlm: validate messages before processing

for an old message to be processed and caught by these checks. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c | 139 ++-- 1 files changed, 104 insertions(+), 35 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c

[PATCH 18/19] dlm: keep cached master rsbs during recovery

keep rsb's in their toss list that they are the master of. These rsb's need to be included when the resource directory is rebuilt during recovery. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c | 66 +--- fs/dlm/lock.c

[PATCH 19/19] dlm: Sanity check namelen before copying it

field). This patch restricts the length of the name to the amount of data actually passed into the call. Signed-off-by: Patrick Caulfield <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/user.c | 12 +--- 1 files changed, 9 insertions(+), 3 deleti

[PATCH 17/19] dlm: change error message to debug

The invalid lockspace messages are normal and can appear relatively often. They should be suppressed without debugging enabled. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/

[PATCH 15/19] dlm: limit dir lookup loop

, the infinite loop is dangerous since some other unknown condition may appear causing the loop to never break. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c

[PATCH 02/19] dlm: proper prototypes

From: Adrian Bunk <[EMAIL PROTECTED]> This patch adds a proper prototype for some functions in fs/dlm/dlm_internal.h Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dlm_internal.h | 16 fs/dlm/loc

[PATCH 14/19] dlm: reject normal unlock when lock is waiting for lookup

Non-forced unlocks should be rejected if the lock is waiting on the rsb_lookup list for another lock to establish the master node. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/dlm/lo

Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote: > > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote: > > void dlm_rcom_in(struct dlm_rcom *rc) > > { > > struct dlm_header *hd = (struct dlm_header *) rc; > &g

Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply

On Sat, Jan 26, 2008 at 10:00:29PM -0800, Andrew Morton wrote: > > On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <[EMAIL PROTECTED]> wrote: > > void dlm_rcom_in(struct dlm_rcom *rc) > > { > > struct dlm_header *hd = (struct dlm_header *) rc; > &g

[GIT PULL] dlm updates for 2.6.25

are mostly relevant for other applications. There are no new features, only fixes for various bugs or problems. They stem mainly from mixed architecture testing, and new tests that overlap recovery with userland stress tests. Thanks, Dave Adrian Bunk (1): dlm: proper prototypes David

[PATCH 00/16] dlm patches for 2.6.25 (batch 2)

m: dlm/user.c input validation fixes David Teigland (2): dlm: proper types for asts and basts dlm: eliminate astparam type casting Denis Cheng (1): dlm: add __init and __exit marks to init and exit functions fs/dlm/ast.c |9 ++-- fs/dlm/config.c |2 +-

[PATCH 04/16] dlm: do not byteswap rcom_config

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dlm_internal.h |6 +++--- fs/dlm/rcom.c | 15 --- fs/dlm/util.c | 20 3 files chan

[PATCH 07/16] dlm: validate data in dlm_recover_directory()

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c inde

[PATCH 02/16] dlm: dlm_process_incoming_buffer() fixes

From: Al Viro <[EMAIL PROTECTED]> * check that length is large enough to cover the non-variable part of message or rcom resp. (after checking that it's large enough to cover the header, of course). * kill more pointless casts Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-o

[PATCH 03/16] dlm: do not byteswap rcom_lock

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dlm_internal.h | 22 +++--- fs/dlm/lock.c | 34 +++--- fs/dlm/rcom.c | 14

[PATCH 08/16] dlm: verify that places expecting rcom_lock have packet long enough

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |3 +++ fs/dlm/rcom.c | 12 +++- 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/fs/dlm/lock.c b/f

[PATCH 06/16] dlm: missing length check in check_config()

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/rcom.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index 3f9b96f..a312f1d 1

[PATCH 13/16] dlm: dlm/user.c input validation fixes

From: Al Viro <[EMAIL PROTECTED]> a) in device_write(): add sentinel NUL byte, making sure that lspace.name will be NUL-terminated b) in compat_input() be keep it simple about the amounts of data we are copying. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teig

[PATCH 05/16] dlm: use proper type for ->ls_recover_buf

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |2 +- fs/dlm/dlm_internal.h |2 +- fs/dlm/rcom.c | 11 ++- fs/dlm/recover.c |4 ++-- 4

[PATCH 01/16] dlm: use proper C for dlm/requestqueue stuff (and fix alignment bug)

gnment. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |2 +- fs/dlm/requestqueue.c | 12 ++-- fs/dlm/requestqueue.h |2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/dlm/lock

[PATCH 09/16] dlm: receive_rcom_lock_args() overflow check

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6c605fc..0593dd8 1

[PATCH 10/16] dlm: make find_rsb() fail gracefully when namelen is too large

tually oops before that while calculating hash of up to 64Kb worth of data - with data actually being 64 _bytes_ in kmalloc()'ed struct. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |6 +- 1 files changed,

[PATCH 12/16] dlm: fix dlm_dir_lookup() handling of too long names

From: Al Viro <[EMAIL PROTECTED]> ... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is not a good way to handle them. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/dir.c |3 +++ 1 files cha

[PATCH 11/16] dlm: fix overflows when copying from ->m_extra to lvb

From: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/lock.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 6d98cf9..5b82187 1

[PATCH 15/16] dlm: eliminate astparam type casting

Put lkb_astparam in a union with a dlm_user_args pointer to eliminate a lot of type casting. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/debug_fs.c |6 ++ fs/dlm/dlm_internal.h |5 - fs/dlm/lock.c | 14 ++ fs/dlm/memory.c

[PATCH 14/16] dlm: proper types for asts and basts

Use proper types for ast and bast functions, and use consistent type for ast param. Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/ast.c |9 +++ fs/dlm/dlm_internal.h | 14 +--- fs/dlm/lock.c

[PATCH 16/16] dlm: add __init and __exit marks to init and exit functions

From: Denis Cheng <[EMAIL PROTECTED]> it moves 365 bytes from .text to .init.text, and 30 bytes from .text to .exit.text, saves memory. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/dlm/config.c|2 +- fs/dlm/

[GIT PULL] dlm updates for 2.6.25 (batch 2)

dlm: receive_rcom_lock_args() overflow check dlm: make find_rsb() fail gracefully when namelen is too large dlm: fix overflows when copying from ->m_extra to lvb dlm: fix dlm_dir_lookup() handling of too long names dlm: dlm/user.c input validation fixes David Teigland (2):

[PATCH 0/6] dlm patches for 3.6

patch is made possible by the dirtbl removal, and fixes a long standing race between resource removal and lookup by reworking how removal is done. At the same time it improves the shrink function efficiency by avoiding repeated searches through hash buckets. David Teigland (6): dlm: use

[PATCH 6/6] dlm: fix missing dir remove

-off-by: David Teigland --- fs/dlm/lock.c | 70 +++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 04e3f15..b569507 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -4000,12 +4000,70 @@ static

[PATCH 5/6] dlm: fix conversion deadlock from recovery

The process of rebuilding locks on a new master during recovery could re-order the locks on the convert queue, creating an "in place" conversion deadlock that would not be resolved. Fix this by not considering queue order when granting conversions after recovery. Signed-off-by: Davi

[PATCH 4/6] dlm: use wait_event_timeout

Use wait_event_timeout to avoid using a timer directly. Signed-off-by: David Teigland --- fs/dlm/recover.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c index ff6f276..12702cc 100644 --- a/fs/dlm

[PATCH 3/6] dlm: fix race between remove and lookup

has been sent. A lookup checks if this in-progress remove matches the name it is looking up. Signed-off-by: David Teigland --- fs/dlm/dlm_internal.h | 13 fs/dlm/lock.c | 181 +++-- fs/dlm/lockspace.c| 21 +- 3 files changed

[PATCH 2/6] dlm: use idr instead of list for recovered rsbs

When a large number of resources are being recovered, a linear search of the recover_list takes a long time. Use an idr in place of a list. Signed-off-by: David Teigland --- fs/dlm/dlm_internal.h |3 ++ fs/dlm/lockspace.c|3 ++ fs/dlm/rcom.c |2 +- fs/dlm/recover.c

Re: [PATCH] dlm: convert add_sock routine return value type to void

On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote: > Since add_sock() always returns a success code - 0, its return > value type should be changed from integer to void. Thanks, I've pushed those to my next branch. Dave -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] dlm: cleanup send_to_sock routine

On Mon, Aug 13, 2012 at 02:29:55PM +0800, Ying Xue wrote: > But I have submitted another patch: > https://lkml.org/lkml/2012/8/9/668 Yes I got it, to see all the patches I've pushed out, check here:

Re: [PATCH 2/2] [RESENDING] fs/ocfs2: get rid of unnecessary initialization

On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote: > On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote: > > default_groups was allocated with kcalloc, so initialize to NULL > > is unnecessary. > > NACK - this isn't a performance critical section of code and that line makes >

Re: [2.6 patch] make dlm_print_rsb() static

On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote: > dlm_print_rsb() can now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, added to dlm.git. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set

On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote: > cluster_set is only called from the macro CLUSTER_ATTR which defines > read/write > access functions. Make the signedness match to avoid sparse warnings every > time > CLUSTER_ATTR is used (lines 149-159) all of the form: > >

Re: linux-next: Tree for Feb 19

On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote: > We are up to 26 trees, more are welcome (even if they are currently empty). dlm (distributed lock manager) tree: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next Dave -- To unsubscribe from this list: send

Re: linux-next: Tree for Feb 19

On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote: > Hi David, > > On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland <[EMAIL PROTECTED]> wrote: > > > > dlm (distributed lock manager) tree: > > > > git://git.kernel.org/pub/scm/linux/kerne

[GIT PULL] dlm fixes for 2.6.25-rc2

insertions(+), 2 deletions(-) commit d7c2feaf88df39124e278b9e775b245b057ac99e Author: David Teigland <[EMAIL PROTECTED]> Date: Thu Feb 21 15:27:09 2008 -0600 dlm: update git tree in MAINTAINERS Signed-off-by: David Teigland <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b

[GIT PULL] dlm updates for 3.6

through a hash bucket. The other commits include minor fixes and changes. Thanks, Dave David Teigland (6): dlm: use rsbtbl as resource directory dlm: use idr instead of list for recovered rsbs dlm: fix race between remove and lookup dlm: use wait_event_timeout dlm: fix

[GIT PULL] dlm updates for 3.7

both access configfs data simultaneously. The second reworks some code to get around a long standing, but intentional, unlock balance warning. The userland daemon no longer takes a lock that is later released from the kernel. The other commits are minor fixes and changes. Thanks, Dave David

Re: [PATCH 1/4] sctp: add sctp_sock_set_nodelay

On Fri, May 29, 2020 at 02:09:40PM +0200, Christoph Hellwig wrote: > Add a helper to directly set the SCTP_NODELAY sockopt from kernel space > without going through a fake uaccess. Ack, they look fine to me, thanks. Dave

[GIT PULL] dlm updates for 5.8

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.8 This set includes a couple minor cleanups, and dropping the interruptible from a wait_event that waits for an event from the userspace cluster management. Thanks, Dave Arnd

Re: [GIT PULL] dlm updates for 5.3

On Wed, Jul 10, 2019 at 09:05:21PM -0700, Linus Torvalds wrote: > If wait_event_interruptible() returns -ERESTARTSYS, it means that we > have a signal pending. > > And if we have a signal pending, then you can't go back and call > wait_event_interruptible() in a loop, because the signal will >

[GIT PULL] dlm updates for 5.3 (second try)

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-5.3 This set removes some unnecessary debugfs error handling, and checks that lowcomms workqueues are not NULL before destroying. (Dropped the commits related to incorrect

Re: is it ok to always pull in sctp for dlm, was: Re: [PATCH 27/33] sctp: export sctp_setsockopt_bindx

On Thu, May 14, 2020 at 12:40:40PM +0200, Christoph Hellwig wrote: > On Wed, May 13, 2020 at 03:00:58PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 13, 2020 at 08:26:42AM +0200, Christoph Hellwig wrote: > > > And call it directly from dlm instead of going through kernel_setsockopt. > >

[GIT PULL] dlm updates for 4.18

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.18 These three commits fix and clean up the flags dlm was using on its SCTP sockets. The result improves the performance and fixes some bad connection delays. Thanks, Dave

[GIT PULL] dlm updates for 4.21

. Thanks, Dave Bob Peterson (1): dlm: Don't swamp the CPU with callbacks queued during recovery David Teigland (2): dlm: fix missing idr_destroy for recover_idr dlm: fix invalid cluster name warning Denis V. Lunev (1): dlm: fix possible call to kfree() for non-initialized

[GIT PULL] dlm updates for 3.19

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.19 This set includes one feature, which allows locks that have been orphaned to be reacquired. Thanks, Dave David Teigland (1): dlm: adopt orphan locks fs/dlm/lock.c

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Mon, Aug 03, 2015 at 07:13:26PM -0700, Guenter Roeck wrote: > - Some watchdogs have a very short maximum timeout, in the range of just a few > seconds. Such low timeouts are difficult if not impossible to support from > user space. Drivers supporting such watchdog hardware need to implement

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Wed, Aug 05, 2015 at 10:41:51AM -0700, Guenter Roeck wrote: > Not really. The heartbeats will be generated such that the watchdog expires > no later that . I > discussed > this already with Uwe; he had the same concern. This isn't in the current > version of the patch set, but it will be in

Re: [PATCH 0/8] watchdog: Add support for keepalives triggered by infrastructure

On Wed, Aug 05, 2015 at 12:01:38PM -0700, Guenter Roeck wrote: > I think I can understand why Wim was reluctant to accept your patch; > I must admit I don't understand your use case either. Very breifly, sanlock is a shared storage based lease manager, and the expiration of a lease is tied to the

[GIT PULL] dlm updates for 4.3

are also included. The other notable fix is for a long standing regression in the behavior of lock value blocks for user space locks. Thanks, Dave Bob Peterson (1): dlm: print error from kernel_sendpage David Teigland (1): dlm: fix lvb copy for user locks Marcelo Ricardo Leitner (6

[GIT PULL] dlm updates for 3.18

(v2: add cc lkml) Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.18 This includes a single commit fixing a missing endian conversion. Thanks, Dave Neale Ferguson (1): dlm: fix missing endian conversion of

Re: [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

On Tue, Nov 04, 2014 at 08:08:52AM -0500, Steven Rostedt wrote: > On Wed, 29 Oct 2014 17:56:07 -0400 > Steven Rostedt wrote: > > > From: Joe Perches > > > > [ REQUEST FOR ACKS ] > > Can any of the DLM maintainers give me an Acked-by for this? Looks ok, Dave -- To unsubscribe from this list:

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > Do you consider take the following clean up? If yes, I will send a > formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. > - to_nodeid =

Re: clustered MD

When a node fails, its dirty areas get special treatment from other nodes using the area_resyncing() function. Should the suspend_list be created before any reads or writes from the file system are processed by md? It seems to me that gfs journal recovery could read/write to dirty regions (from

clustered MD

I've just noticed the existence of clustered MD for the first time. It is a major new user of the dlm, and I have some doubts about it. When did this appear on the mailing list for review? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: clustered MD

On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > On 06/09/2015 01:22 PM, David Teigland wrote: > >I've just noticed the existence of clustered MD for the first time. > >It is a major new user of the dlm, and I have some doubts about it. > >When did this

Re: clustered MD

On Tue, Jun 09, 2015 at 03:08:11PM -0500, Goldwyn Rodrigues wrote: > Hi David, > > On 06/09/2015 02:45 PM, David Teigland wrote: > >On Tue, Jun 09, 2015 at 02:26:25PM -0500, Goldwyn Rodrigues wrote: > >>On 06/09/2015 01:22 PM, David Teigland wrote: > >>

Re: clustered MD

On Tue, Jun 09, 2015 at 10:33:08PM -0500, Goldwyn Rodrigues wrote: > >>>some real world utility to warrant the potential maintenance effort. > >> > >>We do have a valid real world utility. It is to provide > >>high-availability of RAID1 storage over the cluster. The > >>distributed locking is

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote: > The remove_from_waiters could only be invoked after failed to > create_message, right? > Since send_message always returns 0, this patch doesn't touch anything > about the failure > path, and it also doesn't change the original

Re: clustered MD

On Wed, Jun 10, 2015 at 10:27:27AM -0500, Goldwyn Rodrigues wrote: > I thought I answered that: > To use a software RAID1 across multiple nodes of a cluster. Let me > explain in more words.. > > In a cluster with multiple nodes with a shared storage, such as a > SAN. The shared device becomes a

Re: clustered MD

On Wed, Jun 10, 2015 at 11:23:25AM -0500, Goldwyn Rodrigues wrote: > To start with, the goal of (basic) MD RAID1 is to keep the two > mirrored device consistent _all_ of the time. In case of a device > failure, it should degrade the array pointing to the failed device, > so it can be

Re: clustered MD

On Wed, Jun 10, 2015 at 12:05:33PM -0500, David Teigland wrote: > Separate bitmaps for each node sounds like a much better design than the > cmirror design which used a single shared bitmap (I argued for using a > single bitmap when cmirror was being designed.) Sorry misspoke, I argue

Re: clustered MD

On Thu, Jun 11, 2015 at 06:31:31AM +1000, Neil Brown wrote: > What is your interest in this? I'm always happy for open discussion and > varied input, but it would help to know to what extent you are a stake > holder? Using the dlm correctly is non-trivial and should be reviewed. If the dlm is

Re: clustered MD

On Wed, Jun 10, 2015 at 04:07:44PM -0500, David Teigland wrote: > > Also a slightly less adversarial tone would make me feel more > > comfortable, though maybe I'm misreading your intent. > > You're probably misreading "concerned". > > The initial responses t

[GIT PULL] dlm fixes for 4.8

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8-fixes This fixes a bug introduced by recent debugfs cleanup. Thanks, Dave Eric Ren (1): dlm: fix malfunction of dlm_tool caused by debugfs changes fs/dlm/debug_fs.c

[GIT PULL] dlm fixes for 4.9

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.9 This includes a bug fix for a bad memory access during workqueue cleanup, which can happen while shutting down the dlm networking layer. (This was found and fixed in the past

[GIT PULL] dlm fixes for 4.10

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.10 This set fixes error reporting for dlm sockets, removes the unbound property on the dlm callback workqueue to improve performance, and includes a couple trivial changes.

[GIT PULL] dlm fixes for 4.6

Hi Linus, Please pull dlm fixes from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6-fixes This fixes a bug from the configfs cleanup. Thanks, Dave Andrew Price (1): dlm: config: Fix ENOMEM failures in make_cluster() fs/dlm/config.c | 3 +-- 1 file

[GIT PULL] dlm updates for 4.8

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.8 This set includes two trivial changes, one to use kmemdup and another to control the log level of recovery messages. Thanks, Dave Amitoj Kaur Chawla (1): dlm: Use

[GIT PULL] dlm updates for 4.6

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.6 Previous changes introduced the use of socket error reporting for dlm sockets. This set includes two fixes in how the socket error callbacks are used. Thanks, Dave Bob

[GIT PULL] dlm updates for 4.4

Hi Linus, Please pull dlm updates from tag: git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-4.4 This includes one simple fix to make posix locks interruptible by signals in cases where a signal handler is used. Thanks, Dave Eric Ren (1): dlm: make posix locks

Re: [PATCH -next] fs: dlm: fix missing unlock on error in accept_from_sock()

On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote: > Add the missing unlock before return from accept_from_sock() > in the error handling case. Thanks, applied to the next branch. Dave > Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection") > Reported-by: Hulk Robot >

<    1   2   3   4