> but, we still want to go through entire list.
Shouldn't you break the loop immediately after you found the bus and sent ioctl?
Maybe I'm missing something, but I see no reason to continue iterating
after the bus was found (even though you don't do anything and just
compare IDs and "continue").
-
> First of all, please, split per subsystem / driver. Here seems one
> file — one patch.
Sure, will do.
>> if (size > max_size) {
>> dev_err(pcie->dev,
>> -"res size 0x%pap exceeds max supported size 0x%llx\n",
>> +"res size %pap exceeds max supported size 0x
Do not use "0x" in front of %pa, %pap and %pad to avoid
duplicate "0x" in the output.
Signed-off-by: Dmitry V. Krivenok
---
drivers/dma/at_hdmac_regs.h | 2 +-
drivers/i2c/busses/i2c-st.c | 2 +-
drivers/nvdimm/pmem.c | 2 +-
drivers/of/fdt.c | 2 +-
drivers/pci/host/pci
>> A recent patch tried to improve the printk output of the atc_dump_lli()
>> function but introduced a bug
BTW, my original patch was created for mainline and was incorrectly
applied to slave-dma.git for-linus branch (I sent Vinod an email about
that).
In that branch the code was already changed
> + if (IS_ENABLED(CONFIG_ACPI_NFIT_DEBUG)) {
> + dev_dbg(dev, "%s:%s cmd: %d input length: %d\n", __func__,
> + dimm_name, cmd, in_buf.buffer.length);
> + print_hex_dump_debug("cmd: ", DUMP_PREFIX_OFFSET, 4,
> +
> Is your concern readibility or size of generated code (or both?)
>
> I'll look to consolidating the debug printing in next version as additional
> patch.
Just a minor style comment, not critical.
> If we had a longer list, I would definitely say yes. Not so sure with
> just two types. I'll t
6 matches
Mail list logo
