[RFC/RFT 0/5] Input locking patches

2007-07-23 Thread Dmitry Torokhov
Hi everyone, I finally managed to put together some patches implementing locking in input core and main input handles. Please look over them and give them a spin. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mous

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files change

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/e

[RFC/RFT 3/5] Input: tsdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: tsdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/tsdev.c | 392 +++--- 1 files changed, 278 insertions(+), 114 deletions(-) Index: work/drivers/input/t

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/jo

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: > > spin_lock_irq() should generally be avoided. > > In cases like the first case -- input_repeat_key() -- you are making > incorrect assumptions about the state of interrupts. The other cases > are probably ok, but in general spin_l

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-24 Thread Dmitry Torokhov
On 7/24/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: > On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote: > >>> This is a royal pain, since it now throws an ERROR for the obviously >>> preferable piece of code below: >>> >>> if (err) { >>> do_so

Re: Kernel 2.6.23-rc1: strange error messages in dmesg using a PS2 mouse

2007-07-24 Thread Dmitry Torokhov
Hi Uwe, On 7/24/07, Uwe Bugla <[EMAIL PROTECTED]> wrote: Hi everybody, I am using kernel 2.6.23-rc1 with a Logitech PS2 mouse. Although the mouse is fully functionable the following strange error messages appear in dmesg: psmouse: Unknown symbol serio_reconnect psmouse: Unknown symbol serio_op

Re: [PATCH] fix return value of i8042_aux_test_irq

2007-07-26 Thread Dmitry Torokhov
Hi, On 7/26/07, Fernando Luis Vázquez Cao <[EMAIL PROTECTED]> wrote: I made an interesting finding while testing the two patches below. http://lkml.org/lkml/2007/7/19/685 http://lkml.org/lkml/2007/7/19/687 These patches modify the traditional CONFIG_DEBUG_KERNEL in such a way that the request_

[git pull] Input updates for 2.6.23-rc4

2007-08-30 Thread Dmitry Torokhov
Hi Linus, Please consider pulling from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates to the input subsystem. Changelog: - Adrian Bunk (1): Input: p

Re: [2.6 patch] make the dummy touchkit_ps2_detect() static

2007-08-30 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 14 August 2007 17:22, Adrian Bunk wrote: > The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case > shouldn't be a global function. > Applied, thank you. Btw, sorry for the long silence - I had a hard drive crash and the day after I restored everything t

Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver

2007-08-31 Thread Dmitry Torokhov
Hi Jesper, On 8/30/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 31/08/2007, Satyam Sharma <[EMAIL PROTECTED]> wrote: > ... > > > > Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y? > > Arrgh, I messed that one up real good... Thank you for your keen eye Satyam > :-) > > > >

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 04 September 2007 19:34, Adrian McMenamin wrote: > This patch will add support for the Dreamcast keyboard when used > alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and > the pvr2 patch. > > Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> > Thnank you

Re: ALPS touchpad with new Dell not recognised

2007-09-04 Thread Dmitry Torokhov
Hi, On Saturday 04 August 2007 18:45, William Pettersson wrote: > Hi, > This patch adds support for the Alps touchpad on my Dell Vostro 1400 to > the linux kernel. > > Signed-off-by: William Pettersson <[EMAIL PROTECTED]> Applied, thank you William. -- Dmitry - To unsubscribe from this list: s

Re: [PATCH] Input: i8042 - add HP Pavilion DV4270ca to the MUX blacklist

2007-09-04 Thread Dmitry Torokhov
On Monday 03 September 2007 17:47, Elvis Pranskevichus wrote: > This fixes "atkbd.c: Suprious NAK on isa0060/serio0" errors for > HP Pavilion DV4270ca. Same reasons as for > 9d9d50bb2efb50594abfc3941a5504b62c514ebd > and 6e782584e0713ea89da151333e7fe754c8f40324. > > Signed-off-by: Elvis Pranskevi

Re: Fwd: [PATCH] IdealTEK URTC1000 support for usbtouchscreen

2007-09-04 Thread Dmitry Torokhov
On Monday 27 August 2007 18:07, Daniel Ritz wrote: > > OK, so here's the new patch, inline this time: > > thanks. looks fine now. forwarding to Dmitry for mainline inclusion... > Applied, thank you. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] 10-dots braille keyboards

2007-09-04 Thread Dmitry Torokhov
On Monday 20 August 2007 20:38, Samuel Thibault wrote: > Hi, > > Some braille keyboards have 10 dots, so extend the Input braille keys > definitions. > > Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> > Applied, thank you Samuel. -- Dmitry - To unsubscribe from this list: send the line "u

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Mike, On Wednesday 05 September 2007 00:34, Mike Frysinger wrote: > > + kbd->dev = input_allocate_device(); > > ... > > + retval = input_register_device(kbd->dev); > > + if (unlikely(retval)) > > + goto cleanup; > > ... > > +      cleanup: > > + kfree(kbd); > > +

Re: Kernel 2.6.22.6 iPod conflict with PS/2 device.

2007-09-05 Thread Dmitry Torokhov
Hi Justin, On 9/5/07, Justin Piszcz <[EMAIL PROTECTED]> wrote: > > > On Wed, 5 Sep 2007, Satyam Sharma wrote: > > > > > > > On Fri, 31 Aug 2007, Justin Piszcz wrote: > > > >> When I have an iPod attached via USB to an ABIT IC7-G board before it > >> boots up > >> and let X start etc, the mouse (P

Re: [PATCH] [input] USB touchscreen

2007-09-06 Thread Dmitry Torokhov
On Thursday 06 September 2007 17:29, Vladimir Shebordaev wrote: > This patch fixes a nasty typo in usbtouchscreen driver. > > The typo is inherited from the original mtouchusb. It > used to make the input subsytem to incorrectly > report the physical device ids to userspace that in turn > is much

Re: [RFC/RFT 0/5] Input locking patches

2007-07-28 Thread Dmitry Torokhov
Hi Indan, On Friday 27 July 2007 18:25, Indan Zupancic wrote: > Sorry for the babbling, just wanted to say that I've tested these > patches and that they seem to fix real problems. > Thank you for testing the patches. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-28 Thread Dmitry Torokhov
Hi Indan, On Friday 27 July 2007 19:28, Indan Zupancic wrote: > Hi, > > Not real feedback, just some nitpicks. > > On Tue, July 24, 2007 06:45, Dmitry Torokhov wrote: > > +static int input_defuzz_abs_event(int value, int old_val, int fuzz) > > +{ > > + if (

Re: [PATCH] TSDEV - Don't flood dmesg with removal warnings

2007-07-28 Thread Dmitry Torokhov
Hi Parag, On Friday 27 July 2007 10:43, Parag Warudkar wrote: > Ignore my previous whitespace damaged patch. This one should be good. > > tsdev.c warns about scheduled removal each time tsdev_open is called - > So even for a default boot I get to see the warning 3 times - > > [ 340.537078] tsde

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-28 Thread Dmitry Torokhov
On Friday 27 July 2007 16:12, Andrew Morton wrote: > On Fri, 27 Jul 2007 21:43:59 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > Sure, but why is the locking interruptible rather than plain old > > > mutex_lock()? > > > > Hm, well. We hold this mutex for several seconds, as writing tak

Re: [PATCH] fix return value of i8042_aux_test_irq

2007-07-28 Thread Dmitry Torokhov
On Thursday 26 July 2007 11:57, [EMAIL PROTECTED] wrote: > On Fri, July 27, 2007 12:29 am, Alan Cox wrote: > >> > A small number of boxes do share IRQ12 and it was switched to shared > >> for > >> > them. > >> If that is the case interrupt handlers should be able to determine > >> whether > >> a ce

Re: Power button policy and mechanism

2007-10-19 Thread Dmitry Torokhov
Hi Richard, On Friday 19 October 2007, Richard Purdie wrote: > On Tue, 2007-10-16 at 10:34 -0400, Dmitry Torokhov wrote: > > On 10/16/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: > > > This is mainly an embedded issue, but I feel it's quite important. > >

Re: [PATCH 1/3] leds-clevo-mail: export i8042_command()

2007-10-21 Thread Dmitry Torokhov
Hi, On Friday 19 October 2007, Németh Márton wrote: > From: Márton Németh <[EMAIL PROTECTED]> > > Export the i8042_command() function which manages the mutual exclusion > with the help of the i8042_lock spinlock. This lets possible to use the > i8042 hardware safely from other part of the kernel,

Re: [PATCH 10/17] drivers/input/serio/i8042.c: irq handler clean

2007-10-21 Thread Dmitry Torokhov
Hi Jeff, On Sunday 21 October 2007, Jeff Garzik wrote: > commit bdf311215ef8dbae0254c092deaed1d5928b013e > Author: Jeff Garzik <[EMAIL PROTECTED]> > Date: Fri Oct 19 19:28:54 2007 -0400 > > drivers/input/serio/i8042.c: irq handler clean > > * remove unnecessary prototype > >

[git pull] Input updates for 2.6.24-rc0 (part 2)

2007-10-21 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Changelog: - Anton Ekblad (1): Input: appletouch

Re: [PATCH 1/1] INPUT/BF54x-KEYPAD driver: Remove useless line -errno returned by irq_request

2007-10-21 Thread Dmitry Torokhov
On Thursday 18 October 2007, Bryan Wu wrote: > From: Michael Hennerich <[EMAIL PROTECTED]> > > Cc: Andrey Panin <[EMAIL PROTECTED]> > Signed-off-by: Michael Hennerich <[EMAIL PROTECTED]> > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Applied, thank you Michael, Bryan. -- Dmitry - To unsubscribe

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-23 Thread Dmitry Torokhov
Hi Ryan, On 9/28/07, Ryan Lortie <[EMAIL PROTECTED]> wrote: > > Hello. > > I have been working on a more flexible system for blocking the delivery > of input events to other agents in the system. > > My approach is basically summed up as follows: > > - split the current purpose of input_handle in

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-23 Thread Dmitry Torokhov
On 10/18/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Thu, 18 Oct 2007, Dmitry Torokhov wrote: > > On 10/17/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > > Still, I was > > > thinking about it, and a doubt came to mind: wou

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-23 Thread Dmitry Torokhov
On 10/23/07, Ryan Lortie <[EMAIL PROTECTED]> wrote: > On Tue, 2007-23-10 at 09:21 -0400, Dmitry Torokhov wrote: > > Priority/filter idea is different matter. I don't think it is a giood > > solution. There will always be an "arms race", new applications would &

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-23 Thread Dmitry Torokhov
On Tuesday 23 October 2007, Ryan Lortie wrote: > On Tue, 2007-23-10 at 14:10 -0400, Dmitry Torokhov wrote: > > No, rfkill want to see keypresses, period. It does not care if there > > are other applications also seeing the same keypresses, it just does > > not want keyp

Re: New version of Elantech touchpad driver for kernel 2.6.23.1

2007-10-23 Thread Dmitry Torokhov
On Tuesday 23 October 2007, Arjan Opmeer wrote: > @@ -88,6 +88,7 @@ enum psmouse_type { > PSMOUSE_LIFEBOOK, > PSMOUSE_TRACKPOINT, > PSMOUSE_TOUCHKIT_PS2, > +   PSMOUSE_ELANTECH, > PSMOUSE_CORTRON, > PSMOUSE_AUTO/* This one should always be las

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: > > Hi Bryan, > > > > On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > + > [snip] > > > + > > > +static void ad71

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Bryan, On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > + > +static int > +ad7142_probe(struct i2c_adapter *adap, int addr, int kind) > +{ > + struct i2c_client *client; > + int rc; > + > + client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL); > + if (!client) > +

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Ahmed, On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: > > > > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> > > --- > > Hi Bryan, > > Why creating module's own kthread to call ad7142_decode and process keycodes > instead of usi

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote: > > On 10/12/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: > > > > Hi Bryan, >

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: > > > > > Isn't disabling device interrupts from the begining of the ISR > > > "ad7142_interrupt" > > > till the

[git pull] Input updates for 2.6.24-rc0

2007-10-13 Thread Dmitry Torokhov
): Input: usbtouchscreen - support DMC devices with empty EEPROM Dmitry Torokhov (18): Input: xpad - use le16_to_cpup when parsing data stream Input: mark some functions __must_check Input: implement proper locking in input core Input: evdev - implement proper locking

Re: [PATCH] Input: Refactor evdev 32bit compat to be shareable with uinput

2007-10-15 Thread Dmitry Torokhov
Hi Philip, On 10/13/07, Philip Langdale <[EMAIL PROTECTED]> wrote: > Currently, evdev has working 32bit compatibility and uinput does not. uinput > needs the input_event code that evdev uses, so let's refactor it so it can > be shared. > Looks very good, thank you. I just think that we should kee

Re: [patch 2/8] m68k: Atari keyboard ACIA driver cleanup

2007-10-15 Thread Dmitry Torokhov
1,5 @@ > > > /* > > > - * linux/atari/atakeyb.c > > > + * linux/arch/m68k/atari/atakeyb.c > > > > Please kill that line. > > Done. New version below: > > Subject: m68k: Atari keyboard ACIA driver cleanup > Cc: Dmitry Torokhov <[EMAIL PROTECTED

Re: [patch 1/8] m68k: Atari input drivers cleanup

2007-10-15 Thread Dmitry Torokhov
Hi Geert, On 10/13/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > m68k: Atari input drivers cleanup: > - memleak on failed init/register of input devices fixed > - correct keycodes table (Atari keycodes are almost, but not entirely, equal >to Linux keycodes). > > Signed-off-by: Michael

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
Hi Bryan, On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > + > +static int ad7142_thread(void *nothing) > +{ > + do { > + wait_for_completion(&ad7142_completion); > + ad7142_decode(); > + enable_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX); > + } while

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-15 Thread Dmitry Torokhov
Hi Michael, On 10/15/07, Hennerich, Michael <[EMAIL PROTECTED]> wrote: > > > >> + > >> +static int ad7877_read(struct device *dev, u16 reg) > >> +{ > >> + struct spi_device *spi = to_spi_device(dev); > >> + struct ser_req *req = kzalloc(sizeof *req, > GFP_KERNEL); > > >

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > Completion is just not a good abstraction here... Please use work > > abstraction and possibly a separate workqueue. > > Yes, I agree with yo

Re: [git pull] Input updates for 2.6.24-rc0

2007-10-15 Thread Dmitry Torokhov
On 10/13/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Hi Linus, > > Please pull from: > >git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus > or >master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus > >

Re: [git pull] Input updates for 2.6.24-rc0

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Mon, 15 Oct 2007, Dmitry Torokhov wrote: > > > > *ping* > > Thanks, pulled and pushed out. > > Can you check that applesmc looks sane after the merge conflict? The > conflict itself looked p

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
Hi Henrique, On 10/16/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 16 Oct 2007, Matthew Garrett wrote: > > On Mon, Oct 15, 2007 at 07:07:37PM -0200, Henrique de Moraes Holschuh wrote: > > > And the input subsystem maintainer has made it extremely clear in various > > > thre

Re: Power button policy and mechanism

2007-10-16 Thread Dmitry Torokhov
Hi Kristoffer, On 10/16/07, Kristoffer Ericson <[EMAIL PROTECTED]> wrote: > Greetings Dmitry, > > Is the suggested approach on handling powerbutton (in keyboard driver) to > simply push out the event and let userland handle it? Yes. > The reason Im asking this is because as you might know Im ma

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Tue, Oct 16, 2007 at 10:27:11AM -0400, Dmitry Torokhov wrote: > > > I want to add the ability to add "filetrs" to i8042 keyboard ports so > > that certain bytes that represent state changes (battery

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On 10/16/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > On 10/15/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > On 10/15/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Tue, 16 Oct 2007, Matthew Garrett wrote: > > > > > > It still doesn't mean it belongs inside the stream of data for the > > > keyboard, > > > maskerading as a key press. > > > > But it *is* a key press! > > To get somewhat back on tra

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > And unless Dmitry agrees with Linus' suggestion (maybe as a temporary > stopgap while something better gets written?), we are not going anywhere, > anyway. "Nothing is more permanent than a temporary soution" (not sure who sai

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Jeremy Katz <[EMAIL PROTECTED]> wrote: > On Tue, 2007-10-16 at 16:12 -0400, Dmitry Torokhov wrote: > > On 10/16/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Tue, 16 Oct 2007, Matthew Garrett wrote: > > > > > > > > >

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Tue, Oct 16, 2007 at 01:48:54PM -0700, Kok, Auke wrote: > > > real life example: hook up one of those fancy usb keyboards with volume > > buttons to > > your thinkpad. The volume keys on the thinkpad do adjust the volume, the > > ones o

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-17 Thread Dmitry Torokhov
On 10/16/07, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Tue, 16 Oct 2007, Dmitry Torokhov wrote: > > > > I agree that these are 2 different events. My argument is that > > "VOLUME_UP_NOTIFY" event is similar to "BATTERY_OUT_NOTIFY", > &g

Re: [PATCH try #4] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-17 Thread Dmitry Torokhov
Hi Bryan, On 10/17/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > Subject: [PATCH try #4] Input/Joystick Driver: add support AD7142 joystick > driver > My comments are in addition to Jean's: > + > +static void ad7142_close(struct input_dev *dev) > +{ > + struct ad7142_data *data = input_get_dr

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-17 Thread Dmitry Torokhov
On 10/17/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Wed, 17 Oct 2007, Matthew Garrett wrote: > > On Wed, Oct 17, 2007 at 11:57:18AM -0400, Dmitry Torokhov wrote: > > > say that they only care about notifications arising from keypresses > > >

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-18 Thread Dmitry Torokhov
On 10/17/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > Still, I was > thinking about it, and a doubt came to mind: would it cause problems for a > bitmap to share the function for EV_foo and EV_foo notifications? > Not sure if I follow... Are you talking about bringing KEY_*_NOTIFY

Re: kernel processes - are they really needed?

2007-11-01 Thread Dmitry Torokhov
On Wednesday 31 October 2007 13:33, Andi Kleen wrote: > "Dmitry Torokhov" <[EMAIL PROTECTED]> writes: > > > On 10/24/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > >> > >> My favourite for a ridiculous thread was and is "kpsmoused" >

[git pull] Input updates for 2.6.24-rc1

2007-11-02 Thread Dmitry Torokhov
- fix section mismatch Carlos Corbacho (1): Input: Add Euro and Dollar key codes Dmitry Torokhov (2): Input: appletouch - idle reset logic broke older Fountains Input: linux-input mailing list moved to vger.kernel.org Helge Deller (1): Input: inport, logibm - use KERN_INFO

Re: 2.6.22: pcspkr driver no longer loads automatically

2007-11-03 Thread Dmitry Torokhov
rather in arch setup code it is right (and safe) thing to do. -- Dmitry pcspkr: restore uevent generation Make sure that we generate uevents when creating pcspkr devices so that userspace will load pcspkr driver. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- arch/alpha/ker

Re: 2.6.23: no more free evdev devices - evdev leak?

2007-11-06 Thread Dmitry Torokhov
On Nov 5, 2007 10:13 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 31 Oct 2007 16:34:44 + Soeren Sonnenburg <[EMAIL PROTECTED]> > wrote: > > > Dear all, > > (cc's added) > > > > whenever I do a suspend resume cycle the input device's numbers are > > increased until I finally run out o

Re: 2.6.20-rc5: usb mouse breaks suspend to ram

2007-01-16 Thread Dmitry Torokhov
On 1/16/07, Pavel Machek <[EMAIL PROTECTED]> wrote: Hi! I started using el-cheapo usb mouse... only to find out that it breaks suspend to RAM. Suspend-to-disk works okay. I was not able to extract any usefull messages... Resume process hangs; I can still switch console and even type on keyboard

Re: 2.6.20-rc5: usb mouse breaks suspend to ram

2007-01-16 Thread Dmitry Torokhov
On 1/16/07, Pavel Machek <[EMAIL PROTECTED]> wrote: Hi! > >I started using el-cheapo usb mouse... only to find out that it breaks > >suspend to RAM. Suspend-to-disk works okay. I was not able to extract > >any usefull messages... > > > >Resume process hangs; I can still switch console and even t

Re: [PATCH] pc110pad: return proper error

2006-12-20 Thread Dmitry Torokhov
On Tuesday 19 December 2006 03:44, Akinobu Mita wrote: > According to the comment, "if we find any PCI devices in the machine, > we don't have a PC110" in pc110pad.c, we should return -ENODEV > rather than -ENOENT in this case. > Applied, thank you. -- Dmitry - To unsubscribe from this list: se

Re: [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver

2006-12-22 Thread Dmitry Torokhov
On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: On Thursday 21 December 2006 5:08 am, Nicolas Ferre wrote: > > Let me try to sort out the mess with those updates, and ask you to refresh > > this ads7843 support against that more-current ads7846 code. > > Ok, let me know when you have a ne

Re: [patch 2.6.20-rc1 3/6] input: ads7846 more compatible with hwmon

2006-12-22 Thread Dmitry Torokhov
On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: Be more compatible with the hwmon framework: - Hook up to hwmon * show sensor attrubites only if hwmon is present * otherwise be just a touchscreen - Report voltages per hwmon convention * measure in millivolts * voltages a

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-22 Thread Dmitry Torokhov
On 12/22/06, David Brownell <[EMAIL PROTECTED]> wrote: +static void ads7846_report_pen_state(struct ads7846 *ts, int down) +{ + struct input_dev*input_dev = ts->input; + + input_report_key(input_dev, BTN_TOUCH, down); + if (!down) + input_report_abs(input_

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-24 Thread Dmitry Torokhov
On Sunday 24 December 2006 09:27, Pavel Machek wrote: > > perhaps printk('Binary only modules are not allowed by kernel license, > but copyright law may still allow them in special cases. Be careful, Come again? > Greg is going tuo sue you at beggining of 2008 if you get it wrong.') > would be a

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-28 Thread Dmitry Torokhov
On Thursday 28 December 2006 16:45, Rene Herman wrote: > Dave Jones wrote: > > > On Wed, Dec 27, 2006 at 10:32:53PM +0100, Rene Herman wrote: > > >> The bug where the kernel repetitively emits "atkbd.c: Spurious ACK > >> on isa0060/serio0. Some program might be trying access hardware > >> directl

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-28 Thread Dmitry Torokhov
On Thursday 28 December 2006 23:20, Rene Herman wrote: > Dmitry Torokhov wrote: > > > The change to suppress ACKs from paic blinking is already in Linus's > > tree. I just tried booting with root=/dev/sdg and I had leds blinking > > but no messages from atkbd were se

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-28 Thread Dmitry Torokhov
On Friday 29 December 2006 00:17, Rene Herman wrote: > Dmitry Torokhov wrote: > > >>> The change to suppress ACKs from paic blinking is already in Linus's > >>> tree. I just tried booting with root=/dev/sdg and I had leds blinking > >>> but no mess

Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state

2006-12-28 Thread Dmitry Torokhov
, the measured voltage agreed with a multimeter to several decimal places. Signed-off-by: David Brownell <[EMAIL PROTECTED]> Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/touchscreen/Kconfig |9 - drivers/input/touchscreen/ads7846.c | 306 +++

Re: Display class

2006-12-29 Thread Dmitry Torokhov
Hi, On Tuesday 05 December 2006 13:03, James Simmons wrote: > +int probe_edid(struct display_device *dev, void *data) > +{ > +   struct fb_monspecs spec; > +   ssize_t size = 45; const ssize_t size = 45? > + > +   dev->name = kzalloc(size, GFP_KERNEL); Why do you need kzalloc here?

Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK

2006-12-29 Thread Dmitry Torokhov
s commands we sent to it and these ACKs reach atkbd causing it to complain. Somehow you get 2 ACks in a row, I wonder if on your boxes i8042 pumps command and data into keyboard before i8042_interrupt gets a chance to run. Could you please apply the debug patch below and tell me

[git pull] Input patches for 2.6.20-rc3

2007-01-01 Thread Dmitry Torokhov
framework Dmitry Torokhov (1): Input: i8042 - really suppress ACK/NAK during panic blink Imre Deak (5): Input: ads7846 - pluggable filtering logic Input: ads7846 - optionally leave Vref on during differential measurements Input: ads7846 - switch to using hrtimer Input

Re: OT Coffee (was Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2007-01-02 Thread Dmitry Torokhov
On 1/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: On Tue, 02 Jan 2007 20:30:17 +0100, Geert Uytterhoeven said: > > > 2) there had, for a decade prior, been some *700* cases where people > > > had burned themselves with mcdonald's coffee, so it's not as if > > > mcdonald's was unaware of th

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Dmitry Torokhov
On 2/21/07, CIJOML <[EMAIL PROTECTED]> wrote: Hi, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Dmitry Torokhov
On 2/21/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: Hi Dmitry, > > can anybody reply to this and share his/her opinion? > > Input core already exports uniq to udev and also via sysfs. so do you think it would be better to create phys as a string of the source and destination address like "-"

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-22 Thread Dmitry Torokhov
Hi Marcel, On 2/21/07, Marcel Holtmann <[EMAIL PROTECTED]> wrote: Hi Dmitry, > > > > can anybody reply to this and share his/her opinion? > > > > > > Input core already exports uniq to udev and also via sysfs. > > > > so do you think it would be better to create phys as a string of the > > sour

Re: 2.6.21rc1 git usb mouse stops working after resume from ram

2007-02-22 Thread Dmitry Torokhov
On 2/21/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: # # USB HID Boot Protocol drivers # CONFIG_USB_KBD=m CONFIG_USB_MOUSE=m Please do not enable USB boot protocol drivers unless generic HID driver is not working for you. -- Dmitry - To unsubscribe from this list: send the line "unsubsc

Re: BUG: 2.6.20 atkbd spams console after kernel panic

2007-02-22 Thread Dmitry Torokhov
On 2/22/07, Mark Lord <[EMAIL PROTECTED]> wrote: The kernel panic is my fault, but I'd still like to see the on-screen messages when it happens. Unfortunately, 2.6.20 atkbd.c continuously spams the console after a kernel panic (my fault), with these messages: ... kernel panic - not syncing: VFS

Re: input.c: start on release

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle->handler->start) handle->handler->start(handle); } Is the above supposed to be

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Milind Choudhary wrote: > On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: >> > +#define BITWRAP(nr)(1UL << ((nr) % BITS_PER_LONG)) >> > >> > & make the whole input subsystem use it >> > The change is huge, more than 125 files usi

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Dmitry Torokhov wrote: > On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: >> Milind Choudhary wrote: >> > On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: >> >> > +#

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Dmitry Torokhov wrote: > I was not talking about name (I hate BITWRAP) but behavior. Oh, my bad :) > >> but mainly since it only enables wrapping of the long-type. > > I'd provde BIT and separate LLBIT for o

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Dmitry Torokhov wrote: > > Hm, I thought as was clear, but apparently I messed up explaining my > position: > > 1. I don't like BITWRAP name at all and I don't want anything like > that near input code. I t

Re: input.c: start on release

2007-02-24 Thread Dmitry Torokhov
On Friday 23 February 2007 19:44, Pete Zaitcev wrote: > On Fri, 23 Feb 2007 10:06:14 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> > wrote: > > On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > > void input_release_device(struct input_hand

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-24 Thread Dmitry Torokhov
On Saturday 24 February 2007 06:11, Vojtech Pavlik wrote: > > The reason I don't like it with modulo is simply because it hides > > potential bugs (when x is to big). > > That would be my only concern - losing compiler warnings. > I think most dangerous scenario is when both shift operands are

Re: [KJ][RFC][PATCH] BIT macro cleanup

2007-02-24 Thread Dmitry Torokhov
On Saturday 24 February 2007 07:59, Richard Knutsson wrote: > Vojtech Pavlik wrote: > > On Fri, Feb 23, 2007 at 11:43:44PM +0100, Richard Knutsson wrote: > > > > > >> Is the reason for the modulo to put a bitmask larger then the variable > >> into an array? > >> > > > > The complementary L

Re: Fwd: Using serio_register_driver

2007-02-28 Thread Dmitry Torokhov
On 2/27/07, Fausto Carvalho <[EMAIL PROTECTED]> wrote: Well, i have a 8042 controller "connected" to the keyboard controller that send information about battery and others to the keyboard interrupt and io ports in the format of keystrokes. I want a way to not alter atkbd but to create another dri

Re: [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver

2007-02-28 Thread Dmitry Torokhov
On Tuesday 20 February 2007 04:19, Nicolas Ferre wrote: > Add support for the ads7843 touchscreen controller to the ads7846 > driver code. Applied to the input tree, thank you. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: PROBLEM: "BUG:" when resuming from suspend-to-ram

2007-02-28 Thread Dmitry Torokhov
an evdev problem ... > Please try the patch below. -- Dmitry Input: use krefs for refcounting in input handlers This should fix problems whith accessing memory already freed by another thread. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]>

Re: [PATCH] wistron button support for fujitsu-siemens Amilo D88x0

2007-02-06 Thread Dmitry Torokhov
On 2/5/07, Michael Leun <[EMAIL PROTECTED]> wrote: On Mon, 5 Feb 2007 10:35:21 +0100 Michael Leun <[EMAIL PROTECTED]> wrote: > Hello, > > works just fine for me on a Amilo D8820. > Michael, Could you please resend your patch with "Signed-off-by: ..." line and I will apply it. Thanks! -- Dm

Re: [PATCH 9/11] Panic delay fix

2007-02-07 Thread Dmitry Torokhov
On 2/6/07, Zachary Amsden <[EMAIL PROTECTED]> wrote: Andi Kleen wrote: > On Mon, Feb 05, 2007 at 07:53:30PM -0800, Zachary Amsden wrote: > >> Failure to use real-time delay here causes the keyboard to become demonically >> possessed in the event of a kernel crash, with wildly blinking lights and

Re: [PATCH 9/11] Panic delay fix

2007-02-08 Thread Dmitry Torokhov
On 8 Feb 2007 14:33:21 +0100, Andi Kleen <[EMAIL PROTECTED]> wrote: On Thu, Feb 08, 2007 at 01:08:14AM -0800, Zachary Amsden wrote: > Andi Kleen wrote: > >On Wed, Feb 07, 2007 at 02:31:57PM -0800, Zachary Amsden wrote: > > > >>Dmitry Torokhov wrote: > >> &g

<    6   7   8   9   10   11   12   13   14   15   >