Re: [PATCH] Input: serio - Add ARC PS/2 driver

2012-10-16 Thread Dmitry Torokhov
Hi Mischa, On Tue, Oct 16, 2012 at 05:44:58PM +0200, Mischa Jonker wrote: This adds support for the PS/2 block that is used in various ARC FPGA platforms. This looks very nicem just a few comments below. Signed-off-by: Mischa Jonker mischa.jon...@synopsys.com ---

Re: [PATCH RESEND 0/8] TI Touchscreen driver updates and Support for TSC/ADC MFD driver

2012-10-16 Thread Dmitry Torokhov
Hi Rachna, On Tue, Oct 16, 2012 at 12:55:37PM +0530, Patil, Rachna wrote: This patch set is a cumulative set of [1] and [2] sent earlier. I have merged the patch set so that the MFD patches apply without any issues. Also Note that there are no code changes in either of the patch set, only

Re: [PATCH] Input: serio - Add ARC PS/2 driver

2012-10-18 Thread Dmitry Torokhov
Hi Mischa, On Wed, Oct 17, 2012 at 12:10:19PM +0200, Mischa Jonker wrote: This adds support for the PS/2 block that is used in various ARC FPGA platforms. Thank you for making changes. A few more comments below. Signed-off-by: Mischa Jonker mischa.jon...@synopsys.com ---

Re: [RFC][PATCH 2/6] lockdep: validate rcu_dereference() vs rcu_read_lock()

2007-09-21 Thread Dmitry Torokhov
On 9/20/07, Paul E. McKenney [EMAIL PROTECTED] wrote: On Thu, Sep 20, 2007 at 01:31:35PM -0400, Dmitry Torokhov wrote: OK, then what is the purpose of synchronize_sched() in -rt? To wait for all preempt-disable, irq-disable, hard-irq, and SMI/NMI code sequences to complete. OK, so what

[git pull] Input updates for 2.6.23-rc8

2007-09-24 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. There is only one patch that fixes regression in appletouch

Re: [git pull] Input updates for 2.6.23-rc8

2007-09-25 Thread Dmitry Torokhov
On 9/25/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 25 Sep 2007, Dmitry Torokhov wrote: Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive

Re: 2.6.23 /proc/bus/input/devices content question

2007-09-25 Thread Dmitry Torokhov
Hi Michael, On 9/25/07, Michael Guntsche [EMAIL PROTECTED] wrote: Hi, After upgrading to 2.6.23-rc7 for testing purposes I noticed that the contents of /proc/bus/input/devices changed a little bit. I now have the following entries for my USB-keyboard P:

Re: 2.6.23 /proc/bus/input/devices content question

2007-09-25 Thread Dmitry Torokhov
On 9/25/07, Michael Guntsche [EMAIL PROTECTED] wrote: On Sep 25, 2007, at 19:51, Dmitry Torokhov wrote: Hi Michael, ... I this a wanted change or should I still see the same with 2.6.23? Is this with CONFIG_SYSFS_DEPRECATED=y? No, CONFIG_SYSFS_DEPRECATED is not set with both

Re: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver

2007-09-26 Thread Dmitry Torokhov
Hi Bryan, Michael, On 9/25/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Date: Sun, 5 Aug 2007 18:45:26 +0800 Subject: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver Thank you for the patch. Couple of comments: + +static void

Re: xpad_probe: undefined reference to `led_classdev_register'

2007-09-26 Thread Dmitry Torokhov
: xpad - fix dependancy on LEDS class The driver can not be built-in when LEDS class is a module. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/joystick/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: work/drivers/input/joystick/Kconfig

Re: [PATCH] input: move gameports out of SERIO menu

2007-10-02 Thread Dmitry Torokhov
Hi Randy, On Tuesday 02 October 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Move the gameport support menu out of the SERIO menu and put it between touchscreens and misc. devices in the main input layer menu. Change it to use menuconfig instead of config. Or was it

[PATCH for 2.6.23] Driver core: fix regression with SYSFS_DEPRECTATED

2007-10-07 Thread Dmitry Torokhov
Subject: Driver core: fix SYSF_DEPRECATED breakage for nested classdevs From: Dmitry Torokhov [EMAIL PROTECTED] We should only reparent to a class former class devices that form the base of class hierarchy. Nested devices should still grow from their real parents. Signed-off-by: Dmitry Torokhov

Re: [PATCH] Fix Oops in toshiba_acpi error return path

2007-10-07 Thread Dmitry Torokhov
On Sunday 07 October 2007, Andrey Borzenkov wrote: This fixes oops when registering backlight device fails. Attached as I still cannot convince kmail to not mangle long lines ... -andrey Re: kmail - it usually behaves well with the patches as long as you turn off word wrapping and use

Re: [PATCH try #2] Blackfin BF54x Input Keypad controller driver

2007-10-09 Thread Dmitry Torokhov
Hi Bryan, On 10/4/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Blackfin BF54x Input Keypad controller driver: [try #2] Changelog: - Coding style issue fixes - using a temp variable for bf54x_kpad-input - Other updates according to Dmitry's review I

Re: First stab at Elantech touchpad driver for 2.6.22.6. Testers wanted!

2007-10-09 Thread Dmitry Torokhov
Hi Arjan, On 9/13/07, Arjan Opmeer [EMAIL PROTECTED] wrote: Hi!, This is a first stab at a Linux driver for the Elantech touchpad as found on some laptops (e.g. MSI MS-1035 aka L725). This is great! Thank you very much for your effort. Since the touchpad supports absolute mode I'd

Re: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver

2007-08-31 Thread Dmitry Torokhov
Hi Jesper, On 8/30/07, Jesper Juhl [EMAIL PROTECTED] wrote: On 31/08/2007, Satyam Sharma [EMAIL PROTECTED] wrote: ... Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y? Arrgh, I messed that one up real good... Thank you for your keen eye Satyam :-) [ I didn't know

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 04 September 2007 19:34, Adrian McMenamin wrote: This patch will add support for the Dreamcast keyboard when used alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and the pvr2 patch. Signed off by: Adrian McMenamin [EMAIL PROTECTED] Thnank you very

Re: ALPS touchpad with new Dell not recognised

2007-09-04 Thread Dmitry Torokhov
Hi, On Saturday 04 August 2007 18:45, William Pettersson wrote: Hi, This patch adds support for the Alps touchpad on my Dell Vostro 1400 to the linux kernel. Signed-off-by: William Pettersson [EMAIL PROTECTED] Applied, thank you William. -- Dmitry - To unsubscribe from this list: send

Re: [PATCH] Input: i8042 - add HP Pavilion DV4270ca to the MUX blacklist

2007-09-04 Thread Dmitry Torokhov
On Monday 03 September 2007 17:47, Elvis Pranskevichus wrote: This fixes atkbd.c: Suprious NAK on isa0060/serio0 errors for HP Pavilion DV4270ca. Same reasons as for 9d9d50bb2efb50594abfc3941a5504b62c514ebd and 6e782584e0713ea89da151333e7fe754c8f40324. Signed-off-by: Elvis Pranskevichus

Re: Fwd: [PATCH] IdealTEK URTC1000 support for usbtouchscreen

2007-09-04 Thread Dmitry Torokhov
On Monday 27 August 2007 18:07, Daniel Ritz wrote: OK, so here's the new patch, inline this time: thanks. looks fine now. forwarding to Dmitry for mainline inclusion... Applied, thank you. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] 10-dots braille keyboards

2007-09-04 Thread Dmitry Torokhov
On Monday 20 August 2007 20:38, Samuel Thibault wrote: Hi, Some braille keyboards have 10 dots, so extend the Input braille keys definitions. Signed-off-by: Samuel Thibault [EMAIL PROTECTED] Applied, thank you Samuel. -- Dmitry - To unsubscribe from this list: send the line

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Mike, On Wednesday 05 September 2007 00:34, Mike Frysinger wrote: + kbd-dev = input_allocate_device(); ... + retval = input_register_device(kbd-dev); + if (unlikely(retval)) + goto cleanup; ... +      cleanup: + kfree(kbd); + return -EINVAL;

Re: Kernel 2.6.22.6 iPod conflict with PS/2 device.

2007-09-05 Thread Dmitry Torokhov
Hi Justin, On 9/5/07, Justin Piszcz [EMAIL PROTECTED] wrote: On Wed, 5 Sep 2007, Satyam Sharma wrote: On Fri, 31 Aug 2007, Justin Piszcz wrote: When I have an iPod attached via USB to an ABIT IC7-G board before it boots up and let X start etc, the mouse (PS/2) does not

Re: [PATCH] [input] USB touchscreen

2007-09-06 Thread Dmitry Torokhov
On Thursday 06 September 2007 17:29, Vladimir Shebordaev wrote: This patch fixes a nasty typo in usbtouchscreen driver. The typo is inherited from the original mtouchusb. It used to make the input subsytem to incorrectly report the physical device ids to userspace that in turn is much

Re: [PATCH] Add suspend and resume to gpio_keys driver

2007-09-07 Thread Dmitry Torokhov
Hi Anti, On 9/6/07, Anti Sullin [EMAIL PROTECTED] wrote: diff -pur linux-2.6.23-rc5-old/drivers/input/keyboard/gpio_keys.c linux-2.6.23-rc5/drivers/input/keyboard/gpio_keys.c --- linux-2.6.23-rc5-old/drivers/input/keyboard/gpio_keys.c 2007-09-06 18:24:23.0 +0300 +++

Re: Platform device id

2007-09-07 Thread Dmitry Torokhov
Hi Jean, On 9/7/07, Jean Delvare [EMAIL PROTECTED] wrote: Hi Greg, all, While platform_device.id is a u32, platform_device_add() handles -1 as a special id value. This has potential for confusion and bugs. One such bug was reported to me by David Brownell:

Re: [PATCH 2/3] Maple bus support for the Sega Dreamcast - keyboard support

2007-09-09 Thread Dmitry Torokhov
(dc_kbd_driver.drv); is much shorter... +} + +static void __exit dc_kbd_exit(void) +{ + driver_unregister(dc_kbd_driver.drv); +} + +module_init(dc_kbd_init); +module_exit(dc_kbd_exit); If these are fixed you may add: Acked-by: Dmitry Torokhov [EMAIL PROTECTED] Thank you. -- Dmitry

Re: sysfs change of input/event devices in 2.6.23rc breaks udev

2007-09-09 Thread Dmitry Torokhov
break. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/base/core.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) Index: work/drivers/base/core.c === --- work.orig/drivers/base/core.c

Re: [PATCH] input: Fix interrupt enable in i8042_ctr when enabling interrupt fails

2007-09-10 Thread Dmitry Torokhov
Hi Steven, Markus, On 9/10/07, Steven Rostedt [EMAIL PROTECTED] wrote: -- On Mon, 10 Sep 2007, Markus Armbruster wrote: I believe this possible, but unlikely (perhaps not so unlikely on virtual machines). Scenarios involve enable succeeding the first time, failing the second time, and

Re: sysfs change of input/event devices in 2.6.23rc breaks udev

2007-09-10 Thread Dmitry Torokhov
On 9/10/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Sep 10, 2007 at 01:28:47AM -0400, Dmitry Torokhov wrote: On Sunday 09 September 2007 19:03, Kay Sievers wrote: On 9/8/07, Anssi Hannula [EMAIL PROTECTED] wrote: However, the change that broke id_path of udev is that /sys/class

Re: [PATCH 2/3] Maple bus support for the Sega Dreamcast - keyboard support

2007-09-10 Thread Dmitry Torokhov
On 9/10/07, Adrian McMenamin [EMAIL PROTECTED] wrote: On 10/09/2007, Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Adrian, Thanks for the comments - will get on with this but + for (i = 0; i NR_SCANCODES; i++) + kbd-keycode[i] = dc_kbd_keycode[i]; memcpy

Re: [PATCH 2/2] Maple bus support for the SEGA Dreamcast - Dreamcast keyboard support

2007-09-10 Thread Dmitry Torokhov
On 9/10/07, Adrian McMenamin [EMAIL PROTECTED] wrote: + + for (i = 0; i NR_SCANCODES; i++) + memcpy(kbd-keycode + i * sizeof(unsigned char), dc_kbd_keycode + i * sizeof(unsigned char), + sizeof(unsigned char)); Ahem... That's not what I had in

[git pull] Input updates for 2.6.23-rc6

2007-09-11 Thread Dmitry Torokhov
Hi Linus, Please consider pulling from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for input subsystem. Changelog: -- Elvis Pranskevichus (1):

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Andi Kleen [EMAIL PROTECTED] wrote: +static DEFINE_SPINLOCK(i8253_lock); + static __init int add_pcspkr(void) { struct platform_device *pd; @@ -1501,9 +1503,14 @@ static __init int add_pcspkr(void) if (!pd) return -ENOMEM; +pd-dev.platform_data = i8253_lock; That seems

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
Hi Geert, On 7/20/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk [EMAIL PROTECTED] wrote: On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: Hi Geert, On 7/20/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: From: Geert Uytterhoeven [EMAIL PROTECTED] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-20 Thread Dmitry Torokhov
On 7/20/07, Adrian Bunk [EMAIL PROTECTED] wrote: On Fri, Jul 20, 2007 at 02:51:02PM -0400, Dmitry Torokhov wrote: On 7/20/07, Adrian Bunk [EMAIL PROTECTED] wrote: On Fri, Jul 20, 2007 at 01:47:36PM -0400, Dmitry Torokhov wrote: Hi Geert, On 7/20/07, Geert Uytterhoeven [EMAIL PROTECTED

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-21 Thread Dmitry Torokhov
Hi Geert, On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing that declaration in linux/hid.h makes about the same sense as putting it into linux/scsi.h At first I

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: On Sun, 22 Jul 2007, Dmitry Torokhov wrote: On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: On Fri, 20 Jul 2007, Dmitry Torokhov wrote: I am OK with adding a new header file. I was just saying that placing

Re: [PATCH][08/37] Clean up duplicate includes in drivers/input/

2007-07-23 Thread Dmitry Torokhov
On Saturday 21 July 2007 11:02, Jesper Juhl wrote: Hi, This patch cleans up duplicate includes in drivers/input/ Applied to for-linus branch of input tree, thank you. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[RFC/RFT 0/5] Input locking patches

2007-07-23 Thread Dmitry Torokhov
Hi everyone, I finally managed to put together some patches implementing locking in input core and main input handles. Please look over them and give them a spin. -- Dmitry - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mousedev.c

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files changed, 585

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/evdev.c

[RFC/RFT 3/5] Input: tsdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: tsdev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/tsdev.c | 392 +++--- 1 files changed, 278 insertions(+), 114 deletions(-) Index: work/drivers/input/tsdev.c

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/joydev.c

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: spin_lock_irq() should generally be avoided. In cases like the first case -- input_repeat_key() -- you are making incorrect assumptions about the state of interrupts. The other cases are probably ok, but in general

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-24 Thread Dmitry Torokhov
On 7/24/07, Andy Whitcroft [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft [EMAIL PROTECTED] wrote: This is a royal pain, since it now throws an ERROR for the obviously preferable piece of code below: if (err) { do_something();

Re: Kernel 2.6.23-rc1: strange error messages in dmesg using a PS2 mouse

2007-07-24 Thread Dmitry Torokhov
Hi Uwe, On 7/24/07, Uwe Bugla [EMAIL PROTECTED] wrote: Hi everybody, I am using kernel 2.6.23-rc1 with a Logitech PS2 mouse. Although the mouse is fully functionable the following strange error messages appear in dmesg: psmouse: Unknown symbol serio_reconnect psmouse: Unknown symbol

Re: [PATCH] fix return value of i8042_aux_test_irq

2007-07-26 Thread Dmitry Torokhov
Hi, On 7/26/07, Fernando Luis Vázquez Cao [EMAIL PROTECTED] wrote: I made an interesting finding while testing the two patches below. http://lkml.org/lkml/2007/7/19/685 http://lkml.org/lkml/2007/7/19/687 These patches modify the traditional CONFIG_DEBUG_KERNEL in such a way that the

[git pull] Input updates for 2.6.23-rc4

2007-08-30 Thread Dmitry Torokhov
Hi Linus, Please consider pulling from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates to the input subsystem. Changelog: - Adrian Bunk (1): Input:

Re: [2.6 patch] make the dummy touchkit_ps2_detect() static

2007-08-30 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 14 August 2007 17:22, Adrian Bunk wrote: The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case shouldn't be a global function. Applied, thank you. Btw, sorry for the long silence - I had a hard drive crash and the day after I restored everything the

Re: [PATCH 1/3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-11 Thread Dmitry Torokhov
Hi Brian, Michael, On 10/11/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] Thank you for the patch. The formatting of the patch is unorthodox, could you please run it

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-11 Thread Dmitry Torokhov
Hi Bryan, Michael, On 10/11/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int gpio3 = 0; No need to initialize. + +static int ad7877_read(struct device *dev, u16 reg) +{ + struct spi_device *spi = to_spi_device(dev); + struct ser_req *req = kzalloc(sizeof

Re: [PATCH try #3] Blackfin BF54x Input Keypad controller driver

2007-10-11 Thread Dmitry Torokhov
;. Please let me know if you are OK with it. Thanks! Cc: Dmitry Torokhov [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- arch/blackfin/mach-bf548/boards/ezkit.c |2 +- drivers/input/keyboard/Kconfig |9

Re: [PATCH try #3] Blackfin BF54x Input Keypad controller driver

2007-10-11 Thread Dmitry Torokhov
Hi Michael, On 10/11/07, Hennerich, Michael [EMAIL PROTECTED] wrote: From: Dmitry Torokhov [mailto:[EMAIL PROTECTED] Sent: Donnerstag, 11. Oktober 2007 19:27 To: [EMAIL PROTECTED] Cc: Michael Hennerich; [EMAIL PROTECTED]; Linux Kernel; [EMAIL PROTECTED] Subject: Re: [PATCH try #3] Blackfin

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + [snip] + +static void ad7142_close(struct input_dev *dev) +{ + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int +ad7142_probe(struct i2c_adapter *adap, int addr, int kind) +{ + struct i2c_client *client; + int rc; + + client = kmalloc(sizeof(struct i2c_client), GFP_KERNEL); + if (!client) +

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Ahmed, On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's own kthread to call ad7142_decode and process keycodes instead of using a tasklet ?

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote: On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: Isn't disabling device interrupts from the begining of the ISR ad7142_interrupt till the kthread ad7142_thread got waked-up and scheduled a long time, espicially

[git pull] Input updates for 2.6.24-rc0

2007-10-13 Thread Dmitry Torokhov
): Input: usbtouchscreen - support DMC devices with empty EEPROM Dmitry Torokhov (18): Input: xpad - use le16_to_cpup when parsing data stream Input: mark some functions __must_check Input: implement proper locking in input core Input: evdev - implement proper locking

Re: [PATCH] Input: Refactor evdev 32bit compat to be shareable with uinput

2007-10-15 Thread Dmitry Torokhov
Hi Philip, On 10/13/07, Philip Langdale [EMAIL PROTECTED] wrote: Currently, evdev has working 32bit compatibility and uinput does not. uinput needs the input_event code that evdev uses, so let's refactor it so it can be shared. Looks very good, thank you. I just think that we should keep

Re: [patch 2/8] m68k: Atari keyboard ACIA driver cleanup

2007-10-15 Thread Dmitry Torokhov
/atari/atakeyb.c Please kill that line. Done. New version below: Subject: m68k: Atari keyboard ACIA driver cleanup Cc: Dmitry Torokhov [EMAIL PROTECTED], [EMAIL PROTECTED] m68k: Atari keyboard ACIA driver cleanup: - removed dead key autorepeat code - removed hardcoded initial keymap

Re: [patch 1/8] m68k: Atari input drivers cleanup

2007-10-15 Thread Dmitry Torokhov
Hi Geert, On 10/13/07, Geert Uytterhoeven [EMAIL PROTECTED] wrote: m68k: Atari input drivers cleanup: - memleak on failed init/register of input devices fixed - correct keycodes table (Atari keycodes are almost, but not entirely, equal to Linux keycodes). Signed-off-by: Michael Schmitz

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
Hi Bryan, On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: + +static int ad7142_thread(void *nothing) +{ + do { + wait_for_completion(ad7142_completion); + ad7142_decode(); + enable_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX); + } while

Re: [PATCH 2/3] Input/Touchscreen Driver: add support AD7877 touchscreen driver

2007-10-15 Thread Dmitry Torokhov
Hi Michael, On 10/15/07, Hennerich, Michael [EMAIL PROTECTED] wrote: + +static int ad7877_read(struct device *dev, u16 reg) +{ + struct spi_device *spi = to_spi_device(dev); + struct ser_req *req = kzalloc(sizeof *req, GFP_KERNEL); How many reads can

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/15/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Completion is just not a good abstraction here... Please use work abstraction and possibly a separate workqueue. Yes, I agree with you now, although I have a little concern about

Re: [git pull] Input updates for 2.6.24-rc0

2007-10-15 Thread Dmitry Torokhov
On 10/13/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You

Re: [git pull] Input updates for 2.6.24-rc0

2007-10-15 Thread Dmitry Torokhov
On 10/15/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Mon, 15 Oct 2007, Dmitry Torokhov wrote: *ping* Thanks, pulled and pushed out. Can you check that applesmc looks sane after the merge conflict? The conflict itself looked pretty trivial, and it compiles for me, but I'd still like

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
Hi Henrique, On 10/16/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Matthew Garrett wrote: On Mon, Oct 15, 2007 at 07:07:37PM -0200, Henrique de Moraes Holschuh wrote: And the input subsystem maintainer has made it extremely clear in various threads that

Re: Power button policy and mechanism

2007-10-16 Thread Dmitry Torokhov
Hi Kristoffer, On 10/16/07, Kristoffer Ericson [EMAIL PROTECTED] wrote: Greetings Dmitry, Is the suggested approach on handling powerbutton (in keyboard driver) to simply push out the event and let userland handle it? Yes. The reason Im asking this is because as you might know Im

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Tue, Oct 16, 2007 at 10:27:11AM -0400, Dmitry Torokhov wrote: I want to add the ability to add filetrs to i8042 keyboard ports so that certain bytes that represent state changes (battery events, wireless, etc.) can be diverted from

Re: [PATCH try #3] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/16/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 10/15/07, Bryan Wu [EMAIL PROTECTED] wrote: On 10/15/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: Completion is just not a good abstraction here... Please use work abstraction

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Matthew Garrett wrote: It still doesn't mean it belongs inside the stream of data for the keyboard, maskerading as a key press. But it *is* a key press! To get somewhat back on track: volume and

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: And unless Dmitry agrees with Linus' suggestion (maybe as a temporary stopgap while something better gets written?), we are not going anywhere, anyway. Nothing is more permanent than a temporary soution (not sure who said

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Jeremy Katz [EMAIL PROTECTED] wrote: On Tue, 2007-10-16 at 16:12 -0400, Dmitry Torokhov wrote: On 10/16/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Matthew Garrett wrote: It still doesn't mean it belongs inside the stream of data

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-16 Thread Dmitry Torokhov
On 10/16/07, Matthew Garrett [EMAIL PROTECTED] wrote: On Tue, Oct 16, 2007 at 01:48:54PM -0700, Kok, Auke wrote: real life example: hook up one of those fancy usb keyboards with volume buttons to your thinkpad. The volume keys on the thinkpad do adjust the volume, the ones on the USB

Re: [PATCH] Map volume and brightness events on thinkpads

2007-10-17 Thread Dmitry Torokhov
On 10/16/07, Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Dmitry Torokhov wrote: I agree that these are 2 different events. My argument is that VOLUME_UP_NOTIFY event is similar to BATTERY_OUT_NOTIFY, DOCK_UNDOCK_NOTIFY, etc, etc and should be sent not through input

Re: [PATCH try #4] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-17 Thread Dmitry Torokhov
Hi Bryan, On 10/17/07, Bryan Wu [EMAIL PROTECTED] wrote: Subject: [PATCH try #4] Input/Joystick Driver: add support AD7142 joystick driver My comments are in addition to Jean's: + +static void ad7142_close(struct input_dev *dev) +{ + struct ad7142_data *data =

Re: [RFC/RFT 0/5] Input locking patches

2007-07-28 Thread Dmitry Torokhov
Hi Indan, On Friday 27 July 2007 18:25, Indan Zupancic wrote: Sorry for the babbling, just wanted to say that I've tested these patches and that they seem to fix real problems. Thank you for testing the patches. -- Dmitry - To unsubscribe from this list: send the line unsubscribe

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-28 Thread Dmitry Torokhov
Hi Indan, On Friday 27 July 2007 19:28, Indan Zupancic wrote: Hi, Not real feedback, just some nitpicks. On Tue, July 24, 2007 06:45, Dmitry Torokhov wrote: +static int input_defuzz_abs_event(int value, int old_val, int fuzz) +{ + if (fuzz) { + if (value old_val - fuzz

Re: [PATCH] TSDEV - Don't flood dmesg with removal warnings

2007-07-28 Thread Dmitry Torokhov
Hi Parag, On Friday 27 July 2007 10:43, Parag Warudkar wrote: Ignore my previous whitespace damaged patch. This one should be good. tsdev.c warns about scheduled removal each time tsdev_open is called - So even for a default boot I get to see the warning 3 times - [ 340.537078] tsdev

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-28 Thread Dmitry Torokhov
On Friday 27 July 2007 16:12, Andrew Morton wrote: On Fri, 27 Jul 2007 21:43:59 +0200 Michael Buesch [EMAIL PROTECTED] wrote: Sure, but why is the locking interruptible rather than plain old mutex_lock()? Hm, well. We hold this mutex for several seconds, as writing takes this

Re: [PATCH] fix return value of i8042_aux_test_irq

2007-07-28 Thread Dmitry Torokhov
On Thursday 26 July 2007 11:57, [EMAIL PROTECTED] wrote: On Fri, July 27, 2007 12:29 am, Alan Cox wrote: A small number of boxes do share IRQ12 and it was switched to shared for them. If that is the case interrupt handlers should be able to determine whether a certain interrupt

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-26 Thread Dmitry Torokhov
Hi Jiri, On 4/23/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): For devices that require tailored application (for example that glove - I am not sure how a generic application could control it) old phantom way of controlling via ioctl will suffice. The device may still

Re: [RFC 1/2] Input: ff, add FF_RAW effect

2007-04-26 Thread Dmitry Torokhov
On 4/22/07, Jiri Slaby [EMAIL PROTECTED] wrote: On 4/19/07, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 4/19/07, Jiri Slaby [EMAIL PROTECTED] wrote: Dmitry Torokhov napsal(a): If we are interested in using FF API we need to come up with a way to express this effect without exposing

Re: i8042 controller on Toshiba Satellite P10 notebook - patch

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 1:20 PM, Stefan Seyfried [EMAIL PROTECTED] wrote: Jaco Kroon wrote: Dmitry Torokhov wrote: OT: I think I prefer synaptics multi-finger tapping to the tapping in specific locations to get right and middle clicking, but that is another story that probably has nothing to do

Re: i8042 controller on Toshiba Satellite P10 notebook - patch

2005-04-05 Thread Dmitry Torokhov
On Apr 5, 2005 4:01 PM, Jaco Kroon [EMAIL PROTECTED] wrote: btw Dmitri, that patch does not seem to work. But the kernel panic that kicks in when X starts up does imply that _something_ changed. No sync however, so no stack trace in the logs either. In fact, looking at the dmesg part of

Re: [BUG] 2.6.12-rc1/rc2 mouse0 became mouse1

2005-04-08 Thread Dmitry Torokhov
Hi, On Apr 8, 2005 6:58 AM, Ali Akcaagac [EMAIL PROTECTED] wrote: Hello, This doesn't sound right to me. After upgrading from 2.6.11.5/6 to 2.6.12-rc1/rc2 I detected that my mouse didn't operate anymore when loading up XOrg, I realized that /dev/input/mouse0 (which worked for years) had to

Re: [Bug?] Keyboard Problem

2005-04-11 Thread Dmitry Torokhov
Hi, On Monday 11 April 2005 18:45, Manu wrote: I'm currently using a 2.6.10 kernel (on a Debian Sarge, i386). I've compiled a 2.6.11.5 and a 2.6.11.7 kernels and my keyboard (a sweex SILVER MULTIMEDIA KEYBOARD, SW-23 -- PS/2 105 keys -- a classical keyboard) doesn't work with these kernels.

Re: [PATCH 0/5] I8K driver facelift

2005-04-13 Thread Dmitry Torokhov
On Thursday 24 March 2005 02:24, Greg KH wrote: On Thu, Mar 17, 2005 at 03:16:24AM -0500, [EMAIL PROTECTED] wrote: On Wed, 16 Mar 2005 14:38:50 MST, Frank Sorenson said: Okay, I replaced the sysfs_ops with ops of my own, and now all the show and store functions also accept the name of the

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Dmitry Torokhov
On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: It is still a problem if driver is registered after the port has been detected wich quite often is the case as many people have psmouse as a module. I wonder

Re: [PATCH] PNP support for i8042 driver

2005-02-05 Thread Dmitry Torokhov
On Saturday 05 February 2005 08:48, matthieu castet wrote: Hi, Vojtech Pavlik wrote: On Fri, Feb 04, 2005 at 06:37:29PM +0100, matthieu castet wrote: Hi, Vojtech Pavlik wrote: On Sat, Nov 13, 2004 at 02:23:53PM +0100, matthieu castet wrote: Hi, this patch add PNP support for

[RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-05 Thread Dmitry Torokhov
], 2005-02-05 14:33:05-05:00, [EMAIL PROTECTED] Input: psmouse - better handle bad transfers and interrupt delays by requesting resend of the last packet so we don't need to guess if received byte is remainder of last packet or start of a new one. Signed-off-by: Dmitry

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-05 Thread Dmitry Torokhov
On Saturday 05 February 2005 16:02, Vojtech Pavlik wrote: v On Wed, Jan 19, 2005 at 04:18:49PM -0500, Richard Koch wrote: Please include the patch below to bring the ICS MK712 touchscreen controller support, which is in kernel 2.4, in to kernel 2.6. This patch was constructed and applied

Re: Problem with trackpad and 2.6.11-rc[23], but not -rc1

2005-02-05 Thread Dmitry Torokhov
On Saturday 05 February 2005 21:14, Joseph Pingenot wrote: Hello. I just tried (again) to get the most recent kernel version working on my laptop. All is clear except for one small detail: the trackpad and mouse buttons don't work. When using the eraser mouse, it moves around fine.

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-05 Thread Dmitry Torokhov
On Saturday 05 February 2005 16:11, Vojtech Pavlik wrote: On Sat, Feb 05, 2005 at 02:48:56PM -0500, Dmitry Torokhov wrote: Hi, The patch below attempts to better handle situation when psmouse interrupt is delayed for more than 0.5 sec by requesting a resend. This will allow properly

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-05 Thread Dmitry Torokhov
On Sunday 06 February 2005 00:29, Dmitry Torokhov wrote: On Saturday 05 February 2005 16:11, Vojtech Pavlik wrote: On Sat, Feb 05, 2005 at 02:48:56PM -0500, Dmitry Torokhov wrote: Hi, The patch below attempts to better handle situation when psmouse interrupt is delayed for more

[PATCH] Add resume support to serio bus.

2005-02-05 Thread Dmitry Torokhov
in course of regular resume process. Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] i8042.c |8 serio.c | 17 + 2 files changed, 21 insertions(+), 4 deletions(-) === diff -Nru

<    1   2   3   4   5   6   7   8   9   10   >