Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
or
master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus
to receive updates for the input subsystem. Except for the largish
change to the ALPS driver adding Dolphin
On Tue, Mar 12, 2013 at 10:57:19PM +1100, Stephen Rothwell wrote:
On Tue, 12 Mar 2013 10:31:09 +0100 Daniel Hellstrom dan...@gaisler.com
wrote:
APBPS2 driver is missing linux/slab.h required on at least PowerPC. See
patch below. How do you want me to proceed?
That is up to Dmitry -
Hi Chris,
On Wed, Nov 28, 2012 at 08:54:32PM -0800, Christopher Heiny wrote:
On 11/27/2012 01:21 AM, Dmitry Torokhov wrote:
There is no point in having the sensor driver and F01 handler separate
from the RMI core since it is not useful without them and having them
all together simplifies
This saves us a few lines of code.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/keyboard/gpio_keys_polled.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys_polled.c
b/drivers/input/keyboard
This saves us a few lines of code.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/keyboard/gpio_keys.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c
b/drivers/input/keyboard/gpio_keys.c
index 79435de
On Friday, November 30, 2012 09:09:21 AM Greg KH wrote:
On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote:
I didn't get the resend either, so it seems our corporate mail really is
eating messages. Lovely.
+#define IOCTLCMD(_cmd) IOCTL_VMCI_ ## _cmd
I don't recall
On Friday, November 30, 2012 10:39:18 AM Greg KH wrote:
On Fri, Nov 30, 2012 at 09:20:41AM -0800, Dmitry Torokhov wrote:
On Friday, November 30, 2012 09:09:21 AM Greg KH wrote:
On Fri, Nov 30, 2012 at 08:47:46AM -0800, Andy King wrote:
I didn't get the resend either, so it seems our
On Friday, November 30, 2012 10:57:55 AM Greg KH wrote:
On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote:
However you snipped the rest of my reply: do we really need to renumber
ioctls? There is no benefit for the driver as its ioctl handler does
not parse the numbers
On Friday, November 30, 2012 12:44:06 PM Greg KH wrote:
On Fri, Nov 30, 2012 at 12:09:40PM -0800, Dmitry Torokhov wrote:
On Friday, November 30, 2012 10:57:55 AM Greg KH wrote:
On Fri, Nov 30, 2012 at 10:45:44AM -0800, Dmitry Torokhov wrote:
However you snipped the rest of my reply: do
number indicators on controller
activation, and replaces it with a functional IRQ output URB method. It
also implements the LED command control for these devices.
Signed-off-by: Chris Moeller kod...@gmail.com
Signed-off-by: Dmitry Torokhov d...@mail.ru
---
drivers/input/joystick/xpad.c | 699
Hi Kamal,
On Thu, Nov 29, 2012 at 01:57:57PM -0800, Kamal Mostafa wrote:
This driver, submitted on behalf of Cypress Semiconductor Corporation and
additional contributors, provides support for the Cypress PS/2 Trackpad.
This [PATCH v3] version differs from my previous submitted version[1]:
On Fri, Nov 30, 2012 at 08:13:29PM -0800, Chris Moeller wrote:
On Fri, 30 Nov 2012 14:30:23 -0800
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
Hi Chris,
On Friday, November 30, 2012 01:54:06 PM Chris Moeller wrote:
I've submitted versions of this with prior patch sets
On Mon, Dec 03, 2012 at 08:45:20AM +0100, Henrik Rydberg wrote:
+/*
+ * reset trackpad device to standard relative mode.
+ * This is also the defalut mode when trackpad powered on.
+ */
+static void cypress_reset(struct psmouse *psmouse)
+{
+ struct cytp_data *cytp =
Hi Li,
On Tue, Dec 04, 2012 at 08:32:05AM +0800, Li Wu wrote:
Thanks Felipe for the nice comments.
I have consolidated most of your comments to a new version, but I am not
sure how should I send it out.
I am using git send-email from shell command, then shall I just send out
the patch
On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
From: Guillermo A. Amaral g...@maral.me
Fixed a few minor coding style issues in xpad driver.
Applied both, thanks Guillermo.
--
Dmitry
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Li,
On Tue, Dec 04, 2012 at 06:26:29AM -0500, Li Wu wrote:
+STM FTK TOUCHSCREEN DRIVER
+M: Li Wu li...@st.com
+L: device-drivers-de...@blackfin.uclinux.org
+W: http://www.st.com
+S: Supported
+F: drivers/input/touchscreen/ftk.c
+
+
You have an extra blank line
On Tue, Nov 27, 2012 at 01:03:56AM -0800, Dmitry Torokhov wrote:
The default implementation matches exactly our custom one so we can switch
to using the default one. As a bonus the driver will take care of setting
GPIO line for us.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
On Mon, Dec 03, 2012 at 11:28:36PM -0800, Guillermo A. Amaral wrote:
On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote:
On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
From: Guillermo A. Amaral g...@maral.me
Fixed a few minor coding style issues
Hi David,
On Wed, Feb 06, 2013 at 04:23:55PM -0800, Andy King wrote:
In an effort to improve the out-of-the-box experience with Linux kernels for
VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly
VMCI Sockets) (vsock) kernel module for inclusion in the Linux kernel.
Hi Simon,
On Tue, Feb 12, 2013 at 06:42:25PM -0800, Simon Glass wrote:
We now have a binding which adds two parameters to the matrix keypad DT
node. This is separate from the GPIO-driven matrix keypad binding, and
unfortunately incompatible, since that uses row-gpios/col-gpios for the
row and
Hi SImon,
On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote:
Use the key-matrix layer to interpret key scan information from the EC
and inject input based on the FDT-supplied key map. This driver registers
itself with the ChromeOS EC driver to perform communications.
Additional
On Tue, Feb 05, 2013 at 05:58:34PM -0800, Joe Millenbach wrote:
Backing out changes made in earlier TTY removal patch. Switched
to only one dependency in SERPORT on TTY instead of many incorrect
dependencies.
Signed-off-by: Joe Millenbach jmillenb...@gmail.com
Reported-by: Dmitry Torokhov
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
I was looking at the various aspects of the RMI4 patchset,
() methods should not be marked __init unless
platform_driver_probe() is used.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
v1-v2: removed __init markup on omap1_cam_probe() that was pointed out
by Guennadi Liakhovetski.
drivers/media/i2c/adp1653.c
On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote:
put_device() must be called after device_register() fails,
since device_register() always initializes the refcount
on the device structure to one.
dev-id is free'd inside of ipack_device_release function.
So, it's
On Tue, Feb 26, 2013 at 10:21:06AM +0900, Jingoo Han wrote:
+/**
+ * devm_rtc_device_unregister - resource managed devm_rtc_device_unregister()
+ * @dev: the device to unregister
+ * @rtc: the RTC class device to unregister
+ *
+ * Deallocated a rtc allocated with devm_rtc_device_register().
Hi Magnus,
On Tue, Feb 26, 2013 at 10:26:23PM +0900, Magnus Damm wrote:
From: Magnus Damm d...@opensource.se
Update the Emma Mobile GPIO driver to add DT support.
...
@@ -366,15 +387,33 @@ static int em_gio_remove(struct platform
return 0;
}
#ifdef CONFIG_OF here? No need to
On Wed, Feb 27, 2013 at 10:58:44AM -0700, Mathieu Poirier wrote:
On 13-02-27 09:57 AM, Linus Torvalds wrote:
On Tue, Feb 26, 2013 at 11:33 PM, Dave Airlie airl...@gmail.com wrote:
It looks to me like the weak bit isn't working so well
if (platform_sysrq_reset_seq) {
Hi Peter,
On Thu, Jan 24, 2013 at 12:44:29PM +0100, Peter Ujfalusi wrote:
Hi Dmitry,
On 01/14/2013 04:34 PM, Peter Ujfalusi wrote:
Hi Dmitry,
Changes since v2:
- twl4030-vibra patches are left out (they have been applied)
- Do not use devm_input_allocate_device() in twl6040-vibra
Hi Borislav,
On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote:
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 8e1a9ec53003..cb467656e684 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -724,7 +724,7 @@ static int __init
Hi Borislav,
On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Put all config options needed to run Linux as a guest behind a
CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by
default but selected by the user. Also, move
On Fri, Jan 25, 2013 at 07:23:35PM +0100, Borislav Petkov wrote:
On Fri, Jan 25, 2013 at 10:07:31AM -0800, Dmitry Torokhov wrote:
- if (x86_hyper != x86_hyper_ms_hyperv)
+ if (!x86_hyper || strncmp(x86_hyper-name, VMware, 6))
return -ENODEV;
I assume this is a typo as I
On Fri, Jan 25, 2013 at 07:32:13PM +0100, Borislav Petkov wrote:
On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote:
Hi Borislav,
On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Put all config options needed to run
Hi Neil,
On Friday, January 25, 2013 06:59:53 PM Neil Horman wrote:
On Fri, Jan 25, 2013 at 09:37:50AM -0800, ack...@vmware.com wrote:
+
+config VMWARE_VSOCK
+ tristate Virtual Socket protocol
+ depends on VMWARE_VMCI
What is CONFIG_VMWARE_VMCI? I don't find that in any Kconfig
On Mon, Jan 28, 2013 at 06:46:15AM -0800, Greg KH wrote:
On Mon, Jan 28, 2013 at 08:44:24PM +1100, Stephen Rothwell wrote:
Hi Greg,
Today's linux-next merge of the tty tree got a conflict in
drivers/input/keyboard/Kconfig between commit 6f2ac009f29b (Input:
goldfish - virtual input
On Mon, Jan 28, 2013 at 02:09:31PM -0800, Joe Millenbach wrote:
On Mon, Jan 28, 2013 at 9:33 AM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Jan 28, 2013 at 06:46:15AM -0800, Greg KH wrote:
On Mon, Jan 28, 2013 at 08:44:24PM +1100, Stephen Rothwell wrote:
Hi Greg
On Tue, Jan 29, 2013 at 10:59:17AM +1100, Josh Triplett wrote:
On Mon, Jan 28, 2013 at 02:44:43PM -0800, Dmitry Torokhov wrote:
On Mon, Jan 28, 2013 at 02:09:31PM -0800, Joe Millenbach wrote:
On Mon, Jan 28, 2013 at 9:33 AM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
On Mon, Jan
On Tue, Jan 29, 2013 at 04:13:21PM +1100, Josh Triplett wrote:
On Mon, Jan 28, 2013 at 04:23:57PM -0800, Dmitry Torokhov wrote:
On Tue, Jan 29, 2013 at 10:59:17AM +1100, Josh Triplett wrote:
On Mon, Jan 28, 2013 at 02:44:43PM -0800, Dmitry Torokhov wrote:
On Mon, Jan 28, 2013 at 02:09
Hi Joe,
On Mon, Jan 28, 2013 at 10:26:47PM -0800, Joe Millenbach wrote:
On Mon, Jan 28, 2013 at 9:33 PM, Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Please revert the input changes and add *ONE* new dependency to the
serport driver.
Thanks.
--
Dmitry
Apologies on this. I
of list_for_each.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static analysis stuff. Untested. Please review carefully.
Makes sense to me.
Reviewed-by: Dmitry Torokhov dmitry.torok...@gmail.com
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 6cc046d..f42e406
On Mon, Jan 21, 2013 at 09:39:43AM +0900, Namjae Jeon wrote:
2013/1/21, Dan Carpenter dan.carpen...@oracle.com:
This is calling list_del() inside a loop which is a problem when we try
move to the next item on the list. I've converted it to use the _safe
version. And also, as a cleanup,
...@avionic-design.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
This looks good to me.
Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Arnd Bergmann a...@arndb.de
---
Documentation/driver-model/devres.txt | 3 +-
include
can be removed from the failure code paths.
Signed-off-by: Thierry Reding thierry.red...@avionic-design.de
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: linux-in...@vger.kernel.org
---
drivers/input/keyboard/spear-keyboard.c | 8
Hi Ivan,
On Mon, Jan 21, 2013 at 03:15:14PM +0200, Ivan Khoronzhuk wrote:
Rebased on linux_omap/master.
During suspend/resume the key press can be lost if time of resume
sequence is significant.
If press event cannot be remembered then the driver can read the
current button state only in
On Wed, Feb 06, 2013 at 09:56:55PM +, Arnd Bergmann wrote:
On Wednesday 06 February 2013, Heiko Carstens wrote:
I haven't looked into it, but I doubt if that is possible without large
effort, if at all. s390 doesn't have any irq chips, nor something like
edge or level triggered irqs.
Hi Daniel,
On Fri, Feb 01, 2013 at 04:11:44PM +0800, Daniel Kurtz wrote:
As soon as the irq is request, input event interrupts could occur that
the isr should handle. Similarly, if there are input events queued up
in the device output buffer, it will send them immediately when we
drain the
On Fri, Feb 01, 2013 at 04:11:46PM +0800, Daniel Kurtz wrote:
In some cases it is possible for a device to be in its bootloader at
driver probe time. This is detected by the driver when probe() is called
with an i2c_client which has one of the Atmel Bootloader i2c addresses.
In this case,
On Fri, Feb 01, 2013 at 04:11:48PM +0800, Daniel Kurtz wrote:
After firmware update, the device may have a completely different object
table which corresponds to an input device with different properties.
So, destroy the old state before firmware update, and completely
reinitialize the driver
On Fri, Feb 01, 2013 at 04:28:32PM +0800, Daniel Kurtz wrote:
The input fuzz algorithm does a pretty good job filtering out small
jitter on input samples.
However, there is a subtle problem when fuzz is used with mt drivers that
also use input_mt_report_pointer_emulation() to report legacy
/lm8323.c: In function ‘lm8323_suspend’:
drivers/input/keyboard/lm8323.c:801:2: error: implicit declaration of
function ‘irq_set_irq_wake’
[-Werror=implicit-function-declaration]
Cc: Dmitry Torokhov d...@mail.ru
Signed-off-by: Heiko Carstens heiko.carst...@de.ibm.com
Queued for 3.9
On Sun, Feb 10, 2013 at 12:15:40PM -0800, Benson Leung wrote:
This patch adds support for the Cypress APA Smbus Trackpad type,
which uses a modified register map that fits within the
limitations of the smbus protocol.
Devices that use this protocol include:
CYTRA-116001-00 - Samsung Series
On Fri, Feb 01, 2013 at 04:29:00PM +0800, Daniel Kurtz wrote:
Investigating the following gesture highlighted two slight implementation
errors with choosing which slots to report in which slot when multiple
contacts are present:
Action SGM AGM (MTB slot:Contact)
1. Touch
On Tue, Feb 12, 2013 at 11:05:12AM +0100, Samuel Ortiz wrote:
Adding Dmitry to the thread, for the input parts.
Looks reasonable, however the patch is against older version of the
driver and most likely will not apply anymore...
Thanks.
On Thu, Dec 20, 2012 at 09:57:19AM +0100, Jean-Nicolas
On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote:
+config KEYBOARD_CROS_EC
+ tristate ChromeOS EC keyboard
+ select INPUT_MATRIXKMAP
+ select MFD_CROS_EC
Is this select safe? I.e. does MFD_CROS_EC depend on anything else?
I'll remove it, since it isn't
with compat
interface.
Compiled but not tested.
Thanks.
--
Dmitry
UHID: make creating devices work on 64/32 systems
From: Dmitry Torokhov dmitry.torok...@gmail.com
Unfortunately UHID interface, as it was introduced, is broken with 32 bit
userspace running on 64 bit kernels as it uses a pointer
()
i2c_transfer_exact()
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/i2c/i2c-core.c | 69
include/linux/i2c.h| 11
2 files changed, 80 insertions(+)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index
()
i2c_transfer_exact()
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
Resending to Wolfram's new address...
drivers/i2c/i2c-core.c | 69
include/linux/i2c.h| 11
2 files changed, 80 insertions(+)
diff --git a/drivers/i2c/i2c
On Fri, Feb 15, 2013 at 08:36:21PM +0100, Henrik Rydberg wrote:
To properly setup event parameters for emulated events, pass
the appropriate flag to the slot initialization function. Also,
all MT-related events should be setup before initialization.
Incidentally, this solves the issue of
for managed input devices.
Changelog:
-
Chris Bagwell (1):
Input: wacom - fix wacom_set_report retry logic
Dmitry Torokhov (1):
Input: document that unregistering managed devices is not necessary
Nickolai Zeldovich (1):
Input: lm8323 - fix checking PWM interrupt status
Hi Simon,
On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote:
+ for (row = 0; row ckdev-rows; row++) {
+ if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row))
+ return true;
+ }
No need for curly braces here. I would not care if not for below.
On Sat, Feb 16, 2013 at 10:25:24PM +0100, Jean Delvare wrote:
Hi Dmitry,
On Fri, 15 Feb 2013 18:42:35 -0800, Dmitry Torokhov wrote:
Many i2c users consider short transfers to be an error and would prefer
getting -EIO instead of a positive return value and having to convert
it to error
On Sun, Feb 17, 2013 at 01:27:52AM +0100, Pali Rohár wrote:
* This patch enable autoloading tsc2005 driver when is compiled as module
Signed-off-by: Pali Rohár pali.ro...@gmail.com
---
drivers/input/touchscreen/tsc2005.c |1 +
1 file changed, 1 insertion(+)
diff --git
Hi David,
On Fri, Feb 15, 2013 at 12:46:55PM +0100, David Herrmann wrote:
Hi Kirill
On Fri, Feb 15, 2013 at 12:29 PM, Kirill A. Shutemov
kirill.shute...@linux.intel.com wrote:
Hi David and all,
There's claim in uhid.h that the interface is compatible even between
architectures. But
On Mon, Feb 18, 2013 at 11:28:40AM +0100, Jiri Kosina wrote:
On Fri, 15 Feb 2013, Dmitry Torokhov wrote:
Here's my attempt to fix the issue.
Not sure if tricks with padding in a good idea. We can just use __u64
instead of pointer, but it will require update of userspace to silence
On Mon, Feb 18, 2013 at 11:20:43PM -0800, Joe Perches wrote:
On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote:
On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov
On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote:
+ for (row = 0; row ckdev-rows; row
Hi Chung-yih,
On Mon, Feb 18, 2013 at 05:45:07PM +0800, Chung-Yih Wang (王崇懿) wrote:
Yes, I could add CONFIG_MOUSE_PS2_SYNAPTICS for the change as we only
need it for synaptics touchpad/touchpoint on lenovo's machines.
I do not think it will solve anything as all distributions have
Hi Chung-yih,
On Mon, Feb 18, 2013 at 04:40:21PM +0800, Chung-yih Wang wrote:
On the Samsung Series 5 Chromebook, the Synaptics ClickPad will sometimes not
send an 0xFA PS/2 ACK in response to a command byte during the reconnect
sequence following a resume from suspend. From our experiments,
: goldfish - virtual input event driver
Daniel Kurtz (1):
Input: synaptics - fix 1-3 contact transition reporting
Dmitry Torokhov (6):
Input: atkbd - fix a typo in a message
Input: walkera0701 - set up input device's parent
Input: walkera0701 - switch to using pr_xxx() for messages
Hi Jongoo,
On Wed, Feb 20, 2013 at 03:12:38PM +0900, Jingoo Han wrote:
Use devm_request_irq() and devm_kzalloc() to make cleanup paths
more simple.
...
@@ -1269,9 +1266,7 @@ static int __exit menelaus_remove(struct i2c_client
*client)
{
struct menelaus_chip*menelaus =
On Wed, Feb 20, 2013 at 03:13:06PM +0900, Jingoo Han wrote:
Use devm_request_irq() and devm_kzalloc() to make cleanup paths
more simple.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/mfd/ezx-pcap.c | 16 +---
1 files changed, 5 insertions(+), 11 deletions(-)
On Wed, Feb 20, 2013 at 03:14:05PM +0900, Jingoo Han wrote:
Use devm_request_irq() and devm_kzalloc() to make cleanup paths
more simple.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/mfd/tps65010.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
Hi Jingoo,
On Wed, Feb 20, 2013 at 03:11:38PM +0900, Jingoo Han wrote:
Use devm_gpio_request_one() and devm_request_threaded_irq() to make
cleanup paths and more simple.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/mfd/twl6040.c | 26 +++---
1 files
On Wed, Feb 20, 2013 at 05:05:10PM +0900, Jingoo Han wrote:
On Wednesday, February 20, 2013 4:31 PM, Dmitry Torokhov wrote:
Hi Jongoo,
On Wed, Feb 20, 2013 at 03:12:38PM +0900, Jingoo Han wrote:
Use devm_request_irq() and devm_kzalloc() to make cleanup paths
more simple
On Wed, Feb 20, 2013 at 05:17:30PM +0900, Jingoo Han wrote:
On Wednesday, February 20, 2013 5:10 PM, Dmitry Torokhov wrote:
On Wed, Feb 20, 2013 at 05:05:10PM +0900, Jingoo Han wrote:
On Wednesday, February 20, 2013 4:31 PM, Dmitry Torokhov wrote:
Hi Jongoo,
On Wed, Feb 20
of
platform_driver_register(), which disables binding/unbinding via sysfs.
This also allows us to mark hp_wmi_bios_setup as __init and discard it
once module is initialized.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
Compiled only, no hardware to run.
drivers/platform/x86/hp
The remove() methods should not be marked __exit unless we are using
platform_driver_probe() which disables unbinding device from driver
via sysfs.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
Compiled only, no hardware.
drivers/i2c/busses/i2c-pxa.c | 4 ++--
1 file changed, 2
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
Not tested - no hardware.
drivers/mfd/menelaus.c | 4 ++--
drivers/mfd/tps65010
On Wed, Feb 20, 2013 at 09:24:35AM -0800, Simon Glass wrote:
This is the base EC implementation, which provides a high level
interface to the EC for use by the rest of the kernel. The actual
communcations is dealt with by a separate protocol driver which
registers itself with this interface.
this, and then refactor each driver to hold
such a structure.
Signed-off-by: Simon Glass s...@chromium.org
Tested-by: Sourav Poddar sourav.pod...@ti.com (v2)
Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com
I suppose the EC driver will go through MFD tree, right?
--
Dmitry
--
To unsubscribe from
platform_device *pdev)
+{
+ struct cros_ec_device *ec = dev_get_drvdata(pdev-dev.parent);
+ struct device *dev = ec-dev;
+ struct cros_ec_keyb *ckdev = NULL;
+ struct input_dev *idev = NULL;
Why are we assigning these to NULL?
Otherwise
Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com
On Wed, Feb 20, 2013 at 09:24:36AM -0800, Simon Glass wrote:
+#ifdef DEBUG
+ dev_dbg(ec_dev-dev, packet: );
+ for (i = 0; i i2c_msg[1].len; i++)
+ dev_cont(ec_dev-dev, %02x, in_buf[i]);
+ dev_cont(ec_dev-dev, , sum = %02x\n, sum);
There is %ph now so you can simply
On Thu, Feb 21, 2013 at 10:55:55AM -0800, Kamal Mostafa wrote:
Avoid firmware glitch in Cypress PS/2 Trackpad firmware version 11
(as observed in Dell XPS12) which prevents driver from recognizing
the trackpad.
BugLink: http://launchpad.net/bugs/1103594
Signed-off-by: Kamal Mostafa
On Thu, Feb 21, 2013 at 12:02:46PM -0800, Kamal Mostafa wrote:
On Thu, 2013-02-21 at 11:56 -0800, Dmitry Torokhov wrote:
On Thu, Feb 21, 2013 at 10:55:55AM -0800, Kamal Mostafa wrote:
Avoid firmware glitch in Cypress PS/2 Trackpad firmware version 11
(as observed in Dell XPS12) which
Hi,
It looks like a whole slew of devm_request_irq() conversions just got
applied to mainline and many of them are quite broken.
Consider fd5231ce336e038037b4f0190a6838bdd6e17c6d or
c1879fe80c61f3be6f2ddb82509c2e7f92a484fe: the drivers udsed first to
free IRQ and then unregister the
On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote:
On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote:
Hi,
It looks like a whole slew of devm_request_irq() conversions just got
applied to mainline and many of them are quite broken.
Consider
On Fri, Feb 22, 2013 at 04:57:29PM +0900, Jingoo Han wrote:
On Friday, February 22, 2013 4:27 PM, Dmitry Torokhov wrote:
On Fri, Feb 22, 2013 at 04:12:36PM +0900, Jingoo Han wrote:
On Friday, February 22, 2013 3:54 PM, Dmitry Torokhov wrote:
Hi,
It looks like a whole slew
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index 799dafd..c45b9ae 100644
--- a/drivers/w1/masters/w1
This fixes the following warning:
CC drivers/w1/masters/w1-gpio.o
drivers/w1/masters/w1-gpio.c:50:28: warning: ‘w1_gpio_dt_ids’ defined but not
used [-Wunused-variable]
Also provide stub for w1_gpio_probe_dt() if device tree support is
disabled.
Signed-off-by: Dmitry Torokhov
This simplifies error unwinding and device teardown.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters
tree and
prefer kernel-supplied data (it may be easier to fiddle in kernel structure
before committing final result to device tree).
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 93 +---
1 file changed, 53
We should not be using __init/__exit markups on probe() and remove()
methods unless platform_device_probe() is used, because other methods
allow unbinding device through sysfs and these methods should not be
discarded.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
This was just
On Sat, Feb 23, 2013 at 06:55:45PM +0200, Ville Syrjälä wrote:
On Fri, Feb 22, 2013 at 11:58:39PM -0800, Dmitry Torokhov wrote:
The platform data in the dveice structure does not belong to the driver
and so it should not be trying to alter it, but instead use a local pointer
and populate
of devres resources.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/base/devres.c | 74 ++
include/linux/device.h | 4 +++
2 files changed, 78 insertions(+)
diff --git a/drivers/base/devres.c b/drivers/base/devres.c
index
On Sat, Feb 23, 2013 at 04:51:19PM -0700, Stephen Warren wrote:
On 02/22/2013 10:28 PM, Alexander Shiyan wrote:
On 02/22/2013 10:15 PM, Alexander Shiyan wrote:
The driver can be used in various subsystems and therefore should not
be unloaded when it is defined in the kernel configuration,
-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/media/i2c/adp1653.c | 4 ++--
drivers/media/i2c/smiapp/smiapp-core.c | 4 ++--
drivers/media/platform/soc_camera/omap1_camera.c | 4 ++--
drivers/media/radio/radio-si4713.c | 4 ++--
drivers/media/rc
-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/regulator/db8500-prcmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c
index 219d162..a53c11a 100644
--- a/drivers/regulator/db8500-prcmu.c
+++ b
-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/spi/spi-ppc4xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
index 7a85f22..027b474 100644
--- a/drivers/spi/spi-ppc4xx.c
+++ b/drivers/spi/spi-ppc4xx.c
@@ -560,7
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index 799dafd..c45b9ae 100644
--- a/drivers/w1/masters/w1
This simplifies error unwinding and device teardown.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 32 +++-
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters
tree and
prefer kernel-supplied data (it may be easier to fiddle in kernel structure
before committing final result to device tree).
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/w1/masters/w1-gpio.c | 44 +---
1 file changed, 25
801 - 900 of 11293 matches
Mail list logo
