RE: [PATCH 06/10] security: fix documentation for the path_chmod hook

2019-02-07 Thread Edwin Zimmerman
On Thursday, February 07, 2019 8:50 AM Al Viro wrote: > On Thu, Feb 07, 2019 at 03:44:54PM +0300, Denis Efremov wrote: > > The path_chmod hook was changed in the commit > > "switch security_path_chmod() to struct path *" (cdcf116d44e7). > > The argument @mnt was removed from the hook, @dentry was c

RE: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Edwin Zimmerman
ough to do without forcing them to watch for variable declarations in switch statements. Automating this prohibition, should it be accepted, seems like a good idea to me. -Edwin Zimmerman

RE: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Edwin Zimmerman
nings like this: > > fs/fcntl.c: In function ‘send_sigio_to_task’: > fs/fcntl.c:738:13: warning: statement will never be executed > [-Wswitch-unreachable] >siginfo_t si; > ^~ > > Signed-off-by: Kees Cook Reviewed by: Edwin Zimmerman > --- > arch/

Pagefault in fuse_do_ioctl

2019-03-23 Thread Edwin Zimmerman
On 5.0.0-rc4+, I encountered a pagefault in fuse_do_ioctl when fuzzing with trinity on a ntfs filesystem mounted with fuse. I have not been able to reproduce it on other filesystem types. The following python script will reproduce this bug when run on a fuse-mounted ntfs path. >import fcntl >f