Re: [Unionfs] Re: [-mm patch] UNION_FS must depend on SLAB

For what it's worth, the new branch-management code also needs realloc(): right now I do a kfree/kalloc instead. So I'm all for having a true krealloc function. Erez. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[GIT PULL -mm] 0/4 Unionfs updates/fixes/cleanups

the following: Erez Zadok (4): Unionfs: merged several printk KERN_CONT together into one pr_debug Unionfs: mmap fixes Unionfs: branch-management related locking fixes Unionfs: ensure we have lower dentries in d_iput commonfops.c |6 ++ debug.c | 51

[PATCH 3/4] Unionfs: branch-management related locking fixes

Add necessary locking to dentry/inode branch-configuration, so we get consistent values during branch-management actions. In d_revalidate_chain, -permission, and -create, also lock parent dentry. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 ++ fs/unionfs

[PATCH 2/4] Unionfs: mmap fixes

Ensure we have lower inodes in prepare/commit_write. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index a0e654b..ad770ac 100644 --- a/fs

[PATCH 4/4] Unionfs: ensure we have lower dentries in d_iput

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index d969640..cd15243 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -507,9 +507,10 @@ static

[PATCH 1/4] Unionfs: merged several printk KERN_CONT together into one pr_debug

CC: Joe Perches [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 51 +-- 1 files changed, 25 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 5f1d887..d154c32 100644

[PATCH 09/29] Unionfs: lower-level copyup routines

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 899 +++ 1 files changed, 899 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/copyup.c diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c new file mode 100644

[PATCH 17/29] Unionfs: unlink/rmdir operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/unlink.c | 251 +++ 1 files changed, 251 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/unlink.c diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c new file mode 100644

[PATCH 01/29] Unionfs: documentation

Includes index files, MAINTAINERS, and documentation on general concepts, usage, issues, and renaming operations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/00-INDEX |2 + Documentation/filesystems/unionfs/00-INDEX | 10 + Documentation

[PATCH 11/29] Unionfs: lower-level lookup routines

Includes lower nameidata support routines. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 652 +++ 1 files changed, 652 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/lookup.c diff --git a/fs/unionfs/lookup.c

[PATCH 21/29] Unionfs: extended attributes operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/xattr.c | 153 1 files changed, 153 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/xattr.c diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c new file mode 100644

[PATCH 10/29] Unionfs: dentry revalidation

Includes d_release methods and cache-coherency support for dentries. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 548 +++ 1 files changed, 548 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dentry.c diff

[PATCH 26/29] Unionfs: common header file for user-land utilities and kernel

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/union_fs.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 include/linux/union_fs.h diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h new file mode 100644 index

[PATCH 12/29] Unionfs: rename method and helpers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c | 531 +++ 1 files changed, 531 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/rename.c diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c new file mode 100644

[PATCH 14/29] Unionfs: readdir helper functions

Includes whiteout handling for directories. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirhelper.c | 267 1 files changed, 267 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirhelper.c diff --git a/fs/unionfs

[PATCH 22/29] Unionfs: async I/O queue

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/sioq.c | 119 + fs/unionfs/sioq.h | 92 + 2 files changed, 211 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/sioq.c create mode

[PATCH 15/29] Unionfs: readdir state helpers

Includes duplicate name elimination and whiteout-handling code. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rdstate.c | 285 ++ 1 files changed, 285 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/rdstate.c diff --git

[PATCH 03/29] Makefile: hook to compile unionfs

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/Makefile b/fs/Makefile index 500cf15..e202288 100644 --- a/fs/Makefile +++ b/fs/Makefile @@ -118,3 +118,4 @@ obj-$(CONFIG_HPPFS) += hppfs/ obj

[PATCH 02/29] VFS/eCryptfs: use simplified fs_stack API to fsstack_copy_attr_all

Acked-by: Mike Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ecryptfs/dentry.c |2 +- fs/ecryptfs/inode.c |6 +++--- fs/ecryptfs/main.c |2 +- fs/stack.c | 38 -- include/linux/fs_stack.h

[UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

support stackable file systems. Lastly, shortlog and diffstats: Erez Zadok (29): Unionfs: documentation VFS/eCryptfs: use simplified fs_stack API to fsstack_copy_attr_all Makefile: hook to compile unionfs Unionfs: main Makefile Unionfs: fanout header definitions

[PATCH 27/29] VFS path get/put ops used by Unionfs

Note: this will become obsolete once similar patches, now in -mm, make it to mainline. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/namei.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/linux/namei.h b/include/linux/namei.h index

[PATCH 04/29] Unionfs: main Makefile

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/Makefile | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/Makefile diff --git a/fs/unionfs/Makefile b/fs/unionfs/Makefile new file mode 100644 index 000..17ca4a7 --- /dev/null

[PATCH 29/29] Put Unionfs and eCryptfs under one layered filesystems menu

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/Kconfig | 53 + 1 files changed, 41 insertions(+), 12 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 487236c..55a78b7 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1041,6 +1041,47

[PATCH 08/29] Unionfs: basic file operations

Includes read, write, mmap, fsync, and fasync. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 184 + 1 files changed, 184 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/file.c diff --git a/fs/unionfs/file.c

[PATCH 23/29] Unionfs: miscellaneous helper routines

Mostly related to whiteouts. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 242 + 1 files changed, 242 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/subr.c diff --git a/fs/unionfs/subr.c b/fs/unionfs

[PATCH 05/29] Unionfs: fanout header definitions

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 366 +++ 1 files changed, 366 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/fanout.h diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h new file mode 100644

[PATCH 18/29] Unionfs: address-space operations

Includes writepage, writepages, readpage, prepare_write, and commit_write. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 343 + 1 files changed, 343 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/mmap.c

[PATCH 16/29] Unionfs: inode operations

Includes create, lookup, link, symlink, mkdir, mknod, readlink, follow_link, put_link, permission, and setattr. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 1174 1 files changed, 1174 insertions(+), 0 deletions

[PATCH 25/29] Unionfs file system magic number

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/magic.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/magic.h b/include/linux/magic.h index 1fa0c2c..67043ed 100644 --- a/include/linux/magic.h +++ b/include/linux/magic.h @@ -35,6 +35,8

[PATCH 28/29] VFS: export release_open_intent symbol

Needed to release the resources of the lower nameidata structures that we create and pass to lower file systems (e.g., when calling vfs_create). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/namei.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/namei.c b/fs

[PATCH 19/29] Unionfs: mount-time and stacking-interposition functions

Includes read_super and module-linkage routines. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 794 + 1 files changed, 794 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/main.c diff --git a/fs/unionfs

[PATCH 24/29] Unionfs: debugging infrastructure

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 533 1 files changed, 533 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/debug.c diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c new file mode 100644

[PATCH 13/29] Unionfs: directory reading file operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 290 ++ 1 files changed, 290 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirfops.c diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c new file mode

[PATCH 07/29] Unionfs: common file copyup/revalidation operations

Includes open, ioctl, and flush operations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 835 +++ 1 files changed, 835 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/commonfops.c diff --git a/fs/unionfs

[PATCH 06/29] Unionfs: main header file

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/union.h | 602 1 files changed, 602 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/union.h diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h new file mode 100644

[PATCH 20/29] Unionfs: super_block operations

Includes read_inode, delete_inode, put_super, statfs, remount_fs (which supports branch-management ops), clear_inode, alloc_inode, destroy_inode, write_inode, umount_begin, and show_options. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/super.c | 1025

Re: [UNIONFS] 00/29 Unionfs and related patches pre-merge review (v2)

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Thu, Jan 10, 2008 at 09:59:19AM -0500, Erez Zadok wrote: Dear Linus, Al, Christoph, and Andrew, As per your request, I'm posting for review the unionfs code (and related code) that's in my korg tree against mainline (v2.6.24

[GIT PULL -mm] 0/6 Unionfs updates/cleanups/fixes

|1 - file.c | 12 ++-- inode.c |6 +- lookup.c | 52 +++- mmap.c |6 +++--- union.h |2 +- 9 files changed, 59 insertions(+), 45 deletions(-) Erez Zadok [EMAIL PROTECTED] - To unsubscribe from

[PATCH 2/6] Unionfs: remove unnecessary comment

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/fanout.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index c5bf454..afeb9f6 100644 --- a/fs/unionfs/fanout.h +++ b/fs/unionfs

[PATCH 3/6] Unionfs: add missing newlines to printks

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index f32922e..91f9780 100644 --- a/fs/unionfs/dentry.c +++ b/fs

[PATCH 1/6] Unionfs: use bool type in dentry and file revalidation code

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 12 ++-- fs/unionfs/dentry.c |2 +- fs/unionfs/dirfops.c|4 ++-- fs/unionfs/file.c | 12 ++-- fs/unionfs/mmap.c |6 +++--- fs

[PATCH 4/6] Unionfs: check integrity only if validated dentry successfully

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 91f9780..9e0742d 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs

[PATCH 5/6] Unionfs: unionfs_lookup locking consistency

this behavior. This cleanup allowed us to remove two unnecessary int declarations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |6 +- fs/unionfs/lookup.c | 38 +++--- 2 files changed, 24 insertions

[PATCH 6/6] Unionfs: cache coherency after lower objects are removed

Prevent an oops if a lower file is deleted and then it is stat'ed from the upper layer. Ensure that we return a negative dentry so the user will get an ENOENT. Properly dput/mntput so we don't leak references at the lower file system. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef

WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch Booting the machine, waiting a few minutes (not logging

Re: [PATCH 1/2] create file_drop_write_access() helper

In message [EMAIL PROTECTED], Dave Hansen writes: These should fix the bug that Erez Zadok [EMAIL PROTECTED] reported: Stopping RPC idmapd: kernel: __fput() of writeable file with no mnt_want_write() kernel: WARNING: at fs/file_table.c:262 __fput() kernel: [c010283e

Re: WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

In message [EMAIL PROTECTED], Andrew Morton writes: On Fri, 9 Nov 2007 21:12:47 -0500 Erez Zadok [EMAIL PROTECTED] wrote: Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 That's a bit old. and these two patches added: r-o-bind-mounts-track-number-of-mount-writer

Warning: commit message does not conform to UTF-8. (mmotm 10-Nov-2007 22:46)

Andrew, I'm getting minor warnings when applying two patches from http://userweb.kernel.org/~akpm/mmotm/ It's probably not serious but I wonder if checkpatch catches this. Applying patch..git-net.patch Warning: commit message does not conform to UTF-8. You may want to amend it after fixing the

[PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)

. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index bb03660..2496879 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -106,7 +106,7 @@ static inline unsigned long hugetlb_total_pages(void) return 0

[PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

: too few arguments to function 'get_task_comm' make[1]: *** [kernel/capability.o] Error 1 make[1]: Target `__build' not remade because of errors. make: *** [kernel] Error 2 Small patch below fixes compile error. Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/kernel/capability.c b

patch conflicts (MMOTM 10-Nov-2007 22:46)

Andrew, I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped 10-Nov-2007 22:46. 1. I was getting a bunch of patch conflicts, until I realized that this latest set of patches was to be applied against 2.6.24-rc2 (your mm.patch gave it away :-) The last snapshot was against

NFSv4 broken in -mm (MMOM 10-Nov-2007 22:46)

I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped 10-Nov-2007 22:46. Creating dummy f/s and exporting it to localhost, mounting it as nfsv4, then # touch foo touch: setting times of `foo': No such file or directory # echo bar bar: Invalid argument Erez. - To unsubscribe from this

Re: [PATCH] kernel/capability.c get_task_comm compile error (MMOTM)

In message [EMAIL PROTECTED], Ingo Molnar writes: * Erez Zadok [EMAIL PROTECTED] wrote: Small patch below fixes compile error. + char name[sizeof(current-comm)]; warned++; printk(KERN_INFO warning

Re: [PATCH] Unionfs: stop using iget() and read_inode()

patch, or a small incremental one; either way, you can choose to fold the above and below patches into one. Thanks, Erez. Unionfs: bugfix to initialize unionfs_inode_info node Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 7408b0f..d6544f8

[PATCH] init/calibrate.c compile error (MMOTM-2007-11-10-19-05)

to fix the compilation error. Someone should verify that it's the proper fix. Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/include/linux/timex.h b/include/linux/timex.h index 40383f9..57bb18c 100644 --- a/include/linux/timex.h +++ b/include/linux/timex.h @@ -55,6

[PATCH] arch/x86/kernel/setup_64.c compile error (MMOTM-2007-11-10-19-05)

I'm using -mm (MMOTM-2007-11-10-19-05) and getting $ make CC arch/x86/kernel/setup_64.o arch/x86/kernel/setup_64.c: In function 'setup_arch': arch/x86/kernel/setup_64.c:420: error: implicit declaration of function 'early_quirks' That's because the externs for early_quirks() aren't on

[PATCH] NFSD: fix wrong mnt_writer count in rename (MMOTM 2007-11-10-19-05)

. If we can drop the ref earlier, it could improve scalability/performance just a bit, no? (i.e., what are the ramifications of holding on to this mnt writer ref longer than needed?) Cheers, Erez. Signed-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index

[PATCH 2/9] Unionfs: use i_size wrappers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 10 +- fs/unionfs/inode.c |4 ++-- fs/unionfs/rdstate.c|4 ++-- fs/unionfs/rename.c |4 ++-- fs/unionfs/super.c |2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 1/9] Unionfs: flush and release updates

Remove the totalopens counter which was intended to reduce unnecessary processing of d_deleted dentries. Move that processing from file_release to flush. Cc: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 30

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Fri, 9 Nov 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: Three, I believe you need to add a flush_dcache_page(lower_page) after the copy_highpage(lower_page): some architectures will need that to see

[PATCH 9/9] Unionfs: move debugging checks inside locks

This is to ensure that the objects we want to check aren't being destroyed or changed by another thread. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |7 --- fs/unionfs/dentry.c |2 +- fs/unionfs/file.c | 10 +- fs/unionfs/inode.c

[PATCH 6/9] Unionfs: debugging updates

Don't perform dentry+inode checks unless both are valid. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 0066ccd..8464fbb 100644 --- a/fs/unionfs/debug.c

[PATCH 3/9] Unionfs: update cache-coherency detection heuristics

Use a small delay to reduce the number of times unionfs has to detect changed mtime's/ctime's, and also reduce the potential for false positives. See Documentation/filesystems/unionfs/concepts.txt for a detailed discussion. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation

[PATCH 7/9] Unionfs: remove unnecessary lower atime updates

No need for this because our readpage calls vfs_read on the lower objects, which would update the atime as/if needed. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c |8 fs/unionfs/mmap.c |6 -- 2 files changed, 0 insertions(+), 14 deletions(-) diff --git

[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes

/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (9): Unionfs: flush and release updates Unionfs: use i_size wrappers Unionfs: update cache-coherency detection heuristics Unionfs: writepage updates Unionfs: clear partial read in readpage Unionfs

[PATCH 8/9] Unionfs: fold do_readpage into unionfs_readpage

Simplify the code and reduce stack pressure a bit. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 44 ++-- 1 files changed, 14 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 34fd8aa..ef8822f

[PATCH 5/9] Unionfs: clear partial read in readpage

Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 468dc61..bb00fd5 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs

[PATCH 4/9] Unionfs: writepage updates

Don't set/reset the PageUptodate flag on our page. Call flush_dcache_page on the lower page after copy_highpage, and set it uptodate. Call set_page_dirty right before clear_page_dirty_for_io. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c

Re: [PATCH 4/9] tmpfs: allow filepage alongside swappage

In message [EMAIL PROTECTED], Hugh Dickins writes: redirty: set_page_dirty(page); - return AOP_WRITEPAGE_ACTIVATE; /* Return with the page locked */ + if (wbc-for_reclaim) + return AOP_WRITEPAGE_ACTIVATE; /* Return with page locked */ + unlock_page(page); +

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

In message [EMAIL PROTECTED], Hugh Dickins writes: In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I couldn't [...] Hugh, I want to understand how patches 3/4 and 4/4 are related. In patch 3 you say in

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

In message [EMAIL PROTECTED], Hugh Dickins writes: On Tue, 18 Dec 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I

[PATCH] XFS: don't expose sysv device encoding in inode-i_rdev

inode-i_rdev Signed:-off-by: Erez Zadok [EMAIL PROTECTED] diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index 37e1167..daaa060 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c @@ -333,7 +333,8 @@ xfs_vn_mknod( ip = vn_to_inode(vp

vfs_rmdir bug?

Al, Christoph, vfs_rmdir is called from do_rmdir and does essentially this: dentry_unhash(dentry); error = dir-i_op-rmdir(dir, dentry); if (!error) d_delete(dentry); dput(dentry); do_rmdir grabs a ref on the dentry to be rmdir'ed, and also dput's

overdue items in feature-removal-schedule

Linus, Andrew, Christoph, There are 29 listed items in feature-removal-schedule.txt. 11 of those have dates or kernel versions that have passed, including this one: What: remove EXPORT_SYMBOL(kernel_thread) When: August 2006 One feature (removal of sys_sysctl) is listed for September 2010:

NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

I get a permission denied when trying to mount a localhost nfsv2/3 exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. It worked fine in 2.6.24-rc3. Here's a sequence of ops I tried: # mount -t ext2 /dev/hdb1 /n/lower/b0 # exportfs -o no_root_squash,rw

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Tue, 13 Nov 2007, Erez Zadok wrote: [...] I'm glad to report that this unionfs, not the one in 2.6.24-rc2-mm1 but the one including those 9 patches you posted, now gets through my testing with tmpfs without a problem. I do still get

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: [...] I deceived myself for a while that the danger of shmem_writepage hitting its BUG_ON(entry-val) was dealt with too; but that's wrong, I must go back to working out an escape from that one (despite never seeing it). Once I tried a

[GIT PULL -mm] 00/16 Unionfs updates/fixes/cleanups

of git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (15): Unionfs: use f_path instead of f_dentry/mnt Unionfs: minor coding standards applied Unionfs: minor cleanup in the debugging infrastructure Unionfs: set lower mnt

[PATCH 10/16] Unionfs: create opaque directories' whiteouts unconditionally

Needed to maintain Unix semantics (LTP testing). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index 968ee8c..1a26c57 100644 --- a/fs/unionfs/subr.c

[PATCH 13/16] Unionfs: support splice(2)

Also remove redundant variable from unionfs_readpage (saves a bit on stack space). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c |1 + fs/unionfs/mmap.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c

[PATCH 15/16] Unionfs: update our inode size correctly upon partial write

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index ea5ef3d..8c07eed 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -250,7 +250,6 @@ static int

[PATCH 07/16] Unionfs: remove useless debugging messages

These are considered normal behaviour, they don't really reveal any insight to the person debugging the code, and they tend to clutter console messages. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |5 - fs/unionfs/dentry.c | 15 +++ 2 files

[PATCH 11/16] Unionfs: update times in setattr

Needed to maintain Unix semantics via utimes(2). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index ef61d9c..63ff3d3 100644 --- a/fs/unionfs/inode.c

[PATCH 12/16] Unionfs: reintroduce a bmap method

This is needed for swapon(2) files in the union. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 3f65e52..fa358ef 100644 --- a/fs/unionfs

[PATCH 08/16] Unionfs: release lower resources on successful rmdir

This patch prevents those resources from lingering around until memory pressure would have forced them out. The patch also properly handles directories that have been rmdir'ed which are still some process's cwd. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED

[PATCH 05/16] Unionfs: set lower mnt after mkdir which resulted in copyup

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 1708f40..9c144be 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -674,8 +674,10 @@ out

[PATCH 16/16] Unionfs: use generic_file_aio_read/write

There's no apparent need to define our own aio_read/write methods. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index b7d0d55..c922173

[PATCH 01/16] Unionfs: use f_path instead of f_dentry/mnt

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- fs/unionfs/fanout.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 8464fbb..bc221d6 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c

[PATCH 02/16] Unionfs: minor cleanup in writepage

From: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 4918f77..1e10280 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c

[PATCH 03/16] Unionfs: minor coding standards applied

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c |4 ++-- fs/unionfs/dirfops.c |5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 98bed0b..3fe4865 100644 --- a/fs/unionfs/copyup.c +++ b/fs/unionfs

[PATCH 04/16] Unionfs: minor cleanup in the debugging infrastructure

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 64 --- 1 files changed, 30 insertions(+), 34 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index bc221d6..c2b8b58 100644 --- a/fs/unionfs/debug.c +++ b/fs

[PATCH 14/16] Unionfs: prevent multiple writers to lower_page

Without this patch, the LTP fs test rwtest04 triggers a BUG_ON(PageWriteback(page)) in fs/buffer.c:1706. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/unionfs

[PATCH 09/16] Unionfs: don't create whiteouts on rightmost branch

If we are unlinking/rmdir'ing an object on the rightmost branch, there's no need to create a whiteout there: this saves on storage space and inodes. Also, in the (degenerate) case of having only one branch, this really saves on whiteouts. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez

[PATCH 06/16] Unionfs: handle whiteouts more efficiently in filldir

an incorrect printk message that the file system may be corrupt, but set that filldir_node-whiteout to 1. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 13 ++--- fs/unionfs/dirhelper.c |2 +- fs/unionfs/rdstate.c | 11

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: [...] Please try running LTP (e.g. ltp-full-20071031.tgz) after something like [...] Hugh, I just posted a series of patches to unionfs (already in unionfs.git on korg), which fix every problem LTP found, as well as other problems mentioned in

Re: unionfs: several more problems

In message [EMAIL PROTECTED], Hugh Dickins writes: On Mon, 26 Nov 2007, Erez Zadok wrote: [...] The small patch below fixed the problem. Let me know what you think. I've one issue with it: please move that wait_on_page_writeback before the clear_page_dirty_for_io instead of after

Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

In message [EMAIL PROTECTED], J. Bruce Fields writes: On Fri, Dec 07, 2007 at 03:00:13PM -0500, Erez Zadok wrote: [...] Those files are actually in a separate filesystem (of type nfsd) which is supposed to be mounted on /proc/fs/nfsd/. So that mount must have failed in the bad case? It's

Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

In message [EMAIL PROTECTED], J. Bruce Fields writes: On Thu, Dec 06, 2007 at 09:20:41PM -0500, Erez Zadok wrote: I get a permission denied when trying to mount a localhost nfsv2/3 exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. It worked fine in 2.6.24-rc3

Re: [NFS] NFSv2/3 broken exporting/mounting (permission denied) in 2.6.24-rc4

In message [EMAIL PROTECTED], J. Bruce Fields writes: On Thu, Dec 06, 2007 at 09:20:41PM -0500, Erez Zadok wrote: I get a permission denied when trying to mount a localhost nfsv2/3 exported volume, on v2.6.24-rc4-124-gf194d13. It works w/ nfsv4 mounting. It worked fine in 2.6.24-rc3

[GIT PULL -mm] 0/2 Unionfs updates/fixes/cleanups

, reiserfs, nfs2/3/4, jffs2, ramfs, tmpfs, cramfs, and squashfs (where available). See http://unionfs.filesystems.org/ to download back-ported unionfs code. Please pull from the 'master' branch of git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok

  1   2   3   4   5   6   7   8   9   >