[PATCH 5/5] staging: vc04_services: Mark the "DT bindings" job done.

2018-03-05 Thread Eric Anholt
Now we just need to get the other drivers merged and finish the style cleanups/garbage collecting so we can get out of staging. Signed-off-by: Eric Anholt --- drivers/staging/vc04_services/interface/vchi/TODO | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 0/5] VCHI DT bindings

2018-03-05 Thread Eric Anholt
s -- the firmware link it has is just to allow a request to the VPU to bring up VCHI on this hardware doorbell. Greg: I'm good with merging patch 1 whenever, but I'd like to make sure Stefan has a chance to take a look at the cache-line-size property change, at least. Eric Anholt (5):

[PATCH 4/5] ARM: dts: bcm2835: Add VCHI node to the Raspberry Pi boards.

2018-03-05 Thread Eric Anholt
The VCHI firmware communication channel operates in parallel with our other mailbox-based channel. This is the communication channel that exposes the firmware's media decode/encode and ISP interfaces. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 7 +++ 1 file ch

Re: [PATCH v2 2/3] pinctrl: bcm2835: Add support for generic pinctrl binding

2018-03-05 Thread Eric Anholt
Matheus Castello writes: > To keep driver up to date we add generic pinctrl binding support, which covers > the features used in this driver and has additional node properties that this > SoC has compatibility, so enabling future implementations of these properties > without the need to create ne

Re: [PATCH 2/5] staging: vc04_services: Remove cache-line-size property.

2018-03-06 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > > > Am 05.03.2018 um 21:28 schrieb Eric Anholt: >> This was just a way for the DT-passed value to get out of sync with >> what Linux has configured the ARM for. >> >> Signed-off-by: Eric Anholt >> --- >

Re: [PATCH 2/5] staging: vc04_services: Remove cache-line-size property.

2018-03-07 Thread Eric Anholt
Phil Elwell writes: > On 07/03/2018 12:10, Stefan Wahren wrote: >> Hi Phil, > > > >>> It is the L2 cache line size that matters, but as long as you end up with >>> the numbers Stefan mentioned - 32 on BCM2835, 64 on BCM2836 and BCM2837 - >>> I'm not too bothered how you get there. >> >> i think

[PATCH v2 2/6] staging: vc04_services: Add comments describing g_cache_line_size.

2018-03-07 Thread Eric Anholt
It's been tempting to replace this with (L1) cache_line_size(), but that's really not what the value is about. It's about coordinating the condition for the pagelist fragment behavior between the two sides. Signed-off-by: Eric Anholt --- v2: new patch to replace the cache_li

[PATCH v2 1/6] staging: vc04_services: Replace "firmware" node with a compatible lookup.

2018-03-07 Thread Eric Anholt
This was requested by Rob Herring in DT bindings review. Signed-off-by: Eric Anholt --- v2: new patch drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm

[PATCH v2 3/6] dt-bindings: soc: Add a binding for the Broadcom VCHIQ services.

2018-03-07 Thread Eric Anholt
The VCHIQ communication channel can be provided by BCM283x and Capri SoCs, to communicate with the VPU-side OS services. Signed-off-by: Eric Anholt --- v2: dropped firmware property, added cache-line-size. .../bindings/soc/bcm/brcm,bcm2835-vchiq.txt| 28 ++ 1 file

[PATCH v2 6/6] staging: vc04_services: Remove vchiq_queue_bulk_{transmit,receive}.

2018-03-07 Thread Eric Anholt
These are dead code, including in the downstream Raspberry Pi tree. Signed-off-by: Eric Anholt --- v2: new patch while I was looking around the code. .../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20 .../vc04_services/interface/vchiq_arm/vchiq_if.h | 10

[PATCH v2 4/6] ARM: dts: bcm2835: Add VCHIQ node to the Raspberry Pi boards.

2018-03-07 Thread Eric Anholt
The VCHIQ firmware communication channel operates in parallel with our other mailbox-based channel. This is the communication channel that exposes the firmware's media decode/encode and ISP interfaces. Signed-off-by: Eric Anholt --- v2: dropped firmware property, added cache-line-size.

[PATCH v2 5/6] staging: vc04_services: Mark the "DT bindings" job done.

2018-03-07 Thread Eric Anholt
Now we just need to get the other drivers merged and finish the style cleanups/garbage collecting so we can get out of staging. Signed-off-by: Eric Anholt --- v2: no changes drivers/staging/vc04_services/interface/vchi/TODO | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

Re: [PATCH v5 1/3] dt-bindings: pinctrl: bcm2835-gpio: Add generic pinctrl support

2018-04-11 Thread Eric Anholt
e changed, 18 insertions(+) All 3 patches are: Reviewed-by: Eric Anholt Thanks for doing this! signature.asc Description: PGP signature

Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.

2018-04-12 Thread Eric Anholt
Boris Brezillon writes: > On Mon, 9 Apr 2018 13:58:13 -0700 > Eric Anholt wrote: > >> Signed-off-by: Eric Anholt >> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace") > > Reviewed-by: Boris Brezillon Applied to drm-misc-next-fixes.

Re: [PATCH/RFC] soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies return failure

2018-04-09 Thread Eric Anholt
> Fixes: d45f1a563b92dac7 ("staging: vc04_services: fix up rpi firmware > functions") > Signed-off-by: Geert Uytterhoeven You should definitely not be calling these if rpi_firmware_get() failed, so this seems like a good solution. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] drm/vc4: Fix memory leak during BO teardown

2018-04-09 Thread Eric Anholt
Daniel J Blueman writes: > During BO teardown, an indirect list 'uniform_addr_offsets' wasn't being > freed leading to leaking many 128B allocations. Fix the memory leak by > releasing it at teardown time. Reviewed, added a Fixes tag, and pushed to drm-misc-fixes. Thanks! signature.asc Descri

Re: drm/vc4: false-positive negative cursor position warning

2018-04-09 Thread Eric Anholt
Daniel J Blueman writes: > Hi Eric et al, > > In a number of windowing environments (eg GNOME 3) on Raspberry Pi 3B > on 4.16.0 arm64, the mouse cursor top-left gets down to x,y -4,-4, > tripping WARN_ON_ONCE(plane->state->crtc_x < 0 || plane->state->crtc_y > < 0) [1], which therefore seems false

[PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.

2018-04-09 Thread Eric Anholt
Signed-off-by: Eric Anholt Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace") --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 94b99c90425a..7c95ed5c5cac 10

[PATCH 3/3] ARM: dts: cygnus: Remove the vc4 GPU subsystem node.

2018-04-09 Thread Eric Anholt
This is no longer required by the DRM driver, and was just a temporary hack for it. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm-cygnus.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi index 699fdf94d139

[PATCH 2/3] ARM: dts: bcm283x: Remove the vc4 GPU subsystem node.

2018-04-09 Thread Eric Anholt
This is no longer required by the DRM driver, and was just a temporary hack for it. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi index 9d293decf8d3

[PATCH 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

2018-04-09 Thread Eric Anholt
if any of the subsystem devices are present. Signed-off-by: Eric Anholt --- .../bindings/display/brcm,bcm-vc4.txt | 7 drivers/gpu/drm/vc4/vc4_drv.c | 33 ++- drivers/gpu/drm/vc4/vc4_hvs.c | 1 + drivers/gpu/drm/vc4

Re: [PATCH 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

2018-04-10 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 10. April 2018 um 01:00 geschrieben: >> >> >> The GPU subsystem node was a workaround to have a central device to >> bind V3D and display to. Following the lead of 246774d17fc0 >> ("drm/

Re: [PATCH v2 3/6] dt-bindings: soc: Add a binding for the Broadcom VCHIQ services.

2018-03-08 Thread Eric Anholt
Rob Herring writes: > On Wed, Mar 7, 2018 at 12:57 PM, Eric Anholt wrote: >> The VCHIQ communication channel can be provided by BCM283x and Capri >> SoCs, to communicate with the VPU-side OS services. >> >> Signed-off-by: Eric Anholt >> --- >> >> v2

Re: [PATCH] staging: vchiq_arm: Clear VLA warning

2018-03-09 Thread Eric Anholt
"Tobin C. Harding" writes: > The kernel would like to have all stack VLA usage removed[1]. The > array here is fixed (declared with a const variable) but it appears > like VLA to the compiler. We can use a pre-processor define to quiet > the compiler. > > [1]: https://lkml.org/lkml/2018/3/7/621

[PATCH v3 2/6] staging: vc04_services: Remove cache-line-size property (v3)

2018-03-09 Thread Eric Anholt
have to use the firmware's fallback value. Signed-off-by: Eric Anholt --- v2: Kept the property but added documentation. v3: Remove the DT property again, more documentation. .../interface/vchiq_arm/vchiq_2835_arm.c | 20 +++- .../interface/vchiq_

[PATCH v3 5/6] staging: vc04_services: Mark the "DT bindings" job done.

2018-03-09 Thread Eric Anholt
Now we just need to get the other drivers merged and finish the style cleanups/garbage collecting so we can get out of staging. Signed-off-by: Eric Anholt Acked-by: Stefan Wahren --- v2-3: no changes drivers/staging/vc04_services/interface/vchi/TODO | 9 ++--- 1 file changed, 2

[PATCH v3 6/6] staging: vc04_services: Remove vchiq_queue_bulk_{transmit,receive}.

2018-03-09 Thread Eric Anholt
These are dead code, including in the downstream Raspberry Pi tree. Signed-off-by: Eric Anholt --- v2-3: no changes .../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20 .../vc04_services/interface/vchiq_arm/vchiq_if.h | 10 -- 2 files changed, 30

[PATCH v3 3/6] dt-bindings: soc: Add a binding for the Broadcom VCHIQ services. (v3)

2018-03-09 Thread Eric Anholt
The VCHIQ communication channel can be provided by BCM283x and Capri SoCs, to communicate with the VPU-side OS services. Signed-off-by: Eric Anholt --- v2: VCHI->VCHIQ, dropped firmware property, added cache-line-size v3: Dropped cache-line-size, s/vchi@/mailbox@/ .../devicetree/bindings/

[PATCH v3 1/6] staging: vc04_services: Replace "firmware" node with a compatible lookup.

2018-03-09 Thread Eric Anholt
This was requested by Rob Herring in DT bindings review. Signed-off-by: Eric Anholt Acked-by: Stefan Wahren --- v2: new patch v3: no changes drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v3 4/6] ARM: dts: bcm2835: Add VCHIQ node to the Raspberry Pi boards. (v3)

2018-03-09 Thread Eric Anholt
The VCHIQ firmware communication channel operates in parallel with our other mailbox-based channel. This is the communication channel that exposes the firmware's media decode/encode and ISP interfaces. Signed-off-by: Eric Anholt Acked-by: Stefan Wahren (v2) --- v2: dropped firmware pro

[GIT PULL] bcm2835-dt-next-2018-03-13

2018-03-13 Thread Eric Anholt
. Eric Anholt (1): ARM: bcm2835: Add the DPI hardware to the device tree. arch/arm/boot/dts/bcm283x.dtsi | 11 +++ 1 file changed, 11 insertions(+)

[PATCH 2/2] drm/vkms: Add PRIME support by converting to Noralf's shmem helpers.

2018-11-27 Thread Eric Anholt
This cuts out a tremendous amount of boilerplate. I've used the PRIME support now to test V3D rendering on a STB development board with no KMS driver. v2: Use the DEFINE_DRM_GEM_SHMEM_FOPS for proper mmap setup. Signed-off-by: Eric Anholt Acked-by: Daniel Vetter (v1) --- drivers/gp

[PATCH 2/8] soc: bcm: bcm2835-pm: Rename the driver to its new "PM" name.

2018-11-20 Thread Eric Anholt
This is the name of the block we're controlling. Signed-off-by: Eric Anholt --- drivers/soc/bcm/bcm2835-pm.c | 92 ++-- 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/drivers/soc/bcm/bcm2835-pm.c b/drivers/soc/bcm/bcm2835-pm.c index ed05514

[PATCH 6/8] soc: bcm: bcm2835-pm: Add support for power domains under a new binding.

2018-11-20 Thread Eric Anholt
This provides a free software alternative to raspberrypi-power.c's firmware calls to manage power domains. It also exposes a reset line, where previously the vc4 driver had to try to force power off the domain in order to trigger a reset. Signed-off-by: Eric Anholt --- arch/arm/mac

[PATCH 8/8] ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.

2018-11-20 Thread Eric Anholt
The GRAFX domain only contains V3D, and this driver should be the only accessor of V3D (firmware usage gets disabled when V3D is in the DT), so we can safely make Linux control the GRAFX and GRAFX_V3D power domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4

[PATCH 0/8] BCM2835 PM driver

2018-11-20 Thread Eric Anholt
/christinaa/rpi-open-firmware project for enabling USB. Eric Anholt (8): watchdog: bcm2835: Move the driver to the soc/ directory. soc: bcm: bcm2835-pm: Rename the driver to its new "PM" name. soc: bcm: bcm2835-pm: Stop using _relaxed mmio accessors. soc: bcm: bcm2835-pm: Make some l

[PATCH 3/8] soc: bcm: bcm2835-pm: Stop using _relaxed mmio accessors.

2018-11-20 Thread Eric Anholt
We definitely don't want I/O to be reordered here (like the setting of the WDT timeout before enabling the WDT). None of this is performance critical, anyway. Signed-off-by: Eric Anholt --- drivers/soc/bcm/bcm2835-pm.c | 24 1 file changed, 12 insertions(+

[PATCH 7/8] ARM: bcm283x: Extend the WDT DT node out to cover the whole PM block.

2018-11-20 Thread Eric Anholt
will need to be careful in coordinating our usage of firmware services that might power domains on and off versus the bcm2835-pm driver's access of those same domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deleti

[PATCH 4/8] soc: bcm: bcm2835-pm: Make some little accessor macros for the mmio area.

2018-11-20 Thread Eric Anholt
This is more legible than trying to remember to set PM_PASSWORD on everything. Signed-off-by: Eric Anholt --- drivers/soc/bcm/bcm2835-pm.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/soc/bcm/bcm2835-pm.c b/drivers/soc/bcm/bcm2835-pm.c

[PATCH 5/8] dt-bindings: soc: Add a new binding for the BCM2835 PM node.

2018-11-20 Thread Eric Anholt
This binding supersedes the bcm2835-pm-wdt binding which only covered enough to provide a watchdog, but the HW block is actually mostly about power domains. Signed-off-by: Eric Anholt --- .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 42 +++ 1 file changed, 42 insertions

[PATCH 1/8] watchdog: bcm2835: Move the driver to the soc/ directory.

2018-11-20 Thread Eric Anholt
This move does result in the driver being made mandatory for the BCM2835 platform, which is probably actually reasonable given that it's necessary for reboot/halt support. Signed-off-by: Eric Anholt --- drivers/soc/bcm/Makefile | 1 + .../{watchdog/bcm2835_wdt.

Re: [PATCH 0/8] BCM2835 PM driver

2018-11-20 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 20. November 2018 um 18:19 geschrieben: >> >> >> This series moves the BCM2835 WDT driver that controls a fraction of >> the PM block out to soc/ and adds most of the rest of its >> functionali

[PATCH v2 3/5] soc: bcm: bcm2835-pm: Add support for power domains under a new binding.

2018-11-20 Thread Eric Anholt
This provides a free software alternative to raspberrypi-power.c's firmware calls to manage power domains. It also exposes a reset line, where previously the vc4 driver had to try to force power off the domain in order to trigger a reset. Signed-off-by: Eric Anholt --- drivers/mfd/bcm2835

[PATCH v2 2/5] bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.

2018-11-20 Thread Eric Anholt
The PM block that the wdt driver was binding to actually has multiple features we want to expose (power domains, reset, watchdog). Move the DT attachment to a MFD driver and make WDT probe against MFD. Signed-off-by: Eric Anholt --- arch/arm/mach-bcm/Kconfig | 1 + drivers/mfd/Makefile

[PATCH v2 4/5] ARM: bcm283x: Extend the WDT DT node out to cover the whole PM block.

2018-11-20 Thread Eric Anholt
will need to be careful in coordinating our usage of firmware services that might power domains on and off versus the bcm2835-pm driver's access of those same domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deleti

[PATCH v2 5/5] ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.

2018-11-20 Thread Eric Anholt
The GRAFX domain only contains V3D, and this driver should be the only accessor of V3D (firmware usage gets disabled when V3D is in the DT), so we can safely make Linux control the GRAFX and GRAFX_V3D power domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4

[PATCH v2 0/5] BCM2835 PM driver (MFD version)

2018-11-20 Thread Eric Anholt
on, haven't double-checked the reset controller. Eric Anholt (5): dt-bindings: soc: Add a new binding for the BCM2835 PM node. bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD. soc: bcm: bcm2835-pm: Add support for power domains under a new binding. ARM: bcm283x: Extend

[PATCH v2 1/5] dt-bindings: soc: Add a new binding for the BCM2835 PM node.

2018-11-20 Thread Eric Anholt
This binding supersedes the bcm2835-pm-wdt binding which only covered enough to provide a watchdog, but the HW block is actually mostly about power domains. Signed-off-by: Eric Anholt --- .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 42 +++ 1 file changed, 42 insertions

[GIT PULL 3/4] bcm2835-drivers-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-drivers-next-2018-11-27 for you to fetch changes up to 502b431cda801645fd73

[GIT PULL 2/4] bcm2835-soc-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-soc-next-2018-11-27 for you to fetch changes up to 7b369a42e6d06c59fc56a176

[GIT PULL 4/4] bcm2835-dt-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-dt-next-2018-11-27 for you to fetch changes up to 703c605fac82d580822dc39f5

[GIT PULL 1/4] bcm2835-defconfig-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, Hopefully I'm not too late this time around. Stefan's been doing a great job maintaining the bcm2835 branches, and was waiting for me to send the PRs. The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are avail

[PATCH 3/3] drm/v3d: Fix prime imports of buffers from other drivers.

2018-11-28 Thread Eric Anholt
ve fix. Signed-off-by: Eric Anholt Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Cc: Dave Emett --- I've been sitting on this one because I don't like it and was hoping the shmem library would pan out. This is a useful patch for now, tho

Re: [PATCH] firmware: raspberrypi: Fix firmware calls with large buffers

2018-11-15 Thread Eric Anholt
Kees Cook writes: > On Thu, Nov 15, 2018 at 10:05 AM, Stefan Wahren > wrote: >> Hi James, >> >> please look at >> https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html, >> because there are several issues with this patch. Most critical one is >> that i received it not as plain t

[PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race.

2018-12-07 Thread Eric Anholt
. Fixes any easy-to-produce OOPS when tracing the scheduler on V3D with "perf record -a -e gpu_scheduler:.\* glxgears" and DEBUG_SLAB enabled. Signed-off-by: Eric Anholt --- drivers/gpu/drm/scheduler/sched_entity.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff -

[PATCH v3 2/5] bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.

2018-11-30 Thread Eric Anholt
The PM block that the wdt driver was binding to actually has multiple features we want to expose (power domains, reset, watchdog). Move the DT attachment to a MFD driver and make WDT probe against MFD. Signed-off-by: Eric Anholt --- v3: don't reset bcm2835_power_off_wdt on remove, dr

[PATCH v3 4/5] ARM: bcm283x: Extend the WDT DT node out to cover the whole PM block.

2018-11-30 Thread Eric Anholt
will need to be careful in coordinating our usage of firmware services that might power domains on and off versus the bcm2835-pm driver's access of those same domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deleti

[PATCH v3 0/5] BCM2835 PM driver (MFD version respin)

2018-11-30 Thread Eric Anholt
Guenter had some minor changes to patch #2, which I've done in this version. Eric Anholt (5): dt-bindings: soc: Add a new binding for the BCM2835 PM node. bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD. soc: bcm: bcm2835-pm: Add support for power domains under a new

[PATCH v3 3/5] soc: bcm: bcm2835-pm: Add support for power domains under a new binding.

2018-11-30 Thread Eric Anholt
This provides a free software alternative to raspberrypi-power.c's firmware calls to manage power domains. It also exposes a reset line, where previously the vc4 driver had to try to force power off the domain in order to trigger a reset. Signed-off-by: Eric Anholt --- drivers/mfd/bcm2835

[PATCH v3 1/5] dt-bindings: soc: Add a new binding for the BCM2835 PM node.

2018-11-30 Thread Eric Anholt
This binding supersedes the bcm2835-pm-wdt binding which only covered enough to provide a watchdog, but the HW block is actually mostly about power domains. Signed-off-by: Eric Anholt --- .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 42 +++ 1 file changed, 42 insertions

[PATCH v3 5/5] ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.

2018-11-30 Thread Eric Anholt
The GRAFX domain only contains V3D, and this driver should be the only accessor of V3D (firmware usage gets disabled when V3D is in the DT), so we can safely make Linux control the GRAFX and GRAFX_V3D power domains. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4

Re: [PATCH 04/17] clk: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 06/17] dma: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 05/17] clocksource: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Also drop the FSF address. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 09/17] irqchip: bcm283x: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 10/17] mailbox: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 13/17] pwm: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 12/17] pinctrl: bcm2835: Switch to SPDX identifier

2018-11-10 Thread Eric Anholt
Stefan Wahren writes: > Adopt the SPDX license identifier headers to ease license compliance > management. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[PATCH] fixup! firmware: raspberrypi: Remove VLA usage

2018-07-02 Thread Eric Anholt
Kees - with this fix to your patch, the kernel boots again (otherwise, the FW would try to parse the uninitialized bits of stack and throw errors). If you're good with me squashing this in, I'll do so and send it to -next. Signed-off-by: Eric Anholt --- drivers/firmware/raspberrypi.c

[PATCH v2] staging: bcm2835-camera: Replace open-coded idr with a struct idr.

2018-05-11 Thread Eric Anholt
We just need some integer handles that can map back to our message struct when we're handling a reply, which struct idr is perfect for. v2: Fix error check to look at the right variable. Signed-off-by: Eric Anholt --- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 135

[PATCH] staging: bcm2835-camera: Fix module section mismatch warnings.

2018-05-14 Thread Eric Anholt
Noticed by Stephen Rothwell in -next. Signed-off-by: Eric Anholt Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.") Cc: Stephen Rothwell --- Note: only compile tested here. .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 --

Re: [PATCH] mailbox: bcm2835: Fix of_xlate return value

2018-05-30 Thread Eric Anholt
mailbox: Enable BCM2835 mailbox support") Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[GIT PULL 2/4] bcm2835-drivers-next-2018-07-03

2018-07-03 Thread Eric Anholt
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-drivers-next-2018-07-03 for you to fetch changes up to 5bfdc1097654eb31bcf2d10421ed769ef

[GIT PULL 3/4] bcm2835-defconfig-next-2018-07-03

2018-07-03 Thread Eric Anholt
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-next-2018-07-03 for you to fetch changes up to 7b54aafff3ef4571567ff6a7d13ed51

[GIT PULL 4/4] bcm2835-defconfig-64-next-2018-07-03

2018-07-03 Thread Eric Anholt
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-64-next-2018-07-03 for you to fetch changes up to 79db60a8bb0b32fdda90a338f09f

[GIT PULL 1/4] bcm2835-dt-next-2018-07-03

2018-07-03 Thread Eric Anholt
transposer block. Boris Brezillon (1): ARM: dts: bcm283x: Add Transposer block Eric Anholt (1): arm: bcm2835: Add the PMU to the devicetree. Stefan Wahren (1): ARM: dts: add Raspberry Pi Compute Module and IO board

Re: [PATCH] fixup! firmware: raspberrypi: Remove VLA usage

2018-07-05 Thread Eric Anholt
Kees Cook writes: > On Mon, Jul 2, 2018 at 12:45 PM, Eric Anholt wrote: >> Kees - with this fix to your patch, the kernel boots again (otherwise, >> the FW would try to parse the uninitialized bits of stack and throw >> errors). If you're good with me squashing this

[PATCH] arm: bcm2835: Add the PMU to the devicetree.

2018-05-17 Thread Eric Anholt
The a53 and a7 counters seem to match up, so we advertise a7 so that arm32 can probe. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2837.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/bcm2837.dtsi b/arch/arm/boot/dts/bcm2837.dtsi index 7704bb029605

[PATCH] drm/vc4: Introduce tracepoints for CL execution.

2018-05-17 Thread Eric Anholt
This has been useful for debugging the window movement lag in X11, and I have patches to sysprof that watch these to produce nice visualizations. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_gem.c | 4 +++ drivers/gpu/drm/vc4/vc4_irq.c | 4 +++ drivers/gpu/drm/vc4/vc4_trace.h

Re: [PATCH] arm: bcm2835: Add the PMU to the devicetree.

2018-05-17 Thread Eric Anholt
Vince Weaver writes: > On Thu, 17 May 2018, Eric Anholt wrote: > >> diff --git a/arch/arm/boot/dts/bcm2837.dtsi b/arch/arm/boot/dts/bcm2837.dtsi >> index 7704bb029605..1f5e5c782835 100644 >> --- a/arch/arm/boot/dts/bcm2837.dtsi >> +++ b/arch/arm/boot/dts/b

[PATCH] drm/vc4: Define a DRM format modifier for SAND tiling.

2018-05-17 Thread Eric Anholt
From: Dave Stevenson This is the format generated by VC4's H.264 engine, and preferred by the ISP as well. By displaying SAND buffers directly, we can avoid needing to use the ISP to rewrite the SAND H.264 output to linear before display. Signed-off-by: Dave Stevenson Signed-off-by:

Re: [PATCH] arm: bcm2835: Add the PMU to the devicetree.

2018-05-17 Thread Eric Anholt
Vince Weaver writes: > On Thu, 17 May 2018, Stefan Wahren wrote: > >> >> > Eric Anholt hat am 17. Mai 2018 um 15:17 geschrieben: >> > >> > >> > The a53 and a7 counters seem to match up, so we advertise a7 so that >> > arm32 can probe.

[PATCH v4 1/5] dt-bindings: soc: Add a new binding for the BCM2835 PM node. (v4)

2018-12-12 Thread Eric Anholt
This binding supersedes the bcm2835-pm-wdt binding which only covered enough to provide a watchdog, but the HW block is actually mostly about power domains. Signed-off-by: Eric Anholt Reviewed-by: Rob Herring (v3) --- v4: Add the system-power-controller node. .../bindings/soc/bcm/brcm

[PATCH v4 2/5] bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.

2018-12-12 Thread Eric Anholt
The PM block that the wdt driver was binding to actually has multiple features we want to expose (power domains, reset, watchdog). Move the DT attachment to a MFD driver and make WDT probe against MFD. Signed-off-by: Eric Anholt Reviewed-by: Guenter Roeck --- v3: don't

[PATCH v4 4/5] ARM: bcm283x: Extend the WDT DT node out to cover the whole PM block. (v4)

2018-12-12 Thread Eric Anholt
will need to be careful in coordinating our usage of firmware services that might power domains on and off versus the bcm2835-pm driver's access of those same domains. Signed-off-by: Eric Anholt --- v4: Add the system-power-controller node. arch/arm/boot/dts/bcm283x.dtsi | 13 +++--

[PATCH v4 3/5] soc: bcm: bcm2835-pm: Add support for power domains under a new binding.

2018-12-12 Thread Eric Anholt
This provides a free software alternative to raspberrypi-power.c's firmware calls to manage power domains. It also exposes a reset line, where previously the vc4 driver had to try to force power off the domain in order to trigger a reset. Signed-off-by: Eric Anholt Acked-by: Rob He

[PATCH v4 0/5] BCM2835 PM driver

2018-12-12 Thread Eric Anholt
v4 adds the system-power-controller node to the binding as requested by Stefan. No driver changes are added to make the power controller behavior optional yet, since it's really unrelated to this series. Eric Anholt (5): dt-bindings: soc: Add a new binding for the BCM2835 PM node

[PATCH v4 5/5] ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware.

2018-12-12 Thread Eric Anholt
The GRAFX domain only contains V3D, and this driver should be the only accessor of V3D (firmware usage gets disabled when V3D is in the DT), so we can safely make Linux control the GRAFX and GRAFX_V3D power domains. Signed-off-by: Eric Anholt --- v4: no change arch/arm/boot/dts/bcm2835

Re: [PATCH v2 03/19] mailbox: bcm2835: Use device-managed registration API

2018-12-18 Thread Eric Anholt
Thierry Reding writes: > From: Thierry Reding > > Get rid of some boilerplate driver removal code by using the newly added > device-managed registration API. > > Cc: Eric Anholt Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] drm/vc4: Limit SAND tiling support to semiplanar YUV420 formats

2018-12-14 Thread Eric Anholt
off-by: Paul Kocialkowski Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH v2] drm/panel: rpi-touchscreen: Add backlight support

2018-12-20 Thread Eric Anholt
Nicolas Saenz Julienne writes: > This patch exposes backlight control into userspace by creating a > backlight device instead of directly accessing the PWM registers. > > The backlight driver can't go on a separate file as it shares the I2C > bus & address with the panel. I remember some concern

Re: [PATCH v2 2/2] input: add official Raspberry Pi's touchscreen driver

2018-12-20 Thread Eric Anholt
gt; > Signed-off-by: Nicolas Saenz Julienne While I wish we could just have a native driver instead, it does make sense to have this driver upstream given the constraints. Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] i2c: bcm2835: Clear current message and count after a transaction

2018-12-27 Thread Eric Anholt
Stefan Wahren writes: > Hi Paul, > >> Paul Kocialkowski hat am 24. Dezember 2018 >> um 10:10 geschrieben: >> >> >> Hi, >> >> On Sat, 2018-12-22 at 13:19 +0100, Stefan Wahren wrote: >> > Hi Paul, >> > >> > > Paul Kocialkowski hat am 21. Dezember >> > > 2018 um 13:11 geschrieben: >> > > >>

Re: [PATCH] drm/vc4: Allow fb modifiers early enough to fill IN_FORMATS property

2018-12-27 Thread Eric Anholt
Paul Kocialkowski writes: > The KMS mode_config elements are currently configured in vc4_kms_load, > that is called after all components are binded (component_bind_all). > However, the CRTC component (for the Pixel Valve) needs to access the > allow_fb_modifiers element at bind time, when initial

Re: [PATCH] firmware: raspberrypi: Define timeout for transactions

2018-10-31 Thread Eric Anholt
d-off-by: Stefan Wahren Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-15 Thread Eric Anholt
Stefan Wahren writes: > Hi Tuomas, > >> Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 >> geschrieben: >> >> >> Drop various pieces of dead code from here and there to get rid of >> the remaining users of VCHI_CONNECTION_T. After that we get to drop >> entire header files worth of unused co

Re: [PATCH 7/9] ARM: dts: bcm2835-rpi: add onboard audio device

2018-10-16 Thread Eric Anholt
x7e00b840 0xf>; > interrupts = <0 2>; > }; > + > + audio: audio { > + compatible = "brcm,bcm2835-audio"; > + brcm,pwm-channels = <8>; > + }; > }; > }; Assuming the DT binding gets acked, Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-17 Thread Eric Anholt
Dan Carpenter writes: > On Sat, Oct 06, 2018 at 12:18:38PM +0200, Stefan Wahren wrote: >> Hi Tuomas, >> >> > Tuomas Tynkkynen hat am 4. Oktober 2018 um 11:37 >> > geschrieben: >> > >> > >> > Drop various pieces of dead code from here and there to get rid of >> > the remaining users of VCHI_C

[PATCH] drm/syncobj: Fix oops on drm_syncobj_find_fence(file_priv, 0, ...).

2018-11-05 Thread Eric Anholt
This broke rendering on V3D, where we almost always have a 0 in-syncobj. Signed-off-by: Eric Anholt Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9") Cc: Chunming Zhou Cc: Christian König --- drivers/gpu/drm/drm_syncobj.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [PATCH 1/2] Revert "drm/sched: fix timeout handling v2"

2018-11-08 Thread Eric Anholt
"Koenig, Christian" writes: > Am 08.11.18 um 17:04 schrieb Eric Anholt: >> This reverts commit 0efd2d2f68cd5dbddf4ecd974c33133257d16a8e. Fixes >> this failure in V3D GPU reset: >> >> [ 1418.227796] Unable to handle kernel NULL pointer dereference at virtual

<    1   2   3   4   5   6   7   8   9   10   >