[PATCH] drm/vc4: Drop debug print at boot with DPI enabled.

2017-02-08 Thread Eric Anholt
Unlike the other encoders in the driver, I've also dropped the debug dump function. There's only really one register to this device, and we have the debugfs reg entry still. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_dpi.c | 13 - 1 file changed, 13 deletion

[PATCH] ARM: dts: Add devicetree for the Raspberry Pi 3, for arm32 (v3)

2017-02-08 Thread Eric Anholt
Raspbian and Fedora have decided to support the Pi3 in 32-bit mode for now, so it's useful to be able to test that mode on an upstream kernel. It's also been useful for me to use the same board for 32-bit and 64-bit development. Signed-off-by: Eric Anholt --- v1: Gerd's pat

Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

2017-02-08 Thread Eric Anholt
Gerd Hoffmann writes: >> > I think just having links from >> > arch/arm64/boot/dts/broadcom/bcm2837*.dts* to arch/arm/boot/dts/ would >> > be the solution, then this Makefile could just reference >> > bcm2837-rpi-3-b.dtb. >> >> I suspect it is not that easy, last time I tried it didn't work. >>

[PATCH] drm/vc4: Fulfill user BO creation requests from the kernel BO cache.

2017-02-08 Thread Eric Anholt
o be other system noise) Note that there's an intel-gpu-tools test to check for the proper zeroing behavior here, which we continue to pass. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH] drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.

2017-02-09 Thread Eric Anholt
If a CMA allocation failed, the partially constructed BO would be unreferenced through the normal path, and we might choose to put it in the BO cache. If we then reused it before it expired from the cache, the kernel would OOPS. Signed-off-by: Eric Anholt Fixes: c826a6e10644 ("drm/vc4: Add

Re: [PATCH V2] Add devicetree for the Raspberry Pi 3, for arm (32)

2017-02-02 Thread Eric Anholt
Michael Zoran writes: > Signed-off-by: Michael Zoran > --- > arch/arm/boot/dts/Makefile| 3 ++- > arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 ++ > 2 files changed, 4 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/bcm2837-rpi-3-b.dts > > diff --git a/arch/arm/boo

Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig

2017-02-03 Thread Eric Anholt
Gerd Hoffmann writes: > --- > arch/arm/configs/bcm2835_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/bcm2835_defconfig > b/arch/arm/configs/bcm2835_defconfig > index 4b89f4e..3767c24 100644 > --- a/arch/arm/configs/bcm2835_defconfig > +++ b/arch/arm/configs

Re: [PATCH v2 3/8] mmc: bcm2835: add sdhost controller to devicetree

2017-02-03 Thread Eric Anholt
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann Patches 3, 7, 8 are: Acked-by: Eric Anholt waiting on Ulf for merging the driver now. signature.asc Description: PGP signature

[GIT PULL] bcm2835-dt-next-2016-08-29

2016-08-29 Thread Eric Anholt
The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at: https://github.com/anholt/linux bcm2835-dt-next-2016-08-29 for you to fetch changes up to c8336249c1eeca288919e3286f7dd03ae1d8ceae:

[GIT PULL] drm-vc4-fixes-2016-08-29

2016-08-29 Thread Eric Anholt
-0700) This pull request brings in fixes for VC4 3D in 4.8, most of which are covered by testcases. Eric Anholt (6): drm/vc4: Use drm_free_large() on handles to

[GIT PULL] drm-vc4-next-2016-08-29

2016-08-29 Thread Eric Anholt
16-08-19 19:36:22 -0700) This pull request brings in interlaced vblank timing and a 3D rendering memory/CPU overhead reduction. Eric Anholt (1): drm/vc4: Don&#x

Re: [PATCH] char: hw_random: bcm2835: handle of_iomap failures in bcm2835 driver

2016-08-30 Thread Eric Anholt
Arvind Yadav writes: > Check return value of of_iomap and handle errors correctly. > > Signed-off-by: Arvind Yadav Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH] dma: bcm2835: Fix compiler warning on arm64.

2016-06-06 Thread Eric Anholt
Vinod Koul writes: > On Fri, Jun 03, 2016 at 07:23:33PM -0700, Eric Anholt wrote: >> The min() macro was complaining about mismatched types. The max len >> is at most SZ_1G, so we can just put it in an unsigned int. >> >> Signed-off-by: Eric Anholt >> --- >

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-06 Thread Eric Anholt
Vinod Koul writes: > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: >> The tx_status hook is supposed to be safe to call from interrupt >> context, but it wouldn't ever return completion for the last transfer, >> meaning you couldn't poll for DMA co

[GIT PULL] drm-vc4-fixes-2016-06-06 for 4.7

2016-06-06 Thread Eric Anholt
Linux 4.7-rc1 (2016-05-29 09:29:24 -0700) are available in the git repository at: g...@github.com:anholt/linux.git tags/drm-vc4-fixes-2016-06-06 for you to fetch changes up to 56d1fe0979dc9b73c1c12ee07722ac380d42a0c4: drm/vc4: Make pageflip completion handling more robust. (2016-06-06 13:

Re: [PATCH] drm/vc4: clean up error exit path on failed dpi_connector allocation

2016-06-06 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > There is redundant code in the clean up exit path when dpi_connector > fails to be allocated. The current code checks if connector is NULL > before destroying it, in fact, connector is NULL at this point so > the check is redundant and can be remove

Updating Raspberry Pi trees pulled for -next

2016-06-06 Thread Eric Anholt
I was going to bother you to add a bunch more trees to pull into -next now that I'll be merging arm64 changes for the Raspberry Pi 3, but instead I've decided to start using the maint-scripts to make generating a single for-next branch trivial. So, could you replace all of my -next branches you're

Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-06 Thread Eric Anholt
Gerd Hoffmann writes: > From: Eric Anholt > > This commit needs to be split up and cleaned up. Also we should add > interrupt support before pushing upstream. > > Signed-off-by: Eric Anholt OK, I've confirmed with the firmware maintainers: We really can't drive th

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-06 Thread Eric Anholt
Vinod Koul writes: > On Mon, Jun 06, 2016 at 10:33:18AM -0700, Eric Anholt wrote: >> Vinod Koul writes: >> >> > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote: >> >> The tx_status hook is supposed to be safe to call from interrupt >&g

Re: [PATCH] ARM: bcm2835: remove unused __packet

2016-06-07 Thread Eric Anholt
#x27; was not > declared. Should it be static? Reviewed-by: Eric Anholt PM folks: I'd be happy to see this go through your trees, but either way is fine with me. signature.asc Description: PGP signature

Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-07 Thread Eric Anholt
Vinod Koul writes: > On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote: >> >> >> - if (ret == DMA_COMPLETE || !txstate) >> >> >> + if (ret == DMA_COMPLETE) >> >> > >> >> > Why do you change this? txstate c

Re: Updating Raspberry Pi trees pulled for -next

2016-06-07 Thread Eric Anholt
Stephen Rothwell writes: > Hi Eric, > > On Mon, 06 Jun 2016 15:08:26 -0700 Eric Anholt wrote: >> >> I was going to bother you to add a bunch more trees to pull into -next >> now that I'll be merging arm64 changes for the Raspberry Pi 3, but >> instead

Re: [PATCH v2 5/9] arm64: Add BCM2835 support to the defconfig.

2016-06-07 Thread Eric Anholt
Arnd Bergmann writes: > On Friday, June 3, 2016 8:18:24 AM CEST Gerd Hoffmann wrote: >> From: Eric Anholt >> >> Made with make defconfig; make menuconfig (only saying Y to new >> entries); make savedefconfig. > > Please try not to mix 'make savedefconfi

[PATCH 1/2] drm/vc4: Bind the HVS before we bind the individual CRTCs.

2016-07-08 Thread Eric Anholt
We need to be able to look at the CRTC's registers in the HVS as part of initialization, while the HVS doesn't need to look at the PV registers. Signed-off-by: Eric Anholt --- This commit would be slipped in before Mario's commit. drivers/gpu/drm/vc4/vc4_drv.c | 2 +- 1

[PATCH 2/2] drm/vc4: Squash commit for Mario's precise vblank timestamping.

2016-07-08 Thread Eric Anholt
Read out the DISPBASE registers to decide on the FIFO size. Signed-off-by: Eric Anholt --- Mario: How about this for a squash into your commit? Here are the values I dumped for cob_size: [2.148314] [drm] Scaler 0 size 5232 [2.162239] [drm] Scaler 2 size 2048 [2.172957] [drm

Re: [PATCH 2/2] drm/vc4: Squash commit for Mario's precise vblank timestamping.

2016-07-10 Thread Eric Anholt
Mario Kleiner writes: > Hi Eric, > > thanks for all the infos and help! Both your patches look good and i > have successfully tested them on top of with my vblank timestamping patch. > > So for both: > > Reviewed-and-tested-by: Mario Kleiner > > Will you squash 2/2 into my patch or should i res

Re: [PATCH] drm/vc4: remove redundant ret status check

2016-07-11 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > At the current point where ret is being checked for non-zero it has > not changed since it was initialized to zero, hence the check and the > label unref are redundant and can be removed. Reviewed-by: Eric Anholt I'll put

[PATCH 1/7 v2] drm/vc4: Add a getparam ioctl for getting the V3D identity regs.

2016-07-12 Thread Eric Anholt
As I extend the driver to support different V3D revisions, userspace needs to know what version it's targeting. This is most easily detected using the V3D identity registers. v2: Make sure V3D is runtime PM on when reading the registers. Signed-off-by: Eric Anholt --- drivers/gpu/dr

Re: [PATCH] drm/panel: Remove the get_timings() function.

2016-07-12 Thread Eric Anholt
Thierry Reding writes: > On Wed, Jun 01, 2016 at 12:18:01PM -0700, Eric Anholt wrote: >> It appears to have no callers. >> >> Signed-off-by: Eric Anholt >> --- >> drivers/gpu/drm/panel/panel-simple.c | 18 -- >> include/drm/drm_pan

[GIT PULL] drm-vc4-next-2016-07-12

2016-07-12 Thread Eric Anholt
drm/vc4: clean up error exit path on failed dpi_connector allocation drm/vc4: remove redundant ret status check Eric Anholt (2): Merge tag 'drm-vc4-fixes-2016-06-06' into drm-vc4-next drm/vc4: Bind the HVS before we bind the individual CRTCs. Mario Kleiner

Re: [PATCH v3 1/2] ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi

2016-08-18 Thread Eric Anholt
ned-off-by: Ian Campbell > Acked-by: Mark Rutland > Tested-by: Stefan Wahren I'd lost track of these patches, sorry. Both are: Acked-by: Eric Anholt They're going through the -soc tree, right? signature.asc Description: PGP signature

[PATCH] drm/vc4: Don't force new binner overflow allocation per draw.

2016-08-19 Thread Eric Anholt
This came from the initial bringup code, which always idled the GPU and always reset the overflow. That massively increases the size of the working set when you're doing lots of small draws, though, as is common on X desktops or piglit. Signed-off-by: Eric Anholt --- drivers/gpu/dr

Re: [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting

2016-06-13 Thread Eric Anholt
for a long time, and this fix is pretty dependent on the recent refactors. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 2/2] dmaengine: bcm2835: Avoid splitting periods into very small chunks

2016-06-13 Thread Eric Anholt
* latency of fetching the CBs. */ if (period_remaining < max_len * 2) { control_block->length = DIV_ROUND_UP(period_remaining, 8) * 4; } /* update number of bytes in this period so far */ *total_len += control_block-&g

[PATCH] dma: bcm2835: Fix compiler warning on arm64.

2016-06-03 Thread Eric Anholt
The min() macro was complaining about mismatched types. The max len is at most SZ_1G, so we can just put it in an unsigned int. Signed-off-by: Eric Anholt --- Vinod, if you ack it, this one would be nice to be able to merge through the -soc tree, so that when we enable of arm64 builds of this

[PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

2016-06-03 Thread Eric Anholt
ne to write its registers due to a bug in the AXI bridge. Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 6149b27c33ad..320461c578

Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835.

2016-06-04 Thread Eric Anholt
Catalin Marinas writes: > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote: >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >> index 7ef1d05..ea88402 100644 >> --- a/arch/arm64/Kconfig.platforms >> +++ b/arch/arm64/Kconfig.platforms >> @@ -13,6 +13,19 @@ c

Re: [PATCH V2 13/63] clocksource/drivers/bcm2835_timer: Convert init function to return error

2016-06-25 Thread Eric Anholt
success in the init > function. > > Signed-off-by: Daniel Lezcano For the bcm2835 changes here and in 63/63: Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure

2016-03-13 Thread Eric Anholt
Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM > BOs.') > Signed-off-by: Dan Carpenter Pulled. Thanks! signature.asc Des

[GIT PULL] drm-vc4-next for 4.6

2016-03-14 Thread Eric Anholt
g detection for the Pi2/3. Dan Carpenter (1): drm/vc4: Return -EFAULT on copy_from_user() failure Eric Anholt (4): drm/vc4: Let gpiolib know that we're OK with sleeping for HPD. drm/vc4: Respect GPIO_ACTIVE_LO

Re: [PATCH 1/5] ARM: bcm2835: Define standard pinctrl groups in the gpio node.

2016-03-03 Thread Eric Anholt
Stephen Warren writes: > On 02/26/2016 11:19 AM, Eric Anholt wrote: >> The BCM2835-ARM-Peripherals.pdf documentation specifies what the >> function selects do for the pins, and there are a bunch of obvious >> groupings to be made. With these created, we'll be

Re: [PATCH 2/5] ARM: bcm2835: Replace alt0/i2s_alt[02] with standard groups.

2016-03-03 Thread Eric Anholt
Stephen Warren writes: > On 02/26/2016 11:19 AM, Eric Anholt wrote: >> Since all of these pins were documented, we can use their names to >> explain what's going on. > >> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >> b/arch/arm/boot/dts/

[GIT PULL] drm-vc4-fixes-2016-03-03

2016-03-03 Thread Eric Anholt
2:48 -0800) This pull request fixes the major VC4 HDMI modesetting bugs found when the first wave of users showed up in Raspbian. ---- Eric Anholt (6): drm/vc4: Fix a framebuffer reference leak on

[PATCH 1/2] dt-bindings: Add root properties for Raspberry Pi 3

2016-03-04 Thread Eric Anholt
Signed-off-by: Eric Anholt --- Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt index 11d3056..6ffe087 100644

[PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
For now this doesn't support the new hardware present on the Pi 3 (BT, wifi, GPIO expander). Since the GPIO expander isn't supported, we also don't have the LEDs like the other board files do. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/Makefile| 3 +- ar

Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
Mark Rutland writes: > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote: >> For now this doesn't support the new hardware present on the Pi 3 (BT, >> wifi, GPIO expander). Since the GPIO expander isn't supported, we >> also don't have th

Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
Mark Rutland writes: > On Fri, Mar 04, 2016 at 10:55:03AM -0800, Eric Anholt wrote: >> Mark Rutland writes: >> >> > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote: >> >> For now this doesn't support the new hardware present on the Pi 3 (B

[PATCH 2/3] drm/vc4: Recognize a more specific compatible string for V3D.

2016-03-04 Thread Eric Anholt
the future. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 31de5d1..e6d3c60 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -26

[PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-04 Thread Eric Anholt
VC4 is the GPU (display and 3D) present on the 283x. Signed-off-by: Eric Anholt --- v2: Sort by register address, mark HDMI as disabled by default in the SoC file and enable it from -rpi. v3: Add references to the pixel/HSM clocks for HDMI. Rename compatibility strings and clean up

[PATCH 0/3] ARM: bcm2835: Include VC4 GPU in the DT

2016-03-04 Thread Eric Anholt
This has been floating around out of tree, and the Pi Foundation is including a variant of it in the device tree overlay in its firmware update system. Eric Anholt (3): dt-bindings: Add binding docs for V3D. drm/vc4: Recognize a more specific compatible string for V3D. ARM: bcm2835: Add VC4

[PATCH 1/3] dt-bindings: Add binding docs for V3D.

2016-03-04 Thread Eric Anholt
This was missed in the upstreaming process. Signed-off-by: Eric Anholt --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings

Re: [PATCH 4/5] drm/vc4: Add DPI driver

2016-03-24 Thread Eric Anholt
Rob Herring writes: > On Fri, Mar 18, 2016 at 07:42:45PM -0700, Eric Anholt wrote: >> The DPI interface involves taking a ton of our GPIOs to be used as >> outputs, and routing display signals over them in parallel. >> >> Signed-off-by: Eric Anholt >> --- &g

[PATCH 5/5] ARM: bcm2835: Add the DPI hardware to the device tree.

2016-03-24 Thread Eric Anholt
It's currently marked disabled, as it's not useful without a panel associated with it and the GPIO pins routed to ALT2. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arc

[PATCH 4/5] drm/vc4: Add DPI driver

2016-03-24 Thread Eric Anholt
The DPI interface involves taking a ton of our GPIOs to be used as outputs, and routing display signals over them in parallel. v2: Use display_info.bus_formats[] to replace our custom DT properties. Signed-off-by: Eric Anholt --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 36

[PATCH 1/5] of: Add vendor prefix for On Tat Industrial Company.

2016-03-24 Thread Eric Anholt
This is the vendor for a 7" DPI panel sold by Adafruit which I'd like to describe in DT. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 0/5 v2] drm/vc4: DPI panel support

2016-03-24 Thread Eric Anholt
This is round 2 of the DPI panel support for vc4. This time the custom properties are dropped in favor of connector->display_info.bus_formats[]. Testable tree is at: https://github.com/anholt/linux/tree/drm-vc4-dpi-boot Eric Anholt (5): of: Add vendor prefix for On Tat Industrial Comp

[PATCH 3/5] drm: Add an encoder and connector type enum for DPI.

2016-03-24 Thread Eric Anholt
ain things as well for the user (who, if anything, knows their product is a DPI kippah/panel combo), and actually doesn't have to exist (one could connect the 28 GPIOs directly to something else). Simply "DPI" seems like a good compromise name to distinguish from the HDMI, DSI, and TV con

[PATCH 2/5] panel-simple: Add the 7" DPI panel from Adafruit.

2016-03-24 Thread Eric Anholt
This is a basic TFT panel with a 40-pin FPC connector on it. The specification doesn't define timings, but the Adafruit instructions were setting up 800x480 CVT. v2: Add .bus_format and vsync/hsync flags. Signed-off-by: Eric Anholt Acked-by: Rob Herring --- .../bindings/display/panel/

[PATCH 8/8] dmaengine: bcm2835: add dma_memcopy support to bcm2835-dma

2016-03-19 Thread Eric Anholt
From: Martin Sperl Also added check for an error condition in bcm2835_dma_create_cb_chain that showed up during development of this patch. Tested using dmatest for all enabled channels. Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835

[PATCH 1/8] dmaengine: bcm2835: set residue_granularity field

2016-03-19 Thread Eric Anholt
d-off-by: Noralf Trønnes Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index 996c4b0..2d72fe8 100644 --- a/drivers/dma/bc

[PATCH 0/8 v4] bcm2835 DMA slave support

2016-03-19 Thread Eric Anholt
Here's the series for DMA slave and memcpy support for 2835, with the DT changes to enable the remaining channels dropped out while that goes through review. I had to do some minor conflict resolution, but it was pretty mechanical, and I tested again with dmatest on the last patch. Martin Sperl (

[PATCH 3/8] dmaengine: bcm2835: add additional defines for DMA-registers

2016-03-19 Thread Eric Anholt
From: Martin Sperl Add additional defines describing the DMA registers as well as adding some more documentation to those registers. Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 57

[PATCH 2/8] dmaengine: bcm2835: remove unnecessary masking of dma channels

2016-03-20 Thread Eric Anholt
m,dma-channel-mask = <0x7f35>;" So we can remove the whole masking of DMA channels. Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/dma/bcm2835-dma.c b/dri

Re: [GIT PULL] bcm2835 DT changes for 4.6

2016-02-10 Thread Eric Anholt
Martin Sperl writes: >> On 09.02.2016, at 01:32, Eric Anholt wrote: >> >> Hi Florian. Here's the first set of patches for bcm2835 for 4.6. >> We've got more DT patches that are going to happen for new boards, >> too, but they're still getting

Re: [GIT PULL] bcm2835 DT changes for 4.6

2016-02-12 Thread Eric Anholt
Florian Fainelli writes: > On 10/02/2016 10:51, Eric Anholt wrote: >> Martin Sperl writes: >> >>>> On 09.02.2016, at 01:32, Eric Anholt wrote: >>>> >>>> Hi Florian. Here's the first set of patches for bcm2835 for 4.6. >>>&g

Re: [PATCH 02/41] clk: bcm: Remove CLK_IS_ROOT

2016-03-02 Thread Eric Anholt
Stephen Boyd writes: > This flag is a no-op now. Remove usage of the flag. I like that this flag is going away. It's a nice cleanup. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 1/6] driver-core: platform: Provide helpers for multi-driver modules

2015-09-28 Thread Eric Anholt
; unwind properly on error. >> >> Cc: Greg Kroah-Hartman >> Signed-off-by: Thierry Reding > > I raised this already on irc but let's do it here too for the record: > Eric Anholt has a very similar thing (but in drm only) with the > addition of also integrating with

Re: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.

2015-09-28 Thread Eric Anholt
Stephen Warren writes: > On 09/10/2015 03:22 PM, Eric Anholt wrote: >> These will be used for enabling UART1, SPI1, and SPI2. > >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > >> +aux_clocks: aux-clocks@0x7e215004 { >>

Re: [PATCH v2 3/4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-09-28 Thread Eric Anholt
Stephen Warren writes: > On 09/10/2015 02:58 PM, Eric Anholt wrote: >> This adds support for enabling, disabling, and setting the rate of the >> audio domain clocks. It will be necessary for setting the pixel clock >> for HDMI in the VC4 driver and let us write a cpu

[PATCH v3 4/4] ARM: bcm2835: Switch to using the new clock driver support.

2015-09-28 Thread Eric Anholt
but it turns out the firmware needed to change to running it at the 250Mhz core clock speed to avoid a bug in clock domain crossing. Additionally, anything using BCM2835_CLOCK_VPU will now have a correct clock rate if the user configures the boot-time core clock speed using config.txt. Signed-off-by: E

[PATCH v3 1/4] clk: bcm2835: Move under bcm/ with other Broadcom SoC clk drivers.

2015-09-28 Thread Eric Anholt
clk-bcm2835.c predates the drivers under bcm/, but all the new BCM drivers are going in there so let's follow them. Signed-off-by: Eric Anholt Acked-by: Stephen Warren --- drivers/clk/Makefile| 1 - drivers/clk/bcm/Makefile| 1 + drivers/clk/{ => bcm}/clk-b

[PATCH v3 2/4] clk: bcm2835: Add binding docs for the new platform clock driver.

2015-09-28 Thread Eric Anholt
Previously we've only supported a few fixed clocks based on assumptions about how the firmware sets up the clocks, but this binding will let us control the actual (audio power domain) clock manager. Signed-off-by: Eric Anholt Acked-by: Stephen Warren --- .../bindings/clock/brcm,bc

[PATCH v3 3/4] clk: bcm2835: Add support for programming the audio domain clocks.

2015-09-28 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt Tested-by: Martin Sperl --- v2: Fix o

[PATCH 1/2] component: Make a "match_add all devices matching my drivers" helper.

2015-09-28 Thread Eric Anholt
The body of the loop is taken from the exynos driver. It appears to also be useful in msm, and I've used it in vc4. Signed-off-by: Eric Anholt --- This is separated from converting exynos to use it, to let it land separately and not have to sync between trees. drivers/base/component.c

[PATCH 2/2] drm/exynos: Use the core platform_driver component matching helper.

2015-09-28 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 37 +++-- 1 file changed, 7 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 831d2e4..74826ec 100644 --- a

[PATCH v2 1/4] drm: Put platform driver registration/unregistration loops in core.

2015-09-17 Thread Eric Anholt
This is mostly just a move of the code from exynos, with a slight reformat. I wanted to do a similar thing for vc4, and msm looks like a good candidate as well. Signed-off-by: Eric Anholt --- v2: Move to the KMS helper config flag, and add our kerneldoc to drm.tmpl (under the "D

[PATCH v2 2/4] drm/msm: Use drm_platform_register/unregister_drivers().

2015-09-17 Thread Eric Anholt
This matches how exynos handles the registration of its component drivers. Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/adreno/adreno_device.c | 12 +--- drivers/gpu/drm/msm/dsi/dsi.c | 16 +--- drivers/gpu/drm/msm/dsi/dsi.h | 2 -- drivers

[PATCH v2 3/4] drm: Move exynos "match_add all devices matching my drivers" to core.

2015-09-17 Thread Eric Anholt
This is a really nice way to handle the component setup. The subsystem driver knows that it's got a bunch of component drivers, and for any devices that matched its component drivers, it wants all of those to bind to it as master. Signed-off-by: Eric Anholt --- v2: Extend the kern

[PATCH v2 4/4] drm/msm: Use exynos's model for handling component driver matching.

2015-09-17 Thread Eric Anholt
This eliminates the need for the "connectors" and "gpus" nodes in the devicetree, which we were doing nothing connector- or gpu-specific with. Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/msm_drv.c | 65 +-- include/drm/drmP.h

Re: [PATCH v4 1/8] clk: bcm2835: Add binding docs for the Raspberry Pi clock provider

2015-08-12 Thread Eric Anholt
Michael Turquette writes: > Quoting Eric Anholt (2015-07-20 12:33:00) >> The hardware clocks are not controllable by the ARM, so we have to >> make requests to the firmware to do so from the VPU side. This will >> let us replace fixed clocks in our DT with actual clock co

Re: [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver.

2015-08-12 Thread Eric Anholt
Michael Turquette writes: > Hi Eric, > > Quoting Eric Anholt (2015-07-20 12:33:01) >> +void __init rpi_firmware_init_clock_provider(struct device_node *node) >> +{ >> + /* We delay construction of our struct clks until get time, >> +* bec

[GIT PULL] RPi SOC changes for v4.3

2015-08-12 Thread Eric Anholt
- This pull request contains the Raspberry Pi firmware driver, for communicating with the VPU which has exclusive control of some of the peripherals. -------- Eric Anholt (1): ARM: bcm2835: Add the Raspberry Pi firmware driver d

[PATCH v2 2/4] irqchip: bcm2835: If a parent interrupt is registered, chain from it.

2015-07-13 Thread Eric Anholt
The BCM2836 (Raspberry Pi 2) uses two levels of interrupt handling with the CPU-local interrupts being the root, so we need to register ours as chained off of the CPU's local interrupt. Signed-off-by: Eric Anholt --- .../brcm,bcm2835-armctrl-ic.txt

[PATCH v2 3/4] irqchip: Add documentation for the bcm2836 interrupt controller.

2015-07-13 Thread Eric Anholt
This is a new per-cpu root interrupt controller on the Raspberry Pi 2, which will chain to the bcm2835 interrupt controller for peripheral interrupts. Signed-off-by: Eric Anholt --- .../interrupt-controller/brcm,bcm2836-l1-intc.txt | 37 ++ 1 file changed, 37 insertions

[PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
This interrupt controller is the new root interrupt controller with the timer, PMU events, and IPIs, and the bcm2835's interrupt controller is chained off of it to handle the peripherals. I wrote the interrupt chip support, while Andrea Merello wrote the IPI code. Signed-off-by: Eric A

[PATCH v2 1/4] irqchip: bcm2835: Refactor handle_IRQ() calls out of MAKE_HWIRQ.

2015-07-13 Thread Eric Anholt
to 3 reads. Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2835.c | 57 ++- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c index e68c3b6..382450a 100644 --- a/drivers/i

Raspberry Pi 2 interrupt controller support (v2) Second round

2015-07-13 Thread Eric Anholt
As before, the full series you can build and test can be found at: https://github.com/anholt/linux/tree/bcm2836-irqchip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH 3/4] irqchip: Add documentation for the bcm2836 interrupt controller.

2015-07-10 Thread Eric Anholt
Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This is a new per-cpu root interrupt controller on the Raspberry Pi 2, >> which will chain to the bcm2835 interrupt controller for peripheral >> interrupts. > >> diff --git >> a/Documen

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Thomas Gleixner writes: > On Fri, 10 Jul 2015, Stephen Warren wrote: >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >> > +static void bcm2836_mask_per_cpu_irq(unsigned int reg, unsigned int bit) >> > +{ >> > + void __iomem *reg_base = intc.base + reg; >&g

Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2.

2015-07-13 Thread Eric Anholt
Stephen Warren writes: > On 07/07/2015 03:13 PM, Eric Anholt wrote: >> This interrupt controller is the new root interrupt controller with >> the timer, PMU events, and IPIs, and the bcm2835's interrupt >> controller is chained off of it to handle the peripherals.

Re: [PATCH v2 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates.

2015-12-24 Thread Eric Anholt
Michael Turquette writes: > On Fri, Dec 18, 2015 at 8:19 PM, Rob Herring wrote: >> On Tue, Dec 15, 2015 at 03:35:57PM -0800, Eric Anholt wrote: >>> These will be used for enabling UART1, SPI1, and SPI2. >>> >>> Signed-off-by: Eric Anholt >>> --- &g

Re: [PATCH] drm/vc4: fix build warning

2015-12-24 Thread Eric Anholt
has type > 'size_t' [-Wformat=] > DRM_ERROR("BO offset overflow (%d + %d > %d)\n", > > vbo->base.size is size_t and for printing size_t we should be using %zu. > > Signed-off-by: Sudip Mukherjee Reviewed-by: Eric Anholt and I've pulled it for the next round of fixes. signature.asc Description: PGP signature

Re: [PATCH v2 0/8] Raspberry Pi 2 support.

2015-12-24 Thread Eric Anholt
Arnd Bergmann writes: > On Tuesday 22 December 2015, Alexander Aring wrote: >> Later while booting the kernel hangs forever, the solution on my side >> was to enable: >> >> CONFIG_HAVE_ARM_ARCH_TIMER >> >> I think this doesn't use the BCM2835 timer anymore and some cortex-a7 >> related "generic

Including Raspberry Pi -next trees in linux-next

2015-12-26 Thread Eric Anholt
I'll be sending pull-requests to Florian soon, but I would like to get my trees included in linux-next to get increased testing coverage of them against everything else going on for 4.5. I'm expecting to produce trees under these branch names for the forseeable future. Repo: https://github.com/an

[PATCH 1/4] irqchip: bcm2836: Fix initialization of the LOCAL_IRQ_CNT*IRQ timers

2015-12-26 Thread Eric Anholt
The irqchip's register area includes the the setup for the timer's scaling factors, and for the platform we want a fixed configuration of these registers. Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 26 ++ 1 file changed, 26 insertions(+) di

[PATCH 4/4] irqchip: bcm2836: make code more readable

2015-12-26 Thread Eric Anholt
From: Andrea Merello Avoid using hardcoded magics. We have a #define for this number. No functional changes. Signed-off-by: Andrea Merello Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] irqchip: bcm2836: tolerate IRQs while no flag is set in ISR

2015-12-26 Thread Eric Anholt
IRQ lookup. Signed-off-by: Andrea Merello Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 59ac40c..bb8f234 100644 --- a

[PATCH 2/4] irqchip: bcm2836: Add SMP support for the 2836

2015-12-26 Thread Eric Anholt
-off-by: Eric Anholt --- v2: Merge into another CONFIG_SMP block. drivers/irqchip/irq-bcm2836.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 6ec125e..59ac40c 100644 --- a/drivers

[PATCH 0/4] bcm2836 (Raspberry Pi 2) interrupt controller updates for 4.5

2015-12-26 Thread Eric Anholt
fixed and a minor style cleanup to #2. Patches 3, 4 are new, but trivial. Andrea Merello (3): irqchip: bcm2836: Add SMP support for the 2836 irqchip: bcm2836: tolerate IRQs while no flag is set in ISR irqchip: bcm2836: make code more readable Eric Anholt (1): irqchip: bcm2836: Fix

Re: [PATCH v2 8/8] ARM: bcm2835: Add Kconfig support for bcm2836

2015-12-26 Thread Eric Anholt
Eric Anholt writes: > This should be a complete port of bcm2835 functionality to bcm2836 > (Raspberry Pi 2). > > Signed-off-by: Eric Anholt > --- > > v2: Implement Arnd's feedback to not split to ARCH_BCM2836, and > instead use more conditionals in AR

<    5   6   7   8   9   10   11   12   13   14   >