[patch] Add IVB model 3e support to /drivers/idle/intel_idle.c

2012-11-26 Thread Ethan Zhao
Hi, Len Please help to review and apply the patch if it is OK. I didn't go through all the related code, simply add the model 3e to the id list, I have tested it with stable branch kernel 3.6.7 on my Server with Intel ES0 installed. Thanks, Ethan commit 59b90976a0d93d1656583c7a807ec9c8909b077

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-28 Thread Ethan Zhao
Joe, Possibly your customer is running a kernel without source code on a platform whose vendor wouldn't like to fix BIOS issue( Is that a HP/Dell server ?). Anyway, to see if is a payload issue or, you could change the payload size with setpci tool to those devices and set the link retrain

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-10-04 Thread Ethan Zhao
Mike, Peter, Seems lots of work has been done these days, studious guys. those patches merged in last stable/dev branch (fix performance regression caused by extra rtimer programming and rescheduling IPI,confusing idle... etc) ? So I could just do a lazy pull for test with my environment. I nee

Re: Commit 07f9b61 breaks systems that don't implement a _CBA method

2013-10-05 Thread Ethan Zhao
On Sat, Oct 5, 2013 at 7:55 AM, Yinghai Lu wrote: > On Fri, Oct 4, 2013 at 3:11 PM, Bjorn Helgaas wrote: >> On Thu, Oct 3, 2013 at 7:18 PM, Hedi Berriche wrote: > >> It's regrettable that the code is so subtle. The obvious thing to do >> would be to check for _CBA, and if it doesn't exist, look

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-10-06 Thread Ethan Zhao
Got it. On Mon, Oct 7, 2013 at 12:41 PM, Mike Galbraith wrote: > On Fri, 2013-10-04 at 20:06 +0800, Ethan Zhao wrote: >> Mike, Peter, >>Seems lots of work has been done these days, studious guys. those >> patches merged in last stable/dev branch (fix performance regressi

[PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-12 Thread Ethan Zhao
Hi, Len, Robert, Please help to check the following patch, add more conditions when validate the 64bit 32bit FACS/DSDT address in FADT to follow ACPI spec, In the meantime, keep the compatibility and latitude. Thanks, Ethan >From c1116211a7b329c26b0370565c36b084ceb08f71 Mon Sep 17 00:0

Re: ACPI and NUMA guys, please help to check if this patch is OK

2012-11-13 Thread Ethan Zhao
ity domains number %d\n", + d , pxd); + return 0; + } + for (i = 0; i < d; i++) { for (j = 0; j < d; j++) { u8 val = slit->entry[d*i + j]; -- 1.7.1 Thanks, Ethan On Thu, May 24, 2012 at 12:59

[PATCH] arch/x86/pci/xen.c: fix a typo in comments

2012-12-19 Thread Ethan Zhao
Konrad, This patch fix a typo in comments of arch/x86/pci/xen.c Thanks, ethan.z...@oracle.com --- commit 333a48b76d5311ae370d65dfac293ca0d839c455 Author: ethan.zhao Date: Thu Dec 20 20:23:31 2012 -0800 Fix a typo in comments diff --git a/arch/x86

[patch]mpt2sas/mpt2sas_base.c temporarily mask the corrected AER bit while driver initializing to suppress AER

2012-11-15 Thread Ethan Zhao
Hi, Lsi guys, On our servers (Sun fire X3-2/2L/2B, Sun fire X4-2/2L/2B ), while loading mpt2sas driver, the _diag_reset action always triggers correct AER, So mask CRER bit before the reset action and restore it after successful resetting. Please help to check the attached patch, I hav

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
Bob, Thanks for your detailed reviewing about the whole possible conditions. I.C. So that is impossible zero value for Xfacs /Xdsdt if facs/dsdt >0, for they are assigned in acpi_tb_convert_fadt(), I need to move my eyes one line code higher to see why it yelled twice but not using

Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

2012-11-15 Thread Ethan Zhao
DT.Xdsdt))); - - acpi_gbl_FADT.Xdsdt = (u64)acpi_gbl_FADT.dsdt; - } - /* If Hardware Reduced flag is set, we are all done */ if (acpi_gbl_reduced_hardware) { -- 1.7.1 Thanks, Ethan On Fri, Nov 16, 2012 at 11:49 AM, Moore, Robert wrote: > No decision(s) yet, we are stil

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-27 Thread Ethan Zhao
On Sat, Jul 27, 2013 at 1:39 AM, Bjorn Helgaas wrote: > [+cc Jiang, linux-pci, -cc bjorn.helg...@hp.com (dead address)] > > On Fri, Jul 26, 2013 at 05:10:39PM +0800, ethan zhao wrote: >> Cleanup the -EINVAL return value handling and add warning message >> for invalid >>

Re: [PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-27 Thread Ethan Zhao
Seems there are code style issues etc after I pasted it in my mail client. I will correct it and resend v2. Thanks. On Sun, Jul 28, 2013 at 12:09 AM, Bjorn Helgaas wrote: > On Sat, Jul 27, 2013 at 8:27 AM, Yinghai Lu wrote: >> On Fri, Jul 26, 2013 at 10:39 AM, Bjorn Helgaas wrote: > >>> [b

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-07-30 Thread Ethan Zhao
On Tue, Jul 30, 2013 at 5:35 PM, Peter Zijlstra wrote: > > On Tue, Jul 30, 2013 at 05:12:49PM +0800, Ethan Zhao wrote: > > On Mon, Jul 29, 2013 at 6:18 PM, Thomas Gleixner wrote: > > > The test case does not involve anything hrtimer related. Do you have > > &g

[PATCH] hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-07-25 Thread Ethan Zhao
commit 968320b hrtimer: Fix extra wakeups from __remove_hrtimer() introduced a significant scheduling performance regression, following is the test: a. Test environment: SUN FIRE X4170 M2 SERVER CPU model name: Intel(R) Xeon(R) CPU X5675 @ 3.07GHz 2 socket X 6 core X 2 thread b. To eliminate the

[PATCH] x86/PCI: MMCONFIG: cleanup and add address warning to pci_mmconfig_insert

2013-07-26 Thread ethan zhao
Cleanup the -EINVAL return value handling and add warning message for invalid start,end,addr parameters. Signed-off-by: ethan.zhao --- arch/x86/pci/mmconfig-shared.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pc

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva wrote: > Check return value from call

Re: [PATCH] x86/MCE, xen/mcelog: Make /dev/mcelog registration messages more precise

2017-06-20 Thread Ethan Zhao
Borislav, How about skipping the misc_register() steps and keep silence if you know it is running as Dom0 ? as it is easy to know. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:16 AM, Borislav Petkov wrote: > From: Juergen Gross > > When running under Xen as dom0, /dev/

Re: [PATCH] Moved module init-functions into the module.

2017-06-22 Thread Ethan Zhao
functions. Reviewed-by: Ethan Zhao On Thu, Jun 22, 2017 at 2:55 PM, Steve Kemp wrote: > > This commit moves the call to initialize the LSM modules inline > into the LSM-files themselves. > > This removes the need to hunt around for the setup, which was > something that b

Re: [PATCH 04/27] Restrict /dev/mem and /dev/kmem when the kernel is locked down

2017-10-24 Thread Ethan Zhao
David, May I ask a question here -- Is it intentionally enabling the read-only mode, so userspace tools like dmidecode could work with kernel_is_locked_down ? while it was impossible to work with the attached patch applied. Is it a security policy change with secure boot ? Thanks, Ethan On

Re: [PATCH v2] iov: restore NumVFs register to 0 before return from virtfn_max_buses()

2015-10-21 Thread ethan zhao
Bjorn, On 2015/10/22 4:54, Bjorn Helgaas wrote: On Thu, Oct 15, 2015 at 12:16:00PM -0500, Bjorn Helgaas wrote: Hi Ethan, On Wed, Sep 16, 2015 at 12:19:53PM +0900, Ethan Zhao wrote: After commit 4449f079722c ("PCI: Calculate maximum number of buses required for VFs"),the initia

Re: [PATCH v2] iov: restore NumVFs register to 0 before return from virtfn_max_buses()

2015-10-26 Thread ethan zhao
On 2015/10/22 4:54, Bjorn Helgaas wrote: On Thu, Oct 15, 2015 at 12:16:00PM -0500, Bjorn Helgaas wrote: Hi Ethan, On Wed, Sep 16, 2015 at 12:19:53PM +0900, Ethan Zhao wrote: After commit 4449f079722c ("PCI: Calculate maximum number of buses required for VFs"),the initial value

Re: [PATCH v2] iov: restore NumVFs register to 0 before return from virtfn_max_buses()

2015-10-27 Thread ethan zhao
Alexander, On 2015/10/27 13:48, Alexander Duyck wrote: On 10/15/2015 10:16 AM, Bjorn Helgaas wrote: Hi Ethan, On Wed, Sep 16, 2015 at 12:19:53PM +0900, Ethan Zhao wrote: After commit 4449f079722c ("PCI: Calculate maximum number of buses required for VFs"),the initial value of NumVF

[PATCH 2/2 V9] intel_pstate: add kernel parameter to force loading.

2014-12-08 Thread Ethan Zhao
To force loading on Oracle Sun X86 servers, provide one kernel command line parameter intel_pstate = force For those who be aware of the risk of no power capping capabily working and try to get better performance with this driver. Signed-off-by: Ethan Zhao Tested-by: Alexey Kodanev Reviewed

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread ethan zhao
Rafael, On 2014/12/5 6:10, Rafael J. Wysocki wrote: On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote: To force loading on Oracle Sun X86 servers, provide one kernel command line parameter intel_pstate = ora_force I would suggest to change the name of the option to "oracle_

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread ethan zhao
Kristen, On 2014/12/5 6:38, Kristen Carlson Accardi wrote: On Thu, 04 Dec 2014 23:10:58 +0100 "Rafael J. Wysocki" wrote: On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote: To force loading on Oracle Sun X86 servers, provide one kernel command line parameter in

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread ethan zhao
Linda, On 2014/12/5 7:03, Linda Knippers wrote: On 12/4/2014 5:38 PM, Kristen Carlson Accardi wrote: On Thu, 04 Dec 2014 23:10:58 +0100 "Rafael J. Wysocki" wrote: On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote: To force loading on Oracle Sun X86 servers, provide

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread ethan zhao
Linda, On 2014/12/5 12:56, Linda Knippers wrote: Hi Ethan, On 12/4/2014 10:38 PM, ethan zhao wrote: Linda, On 2014/12/5 7:03, Linda Knippers wrote: On 12/4/2014 5:38 PM, Kristen Carlson Accardi wrote: On Thu, 04 Dec 2014 23:10:58 +0100 "Rafael J. Wysocki" wrote: On Thursday, D

[PATCH 2/2 V8] intel_pstate: add kernel parameter to force loading.

2014-12-05 Thread Ethan Zhao
To force loading on Oracle Sun X86 servers, provide one kernel command line parameter intel_pstate = force For those who be aware of the risk of no power capping capabily working and try to get better performance with this driver. Signed-off-by: Ethan Zhao Tested-by: Alexey Kodanev --- v2

[PATCH] PCI: export pci device assignment info as read only via sysfs

2014-12-30 Thread Ethan Zhao
/assigned 1 PCI device isn't assigned to guest OS $cat /sys/devices/pci:00/:00:1f.3/assigned 0 Compiled and tested with v3.18.1 Signed-off-by: Ethan Zhao --- drivers/pci/pci-sysfs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pc

Re: [PATCH] Selinux/hooks.c: Fix a NULL pointer dereference caused by semop()

2015-01-22 Thread ethan zhao
Manfred, On 2015/1/23 2:15, Manfred Spraul wrote: On 01/22/2015 03:44 AM, Ethan Zhao wrote: On Wed, Jan 21, 2015 at 1:30 PM, Manfred Spraul wrote: On 01/21/2015 04:53 AM, Ethan Zhao wrote: On Tue, Jan 20, 2015 at 10:10 PM, Stephen Smalley wrote: On 01/20/2015 04:18 AM, Ethan Zhao wrote

Re: [PATCH] Selinux/hooks.c: Fix a NULL pointer dereference caused by semop()

2015-01-22 Thread ethan zhao
Stephen, On 2015/1/23 3:05, Stephen Smalley wrote: On Wed, Jan 21, 2015 at 9:44 PM, Ethan Zhao wrote: On Wed, Jan 21, 2015 at 1:30 PM, Manfred Spraul wrote: On 01/21/2015 04:53 AM, Ethan Zhao wrote: On Tue, Jan 20, 2015 at 10:10 PM, Stephen Smalley wrote: On 01/20/2015 04:18 AM, Ethan

Re: [PATCH] Selinux/hooks.c: Fix a NULL pointer dereference caused by semop()

2015-01-22 Thread ethan zhao
Davidlohr, On 2015/1/23 4:48, Davidlohr Bueso wrote: On Thu, 2015-01-22 at 14:05 -0500, Stephen Smalley wrote: On Wed, Jan 21, 2015 at 9:44 PM, Ethan Zhao wrote: On Wed, Jan 21, 2015 at 1:30 PM, Manfred Spraul wrote: On 01/21/2015 04:53 AM, Ethan Zhao wrote: On Tue, Jan 20, 2015 at 10:10

Re: [PATCH] Selinux/hooks.c: Fix a NULL pointer dereference caused by semop()

2015-01-23 Thread Ethan Zhao
(not verified yet on my case). Thanks, Ethan On Fri, Jan 23, 2015 at 11:30 AM, Davidlohr Bueso wrote: > On Fri, 2015-01-23 at 10:19 +0800, ethan zhao wrote: >> > If not, what kernel >> > version were you running when you triggered the bug? >> To be honest, a

Re: [PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-13 Thread ethan zhao
Vasu, On 2015/1/14 3:38, Dev, Vasu wrote: -Original Message- diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index a5f2660..a2572cc 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_

Re: [PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-15 Thread ethan zhao
Vasu, OK, disable FCOE as default configuration as a temporary step to make it work. Thanks, Ethan On 2015/1/16 7:45, Dev, Vasu wrote: -Original Message- From: ethan zhao [mailto:ethan.z...@oracle.com] Sent: Tuesday, January 13, 2015 6:41 PM To: Dev, Vasu Cc: Ethan Zhao

[PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-09 Thread Ethan Zhao
VLAN etc. Passed building with v3.19-rc3. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index

Re: [PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-12 Thread Ethan Zhao
Vasu, On Sat, Jan 10, 2015 at 2:18 AM, Dev, Vasu wrote: >> -Original Message- >> From: Ronciak, John >> Sent: Friday, January 09, 2015 8:42 AM >> To: Ethan Zhao; Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; >> Wyborny, Carolyn; Skidmore, Donald C;

Re: [PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-16 Thread ethan zhao
Vasu, What' your idea about the v2, any suggestion ? Jeff is looking forward to see it. Thanks, Ethan On 2015/1/16 22:47, Jeff Kirsher wrote: On Fri, 2015-01-16 at 09:48 +0800, ethan zhao wrote: Vasu, OK, disable FCOE as default configuration as a temporary step to make it

Re: [PATCH] i40e: don't enable and init FCOE by default when do PF reset

2015-01-19 Thread ethan zhao
On 2015/1/20 5:10, Dev, Vasu wrote: -Original Message- From: ethan zhao [mailto:ethan.z...@oracle.com] Sent: Friday, January 16, 2015 7:01 PM To: Kirsher, Jeffrey T Cc: Dev, Vasu; Ethan Zhao; Ronciak, John; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose

[PATCH] Selinux/hooks.c: Fix a NULL pointer dereference caused by semop()

2015-01-20 Thread Ethan Zhao
->avc_has_perm(sid, isec->sid, isec->sclass, perms, &ad); ^- NULL pointer dereference happens The test kernel was running on VMware. This patch use to fix this serious security issue could be triggered by user space. This patch

[PATCH] Timer: fix a race condition between init_timers_cpu() and get_next_timer_interrupt()

2015-04-29 Thread Ethan Zhao
nte->base)) ... } This bug will affect stable branch 4.0, 3.8, 3.19, I didn't check other branches. The patch has been tested and verfied on stable 4.0. Reported-by: Tim Uglow Signed-off-by: Ethan Zhao --- kernel/time/timer.c | 4 1 file changed, 4 insertions(+

[PATCH] x86/mce: fix mce_restart() race with CPU hotplug operation

2015-04-29 Thread Ethan Zhao
others). and this patch has been verified on stable 4.0 branch. Reported-by: Tim Uglow Signed-off-by: Ethan Zhao --- arch/x86/kernel/cpu/mcheck/mce.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 3c036cb..fcc2794

[PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI

2015-05-27 Thread Ethan Zhao
server X5-2 series and HP ProLiant DL380 Gen9 with kernel 4.0.4 Signed-off-by: Ethan Zhao Tested-by: Kunlun Lao --- arch/x86/kernel/sysfb_simplefb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c index

Re: [PATCH] x86/simplefb: simplefb was broken on Oracle and HP system, skip VIDEO_TYPE_EFI

2015-06-09 Thread ethan zhao
On 2015/6/5 17:31, David Herrmann wrote: Hi On Fri, Jun 5, 2015 at 11:17 AM, Matt Fleming wrote: (Cc'ing David) On Wed, 27 May, at 04:45:48PM, Ethan Zhao wrote: As descriped in https://bugzilla.kernel.org/show_bug.cgi?id=98721 When kernel 4.0.4 was tested on Oracle and HP system with

Re: [PATCH v7 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot_reset() callback

2020-11-26 Thread Ethan Zhao
On Wed, Nov 25, 2020 at 2:47 AM Guilherme G. Piccoli wrote: > > Hi Kuppuswamy Sathyanarayanan (and all involved here), thanks for the > patch! I'd like to ask what is the status of this patchset - I just > "parachuted" in the issue, and by tracking the linux-pci ML, I found > this V7 (and all prev

[PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-08 Thread ethan zhao
in function iommu_support_dev_iotlb(),return value of device_to_iommu() is used without checking, this could cause NULL pointer issue. this patch is for v3.12.6 Signed-off-by: Ethan Zhao --- drivers/iommu/intel-iommu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a

Re: [PATCH Trivial] intel-iommu: check return value of device_to_iommu() before using it

2014-01-09 Thread Ethan Zhao
On Thu, Jan 9, 2014 at 8:01 PM, Joerg Roedel wrote: > On Thu, Jan 09, 2014 at 09:58:42AM +0800, ethan zhao wrote: >> drivers/iommu/intel-iommu.c |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/iommu/intel-iommu.c b/drivers/i

Re: [PATCH 1/2 v2] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, I will check the patch and make it pass the building, seems encoding issue. Thanks, Ethan On Wed, Jan 15, 2014 at 11:46 AM, Brown, Aaron F wrote: > On Fri, 2013-12-27 at 01:02 -0800, Jeff Kirsher wrote: >> On Wed, 2013-12-25 at 00:12 +0800, Ethan Zhao wrote: >> > Be

[PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Because ixgbe driver limit the max number of VF functions could be enabled to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v2: fix a typo. v3: fix a encoding issue. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4

[PATCH 2/2] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread Ethan Zhao
sriov_set_totalvfs() before enable VFs with ixgbe_enable_sriov(). Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ma

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-11-11 Thread Ethan Zhao
k driver: be2net Average Bandwidth for : 1.tcp-unidirectional test: 7992 Mbits/sec 2.tcp-unidirectional-parallel: 9403 Mbits/sec 3.tcp-bidirectonal test : 5802 Mbits/sec Thanks, Ethan On Thu, Oct 31, 2013 at 11:25 PM, Eric Dumazet wrote: > On Thu, 2013-10-31 at 10:44 +

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-11-11 Thread Ethan Zhao
for last HTML mail, resend txt ) Ethan On Tue, Nov 12, 2013 at 9:34 AM, Eric Dumazet wrote: > On Tue, 2013-11-12 at 09:03 +0800, Ethan Zhao wrote: >> Eric, >> We have tested the performance with the TSO and TSQ patches >> merged, the result not good, even worse than ker

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-20 Thread Ethan Zhao
Bjorn, To be honest, the output above is picked up from other guy's mail, because I composed the patch mail at home and left the real bug material at company, they 'really' hit an issue confused by lspci output while SR-IOV is initialized to disabled . There is an error in above output as de

Re: [PATCH] PCI: Init NumVFs register to zero in sriov_init()

2013-11-20 Thread Ethan Zhao
Bjorn, I revised the description part with the original bug material as below, help to take a look, will send V2 back to home, SMTP blocked by company network. PCI: Init NumVFs register to zero in sriov_init() Though no specification about NumVFs register initial value after POST, to

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-11 Thread Ethan Zhao
On Fri, Oct 11, 2013 at 11:35 PM, Greg KH wrote: > On Fri, Oct 11, 2013 at 10:58:18AM +0800, ethan.zhao wrote: >> From: "ethan.zhao" >> >> While loading ixgbevf driver,every vf detected will be output as the >> same name 'eth4': >> >> ixgbevf: Intel(R) 10 Gigabit PCI Express Virtual Function Net

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-11 Thread Ethan Zhao
On Sat, Oct 12, 2013 at 1:26 AM, Skidmore, Donald C wrote: >> -Original Message- >> From: Greg KH [mailto:gre...@linuxfoundation.org] >> Sent: Friday, October 11, 2013 9:12 AM >> To: Bjorn Helgaas >> Cc: ethan.zhao; linux-kernel@vger.kernel.org; Skidmore, Donald C; e1000- >> de...@lists.so

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Sat, Oct 12, 2013 at 12:08 AM, Bjorn Helgaas wrote: > [+cc Don, e1000-devel] > > On Fri, Oct 11, 2013 at 9:35 AM, Greg KH wrote: >> On Fri, Oct 11, 2013 at 10:58:18AM +0800, ethan.zhao wrote: >>> From: "ethan.zhao" >>> >>> While loading ixgbevf driver,every vf detected will be output as the >

Re: [PATCH] drivers/base/core.c: always output device renaming messages.

2013-10-12 Thread Ethan Zhao
On Sun, Oct 13, 2013 at 1:50 AM, Greg KH wrote: > On Sat, Oct 12, 2013 at 02:52:51PM +0800, Ethan Zhao wrote: >> >> --- a/drivers/base/core.c >> >> +++ b/drivers/base/core.c >> >> @@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char

Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-10-30 Thread Ethan Zhao
Hi guys, We got network I/O performance degradation with latest stable kernel and the be2net driver as compared to old kernel 3.0.6. later we found even compared to the same latest stable kernel but the INTEL_IOMMU set to 'n', still got very noticeable performance regression: Kernel : 3

Re: Got iperf regression while intel_iommu is on, how to cut the cost of cache flushing

2013-10-31 Thread Ethan Zhao
Eric, Thanks, hope it could kill the most pain of the regression. I will try them and report the result. Ethan > You might hit a known problem for some 10Gb links. > > 3.12-rc6 has the fixes already, and stable has some pending backports : > > commit 95bd09eb27507691520d39ee1044d6ad831c1168 >

Re: NETDEV WATCHDOG: eth0 (e1000e): transmit queue 0 timed out

2013-12-02 Thread Ethan Zhao
Bjorn, Seems not the same bug as http://sourceforge.net/p/e1000/bugs/367/ , Nick is not running his kernel on bare metal, per the error log, he runs his kernel as HVM DomU guest or Dom0 on XEN ? so just a check of NULL will not fix that. Thanks, Ethan On Thu, Nov 21, 2013 at 5:22 AM, Bjorn

Re: [BUG] Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

2013-12-04 Thread Ethan Zhao
Rui, Agree with that, there are really many such confusing error type definition need to be standardized or unified, some of them are ambiguous、inconsistent, some of them violates ACPI/PCI spec. According to the ACPI spec, the 'FATAL' in fact, is a sub-category of 'UNCORRECTABLE' , the anothe

Re: [PATCH V3]hrtimer: Fix a performance regression by disable reprogramming in remove_hrtimer

2013-12-12 Thread Ethan Zhao
FLUSH' to all the buggy CPU, is that right ? Thanks, Ethan On Mon, Oct 7, 2013 at 12:57 PM, Ethan Zhao wrote: > Got it. > > On Mon, Oct 7, 2013 at 12:41 PM, Mike Galbraith wrote: >> On Fri, 2013-10-04 at 20:06 +0800, Ethan Zhao wrote: >>> Mike, Peter, >>>

[PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Ethan Zhao
stats() just as ixgbe driver did for some of its stats. Tested with last netxen 4.0.82 Compiled with stable 3.15.6 Signed-off-by: Ethan Zhao Tested-by: Sriharsha Yadagudde --- -v2 only fix rx_dropped field, not all. -v3 workaround checkpatch.pl bug according to suggestion from Joe Pe

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Ethan Zhao
On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram wrote: > On 07/18/2014 09:13 AM, Ethan Zhao wrote: >> >> netxen driver has implemented netxen_nic_get_ethtool_stats() interface, >> but it doesn't collect stats.rxdropped in driver, so we will get >> different rx_dro

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Ethan Zhao
在 2014年7月19日,上午2:21,Rajesh Borundia 写道: >> -Original Message- >> From: Ethan Zhao [mailto:ethan.z...@oracle.com] >> Sent: Friday, July 18, 2014 9:13 AM >> To: Manish Chopra; Sony Chacko; Rajesh Borundia; netdev >> Cc: linux-kernel; ethan.ker...@gmail.com;

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu wrote: > Ethan Zhao : >> ?? 2014??7??192:21??Rajesh Borundia >> ?? > [...] >> > I think ethtool stats are adapter specific. Driver does not maintain >> > rx_dropped stats and we also don't ge

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
> 在 2014年7月20日,上午12:28,Francois Romieu 写道: > > Ethan Zhao : >>> On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu >>> wrote: >>> Ethan Zhao : > [...] >>> I'd rather see ethtool stats provides one of those: >>> 1. hardware sta

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
ped field with my patch is the right way. the patch is not intended to dump hardware statistic counters. Thanks, Ethan On Sun, Jul 20, 2014 at 8:43 AM, Ethan Zhao wrote: > > >> 在 2014年7月20日,上午12:28,Francois Romieu 写道: >> >> Ethan Zhao : >>>> On Sat, Jul

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-20 Thread Ethan Zhao
-- Forwarded message -- From: Francois Romieu Date: Mon, Jul 21, 2014 at 2:01 AM Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats() To: Ethan Zhao Cc: Rajesh Borundia , Ethan Zhao , Manish Chopra , Sony Chacko , netdev , linux-kernel

[PATCH] i40e: use global pci_vfs_assigned() to replace local i40e_vfs_are_assigned()

2014-07-21 Thread Ethan Zhao
There is global funcion pci_vfs_assigned(), so use it instead of composing local one. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 31 +--- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e

Re: [PATCH 3/4 v3] xen-pciback: use pci device flag operation helper function

2014-07-29 Thread Ethan Zhao
> 在 2014年7月29日,下午6:07,David Vrabel 写道: > >> On 29/07/14 05:06, Ethan Zhao wrote: >> Use pci device flag operation helper functions when set device >> to assigned or deassigned state. >> >> Signed-off-by: Ethan Zhao > > Konrad already reviewed this b

Re: [PATCH 2/4 v3] KVM: use pci device flag operation helper functions

2014-07-29 Thread Ethan Zhao
This patch was already Acked-by: Paolo Bonzini I forgot to add the Ack tag. Thanks, Ethan Sorry for last post in HTML format with ipad. On Tue, Jul 29, 2014 at 12:06 PM, Ethan Zhao wrote: > Use helper function instead of direct operation to pci device > flag when set device to assig

Re: [PATCH 3/4 v3] xen-pciback: use pci device flag operation helper function

2014-07-29 Thread Ethan Zhao
On Tue, Jul 29, 2014 at 6:07 PM, David Vrabel wrote: > On 29/07/14 05:06, Ethan Zhao wrote: >> Use pci device flag operation helper functions when set device >> to assigned or deassigned state. >> >> Signed-off-by: Ethan Zhao > > Konrad already reviewed this but

[PATCH] ixgbe: delete one duplicate marcro definition of IXGBE_MAX_L2A_QUEUES

2014-09-20 Thread Ethan Zhao
There is typo in ixgbe.h, two marcro definition of IXGBE_MAX_L2A_QUEUES to 4, delete one, clear the compiler warning. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F wrote: > On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote: >> Because ixgbe driver limit the max number of VF functions could be enabled >> to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 >> in

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Is this your net-next repo ? if so, I rebuild the patch with this repo right now . git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git Thanks, Ethan On Thu, Jan 16, 2014 at 9:54 AM, Brown, Aaron F wrote: > On Thu, 2014-01-16 at 09:27 +0800, Ethan Zhao wrote: >&g

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Ok, Dave Miler's net-next tree. Thanks, Etan On Thu, Jan 16, 2014 at 10:51 AM, Brown, Aaron F wrote: > On Thu, 2014-01-16 at 09:58 +0800, Ethan Zhao wrote: >> Aaron, >> >> Is this your net-next repo ? if so, I rebuild the patch with this repo >> rig

Re: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
Aaron, Revised those patches for Dave Miller's net-next OK, passed building. resent. Thanks, Ethan On Thu, Jan 16, 2014 at 11:08 AM, Ethan Zhao wrote: > Aaron, > Ok, Dave Miler's net-next tree. > > Thanks, > Etan > > On Thu, Jan 16, 2014 at 10:51 AM, Bro

[PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. Signed-off-by: Ethan Zhao Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe

[PATCH 2/2 Net-next] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
sriov_set_totalvfs() before enable VFs with ixgbe_enable_sriov(). V2: revised for net-next tree. Signed-off-by: Ethan Zhao Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/et

Re: [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread Ethan Zhao
, 2014 at 1:57 PM, David Miller wrote: > From: ethan zhao > Date: Thu, 16 Jan 2014 12:25:01 +0800 > >> Signed-off-by: Ethan Zhao >> Signed-off-by: Ethan Zhao > > Please don't give two signoffs for yourself, it is not appropriate at > all. > > I am very genui

[PATCH 1/2 net-next v4] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread ethan zhao
Because ixgbe driver limit the max number of VF functions could be enalbed to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63 in code. v3: revised for net-next tree. V4: remove one signoff of two. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe

[PATCH 2/2 Net-next v4] ixgbe: set driver_max_VFs should be done before enabling SRIOV

2014-01-15 Thread ethan zhao
sriov_set_totalvfs() before enable VFs with ixgbe_enable_sriov(). V2: revised for net-next tree. V4: remove one signoff of two. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/et

[PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Ethan Zhao
Because bd_number is not useful anymore, so remove it from adapter struct, or if keep it, we have to fix the boards driven counter bug in ixgbe_remove() and ixgbe_probe() only for trival debug purpose -- other output is enough. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbe

[PATCH] ixgbevf: remove useless bd_number from struct ixgbevf_adapter

2014-07-28 Thread Ethan Zhao
It is useless and buggy, just remove it. Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h |1 - drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |4 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbevf

Re: [PATCH 1/4] PCI: introduce helper functions for device flag operation

2014-07-28 Thread ethan zhao
On 2014/7/29 5:00, Alex Williamson wrote: On Wed, 2014-07-23 at 00:19 +0800, Ethan Zhao wrote: This patch introduced three helper functions to hide direct device flag operation. void pci_set_dev_assigned(struct pci_dev *pdev); void pci_set_dev_deassigned(struct pci_dev *pdev); bool

[PATCH 1/4 v2] PCI: introduce helper functions for device flag operation

2014-07-28 Thread Ethan Zhao
This patch introduced three helper functions to hide direct device flag operation. void pci_set_dev_assigned(struct pci_dev *pdev); void pci_set_dev_deassigned(struct pci_dev *pdev); bool pci_is_dev_assigned(struct pci_dev *pdev); Signed-off-by: Ethan Zhao --- v2: simplify unnecessory ternary

Re: [PATCH 1/4] PCI: introduce helper functions for device flag operation

2014-07-28 Thread ethan zhao
On 2014/7/29 10:31, Alex Williamson wrote: On Tue, 2014-07-29 at 09:53 +0800, ethan zhao wrote: On 2014/7/29 5:00, Alex Williamson wrote: On Wed, 2014-07-23 at 00:19 +0800, Ethan Zhao wrote: This patch introduced three helper functions to hide direct device flag operation. void

Re: [PATCH] ixgbe: remove useless bd_number from adapter struct

2014-07-28 Thread Ethan Zhao
Thanks Brown, Aaron F On Tue, Jul 29, 2014 at 10:51 AM, Brown, Aaron F wrote: >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Ethan Zhao >> Sent: Monday, July 28, 2014 12:41 AM >> To: Kirsher, Jeffrey T; Brandebur

Re: [PATCH 1/4] PCI: introduce helper functions for device flag operation

2014-07-28 Thread Ethan Zhao
Both of you and Alex W prefer the 'Verb' , Ok, I accept the suggestion. Thanks, Ethan On Tue, Jul 29, 2014 at 11:37 AM, Alexander Duyck wrote: > On 07/28/2014 07:43 PM, ethan zhao wrote: >> >> On 2014/7/29 10:31, Alex Williamson wrote: >>> On Tue, 2014-07-2

[PATCH 0/4 v3] Introduce device assignment flag operation helper function

2014-07-28 Thread Ethan Zhao
This patch set introduces three PCI device flag operation helper functions when set pci device PF/VF to assigned or deassigned status also check it. and patch 2,3,4 apply these helper functions to KVM,XEN and PCI. v2: simplify unnecessory ternary operation in function pci_is_dev_assigned(). v3: am

[PATCH 3/4 v3] xen-pciback: use pci device flag operation helper function

2014-07-28 Thread Ethan Zhao
Use pci device flag operation helper functions when set device to assigned or deassigned state. Signed-off-by: Ethan Zhao --- v3: amend helper functions naming. drivers/xen/xen-pciback/pci_stub.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen

[PATCH 4/4 v3] PCI: use device flag operation helper function in iov.c

2014-07-28 Thread Ethan Zhao
Use device flag operation helper functions when check device assignment status. Signed-off-by: Ethan Zhao --- v3: amend helper functions naming. drivers/pci/iov.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index de7a747

[PATCH 1/4 v3] PCI: introduce helper functions for device flag operation

2014-07-28 Thread Ethan Zhao
This patch introduced three helper functions to hide direct device flag operation. void pci_set_dev_assigned(struct pci_dev *pdev); void pci_clear_dev_assigned(struct pci_dev *pdev); bool pci_is_dev_assigned(struct pci_dev *pdev); Signed-off-by: Ethan Zhao --- v2: simplify unnecessory ternary

[PATCH 2/4 v3] KVM: use pci device flag operation helper functions

2014-07-28 Thread Ethan Zhao
Use helper function instead of direct operation to pci device flag when set device to assigned or deassigned. Signed-off-by: Ethan Zhao --- v3: amend helper functions naming. virt/kvm/assigned-dev.c |2 +- virt/kvm/iommu.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 2/2 V3] PCI: implement VFs assignment reference counter

2014-07-11 Thread Ethan Zhao
-by: Ethan Zhao --- drivers/pci/iov.c | 42 -- drivers/pci/pci.h |1 + 2 files changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 090f827..10efe43 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c

[PATCH 1/2 V3] PCI: introduce device assignment interface and refactory related code

2014-07-11 Thread Ethan Zhao
atomic, steps clear between interface defination and implemenation according to the suggestion from alex.william...@redhat.com Signed-off-by: Ethan Zhao --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 17 ++--- drivers/pci/iov.c | 20

Re: [PATCH NET-NEXT V2] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-08 Thread ethan zhao
David, Please help to review and confirm this patch. Thanks, Ethan On 2014/7/8 21:57, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get different rx_dropped statistic information

  1   2   3   4   >