ow:
* do_dbs_timer() [-> dbs_timer_coordinated()] -> dbs_timer_update()
- simplified cpu_callback cases
v3
- original submission
Fabio Baltieri (4):
cpufreq: star/stop cpufreq timers on cpu hotplug
cpufreq: ondemand: call dbs_check_cpu only when necessary
cpufreq: conservative: call dbs_che
the cpufreq
governor (both ondemand and conservative).
This patch make sure that deferred timers are run on all CPUs in the
case of software controlled CPUs that run on the same frequency.
Signed-off-by: Rickard Andersson
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c
Add a CPU notifier to start and stop individual core timers on CPU
hotplug events when running on CPUs with SW coordinated frequency.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_governor.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a
Modify conservative timer to not resample CPU utilization if recently
sampled from another SW coordinated core.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c | 47 +-
1 file changed, 41 insertions(+), 6 deletions(-)
diff --git a
Modify update_sampling_rate() to check, and eventually immediately
schedule, all CPU's do_dbs_timer delayed work.
This is required in case of software coordinated CPUs, as we now have a
separate delayed work for each CPU.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_ondemand.
Modify ondemand timer to not resample CPU utilization if recently
sampled from another SW coordinated core.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_governor.c | 3 ++
drivers/cpufreq/cpufreq_governor.h | 1 +
drivers/cpufreq/cpufreq_ondemand.c | 58
ite+0x52/0xa0
Nov 26 17:36:54 balto kernel: [ 839.587306] [] ?
do_page_fault+0xe/0x10
Nov 26 17:36:54 balto kernel: [ 839.587345] []
system_call_fastpath+0x16/0x1b
Signed-off-by: Fabio Baltieri
---
Hi Rafael,
this is based on a clean linux-pm linux-next branch (i.e. not with my other
p
take it out the way.
Also, I think that cancel_delayed_work_sync can be removed too.
Should I send an updated version as soon as I get an ack for the other
patches in the series or do you want me to wait until 3.8-rc1?
Thanks,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the
Enable ux500 specific USB and watchdog drivers by default on
u8500_defconfig.
Signed-off-by: Fabio Baltieri
---
Hello Linus,
ux500 watchdog support was introduced during this merge window and USB
was fixed too, so I'm sending a defconfig update to enable those two
drivers by default, so
Hi Linus,
On Mon, Mar 18, 2013 at 12:00:57PM +0100, Fabio Baltieri wrote:
> Enable ux500 specific USB and watchdog drivers by default on
> u8500_defconfig.
Please ignore this patch, some new Kconfig menus are being added in
-next so ab8500 USB will need additional options. I'll sen
Enable ux500 specific USB and watchdog drivers by default on
u8500_defconfig.
Signed-off-by: Fabio Baltieri
---
Hi Linus,
this enables USB and watchdog on ux500 defconfig, and is generated
considering the new USB_PHY config option recently added in the
musb-next tree.
Thanks,
Fabio
arch/arm
Enable ux500 specific USB and watchdog drivers by default on
u8500_defconfig.
Signed-off-by: Fabio Baltieri
---
Hi again Linus,
seems like this is being harder than I thought... In v2 I had a
duplicated CONFIG_AB8500_USB symbol that was giving a warning in make
u8500_defconfig, this version
AB8500 asserts LATCH bits for masked out interrupts. This patch
explicitly masks those out using the cached mask value to prevent
handle_nested_irq() being called for masked IRQ on the same register as
unmasked ones.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
Hello Samuel
On Wed, Jan 23, 2013 at 11:16:19AM +0100, Linus Walleij wrote:
> On Mon, Jan 21, 2013 at 1:22 PM, Fabio Baltieri
> wrote:
> > On Mon, Jan 21, 2013 at 01:09:31PM +0100, Fabio Baltieri wrote:
> >> From: Rabin Vincent
> >>
> >> Modify clksrc_dbx500_prcmu_rea
27;s stuff, yes.
Lee's patches are on -next and should not conflict with this one
(tested again on today's tree), but it may be nice anyway to have this
in the regulator framework with the others.
Mark, would you consider taking this one in your tree?
Thanks,
Fabio
--
Fabio Baltier
Update V-INTCORE regulator constraints to allow voltage and
configuration changes from consumer drivers.
Signed-off-by: Fabio Baltieri
---
arch/arm/mach-ux500/board-mop500-regulators.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/board-mop500
On Tue, Apr 02, 2013 at 10:23:05AM +0100, Lee Jones wrote:
> On Tue, 02 Apr 2013, Fabio Baltieri wrote:
>
> > Update V-INTCORE regulator constraints to allow voltage and
> > configuration changes from consumer drivers.
> >
> > Signed-off-by: Fabio Baltieri
> >
et are a couple of printk warnings, so I
don't think is worth to go through tree dependency pain as everything
should come together nicely in linux-next.
Thanks,
Fabio
Fabio Baltieri (6):
usb: musb: ux500_dma: drop references to U5500
usb: phy: ab8500-usb: convert to devm_kzalloc
usb:
Drop references to deprecated U5500 platform in driver comments.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c
index f417b7e
Convert local data allocation to devm_kzalloc and drop unnecessary fail
path code.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/phy/phy-ab8500
Add initial regulator support to ab8500-usb by introducing necessary
devm_regulator_get().
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 36
1 file changed, 36 insertions(+)
diff --git a/drivers/usb/phy/phy
Split ab8500_usb_phy_ctrl into separate enable/disable functions to make
the code more linear and readable.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 55 +++-
1 file changed, 26 insertions(+), 29 deletions
-off-by: Praveena Nadahally
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 68 ++--
1 file changed, 66 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
From: Mian Yousaf Kaukab
To prevent clock and regulator frameworks from complaining, only disable
the host or peripheral phy if they were enabled.
Reported-by: Sakethram Bommisetti
Signed-off-by: Mian Yousaf Kaukab
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy
machine.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500.c | 1 -
drivers/usb/phy/phy-ab8500-usb.c | 10 +++---
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 88795f5..2c8000
pins are shared with ab8505_micro_usb_iddet driver.
Signed-off-by: Patrice Chotard
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/
Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 30 ++
1 file changed, 2 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/phy/phy-ab8500-usb.c b/drivers/usb/phy/phy-ab8500-usb.c
index 0875e2b..30adfee 100644
--- a/drivers/usb/phy/phy
From: Sakethram Bommisetti
Modify ab8500_usb_set_peripheral() and ab8500_usb_set_host() code to
schedule phy_dis_work only when necessary in order to prevent regulator
count mismatch during reboot/shutdown.
Signed-off-by: Sakethram Bommisetti
Acked-by: Linus Walleij
Signed-off-by: Fabio
From: Sakethram Bommisetti
AB8500 v2.0 has eye diagram issues when drawing more than 100mA from
VBUS. Force charging current to 100mA in case of standard host.
Signed-off-by: Sakethram Bommisetti
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c
From: Sakethram Bommisetti
Set phy tuning values proposed by the hardware teams for AB8500 and
AB8505 to improve USB eye diagram performances.
Signed-off-by: Sakethram Bommisetti
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 87
Hi Felipe,
On Wed, Apr 03, 2013 at 11:58:58AM +0300, Felipe Balbi wrote:
> On Wed, Apr 03, 2013 at 11:53:36AM +0300, Felipe Balbi wrote:
> > On Wed, Apr 03, 2013 at 10:45:05AM +0200, Fabio Baltieri wrote:
> > > From: Sakethram Bommisetti
> > >
> > > AB8
rn value in
all three affected USB phy drivers, and issue a dev_err() in case it
fails.
TWL4030 and TWL6030 patches has been build-tested only.
Thanks,
Fabio
Fabio Baltieri (3):
usb: phy: ab8500-usb: check regulator_enable return value
usb: phy: twl4030-usb: check regulator_enable return v
Since regulator_enable() is going to be marked as __must_check in the
next merge window, always check regulator_enable() return value and
print a warning if it fails.
Cc: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-ab8500-usb.c | 12 +---
1 file changed, 9
Since regulator_enable() is going to be marked as __must_check in the
next merge window, always check regulator_enable() return value and
print a warning if it fails.
Cc: Kalle Jokiniemi
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-twl4030-usb.c | 18 +++---
1 file changed
Since regulator_enable() is going to be marked as __must_check in the
next merge window, always check regulator_enable() return value and
print a warning if it fails.
Cc: Hema HK
Signed-off-by: Fabio Baltieri
---
drivers/usb/phy/phy-twl6030-usb.c | 11 +--
1 file changed, 9 insertions
Hi Felipe,
On Wed, Apr 03, 2013 at 05:06:22PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Wed, Apr 03, 2013 at 04:02:24PM +0200, Fabio Baltieri wrote:
> > While testing your 'next' branch merged with today's next I got some new
> > warnings, caused by a
ING(WATCHDOG_NOWAYOUT) ")");
>
> nowayout is a boolean value so please change this to
> static bool nowayout = WATCHDOG_NOWAYOUT;
Right.
> The rest is OK by me. So if bowayout get's fixed then you have my acked-by.
Ok, I'll send a v2 of this patch soon with both para
This patch adds support for the ux500_wdt watchdog that is found in
ST-Ericsson Ux500 platform. The driver is based on PRCMU APIs.
Acked-by: Linus Walleij
Acked-by: Lee Jones
Signed-off-by: Fabio Baltieri
---
Changes from v1:
- changed timeout as unsigned in both module parameter and pdata
Definitely, that's what we have -next for!
> On Thu, Dec 27, 2012 at 8:25 PM, Fabio Baltieri
> wrote:
>
> > diff --git a/drivers/cpufreq/cpufreq_governor.c
> > b/drivers/cpufreq/cpufreq_governor.c
>
> > static inline void dbs_timer_init(struct
;m sending a v7 with the cleanup on first patch and this one
dropped if you are ok with rebasing your pm-cpufreq-next. Let me know
if you prefer me to just send a revert + cleanup patch instead.
Thanks,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Jan 30, 2013 at 10:14:53AM +0100, Fabio Baltieri wrote:
> Hello Viresh,
>
> On Wed, Jan 30, 2013 at 12:33:40PM +0530, Viresh Kumar wrote:
> > I am starting to follow cpufreq patches religiously now and so have to come
> > back to this old thread due to some crash w
On Wed, Jan 30, 2013 at 04:47:58PM +0530, Viresh Kumar wrote:
> On 30 January 2013 16:34, Fabio Baltieri wrote:
> > Small sidenote, actually what I'm going to drop here i *cdbs, as I need
> > cpu for schedule_delayed_work_on and can't use cdbs->cpu for that as
>
patches instead.
Thanks,
Fabio
Fabio Baltieri (3):
cpufreq: ondemand: call dbs_check_cpu only when necessary
cpufreq: conservative: call dbs_check_cpu only when necessary
cpufreq: ondemand: use all CPUs in update_sampling_rate
Rickard Andersson (1):
cpufreq: handle SW coordinated CPUs
the cpufreq
governor (both ondemand and conservative).
This patch make sure that deferred timers are run on all CPUs in the
case of software controlled CPUs that run on the same frequency.
Signed-off-by: Rickard Andersson
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c
Modify ondemand timer to not resample CPU utilization if recently
sampled from another SW coordinated core.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_governor.c | 3 ++
drivers/cpufreq/cpufreq_governor.h | 1 +
drivers/cpufreq/cpufreq_ondemand.c | 58
Modify conservative timer to not resample CPU utilization if recently
sampled from another SW coordinated core.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c | 47 +-
1 file changed, 41 insertions(+), 6 deletions(-)
diff --git a
Modify update_sampling_rate() to check, and eventually immediately
schedule, all CPU's do_dbs_timer delayed work.
This is required in case of software coordinated CPUs, as we now have a
separate delayed work for each CPU.
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_ondemand.
Drop unused arguments from dbs_timer_init and clean dbs_timer_exit and
cpufreq_governor_dbs to remove non necessary special cases.
Reported-by: Viresh Kumar
Signed-off-by: Fabio Baltieri
---
Hello Rafael,
that's the cleanup on top of "cpufreq: handle SW coordinated CPUs".
[internal note]
> I believe you are required to send patches to patc...@linaro.org too :)
I already have patc...@linaro.org in BCC, all my patches are there.
[/internal note]
> On 30 January 2013 18:30, Fabio Baltieri wrote:
> > From: Rickard Andersson
> >
> > This patch f
On Wed, Jan 30, 2013 at 09:21:41PM +0530, Viresh Kumar wrote:
> On 30 January 2013 18:30, Fabio Baltieri wrote:
> > Modify ondemand timer to not resample CPU utilization if recently
> > sampled from another SW coordinated core.
> >
> > Signed-off-by: Fabio Baltieri
On Wed, Jan 30, 2013 at 09:23:22PM +0530, Viresh Kumar wrote:
> On 30 January 2013 18:30, Fabio Baltieri wrote:
> > Modify conservative timer to not resample CPU utilization if recently
> > sampled from another SW coordinated core.
> >
> > Signed-off-by: Fabio Baltie
ts v8.
I'm not sending a v8 as Rafael already asked for incremental, but I'll
send a patch with that soon.
Thanks,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Implement a generic helper function policy_is_shared() to replace the
current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be
used by code other than cpufreq governors.
Suggested-by: Viresh Kumar
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c | 2
Hello Viresh,
On Wed, Jan 30, 2013 at 10:41:08PM +0530, Viresh Kumar wrote:
> On 30 January 2013 22:16, Fabio Baltieri wrote:
> > Isn't that how it works now? The current cpu ktime is not checked
> > against its own, but against the "leader" cpu (dbs_info_local-&
On Thu, Jan 31, 2013 at 02:01:27PM +0530, Viresh Kumar wrote:
> On 31 January 2013 13:44, Fabio Baltieri wrote:
> > Implement a generic helper function policy_is_shared() to replace the
> > current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be
> > used by co
On Thu, Jan 31, 2013 at 02:12:29PM +0530, Viresh Kumar wrote:
> On 31 January 2013 14:09, Fabio Baltieri wrote:
> > Ok, now I see the problem: cdbs->cpu is initialized only on the leader
> > cpu and this is working by coincidence on my system, while
> > cdbs->time_stamp
Implement a generic helper function policy_is_shared() to replace the
current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be
used by code other than cpufreq governors.
Suggested-by: Viresh Kumar
Signed-off-by: Fabio Baltieri
---
Changes from v1:
- replaced cpumask_weight in acpi
Fix governors code to set all cpu's cdbs->cpu to the the actual cpu id
and use cur_policy->cpu istead of cdbs->cpu to track current governor's
leader cpu.
Reported-by: Viresh Kumar
Signed-off-by: Fabio Baltieri
---
drivers/cpufreq/cpufreq_conservative.c | 5 +++
On Thu, Jan 31, 2013 at 04:23:06PM +0530, Viresh Kumar wrote:
> On 30 January 2013 19:23, Fabio Baltieri wrote:
> > Drop unused arguments from dbs_timer_init and clean dbs_timer_exit and
> > cpufreq_governor_dbs to remove non necessary special cases.
> >
> > Reported-b
lo Viresh, thanks for getting this done... looks much cleaner now!
I tested both patches on my ux500 setup (dual Cortex-A9) and it seems to
run correctly on both CPU load changes and CPU hotplug, so:
Tested-by: Fabio Baltieri
As a sidenote, I noticed just now that since:
bc92bea cpufre
ced again. Get rid of it.
>
> Signed-off-by: Viresh Kumar
> ---
Hi,
Tested-by: Fabio Baltieri
Thanks,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hello Rafael,
On Thu, Jan 31, 2013 at 11:23:54PM +0100, Rafael J. Wysocki wrote:
> On Thursday, January 31, 2013 07:50:04 PM Fabio Baltieri wrote:
> > On Thu, Jan 31, 2013 at 10:58:02PM +0530, Viresh Kumar wrote:
> > > With the inclusion of following patches:
> >
On Sat, Feb 23, 2013 at 01:35:26AM +0100, Rafael J. Wysocki wrote:
> On Saturday, February 23, 2013 01:10:55 AM Fabio Baltieri wrote:
> > Well, this did the trick in my case:
> >
> > --- >8 ---
> > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
>
Hello Rafael,
On Sat, Feb 23, 2013 at 05:33:39AM +0100, Rafael J. Wysocki wrote:
> On Saturday, February 23, 2013 02:44:27 AM Fabio Baltieri wrote:
> > On Sat, Feb 23, 2013 at 01:35:26AM +0100, Rafael J. Wysocki wrote:
> > > The new sysfs interface for power resources control m
power.
>
> In addition to that, if it is impossible to determine the initial
> states of wakeup power resources, avoid enabling wakeup for devices
> whose wakeup power depends on those power resources.
>
> Reported-by: Dave Jones
> Reported-by: Fabio Baltieri
> Signed-off-by:
From: Rabin Vincent
Modify clksrc_dbx500_prcmu_read to replace readl() with readl_relaxed().
This speeds up calls to the function by about 40%.
Signed-off-by: Rabin Vincent
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/clocksource/clksrc-dbx500-prcmu.c | 9 -
1
Remove references to the deprecated DB5500 platform.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/clocksource/clksrc-dbx500-prcmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/clksrc-dbx500-prcmu.c
b/drivers/clocksource/clksrc
ction.
Thanks,
Fabio
Fabio Baltieri (4):
usb: musb: ux500: implement musb_set_vbus
usb: musb: ux500: add otg notifier support
usb: otg: ab8500-usb: drop support for ab8500 pre v2.0
usb: otg: ab8500-usb: update irq handling code
Virupax Sadashivpetimath (1):
usb: musb: ux500_dma: add missin
From: Virupax Sadashivpetimath
Fix dma_controller_create() fail path in case memory resource is
missing.
Acked-by: Linus Walleij
Signed-off-by: Virupax Sadashivpetimath
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500_dma.c | 12 +++-
1 file changed, 11 insertions(+), 1
Add ux500_musb_set_vbus() implementation for ux500.
This is based on the version originally developed inside ST-Ericsson.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500.c | 64
1 file changed, 64 insertions
Add transceiver notifier event handling to the ux500 driver to set vbus
on specific transceiver events.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/drivers/usb
AB8500 versions preceding 2.0 were only used internally by ST-Ericsson
and are not supported anymore. This patch drops all v1.0 and v1.1
support code.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/otg/ab8500-usb.c | 139 ---
1
devm_* helpers and
drop all non necessary fail path code.
Acked-by: Linus Walleij
Signed-off-by: Fabio Baltieri
---
drivers/usb/musb/ux500.c | 7 +-
drivers/usb/otg/ab8500-usb.c | 440 -
include/linux/usb/musb-ux500.h | 31 +++
3 files changed
Fix db8500_read_soc_id() to read all five soc_id number locations
instead of repeating the second one two times.
Signed-off-by: Fabio Baltieri
---
arch/arm/mach-ux500/cpu-db8500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm
being dropped at compile time if not needed.
Signed-off-by: Fabio Baltieri
---
Hello Felipe,
this looks like a leftover from the debug code cleanup. Some code in
cppi_dma was constantly compiled out, and that included some dead
_dbg_level() references. All debug printks are already declared
99%)
rename drivers/leds/{ => trigger}/ledtrig-default-on.c (98%)
rename drivers/leds/{ => trigger}/ledtrig-gpio.c (99%)
rename drivers/leds/{ => trigger}/ledtrig-heartbeat.c (99%)
rename drivers/leds/{ => trigger}/ledtrig-ide-disk.c (100%)
rename drivers/leds/{ => trigger}/ledtrig-on
kernel, there are some in your
dmesg too. I'll try to come up with a fix for current mainline, but all
the acpi stuff is quite obscure to me and the patch does not revert
cleanly, maybe Rafael (in CC) has some idea!
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: send the line "
On Fri, Feb 22, 2013 at 05:23:04PM -0500, Dave Jones wrote:
> On Fri, Feb 22, 2013 at 10:51:58PM +0100, Fabio Baltieri wrote:
> > On Fri, Feb 22, 2013 at 03:59:54AM -0500, Dave Jones wrote:
> > > On Thu, Feb 21, 2013 at 10:40:10AM -0800, Greg KH wrote:
> > >
> &
On Mon, Sep 03, 2012 at 08:13:35PM +0200, Kurt Van Dijck wrote:
> On Mon, Sep 03, 2012 at 02:40:39PM +0200, Marc Kleine-Budde wrote:
> > The net->ifindex is unique. But it's only an integer. Usually can0 has a
> > ifindex != 0, so a simple can%d is contra productive here.
> >
> > Some pointers to
On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote:
> On Mon, Sep 03, 2012 at 10:54:49PM +0200, Oliver Hartkopp wrote:
> > On 03.09.2012 20:29, Fabio Baltieri wrote:
> >
> > > On Mon, Sep 03, 2012 at 08:13:35PM +0200, Kurt Van Dijck wrote:
> > >>
in mind?
Of course that would simplify another bit trigger integration to the
driver... if the target is to have support for all drivers that's a good
thing, through I think that triggers are mostly useful on embedded drivers.
Cheers,
Fabio
--
Fabio Baltieri
--
To unsubscribe from this list: s
ique in case of hotplugging CAN devices.
>
> This patch tries to address this problem by modifying the
> LED trigger name according to the CAN device name when
> the latter changes.
>
> v1 - Kurt Van Dijck
> v2 - Fabio Baltieri
> - remove rename blocking if trigger is bound
Implements a "led_trigger_rename" function to rename a trigger with
proper locking.
This assumes that led name was originally allocated in non-constant
storage.
Signed-off-by: Fabio Baltieri
Cc: Kurt Van Dijck
Cc: Bryan Wu
---
Hi Bryan,
I'm resending this one as it was prob
on tx/rx LEDs
- CAN_LED_EVENT_STOP: turn off tx/rx LEDs
- CAN_LED_EVENT_TX: trigger tx LED blink
- CAN_LED_EVENT_RX: trigger tx LED blink
Cc: Oliver Hartkopp
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Signed-off-by: Fabio Baltieri
---
Hi all!
This is the v3 of my CAN LED trigger patch
Add support for canbus activity led indicators on flexcan devices by
calling appropriate can_led_* functions.
These are only enabled when CONFIG_CAN_LEDS is Y, becomes no-op
otherwise.
Signed-off-by: Fabio Baltieri
---
drivers/net/can/flexcan.c | 13 +
1 file changed, 13 insertions
Hi Marc,
On Mon, Jul 30, 2012 at 11:17:53PM +0200, Marc Kleine-Budde wrote:
> On 07/30/2012 09:20 PM, Fabio Baltieri wrote:
> > This patch implements the functions to add two LED triggers, named
> > -tx and -rx, to a canbus device driver.
> >
> > Triggers are calle
On Tue, Jul 31, 2012 at 12:12:59PM +0200, Marc Kleine-Budde wrote:
> >> +/*
> >> + * Register CAN LED triggers for a CAN device
> >> + *
> >> + * This is normally called from a driver's probe function
> >> + */
> >> +void can_led_init(struct net_device *netdev)
> >> +{
> >> + struct can_priv *priv
On Tue, Jul 31, 2012 at 09:10:00AM +0200, Marc Kleine-Budde wrote:
> >>> +/*
> >>> + * Register CAN LED triggers for a CAN device
> >>> + *
> >>> + * This is normally called from a driver's probe function
> >>> + */
> >>> +void can_led_init(struct net_device *netdev)
> >>> +{
> >>> + struct can_pri
On Tue, Jul 31, 2012 at 10:46:57AM +0200, Wolfgang Grandegger wrote:
> Hi Fabio,
>
> On 07/30/2012 09:20 PM, Fabio Baltieri wrote:
> > This patch implements the functions to add two LED triggers, named
> > -tx and -rx, to a canbus device driver.
> >
> > Triggers
function is
needed.
Supported events are:
- CAN_LED_EVENT_OPEN: turn on tx/rx LEDs
- CAN_LED_EVENT_STOP: turn off tx/rx LEDs
- CAN_LED_EVENT_TX: trigger tx LED blink
- CAN_LED_EVENT_RX: trigger tx LED blink
Cc: Oliver Hartkopp
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Signed-off-by: Fabio Baltieri
Hello Bryan,
On Sat, Sep 15, 2012 at 06:18:44PM +0200, Fabio Baltieri wrote:
> Implements a "led_trigger_rename" function to rename a trigger with
> proper locking.
>
> This assumes that led name was originally allocated in non-constant
> storage.
Did you have any ch
Hi Kurt,
On Thu, Sep 6, 2012 at 12:33 PM, Kurt Van Dijck wrote:
> On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote:
>> On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote:
> [...]
>> > > The name of the device can only be changed when the interfa
Hi Kurt,
thanks for the patch!
On Tue, Sep 04, 2012 at 11:29:11AM +0200, Kurt Van Dijck wrote:
> The LED trigger name for CAN devices is based on the initial
> CAN device name, but does never change. The LED trigger name
> is not guaranteed to be unique in case of hotplugging CAN devices.
>
> Th
On Thu, Sep 06, 2012 at 09:31:07PM +0200, Oliver Hartkopp wrote:
> >> +
> >> +/*
> >> + * NETDEV rename notifier to rename the associated led triggers too
> >> + */
> >> +static int can_led_notifier(struct notifier_block *nb, unsigned long msg,
> >> + void *data)
> >> +{
> >> + st
On Thu, Sep 06, 2012 at 05:11:58PM +0200, Kurt Van Dijck wrote:
> > > I also think that led triggers should be available.
> >
> > Right, that's why I think the only way is to use device name.
>
> yes, but it has 2 disadvantages:
> * inconvenient. I like 'can0-tx' much more than any device name
>
On Fri, Sep 07, 2012 at 09:04:19AM +0200, Kurt Van Dijck wrote:
> On Thu, Sep 06, 2012 at 10:57:28PM +0200, Fabio Baltieri wrote:
> > On Thu, Sep 06, 2012 at 05:11:58PM +0200, Kurt Van Dijck wrote:
> > Can't argue with that... I'm trying to see how it comes but names
Implements a led_trigger_rename() function to rename a trigger with
proper locking.
This also implies that "name" in "struct led_trigger" is not const
anymore.
Signed-off-by: Fabio Baltieri
Cc: Kurt Van Dijck
Cc: Bryan Wu
---
Hi all,
this adds a led_trigger_rename_static(
to the CAN device name when
the latter changes.
This patch is meant as illustration only.
In case of VCAN device rename, a segmentation fault will occur.
v1 - Kurt Van Dijck
v2 - Fabio Baltieri
- remove rename blocking if trigger is bound
- use led-subsystem function for the actual rename (still
On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote:
> On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote:
> > Implements a led_trigger_rename() function to rename a trigger with
> > proper locking.
> This is the way to go.
> Maybe add 'default_
> +{
> + if ((dev->type != ARPHRD_CAN) || (dev->rtnl_link_ops != &can_link_ops))
> + return NULL;
> +
> + return netdev_priv(dev);
> +}
> +
No EXPORT_SYMBOL_GPL here?
Looks good to me a part from that.
Fabio
--
Fabio Baltieri
--
To unsubscribe from this lis
1 - 100 of 332 matches
Mail list logo
