Re: [PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

hould I take this or is it going with the rest of the series? If you wanna take it through Trivial or something like that: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume

Hi, Roger Quadros writes: > Adding/removing host/gadget controller before .pm_complete() > causes a lock-up. Let's prevent any dual-role state change > between .pm_prepare() and .pm_complete() to fix this. > > Signed-off-by: Roger Quadros > --- >

Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume

Hi, Roger Quadros writes: > Adding/removing host/gadget controller before .pm_complete() > causes a lock-up. Let's prevent any dual-role state change > between .pm_prepare() and .pm_complete() to fix this. > > Signed-off-by: Roger Quadros > --- > drivers/usb/dwc3/core.c | 31

Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

Hi, Christophe JAILLET writes: > This serie aims to fix 2 issues. (path 2 & 4) > > The 2nd patch fixes a memory leak. It uses devm_ function a simplify the > handling of the memory. > > The 4th patch fixes a potential invalid pointer dereference. > > The 2 other

Re: [PATCH 0/4] usb: gadget: fotg210-udc: Fixes and cleanup

Hi, Christophe JAILLET writes: > This serie aims to fix 2 issues. (path 2 & 4) > > The 2nd patch fixes a memory leak. It uses devm_ function a simplify the > handling of the memory. > > The 4th patch fixes a potential invalid pointer dereference. > > The 2 other ones, are just clean-ups to

Re: [PATCH v2] usb: dwc3: core: Fix ULPI PHYs and prevent phy_get/ulpi_init during suspend/resume

Roger Quadros writes: > In order for ULPI PHYs to work, dwc3_phy_setup() and dwc3_ulpi_init() > must be doene before dwc3_core_get_phy(). > > commit 541768b08a40 ("usb: dwc3: core: Call dwc3_core_get_phy() before > initializing phys") > broke this. > > The other issue is that

Re: [PATCH v2] usb: dwc3: core: Fix ULPI PHYs and prevent phy_get/ulpi_init during suspend/resume

Roger Quadros writes: > In order for ULPI PHYs to work, dwc3_phy_setup() and dwc3_ulpi_init() > must be doene before dwc3_core_get_phy(). > > commit 541768b08a40 ("usb: dwc3: core: Call dwc3_core_get_phy() before > initializing phys") > broke this. > > The other issue is that

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

Hi, Kunihiko Hayashi writes: > Hello Felipe, > > Thank you for your comments. > > On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > >> >> Hi, >> >> Kunihiko Hayashi writes: >> > Add a specific glue layer for

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

Hi, Kunihiko Hayashi writes: > Hello Felipe, > > Thank you for your comments. > > On Tue, 23 Jan 2018 15:12:36 +0200 wrote: > >> >> Hi, >> >> Kunihiko Hayashi writes: >> > Add a specific glue layer for UniPhier SoC platform to support >> > USB host mode. It manages hardware operating

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

Hi, Kunihiko Hayashi writes: > Add a specific glue layer for UniPhier SoC platform to support > USB host mode. It manages hardware operating sequences to enable multiple > clock gates and assert resets, and to prepare to use dwc3 controller > on the SoC. > > This

Re: [PATCH 2/4] usb: dwc3: add dwc3 glue layer for UniPhier SoCs

Hi, Kunihiko Hayashi writes: > Add a specific glue layer for UniPhier SoC platform to support > USB host mode. It manages hardware operating sequences to enable multiple > clock gates and assert resets, and to prepare to use dwc3 controller > on the SoC. > > This patch also handles the physical

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called on resume(). > This was the $subject of this

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called on resume(). > This was the $subject of this patch. indeed.

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Roger Quadros writes: >>> In host mode runtime suspend/resume could happen very often with >>> device connected, and resetting h/w on every runtime_resume might not >>> be desired. And PHYs drivers can also support runtime_suspend which >>> would be preferred instead of

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Roger Quadros writes: >>> In host mode runtime suspend/resume could happen very often with >>> device connected, and resetting h/w on every runtime_resume might not >>> be desired. And PHYs drivers can also support runtime_suspend which >>> would be preferred instead of shutting down phy.

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: On 27/09/17 14:19, Manu Gautam wrote: > Driver powers-off PHYs and reinitializes DWC3 core and gadget on > resume. While this works fine for gadget mode but in host > mode there is not re-initialization of host stack. Also,

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: On 27/09/17 14:19, Manu Gautam wrote: > Driver powers-off PHYs and reinitializes DWC3 core and gadget on > resume. While this works fine for gadget mode but in host > mode there is not re-initialization of host stack. Also, resetting > bus as part of

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: - ret = dwc3_core_soft_reset(dwc); + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: - ret = dwc3_core_soft_reset(dwc); + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we can't call

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: >> On 27/09/17 14:19, Manu Gautam wrote: >>> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >>> resume. While this works fine for gadget mode but in host >>> mode there is not re-initialization of host stack. Also, resetting >>>

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Manu Gautam writes: >> On 27/09/17 14:19, Manu Gautam wrote: >>> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >>> resume. While this works fine for gadget mode but in host >>> mode there is not re-initialization of host stack. Also, resetting >>> bus as part of

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Felipe, >>> >>> On 10/01/18 15:11, Roger Quadros wrote: The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Felipe, >>> >>> On 10/01/18 15:11, Roger Quadros wrote: The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system suspend/resume it will result in

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: > Felipe, > > On 10/01/18 15:11, Roger Quadros wrote: >> The USB PHYs should be requested only once during the life cycle of >> this driver. >> >> As dwc3_core_init() is called during system suspend/resume >> it will result in multiple calls to

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: > Felipe, > > On 10/01/18 15:11, Roger Quadros wrote: >> The USB PHYs should be requested only once during the life cycle of >> this driver. >> >> As dwc3_core_init() is called during system suspend/resume >> it will result in multiple calls to dwc3_core_get_phy()

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Roger Quadros writes: > Hi Manu, > > On 27/09/17 14:19, Manu Gautam wrote: >> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >> resume. While this works fine for gadget mode but in host >> mode there is not re-initialization of host stack. Also, resetting >>

Re: [RESEND PATCH 1/3] usb: dwc3: Don't reinitialize core during host bus-suspend/resume

Hi, Roger Quadros writes: > Hi Manu, > > On 27/09/17 14:19, Manu Gautam wrote: >> Driver powers-off PHYs and reinitializes DWC3 core and gadget on >> resume. While this works fine for gadget mode but in host >> mode there is not re-initialization of host stack. Also, resetting >> bus as part of

Re: [usb_add_gadget_udc_release] BUG: KASAN: double-free or invalid-free in (null)

e7: >> slab_free at mm/slub.c:2973 >> (inlined by) kfree at >> mm/slub.c:3899 >> [ 38.605034] usb_add_gadget_udc_release+0x693/0x6ca: >>

Re: [usb_add_gadget_udc_release] BUG: KASAN: double-free or invalid-free in (null)

slab_free at mm/slub.c:2973 >> (inlined by) kfree at >> mm/slub.c:3899 >> [ 38.605034] usb_add_gadget_udc_release+0x693/0x6ca: >> usb_a

Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

QUESTS 8 if you want to be taken seriously, the bare minimum you can do is to use scripts/get_maintainer.pl to help with a proper Cc list: $ scripts/get_maintainer.pl -f drivers/usb/gadget/function/uvc.h Laurent Pinchart <laurent.pinch...@ideasonboard.com> (maintainer:USB WEBCAM GA

Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

the bare minimum you can do is to use scripts/get_maintainer.pl to help with a proper Cc list: $ scripts/get_maintainer.pl -f drivers/usb/gadget/function/uvc.h Laurent Pinchart (maintainer:USB WEBCAM GADGET) Felipe Balbi (maintainer:USB GADGET/PERIPHERAL SUBSYSTEM) Greg Kroah-Hartman (supporter

Re: [PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

Hi, Lipengcheng writes: > In removal requests, it is necessary to make the corresponding trb > disable state (HWO = 1) and dep->queued_requests a corresponding reduction. > It is better to use a alone funtion to disable trb (HWO = 0). this shouldn't be necessary. What

Re: [PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

Hi, Lipengcheng writes: > In removal requests, it is necessary to make the corresponding trb > disable state (HWO = 1) and dep->queued_requests a corresponding reduction. > It is better to use a alone funtion to disable trb (HWO = 0). this shouldn't be necessary. What problem are you facing?

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

Hi, Lipengcheng writes: >> Lipengcheng writes: >> >> > Iso transmission, the current process is that all trb(HWO=1) is handled. >> > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin >> > refill trb, this will produce 0 length

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

Hi, Lipengcheng writes: >> Lipengcheng writes: >> >> > Iso transmission, the current process is that all trb(HWO=1) is handled. >> > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin >> > refill trb, this will produce 0 length package, the patch is to >> > achieve the core

Re: [PATCH] usb:dwc3:fix access poisoned list_head in dwc3_gadget_giveback

Hi, Yu Chen writes: > From: Yu Chen > > Unable to handle kernel paging request at virtual address dead0108 > pgd = fff7a3179000 > [dead0108] *pgd=230e0003, *pud=230e0003, > *pmd= > Internal error:

Re: [PATCH] usb:dwc3:fix access poisoned list_head in dwc3_gadget_giveback

Hi, Yu Chen writes: > From: Yu Chen > > Unable to handle kernel paging request at virtual address dead0108 > pgd = fff7a3179000 > [dead0108] *pgd=230e0003, *pud=230e0003, > *pmd= > Internal error: Oops: 9644 [#1] PREEMPT SMP > Modules

Re: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

Hi, Lipengcheng writes: > Iso transmission, the current process is that all trb(HWO=1) is handled. > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin refill > trb, this will produce 0 length package, the patch is to achieve the core > consumes a trb, and

Re: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

Hi, Lipengcheng writes: > Iso transmission, the current process is that all trb(HWO=1) is handled. > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin refill > trb, this will produce 0 length package, the patch is to achieve the core > consumes a trb, and then the software

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

Hi, Joe Perches <j...@perches.com> writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

Hi, Joe Perches writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi -- balbi

Re: linux-next: Tree for Dec 14 (usb/dwc3)

Hi, Randy Dunlap writes: > On 12/13/2017 11:06 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20171213: >> > > on i386: > > ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3.ko] undefined! > ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3.ko]

Re: linux-next: Tree for Dec 14 (usb/dwc3)

Hi, Randy Dunlap writes: > On 12/13/2017 11:06 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20171213: >> > > on i386: > > ERROR: "__tracepoint_dwc3_writel" [drivers/usb/dwc3/dwc3.ko] undefined! > ERROR: "__tracepoint_dwc3_readl" [drivers/usb/dwc3/dwc3.ko] undefined! > > > > I

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, Douglas Anderson writes: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200 MHz). > >

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, Douglas Anderson writes: > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cause the system to lockup, especially > if the CPU Frequency was at one of the slower operating points (like > 100 MHz / 200 MHz). > > Upon tracing, I found

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

Hi, (please break your lines at 80-characters) Yinbo Zhu writes: >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index >>> 5cb3f6795b0b..071e7cea8cbb 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1106,6 +1106,9 @@

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

Hi, (please break your lines at 80-characters) Yinbo Zhu writes: >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index >>> 5cb3f6795b0b..071e7cea8cbb 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1106,6 +1106,9 @@ static void

Re: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

Hi, Greg Kroah-Hartman writes: > On Fri, Dec 08, 2017 at 05:49:41PM +0800, yinbo@nxp.com wrote: >> From: "yinbo.zhu" >> >> Description: This is a occasional problem where the software > > No need for a "Description:" word. That's just

Re: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

Hi, Greg Kroah-Hartman writes: > On Fri, Dec 08, 2017 at 05:49:41PM +0800, yinbo@nxp.com wrote: >> From: "yinbo.zhu" >> >> Description: This is a occasional problem where the software > > No need for a "Description:" word. That's just assumed here, right? > >> issues an End Transfer

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

26:59 +0800 >> > Chunyan Zhang <zhang.chun...@linaro.org> wrote: >> > >> > > On 17 May 2017 at 16:05, Felipe Balbi <felipe.ba...@linux.intel.com> >> > > wrote: >> > > > That way, users don't need to keep a global static pointe

Re: [PATCH] kernel: trace: pass export pointer as argument to ->write()

Hi, Alexander Shishkin writes: > On Mon, Dec 04, 2017 at 07:09:38AM -0500, Steven Rostedt wrote: >> On Wed, 17 May 2017 22:52:28 -0400 >> Steven Rostedt wrote: >> >> > On Thu, 18 May 2017 10:26:59 +0800 >> > Chunyan Zhang wrote: >> &g

Re: [PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

as hrtimer mode. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> > Cc: Felipe Balbi <ba...@kernel.org> > Cc: linux-...@vger.kernel.org This doesn't compile, so I'm assuming it depends on previ

Re: [PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

> Signed-off-by: Anna-Maria Gleixner > Cc: Felipe Balbi > Cc: linux-...@vger.kernel.org This doesn't compile, so I'm assuming it depends on previous patches on this series? In that case: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

44: dwc3_event: event (0901): > Erratic Error [U0] > > Signed-off-by: Roger Quadros <rog...@ti.com> FWIW: Acked-by: Felipe Balbi <felipe.balbi@linux/intel.com> I'm taking the dwc3 counterpart to v4.16 -- balbi signature.asc Description: PGP signature

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

(0901): > Erratic Error [U0] > > Signed-off-by: Roger Quadros FWIW: Acked-by: Felipe Balbi I'm taking the dwc3 counterpart to v4.16 -- balbi signature.asc Description: PGP signature

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

Hi, Ruslan Bilovol writes: > On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol > wrote: >> Hi, >> >> This patch adds USB Audio Device Class 3.0 [1] function >> support to gadget subsystem. >> I didn't add UAC3 support to legacy gadget as it

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

Hi, Ruslan Bilovol writes: > On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol > wrote: >> Hi, >> >> This patch adds USB Audio Device Class 3.0 [1] function >> support to gadget subsystem. >> I didn't add UAC3 support to legacy gadget as it will >> make preprocessor configuration too complex

Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

Hi, Lu Baolu writes: > The kernel FIFO implementation, kfifo, provides interfaces to manipulate > a first-in-first-out circular buffer. Use kfifo instead of the homemade > one to make the code more concise and readable. > > Signed-off-by: Lu Baolu

Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

Hi, Lu Baolu writes: > The kernel FIFO implementation, kfifo, provides interfaces to manipulate > a first-in-first-out circular buffer. Use kfifo instead of the homemade > one to make the code more concise and readable. > > Signed-off-by: Lu Baolu Thanks :-) Can you give a little description

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping <j...@metanate.com> writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 --

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 -- > Subject: [PA

RE: [PATCH] usb: dwc3: Enable the USB snooping

Hi, Ran Wang writes: >> Ran Wang writes: >> > Add support for USB3 snooping by asserting bits in register >> > DWC3_GSBUSCFG0 for data and descriptor. >> >> we know *how* to enable a feature :-) It's always the same, you fiddle with >> some registers

RE: [PATCH] usb: dwc3: Enable the USB snooping

Hi, Ran Wang writes: >> Ran Wang writes: >> > Add support for USB3 snooping by asserting bits in register >> > DWC3_GSBUSCFG0 for data and descriptor. >> >> we know *how* to enable a feature :-) It's always the same, you fiddle with >> some registers and it works. What you failed to tell us

Re: [PATCH] usb: dwc3: Enable the USB snooping

Hi, Ran Wang writes: > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor. we know *how* to enable a feature :-) It's always the same, you fiddle with some registers and it works. What you failed to tell us is: a) WHY do

Re: [PATCH] usb: dwc3: Enable the USB snooping

Hi, Ran Wang writes: > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor. we know *how* to enable a feature :-) It's always the same, you fiddle with some registers and it works. What you failed to tell us is: a) WHY do you need this? b) WHY

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Mathias Nyman writes: >> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >> +{ >> +db->buf_buf = kzalloc(size, GFP_KERNEL); >> +if (!db->buf_buf) >> +return -ENOMEM; >> + >> +db->buf_size = size; >> +db->buf_put =

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Mathias Nyman writes: >> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >> +{ >> +db->buf_buf = kzalloc(size, GFP_KERNEL); >> +if (!db->buf_buf) >> +return -ENOMEM; >> + >> +db->buf_size = size; >> +db->buf_put = db->buf_buf; >> +db->buf_get

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping <j...@metanate.com> writes: > On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > >> John Keeping <j...@metanate.com> writes: >> > This check has gone through several incompatible variations in commits >> > 53642399aa71 ("

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping writes: > On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > >> John Keeping writes: >> > This check has gone through several incompatible variations in commits >> > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on r

Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

Hi, abhij...@vger.kernel.org, ku...@vger.kernel.org writes: these emails don't exist. Fix your email client. > From: abhijeet kumar capitalize names > Runtime resume USB device in order to ensure that PM framework > knows that the we might be using the device in a

Re: [PATCH] USB :core :Prevent USB devices to autosuspend while setting interface

Hi, abhij...@vger.kernel.org, ku...@vger.kernel.org writes: these emails don't exist. Fix your email client. > From: abhijeet kumar capitalize names > Runtime resume USB device in order to ensure that PM framework > knows that the we might be using the device in a short time and doesn't >

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping writes: > This check has gone through several incompatible variations in commits > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat > descriptor validation") and

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

Hi, John Keeping writes: > This check has gone through several incompatible variations in commits > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat > descriptor validation") and 3ba534df815f ("Revert "usb:

Re: [PATCH] usb: gadget: f_fs: Fix use-after-free in ffs_free_inst

t; Cc: sta...@vger.kernel.org >> Signed-off-by: Andrew Gabbasov <andrew_gabba...@mentor.com> >> --- >> drivers/usb/gadget/function/f_fs.c | 1 + >> 1 file changed, 1 insertion(+) > > Felipe, want me to take this directly? If you can still squeeze it into the merge window, sure: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> Thanks -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: f_fs: Fix use-after-free in ffs_free_inst

nel.org >> Signed-off-by: Andrew Gabbasov >> --- >> drivers/usb/gadget/function/f_fs.c | 1 + >> 1 file changed, 1 insertion(+) > > Felipe, want me to take this directly? If you can still squeeze it into the merge window, sure: Acked-by: Felipe Balbi Thanks -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 3/3] usb: dwc3: Enable USB 3.0 phy driver

Hi, Ran Wang writes: > Adds entry point at dwc3 core init function to enable > USB 3.0 PHY driver. > > Signed-off-by: Ran Wang > --- > Change in v2: > - New file > > drivers/usb/dwc3/core.c | 15 +++ > 1 file changed, 15 insertions(+)

Re: [PATCH v2 3/3] usb: dwc3: Enable USB 3.0 phy driver

Hi, Ran Wang writes: > Adds entry point at dwc3 core init function to enable > USB 3.0 PHY driver. > > Signed-off-by: Ran Wang > --- > Change in v2: > - New file > > drivers/usb/dwc3/core.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the Debug Capability(DbC). It >> >>> > >> >> > presents a

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

s Gleixner <t...@linutronix.de> > Cc: Kate Stewart <kstew...@linuxfoundation.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

> Cc: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again

> > Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann <a...@arndb.de> oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again

a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi -- balbi

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> >> > can be implemented with the Debug Capability(DbC). It presents a debug >> >> > device

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> >> > can be implemented with the Debug Capability(DbC). It presents a debug >> >> > device which is fully compliant with the USB framework and

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> > can be implemented with the Debug Capability(DbC). It presents a debug >> > device which is fully compliant with the USB framework and provides the >> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> > can be implemented with the Debug Capability(DbC). It presents a debug >> > device which is fully compliant with the USB framework and provides the >> > equivalent of a very high

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

Roger Quadros writes: > UDC core calls .udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more or less than that > supported by the dwc3 controller driver. > > Select the lesser of the 2

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

Roger Quadros writes: > UDC core calls .udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more or less than that > supported by the dwc3 controller driver. > > Select the lesser of the 2 speeds so both are

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Doug Anderson <diand...@chromium.org> writes: > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <ba...@kernel.org> wrote: >> >> Hi, >> >> Doug Anderson <diand...@chromium.org> writes: >>> Hi, >>> >>> On Sat, Oct 2

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Doug Anderson writes: > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: >> >> Hi, >> >> Doug Anderson writes: >>> Hi, >>> >>> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >>> wrote: >>>> Hi Doug

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, Doug Anderson writes: > Hi, > > On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: >> Hi Doug, >> >> [add Felipe since this should go through his tree] > > Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past No problems

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

Hi, Doug Anderson writes: > Hi, > > On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren wrote: >> Hi Doug, >> >> [add Felipe since this should go through his tree] > > Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past No problems :-) > but for some reason get_maintainer didn't

Re: [PATCH] usb: gadget: composite: mark expected switch fall-throughs

"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Felipe B

Re: [PATCH] usb: gadget: composite: mark expected switch fall-throughs

"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] usb: gadget: udc: dummy_hcd: mark expected switch fall-throughs

"Gustavo A. R. Silva" <garsi...@embeddedor.com> writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Felipe B

Re: [PATCH] usb: gadget: udc: dummy_hcd: mark expected switch fall-throughs

"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 3/3] usb: phy: remove phy-qcom-8x16-usb.c

Alex Elder writes: > No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver > support any more, so remove the code. > > Suggested-by: Stephen Boyd > Signed-off-by: Alex Elder > Acked-by: Bjorn Andersson

Re: [PATCH 3/3] usb: phy: remove phy-qcom-8x16-usb.c

Alex Elder writes: > No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver > support any more, so remove the code. > > Suggested-by: Stephen Boyd > Signed-off-by: Alex Elder > Acked-by: Bjorn Andersson > Acked-by: Andy Gross Kconfig? -- balbi signature.asc Description: PGP

Re: [PATCH] usb: gadget: f_phonet: mark expected switch fall-throughs

off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Greg, I have already sent you my pull request. If you want, I can prepare a part 2, otherwise: Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

<    1   2   3   4   5   6   7   8   9   10   >