Re: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-01 Thread Felipe Balbi
Hi, On Mon, Oct 01, 2012 at 01:47:17PM +0300, Andy Shevchenko wrote: On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote: On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote: From: Heikki Krogerus heikki.kroge...@linux.intel.com commit log would be great. Will do

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Felipe Balbi
Hi, coming late to the discussion, so bear with me On Tue, Oct 02, 2012 at 01:38:56PM +0100, Mark Brown wrote: This means mfd framework does not have an API to create a device from dt data or so do I think since of_platform_populate() is used. Thats why I suggested the idea of extending

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread Felipe Balbi
Hi, On Tue, Oct 02, 2012 at 01:58:20PM +0100, Mark Brown wrote: On Tue, Oct 02, 2012 at 03:43:22PM +0300, Felipe Balbi wrote: BTW, OTOH writing all children into the DT actually describes the HW, no ? And depending on the device I feel it'd be better to write that Well, it depends

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 06:10:48PM +0530, Vivek Gautam wrote: Hi Doug, Sorry!! for the delayed response. On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson diand...@chromium.org wrote: Vivek, I don't really have a good 1 foot view about how all of the USB bits fit together,

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 07:13:55PM +0530, Vivek Gautam wrote: On Thu, Jan 10, 2013 at 6:32 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Dec 24, 2012 at 07:28:33PM +0530, Vivek Gautam wrote: DWC3 controller curretly depends on CONFIG_USB and CONFIG_USB_GADGET. Some hardware may

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-13 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 07:58:23PM +0530, Vivek Gautam wrote: Hi, On Fri, Jan 11, 2013 at 7:29 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Jan 11, 2013 at 07:13:55PM +0530, Vivek Gautam wrote: On Thu, Jan 10, 2013 at 6:32 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: Hi Arnd, On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an

Re: [PATCH 2/2] ARM: dts: omap: Add omap-usb2 dt data

2013-01-10 Thread Felipe Balbi
file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp. Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com This patch is also missing in mainline :-( Well, in that case this was done on purpose

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-10 Thread Felipe Balbi
Hi, On Mon, Dec 24, 2012 at 07:28:33PM +0530, Vivek Gautam wrote: DWC3 controller curretly depends on CONFIG_USB and CONFIG_USB_GADGET. Some hardware may like to use only host feature on dwc3. So, removing the dependency of USB_DWC3 on USB_GADGET and further modulating the dwc3 core to enable

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote: diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 6d05085..111f454 100644 --- a/drivers/usb/phy/phy-msm-usb.c +++ b/drivers/usb/phy/phy-msm-usb.c @@ -64,8 +64,8 @@ static int

Re: [PATCH 01/16] usb: musb: dsps: init / shutdown the phy

2013-07-25 Thread Felipe Balbi
On Mon, Jul 22, 2013 at 08:09:52PM +0200, Sebastian Andrzej Siewior wrote: If the init / shutdown function of the phy moves out of dsps into the phy driver, then dsps needs to call the callbacks of the phy driver to ensure that this happens. Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH 02/16] usb: phy: phy-nop: add support for am335x PHY

2013-07-25 Thread Felipe Balbi
On Mon, Jul 22, 2013 at 08:09:53PM +0200, Sebastian Andrzej Siewior wrote: The am335x PHY code is well hidden in multiple places. The glue layer uses the nop and does up/down in the background. This patch copies the power on / power off part out of dsps so it can be removed later in dsps. At

Re: [PATCH 02/16] usb: phy: phy-nop: add support for am335x PHY

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 04:45:29PM +0200, Sebastian Andrzej Siewior wrote: * Felipe Balbi | 2013-07-25 17:33:30 [+0300]: On Mon, Jul 22, 2013 at 08:09:53PM +0200, Sebastian Andrzej Siewior wrote: right, I replied to the wrong series, please add a patch renaming file and functions to phy

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 05:16:53PM +0200, Sebastian Andrzej Siewior wrote: On 07/25/2013 05:12 PM, Bin Liu wrote: Sebastian, Hi Bin, Is it really there or was it never there and it has been added to TRM by accident? The EOI register IS in the USB subsystem of AM33xx, but the SoC

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 10:28:37AM -0500, Bin Liu wrote: Sebastian, On Thu, Jul 25, 2013 at 10:16 AM, Sebastian Andrzej Siewior bige...@linutronix.de wrote: On 07/25/2013 05:12 PM, Bin Liu wrote: Sebastian, Hi Bin, Is it really there or was it never there and it has been

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] I switched from ? : to !! mostly to save from

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: This resolves the following valid build warning: drivers/usb/gadget/at91_udc.c:1685:34

Re: [PATCH 1/6] usb: phy-nop: Use RESET Controller for managing the reset line

2013-07-25 Thread Felipe Balbi
On Thu, Jul 18, 2013 at 11:53:05AM +0300, Roger Quadros wrote: Till now we were modelling the RESET line as a voltage regulator and using the regulator framework to manage it. [1] introduces a GPIO based reset controller driver. We use that to manage the PHY reset line, at least for DT

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-25 Thread Felipe Balbi
Hi, On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote: mv_u3d_nuke() expects to be calles with ep-u3d-lock held, because mv_u3d_done() does. But mv_u3d_ep_disable() calls it without lock that can lead to unpleasant consequences. Found by Linux Driver Verification project

Re: [PATCH v2 0/9] Tegra USB cleanup series

2013-07-25 Thread Felipe Balbi
Hi, On Mon, Jul 15, 2013 at 05:28:56PM -0600, Stephen Warren wrote: On 07/15/2013 01:53 PM, Tuomas Tynkkynen wrote: Hi, Here's a V2 of the few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 09:38:08PM +0300, Tuomas Tynkkynen wrote: Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 10:11:16PM +0300, Tuomas Tynkkynen wrote: Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com Reviewed-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 607bef8..50c833f 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -384,21 +384,6 @@ static int dwc3_probe(struct platform_device

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 09:48:26AM +0300, Ivan T. Ivanov wrote: Also, this is not *modifying* what was passed, just skipping the xHCI address space so we don't request_mem_region() an area we won't really handle and prevent xhci-hcd.ko from probing. Hmm? platform_get_resource()

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-26 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: That's what the code does today, and I wasn't trying to second-guess their decisions

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-26 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 03:31:34PM +0300, Ivan T. Ivanov wrote: Hi Felipe, On Thu, 2013-07-25 at 16:43 +0300, Ivan T. Ivanov wrote: On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-26 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 09:23:35AM -0700, Olof Johansson wrote: On Fri, Jul 26, 2013 at 2:54 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 01:59:51PM -0700, Olof Johansson wrote: On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi ba...@ti.com wrote: On Thu, Jul 25, 2013 at 09:18

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-26 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 06:44:23PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, July 26, 2013 2:54 AM Also, this is not *modifying* what was passed, just skipping the xHCI address space so we don't request_mem_region() an area we won't

Re: [PATCH v2 3/3] Input: omap-keypad: Set irq to level instead of edge

2013-07-27 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 08:09:06PM +0300, Illia Smyrnov wrote: From: Axel Haslam axelhas...@ti.com Set mpu irq to level instead of edge, since if mpu is in low power an edge detection may be lost if the event is a wkup event. Signed-off-by: Axel Haslam axelhas...@ti.com

Re: [PATCH 1/4] usb: phy: rename nop_usb_xceiv = usb_phy_gen_xceiv

2013-07-29 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 10:15:54PM +0200, Sebastian Andrzej Siewior wrote: The nop driver isn't a do-nothing-stub but supports a couple functions like clock on/off or is able to use a voltage regulator. This patch simply renames the driver to generic since it is easy possible to extend it by a

Re: [PATCH 2/4] usb: phy: add am335x pieces to generic phy

2013-07-29 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 10:15:55PM +0200, Sebastian Andrzej Siewior wrote: This patch copies the phy support bits from dsps into the generic phy driver. Most code can be re-used except for the on/off. The additional am335x can be removed once we have a phy driver that does more than this.

Re: [PATCH v2 1/6] usb: phy: msm: Move mach depndend code to platform data

2013-07-29 Thread Felipe Balbi
: David Brown dav...@codeaurora.org Cc: Daniel Walker dwal...@fifo99.com Cc: Bryan Huntsman bry...@codeaurora.org Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux

Re: [PATCH v2 3/6] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote: motg-irq = platform_get_irq(pdev, 0); - if (!motg-irq) { + if (motg-irq 0) { looks like this particular hunk isn't part of $subject. -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-29 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote: On 07/25/2013 09:30 PM, Felipe Balbi wrote: On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote: mv_u3d_nuke() expects to be calles with ep-u3d-lock held, because mv_u3d_done() does

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-29 Thread Felipe Balbi
On Mon, Jul 29, 2013 at 05:15:58PM +0400, Alexey Khoroshilov wrote: On 07/29/2013 04:52 PM, Felipe Balbi wrote: Hi, On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote: On 07/25/2013 09:30 PM, Felipe Balbi wrote: On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-29 Thread Felipe Balbi
On Mon, Jul 29, 2013 at 04:52:12PM +0300, Felipe Balbi wrote: On Mon, Jul 29, 2013 at 05:15:58PM +0400, Alexey Khoroshilov wrote: On 07/29/2013 04:52 PM, Felipe Balbi wrote: Hi, On Fri, Jul 26, 2013 at 07:26:05PM +0400, Alexey Khoroshilov wrote: On 07/25/2013 09:30 PM, Felipe Balbi

Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-07-29 Thread Felipe Balbi
Hi, On Fri, Jul 26, 2013 at 02:33:38PM +0530, Kishon Vijay Abraham I wrote: Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the device name of the controller had *.auto* in it. Since with

Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote: Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the device name of the controller had *.auto* in it.

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 07:45:09PM +0300, Illia Smyrnov wrote: Enable/disable IRQ wake in suspend/resume handlers to make the keypad wakeup capable. Signed-off-by: Illia Smyrnov illia.smyr...@ti.com --- drivers/input/keyboard/omap4-keypad.c | 43 +

Re: [PATCH v3 2/3] Input: omap-keypad: errata i689: Correct debounce time

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 07:45:10PM +0300, Illia Smyrnov wrote: From: Axel Haslam axelhas...@ti.com Set debounce time value to 12ms to workaround the errata. ERRATA DESCRIPTION: When a key is released for a time shorter than the debounce time, in-between 2 key press (KP1 and KP2), the

Re: [PATCH v3 3/3] Input: omap-keypad: Setup irq type from DT

2013-07-29 Thread Felipe Balbi
On Mon, Jul 29, 2013 at 07:45:11PM +0300, Illia Smyrnov wrote: OMAP4 is DT only, so read the keypad IRQ type from DT instead hardcoding it in driver. Cc: Felipe Balbi ba...@ti.com Signed-off-by: Illia Smyrnov illia.smyr...@ti.com Looks good to my eyes: Reviewed-by: Felipe Balbi ba

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 11:59:45AM -0700, Dmitry Torokhov wrote: @@ -439,12 +444,50 @@ static const struct of_device_id omap_keypad_dt_match[] = { MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); #endif +#ifdef CONFIG_PM_SLEEP +static int omap4_keypad_suspend(struct

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 12:59:23PM -0700, Dmitry Torokhov wrote: @@ -439,12 +444,50 @@ static const struct of_device_id omap_keypad_dt_match[] = { MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); #endif +#ifdef CONFIG_PM_SLEEP +static int

Re: [PATCH v2] usb: phy-samsung-usb: Simplify PMU register handling

2013-07-29 Thread Felipe Balbi
On Mon, Jul 29, 2013 at 02:17:56PM -0700, Julius Werner wrote: This patch simplifies the way the phy-samsung-usb code finds the correct power management register to enable PHY clock gating. Previously, the code would calculate the register address from a device tree supplied base address and

Re: linux-next: build failure after merge of the usb-gadget tree

2013-07-29 Thread Felipe Balbi
Hi, On Tue, Jul 30, 2013 at 02:34:27PM +1000, Stephen Rothwell wrote: Hi Felipe, After merging the usb-gadget tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/usb/phy/of.c:32:24: error: redefinition of 'of_usb_get_phy_mode' enum usb_phy_interface

Re: linux-next: manual merge of the usb-gadget tree with the usb.current tree

2013-07-29 Thread Felipe Balbi
Hi, On Tue, Jul 30, 2013 at 02:08:10PM +1000, Stephen Rothwell wrote: Hi Felipe, Today's linux-next merge of the usb-gadget tree got a conflict in drivers/usb/gadget/udc-core.c between commit 1894870eb424 (usb: gadget: udc-core: fix the typo of udc state attribute) from the usb.current tree

Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-07-30 Thread Felipe Balbi
Hi, On Tue, Jul 30, 2013 at 10:44:48AM +0530, Kishon Vijay Abraham I wrote: On Mon, Jul 29, 2013 at 08:59:26PM +0530, Kishon Vijay Abraham I wrote: Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating MUSB core device. So in usb_bind_phy (binds the controller

Re: [PATCH 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-07-30 Thread Felipe Balbi
Hi, On Tue, Jul 30, 2013 at 11:41:23AM +0530, Kishon Vijay Abraham I wrote: diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c index 244d8a5..17bb076 100644 --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@

Re: linux-next: manual merge of the arm-soc tree with the usb tree

2013-08-27 Thread Felipe Balbi
Greg they were in Felipe's tree for a while. To be exact, last .dts change via USB was: Author: Sebastian Andrzej Siewior bige...@linutronix.de AuthorDate: Thu Jun 20 12:13:04 2013 +0200 Commit: Felipe Balbi ba...@ti.com CommitDate: Fri Aug 9 17:40:16 2013 +0300

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-08-27 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote: On 12 July 2013 12:27, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: Hi Felipe, This is intended to pull down a reset signal line, not to switch power to the device

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-27 Thread Felipe Balbi
On Wed, Aug 14, 2013 at 12:28:17PM +0300, Ivan T. Ivanov wrote: Hi, On Mon, 2013-08-12 at 13:24 -0500, Felipe Balbi wrote: On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote: Hi, On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: Hi, On Tue, Aug 06

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 13, 2013 at 02:34:10PM +0100, Mark Rutland wrote: On Mon, Aug 12, 2013 at 07:05:53PM +0100, Felipe Balbi wrote: On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote: On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote: On Fri, Aug 09, 2013 at 04:40:32PM +0100

Re: [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers

2013-08-27 Thread Felipe Balbi
On Thu, Aug 15, 2013 at 01:40:01AM +0300, Philippe De Swert wrote: Hi, On 12/08/13 21:08, Felipe Balbi wrote: On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote: Some bad gadget drivers do not check the return status of usb_add_config. fix the gadget driver As stated

Re: [PATCH v11 0/8] PHY framework

2013-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-27 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 09:24:01AM +0800, Peter Chen wrote: On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' Signed-off-by:

Re: linux-next: manual merge of the arm-soc tree with the usb tree

2013-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 27, 2013 at 12:30:21PM -0700, Greg KH wrote: On Tue, Aug 27, 2013 at 01:37:32PM -0500, Felipe Balbi wrote: Hi, On Tue, Aug 27, 2013 at 10:37:32AM -0700, Greg KH wrote: On Tue, Aug 27, 2013 at 04:13:23PM +0200, Sebastian Andrzej Siewior wrote: On 08/27/2013 04:05 PM

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-27 Thread Felipe Balbi
, On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: I think they are SNPS DesignWare

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-27 Thread Felipe Balbi
Hi, On Thu, Aug 22, 2013 at 07:10:04PM +, Graham Williams wrote: The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham gwi...@broadcom.com complains about being a malformed

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Felipe Balbi
On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Felipe Balbi
nodes in the core instead of doing this manually in each driver. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang w...@the-dreams.de for i2c-omap.c: Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-20 Thread Felipe Balbi
Hi, On Mon, Aug 19, 2013 at 10:58:09AM +0530, Kishon Vijay Abraham I wrote: So maybe let's stop solving an already solved problem and just state that you need to explicitly assign device ID to use this framework? Felipe, Can we have it the way I had in my v10 patch series till we find

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: Hi, On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: Hi, On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-22 Thread Felipe Balbi
, 2013, at 9:54 AM, Ivan T. Ivanov wrote: Hi, On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: Hi, On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: Hi, On Tue, Aug 20, 2013 at 04:32:23PM +0300

Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)

2013-08-13 Thread Felipe Balbi
Hi, On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':

Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)

2013-08-13 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote: Hi, On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote: Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/usb/phy/phy-am335x-control.c

Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)

2013-08-13 Thread Felipe Balbi
On Tue, Aug 13, 2013 at 09:52:53PM +0200, Sedat Dilek wrote: On Tue, Aug 13, 2013 at 9:51 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote: Hi, On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote: Hi all, After merging

Re: [PATCH 2/2] usb: gadget: ffs: add ACM + FunctionFS configuration

2013-08-16 Thread Felipe Balbi
On Fri, Aug 16, 2013 at 11:27:48AM -0400, Matt Porter wrote: Adds an additional configuration to g_ffs to allow for CDC ACM support in conjuction with FunctionFS. A module parameter is added to allow for multiple ACM ports to be instantiated. Signed-off-by: Matt Porter

Re: [PATCH 0/5] Add phy support for AM335X platform using Generic PHy framework

2013-07-09 Thread Felipe Balbi
On Wed, Jul 10, 2013 at 10:26:25AM +0530, George Cherian wrote: On 7/9/2013 5:05 PM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 09 July 2013 11:10 AM, George Cherian wrote: On 7/9/2013 1:14 AM, Sebastian Andrzej Siewior wrote: On 07/08/2013 12:43 PM, George Cherian wrote: This patch

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-09 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 05:34:15PM -0700, Julius Werner wrote: This patch adds support for a new 'samsung,hsic-reset-gpio' in the device tree, which will be interpreted as an active-low reset pin during PHY initialization when it exists. Useful for intergrated HSIC devices like an SMSC 3503

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-12 Thread Felipe Balbi
Hi, On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: Hi Felipe, This is intended to pull down a reset signal line, not to switch power to the device. I could implement that with the regulator framework too, but I think that would just be confusing and harder to understand

Re: [PATCH 2/2] serial: omap: fix wrong context restoration on init

2013-07-12 Thread Felipe Balbi
it by default. [1] http://www.spinics.net/lists/arm-kernel/msg256828.html [2] http://www.spinics.net/lists/arm-kernel/msg258062.html [3] http://www.spinics.net/lists/arm-kernel/msg258040.html CC: Tony Lindgren t...@atomide.com CC: Rajendra Nayak rna...@ti.com CC: Felipe Balbi ba...@ti.com CC

Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

2013-07-15 Thread Felipe Balbi
On Wed, Jul 10, 2013 at 11:45:16PM +0200, Geert Uytterhoeven wrote: When builtin (CONFIG_USB_FOTG210_UDC=y): LD drivers/usb/gadget/built-in.o WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variable fotg210_driver to the function

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-07-15 Thread Felipe Balbi
Acked-by: Felipe Balbi ba...@ti.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- This patch should be applied after all of the extcon patchset will be applied because this patch has dependency of extcon patch related to DT. http://goo.gl/Tu3qW Changes from v5: * rebased to 3.11-rc1

Re: [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-18 Thread Felipe Balbi
On Thu, Jun 13, 2013 at 02:13:59PM +0530, Kishon Vijay Abraham I wrote: Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com Reviewed-by: Felipe Balbi ba

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-18 Thread Felipe Balbi
Hi, On Mon, Jun 17, 2013 at 12:16:35PM +0200, Sylwester Nawrocki wrote: I have already used this API for our MIPI CSI-2/DSIM DPHYs driver, the RFC patch series can be found at [1]. Thanks, Sylwester [1] http://www.spinics.net/lists/arm-kernel/msg251666.html one comment to that series:

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:19:03PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote: Hi, On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:26:23PM +0530, Kishon Vijay Abraham I wrote: On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev) otg-start_srp = omap_usb_start_srp;

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: In order for controllers to get PHY in case of non dt boot, the phy binding information

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 04:43:44PM +0530, Kishon Vijay Abraham I wrote: On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: In order

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 08:25:00PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 18 June 2013 06:05 PM, Felipe Balbi wrote: Hi, On Tue, Jun 18, 2013 at 04:43:44PM +0530, Kishon Vijay Abraham I wrote: On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 10:53:26AM -0400, Alan Stern wrote: If the controllers don't want HCD core to manage the PHY they can just set it to some error code. they shouldn't have the choice, otherwise it'll be a bit of a PITA to maintain the code. ehci core tries to grab the

Re: linux-next: Tree for Jun 18 usb/chipidea)

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 11:52:36AM -0700, Randy Dunlap wrote: On 06/18/13 00:30, Stephen Rothwell wrote: Hi all, Changes since 20130617: on i386: # CONFIG_USB_PHY is not set drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 09:35:38PM +0300, Grygorii Strashko wrote: On 06/07/2013 11:51 PM, Kevin Hilman wrote: Grygorii Strashko grygorii.stras...@ti.com writes: From: Kevin Hilman khil...@deeprootsystems.com Currently, runtime PM is used to keep the device enabled only during active

Re: [PATCH 2/5] i2c: omap: add runtime check in isr to be sure that i2c is enabled

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:42:25PM +0300, Grygorii Strashko wrote: Hi Felipe, On 06/07/2013 10:02 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:05PM +0300, Grygorii Strashko wrote: Add runtime check at the beginning of omap_i2c_isr/omap_i2c_isr_thread to be sure that i2c

Re: [PATCH 3/5] i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg()

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:43:04PM +0300, Grygorii Strashko wrote: Hi Felipe, On 06/07/2013 10:05 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote: ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be Have you seen

Re: [PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:43:17PM +0300, Grygorii Strashko wrote: Hi Felipe, On 06/07/2013 10:07 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote: The omap_i2c_isr() does the irq check and schedules threaded handler if any of enabled IRQs

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 01:01:28PM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: [...] If you have 200 pm_runtime_get() followed by 200 pm_runtime_put() (put is called only after 200 gets, no put-get ping-pong), your -runtime_resume() gets called once, your

Re: [RFC PATCH 1/6] mfd: omap-usb-host: move initialization to module_init()

2013-06-20 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 05:05:48PM +0300, Roger Quadros wrote: We no longer need to be initialized in any particular order so move driver initialization to the standard place i.e. module_init() CC: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Roger Quadros rog...@ti.com ---

Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend

2013-06-20 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 05:05:51PM +0300, Roger Quadros wrote: Runtime suspend the controller during bus suspend and resume it during bus resume. This will ensure that the USB Host power domain enters lower power state and does not prevent the SoC from endering deeper sleep states.

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-20 Thread Felipe Balbi
Hi, On Thu, Jun 20, 2013 at 08:53:05AM +0800, Chao Xie wrote: @@ -2674,6 +2693,9 @@ void usb_remove_hcd(struct usb_hcd *hcd) free_irq(hcd-irq, hcd); } + if (hcd-phy) + usb_phy_shutdown(hcd-phy); + usb_put_dev(hcd-self.root_hub);

Re: v3.11-rc1 USB regressions

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 12:30:00PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 16 July 2013 12:03 PM, Daniel Mack wrote: Hi Aaro, On 16.07.2013 00:56, Aaro Koskinen wrote: Hi, I think USB tree introduced regressions in v3.11-rc1, at least for some OMAP devices using legacy

Re: v3.11-rc1 USB regressions

2013-07-16 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 11:08:36AM +0300, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 12:30:00PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 16 July 2013 12:03 PM, Daniel Mack wrote: Hi Aaro, On 16.07.2013 00:56, Aaro Koskinen wrote: Hi, I think USB tree introduced

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK. The bus becomes _unusable for other clients_.

Re: [PATCH 3/4] pinctrl: Add support for additional dynamic states

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 02:05:36AM -0700, Tony Lindgren wrote: +int pinctrl_check_dynamic(struct device *dev, struct pinctrl_state *st1, + struct pinctrl_state *st2) +{ + struct pinctrl_setting *s1, *s2; + + list_for_each_entry(s1, st1-settings, node) { +

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 05:33:47PM +0800, Hein Tibosch wrote: On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 02:01:11PM +0300, Grygorii Strashko wrote: On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK. The bus becomes _unusable for other clients_. While

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Felipe Balbi
Hi, On Tue, Jul 16, 2013 at 02:01:33PM +0200, Federico Vaga wrote: Hello, I have an x86 board made by STMicroelectronics (STA2X11) with the Synopsis USB-OTG DesignWare 2 on it and connected through the PCI-e bus. I know that there are two drivers for the same controller: (host)

Re: DWC2 and/or S3C-HSOTG for STA2X11 board

2013-07-16 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:27:43PM +0200, Federico Vaga wrote: Thank you Felipe [add CC Giancarlo from ST] On Tuesday 16 July 2013 15:04:25 Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 02:01:33PM +0200, Federico Vaga wrote: Hello, I have an x86 board made

<    3   4   5   6   7   8   9   10   11   12   >