Re: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically

On Sun, 30 Jun 2013, Geert Uytterhoeven wrote: > +static void __init alloc_msg_queue(int iop_num) > +{ > + iop_send_queue[iop_num] = > + kzalloc(NUM_IOP_CHAN * sizeof(**iop_send_queue), GFP_KERNEL); > + iop_listeners[iop_num] = > + kzalloc(NUM_IOP_CHAN * sizeof(**i

Re: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically

On Sun, 30 Jun 2013, Brad Boyer wrote: > On Sun, Jun 30, 2013 at 12:02:22PM +0200, Geert Uytterhoeven wrote: > > > > if (iop_scc_present) { > > printk("IOP: detected SCC IOP at %p\n", iop_base[IOP_NUM_SCC]); > > + alloc_msg_queue(IOP_NUM_SCC); > > Technically, this is

Re: [PATCH] m68k/mac: Fix comment about iop_*_present flags setup timing

On Sun, 30 Jun 2013, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > arch/m68k/mac/iop.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c > index 7d8d461..8a4c446 100644 > --- a/arch/m68k/mac/iop.c >

Re: [PATCH] Make m68k cross compile like every other architecture.

On Thu, 11 Oct 2007, Geert Uytterhoeven wrote: > > Reading the patch in that link, recent cross compilers from _where_? > > Buildroot? Cross-tools? Gentoo embedded? Cross Linux From Scratch? > > My Firmware Linux project? > > > > You assume they all use the same name, yet your patch chang

[PATCH] Re: [PATCH] Jazzsonic driver updates

looked, the SONIC code in the MIPS repo didn't agree with the SONIC code in the m68k repo. But, it shouldn't be difficult to make macsonic and jazzsonic work with the same core driver code again. Besides, we already have two SONIC drivers in the tree, seperating jazzsonic and macs

Re: [PATCH] Jazzsonic driver updates

On Wed, 23 Mar 2005, Ralf Baechle wrote: > On Tue, Mar 22, 2005 at 06:13:17PM +0100, Geert Uytterhoeven wrote: > > > On Fri, 28 Jan 2005, Linux Kernel Mailing List wrote: > > > ChangeSet 1.1986, 2005/01/28 00:12:28-05:00, [EMAIL PROTECTED] > > > > > > [PATCH] Jazzsonic driver updates > > >

Re: [patch 10/10] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

On Mon, 13 Aug 2007, Michael Schmitz wrote: > > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > > > m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible > > With buttons emulation being available via uinput event devices, do we > still need the kernel mouse button emulation? At

Re: [PATCH] Make m68k cross compile like every other architecture.

> > If your cross-compiler is called differently than the default on in > arch/*/Makefile, Part of the problem is that there is no compelling default. The name of the cross-compiler can vary depending on the chosen executable prefix or the chosen target tuple. Let's say I create new cross t

Re: stuff ready to be deleted?

On Tue, 29 May 2007, Geert Uytterhoeven wrote: > On Mon, 28 May 2007, Robert P. J. Day wrote: > > i'm trying to keep track of kernel janitor projects that involve > > removing dead content from the tree: > > > > http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List > > > > curre

Re: [PATCH] spelling fixes: arch/m68knommu/

On Fri, 11 May 2007, Simon Arlott wrote: > - * Local routines to interrcept the standard I/O and vector handling > - * code. Don't include this 'till now - initialization code above needs > + * Local routines to intercept the standard I/O and vector handling > + * code. Don't include thi

Re: [PATCH] spelling fixes: arch/m68knommu/

On Sat, 12 May 2007, Simon Arlott wrote: > On 12/05/07 02:03, Finn Thain wrote: > > > > On Fri, 11 May 2007, Simon Arlott wrote: > > > > > - * Local routines to interrcept the standard I/O and vector > > > handling > > > - * cod

Re: [PATCH] spelling fixes: arch/m68knommu/

On Sat, 12 May 2007, Kolbj??rn Barmen wrote: > On Sat, 12 May 2007, Finn Thain wrote: > > > To answer your question, I find it easier to parse the original idiom, > > "'til now". Your corruption, "until now", loses information available to >

Re: [patch 29/33] SONIC interrupt handling, v4

this patch had a bug where a nubus sonic card would register two interrupt handlers. Only a built-in sonic needs both. Versions 2 and 3 needed some cleanups, as Raylynn Knight and Christoph Hellwig pointed out (thanks). Signed-off-by: Finn Thain <[EMAIL PROTECTED]> drivers/net/jazzs

[PATCH] MAINTAINERS: Abandon pas16, dtc and t128 ISA card SCSI host adapter drivers

I don't intend to modernize these three drivers, so as to avoid the deprecated scsi_register() API. I don't have the relevant hardware. Cc: Michael Schmitz References: https://lkml.kernel.org/r/20160911171249.ga7...@infradead.org Signed-off-by: Finn Thain --- Whilst I suspect th

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

On Mon, 20 Jun 2016, Andreas Schwab wrote: > Peter Zijlstra writes: > > > Could either of you comment on the below patch? > > > > All atomic functions that return a value should imply full memory > > barrier semantics -- this very much includes a compiler barrier / > > memory clobber. > > I

Re: [PATCH 4/3] g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio

On Sun, 25 Sep 2016, Christoph Hellwig wrote: > On Sun, Sep 25, 2016 at 09:39:20PM +0200, Ondrej Zary wrote: > > > #define NCR5380_read(reg) \ > > + ioread8(((struct NCR5380_hostdata *)shost_priv(instance))->iomem + \ > > + ((struct NCR5380_hostdata *)shost_priv(instance))->offset +

Re: [PATCH 1/3] g_NCR5380: Remove deprecated __setup

On Sat, 24 Sep 2016, Ondrej Zary wrote: > Remove deprecated __setup for parsing command line parameters. > g_NCR5380.* parameters could be used instead. Removing useful features is deprecated too. The best reason I can see for removing the __setup parameters is that the g_NCR5380 module param

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

On Sat, 24 Sep 2016, Ondrej Zary wrote: > Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c > Use pnp_driver and isa_driver to manage cards. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 310 > +- > drivers/scsi/g_

Re: [PATCH 2/3] g_NCR5380: Reduce overrides[] from array to struct

On Sat, 24 Sep 2016, Ondrej Zary wrote: > Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE. Then > remove all code iterating the overrides[] array and reduce it to struct > card. There is a reference to the compile-time override in Documentation/scsi/g_NCR5380.txt which needs

[PATCH v2 3/3] scsi/ncr5380: Improve interrupt latency during PIO tranfers

ac LC III (because it only gets about 510 accesses per ms). This patch decreases disk performance by a fraction of one percent for dmx3191d on my 333 MHz PowerPC 750. Other affected hardware (such as g_NCR5380 on x86) was not tested but 5380 ISA cards generally use PDMA and not PIO. Signed-off-by:

Re: [PATCH] scsi: ncr5380: constify pnp_device_id

On Wed, 16 Aug 2017, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Acked

scsi/NCR5380: Suppress SDTR and WDTR message logging

guments to scmd_printk(). Tested-by: Stan Johnson Signed-off-by: Finn Thain diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index acc33440bca0..3cf16bca0dc6 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -1907,8 +1907,6 @@ static void NCR5380_information_transfer(struct

[PATCH 4/4] m68k/mac: Add mutual exclusion for IOP interrupt polling

The IOP interrupt handler iop_ism_irq() is used by the adb-iop driver to poll for ADB request completion. Unfortunately, it is not re-entrant. Fix the race condition by adding an iop_ism_irq_poll() function with suitable mutual exclusion. Tested-by: Stan Johnson Signed-off-by: Finn Thain Cc

[PATCH 0/4] m68k/mac: Various cleanups and fixes

Finn Thain (4): m68k/mac: More printk modernization m68k/mac: Disentangle VIA and OSS initialization m68k/mac: Disentangle VIA/RBV and NuBus initialization m68k/mac: Add mutual exclusion for IOP interrupt polling arch/m68k/include/asm/mac_iop.h | 1 + arch/m68k/mac/baboon.c

[PATCH 2/4] m68k/mac: Disentangle VIA and OSS initialization

ard oss_init() and delaying via_init() is no problem because those functions are independent. The only requirement here is that oss_register_interrupts() happens after via_init(). That is, mac_init_IRQ() happens after config_mac(). Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m

[PATCH 1/4] m68k/mac: More printk modernization

Log message fragments used to be printed on one line but now get split up. Fix this. Also, suppress log spam that merely prints known pointer values. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/baboon.c | 2 +- arch/m68k/mac/iop.c| 4 ++-- arch/m68k/mac/psc.c

[PATCH 3/4] m68k/mac: Disentangle VIA/RBV and NuBus initialization

is not something that the NuBus subsystem should worry about. So let's invoke via_nubus_init() earlier and make the platform responsible for bus unlocking and interrupt setup instead of the NuBus subsystem. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/oss.c | 8

[PATCH 00/14] Modernization and fixes for NuBus subsystem

This series begins with cleanups and fixes for the NuBus subsystem and finishes with a patch to add support for the Linux Driver Model. The next series, which requires this one, will modernize NuBus drivers. Finn Thain (14): nubus: Avoid array underflow and overflow nubus: Fix up header

[PATCH 14/14] nubus: Add support for the driver model

Cc: Greg Kroah-Hartman Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/Makefile | 2 +- drivers/nubus/bus.c| 87 ++ drivers/nubus/nubus.c | 3 ++ include/linux/nubus.h | 39 ++ 4 files changed, 130

[PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources

with their purpose and with related functions in the same file. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 123 ++ 1 file changed, 65 insertions(+), 58 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/

[PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/

given seq_file. This is used by the procfs file_operations methods, to finally give userspace access to slot ROM information, such as the available video modes. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 117 +++--- drivers/nubus

[PATCH 08/14] nubus: Clean up whitespace

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h index d832d849d55c..cddfed466bee 100644 --- a

[PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/

ata. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/proc.c | 100 -- include/linux/nubus.h | 1 - 2 files changed, 101 deletions(-) diff --git a/drivers/nubus/proc.c b/drivers/nubus/proc.c index c05662931b6c..88f6a880adb4 10064

[PATCH 07/14] nubus: Remove redundant code

nubus_find_device() function and the bogus get_nubus_list() prototype. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 52 +-- drivers/nubus/proc.c | 2 -- include/linux/nubus.h | 17 + 3 files changed, 22

[PATCH 05/14] nubus: Validate slot resource IDs

While we are here, include the slot number in the related error messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c

[PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot

en the directory already exists. Each nubus_board gets a directory such as /proc/bus/nubus/s/ where s is the hex slot number. Therefore, store the 'procdir' pointer in struct nubus_board instead of struct nubus_dev. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/pr

[PATCH net v3 10/12] net/mac8390: Fix log messages

Use dev_foo() and log the slot number instead of the unexpanded "eth%d". Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 36 +---

[PATCH net v3 09/12] net/8390: Fix redundant code

ure") Tested-by: Stan Johnson Signed-off-by: Finn Thain --- Only the mac8390.c and lib8390.c changes have been tested. The other changes are similar but untested. --- drivers/net/ethernet/8390/ax88796.c | 3 --- drivers/net/ethernet/8390/axnet_cs.c | 2 -- drivers/net/ethe

[PATCH net v3 01/12] net/macsonic: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/natsemi/macsonic.c | 170 ++-- 1 file changed, 118 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c index

[PATCH net v3 00/12] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

macmace.c. Changes since v2: - Modernize NuBus drivers by adopting the Linux Driver Model. - Use dev_foo() in NuBus drivers. - Don't log any probe messages after register_netdev(). Finn Thain (12): net/macsonic: Convert to nubus_driver net/mac89x0: Convert to platform_driver net/ma

[PATCH net v3 11/12] net/macmace: Fix and clean up log messages

Don't log unexpanded "eth%d". Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net

[PATCH net v3 07/12] net/mac89x0: Fix and modernize log messages

Fix log message fragments which no longer produce the desired output (since the behaviour of printk() was changed). Add missing printk severity levels. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac8

[PATCH net v3 12/12] net/smc9194: Remove bogus CONFIG_MAC reference

"[PATCH] add m68k dependencies to net driver config".) Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/smsc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig index 63

[PATCH net v3 06/12] net/mac89x0: Remove dead or unreachable code

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 8a23d2fc0e28..c1a3d1aed037 100644 --- a/drivers/net

[PATCH net v3 08/12] net/mac89x0: Replace custom debug logging with netif_* calls

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 52 --- 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 4575370d57db..9348c095c898 100644

[PATCH net v3 05/12] net/sonic: Replace custom debug logging with netif_* calls

Eliminate duplicated debug code by moving it into the core driver. Don't log the only valid silicon revision number (it's in the source). Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by: Finn Thain --- Only the sonic.[ch] and macsonic.c changes have b

[PATCH net v3 03/12] net/mac8390: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 -- drivers/net/ethernet/8390/mac8390.c | 105 ++-- include/net/Space.h | 1 - 3 files changed, 53 insertions(+), 56 deletions(-) diff --git a

[PATCH net v3 02/12] net/mac89x0: Convert to platform_driver

Apparently these Dayna cards don't have a pseudoslot declaration ROM which means they can't be probed like NuBus cards. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- arch/m68k/mac/config.c| 4 +++ drivers/net/Space.c | 3 -- drivers/ne

[PATCH net v3 04/12] net/sonic: Clean up and modernize log messages

: Finn Thain --- Only the macsonic.c changes have been tested. The other changes are similar but untested. --- drivers/net/ethernet/natsemi/jazzsonic.c | 13 drivers/net/ethernet/natsemi/macsonic.c | 54 ++-- drivers/net/ethernet/natsemi/xtsonic.c | 11

Re: [PATCH 04/14] nubus: Fix log spam

On Sat, 11 Nov 2017, Joe Perches wrote: > On Sat, 2017-11-11 at 01:12 -0500, Finn Thain wrote: > > Testing shows that a single Radius PrecisionColor 24X display board, > > which has 95 functional resources, produces over a thousand lines of > > log messages. Suppress these m

Re: [PATCH 14/14] nubus: Add support for the driver model

On Sat, 11 Nov 2017, Greg Kroah-Hartman wrote: > On Sat, Nov 11, 2017 at 09:45:53AM +0100, Greg Kroah-Hartman wrote: > > > > I can't take patches without any changelog text at all, that's not > > good engineering, sorry :( > > I forgot to write it, sorry. I was going to explain the decision to

Re: [PATCH 12/14] nubus: Rename struct nubus_dev

On Mon, 13 Nov 2017, Geert Uytterhoeven wrote: > Hi Finn, > > On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain > wrote: > > It is misleading to use "dev" to mean a functional resource. And in > > adopting the Linux Driver Model, struct nubus_board will embed a &g

Re: [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/

On Mon, 13 Nov 2017, Geert Uytterhoeven wrote: > On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain > wrote: > > > --- > > drivers/nubus/nubus.c | 117 +++--- > > drivers/nubus/proc.c | 170 > >

Re: [PATCH 2/4] m68k/mac: Disentangle VIA and OSS initialization

On Fri, 27 Oct 2017, Kars de Jong wrote: > 2017-10-27 4:45 GMT+02:00 Finn Thain : > > > macintosh_config->via_type is meaningless on Mac IIfx (i.e. the only > > model with OSS chip), so skip the via_type switch statement. > > > > Call oss_init() before via_in

Re: [PATCH 1/4] m68k/mac: More printk modernization

On Fri, 27 Oct 2017, Kars de Jong wrote: > 2017-10-27 4:45 GMT+02:00 Finn Thain : > > Log message fragments used to be printed on one line but now get split > > up. Fix this. Also, suppress log spam that merely prints known pointer > > values. > > > > Tested-by

Re: [PATCH 1/4] m68k/mac: More printk modernization

On Sat, 28 Oct 2017, I wrote: > > Any particular reason why you didn't use pr_debug() here? I'm guessing > > it's because this is not a known pointer value? > > > > It's because the call to psc_debug_dump() is already conditional on > #ifdef DEBUG_PSC. > > Having the printk conditional on bot

Re: [RFC v6 03/25] m68k/atari: Replace nvram_{read,write}_byte with arch_nvram_ops

James, would you please review and ack this patch, and patch 01/25 also? On Sun, 23 Aug 2015, Finn Thain wrote: > By implementing an arch_nvram_ops struct, any platform can re-use the > drivers/char/nvram module without needing any arch-specific code > in that module. Atari doe

[PATCH] nubus: Set default dma mask for nubus_board devices

A 32-bit mask is used by default because a NuBus slot has 32 address/data lines and a NuBus board is free to use all of them. Cc: Christoph Hellwig Cc: Greg Kroah-Hartman Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/bus.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH] m68k/mac: Use correct PMU response format

Now that the 68k Mac port has adopted the via-pmu driver, it must decode the PMU response accordingly otherwise the date and time will be wrong. Signed-off-by: Finn Thain --- I mistakenly omitted this change from my PMU patch series when I dropped "[PATCH v3 10/12] macintosh: Use common co

Re: m68k allmodconfig build errors

On Thu, 26 Jul 2018, Randy Dunlap wrote: > > > > The untested patch below may work. It seems that it may be relevant to > > both arc and m68k: > > > I got back to looking at the build errors. I agree with Andreas that > all of the fields in question are null-terminated, so Finn's patch looks

Re: m68k allmodconfig build errors

On Fri, 27 Jul 2018, Andreas Schwab wrote: > On Jul 27 2018, Finn Thain wrote: > > > Why doesn't gcc convert strncmp to __builtin_strcmp? > > It does. In fact, it first converts strncmp to __builtin_strncmp, then > optimizes it to __builtin_strcmp. Finally, __bulti

Re: m68k allmodconfig build errors

On Thu, 19 Jul 2018, Randy Dunlap wrote: > Hi Geert, > > I am seeing a few errors when cross-building m68k on x86_64, using the > toolchain at https://mirrors.edge.kernel.org/pub/tools/crosstool/ > (thanks, Arnd). (so this is gcc 8.1.0) > > block/partitions/ldm.o: In function `ldm_partition':

Re: m68k allmodconfig build errors

On Mon, 23 Jul 2018, Randy Dunlap wrote: > On 07/20/2018 12:20 AM, Andreas Schwab wrote: > > On Jul 19 2018, Randy Dunlap wrote: > > > >> block/partitions/ldm.o: In function `ldm_partition': > >> ldm.c:(.text+0x1900): undefined reference to `strcmp' > >> ldm.c:(.text+0x1964): undefined reference

[PATCH] m68k/mac: Rework patch "use time64_t in RTC handling"

time() and cuda_write_time(). Have via_read_time() return a time64_t, consistent with changes to pmu_read_time and cuda_read_time(). Drop the pointless wraparound conditional in via_read_time(). Cc: Arnd Bergmann Signed-off-by: Finn Thain --- arch/m68k/mac/misc.c | 18 +++--- 1 file changed, 7

Re: [PATCH v4 00/14] Modernization and fixes for NuBus subsystem

Hi Geert, On Fri, 5 Jan 2018, Geert Uytterhoeven wrote: > > I assume you meant this to go in through the m68k tree? > Yes, please. Because the NuBus-PowerMac port is out-of-tree, the m68k tree seems more appropriate than the powerpc tree for this submission. > Can you please run this through

Re: [PATCH v4 00/14] Modernization and fixes for NuBus subsystem

On Sun, 7 Jan 2018, Geert Uytterhoeven wrote: > it does complain when using spaces only ("please, no spaces at the > _start_ of a line"). > Checkpatch accepts this tab: int map(struct mm_id * mm_idp, unsigned long virt, unsigned long len, int prot, int phys_fd, unsigned long long offse

[PATCH] m68k/mac: Enable PDMA support for PowerBook 190

Stan's tests showed that PDMA improves sequential read performance by a factor of 5 on a PowerBook 190. Last time I tried this on a PowerBook 520 it didn't work, so let's not enable it there until it can be tested with the present mac_scsi driver. Tested-by: Stan Johnson Sign

[PATCH] macintosh/via-pmu68k: Initialize PMU driver with setup_arch and arch_initcall

... arch_initcall via_pmu_start Bring via-pmu68k.c into line with via-pmu.c to fix this issue. Cc: Geert Uytterhoeven Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/config.c | 4 ++ drivers/macintosh/via-pmu68k.c | 89 +- 2

[PATCH] m68k/mac: Fix apparent race condition in Baboon interrupt dispatch

apparent race condition. No-one seems to know how to clear Baboon IRQ flags, or whether that's even possible, so add a comment about this. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/baboon.c | 27 --- 1 file changed, 8 insertions(+), 19 dele

Re: [PATCH] m68k/mac: Enable PDMA support for PowerBook 190

On Mon, 29 Jan 2018, Geert Uytterhoeven wrote: > > Anyone with a PB520 who can check if it works now with scsi_type = > MAC_SCSI_OLD? > The PB520 and PB540 have a flawed early-revision 68LC040 processor* which makes it unlikely that these machines are running Linux (or NetBSD). A few have ha

Re: [PATCH] [RESEND] scsi: ips: fix firmware timestamps for 32-bit

On Wed, 17 Jan 2018, Arnd Bergmann wrote: > do_gettimeofday() is deprecated since it will stop working in 2038 on > 32-bit platforms. The firmware interface here actually supports times > until year 25500, so we should use longer timestamps. > I think that reasoning is flawed. If the firmware su

[PATCH v5 00/14] Modernization and fixes for NuBus subsystem

ps with single_open(). Changes since v3: - Added Acked-by and Reviewed-by tags. - Moved the SPDX tag in bus.c to the first line of the file. Changes since v4: - Addressed some code style issues. Finn Thain (14): nubus: Avoid array underflow and overflow nubus: Fix up header split nubus: Use stat

[PATCH v5 03/14] nubus: Use static functions where possible

This fixes a couple of warnings from 'make W=1': drivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot' drivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus' Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH v5 01/14] nubus: Avoid array underflow and overflow

Check array indices. Avoid sprintf. Use buffers of sufficient size. Use appropriate types for array length parameters. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 29 + drivers/nubus/proc.c | 12 ++-- include/linux/nubus.h

[PATCH v5 02/14] nubus: Fix up header split

UAPI: (Scripted) Disintegrate include/linux") Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 27 +++ include/uapi/linux/nubus.h | 23 --- 2 files changed, 23 insertions(+), 27 deletions(-) diff --git a/include/lin

[PATCH v5 13/14] nubus: Add expansion_type values for various Mac models

d-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/include/asm/macintosh.h | 9 ++- arch/m68k/mac/config.c | 110 +--- drivers/net/ethernet/natsemi/macsonic.c | 8 +-- 3 files changed, 54 insertions(+), 73 deletions(-) diff --git a/arch/m6

[PATCH v5 14/14] nubus: Add support for the driver model

ed-by: Greg Kroah-Hartman Tested-by: Stan Johnson Signed-off-by: Finn Thain --- The conversion of Mac network drivers from the Space.c convention to the Driver Model takes place in a separate patch series, archived at https://lkml.org/lkml/2017/11/11/25 That series motivates parts of this design,

[PATCH v5 12/14] nubus: Adopt standard linked list implementation

This increases code re-use and improves readability. Cc: "David S. Miller" Cc: Bartlomiej Zolnierkiewicz Acked-by: Bartlomiej Zolnierkiewicz Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 7 +++-- drivers/net/ethernet/cirrus/mac89x

[PATCH v5 11/14] nubus: Rename struct nubus_dev

ing struct nubus_dev as struct nubus_rsrc. "Functional resource" is the vendor's terminology so this helps avoid confusion. Cc: "David S. Miller" Cc: Bartlomiej Zolnierkiewicz Acked-by: Bartlomiej Zolnierkiewicz Tested-by: Stan Johnson Signed-off-by: Finn Thain ---

[PATCH v5 10/14] nubus: Rework /proc/bus/nubus/s/ implementation

ble video modes. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 114 -- drivers/nubus/proc.c | 222 ++ include/linux/nubus.h | 37 - 3 files changed, 256 insertions(+), 117 deletions(-

[PATCH v5 06/14] nubus: Call proc_mkdir() not more than once per slot directory

n the directory already exists. Each nubus_board gets a directory, such as /proc/bus/nubus/s/ where s is the hex slot number. Therefore, store the 'procdir' pointer in struct nubus_board instead of struct nubus_dev. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/pr

[PATCH v5 08/14] nubus: Clean up whitespace

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h index 3c7b236074b3..2d6f04055ebe 100644 --- a

[PATCH v5 07/14] nubus: Remove redundant code

nubus_find_device() function, the bogus get_nubus_list() prototype and the pointless card_present temporary variable. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 57 --- drivers/nubus/proc.c | 2 -- include/linux/nubus.h | 17

[PATCH v5 09/14] nubus: Generalize block resource handling

their purpose and with related functions in the same file. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 123 ++ 1 file changed, 65 insertions(+), 58 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/

[PATCH v5 04/14] nubus: Fix log spam

as the sequence of entries is backwards (my bad). Move the "scanning slots" message to its proper location. Fixes: 71ae40e4cf33 ("nubus: Clean up printk calls") Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 129 ++---

[PATCH v5 05/14] nubus: Validate slot resource IDs

While we are here, include the slot number in the related error messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c

[PATCH] MAINTAINERS: Add NuBus subsystem entry

This is legacy code but it might as well have an official maintainer. Cc: linux-m...@lists.linux-m68k.org Signed-off-by: Finn Thain --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2811a211632c..2bf5a5aee278 100644 --- a/MAINTAINERS

[PATCH] macintosh/adb: Use C99 initializers for struct adb_driver instances

Hopefully this will make it easier for the next reader who needs to check these pointers. No change to object files. Cc: Benjamin Herrenschmidt Signed-off-by: Finn Thain --- drivers/macintosh/adb-iop.c| 14 +++--- drivers/macintosh/macio-adb.c | 15 +++ drivers

[PATCH 0/3] m68k/mac: Miscellaneous clean-ups and fixes

Finn Thain (3): m68k/mac: Clean up whitespace and remove redundant parentheses m68k/mac: Enable RTC for 100-series PowerBooks m68k/mac: Remove bogus "FIXME" comment arch/m68k/mac/misc.c | 138 +-- 1 file changed, 78 inserti

[PATCH 3/3] m68k/mac: Remove bogus "FIXME" comment

This code works fine. The comment is misleading so remove it. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/misc.c | 4 1 file changed, 4 deletions(-) diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c index e0a5e2dfeb46..6aa77d1af47a 100644 --- a/arch/m68k

[PATCH 2/3] m68k/mac: Enable RTC for 100-series PowerBooks

now result in an error instead of failing silently. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/mac/misc.c | 70 ++-- 1 file changed, 41 insertions(+), 29 deletions(-) diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/mi

[PATCH 1/3] m68k/mac: Clean up whitespace and remove redundant parentheses

Signed-off-by: Finn Thain --- This uses the same spaces-after-tabs style that I've used elsewhere in this file. Please let me know if you'd prefer a variation that keeps checkpatch quiet. --- arch/m68k/mac/misc.c | 68 ++-- 1 file c

[PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls

In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev in dma api calls as if it was a pointer to a struct device. But it actually points to a struct platform_device. Fix this. Cc: Thomas Bogendoerfer Signed-off-by: Finn Thain --- drivers/scsi/jazz_esp.c | 2 +- drivers/s

[PATCH v2 00/10] SWIM driver fixes

y and Reviewed-by tags. Finn Thain (10): m68k/mac: Revisit floppy disc controller base addresses m68k/mac: Fix SWIM memory resource end address m68k/mac: Don't remap SWIM MMIO region block/swim: Fix array bounds check block/swim: Remove extra put_disk() call from error path block/s

[PATCH v2 08/10] block/swim: Check drive type

The SWIM chip is compatible with GCR-mode Sony 400K/800K drives but this driver only supports MFM mode. Therefore only Sony FDHD drives are supported. Skip incompatible drives. Cc: Laurent Vivier Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn

[PATCH v2 07/10] block/swim: Rename macros to avoid inconsistent inverted logic

Vivier Cc: Benjamin Herrenschmidt Cc: linuxppc-...@lists.ozlabs.org Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier --- drivers/block/swim.c | 8 drivers/block/swim3.c | 6 +++--- 2 files changed, 7 insert

[PATCH v2 09/10] block/swim: Fix IO error at end of medium

h the device size passed to set_capacity() during drive probe. Call set_capacity() again upon device open, after refreshing the density and head count values. Cc: Laurent Vivier Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent V

[PATCH v2 10/10] block/swim: Select appropriate drive on device open

The driver supports internal and external FDD units so the floppy_open function must not hard-code the drive location. Cc: Laurent Vivier Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier --- drivers/block/swim.c

[PATCH v2 06/10] block/swim: Don't log an error message for an invalid ioctl

ioctl, just do as the swim3 driver does and return -ENOTTY. Cc: Laurent Vivier Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier Reviewed-by: Geert Uytterhoeven --- drivers/block/swim.c | 9 ++--- 1 file change

[PATCH v2 05/10] block/swim: Remove extra put_disk() call from error path

Cc: Laurent Vivier Cc: Jens Axboe Cc: sta...@vger.kernel.org # v4.14+ Fixes: 103db8b2dfa5 ("[PATCH] swim: stop sharing request queue across multiple gendisks") Tested-by: Stan Johnson Signed-off-by: Finn Thain Acked-by: Laurent Vivier Reviewed-by: Geert Uytterhoeven --- dri

  1   2   3   4   5   6   7   8   9   10   >