Re: scheduling while atomic hang.

2013-07-05 Thread Frederic Weisbecker
On Fri, Jul 05, 2013 at 08:51:13AM +0200, Ingo Molnar wrote: * H. Peter Anvin h...@zytor.com wrote: On 07/03/2013 07:49 PM, Linus Torvalds wrote: [816f42bf] __schedule+0x94f/0x9c0 [816f487e] schedule_user+0x2e/0x70 [816f6de4] retint_careful+0x12/0x2e

Re: [URGENT rfc patch 0/3] tsc clocksource bug fix

2013-07-05 Thread Frederic Weisbecker
2013/7/4 Peter Zijlstra pet...@infradead.org: On Thu, Jul 04, 2013 at 01:34:13PM +0800, Alex Shi wrote: If the tsc is marked as constant and nonstop, could we set it as system clocksource when do tsc register? w/o checking it on clocksource_watchdog? I'd not do that; the BIOS can still screw

Re: scheduling while atomic hang.

2013-07-06 Thread Frederic Weisbecker
On Fri, Jul 05, 2013 at 12:27:51PM -0700, Linus Torvalds wrote: On Thu, Jul 4, 2013 at 11:51 PM, Ingo Molnar mi...@kernel.org wrote: It would be nice to have a full-kernel-stack backtrace printout as an option, which prints entries 'above' the current RSP. One problem with that is that

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-20 Thread Frederic Weisbecker
On Fri, Sep 20, 2013 at 01:03:17PM +0200, Thomas Gleixner wrote: On Thu, 19 Sep 2013, Linus Torvalds wrote: On Thu, Sep 19, 2013 at 2:51 PM, Frederic Weisbecker fweis...@gmail.com wrote: It fixes stacks overruns reported by Benjamin Herrenschmidt: http://lkml.kernel.org/r

Re: RFC vmstat: On demand vmstat threads

2013-09-20 Thread Frederic Weisbecker
On Fri, Sep 20, 2013 at 12:41:02PM +0200, Thomas Gleixner wrote: On Thu, 19 Sep 2013, Christoph Lameter wrote: On Thu, 19 Sep 2013, Thomas Gleixner wrote: The vmstat accounting is not the only thing which we want to delegate to dedicated core(s) for the full NOHZ mode. So instead

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-20 Thread Frederic Weisbecker
On Fri, Sep 20, 2013 at 07:30:14PM +0200, Thomas Gleixner wrote: On Fri, 20 Sep 2013, Frederic Weisbecker wrote: Now just for clarity, what do we then do with inline sofirq executions: on local_bh_enable() for example, or explicit calls to do_softirq() other than irq exit? Should we keep

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-21 Thread Frederic Weisbecker
2013/9/20 Linus Torvalds torva...@linux-foundation.org: On Fri, Sep 20, 2013 at 9:26 AM, Frederic Weisbecker fweis...@gmail.com wrote: Now just for clarity, what do we then do with inline sofirq executions: on local_bh_enable() for example, or explicit calls to do_softirq() other than irq

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-21 Thread Frederic Weisbecker
On Sun, Sep 22, 2013 at 07:45:01AM +1000, Benjamin Herrenschmidt wrote: On Sat, 2013-09-21 at 13:58 -0500, Frederic Weisbecker wrote: Now certainly what needs to be fixed then is archs that don't have __ARCH_IRQ_EXIT_IRQS_DISABLED or archs that have any other significant opportunity

Re: [PATCH RESEND] printk: report boot console names during cut-over

2013-09-21 Thread Frederic Weisbecker
On Fri, Sep 20, 2013 at 08:34:01AM -0700, Kees Cook wrote: This reports the names of boot consoles as they're being disabled to help identify which is which during cut-over. Helps answer the question which boot console actually got activated? once the regular console is running, mostly when

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-23 Thread Frederic Weisbecker
On Mon, Sep 23, 2013 at 02:40:34PM +1000, Benjamin Herrenschmidt wrote: On Sun, 2013-09-22 at 07:45 +1000, Benjamin Herrenschmidt wrote: What I *can* do that would help I suppose would be to switch to the irq stack before irq_enter/exit which would at least mean that softirq would run from

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-24 Thread Frederic Weisbecker
On Tue, Sep 24, 2013 at 02:42:57PM +1000, Benjamin Herrenschmidt wrote: On Tue, 2013-09-24 at 04:44 +0200, Frederic Weisbecker wrote: So the safest way to fix this is to unconditionally call do_softirq() from irq_exit(). A performance penalty may come along but safety primes. We should

Re: [RFC GIT PULL] softirq: Consolidation and stack overrun fix

2013-09-25 Thread Frederic Weisbecker
On Wed, Sep 25, 2013 at 06:55:47AM +1000, Benjamin Herrenschmidt wrote: On Tue, 2013-09-24 at 15:56 +0200, Frederic Weisbecker wrote: On Tue, Sep 24, 2013 at 02:42:57PM +1000, Benjamin Herrenschmidt wrote: On Tue, 2013-09-24 at 04:44 +0200, Frederic Weisbecker wrote: So the safest way

Re: [PATCH v2] printk: report console names during cut-over

2013-09-25 Thread Frederic Weisbecker
debugging boot console failures. Signed-off-by: Kees Cook keesc...@chromium.org Acked-by: Frederic Weisbecker fweis...@gmail.com Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH 1/7] irq: Force hardirq exit's softirq processing on its own stack

2013-09-25 Thread Frederic Weisbecker
significantly the opportunities for task stack overflow dug by softirqs. Longer term solutions may involve extending the hardirq stack coverage to irq_exit(), etc... Reported-by: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: sta

[RFC PATCH 0/7] softirq: Consolidation and stack overrun fix v2

2013-09-25 Thread Frederic Weisbecker
in __do_softirq() * more comments * introduction of a longer term solution via a new arch symbol for archs to tell about irq_exit() stack coverage. Thanks. Frederic Weisbecker (7): irq: Force hardirq exit's softirq processing on its own stack irq: Consolidate do_softirq() arch overriden

[PATCH 4/7] irq: Improve a bit softirq debugging

2013-09-25 Thread Frederic Weisbecker
step further and generalize that debug check to any softirq processing. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t...@linutronix.de Cc: Peter

[PATCH 7/7] x86: Tell about irq stack coverage

2013-09-25 Thread Frederic Weisbecker
there. x86-32 is not concerned because it only runs the irq handler on the irq stack. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t

[PATCH 6/7] irq: Optimize softirq stack selection in irq exit

2013-09-25 Thread Frederic Weisbecker
() runs on the irq stack. That way we can spare some stack switch on irq processing and all the cache issues that come along. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi

[PATCH 5/7] irq: Justify the various softirq stack choices

2013-09-25 Thread Frederic Weisbecker
For clarity, comment the various stack choices for softirqs processing, whether we execute them from ksoftirqd or local_irq_enable() calls. Their use on irq_exit() is already commented. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc

[PATCH 3/7] irq: Optimize call to softirq on hardirq exit

2013-09-25 Thread Frederic Weisbecker
Before processing softirqs on hardirq exit, we already do the check for pending softirqs while hardirqs are guaranteed to be disabled. So we can take a shortcut and safely jump to the arch specific implementation directly. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin

[PATCH 2/7] irq: Consolidate do_softirq() arch overriden implementations

2013-09-25 Thread Frederic Weisbecker
switch. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t...@linutronix.de Cc: Peter Zijlstra pet...@infradead.org Cc: H. Peter Anvin h...@zytor.com Cc

Re: [PATCH 6/7] irq: Optimize softirq stack selection in irq exit

2013-09-26 Thread Frederic Weisbecker
On Wed, Sep 25, 2013 at 04:04:28PM -0700, Linus Torvalds wrote: On Wed, Sep 25, 2013 at 9:18 AM, Frederic Weisbecker fweis...@gmail.com wrote: +#ifdef __ARCH_IRQ_EXIT_ON_IRQ_STACK Please don't introduce anymore of these insane ad-hoc crazy architecture macros. Just make it a regular

[PATCH 6/8] irq: Optimize softirq stack selection in irq exit

2013-09-26 Thread Frederic Weisbecker
to solve. So lets adapt the irq exit's softirq stack on top of a new Kconfig symbol that can be defined when irq_exit() runs on the irq stack. That way we can spare some stack switch on irq processing and all the cache issues that come along. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc

[PATCH 1/8] irq: Force hardirq exit's softirq processing on its own stack

2013-09-26 Thread Frederic Weisbecker
significantly the opportunities for task stack overflow dug by softirqs. Longer term solutions may involve extending the hardirq stack coverage to irq_exit(), etc... Reported-by: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: sta

[PATCH 0/8] softirq: Consolidation and stack overrun fix v3

2013-09-26 Thread Frederic Weisbecker
of 06367d58f487a592de50e6e2327371c5e3b6188f (Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc) And it can be pulled from: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git irq/core-v4 HEAD: 0362b2ff8d67913a8ffc5d757500129ead56b007 Frederic Weisbecker (8

[PATCH 4/8] irq: Improve a bit softirq debugging

2013-09-26 Thread Frederic Weisbecker
step further and generalize that debug check to any softirq processing. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t...@linutronix.de Cc: Peter

[PATCH 8/8] powerpc: Tell about irq stack coverage

2013-09-26 Thread Frederic Weisbecker
Now that powerpc runs irq_exit() under the irq stack, let the softirq core know about that so that we spare the needless stack switch on irq exit's softirq processing. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau

[PATCH 5/8] irq: Justify the various softirq stack choices

2013-09-26 Thread Frederic Weisbecker
For clarity, comment the various stack choices for softirqs processing, whether we execute them from ksoftirqd or local_irq_enable() calls. Their use on irq_exit() is already commented. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc

[PATCH 3/8] irq: Optimize call to softirq on hardirq exit

2013-09-26 Thread Frederic Weisbecker
Before processing softirqs on hardirq exit, we already do the check for pending softirqs while hardirqs are guaranteed to be disabled. So we can take a shortcut and safely jump to the arch specific implementation directly. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin

[PATCH 7/8] x86: Tell about irq stack coverage

2013-09-26 Thread Frederic Weisbecker
there. x86-32 is not concerned because it only runs the irq handler on the irq stack. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t

[PATCH 2/8] irq: Consolidate do_softirq() arch overriden implementations

2013-09-26 Thread Frederic Weisbecker
switch. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@au1.ibm.com Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t...@linutronix.de Cc: Peter Zijlstra pet...@infradead.org Cc: H. Peter Anvin h...@zytor.com Cc

Re: [PATCH 0/8] softirq: Consolidation and stack overrun fix v3

2013-09-26 Thread Frederic Weisbecker
On Thu, Sep 26, 2013 at 09:43:38AM -0700, Linus Torvalds wrote: On Thu, Sep 26, 2013 at 9:24 AM, Frederic Weisbecker fweis...@gmail.com wrote: * Turn __ARCH_IRQ_EXIT_ON_IRQ_STACK old ad-hoc style symbol to proper Kconfig (CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK) * Activates it to powerpc

[GIT PULL] arm/context_tracking build fix

2013-09-27 Thread Frederic Weisbecker
Ingo, Please pull the context_tracking/fixes branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git context_tracking/fixes Thanks, Frederic --- Frederic Weisbecker (1): arm: Fix build error with context tracking calls

Re: [PATCH 0/8] softirq: Consolidation and stack overrun fix v3

2013-09-30 Thread Frederic Weisbecker
On Thu, Sep 26, 2013 at 09:43:38AM -0700, Linus Torvalds wrote: On Thu, Sep 26, 2013 at 9:24 AM, Frederic Weisbecker fweis...@gmail.com wrote: * Turn __ARCH_IRQ_EXIT_ON_IRQ_STACK old ad-hoc style symbol to proper Kconfig (CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK) * Activates it to powerpc

[PATCH 2/3] nohz: Drop generic vtime obsolete dependency on CONFIG_64BIT

2013-09-30 Thread Frederic Weisbecker
Molnar mi...@kernel.org Cc: Russell King r...@arm.linux.org.uk Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Arm Linux linux-arm-ker...@lists.infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- init/Kconfig| 2 +- kernel/time/Kconfig | 1 - 2 files changed, 1 insertion

[PATCH 0/3] nohz full: drop 64-bit requirement, enable ARM support v2

2013-09-30 Thread Frederic Weisbecker
Hi Kevin, Your patchset was fine but I just did a second round. Namely I did the following changes: * Drop the 64 bits dependency after we settle the new dependency on HAVE_VIRT_CPU_ACCOUNTING_GEN and not before. This way we don't have a middle state that loose the dependency in the middle of

[PATCH 1/3] vtime: Add HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig

2013-09-30 Thread Frederic Weisbecker
. Feature requested by Frederic Weisbecker. Signed-off-by: Kevin Hilman khil...@linaro.org Cc: Ingo Molnar mi...@kernel.org Cc: Russell King r...@arm.linux.org.uk Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Arm Linux linux-arm-ker...@lists.infradead.org Signed-off-by: Frederic Weisbecker

[PATCH 3/3] ARM: Kconfig: allow full nohz CPU accounting

2013-09-30 Thread Frederic Weisbecker
...@linaro.org Cc: Ingo Molnar mi...@kernel.org Cc: Russell King r...@arm.linux.org.uk Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Arm Linux linux-arm-ker...@lists.infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

[GIT PULL] irq fix for 3.12-rc

2013-09-30 Thread Frederic Weisbecker
/1380212686-25897-1-git-send-email-fweis...@gmail.com I've added Linus ack and rebased to rc3. Thanks, Frederic --- Frederic Weisbecker (1): irq: Force hardirq exit's softirq processing on its own stack kernel/softirq.c | 15 --- 1 file changed, 12 insertions(+), 3

[GIT PULL] irq: updates for 3.13

2013-09-30 Thread Frederic Weisbecker
/1380212686-25897-1-git-send-email-fweis...@gmail.com with Linus and Benjamin's ack added and a rebase against rc3. It also contains the regression fix (with the same commit id) from my other pull request. Thanks, Frederic --- Frederic Weisbecker (8): irq: Force hardirq exit's softirq

Re: [GIT PULL] irq fix for 3.12-rc

2013-09-30 Thread Frederic Weisbecker
On Mon, Sep 30, 2013 at 09:07:19AM -0700, Linus Torvalds wrote: On Mon, Sep 30, 2013 at 7:55 AM, Frederic Weisbecker fweis...@gmail.com wrote: ... the chances for a stack overrun as reported in powerpc for example: [ 1002.364577] do_IRQ: stack overflow: 1920 [ 1002.364653

Re: [PATCH 3/3] ARM: Kconfig: allow virt CPU accounting

2013-07-19 Thread Frederic Weisbecker
On Wed, Jul 03, 2013 at 11:36:41AM -0700, Kevin Hilman wrote: With the 64-bit requirement removed from virt CPU accounting, allow ARM platforms to enable it. Cc: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Kevin Hilman khil...@linaro.org --- arch/arm/Kconfig | 1 + 1 file

Re: [PATCH 1/3] nohz: Kconfig: remove redundant 64-bit dependency

2013-07-19 Thread Frederic Weisbecker
that situation) and that's a bug. So we need to inherit the 64 bits dependency on NO_HZ_FULL to prevent that. We can remove this dependency from NO_HZ_FULL, but only once we remove it from VIRT_CPU_ACCOUNTING_GEN, not the other way around otherwise this breaks bisection. Cc: Frederic

Re: [PATCH 2/3] init/Kconfig: VIRT_CPU_ACCOUNTING_GEN: drop 64-bit requirement

2013-07-19 Thread Frederic Weisbecker
On Wed, Jul 03, 2013 at 11:36:40AM -0700, Kevin Hilman wrote: The 64-bit requirement can be removed after the conversion of the nsec granularity cputime to work on !64_BIT, which was done in commit 8c23b80e (cputime_nsecs: use math64.h for nsec resolution conversion helpers) Cc: Frederic

Re: [PATCH 04/11] perf tools: Support callchain sorting based on addresses

2013-07-22 Thread Frederic Weisbecker
a...@linux.intel.com Cc: Frederic Weisbecker fweis...@gmail.com Link: http://lkml.kernel.org/n/tip-0uskktybf0e7wrnoi5e9b...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com --- tools/perf/Documentation/perf-report.txt | 8 ++-- tools/perf/builtin-report.c

[PATCH 6/8] perf: Account freq events per cpu

2013-07-22 Thread Frederic Weisbecker
This is going to be used by the full dynticks subsystem as a finer-grained information to know when to keep and when to stop the tick. Original-patch-by: Peter Zijlstra pet...@infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra pet

[PATCH 5/8] perf: Migrate per cpu event accounting

2013-07-22 Thread Frederic Weisbecker
When an event is migrated, move the event per-cpu accounting accordingly so that branch stack and cgroup events work correctly on the new CPU. Original-patch-by: Peter Zijlstra pet...@infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter

[PATCH 8/8] watchdog: Remove hack to make full dynticks working

2013-07-22 Thread Frederic Weisbecker
concurrently with the full dynticks feature. Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra pet...@infradead.org Cc: Namhyung Kim namhy...@kernel.org Cc: Ingo Molnar mi...@kernel.org Cc: Arnaldo Carvalho de Melo a...@redhat.com Cc: Stephane Eranian

[PATCH 7/8] perf: Finer grained full dynticks kick

2013-07-22 Thread Frederic Weisbecker
events is handled from a seperate hrtimer. The tick can be shutdown the rest of the time. Original-patch-by: Peter Zijlstra pet...@infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra pet...@infradead.org Cc: Namhyung Kim namhy

[PATCH 1/8] perf: Fix branch stack refcount leak on callchain init failure

2013-07-22 Thread Frederic Weisbecker
-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra pet...@infradead.org Cc: Namhyung Kim namhy...@kernel.org Cc: Ingo Molnar mi...@kernel.org Cc: Arnaldo Carvalho de Melo a...@redhat.com Cc: Stephane Eranian eran...@google.com --- kernel/events/core.c | 12

[PATCH 3/8] perf: Gather event accounting code

2013-07-22 Thread Frederic Weisbecker
Gather all the event accounting code to a single place, once all the prerequisites are completed. This simplifies the refcounting. Original-patch-by: Peter Zijlstra pet...@infradead.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra pet

[PATCH 2/8] perf: Sanitize get_callchain_buffer()

2013-07-22 Thread Frederic Weisbecker
if case of failure, not by the caller. So lets clean this up by cancelling the refcount from get_callchain_buffer() in case of failure. And correctly free the event accordingly in perf_event_alloc(). Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Jiri Olsa jo...@redhat.com Cc: Peter Zijlstra

[PATCH 4/8] perf: Split per cpu event accounting code

2013-07-22 Thread Frederic Weisbecker
Split the per-cpu accounting part of the event accounting code. This way we can use the per-cpu handling seperately. This is going to be used by to fix the event migration code accounting. Original-patch-by: Peter Zijlstra pet...@infradead.org Signed-off-by: Frederic Weisbecker fweis

[PATCH 0/8] perf: Finer grained full dynticks handling

2013-07-22 Thread Frederic Weisbecker
that distros want to enable both... You can fetch from: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git perf/nohz Thanks, Frederic --- Frederic Weisbecker (8): perf: Fix branch stack refcount leak on callchain init failure perf: Sanitize

Re: [PATCH 8/8] watchdog: Remove hack to make full dynticks working

2013-07-23 Thread Frederic Weisbecker
On Tue, Jul 23, 2013 at 08:33:31AM -0400, Don Zickus wrote: On Tue, Jul 23, 2013 at 02:31:06AM +0200, Frederic Weisbecker wrote: A perf event can be used without forcing the tick to stay alive if it doesn't use a frequency but a sample period and if it doesn't throttle (raise storm

Re: [PATCH] NMI: fix NMI period is not correct when cpu frequency changes issue.

2013-07-24 Thread Frederic Weisbecker
On Thu, Apr 18, 2013 at 01:32:09PM +0200, Peter Zijlstra wrote: On Mon, 2013-04-15 at 16:30 -0700, Andrew Morton wrote: I think this will break the build if CONFIG_PERF_EVENTS=n and CONFIG_LOCKUP_DETECTOR=y. I was able to create such a config for powerpc. If I'm reading it correctly,

Re: [PATCH RFC nohz_full 6/7] nohz_full: Add full-system-idle state machine

2013-07-24 Thread Frederic Weisbecker
On Thu, Jul 18, 2013 at 10:06:25PM -0700, Paul E. McKenney wrote: Lets summarize the last sequence, the following happens ordered by time: CPU 0 CPU 1 cmpxchg(full_sysidle_state, RCU_SYSIDLE_SHORT, RCU_SYSIDLE_LONG);

[PATCH 1/2] nohz: Do not warn about unstable tsc unless user uses nohz_full

2013-07-24 Thread Frederic Weisbecker
Galbraith efa...@gmx.de Cc: Kevin Hilman khil...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/time/tick-sched.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index e80183f..1102534 100644

[PATCH 2/2] nohz: fix compile warning in tick_nohz_init()

2013-07-24 Thread Frederic Weisbecker
Gleixner t...@linutronix.de Cc: Peter Zijlstra pet...@infradead.org Cc: Borislav Petkov b...@alien8.de Cc: Li Zhong zh...@linux.vnet.ibm.com Cc: Mike Galbraith efa...@gmx.de Cc: Kevin Hilman khil...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/time/tick-sched.c |2 -- 1

[GIT PULL] nohz fixes

2013-07-24 Thread Frederic Weisbecker
Ingo, Please pull the timers/urgent branch that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/urgent Just one thing you need to know: you reported me that the warning was too much to tell the user that he can't use full dynticks due to

Re: [tip:timers/nohz] nohz: Move full nohz kick to its own IPI

2014-05-07 Thread Frederic Weisbecker
On Wed, May 07, 2014 at 05:17:35PM +0200, Peter Zijlstra wrote: On Mon, May 05, 2014 at 05:34:08PM +0200, Frederic Weisbecker wrote: On Mon, May 05, 2014 at 05:12:28PM +0200, Peter Zijlstra wrote: Note the current ordering: cmpxchg(qsd-pending, 0, 1) get ipi

Re: [tip:timers/nohz] nohz: Move full nohz kick to its own IPI

2014-05-07 Thread Frederic Weisbecker
On Wed, May 07, 2014 at 05:37:36PM +0200, Peter Zijlstra wrote: On Wed, May 07, 2014 at 05:29:24PM +0200, Frederic Weisbecker wrote: On Wed, May 07, 2014 at 05:17:35PM +0200, Peter Zijlstra wrote: On Mon, May 05, 2014 at 05:34:08PM +0200, Frederic Weisbecker wrote: On Mon, May 05, 2014

[PATCH 5/6] workqueue: Allow modifying low level unbound workqueue cpumask

2014-05-07 Thread Frederic Weisbecker
...@cn.fujitsu.com Cc: Mike Galbraith bitbuc...@online.de Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Tejun Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/workqueue.c | 65

[PATCH 2/6] workqueue: Reorder sysfs code

2014-05-07 Thread Frederic Weisbecker
Cc: Tejun Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/workqueue.c | 626 ++--- 1 file changed, 313 insertions(+), 313 deletions(-) diff --git a/kernel/workqueue.c b

[PATCH 6/6] workqueue: Record real per-workqueue cpumask

2014-05-07 Thread Frederic Weisbecker
Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/workqueue.c | 8 1 file changed, 8 insertions(+) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 5978cee..504cf0a 100644 --- a/kernel/workqueue.c +++ b

[PATCH 3/6] workqueue: Create low-level unbound workqueues cpumask

2014-05-07 Thread Frederic Weisbecker
...@linux.com Cc: Kevin Hilman khil...@linaro.org Cc: Lai Jiangshan la...@cn.fujitsu.com Cc: Mike Galbraith bitbuc...@online.de Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Tejun Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com

[PATCH 1/6] workqueue: Allow changing attributions of ordered workqueues

2014-05-07 Thread Frederic Weisbecker
Cc: Lai Jiangshan la...@cn.fujitsu.com Cc: Mike Galbraith bitbuc...@online.de Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Tejun Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/workqueue.c | 69

[PATCH 4/6] workqueue: Split apply attrs code from its locking

2014-05-07 Thread Frederic Weisbecker
paul...@linux.vnet.ibm.com Cc: Tejun Heo t...@kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/workqueue.c | 77 +++--- 1 file changed, 44 insertions(+), 33 deletions(-) diff --git

[RFC PATCH 0/6] workqueue: Introduce low-level unbound wq sysfs cpumask v2

2014-05-07 Thread Frederic Weisbecker
/pub/scm/linux/kernel/git/frederic/linux-dynticks.git core/workqueue-v4 --- Frederic Weisbecker (5): workqueue: Reorder sysfs code workqueue: Create low-level unbound workqueues cpumask workqueue: Split apply attrs code from its locking workqueue: Allow modifying low

Re: [tip:timers/nohz] nohz: Move full nohz kick to its own IPI

2014-05-09 Thread Frederic Weisbecker
On Wed, May 07, 2014 at 09:07:14PM +0200, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Wed, May 07, 2014 at 06:05:08PM +0200, Frederic Weisbecker wrote: So we can as well zap these commits and replace them with the irq_work_on() conversion (still preparing

Re: vmstat: On demand vmstat workers V4

2014-05-09 Thread Frederic Weisbecker
On Sat, May 10, 2014 at 12:57:15AM +0200, Thomas Gleixner wrote: On Fri, 9 May 2014, Christoph Lameter wrote: On Fri, 9 May 2014, Thomas Gleixner wrote: I understand why you want to get this done by a housekeeper, I just did not understand why we need this whole move it around business is

Re: vmstat: On demand vmstat workers V4

2014-05-09 Thread Frederic Weisbecker
On Fri, May 09, 2014 at 04:47:45PM -0700, Paul E. McKenney wrote: On Sat, May 10, 2014 at 12:57:15AM +0200, Thomas Gleixner wrote: If someone decides to make tick_do_timer_cpu non-constant in NO_HZ_FULL CPUs, they will break unless/until I make RCU deal with that sort of thing, at least for

Re: vmstat: On demand vmstat workers V4

2014-05-10 Thread Frederic Weisbecker
On Sat, May 10, 2014 at 02:31:28PM +0200, Thomas Gleixner wrote: On Sat, 10 May 2014, Frederic Weisbecker wrote: But I still have the plan to make the timekeeper use the full sysidle facility in order to adaptively get to dynticks idle. Reminder for others: in NO_HZ_FULL, the timekeeper

Re: vmstat: On demand vmstat workers V4

2014-05-10 Thread Frederic Weisbecker
On Sat, May 10, 2014 at 06:17:08PM -0700, Paul E. McKenney wrote: On Sat, May 10, 2014 at 03:14:25PM +0200, Frederic Weisbecker wrote: On Sat, May 10, 2014 at 02:31:28PM +0200, Thomas Gleixner wrote: On Sat, 10 May 2014, Frederic Weisbecker wrote: But I still have the plan to make

[PATCH 3/5] irq_work: Allow remote queueing

2014-05-11 Thread Frederic Weisbecker
...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- include/linux/irq_work.h | 2 ++ kernel/irq_work.c| 29 +++-- 2 files

[PATCH 5/5] nohz: Use IPI implicit full barrier against rq-nr_running r/w

2014-05-11 Thread Frederic Weisbecker
...@linaro.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/sched/core.c | 9 + kernel/sched/sched.h | 10

[RFC PATCH 0/5] nohz: Move nohz kick out of scheduler IPI, v3

2014-05-11 Thread Frederic Weisbecker
Hi, So this version gives up with smp_queue_function_single() and extends irq work to support remote queuing. As suggested by Peterz. Comments? git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/nohz-irq-work Thanks, Frederic --- Frederic

[PATCH 4/5] nohz: Move full nohz kick to its own IPI

2014-05-11 Thread Frederic Weisbecker
Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- include/linux/tick.h | 9 - kernel/sched/core.c | 5 + kernel/sched/sched.h | 2 +- kernel/time/Kconfig | 2 ++ kernel/time/tick-sched.c

[PATCH 1/5] irq_work: Architecture support for remote irq work raise

2014-05-11 Thread Frederic Weisbecker
viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- arch/Kconfig | 12 arch/alpha/kernel/time.c | 3 ++- arch/arm/Kconfig | 1 + arch/arm/kernel/smp.c | 4 ++-- arch/powerpc/kernel/time.c | 3 ++- arch/sparc/kernel/pcr.c

[PATCH 2/5] irq_work: Force non-lazy works on IPI

2014-05-11 Thread Frederic Weisbecker
: Ingo Molnar mi...@kernel.org Cc: Kevin Hilman khil...@linaro.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com

[PATCH 3/6] nohz: Support nohz full remote kick

2014-06-10 Thread Frederic Weisbecker
: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- include/linux/tick.h | 9 - kernel/time/tick-sched.c | 10 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/linux/tick.h b/include/linux/tick.h index

[PATCH 1/6] irq_work: Split raised and lazy lists

2014-06-10 Thread Frederic Weisbecker
E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/irq_work.c | 53 - 1

[PATCH 6/6] nohz: Use IPI implicit full barrier against rq-nr_running r/w

2014-06-10 Thread Frederic Weisbecker
mi...@kernel.org Cc: Kevin Hilman khil...@linaro.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/sched/core.c

[PATCH 5/6] nohz: Use nohz own full kick on 2nd task enqueue

2014-06-10 Thread Frederic Weisbecker
Molnar mi...@kernel.org Cc: Kevin Hilman khil...@linaro.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Peter Zijlstra pet...@infradead.org Cc: Thomas Gleixner t...@linutronix.de Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/sched

[PATCH 2/6] irq_work: Implement remote queueing

2014-06-10 Thread Frederic Weisbecker
Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- include/linux/irq_work.h | 5 + kernel/irq_work.c| 25 - kernel/smp.c | 9 + 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/include/linux

[PATCH 4/6] nohz: Switch to nohz full remote kick on timer enqueue

2014-06-10 Thread Frederic Weisbecker
viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/sched/core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index d9d8ece..03dc7e9 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c

[PATCH 0/6] nohz: Move nohz kick out of scheduler IPI, v8

2014-06-10 Thread Frederic Weisbecker
() on CONFIG_SMP, fixes some broken builds * Convert full nohz timer list kick git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git timers/nohz-irq-work-v6 Thanks, Frederic --- Frederic Weisbecker (6): irq_work: Split raised and lazy lists irq_work

Re: [PATCH 0/6] nohz: Move nohz kick out of scheduler IPI, v8

2014-06-10 Thread Frederic Weisbecker
On Tue, Jun 10, 2014 at 05:48:39PM +0200, Peter Zijlstra wrote: On Tue, Jun 10, 2014 at 05:15:03PM +0200, Frederic Weisbecker wrote: So this set happens to have more changes than expected because I found out that the timer list full nohz kick also relies on the scheduler IPI. So I had

Re: [PATCH 6/6] nohz: Use IPI implicit full barrier against rq-nr_running r/w

2014-06-10 Thread Frederic Weisbecker
On Tue, Jun 10, 2014 at 05:48:13PM +0200, Peter Zijlstra wrote: On Tue, Jun 10, 2014 at 05:15:09PM +0200, Frederic Weisbecker wrote: + /* + * More than one running task need preemption. + * nr_running update is assumed to be visible + * after IPI is sent from wakers

Re: [RFC PATCH 00/11] printk: safe printing in NMI context

2014-06-10 Thread Frederic Weisbecker
On Thu, May 29, 2014 at 10:09:48AM +0200, Jiri Kosina wrote: On Thu, 29 May 2014, Frederic Weisbecker wrote: I am rather surprised that this patchset hasn't received a single review comment for 3 weeks. Let me point out that the issues Petr is talking about in the cover letter

Re: [RFC PATCH 00/11] printk: safe printing in NMI context

2014-06-10 Thread Frederic Weisbecker
On Fri, May 30, 2014 at 10:13:28AM +0200, Jan Kara wrote: On Thu 29-05-14 02:09:11, Frederic Weisbecker wrote: On Thu, May 29, 2014 at 12:02:30AM +0200, Jiri Kosina wrote: On Fri, 9 May 2014, Petr Mladek wrote: printk() cannot be used safely in NMI context because it uses internal

[PATCH 0/2] timer: Fix missing dynticks kick

2014-06-12 Thread Frederic Weisbecker
Thomas, Viresh has spotted and fixed an interesting issue. When a timer list is enqueued or updated on a (idle or full) dynticks target, we kick it with an IPI. At least that's what we do on add_timer_on() but the mod_timer*() family doesn't handle that. I think that's because we had assumptions

[PATCH 1/2] timer: Store cpu-number in 'struct tvec_base'

2014-06-12 Thread Frederic Weisbecker
the callers know the CPU number of a timer's base. So lets store it in the struct tvec_base to resolve the CPU without much overhead. It is set once for good at every CPU's first boot. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel

[PATCH 2/2] timer: Kick dynticks targets on mod_timer*() calls

2014-06-12 Thread Frederic Weisbecker
that it is well handled for all sort of timer enqueue. Even timer migration is concerned so that a full dynticks target is correctly kicked as needed when timers are migrating to it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Frederic Weisbecker fweis...@gmail.com --- kernel/timer.c

[PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-12 Thread Frederic Weisbecker
kthread only when nohz full is actually used (ie: when the nohz_full= parameter is filled or CONFIG_NO_HZ_FULL_ALL=y) Signed-off-by: Frederic Weisbecker fweis...@gmail.com Cc: Josh Triplett j...@joshtriplett.org Cc: Steven Rostedt rost...@goodmis.org Cc: Mathieu Desnoyers mathieu.desnoy

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-13 Thread Frederic Weisbecker
On Thu, Jun 12, 2014 at 06:24:32PM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 02:16:59AM +0200, Frederic Weisbecker wrote: CONFIG_NO_HZ_FULL may be enabled widely on distros nowadays but actual users should be a tiny minority, if actually any. Also there is a risk

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-13 Thread Frederic Weisbecker
On Thu, Jun 12, 2014 at 06:35:15PM -0700, Paul E. McKenney wrote: On Thu, Jun 12, 2014 at 06:24:32PM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 02:16:59AM +0200, Frederic Weisbecker wrote: CONFIG_NO_HZ_FULL may be enabled widely on distros nowadays but actual users should

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-13 Thread Frederic Weisbecker
On Thu, Jun 12, 2014 at 07:05:54PM -0700, Paul E. McKenney wrote: On Thu, Jun 12, 2014 at 06:24:32PM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 02:16:59AM +0200, Frederic Weisbecker wrote: CONFIG_NO_HZ_FULL may be enabled widely on distros nowadays but actual users should

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-13 Thread Frederic Weisbecker
On Fri, Jun 13, 2014 at 08:52:33AM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 02:47:16PM +0200, Frederic Weisbecker wrote: On Thu, Jun 12, 2014 at 06:35:15PM -0700, Paul E. McKenney wrote: On Thu, Jun 12, 2014 at 06:24:32PM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014

Re: [PATCH] rcu: Only pin GP kthread when full dynticks is actually used

2014-06-13 Thread Frederic Weisbecker
On Fri, Jun 13, 2014 at 08:55:48AM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014 at 02:55:45PM +0200, Frederic Weisbecker wrote: On Thu, Jun 12, 2014 at 07:05:54PM -0700, Paul E. McKenney wrote: On Thu, Jun 12, 2014 at 06:24:32PM -0700, Paul E. McKenney wrote: On Fri, Jun 13, 2014

<    11   12   13   14   15   16   17   18   19   20   >