[PATCH] ocfs2: disable BUG assertions in reading blocks

2016-06-21 Thread Gang He
CATCH_BH_JBD_RACES to wrap BUG() in the ocfs2_read_blocks_sync function like before. 2) disable the macro CATCH_BH_JBD_RACES in Makefile by default. Signed-off-by: Gang He --- fs/ocfs2/Makefile | 2 -- fs/ocfs2/buffer_head_io.c | 5 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: make config_item_type const

2017-10-15 Thread Gang He
Hello Intel Kbuild team, You just upgrade GCC version when compiling the latest kernel? Since these code looks a little old, I am sure that the related contributors are still work on OCFS2 project. Thanks Gang >>> > Hi Bhumika, > > [auto build test WARNING on linus/master] > [also build te

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 18:14, Gang He wrote: >> Hi Changwei, >> >> >>>>> >>> On 2018/1/10 17:05, Gang He wrote: >>>> Hi Changwei, >>>> >>>> >>>>>>> >>>>&g

Re: [Ocfs2-devel] [PATCH v3 3/3] ocfs2: nowait aio support

2018-01-10 Thread Gang He
Hi Alex, >>> > Hi Gang, > > On 2017/12/28 18:07, Gang He wrote: >> Return -EAGAIN if any of the following checks fail for >> direct I/O with nowait flag: >> Can not get the related locks immediately, >> Blocks are not allocated at the write location,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 10:07, Gang He wrote: >> Hi Changwei, >> >> >>>>> >>> On 2018/1/10 18:14, Gang He wrote: >>>> Hi Changwei, >>>> >>>> >>>>>>> >>>>> On

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 11:33, Gang He wrote: >> Hi Changwei, >> >> >>>>> >>> On 2018/1/11 10:07, Gang He wrote: >>>> Hi Changwei, >>>> >>>> >>>>>>> >>>>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 12:31, Gang He wrote: >> Hi Changwei, >> >> >>>>> >>> On 2018/1/11 11:33, Gang He wrote: >>>> Hi Changwei, >>>> >>>> >>>>>>> >>>>> On 2018/1/11 10:

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 15:19, Gang He wrote: >> >> >> >>>>> >>> On 2018/1/11 12:31, Gang He wrote: >>>> Hi Changwei, >>>> >>>> >>>>>>> >>>>> On 2018/1/11 11:

Re: [Ocfs2-devel] [PATCH v2] ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE

2018-01-04 Thread Gang He
fenced. Thanks Gang >>> > > On 17/12/28 15:48, Gang He wrote: >> If we can't get inode lock immediately in the function >> ocfs2_inode_lock_with_page() when reading a page, we should not >> return directly here, since this will lead to a softlockup problem

Re: [Ocfs2-devel] [PATCH v2] ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE

2018-01-05 Thread Gang He
Hi Andrew, >>> Andrew Morton 01/06/18 4:50 AM >>> On Thu, 04 Jan 2018 23:31:12 -0700 "Gang He" wrote: > Happy new year. > Could you help to pick up this patch, which is used to fix a old patch > 1cce4df04f37. > If we have not this patch, so

Re: [Ocfs2-devel] [PATCH v2 1/2] ocfs2: add trimfs dlm lock resource

2018-01-10 Thread Gang He
Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> Introduce a new dlm lock resource, which will be used to >> communicate during fstrim a ocfs2 device from cluster nodes. >> >> Signed-off-by: Gang He

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >> fstrim command. But there is a problem, ocfs2 is a shared disk >> cluster file system, if the user configures a scheduled fs

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 17:05, Gang He wrote: >> Hi Changwei, >> >> >>>>> >>> Hi Gang, >>> >>> On 2017/12/14 13:16, Gang He wrote: >>>> As you know, ocfs2 has support trim the underlying disk via &

[PATCH v4 1/3] ocfs2: add ocfs2_try_rw_lock and ocfs2_try_inode_lock

2018-01-15 Thread Gang He
Add ocfs2_try_rw_lock and ocfs2_try_inode_lock functions, which will be used in non-block IO scenarios. Reviewed-by: Alex Chen Signed-off-by: Gang He --- fs/ocfs2/dlmglue.c | 21 + fs/ocfs2/dlmglue.h | 4 2 files changed, 25 insertions(+) diff --git a/fs/ocfs2

[PATCH v4 0/3] ocfs2: add nowait aio support

2018-01-15 Thread Gang He
urned to the upper code, move invoking ocfs2_overwrite_io() function from ocfs2_file_write_iter() to ocfs2_prepare_inode_for_write(), this change can combine acquiring the related locks. Gang He (3): ocfs2: add ocfs2_try_rw_lock and ocfs2_try_inode_lock ocfs2: add ocfs2_overwrite_io function

[PATCH v4 2/3] ocfs2: add ocfs2_overwrite_io function

2018-01-15 Thread Gang He
Add ocfs2_overwrite_io function, which is used to judge if overwrite allocated blocks, otherwise, the write will bring extra block allocation overhead. Reviewed-by: Alex Chen Signed-off-by: Gang He --- fs/ocfs2/extent_map.c | 45 + fs/ocfs2

[PATCH v4 3/3] ocfs2: nowait aio support

2018-01-15 Thread Gang He
Return -EAGAIN if any of the following checks fail for direct I/O with nowait flag: Can not get the related locks immediately, Blocks are not allocated at the write location, it will trigger block allocation, this will block IO operations. Signed-off-by: Gang He --- fs/ocfs2/dir.c | 2

[PATCH] dlm: prompt the user SCTP is experimental

2018-03-19 Thread Gang He
in case one connection(ring) is broken. Then, I suggest to add a kernel print, which prompts the user SCTP protocol for DLM should be considered experimental, it is not recommended in production environment. Signed-off-by: Gang He --- fs/dlm/lowcomms.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-03-22 Thread Gang He
ut 5mins hang in case > one connection(ring) is broken. > Then, I suggest to add a kernel print, which prompts the user SCTP > protocol for DLM should be considered experimental, it is not > recommended in production environment. > > Signed-off-by: Gang He > --- > fs/

Re: [Ocfs2-devel] [PATCH] fix crash on ocfs2_duplicate_clusters_by_page

2018-08-20 Thread Gang He
Hello Larry, >>> On 2018/8/16 at 19:24, in message <20180816112426.12218-1-lc...@suse.com>, Larry Chen wrote: > ocfs2_duplicate_clusters_by_page may crash if an extent's page is dirty. > When a page has not been written back, it is still in dirty state. If at > that moment, ocfs2_duplicate_clust

[PATCH 0/4] ocfs2: add online file check feature

2015-06-23 Thread Gang He
used to communication back what has to be fixed or is fixed. You could write: $# echo "CHECK " > /sys/fs/ocfs2/devname/filecheck or $# echo "FIX " > /sys/fs/ocfs2/devname/filecheck Gang He (4): ocfs2: export ocfs2_kset for online file check ocfs2: sysfile interfaces for

[PATCH 1/4] ocfs2: export ocfs2_kset for online file check

2015-06-23 Thread Gang He
Export ocfs2_kset object from ocfs2_stackglue kernel module, then online file check code will create the related sysfiles under ocfs2_kset object. Signed-off-by: Gang He Reviewed-by: Goldwyn Rodrigues --- fs/ocfs2/stackglue.c | 3 ++- fs/ocfs2/stackglue.h | 2 ++ 2 files changed, 4 insertions

[PATCH 3/4] ocfs2: create/remove sysfile for online file check

2015-06-23 Thread Gang He
Create online file check sysfile when ocfs2 mount, remove the related sysfile when ocfs2 umount. Signed-off-by: Gang He Reviewed-by: Goldwyn Rodrigues --- fs/ocfs2/super.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 403c566..7213a94 100644

[PATCH 2/4] ocfs2: sysfile interfaces for online file check

2015-06-23 Thread Gang He
Implement online file check sysfile interfaces, e.g. how to create the related sysfile according to device name, how to display/handle file check request from the sysfile. Signed-off-by: Gang He Reviewed-by: Goldwyn Rodrigues --- fs/ocfs2/Makefile| 3 +- fs/ocfs2/filecheck.c | 569

[PATCH 4/4] ocfs2: check/fix inode block for online file check

2015-06-23 Thread Gang He
Implement online check or fix inode block during reading a inode block to memory. Signed-off-by: Gang He Reviewed-by: Goldwyn Rodrigues --- fs/ocfs2/inode.c | 196 +++-- fs/ocfs2/ocfs2_trace.h | 2 + 2 files changed, 192 insertions(+), 6

[PATCH] dlm: make sctp_connect_to_sock() return in specified time

2018-04-26 Thread Gang He
time is spent in sock->ops->connect() function before returns ETIMEDOUT(-110) error, since O_NONBLOCK argument in connect() function does not work here, then we should make sock->ops->connect() function return in specified time via setting socket SO_SNDTIMEO atrribute. Signed-off-by: Gang

[PATCH] ocfs2: adjust arguments in dlm_new_lockspace called by kernel

2016-05-20 Thread Gang He
dlm_new_lockspace() function, to make sure the lockspace is created by kernel module itself, and this change will not affect the backward compatibility. Second, the obvious error message is reported in the kernel log, let the user be more easy to find the root cause. Gang He (1): ocfs2: insure dlm lockspace

[PATCH] ocfs2: insure dlm lockspace is created by kernel module

2016-05-20 Thread Gang He
should give the user a obvious error message, then, the user can let that user space tool exit before mounting the file system again. Signed-off-by: Gang He --- fs/ocfs2/stack_user.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2

Re: [PATCH v2 0/4] Add online file check feature

2015-12-04 Thread Gang He
Hi Greg, >>> > On Wed, Dec 02, 2015 at 07:05:27PM -0700, Gang He wrote: >> Hello Pavel, >> >> >> >> >>> >> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> >> When there are errors in the ocfs2 filesystem, >&

Re: [PATCH v2 0/4] Add online file check feature

2015-12-06 Thread Gang He
Hello Greg and Pavel, Sorry, there was a misunderstand, I was not aware that there were some design constraints for sysfs interfaces. I will review and modify this portion code. Thanks Gang >>> > On Fri, Dec 04, 2015 at 01:36:21AM -0700, Gang He wrote: >> Hi Greg, >&

Re: [PATCH v2 0/4] Add online file check feature

2015-12-02 Thread Gang He
Hello Pavel, >>> > On Wed 2015-10-28 14:25:57, Gang He wrote: >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by the inode number which caused the error. >> This inode number would be the input to fixing the file. >> One

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Gang He
Hi Mark and Junxiao, >>> > On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: >> Hi Gang, >> >> On 11/03/2015 03:54 PM, Gang He wrote: >> > Hi Junxiao, >> > >> > Thank for your reviewing. >> > Current design, we u

Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-24 Thread Gang He
Hi Mark and Junxiao, >>> > Hi Mark, > > On 11/25/2015 06:16 AM, Mark Fasheh wrote: >> Hi Junxiao, >> >> On Tue, Nov 03, 2015 at 03:12:35PM +0800, Junxiao Bi wrote: >>> Hi Gang, >>> >>> This is not like a right patch. >>> First, online file check only checks inode's block number, valid flag, >>

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Gang He
Hi Junxiao, >>> > Hi Gang, > > On 11/25/2015 11:29 AM, Gang He wrote: >> Hi Mark and Junxiao, >> >> >>>>> >>> On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: >>>> Hi Gang, >>>> >>>&g

[PATCH v2 0/4] Add online file check feature

2015-10-27 Thread Gang He
nd, update the source file contribution vendor. Gang He (4): ocfs2: export ocfs2_kset for online file check ocfs2: sysfile interfaces for online file check ocfs2: create/remove sysfile for online file check ocfs2: check/fix inode block for online file check fs/ocfs2/Makefile | 3 +- fs

[PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-10-27 Thread Gang He
Implement online check or fix inode block during reading a inode block to memory. Signed-off-by: Gang He --- fs/ocfs2/inode.c | 196 +++-- fs/ocfs2/ocfs2_trace.h | 2 + 2 files changed, 192 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2

[PATCH v2 1/4] ocfs2: export ocfs2_kset for online file check

2015-10-27 Thread Gang He
Export ocfs2_kset object from ocfs2_stackglue kernel module, then online file check code will create the related sysfiles under ocfs2_kset object. Signed-off-by: Gang He --- fs/ocfs2/stackglue.c | 3 ++- fs/ocfs2/stackglue.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 3/4] ocfs2: create/remove sysfile for online file check

2015-10-27 Thread Gang He
Create online file check sysfile when ocfs2 mount, remove the related sysfile when ocfs2 umount. Signed-off-by: Gang He --- fs/ocfs2/super.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 403c566..7213a94 100644 --- a/fs/ocfs2/super.c +++ b/fs

[PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-10-27 Thread Gang He
Implement online file check sysfile interfaces, e.g. how to create the related sysfile according to device name, how to display/handle file check request from the sysfile. Signed-off-by: Gang He --- fs/ocfs2/Makefile| 3 +- fs/ocfs2/filecheck.c | 566

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-28 Thread Gang He
tter > on where and how it helps ... would you mind sharing couple > examples(real scenarios). > > Thanks, > --Srini > > > On 10/27/2015 11:25 PM, Gang He wrote: >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by the inode num

Re: [Ocfs2-devel] [PATCH v2 0/4] Add online file check feature

2015-10-29 Thread Gang He
came > across prompted this change and how this change would help in that case. > > Thanks, > --Srini > > > On 10/28/2015 09:44 PM, Gang He wrote: >> Hello Srini, >> >> There is a doc about ocfs2 online file check. >> >> OCFS2 online file chec

[PATCH] ocfs2: add feature document for online file check

2015-07-19 Thread Gang He
er is reported in the kernel log. The user can try to check/fix this file via online filecheck feature. Signed-off-by: Gang He --- .../filesystems/ocfs2-online-filecheck.txt | 95 ++ 1 file changed, 95 insertions(+) create mode 100644 Documentation/filesystems/ocfs2-o

Re: [PATCH] ocfs2: add feature document for online file check

2015-07-19 Thread Gang He
y, and the problematic file's inode number is > reported > in the kernel log. The user can try to check/fix this file via online > filecheck > feature. > > Signed-off-by: Gang He > --- > .../filesystems/ocfs2-online-filecheck.txt | 95 > +

[PATCH v3] ocfs2: add feature document for online file check

2015-12-30 Thread Gang He
file's inode number is reported in the kernel log. The user can try to check/fix this file via online filecheck feature. Signed-off-by: Gang He --- .../filesystems/ocfs2-online-filecheck.txt | 94 ++ 1 file changed, 94 insertions(+) create mode 100644 Document

[PATCH v4 0/5] Add online file check feature

2016-02-28 Thread Gang He
with first version, I use strncasecmp instead of double strncmp functions. Second, update the source file contribution vendor. Gang He (5): ocfs2: export ocfs2_kset for online file check ocfs2: sysfile interfaces for online file check ocfs2: create/remove sysfile for online file check ocfs2: check/

[PATCH v4 5/5] ocfs2: add feature document for online file check

2016-02-28 Thread Gang He
file's inode number is reported in the kernel log. The user can try to check/fix this file via online filecheck feature. Signed-off-by: Gang He Reviewed-by: Mark Fasheh --- .../filesystems/ocfs2-online-filecheck.txt | 94 ++ 1 file changed, 94 insertions(+) create

[PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

2016-02-28 Thread Gang He
Implement online file check sysfile interfaces, e.g. how to create the related sysfile according to device name, how to display/handle file check request from the sysfile. Signed-off-by: Gang He --- fs/ocfs2/Makefile| 3 +- fs/ocfs2/filecheck.c | 606

[PATCH v4 3/5] ocfs2: create/remove sysfile for online file check

2016-02-28 Thread Gang He
Create online file check sysfile when ocfs2 mount, remove the related sysfile when ocfs2 umount. Signed-off-by: Gang He Reviewed-by: Mark Fasheh --- fs/ocfs2/super.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 2de4c8a..5ef88b8 100644 --- a

[PATCH v4 4/5] ocfs2: check/fix inode block for online file check

2016-02-28 Thread Gang He
Implement online check or fix inode block during reading a inode block to memory. Signed-off-by: Gang He --- fs/ocfs2/inode.c | 225 +++-- fs/ocfs2/ocfs2_trace.h | 2 + 2 files changed, 218 insertions(+), 9 deletions(-) diff --git a/fs/ocfs2

[PATCH v4 1/5] ocfs2: export ocfs2_kset for online file check

2016-02-28 Thread Gang He
Export ocfs2_kset object from ocfs2_stackglue kernel module, then online file check code will create the related sysfiles under ocfs2_kset object. Signed-off-by: Gang He Reviewed-by: Mark Fasheh --- fs/ocfs2/stackglue.c | 3 ++- fs/ocfs2/stackglue.h | 2 ++ 2 files changed, 4 insertions(+), 1

Re: [Ocfs2-devel] [PATCH 0/4] ocfs2: add online file check feature

2015-07-03 Thread Gang He
e.com/pipermail/ocfs2-devel/2015-April/010768.html > https://oss.oracle.com/pipermail/ocfs2-devel/2015-June/010873.html > > Thanks, > Joseph > > On 2015/6/24 13:24, Gang He wrote: >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-03 Thread Gang He
bled or > add some mount option for it. > > Thanks, > Junxiao. > > On 10/28/2015 02:25 PM, Gang He wrote: >> Implement online file check sysfile interfaces, e.g. >> how to create the related sysfile according to device name, >> how to display/handle file check re

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
and load into the memory as a inode object. Since the file system is under a cluster environment, we have to use some existing function and code path to keep these block operation under a cluster lock. Thanks Gang > > Thanks, > Junxiao. > On 10/28/2015 02:26 PM, Gang He wrote: &g

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-03 Thread Gang He
Hi Junxiao, >>> > Hi Gang, > > On 11/03/2015 03:54 PM, Gang He wrote: >> Hi Junxiao, >> >> Thank for your reviewing. >> Current design, we use a sysfile as a interface to check/fix a file (via > pass a ino number). >> But, this

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:15 PM, Gang He wrote: >> Hello Junxiao, >> >> See my comments inline. >> >> >>>>> >>> Hi Gang, >>> >>> This is not like a right patch. >>> First, online file check only check

Re: [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

2015-11-03 Thread Gang He
>>> > On 11/03/2015 04:47 PM, Gang He wrote: >> >> >> >>>>> >>> On 11/03/2015 04:15 PM, Gang He wrote: >>>> Hello Junxiao, >>>> >>>> See my comments inline. >>>> >>>> >>&

RE: [PATCH] ocfs2: mount shared volume without ha stack

2020-04-28 Thread Gang He
Hello Joseph, Thank for your taking the time to review the patch. Please see my comments inline. > -Original Message- > From: Joseph Qi [mailto:joseph...@linux.alibaba.com] > Sent: 2020年4月27日 17:48 > To: Gang He ; m...@fasheh.com; jl...@evilplan.org > Cc: linux-kernel@

Re: [Ocfs2-devel] [PATCH] ocfs2: fix the application IO timeout when fstrim is running

2019-01-14 Thread Gang He
Hello Changewei, >>> On 2019/1/15 at 11:50, in message <63adc13fd55d6546b7dece290d39e3730127825...@h3cmlb12-ex.srv.huawei-3com.com>, Changwei Ge wrote: > Hi Gang, > > Most parts of this patch look sane to me, just a tiny question... > > On 2019/1/11 17:01, Gang

Re: [Ocfs2-devel] [PATCH] ocfs2: fix the application IO timeout when fstrim is running

2019-01-15 Thread Gang He
Hello ChangWei, >>> On 2019/1/15 at 16:00, in message <63adc13fd55d6546b7dece290d39e3730127826...@h3cmlb12-ex.srv.huawei-3com.com>, Changwei Ge wrote: > On 2019/1/15 13:49, Gang He wrote: >> Hello Changewei, >> >>>>> On 2019/1/15 at 11:50, in messag

[PATCH 1/2] ocfs2: add last unlock times in locking_state

2019-05-23 Thread Gang He
k resource record. Signed-off-by: Gang He Reviewed-by: Joseph Qi --- fs/ocfs2/dlmglue.c | 21 + fs/ocfs2/ocfs2.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index af405586c5b1..dccf4136f8c1 100644 ---

[PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-23 Thread Gang He
. Compared with v1, the main change is to add CONFIG_OCFS2_FS_STATS macro definition judgment. Signed-off-by: Gang He Reviewed-by: Joseph Qi --- fs/ocfs2/dlmglue.c | 36 fs/ocfs2/ocfs2.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/fs/ocfs2/dlmglue.c

Re: [Ocfs2-devel] [PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-23 Thread Gang He
example of outputs before patch VS that after patch? > I think that would directly show what the patch does. > > thanks, > wengang > > On 05/23/2019 03:40 AM, Gang He wrote: >> Add locking filter debugfs file, which is used to filter lock >> resources dump from loc

Re: [Ocfs2-devel] [PATCH V3 2/2] ocfs2: add locking filter debugfs file

2019-05-26 Thread Gang He
new last access time field too. > > thanks, > wengang > > On 2019/5/23 19:15, Gang He wrote: >> Hello Wengang, >> >> This patch is used to add a filter attribute(the default value is 0), the > kernel module can use this attribute value to filter the lock r

[PATCH V4 3/3] ocfs2: add first lock wait time in locking_state

2019-06-10 Thread Gang He
tect these deadlock problems via comparing the first lock wait time with the current time. Signed-off-by: Gang He --- fs/ocfs2/dlmglue.c | 32 +--- fs/ocfs2/ocfs2.h | 1 + 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2

[PATCH V4 2/3] ocfs2: add locking filter debugfs file

2019-06-10 Thread Gang He
, ocfs2_dlm_init_debug() returns directly with error when creating locking filter debugfs file is failed, since ocfs2_dlm_shutdown_debug() will handle this failure perfectly. Compared with v1, the main change is to add CONFIG_OCFS2_FS_STATS macro definition judgment. Signed-off-by: Gang He Reviewed-by: Joseph Qi

[PATCH V4 1/3] ocfs2: add last unlock times in locking_state

2019-06-10 Thread Gang He
k resource record. Compared with v1, the main change is to use wall time in microsecond for last pr/ex unlock time. Signed-off-by: Gang He Reviewed-by: Joseph Qi --- fs/ocfs2/dlmglue.c | 18 +++--- fs/ocfs2/ocfs2.h | 1 + 2 files changed, 16 insertions(+), 3 deletions(-) diff

[PATCH] ocfs2: fix the application IO timeout when fstrim is running

2019-01-11 Thread Gang He
meta-file. Signed-off-by: Gang He --- fs/ocfs2/alloc.c | 159 + fs/ocfs2/dlmglue.c | 5 ++ fs/ocfs2/ocfs2.h | 1 + fs/ocfs2/ocfs2_trace.h | 2 + fs/ocfs2/super.c | 2 + 5 files changed, 106 insertions(+), 63 deletions(-) diff

Re: [PATCH] dlm: prompt the user SCTP is experimental

2018-04-02 Thread Gang He
Hi David, >>> > On Thu, Mar 22, 2018 at 10:27:56PM -0600, Gang He wrote: >> Hello David, >> >> Do you agree to add this prompt to the user? >> Since sometimes customers attempted to setup SCTP protocol with two rings, >> but they could not get the

Re: [Ocfs2-devel] [PATCH] ocfs2: ocfs2_inode_lock_tracker does not distinguish lock level

2018-05-10 Thread Gang He
process 2 ocfs2_inode_lock_tracker(ex=0) <== ocfs2_inode_lock_tracker(ex=1) ocfs2_inode_lock_tracker(ex=1) Signed-off-by: Larry Chen Reviewed-by: Gang He --- fs/ocfs2/dlmglue.c | 119 +++-- fs/ocfs2/dlmglue.h | 1 +

答复: Re: [PATCH 1/2] ocfs2: add kobject for online file check

2016-12-19 Thread Gang He
the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gang-He/ocfs2-add-kobject-for-online-file-check/20161219-181858 config: x86_64-randconfig-x000-201651 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reprodu

答复: Re: [kbuild-all] 答复: Re: [PATCH 1/2] ocfs2: add kobject for online file check

2016-12-19 Thread Gang He
Hi Fengguang and all, I will reconstruct my patch set, to make sure each patch can follow this rule. Thanks Gang >>> Fengguang Wu 2016-12-20 上午 9:47 >>> Hi Gang, On Mon, Dec 19, 2016 at 06:43:48PM -0700, Gang He wrote: >Hello Kbuild, >Could you build my whole patch set

[PATCH v2 0/4] ocfs2: use kobject for online file check

2016-12-21 Thread Gang He
small fixes during this code refactoring. Second, the code change does not affect the underlying file check code. Thank Goldwyn very much. Compare with first version, split the code change into four patches, make sure each patch will not bring ocfs2 kernel modules compiling errors. Gang He (4):

[PATCH v2 4/4] ocfs2: add duplicative ino number check

2016-12-21 Thread Gang He
Add duplicative ino number check, to avoid adding a file into the file check list when this file is being checked. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2

[PATCH v2 2/4] ocfs2: fix some small problems

2016-12-21 Thread Gang He
First, move setting fe_done = 1 in spin lock, avoid bring any potential race condition. Second, tune mlog message level from ERROR to NOTICE, since the message should not belong to error message. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 3/4] ocfs2: add kobject for online file check

2016-12-21 Thread Gang He
Use embedded kobject mechanism for online file check feature, this will avoid to use a global list to save/search per-device online file check related data. The changed code is based on Goldwyn Rodrigues's patches and ext4 fs code. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c

[PATCH v2 1/4] ocfs2: move some definitions to header file

2016-12-21 Thread Gang He
Move some definitions to header file, which will be referenced by other source files when kobject mechanism is introduced. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 27 --- fs/ocfs2/filecheck.h | 27 +++ 2 files changed, 27 insertions

Re: [PATCH v2 2/4] ocfs2: fix some small problems

2016-12-28 Thread Gang He
>>> > Hi Gang, one small comment below: > > On Wed, Dec 21, 2016 at 2:20 AM, Gang He wrote: >> First, move setting fe_done = 1 in spin lock, avoid bring >> any potential race condition. Second, tune mlog message level >> from ERROR to NOTICE, since the m

[PATCH 1/2] ocfs2: add kobject for online file check

2016-12-19 Thread Gang He
move some data structure definitions to the header file; 2) tune mlog message level from ERROR to NOTICE; 3) add file check duplicative ino number check; 4) the other miscellaneous. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 360 --- fs/

[PATCH 0/2] ocfs2: use kobject for online file check

2016-12-19 Thread Gang He
fixes during this code refactoring. Second, the code change does not affect the underlying file check code. Thank Goldwyn very much. Gang He (2): ocfs2: add kobject for online file check ocfs2: embed kobject in ocfs2_super structure fs/ocfs2/filecheck.c

[PATCH 2/2] ocfs2: embed kobject in ocfs2_super structure

2016-12-19 Thread Gang He
Embed kobject in ocfs2_super structure, then we can use container_of method to get our own data pointor via kobject pointer. Second, I adjust the related code in create/remove online file check sysfs entry. Signed-off-by: Gang He --- fs/ocfs2/ocfs2.h | 8 fs/ocfs2/super.c | 27

Re: [PATCH] ocfs2: fix crash caused by stale lvb with fsdlm plugin

2016-12-11 Thread Gang He
Hi Eric, Looks good for me. Just one suggestion, please monitor if the LVB sharing mechanism in the cluster still works well in the normal scenario, to avoid any performance decrease regression problem. Reviewed-by: Gang He Thanks Gang >>> > The crash happens rather often w

Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

2016-03-21 Thread Gang He
1 Mar 2016 15:57:23 -0700 Mark Fasheh wrote: >> > >> > > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote: >> > > > Implement online file check sysfile interfaces, e.g. >> > > > how to create the related sysfile according t

[PATCH 1/4] ocfs2: update filecheck copyright

2015-08-21 Thread Gang He
Update filecheck copyright to the right time/contributor Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 2 +- fs/ocfs2/filecheck.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/filecheck.c b/fs/ocfs2/filecheck.c index a492e55..4b5a673 100644 --- a/fs/ocfs2

[PATCH 4/4] ocfs2: add file extent block check

2015-08-21 Thread Gang He
Add file extent block online check, besides inode block online check, we will add more kinds of meta block online check/repair. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 247 +-- 1 file changed, 239 insertions(+), 8 deletions(-) diff

[PATCH 3/4] ocfs2: filecheck validate_extent_block function

2015-08-21 Thread Gang He
Add validate_extent_block/repair_extent_block functions for online filecheck. Signed-off-by: Gang He --- fs/ocfs2/alloc.c | 116 + fs/ocfs2/alloc.h | 4 ++ fs/ocfs2/ocfs2_trace.h | 24 ++ 3 files changed, 144 insertions

[PATCH 2/4] ocfs2: add errno and macro definitions

2015-08-21 Thread Gang He
Add new errno, macro definitions and header file inclusion, which will be used for file extent block online check. Signed-off-by: Gang He --- fs/ocfs2/filecheck.c | 4 fs/ocfs2/filecheck.h | 1 + fs/ocfs2/journal.h | 3 +++ 3 files changed, 8 insertions(+) diff --git a/fs/ocfs2

[PATCH 0/4] ocfs2: add file extent block online check

2015-08-21 Thread Gang He
Besides inode block online check, add file extent block online check this time, we will add more kinds of meta block online check/repair in the future. Gang He (4): ocfs2: update filecheck copyright ocfs2: add errno and macro definitions ocfs2: filecheck validate_extent_block function

Re: [PATCH 0/4] ocfs2: add online file check feature

2015-07-10 Thread Gang He
Hi Andrew, Thank for your suggestions. I will sort out a document for ocfs2 online file check feature. Thanks Gang >>> > On Wed, 24 Jun 2015 13:24:17 +0800 Gang He wrote: > >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by th

[PATCH v3 0/4] Add online file check feature

2015-12-24 Thread Gang He
corruption currently until having a complete solution. Compare with first version, I use strncasecmp instead of double strncmp functions. Second, update the source file contribution vendor. Gang He (4): ocfs2: export ocfs2_kset for online file check ocfs2: sysfile interfaces for online file ch

[PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check

2015-12-24 Thread Gang He
Export ocfs2_kset object from ocfs2_stackglue kernel module, then online file check code will create the related sysfiles under ocfs2_kset object. Signed-off-by: Gang He --- fs/ocfs2/stackglue.c | 3 ++- fs/ocfs2/stackglue.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 4/4] ocfs2: check/fix inode block for online file check

2015-12-24 Thread Gang He
Implement online check or fix inode block during reading a inode block to memory. Signed-off-by: Gang He --- fs/ocfs2/inode.c | 200 +++-- fs/ocfs2/ocfs2_trace.h | 2 + 2 files changed, 196 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2

[PATCH v3 2/4] ocfs2: sysfile interfaces for online file check

2015-12-24 Thread Gang He
Implement online file check sysfile interfaces, e.g. how to create the related sysfile according to device name, how to display/handle file check request from the sysfile. Signed-off-by: Gang He --- fs/ocfs2/Makefile| 3 +- fs/ocfs2/filecheck.c | 605

[PATCH v3 3/4] ocfs2: create/remove sysfile for online file check

2015-12-24 Thread Gang He
Create online file check sysfile when ocfs2 mount, remove the related sysfile when ocfs2 umount. Signed-off-by: Gang He --- fs/ocfs2/super.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 2de4c8a..5ef88b8 100644 --- a/fs/ocfs2/super.c +++ b/fs

Re: [PATCH v3 0/4] Add online file check feature

2015-12-29 Thread Gang He
Hello Andrew and Mark, >>> > On Fri, 25 Dec 2015 15:16:15 +0800 Gang He wrote: > >> When there are errors in the ocfs2 filesystem, >> they are usually accompanied by the inode number which caused the error. >> This inode number would be the input to fixing

Re: [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check

2015-12-29 Thread Gang He
Hello Andrew, >>> > On Fri, 25 Dec 2015 15:16:16 +0800 Gang He wrote: > >> Export ocfs2_kset object from ocfs2_stackglue kernel module, >> then online file check code will create the related sysfiles >> under ocfs2_kset object. >> >> ... >&

[PATCH] ocfs2: fix potential soft lockup during fstrim

2020-09-26 Thread Gang He
upper applications more IO opportunities, these applications are not blocked for too long at writing files. Signed-off-by: Gang He --- fs/ocfs2/alloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 4c1b90442d6f..2cf9321919b5 100644

[PATCH] ocfs2: fix remounting needed after setfacl command

2020-07-16 Thread Gang He
ile: ocfs2/ivan owner: root group: root user::rw- group::r-- mask::r-- other::r-- The latest acl record("u:ivan:rw") cannot be returned via getfacl command until remounting. Signed-off-by: Gang He --- fs/ocfs2/acl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ocfs2/acl

Re: [PATCH V4 3/3] ocfs2: add first lock wait time in locking_state

2019-06-12 Thread Gang He
Hello Joseph, >>> On 6/12/2019 at 3:03 pm, in message , Joseph Qi wrote: > Hi Gang, > > On 19/6/11 09:54, Gang He wrote: >> ocfs2 file system uses locking_state file under debugfs to dump >> each ocfs2 file system's dlm lock resources, but the users eve

Re: [Ocfs2-devel] mmotm 2019-06-11-16-59 uploaded (ocfs2)

2019-06-13 Thread Gang He
Hello Randy and Andrew, >>> On 6/13/2019 at 9:18 am, in message <20190612181813.48ad05832e05f767e7116...@linux-foundation.org>, Andrew Morton wrote: > On Wed, 12 Jun 2019 07:15:30 -0700 Randy Dunlap wrote: > >> On 6/11/19 4:59 PM, a...@linux-foundation.org wrote: >> > The mm-of-the-moment snap

Re: [Ocfs2-devel] [PATCH 1/2] ocfs2: add last unlock times in locking_state

2019-05-29 Thread Gang He
Hi Wengang, >>> On 2019/5/29 at 1:22, in message <66083663-1d25-437b-ce98-07d200f44...@oracle.com>, Wengang wrote: > Hi Gang, > > This idea sounds cool! > Some comments in lines: > > On 05/23/2019 03:40 AM, Gang He wrote: >> ocfs2 file system uses l

  1   2   >