On Sun, Oct 28, 2018 at 03:45:16PM -0700, Linus Torvalds wrote:
> On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell
> wrote:
> >
> > After merging the origin tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
>
> linux-next is back! Wheee..
>
> > 5a2de63fd1a5 ("brid
On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote:
> On Wed, Apr 11, 2018 at 5:15 PM, syzbot
> wrote:
> > Hello,
> >
> > syzbot hit the following crash on upstream commit
> > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +)
> > Merge branch 'perf-urgent-for-lin
On Thu, Apr 26, 2018 at 10:04:16AM +0200, Dmitry Vyukov wrote:
> On Thu, Apr 26, 2018 at 8:13 AM, Hangbin Liu wrote:
> > On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote:
> >> On Wed, Apr 11, 2018 at 5:15 PM, syzbot
> >> wrote:
> >> > Hello,
On Tue, Jan 05, 2021 at 05:43:16PM +0800, Yi Chen wrote:
> From: yiche
>
> Fixes: 619ae8e0697a6 ("selftests: netfilter: add test case for conntrack
> helper assignment")
>
> Fix nft_conntrack_helper.sh fake fail:
> conntrack tool need "-f ipv6" parameter to show out ipv6 traffic items.
> sleep
On Wed, Feb 20, 2019 at 03:09:21PM +0200, Nikolay Aleksandrov wrote:
> On 20/02/2019 14:48, Sebastian Gottschall wrote:
> > *reminder*
> >
> [snip]
> > }
> > static void br_ip4_multicast_query(struct net_bridge *br,
> >>> Is this also a problem in 4.20? This patch went into 4.20-rc1
On Sun, May 19, 2019 at 10:27:53PM +0200, Florian Westphal wrote:
> Nathan Chancellor wrote:
> > On Wed, May 15, 2019 at 12:56:16PM +0200, Greg Kroah-Hartman wrote:
> > > From: Hangbin Liu
> > >
> > > [ Upstream commit e9919a24d3022f72bcadc407e73a6ef
On Tue, Dec 18, 2018 at 09:55:45PM -0800, David Miller wrote:
> From: Sukumar Gopalakrishnan
> Date: Wed, 19 Dec 2018 10:57:02 +0530
>
> > Hi David,
> >
> > There are two patch for this issue:
> >1) Your changes which removes cache_resolve_queue_len
> > 2) Hangbin's changes which make
#syz fix: net/smc: simplify wait when closing listen socket
On Fri, May 11, 2018 at 07:17:16AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed")
>
> is missing a Signed-off-by from its author.
Opps, My bad.
> After route cache is flushed via ipv4_sysctl_rtcache_flush(), we f
2017-02-16 6:41 GMT+08:00 Ben Hutchings :
> 3.2.85-rc1 review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Hangbin Liu
>
> commit 24803f38a5c0b6c57ed800b47e695f9ce474bc3a upstream.
>
> In commit 24cf3af3fed5 ("igm
et/ipv6/mcast.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
> index 7e12d2114158..8cd2782a31e4 100644
> --- a/net/ipv6/mcast.c
> +++ b/net/ipv6/mcast.c
> @@ -2615,6 +2615,7 @@ void ipv6_mc_destroy_dev(struct inet6_dev *idev)
> idev->mc_list = i->next;
>
> write_unlock_bh(&idev->lock);
> + ip6_mc_clear_src(i);
> ma_put(i);
> write_lock_bh(&idev->lock);
> }
> --
> 2.17.1
>
Acked-by: Hangbin Liu
On Fri, Sep 25, 2020 at 02:16:14PM -0700, Kees Cook wrote:
> On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote:
> > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote:
> > >
> > > Currently, after generating run_kselftest.sh, there is no way to choose
> &g
On Fri, Sep 25, 2020 at 04:45:27PM -0700, Kees Cook wrote:
> Currently with run_kselftest.sh there is no way to choose which test
> we could run. All the tests listed in kselftest-list.txt are all run
> every time. This patch enhanced the run_kselftest.sh to make the test
> collections (or tests) i
On Mon, Sep 28, 2020 at 01:06:15PM -0700, Kees Cook wrote:
> > I'm really sorry to make this trouble. And I'm OK to revert the patch.
> > I just a little wondering how do you generate this script.
>
> This issue is with which shell is used. I suspect your /bin/sh is full
> /bin/bash, where as Nare
On Mon, Sep 28, 2020 at 01:26:47PM -0700, Kees Cook wrote:
> v2:
> - update documentation
> - include SPDX line in extracted script
> v1:
> https://lore.kernel.org/linux-kselftest/20200925234527.1885234-1-keesc...@chromium.org/
>
I'm not sure if the doc update are all appropriate. Need others he
ftest to skeletons"). But this
commit is too large and need more backports. To fix it, the
easiest way is just use the current goto label 'close_prog'.
Reported-by: kernel test robot
Fixes: da43712a7262 ("selftests/bpf: Skip perf hw events test if the setup
disabled it&quo
"zram.sh"
cd $ROOT
}
usage()
{
cat <
$logfile; shift ;;
-t | --tests ) TESTS=$2; shift 2 ;;
-h | --help ) usage; exit 0;;
"" ) break;;
* ) usage; exit 1;;
esac
done
cd $BASE_DIR
ROOT=$PWD
for folder in $TESTS; do
f
"zram.sh"
cd $ROOT
}
usage()
{
cat <
$logfile; shift ;;
-t | --tests ) TESTS=$2; shift 2 ;;
-h | --help ) usage; exit 0;;
"" ) break;;
* ) usage; exit 1;;
esac
done
cd $BASE_DIR
ROOT=$PWD
for folder in $TESTS; do
"zram.sh"
cd $ROOT
}
usage()
{
cat <
$logfile; shift ;;
-t | --tests ) TESTS=$2; shift 2 ;;
-l | --list ) echo $TESTS; exit 0 ;;
-h | --help ) usage; exit 0 ;;
"" ) break;;
* ) usage; exit 1;;
esac
done
cd $B
Use nft by default if it's supported, as nft is the replacement for iptables,
which is used by default in some releases. Additionally, iptables is dropped
in some releases.
Signed-off-by: Hangbin Liu
---
v2: use one nft table for testing (Phil Sutter)
---
tools/testing/selftests/wire
Add a test to check the temporary address could be added/removed
correctly when mngtempaddr is set or removed/unmanaged.
Suggested-by: Sam Edwards
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/net/rtnetlink.sh | 89
1 file changed, 89 insertions(+)
diff --git
Currently the temporary address is not removed when mngtmpaddr is deleted
or becomes unmanaged. The patch set fixed this issue and add a related
test.
Hangbin Liu (2):
net/ipv6: delete temporary address if mngtmpaddr is removed or
un-mngtmpaddr
selftests/rtnetlink.sh: add mngtempaddr test
Fixes: 778964f2fdf0 ("ipv6/addrconf: fix timing bug in tempaddr regen")
Signed-off-by: Hangbin Liu
---
net/ipv6/addrconf.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 94dceac52884..6852dbce5a7d 100644
--- a/net/ipv6/addrconf.c
Some distros may not load nf_conntrack by default, which will cause
subsequent nf_conntrack settings to fail. Let's load this module if it's
not loaded by default.
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Hangbin Liu
---
v2: load the m
cture")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/net/rds/Makefile | 3 ++-
tools/testing/selftests/net/rds/test.py | 0
2 files changed, 2 insertions(+), 1 deletion(-)
mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py
diff --git a/tools/testing/selftests/net/rd
Some distros may not load nf_conntrack by default, which will cause
subsequent nf_conntrack settings to fail. Let's load this module if it's
not loaded by default.
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Hangbin Liu
---
tools/testing
Use nft by default if it's supported, as nft is the replacement for iptables,
which is used by default in some releases. Additionally, iptables is dropped
in some releases.
Signed-off-by: Hangbin Liu
---
CC nft developers to see if there are any easier configurations,
as I'm not ver
On Fri, Nov 15, 2024 at 12:46:27PM -0800, Sam Edwards wrote:
> Hi Hangbin,
>
> It took me a while to grasp but the problem seems to be a confusion
> about what it means to set a temporary's lifetimes to 0/0:
> 1) "The mngtmpaddrs has gone away; this temporary is slated for
> deletion by addrconf_v
On Fri, Nov 15, 2024 at 12:59:27PM -0800, Sam Edwards wrote:
> Hi Hangbin,
>
> My apologies, I should have shared my version of the check function
> before. Here it is:
>
> ```bash
> # Called to validate the addresses on $IFNAME:
> #
> # 1. Every `temporary` address must have a matching `mngtmpad
On Sun, Nov 17, 2024 at 09:09:00PM +0100, Jason A. Donenfeld wrote:
> On Mon, Nov 11, 2024 at 04:19:02AM +0000, Hangbin Liu wrote:
> > Use nft by default if it's supported, as nft is the replacement for
> > iptables,
> > which is used by default in some releases. Additio
fered/valid time to 0, and later in addrconf_verify_rtnl() all checkings
failed to remove the addresses. Fix this by deleting the temporary address
directly for these situations.
Fixes: 778964f2fdf0 ("ipv6/addrconf: fix timing bug in tempaddr regen")
Signed-off-by: Hangbin Liu
---
net/ipv6/addrconf.c | 41
Add a test to check the temporary address could be added/removed
correctly when mngtempaddr is set or removed/unmanaged.
Signed-off-by: Sam Edwards
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/net/rtnetlink.sh | 95
1 file changed, 95 insertions(+)
diff
including, add Sam in SOB (Sam
Edwards)
Hangbin Liu (2):
net/ipv6: delete temporary address if mngtmpaddr is removed or
unmanaged
selftests/rtnetlink.sh: add mngtempaddr test
net/ipv6/addrconf.c | 41 +++---
tools/testing/selftests/net/rtnetlink.sh | 95
On Wed, Nov 13, 2024 at 11:56:12AM -0800, Jakub Kicinski wrote:
> On Wed, 13 Nov 2024 12:51:52 +0000 Hangbin Liu wrote:
> > Add a test to check the temporary address could be added/removed
> > correctly when mngtempaddr is set or removed/unmanaged.
>
> Doesn't seem to wo
On Thu, Nov 14, 2024 at 07:13:40AM -0800, Jakub Kicinski wrote:
> > I will modify the test with Sam's suggestions and see if it could pass.
>
> The other option is that some other test doesn't clean up after itself,
> since we reuse VMs. We have a script in NIPA to map things:
> contest/cithreadma
On Sun, Nov 17, 2024 at 09:09:00PM +0100, Jason A. Donenfeld wrote:
> On Mon, Nov 11, 2024 at 04:19:02AM +0000, Hangbin Liu wrote:
> > Use nft by default if it's supported, as nft is the replacement for
> > iptables,
> > which is used by default in some releases. Additio
.amazon.com
Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/net/rds/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/rds/Makefile
b/tools/testing/selftes
On Wed, Nov 13, 2024 at 06:43:12PM -0800, Jakub Kicinski wrote:
> On Thu, 14 Nov 2024 02:00:01 +0000 Hangbin Liu wrote:
> > > # [+300.25] tempaddr not deleted for 2001:db8::1
> > > # [+0.16] tempaddr not deleted for 2003:db8::1
> > > # [+0.07] FAIL: mngtmpaddr add/r
On Wed, Nov 13, 2024 at 01:03:13PM -0800, Sam Edwards wrote:
> On Wed, Nov 13, 2024 at 4:52 AM Hangbin Liu wrote:
> >
> > RFC8981 section 3.4 says that existing temporary addresses must have their
> > lifetimes adjusted so that no temporary addresses should ever remain &quo
Hi Sam,
On Wed, Nov 13, 2024 at 12:43:00PM -0800, Sam Edwards wrote:
> > +# If the mngtmpaddr or tempaddr missing, return 0 and stop waiting
> > +check_tempaddr_exists()
> > +{
> > + local start=${1-"1"}
> > + addr_list=$(ip -j -n $testns addr show dev ${devdummy})
> > + for i in
echo "udp gso"
> run_in_netns ${args} -S 0
>
> --
> 2.39.3 (Apple Git-146)
>
Reviewed-by: Hangbin Liu
> + run_in_netns ${args} -m
> +
> echo "udp gso"
> run_in_netns ${args} -S 0
>
> --
> 2.39.3 (Apple Git-146)
>
Reviewed-by: Hangbin Liu
On Fri, Dec 13, 2024 at 07:31:27PM -0800, Jakub Kicinski wrote:
> On Fri, 13 Dec 2024 07:18:08 +0000 Hangbin Liu wrote:
> > On Thu, Dec 12, 2024 at 06:27:34AM -0800, Jakub Kicinski wrote:
> > > On Wed, 11 Dec 2024 07:11:25 + Hangbin Liu wrote:
> > > > The firs
On Thu, Jan 02, 2025 at 11:33:34AM +0800, Jianbo Liu wrote:
> > > Re-locking doesn't look great, glancing at the code I don't see any
> > > obvious better workarounds. Easiest fix would be to don't let the
> > > drivers sleep in the callbacks and then we can go back to a spin lock.
> > > Maybe nvid
Convert iptabels to nft as it is the replacement for iptables, which is used
by default in most releases.
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/wireguard/netns.sh | 29 ++
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tools/testing
(Phil Sutter)
Hangbin Liu (2):
selftests: wireguards: convert iptables to nft
selftests: wireguard: update to using nft for qemu test
tools/testing/selftests/wireguard/netns.sh| 29 +-
.../testing/selftests/wireguard/qemu/Makefile | 40 ++-
.../selftests
Since we will replace iptables with nft for wireguard netns testing,
let's also convert the qemu test to use nft at the same time.
Co-developed-by: Phil Sutter
Signed-off-by: Phil Sutter
Signed-off-by: Hangbin Liu
---
.../testing/selftests/wireguard/qemu/Makefile
On Wed, Jan 08, 2025 at 11:40:05AM +0800, Jianbo Liu wrote:
>
>
> On 1/8/2025 10:46 AM, Hangbin Liu wrote:
> > On Mon, Jan 06, 2025 at 10:47:16AM +0000, Hangbin Liu wrote:
> > > On Thu, Jan 02, 2025 at 11:33:34AM +0800, Jianbo Liu wrote:
> > > > > > Re-l
t and then convert
the multicast address to the right MAC address.
Fixes: 8eb36164d1a6 ("bonding: add ns target multicast address to slave device")
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_options.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
The mac address on backup slave should be convert from Solicited-Node
Multicast address, not from bonding unicast target address.
Hangbin Liu (2):
bonding: fix incorrect MAC address setting to receive NA messages
selftests: bonding: fix incorrect mac address
drivers/net/bonding
The correct mac address for NS target 2001:db8::254 is 33:33:ff:00:02:54,
not 33:33:00:00:02:54. The same with client maddress.
Fixes: 86fb6173d11e ("selftests: bonding: add ns multicast group testing")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/drivers/net/bonding/bond_
Oh, I just found the subject is incorrect. We want to receive the NS
message, not NA message on backup slaves.
Thanks
Hangbin
On Wed, Feb 05, 2025 at 08:03:35AM +, Hangbin Liu wrote:
> In order to receive the neighbor solicitation messages on the backup slave,
> we should add
The correct mac address for NS target 2001:db8::254 is 33:33:ff:00:02:54,
not 33:33:00:00:02:54. The same with client maddress.
Fixes: 86fb6173d11e ("selftests: bonding: add ns multicast group testing")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/drivers/net/bonding/bond_
use directly. Instead, we should first convert it to a
Solicited-Node Multicast Address and then derive the corresponding MAC
address.
Fixes: 8eb36164d1a6 ("bonding: add ns target multicast address to slave device")
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_options.c |
The mac address on backup slave should be convert from Solicited-Node
Multicast address, not from bonding unicast target address.
v2: fix patch 01's subject
Hangbin Liu (2):
bonding: fix incorrect MAC address setting to receive NS messages
selftests: bonding: fix incorrect mac ad
he NS message somewhere,
even using tcpdump (the NIC will be in promisc mode) I can't capture the
NS message on backup slave.
I need to debug more.
Thanks
Hangbin
On Fri, Feb 07, 2025 at 09:29:18AM +0000, Hangbin Liu wrote:
> The mac address on backup slave should be convert from S
On Thu, Feb 06, 2025 at 05:19:34PM -0800, Jay Vosburgh wrote:
> I think this now deserves some commentary in the code. Not
> because this function itself is unclear, but because there's the
> similarly-named slave_set_ns_maddr() (singular, not plural as in this
> patch) that will behave in a
functions. Also only use one mac_addr variable
in slave_set_ns_maddr() to save some code and logic.
Fixes: 8eb36164d1a6 ("bonding: add ns target multicast address to slave device")
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_options.c | 55 +---
bject
Hangbin Liu (2):
bonding: fix incorrect MAC address setting to receive NS messages
selftests: bonding: fix incorrect mac address
drivers/net/bonding/bond_options.c| 55 ---
.../drivers/net/bonding/bond_options.sh | 4 +-
2 files changed, 49 insertions(+
The correct mac address for NS target 2001:db8::254 is 33:33:ff:00:02:54,
not 33:33:00:00:02:54. The same with client maddress.
Fixes: 86fb6173d11e ("selftests: bonding: add ns multicast group testing")
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/drivers/net/bonding/bond_
Hi Jay,
On Sat, Feb 08, 2025 at 06:34:21AM +, Hangbin Liu wrote:
> Please hold on this patch. Our QE reported that with bare NIC, the
> backup NIC can't receive the NS messages even after joining the multicast
> MAC group. But after remove the backup NIC from bond, the NIC int
The first patch fixes the xfrm offload feature during setup active-backup
mode. The second patch add a ipsec offload testing.
Hangbin Liu (2):
bonding: fix xfrm offload feature setup on active-backup mode
selftests: bonding: add ipsec offload test
drivers/net/bonding/bond_main.c
.
Signed-off-by: Hangbin Liu
---
.../selftests/drivers/net/bonding/Makefile| 3 +-
.../drivers/net/bonding/bond_ipsec_offload.sh | 155 ++
.../selftests/drivers/net/bonding/config | 4 +
3 files changed, 161 insertions(+), 1 deletion(-)
create mode 100755
tools/testing
registered first before changing the bond
link parameters. This change will allow the XFRM ESP offload feature to be
correctly enabled.
Fixes: 007ab5345545 ("bonding: fix feature flag setting at init time")
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_main.c| 2 +-
d
On Thu, Dec 12, 2024 at 11:19:33AM +0200, Nikolay Aleksandrov wrote:
> > diff --git a/drivers/net/bonding/bond_main.c
> > b/drivers/net/bonding/bond_main.c
> > index 49dd4fe195e5..7daeab67e7b5 100644
> > --- a/drivers/net/bonding/bond_main.c
> > +++ b/drivers/net/bonding/bond_main.c
> > @@ -4389,7
Since we will replace iptables with nft for wireguard netns testing,
let's also convert the qemu test to use nft at the same time.
Co-developed-by: Phil Sutter
Signed-off-by: Phil Sutter
Signed-off-by: Hangbin Liu
---
.../testing/selftests/wireguard/qemu/Makefile
Convert iptabels to nft as it is the replacement for iptables, which is used
by default in most releases.
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/wireguard/netns.sh | 29 ++
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tools/testing
(Phil Sutter)
Hangbin Liu (2):
selftests: wireguards: convert iptables to nft
selftests: wireguard: update to using nft for qemu test
tools/testing/selftests/wireguard/netns.sh| 29 +-
.../testing/selftests/wireguard/qemu/Makefile | 40 ++-
.../selftests
On Thu, Dec 12, 2024 at 11:43:15AM +0200, Nikolay Aleksandrov wrote:
> >>> --- a/drivers/net/bonding/bond_netlink.c
> >>> +++ b/drivers/net/bonding/bond_netlink.c
> >>> @@ -568,18 +568,21 @@ static int bond_newlink(struct net *src_net, struct
> >>> net_device *bond_dev,
> >>> str
On Thu, Dec 12, 2024 at 06:27:34AM -0800, Jakub Kicinski wrote:
> On Wed, 11 Dec 2024 07:11:25 +0000 Hangbin Liu wrote:
> > The first patch fixes the xfrm offload feature during setup active-backup
> > mode. The second patch add a ipsec offload testing.
>
> Looks like the
On Fri, Nov 22, 2024 at 03:01:29PM +, Maximilian Heyne wrote:
> Hi Hangbin,
>
> On Fri, Sep 27, 2024 at 12:13:49PM +0800, Hangbin Liu wrote:
> > The include.sh file is generated for inclusion and should not be executable.
> > Otherwise, it will be added to kselftest-l
On Fri, Jan 10, 2025 at 03:35:23PM +0100, Alessandro Zanni wrote:
> On Fri, Jan 10, 2025 at 04:09:07AM +0000, Hangbin Liu wrote:
> > On Fri, Jan 10, 2025 at 01:07:44AM +0100, Alessandro Zanni wrote:
> > > Running "make kselftest TARGETS=net/forwarding" results in seve
On Fri, Jan 10, 2025 at 01:07:44AM +0100, Alessandro Zanni wrote:
> Running "make kselftest TARGETS=net/forwarding" results in several
> occurrences of the same error:
> ./lib.sh: line 787: teamd: command not found
>
> Since many tests depends on teamd, this fix stops the tests if the
> teamd com
On Tue, Jan 21, 2025 at 08:55:25AM +, Hangbin Liu wrote:
> The fixed commit adds NETIF_F_GSO_ESP bit for bonding gso_partial_features.
> However, if we don't set the dev NETIF_F_GSO_PARTIAL bit, the later
> netdev_change_features() -> netdev_fix_features() will remove the
>
333b4217 ("bonding: add ESP offload features when slaves support")
Reported-by: Liang Li
Signed-off-by: Hangbin Liu
---
v2: remove NETIF_F_GSO_PARTIAL bit if not set gso_partial_features.
The issue is reported internally, so there is no Closes tag.
BTW, I saw some drivers set NETIF_F_GSO_PARTIA
333b4217 ("bonding: add ESP offload features when slaves support")
Reported-by: Liang Li
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
On Mon, Jan 20, 2025 at 04:16:49PM +, Cosmin Ratiu wrote:
> On Fri, 2025-01-17 at 08:54 +0100, Steffen Klassert wrote:
> > >
> > > Hi Jianbo,
> > >
> > > I talked with Sabrina and it looks we can't simply do this. Because
> > > both
> > > xfrm_add_sa_expire() and xfrm_timer_handler() calling
On Thu, Jan 02, 2025 at 11:33:34AM +0800, Jianbo Liu wrote:
> > > Re-locking doesn't look great, glancing at the code I don't see any
> > > obvious better workarounds. Easiest fix would be to don't let the
> > > drivers sleep in the callbacks and then we can go back to a spin lock.
> > > Maybe nvid
On Wed, Jan 08, 2025 at 07:15:00AM +, Hangbin Liu wrote:
> > > > > > I don't know how to disable bonding sleeping since we use
> > > > > > mutex_lock now.
> > > > > > Hi Jianbo, do you have any idea?
> > > > > >
&
On Thu, Jan 09, 2025 at 09:26:38AM +0800, Jianbo Liu wrote:
>
>
> On 1/8/2025 3:14 PM, Hangbin Liu wrote:
> > On Wed, Jan 08, 2025 at 11:40:05AM +0800, Jianbo Liu wrote:
> > >
> > >
> > > On 1/8/2025 10:46 AM, Hangbin Liu wrote:
> > > >
On Mon, Jan 06, 2025 at 10:47:16AM +, Hangbin Liu wrote:
> On Thu, Jan 02, 2025 at 11:33:34AM +0800, Jianbo Liu wrote:
> > > > Re-locking doesn't look great, glancing at the code I don't see any
> > > > obvious better workarounds. Easiest fix would be to d
On Thu, Jan 09, 2025 at 05:51:07PM +0800, Jianbo Liu wrote:
> > > No, we don't need. But I am trying to understand what you said in your
> > > last
> > > email about adding a new lock, or unlocking spin lock in
> >
> > I *thought* we need the spin lock in xfrm_state_delete(). So to protect
> > x
del, add}_sa_all (Cosmin Ratiu)
use the defer helpers in lib.sh for selftest (Petr Machata)
v3: move the ipsec deletion to bond_ipsec_free_sa (Cosmin Ratiu)
v2: do not turn carrier on if bond change link failed (Nikolay Aleksandrov)
move the mutex lock to a work queue (Cosmin Ratiu)
Hangbi
Hi Jason, Phil,
On Wed, Mar 19, 2025 at 05:15:41PM +0100, Jason A. Donenfeld wrote:
> On Mon, Jan 06, 2025 at 08:10:43AM +0000, Hangbin Liu wrote:
> > + echo "file /bin/nft $(NFTABLES_PATH)/src/nft 755 0 0" >> $@
> > + echo "file /lib/libmnl.so.0 $(TOO
Hi Jason,
I saw the patch status[1] is still "Awaiting Upstream".
Is there anything I need to do?
https://patchwork.kernel.org/project/netdevbpf/patch/20250106081043.2073169-2-liuhang...@gmail.com/
Thanks
Hangbin
On Mon, Jan 06, 2025 at 08:10:41AM +0000, Hangbin Liu wrote:
> T
On Wed, Mar 19, 2025 at 05:11:15PM +0100, Jason A. Donenfeld wrote:
> On Tue, Mar 18, 2025 at 10:24:40AM +0000, Hangbin Liu wrote:
> > I saw the patch status[1] is still "Awaiting Upstream".
> > Is there anything I need to do?
>
> I'm looking at it now, but
On Fri, Mar 21, 2025 at 12:42:42PM +0100, Phil Sutter wrote:
> Hi Hangbin,
>
> On Fri, Mar 21, 2025 at 10:40:25AM +, Hangbin Liu wrote:
> > Hi Jason, Phil,
> > On Wed, Mar 19, 2025 at 05:15:41PM +0100, Jason A. Donenfeld wrote:
> > > On Mon, Jan 06, 2025 at 08:10
On Sun, Mar 23, 2025 at 10:10:33PM +0100, Phil Sutter wrote:
> On Sat, Mar 22, 2025 at 09:30:15AM +0000, Hangbin Liu wrote:
> > Convert iptabels to nft as it is the replacement for iptables, which is used
>
>
> Typo, but I would write "Convert the selft
update, just re-send
v3: drop iptables directly (Jason A. Donenfeld)
Also convert to using nft for qemu testing (Jason A. Donenfeld)
v2: use one nft table for testing (Phil Sutter)
Hangbin Liu (2):
wireguard: selftests: convert iptables to nft
wireguard: selftests: update to using nft for qemu
Convert the selftest to nft as it is the replacement for iptables, which
is used by default in most releases.
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/wireguard/netns.sh | 29 ++
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/tools/testing
Since we will replace iptables with nft for wireguard netns testing,
let's also convert the qemu test to use nft at the same time.
Co-developed-by: Phil Sutter
Signed-off-by: Phil Sutter
Signed-off-by: Hangbin Liu
---
.../testing/selftests/wireguard/qemu/Makefile
Hi Nikolay,
On Fri, Mar 07, 2025 at 09:42:49AM +0200, Nikolay Aleksandrov wrote:
> On 3/7/25 05:19, Hangbin Liu wrote:
> > The fixed commit placed mutex_lock() inside spin_lock_bh(), which triggers
> > a warning:
> >
> > BUG: sleeping function called from invalid cont
On Thu, Feb 27, 2025 at 03:31:01PM +0200, Nikolay Aleksandrov wrote:
> >> One more thing - note I'm not an xfrm expert by far but it seems to me
> >> here you have
> >> to also call xdo_dev_state_free() with the old active slave dev otherwise
> >> that will
> >> never get called with the origina
On Fri, Mar 07, 2025 at 10:33:57AM +0200, Nikolay Aleksandrov wrote:
> On 3/7/25 10:11, Hangbin Liu wrote:
> > Hi Nikolay,
> > On Fri, Mar 07, 2025 at 09:42:49AM +0200, Nikolay Aleksandrov wrote:
> >> On 3/7/25 05:19, Hangbin Liu wrote:
> >>> The fix
On Wed, Mar 05, 2025 at 04:12:18PM +, Cosmin Ratiu wrote:
> +++ b/drivers/net/bonding/bond_main.c
> @@ -613,8 +613,11 @@ static void bond_ipsec_del_sa_all(struct bonding
> *bond)
>
> mutex_lock(&bond->ipsec_lock);
> list_for_each_entry(ipsec, &bond->ipsec_list, list) {
> -
Jakub Kicinski
Closes: https://lore.kernel.org/netdev/20241212062734.182a0...@kernel.org
Suggested-by: Cosmin Ratiu
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_main.c | 69 -
1 file changed, 51 insertions(+), 18 deletions(-)
diff --git a/drivers/net/bonding/bon
On Thu, Mar 06, 2025 at 01:37:15PM +, Cosmin Ratiu wrote:
> On Thu, 2025-03-06 at 10:02 +0000, Hangbin Liu wrote:
> > > For bond_ipsec_add_sa_all(), I will move the xso.real_dev =
> > > real_dev
> > > after .xdo_dev_state_add() in case the following situation.
is the test result:
TEST: bond_ipsec_offload (active_slave eth0)[ OK ]
TEST: bond_ipsec_offload (active_slave eth1)[ OK ]
Reviewed-by: Petr Machata
Signed-off-by: Hangbin Liu
---
.../selftests/drivers/net/bonding/Makefile| 3 +-
.../drivers
registered first before changing the bond
link parameters. This change will allow the XFRM ESP offload feature to be
correctly enabled.
Fixes: 007ab5345545 ("bonding: fix feature flag setting at init time")
Signed-off-by: Hangbin Liu
---
drivers/net/bonding/bond_main.c| 2 +-
d
for selftest (Petr Machata)
v3: move the ipsec deletion to bond_ipsec_free_sa (Cosmin Ratiu)
v2: do not turn carrier on if bond change link failed (Nikolay Aleksandrov)
move the mutex lock to a work queue (Cosmin Ratiu)
Hangbin Liu (3):
bonding: move IPsec deletion to bond_ipsec_free_sa
bond
1 - 100 of 142 matches
Mail list logo
