On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote:
> > +static int ubifs_freeze_super(struct super_block *sb)
> > +{
> > + struct ubifs_info *c = sb->s_fs_info;
> > + int err;
> > +
> > + dbg_gen("starting");
> > + /* freeze_super always succeeds if file system is in read-on
Hi, Richard.
On Fri, May 26, 2017 at 11:52:42AM +0200, Richard Weinberger wrote:
> Hyunchul,
>
> Am 26.05.2017 um 01:30 schrieb Hyunchul Lee:
> > From: Hyunchul Lee
> >
> > for un/freeze support, implement freeze_super and un/freeze_fs
> > of super_operations.
Hi, Richard.
On Mon, May 29, 2017 at 09:43:46AM +0900, Hyunchul Lee wrote:
> On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote:
> > > +static int ubifs_freeze_super(struct super_block *sb)
> > > +{
> > > + struct ubifs_info *c =
and I missed the following case.
in some embedded systems, clean-up for shutdown should be fast.
during this clean-up, freeze file system to guarantee integrity.
umount with MNT_DETACH is not suitable because of not killing tasks.
On Mon, May 29, 2017 at 10:18:34AM +0900, Hyunchul Lee wrote
On Mon, May 29, 2017 at 10:42:37AM +0200, Richard Weinberger wrote:
> Hyunchul,
>
> Am 29.05.2017 um 04:24 schrieb Hyunchul Lee:
> >>> This is just broken. First ubifs should still properly propagate
> >>> the errors, and second freezing/unfreezing read only file
On 11/11/2017 09:38 AM, Chao Yu wrote:
> On 2017/11/9 13:51, Hyunchul Lee wrote:
>> From: Hyunchul Lee
>>
>> Select the type of the segment using write hints, when blocks are
>> allocated for direct write.
>>
>> There are unhandled corner cases. Hints are
On 11/10/2017 03:42 PM, Chao Yu wrote:
> On 2017/11/10 8:23, Hyunchul Lee wrote:
>> Hello, Chao
>>
>> On 11/09/2017 06:12 PM, Chao Yu wrote:
>>> On 2017/11/9 13:51, Hyunchul Lee wrote:
>>>> From: Hyunchul Lee
>>>>
>>>> Using
On 11/13/2017 10:26 AM, Chao Yu wrote:
> On 2017/11/13 8:24, Hyunchul Lee wrote:
>> On 11/10/2017 03:42 PM, Chao Yu wrote:
>>> On 2017/11/10 8:23, Hyunchul Lee wrote:
>>>> Hello, Chao
>>>>
>>>> On 11/09/2017 06:12 PM, Chao Yu wrote:
>
On 11/13/2017 10:24 AM, Chao Yu wrote:
> On 2017/11/13 8:07, Hyunchul Lee wrote:
>> On 11/11/2017 09:38 AM, Chao Yu wrote:
>>> On 2017/11/9 13:51, Hyunchul Lee wrote:
>>>> From: Hyunchul Lee
>>>>
>>>> Select the type of the segment using
On 11/13/2017 10:59 AM, Chao Yu wrote:
> On 2017/11/13 9:35, Hyunchul Lee wrote:
>> On 11/13/2017 10:26 AM, Chao Yu wrote:
>>> On 2017/11/13 8:24, Hyunchul Lee wrote:
>>>> On 11/10/2017 03:42 PM, Chao Yu wrote:
>>>>> On 2017/11/10 8:23, Hyunchul Lee wro
Hi Chao,
On 01/25/2018 12:32 AM, Chao Yu wrote:
> On 2018/1/22 18:49, Hyunchul Lee wrote:
>> From: Hyunchul Lee
>>
>> Add the 'whint_mode' mount option that controls which write
>> hints are passed down to block layer. There are "off" and
>>
On 01/25/2018 05:01 PM, Chao Yu wrote:
> Hi Hyunchul,
>
> On 2018/1/25 10:47, Hyunchul Lee wrote:
>> Hi Chao,
>>
>> On 01/25/2018 12:32 AM, Chao Yu wrote:
>>> On 2018/1/22 18:49, Hyunchul Lee wrote:
>>>> From: Hyunchul Lee
>>>>
>
From: Hyunchul Lee
Changes since version 1:
- Set 'whint_mode' to off if 'active_logs' is two or four
- Minor fixes suggested by Chao
This set implements passing down write hints to block layer with the
following mapping. This mapping equals the conclusion from discussio
From: Hyunchul Lee
Signed-off-by: Hyunchul Lee
---
Documentation/filesystems/f2fs.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/filesystems/f2fs.txt
b/Documentation/filesystems/f2fs.txt
index 13c2ff0..414a160 100644
--- a/Documentation/filesystems/f2fs.txt
+++ b
From: Hyunchul Lee
Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes
down write hints with its policy.
* whint_mode=fs-based. F2FS passes down hints with its policy.
User F2FS
From: Hyunchul Lee
Add the 'whint_mode' mount option that controls which write
hints are passed down to block layer. There are "off" and
"user-based" mode. The default mode is "off".
1) whint_mode=off. F2FS only passes down WRITE_LIFE_NOT_SET.
2) whint_
From: Hyunchul Lee
Add the 'whint_mode' mount option that controls which write
hints are passed down to block layer. There are "off" and
"user-based" mode. The default mode is "off".
1) whint_mode=user-based. F2FS tries to pass down hints giv
From: Hyunchul Lee
This set implements passing down write hints to block layer with the
following mapping. This mapping equals the conclusion from discussion in
the link, https://sourceforge.net/p/linux-f2fs/mailman/message/36170969/
But there are two exceptions. (1) the 'iohint_mode&#
From: Hyunchul Lee
Signed-off-by: Hyunchul Lee
---
Documentation/filesystems/f2fs.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/filesystems/f2fs.txt
b/Documentation/filesystems/f2fs.txt
index 13c2ff0..414a160 100644
--- a/Documentation/filesystems/f2fs.txt
+++ b
From: Hyunchul Lee
Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes
down write hints with its policy.
* whint_mode=fs-based. F2FS passes down hints with its policy.
User F2FS
On 01/26/2018 11:10 AM, Chao Yu wrote:
> On 2018/1/26 7:46, Hyunchul Lee wrote:
>> On 01/25/2018 05:01 PM, Chao Yu wrote:
>>> Hi Hyunchul,
>>>
>>> On 2018/1/25 10:47, Hyunchul Lee wrote:
>>>> Hi Chao,
>>>>
>>>> On 01/25/20
From: Hyunchul Lee
This patch adds nowait aio support[1].
Return EAGAIN if any of the following checks fail for direct I/O:
- i_rwsem is not lockable
- Blocks are not allocated at the write location
And xfstests generic/471 is passed.
[1]: 6be96d "Introduce RWF_NOWAI
From: Hyunchul Lee
This patch adds nowait aio support[1].
Return EAGAIN if any of the following checks fail for direct I/O:
- i_rwsem is not lockable
- Blocks are not allocated at the write location
And xfstests generic/471 is passed.
[1]: 6be96d "Introduce RWF_NOWAI
From: Hyunchul Lee
This patch adds nowait aio support[1].
Return EAGAIN if any of the following checks fail for direct I/O:
- i_rwsem is not lockable
- Blocks are not allocated at the write location
And xfstests generic/471 is passed.
[1]: 6be96d "Introduce RWF_NOWAI
if filename is encrypted, filename could have no printable characters.
so remove it.
Signed-off-by: Hyunchul Lee
---
fs/ubifs/dir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 528369f..b2c8beb 100644
--- a/fs/ubifs/dir.c
+++ b/fs
if a character is not printable, print '?' instead of that.
Signed-off-by: Hyunchul Lee
---
fs/ubifs/debug.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 1e712a36..b14c06f 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubi
instead of filenames, print inode numbers, file types, and length.
Signed-off-by: Hyunchul Lee
---
fs/ubifs/debug.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index b14c06f..718b749 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs
Richard,
this patch works well. but i found some trivial mistakes.
On Thu, Feb 09, 2017 at 10:28:35PM +0100, Richard Weinberger wrote:
> When removing an encrypted file with a long anem and without having
> the key we have to be able to locate and remove the directory entry
> via a double hash. T
Hi, Richard
On 03/03/2017 04:56 PM, Richard Weinberger wrote:
> Hyunchul Lee,
>
> Am 03.03.2017 um 08:44 schrieb Hyunchul Lee:
>> From: Hyunchul Lee
>>
>> When write syscall is called, every time security label is searched to
>> determine that file's p
From: Hyunchul Lee
When write syscall is called, every time security label is searched to
determine that file's privileges should be changed.
If LSM(Linux Security Model) is not used, this is useless.
So introduce CONFIG_UBIFS_SECURITY to disable security labels. it's default
v
Hello Sedat,
For v1.0.3 and later releases, we can provide tar.xz tarballs, hashes
and detached signatures.
But is there a reason why hashes are required despite the signature?
We will let you know when it's done.
Thanks.
Regards,
Hyunchul
2020년 6월 30일 (화) 오후 7:16, Sedat Dilek 님이 작성:
>
> On Tu
Allow to change permission masks, allow_utime,
errors. But ignore other options.
Signed-off-by: Hyunchul Lee
---
fs/exfat/super.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 61c6cf240c19
We need to commit dirty metadata and pages to disk
before remounting exfat as read-only.
This fixes a failure in xfstests generic/452
Signed-off-by: Hyunchul Lee
---
fs/exfat/super.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
device.
I will put this explanation in a commit message.
> >
> > Signed-off-by: Hyunchul Lee
> > ---
> > fs/exfat/super.c | 19 +++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> >
2020년 6월 15일 (월) 오전 9:18, Namjae Jeon 님이 작성:
>
> > Allow to change permission masks, allow_utime, errors. But ignore other
> > options.
> >
> > Signed-off-by: Hyunchul Lee
> > ---
> > fs/exfat/super.c | 40 +---
&g
x27;t
have a chance to commit metadata and
vfs invalidates page caches in a block device.
Signed-off-by: Hyunchul Lee
---
Changes from v1:
- Does not check the return value of sync_filesystem to
allow to change from "rw" to "ro" even when this function
fails.
- Add the detaile
Hi Richard
I found a mistake in this patch.
On Thu, Dec 01, 2016 at 11:02:19PM +0100, Richard Weinberger wrote:
> The new feature UBIFS_FLG_PARENTPOINTER allows looking
> up the parent. Usually the Linux VFS walks down the filesystem
> and no parent pointers are needed. But when a filesystem
> is
Richard,
On Thu, Mar 30, 2017 at 10:56:21AM +0200, Richard Weinberger wrote:
> It is perfectly fine to link a tmpfile back using linkat().
> Since tmpfiles are created with a link count of 0 they appear
> on the orphan list, upon re-linking the inode has to be removed
> from the orphan list again.
From: Hyunchul Lee
for un/freeze support, implement freeze_super and un/freeze_fs
of super_operations.
ubifs_freeze_super just calls freeze_super. because freeze_super always
succeeds if file system is read-only, UBIFS errors should be checked.
if there are errors, UBIFS is switched to read
On 11/16/2017 01:27 AM, Jaegeuk Kim wrote:
> On 11/14, Chao Yu wrote:
>> On 2017/11/14 12:20, Jaegeuk Kim wrote:
>>> On 11/13, Hyunchul Lee wrote:
>>>> On 11/13/2017 10:59 AM, Chao Yu wrote:
>>>>> On 2017/11/13 9:35, Hyunchul Lee wrote:
>>>
On 11/16/2017 12:58 PM, Jaegeuk Kim wrote:
> On 11/16, Chao Yu wrote:
>> On 2017/11/16 8:56, Hyunchul Lee wrote:
>>>
>>> On 11/16/2017 01:27 AM, Jaegeuk Kim wrote:
>>>> On 11/14, Chao Yu wrote:
>>>>> On 2017/11/14 12:20, Jaegeuk Kim wrote:
>
for users, and LIFE_SHORT and LIFE_EXTREME is converted to different
hints by F2FS.
Thanks.
On 12/12/2017 11:45 AM, Chao Yu wrote:
> Hi Hyunchul,
>
> On 2017/12/12 10:15, Hyunchul Lee wrote:
>> Hi Chao,
>>
>> On 12/11/2017 10:15 PM, Chao Yu wrote:
>>> Hi
Hi Jaegeuk,
On 12/28/2017 12:26 PM, Jaegeuk Kim wrote:
> On 12/23, Chao Yu wrote:
>> On 2017/12/15 10:06, Jaegeuk Kim wrote:
>>> On 12/14, Hyunchul Lee wrote:
>>>> Hi Jaegeuk,
>>>>
>>>> I need your comment about the fs_iohint mount option.
&
Hi Jaegeuk,
Agreed. If Chao agrees with this policy, I will implement it.
Thanks for the comment.
On 12/15/2017 11:06 AM, Jaegeuk Kim wrote:
> On 12/14, Hyunchul Lee wrote:
>> Hi Jaegeuk,
>>
>> I need your comment about the fs_iohint mount option.
>>
>> a) w/o f
Hi Chao,
On 12/11/2017 10:15 PM, Chao Yu wrote:
> Hi Hyunchul,
>
> On 2017/12/1 16:28, Hyunchul Lee wrote:
>> Hi Chao,
>>
>> On 11/30/2017 04:06 PM, Chao Yu wrote:
>>> Hi Hyunchul,
>>>
>>> On 2017/11/28 8:23, Hyunchul Lee wrote:
>>&g
Assign inode data budget to budget request correctly.
Signed-off-by: Hyunchul Lee
---
fs/ubifs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index b777bdd..df67236 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1050,7 +1050,6
in RENAME_WHITEOUT error path, fscrypt_name should be freed.
Signed-off-by: Hyunchul Lee
---
fs/ubifs/dir.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index df67236..0d5f8e7 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
Hi Richard,
On Sun, May 21, 2017 at 10:20:49PM +0200, Richard Weinberger wrote:
> The new feature UBIFS_FLG_PARENTPOINTER allows looking
> up the parent. Usually the Linux VFS walks down the filesystem
> and no parent pointers are needed. But when a filesystem
> is exportable via NFS such a lookup
Hi Richard,
On Mon, May 22, 2017 at 10:45:08AM +0200, Richard Weinberger wrote:
> Hyunchul,
>
> Am 22.05.2017 um 06:30 schrieb Hyunchul Lee:
> >> + if (move)
> >> + old_inode_ui->parent_inum = new_dir->i_ino;
> >> +
> >>err = ubifs
From: Hyunchul Lee
Use readahead_gfp_mask for gfp flags when allocating pages.
This set additional flags which are __GFP_NORETRY and
__GFP_NOWARN. So OOMs and a failure message can be
avoided.
And we should remove __GFP_FS from flags to prevent from
calling ubifs_writepage during page reclaim
From: Hyunchul Lee
In low memory situations, page allocations for bulk read
can kill applications for reclaiming memory, and print an
failure message when allocations are failed.
Because bulk read is just an optimization, we don't have
to do these and can stop page allocations.
Though
From: Hyunchul Lee
In low memory situations, page allocations for bulk read
can kill applications for reclaiming memory, and print an
failure message when allocations are failed.
Because bulk read is just an optimization, we don't have
to do these and can stop page allocations.
Though
From: Hyunchul Lee
When erase count and volume identifier headers are read,
ubi_io_is_bad is called. So instead of calling ubi_io_is_bad
from scan_peb, use the result.
this patch reduces the attach time by about 15% in my
environment.
ARMv7 1GHZ based board, 66.8MiB MTD partition
From: Hyunchul Lee
This implements which hint is passed down to block layer
for datas from the specific segment type.
segment type hints
-
COLD_NODE & COLD_DATAWRITE_LIFE_EXTREME
WARM_
From: Hyunchul Lee
When blocks are allocated for direct write, select the type of
segment using the kiocb hint. But if an inode has FI_NO_ALLOC,
use the inode hint.
Signed-off-by: Hyunchul Lee
---
v2:
- Add a new member, m_seg_type to struct f2fs_map_blocks.
- Assign the segment type to
From: Hyunchul Lee
This implements which hint is passed down to block layer
for direct write.
(allocated
file hintsegment type) io hint
--
WRITE_LIFE_SHORT HOT_DATAWRITE_LIFE_MEDIUM
WRITE_LIFE_EXTREME
Hi Chao,
On 11/30/2017 04:06 PM, Chao Yu wrote:
> Hi Hyunchul,
>
> On 2017/11/28 8:23, Hyunchul Lee wrote:
>> From: Hyunchul Lee
>>
>> This implements which hint is passed down to block layer
>> for datas from the specific segment type.
>>
&g
Hi Jaegeuk,
On 12/01/2017 04:28 PM, Jaegeuk Kim wrote:
> On 11/30, Chao Yu wrote:
>> On 2017/11/28 8:23, Hyunchul Lee wrote:
>>> From: Hyunchul Lee
>>>
>>> This implements which hint is passed down to block layer
>>> for datas from th
From: Hyunchul Lee
Using write hints[1], applications can inform the life time of the data
written to devices. and this[2] reported that the write hints patch
decreased writes in NAND by 25%.
This hints help F2FS to determine the followings.
1) the segment types where the data will be written
From: Hyunchul Lee
Write hints helps F2FS to determine which type of segments would be
selected for buffered write.
This patch implements the mapping from write hints to segment types
as shown below.
hints segment type
-
WRITE_LIFE_SHORT
From: Hyunchul Lee
Select the type of the segment using write hints, when blocks are
allocated for direct write.
There are unhandled corner cases. Hints are not applied in
in-place update. And if the blocks of a file is not pre-allocated
because of the invalid user buffer, CURSEG_WARM_DATA
Hello, Chao
On 11/09/2017 06:12 PM, Chao Yu wrote:
> On 2017/11/9 13:51, Hyunchul Lee wrote:
>> From: Hyunchul Lee
>>
>> Using write hints[1], applications can inform the life time of the data
>> written to devices. and this[2] reported that the write hints patch
>
On 11/18/2017 03:53 AM, Jaegeuk Kim wrote:
> ...
>>>>>>>>>>>>>>>>> From: Hyunchul Lee
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Using write hi
63 matches
Mail list logo
