/ni_65xx.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
These have since been reposted by Ravi in a different order and one
minor correction, so can be scrapped, I guess.
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
These have since been reposted by Ravi in a different order and one
minor correction, so can be scrapped, I guess.
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
s626.h | 356 ++
1 file changed, 237 insertions(+), 119 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
++
1 file changed, 237 insertions(+), 119 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
t; 4)
+#define DMM32AT_AI_CFG_SCINT_15US BIT(4)
#define DMM32AT_AI_CFG_SCINT_10US (2 << 4)
#define DMM32AT_AI_CFG_SCINT_5US (3 << 4)
The same thing here.
[snip]
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
2AT_AI_CFG_SCINT_20US (0 << 4)
-#define DMM32AT_AI_CFG_SCINT_15US (1 << 4)
+#define DMM32AT_AI_CFG_SCINT_15US BIT(4)
#define DMM32AT_AI_CFG_SCINT_10US (2 << 4)
#define DMM32AT_AI_CFG_SCINT_5US (3 << 4)
The same thing here.
[
s800.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
das800.c | 102
1 file changed, 51 insertions(+), 51 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
1 file changed, 51 insertions(+), 51 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
atches
+ */
static inline int timer_period(void)
{
return HZ / 20;
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
timer_period(void)
{
return HZ / 20;
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/comedi_bond.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
It looks fine, apart from the typo on the patch subject line ("Preferd"
should be "Prefer").
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Ab
/drivers/comedi_bond.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
It looks fine, apart from the typo on the patch subject line ("Preferd"
should be "Prefer").
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=(
com>
---
drivers/staging/comedi/drivers/das16m1.c | 168 ---
1 file changed, 89 insertions(+), 79 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
/drivers/das16m1.c | 168 ---
1 file changed, 89 insertions(+), 79 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/jr3_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/jr3_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
(1 << 7)
+#define DAS6402_MODE_DMA3 BIT(7)
Similarly, DAS6402_MODE_DMA1 and DAS6402_MODE_DMA3 should be defined in
the same style, perhaps something like this:
#define DAS6402_MODE_DMA(x) ((x) << 7)
#define DAS6402_MODE_DMA1 DAS640
E_DMA(x) ((x) << 7)
#define DAS6402_MODE_DMA1 DAS6402_MODE_DMA(0)
#define DAS6402_MODE_DMA3 DAS6402_MODE_DMA(1)
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
<ravishankark...@gmail.com>
---
drivers/staging/comedi/drivers/das16.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk>
On 01/06/16 11:26, Ravishankar Karkala Mallikarjunayya wrote:
This patch Replace all occurences of (1<
---
drivers/staging/comedi/drivers/das16.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abb
com>
---
drivers/staging/comedi/drivers/jr3_pci.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
/drivers/jr3_pci.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/me_daq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/me_daq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
rivers/staging/comedi/drivers/mpc624.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
com>
---
drivers/staging/comedi/drivers/ni_65xx.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/ni_65xx.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ggered)
+ unsigned int triggered)
{
struct pcmuio_private *devpriv = dev->private;
int asic = pcmuio_subdevice_to_asic(s);
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
triggered)
{
struct pcmuio_private *devpriv = dev->private;
int asic = pcmuio_subdevice_to_asic(s);
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ADDI_TCW_CTRL_IRQ_ENA);
The patch looks fine (although this odd-ball Comedi driver shouldn't
really be sending signals to a user-space task!).
Is this really PATCH 2649/2649?
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk&
h looks fine (although this odd-ball Comedi driver shouldn't
really be sending signals to a user-space task!).
Is this really PATCH 2649/2649?
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
On 31/05/16 18:07, Joe Perches wrote:
On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote:
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the s626.c file that fixes up a type issues like
i.e Prefer kernel type 'u8' over 'uint8_t'
Prefer kernel type 'u16
On 31/05/16 18:07, Joe Perches wrote:
On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote:
On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
This is a patch to the s626.c file that fixes up a type issues like
i.e Prefer kernel type 'u8' over 'uint8_t'
Prefer kernel type 'u16
change
---
drivers/staging/comedi/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
hanges since v1: No change
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
ark...@gmail.com>
---
changes since v1: No change
---
drivers/staging/comedi/drivers/s626.c | 60 +++
1 file changed, 40 insertions(+), 20 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <ab
v1: No change
---
drivers/staging/comedi/drivers/s626.c | 60 +++
1 file changed, 40 insertions(+), 20 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
viewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
deletions(-)
Thanks. It would have been nice if the checkpatch.pl tool detected
_all_ the instances of these types. As a result of this patch, s626.c
contains a mixture of the different integer type styles. I guess we can
fix that up later though.
Reviewed-by: Ian Abbott
--
-=( Ian
On 23/05/16 12:15, Mark Brown wrote:
On Sat, May 21, 2016 at 09:50:35AM -0700, Dmitry Torokhov wrote:
On Mon, Mar 23, 2015 at 10:50 AM, Ian Abbott <abbo...@mev.co.uk> wrote:
`spidev_message()` sums the lengths of the individual SPI transfers to
determine the overall SPI message
On 23/05/16 12:15, Mark Brown wrote:
On Sat, May 21, 2016 at 09:50:35AM -0700, Dmitry Torokhov wrote:
On Mon, Mar 23, 2015 at 10:50 AM, Ian Abbott wrote:
`spidev_message()` sums the lengths of the individual SPI transfers to
determine the overall SPI message length. It restricts the total
On 20/05/16 18:52, Hartley Sweeten wrote:
On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote:
On 20/05/16 17:37, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
"plx9080.h", using
On 20/05/16 18:52, Hartley Sweeten wrote:
On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote:
On 20/05/16 17:37, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
"plx9080.h", using
On 21/05/16 17:50, Dmitry Torokhov wrote:
On Mon, Mar 23, 2015 at 10:50 AM, Ian Abbott <abbo...@mev.co.uk> wrote:
`spidev_message()` sums the lengths of the individual SPI transfers to
determine the overall SPI message length. It restricts the total
length, returning an error if to
On 21/05/16 17:50, Dmitry Torokhov wrote:
On Mon, Mar 23, 2015 at 10:50 AM, Ian Abbott wrote:
`spidev_message()` sums the lengths of the individual SPI transfers to
determine the overall SPI message length. It restricts the total
length, returning an error if too long, but it does not check
On 20/05/16 17:37, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
"plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)`
and `GENMASK(h,l)` macros to define the value
On 20/05/16 17:37, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
"plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)`
and `GENMASK(h,l)` macros to define the value
On 20/05/16 17:21, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros in "plx9080.h" that define the offsets of registers,
following the pattern `PLX_REG_`, where `` is the register
name from the PLX PCI 9080 Data Book.
Add defines for th
On 20/05/16 17:21, Hartley Sweeten wrote:
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
Rename the macros in "plx9080.h" that define the offsets of registers,
following the pattern `PLX_REG_`, where `` is the register
name from the PLX PCI 9080 Data Book.
Add defines for th
I/O space. Change its value from `0xfffa` to `0xfffc`
to match `LRNG_IO_MASK`.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b
I/O space. Change its value from `0xfffa` to `0xfffc`
to match `LRNG_IO_MASK`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b/drivers/staging/comedi/drive
MA control registers. Make use of
the parameterized versions of the macros where it seems appropriate.
The registers for supporting the I2O (Intelligent Input/Output) feature
are largely left undefined, just defining enough to allow the I2O
feature to be disabled.
Signed-off-by: Ian Abbot
MA control registers. Make use of
the parameterized versions of the macros where it seems appropriate.
The registers for supporting the I2O (Intelligent Input/Output) feature
are largely left undefined, just defining enough to allow the I2O
feature to be disabled.
Signed-off-by: Ian Abbott
---
dr
Replace the existing macros in "plx9080.h" that define values for the
LAS0BA and LAS1BA registers. Use the prefix `PLX_LASBA_` for the
macros. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the macros.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
driver
Replace the existing macros in "plx9080.h" that define values for the
LAS0BA and LAS1BA registers. Use the prefix `PLX_LASBA_` for the
macros. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the macros.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_
1
register. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 80 ++--
1 file changed, 56 insertions(+), 24 deletions(-)
diff --git a/drivers/stagin
1
register. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 80 ++--
1 file changed, 56 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 60 +---
1 file changed, 40 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b/drivers/staging/comedi/drivers
to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 60 +---
1 file changed, 40 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b/drivers/staging/comedi/drivers/plx9080.h
index 140135c..0bcd
Replace the existing macros in "plx9080.h" that define values for the
DMPBAM register. Use the prefix `PLX_DMPBAM_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi
Replace the existing macros in "plx9080.h" that define values for the
DMPBAM register. Use the prefix `PLX_DMPBAM_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9
For the PLX PCI 9080, the read-only PCIHIDR register is hard-coded with
the value `0x908010b5`. Add a macro `PLX_PCIHIDR_9080` that expands to
this value.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 3 +++
1 file changed, 3 insertions(+)
Replace the existing macros in "plx9080.h" that define values for the
DMAMODE0 and DMAMODE1 registers. Use the prefix `PLX_DMAMODE_` for the
macros. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
driver
Replace the existing macros in "plx9080.h" that define values for the
INTCSR register. Use the prefix `PLX_INTCSR_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/stagin
Replace the existing macros in "plx9080.h" that define values for the
CNTRL register. Use the prefix `PLX_CNTRL_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/stagin
Replace `enum bigend_bits` in "plx9080.h" with a bunch of macros
defining values for the BIGEND register. Use the prefix `PLX_BIGEND_`
for the macro names. Make use of the `BIT(x)` and `GENMASK(h,l)` macros
to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
For the PLX PCI 9080, the read-only PCIHIDR register is hard-coded with
the value `0x908010b5`. Add a macro `PLX_PCIHIDR_9080` that expands to
this value.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
Replace the existing macros in "plx9080.h" that define values for the
DMAMODE0 and DMAMODE1 registers. Use the prefix `PLX_DMAMODE_` for the
macros. Make use of the `BIT(x)` and `GENMASK(h,l)` macros to define
the values.
Signed-off-by: Ian Abbott
---
drivers/staging/come
Replace the existing macros in "plx9080.h" that define values for the
INTCSR register. Use the prefix `PLX_INTCSR_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcida
Replace the existing macros in "plx9080.h" that define values for the
CNTRL register. Use the prefix `PLX_CNTRL_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcida
Replace `enum bigend_bits` in "plx9080.h" with a bunch of macros
defining values for the BIGEND register. Use the prefix `PLX_BIGEND_`
for the macro names. Make use of the `BIT(x)` and `GENMASK(h,l)` macros
to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/come
Add macros in "plx9080.h" that define values for the DMATHR register
values. Use the prefix `PLX_DMATHR_` for the macros. Make use of the
`BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/driver
Add macros in "plx9080.h" that define values for the DMATHR register
values. Use the prefix `PLX_DMATHR_` for the macros. Make use of the
`BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9
Add `#include` lines to declare stuff used by "plx9080.h" itself.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b/drivers/stagin
Use the usual block comment style and remove some excess spaces from
single-line comments. Remove some obvious stuff about register offsets
being zero relative. Remove some text about the original history of the
file, as it bears hardly any resemblance to it now.
Signed-off-by: Ian Abbott <a
Replace the existing macros in "plx9080.h" that define values for the
DMACSR0 and DMACSR0 registers. Use the prefix `PLX_DMACSR_` for the
macros. Make use of the `BIT(x)` macro to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drive
Document the DMA descriptor `struct plx_dma_desc`, and the DMA abort
function `plx9080_abort_dma()`.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/plx9080.h | 35 ++--
1 file changed, 29 insertions(+), 6 deletions(-)
diff
Add `#include` lines to declare stuff used by "plx9080.h" itself.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/comedi/drivers/plx9080.h
b/drivers/staging/comedi/drivers/plx9080.h
ind
Use the usual block comment style and remove some excess spaces from
single-line comments. Remove some obvious stuff about register offsets
being zero relative. Remove some text about the original history of the
file, as it bears hardly any resemblance to it now.
Signed-off-by: Ian Abbott
Replace the existing macros in "plx9080.h" that define values for the
DMACSR0 and DMACSR0 registers. Use the prefix `PLX_DMACSR_` for the
macros. Make use of the `BIT(x)` macro to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcida
Document the DMA descriptor `struct plx_dma_desc`, and the DMA abort
function `plx9080_abort_dma()`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9080.h | 35 ++--
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
Replace the existing macros in "plx9080.h" that define values for the
DMCFGA register. Use the prefix `PLX_DMCFGA_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi
Replace the existing macros in "plx9080.h" that define values for the
DMCFGA register. Use the prefix `PLX_DMCFGA_` for the macros. Make use
of the `BIT(x)` and `GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/plx9
The defines related to the Power-Up Test Suite (PUTS) are just cruft that
has nothing to do with the PLX PCI-9080 chip. They seem to have been
inherited from "drivers/net/plx9060.h" in the kernel 2.2.16 sources for
use by the "wanxl" driver. Remove them.
Signed-off-
`GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 22 +++---
drivers/staging/comedi/drivers/gsc_hpdi.c| 8
drivers/staging/comedi/drivers/plx9080.h | 17 ++
The defines related to the Power-Up Test Suite (PUTS) are just cruft that
has nothing to do with the PLX PCI-9080 chip. They seem to have been
inherited from "drivers/net/plx9060.h" in the kernel 2.2.16 sources for
use by the "wanxl" driver. Remove them.
Signed-off-by: Ian
`GENMASK(h,l)` macros to define the values.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 22 +++---
drivers/staging/comedi/drivers/gsc_hpdi.c| 8
drivers/staging/comedi/drivers/plx9080.h | 17 ++---
3 files changed, 25
, and define a macro `PLX_LASRR_MLOC_MASK` to mask the PCI
memory location control bits.
Signed-off-by: Ian Abbott <abbo...@mev.co.uk>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 ++--
drivers/staging/comedi/drivers/plx9080.h | 18 ++
2 files changed, 12 insertions
Re-do "drivers/staging/comedi/drivers/plx9080.h". It mostly contains
defines for register offsets and values for the PLX PCI 9080 PCI
interface chip. To make it easier to follow, base the macro names for
register offsets on the register names from the PLX PCI 9080 data book.
Base the macro names
Re-do "drivers/staging/comedi/drivers/plx9080.h". It mostly contains
defines for register offsets and values for the PLX PCI 9080 PCI
interface chip. To make it easier to follow, base the macro names for
register offsets on the register names from the PLX PCI 9080 data book.
Base the macro names
, and define a macro `PLX_LASRR_MLOC_MASK` to mask the PCI
memory location control bits.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 ++--
drivers/staging/comedi/drivers/plx9080.h | 18 ++
2 files changed, 12 insertions(+), 10 deletions(-)
hanges since V1:
- No change
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=(
change
---
drivers/staging/comedi/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Thanks!
Reviewed-by: Ian Abbott <abbo...@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Ian Abbott
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
401 - 500 of 2849 matches
Mail list logo
