As preparation for removal of comedi_fc.h, replace calls to the
`cfc_check_trigger_...` functions from comedi_fc.h with the
replacement `comedi_check_trigger_...` functions from ../comedidev.h
and remove the inclusion of comedi_fc.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
As preparation for removal of comedi_fc.h, replace calls to the
`cfc_check_trigger_...` functions from comedi_fc.h with the
replacement `comedi_check_trigger_...` functions from ../comedidev.h
and remove the inclusion of comedi_fc.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
As preparation for removal of comedi_fc.h, replace calls to the
`cfc_check_trigger_...` functions from comedi_fc.h with the
replacement `comedi_check_trigger_...` functions from ../comedidev.h
and remove the inclusion of comedi_fc.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
ni_labpc_isadma.c doesn't use anything from comedi_fc.h.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_labpc_isadma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_labpc_isadma.c
b/drivers/staging/comedi/drivers
On 23/03/15 18:50, Mark Brown wrote:
On Mon, Mar 23, 2015 at 05:50:27PM +, Ian Abbott wrote:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
Cc: sta...@vger.kernel.org # 4.0+
This doesn't apply against Linus' tree as far as I can tell - if you
think this needs to go to stable please send
Add a new header that Comedi PCMCIA drivers can include instead of
comedidev.h. Currently, it just pulls in pcmcia/cistpl.h,
pcmcia/ds.h and comedidev.h, but the plan is to migrate the
PCMCIA-specific stuff from comedidev.h here.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging
there is a -Wunused-function warning for the get_min_full_scales()
function definition. The function can be removed.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/cisreg.h, pcmcia/ds.h and
../comedidev.h. pcmcia/cisreg.h isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/ds.h and ../comedidev.h, which will now
get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_mio_cs.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/cisreg.h, pcmcia/ds.h and
../comedidev.h. pcmcia/cisreg.h isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_labpc_cs.c | 6
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/ds.h and ../comedidev.h, which will now
get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_daq_700.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
Move the PCMCIA-specific stuff out of comedidev.h into
comedi_pcmcia.h. Comedi PCMCIA drivers now include comedi_pcmcia.h
instead of comedidev.h, which now gets pulled in indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_pcmcia.h | 28
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/cisreg.h, pcmcia/ds.h and
../comedidev.h. pcmcia/cisreg.h isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/ds.h and ../comedidev.h, which will now
get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 5 +
1 file changed, 1 insertion(+), 4 deletions
insn-n; n++) {
That part is good.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
Include the new comedi_pcmcia.h header instead of pcmcia/cistpl.h,
pcmcia/ds.h and comedidev.h, which will now get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_pcmcia.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Include the new ../comedi_pcmcia.h header instead of
pcmcia/cistpl.h, pcmcia/ds.h and ../comedidev.h, which will now
get included indirectly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08_cs.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
comedidev.h includes PCMCIA-specific stuff that gets included by all
comedi drivers including non-PCMCIA ones. Separate it out into its own
header comedi_pcmcia.h. Make the new header include
pcmcia/cistpl.h, pcmcia/ds.h and comedidev.h so that comedi PCMCIA
drivers do not need to include them
readl(mite-mite_io_addr + MITE_TCR(mite_chan-channel));
}
EXPORT_SYMBOL_GPL(mite_dma_tcr);
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send
1);
outl(ul_Command1, dev-iobase + APCI3501_TIMER_CTRL_REG);
- i_temp = inl(dev-iobase + APCI3501_TIMER_STATUS_REG) 0x1;
+ inl(dev-iobase + APCI3501_TIMER_STATUS_REG);
return IRQ_HANDLED;
}
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd
+ APCI3501_TIMER_STATUS_REG);
return insn-n;
}
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On 30/01/15 12:10, Dan Carpenter wrote:
On Fri, Jan 30, 2015 at 10:29:44AM +, Ian Abbott wrote:
@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
ul_Command1 = inl(dev-iobase + APCI3501_TIMER_CTRL_REG);
ul_Command1 = ((ul_Command1 0xF9FDul) | 1
*/
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
-ai_count = 0; /* stop and don't transfer any more */
- status = readw(dev-mmio + LAS0_IT);
- overrun = readl(dev-mmio + LAS0_OVERRUN) 0x;
writel(0, dev-mmio + LAS0_ADC_FIFO_CLEAR);
return 0;
}
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott
buffer before it reaches an
invalid user memory address. Fix it by checking that neither the total
nor the individual transfer lengths exceed the maximum allowed value.
Thanks to Dan Carpenter for reporting the potential integer overflow.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
Cc: sta
already been done for some comedi drivers.
Thanks,
Ian A.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Keep the details of the comedi subdevice `runflags` member local to
comedi_fops.c. In particular, the usage of the
`COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
with the others. It's used as a marker to indicate the subdevice's
`private` pointer can be automatically freed
The `COMEDI_SRF_...` macros define flag combinations in the `runflags`
member of `struct comedi_subdevice`. They are only used directly in
comedi_fops.c, so move them to there.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_fops.c | 17 +
drivers
module.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedi_fops.c | 24 --
drivers/staging/comedi/comedi_internal.h | 1 +
drivers/staging/comedi/comedidev.h | 1 +
drivers/staging/comedi/drivers.c
The definition of the macro `USE_KMALLOC` is commented out, and nothing
refers to it. Remove the commented out macro.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index b514ad1..fa7ae2c 100644
--- a/drivers/staging/comedi
Reformat some function declarations to avoid bunching up near column 80.
Also add a blank line after a `struct` definition.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 59 ++-
1 file changed, 30 insertions(+), 29 deletions(-)
diff --git a/drivers
Use the usual style for block comments. Squash double spaces after
comment opening sequences.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 105 +-
1 file changed, 54 insertions(+), 51 deletions(-)
diff --git a/drivers
1) staging: comedi: mite: move #include linux/slab.h
2) staging: comedi: mite.h: remove PCIMIO_COMPAT
3) staging: comedi: mite.c: remove commented out USE_KMALLOC
4) staging: comedi: mite.h: remove ../comedi_pci.h and make
self-reliant
5) staging: comedi: mite.h: reformat some comments
6)
The Comedi driver modules build fine if the inclusion of linux/slab.h
is removed from mite.h, so remove it. However, since mite.c calls
`kzalloc()`, include linux/slab.h there.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.c | 1 +
drivers/staging/comedi
The macro `PCIMIO_COMPAT` is defined, but never used. Remove it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.h
b/drivers/staging/comedi/drivers/mite.h
index
other includes and (incomplete) `struct` declarations to make it compile
without warnings or errors even when included first in a .c file.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/mite.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
, 98 insertions(+), 98 deletions(-)
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
if (channel 4)
return 1 channel;
So, yes.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
literal and ends
up getting assigned to `dev-board_name`.
Get rid of the multiple board type support, and set `dev-board_name` to
point to the original string literal pointed to by
`hpdi_boards[0].name`. This string is visible to userspace.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c
b/drivers/staging/comedi/drivers/gsc_hpdi.c
index 51ab801..e929618 100644
--- a/drivers/staging
Use the `PCI_DEVICE_SUB()` macro in the initializer of the PCI module
device table `gsc_hpdi_pci_table[]`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi
Fix all the checkpatch issues CHECK: Prefer using the BIT macro.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 82 +++
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Use the usual style for block comments. Squash double spaces after
comment opening sequence. Move some comments after opening braces to
following line.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 59 ++-
1 file changed
Simplify (eliminate) the board type matching code, since only a single
board type is supported. Reformat the comments. Fix the checkpatch
issues. Use a better module description string.
1) staging: comedi: gsc_hpdi: tidy up comments
2) staging: comedi: gsc_hpdi: remove multiple board type
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt. `udelay()` is only called once
from a place where sleeping is allowed. Replace it with a call to
`usleep_range()` with a reasonable upper limit.
Signed-off-by: Ian Abbott abbo
-start_arg) +
Thanks. The patch is fine, but Hartley has already sent the same fix to
de...@linuxdriverproject.org, and Greg was intending to apply that one.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe
: unhandled register=0x%x\n,
__func__, reg);
return 0;
}
Apart from that niggle, the patch looks good!
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
of the */ characters), so I had to split them over several
lines.
yes, i noticed. its almost 84 char. but after applying your patch also
it comes to 81.
Really? I only see 80 characters.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
)
+*/
devpriv-i2c_cal_range_bits = adc_src_4020_bits(4);
/* set channels to +-5 volt input ranges */
for (i = 0; i s-n_chan; i++)
Looks good.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
master clock by dividing by (x + 3) where x is
+ * 24 bit number
*/
static void check_adc_timing(struct comedi_device *dev, struct comedi_cmd
*cmd)
{
Looks good.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
Replace the boiler-plate Comedi module description string with something
more specific.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers
`das08_do_wbits()` and `das08jr_do_wbits()` are handlers for the Comedi
`INSN_BITS` instruction for the digital output subdevice on non-JR and
JR boards, respectively. Rename them to `das08_do_insn_bits()` and
`das08jr_do_insn_bits()` respectively for consistency.
Signed-off-by: Ian Abbott abbo
`das08_di_rbits()` and `das08jr_di_rbits()` are handlers for the Comedi
`INSN_BITS` instruction for the digital input subdevice on non-JR and
JR boards, respectively. Rename them to `das08_di_insn_bits()` and
`das08jr_di_insn_bits()` respectively for consistency.
Signed-off-by: Ian Abbott abbo
`das08_ai_rinsn()` is the handler for Comedi `INSN_READ` instructions
for the AI subdevice. Rename the function to `das08_ai_insn_read()` for
consistency.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 7 ---
1 file changed, 4 insertions(+), 3
The `range_das08_pgl`, `range_das08_pgm`, and `range_das08_pgh`
variables define the analog input ranges for the PGL, PGM, and PGH
board variants, and are also used for the AOL, AOM, and AOH board
variants. Rename them to use the `das08_` prefix for consistency.
Signed-off-by: Ian Abbott abbo
, add a macro
`DAS08JR_AO_UPDATE_REG` with the same value as the `DAS08JR_DI_REG`
macro (for digital inputs) and use it when reading the register to
update the analog outputs.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 7 ++-
1 file changed, 6
The `DAS08_STATUS` macro contains the offset to the read-only status
register. Rename it to `DAS08_STATUS_REG` and add a comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
. Also make use of the `BIT()` macro to define the value.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
The `DAS08_TRIG_12BIT` macro contains the offset to the write-only
software trigger register for 12-bit or 16-bit analog-to-digital
conversions. Rename the macro to `DAS08_AI_TRIG_REG` and add a comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 4
Reformat remaining comments to use the preferred style for single-line
and block comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.h
b
The `DAS08_LSB` and `DAS08_MSB` macros contain the offsets to the
least-significant and most-significant analog input data registers.
Rename them to `DAS08_AI_LSB_REG` and `DAS08_AI_MSB_REG` respectively
and add comments to document them.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
/PCI/PCMCIA drivers).
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das08.h
b/drivers/staging/comedi/drivers/das08.h
index 57c7640..388855e 100644
. Rename the macro to `DAS08_STATUS_IRQ` and add a comment.
Also use the `BIT()` macro to define the value.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers
Replace double spaces with single spaces at the start of each line in
the copyright comment at the top of the file.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff
.
The `DAS08AO_AO_UPDATE` macro contains the offset to the low byte
register for analog output channel 0 on the AOL, AOM, and AOH
boards, which the driver reads to update the analog outputs. Rename the
macro to `DAS08AOX_AO_UPDATE_REG` and add a comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging
. If anywhere, they should probably be in the das08_isa module.
Just remove them. The comments for the register macros indicate which
boards they apply to anyway, so we don't lose much information.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 68
Use the preferred style for block comments. Squash double spaces after
the comment opening sequence for single-line comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
the `BIT()` macro to define its value. (Note: the
driver does not currently enable interrupts.)
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers
input Comedi subdevice. Rename the
variables to reflect that.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi
of a function prototype, so just declare `struct
comedi_device` as an incomplete type. It also uses `bool`, so include
linux/types.h to declare it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging
initially supported by a patch from an external contributor
to the COMEDI project back in 2001. Assume the code is correct for now,
but add a comment to mention the discrepancy.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 21 ++---
1 file
with other register macros.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
index 935bbfb..eef0456 100644
the corresponding bits for the control
register (except on JR boards). Rename it to `DAS08_CONTROL_DO(x)`
and add a comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
index b43bc2d..f0ee617 100644
--- a/drivers
` for the digital output register, and add some comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
index
The `DAS08_CONTROL` macro contains the offset to the write-only control
register. Rename it to `DAS08_CONTROL_REG` and add a comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
)` and `DAS08AOX_AO_MSB_REG(x)` respectively, and
add some comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
in the comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers/das08.c
index 4e8756a..8aa8011 100644
)` and `DAS08JR_AO_MSB_REG(x)` respectively, and
add some comments.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi/drivers
Clean up the Comedi das08 module a bit, mostly for consistent naming
of things.
01) staging: comedi: das08.h: reformat copyright comment
02) staging: comedi: das08.h: change description in copyright header
comment
03) staging: comedi: das08.h: reformat remaining comments
04) staging: comedi:
`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 20 ++--
drivers/staging/comedi/drivers/das08.h | 5 +++--
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das08.c
b/drivers/staging/comedi
Reformat the copyright comment at the top of the file to use the
preferred block comment style.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers
for boards that support
programmable gain.
This will also allow range tables to be included for convenience for
those boards that support multiple ranges by DIP switches. Those boards
are currently initialized to use a single unknown range.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers
, cmd-chanlist_len);
err |= __get_user(temp.uptr, cmd32-data);
Looks okay now apart from it being ugly, but that can't be helped since
comedi uses that chanlist member for both user and kernel addresses!
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail
)
return 0x3;
if (channel == 5)
Surely that's a false positive sparse warning?
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux
/drivers/s626.c | 6 +-
Looks good apart from the checkpatch warning in patch 3 as pointed out
by Sudip.
For patches 1-2 and 4-6:
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
)) {
- rc = -ENOSYS;
+ rc = -EPERM;
Why -EPERM? I think either -ENODEV or -ENXIO would be better.
goto out;
}
if (dev-open) {
-- 1.7.9.5
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo
);
Okay, it would be nice if the patch subject line mentioned the name of
the module, but this is the only one in COMEDI with a split author line.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
/staging/comedi/drivers/s626.c | 6 +-
6 files changed, 7 insertions(+), 31 deletions(-)
Looks good.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe
to compat_ptr(), so it won't work. Your first
patch was better, apart from exceeding the 80 character line limit.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe
be NULL then we should keep the
check so that the code is easier to read.
So we should keep the check in this case too.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line
adl_pci9118_driver = {
The patch does no harm, but as mentioned by Dan Carpenter, if pcidev
could be NULL (which it could be), we should keep the test for readability.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk
.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
,
not the whole of comedi.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at http://www.tux.org/lkml/
file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please
1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line unsubscribe
or range number!
chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n,
i, CR_CHAN(chansegment[i]),
Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Web: http
(dev, s, daqboard2000_8255_cb,
dioP2ExpansionIO8Bit);
That 'dioP2ExpansionIO8Bit' line could do with being un-indented by a
couple of spaces so it still lines up with the 'dev' on the preceding line.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
801 - 900 of 2849 matches
Mail list logo
