[PATCH 04/18] staging: fsl-dpaa2/eth: Remove incorrect error path

2017-06-06 Thread Ioana Radulescu
Not having Rx hashing distribution enabled for an interface is a valid configuration and shouldn't be treated as an error. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH 18/18] staging: fsl-dpaa2/eth: Update number of netdev queues

2017-06-06 Thread Ioana Radulescu
. Signed-off-by: Bogdan Purcareata Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c index 3f7f61b9c462

[PATCH 13/18] staging: fsl-dpaa2/eth: Remove unused fields from priv struct

2017-06-06 Thread Ioana Radulescu
Remove the dpni_id and buffer_layout fields from device's private structure. They're only used at probe so we don't need to store them for further use. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 33 +- drivers/st

[PATCH 1/9] staging: fsl-dpaa2/eth: Fix potential endless loop

2017-10-11 Thread Ioana Radulescu
risk entering an endless loop. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 58 -- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/dr

[PATCH 3/9] staging: fsl-dpaa2/eth: Check SGT final bit is present

2017-10-11 Thread Ioana Radulescu
issue a warning. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c index e9fe1c9..6f009d1 100644 --- a/drivers/st

[PATCH 4/9] staging: fsl-dpaa2/eth: Check if notification rearm is successful

2017-10-11 Thread Ioana Radulescu
In case dpaa2_io_service_rearm() fails with an error other then EBUSY, it will do so silently; add a check for this and a warning message, as a failure here means we're unable to receive any more traffic on the current cpu. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/eth

[PATCH 6/9] staging: fsl-dpaa2/eth: Fix double DMA unmap

2017-10-11 Thread Ioana Radulescu
function to free only the subsequent buffers. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet

[PATCH 7/9] staging: fsl-dpaa2/eth: Use implicit clear of link interrupt

2017-10-11 Thread Ioana Radulescu
: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c index 6540ab0..3a8bad1 100644 --- a/drivers/staging/fsl

[PATCH 8/9] staging: fsl-dpaa2/eth: Don't use netdev_err too early

2017-10-11 Thread Ioana Radulescu
Early during probe the netdevice name is not initialized yet, so use dev_err instead of netdev_err when printing error messages. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 9/9] staging: fsl-dpaa2/eth: Add firmware version

2017-10-11 Thread Ioana Radulescu
Include firmware version in the driver information exported through ethtool. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 14 +- drivers/staging/fsl-dpaa2/ethernet/dpni-cmd.h | 5 drivers/staging/fsl-dpaa2/ethernet/dpni.c

[PATCH 2/9] staging: fsl-dpaa2/eth: Account for Rx FD buffers on error path

2017-10-11 Thread Ioana Radulescu
On Rx path, if we fail to build an skb from the incoming FD, we still need to update the channel buffer count accordingly, otherwise we risk depleting the pool while the software counter still sees available buffers. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2

[PATCH 5/9] staging: fsl-dpaa2/eth: Refactor interrupt arming in NAPI poll

2017-10-11 Thread Ioana Radulescu
Take into consideration the return value of napi_complete_done(), since there might be an indication that it's not suitable to enable driver interrupts yet. Signed-off-by: Bogdan Purcareata --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-27 Thread Ioana Radulescu
esult when cpu id is negative, by explicitly stating the comparison is between signed values. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c

[PATCH v2] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ioana Radulescu
explicitly comparing the cpu id with the "any" value before verifying the upper bound. Signed-off-by: Ioana Radulescu --- v2: - make condition more clear (as suggested by Dan Carpenter) - don't use unlikely() drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 4 ++-- drivers/staging/

[PATCH] staging: fsl-mc/dpio: Propagate error code

2017-06-15 Thread Ioana Radulescu
dpaa2_io_service_register() returns zero even if qbman_swp_CDAN_set() encountered an error. Fix this by propagating the error code so the caller is informed data availability notifications are not properly set for a channel. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-mc/bus/dpio

[PATCH 3/6] staging: fsl-dpaa2/eth: Add counter for skb reallocs

2017-12-08 Thread Ioana Radulescu
Add a counter for the number of egress frames that need to be realloc'ed due to insufficient headroom space. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 + drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 + drivers/staging/fsl-dpaa2/eth

[PATCH 6/6] staging: fsl-dpaa2/eth: Make Tx buffer alignment optional

2017-12-08 Thread Ioana Radulescu
alignment of forwarded frames. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 ++ drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

[PATCH 0/6] staging: fsl-dpaa2/eth: Frame buffer optimizations

2017-12-08 Thread Ioana Radulescu
E test (as client), we see an increase in throughput from 3.79Gbps to 5.11Gbps. For UDP traffic no improvement is observed, since the stack usually creates skbs with minimal headroom (2B) for UDP frames. Ioana Radulescu (6): staging: fsl-dpaa2/eth: Fix access to FAS field staging: fsl-dpaa2/

[PATCH 1/6] staging: fsl-dpaa2/eth: Fix access to FAS field

2017-12-08 Thread Ioana Radulescu
/eth: Extra headroom in RX buffers") Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 8 drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 13 + 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/staging/fsl-dpaa

[PATCH 5/6] staging: fsl-dpaa2/eth: Compute needed headroom per frame

2017-12-08 Thread Ioana Radulescu
frame basis. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 9 ++--- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 11 --- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/dr

[PATCH 4/6] staging: fsl-dpaa2/eth: Don't enable FAS on Tx

2017-12-08 Thread Ioana Radulescu
field we currently use. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 73 +- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 6 --- 2 files changed, 13 insertions(+), 66 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/

[PATCH 2/6] staging: fsl-dpaa2/eth: Don't set netdev->needed_headroom

2017-12-08 Thread Ioana Radulescu
ng between two of our own interfaces, there is no functional change; for traffic forwarded from a different device or generated on the core, skb realloc operations are moved from the stack to our driver, with no visible impact on performance. Signed-off-by: Ioana Radulescu --- drivers/staging/fsl-dpaa2/

RE: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file

2016-12-06 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, December 06, 2016 11:58 AM > To: Ruxandra Ioana Radulescu > Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > ag...@suse.de; a...@arndb.de; Alexandru Marginean

RE: [PATCH 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-11-10 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuart.yo...@nxp.com] > Sent: Friday, October 21, 2016 9:02 AM > To: gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li > ; Roy Pledge ; Roy Ple

RE: [PATCH 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects

2016-11-02 Thread Ruxandra Ioana Radulescu
> ; Ruxandra Ioana Radulescu > ; Roy Pledge ; Stuart > Yoder > Subject: [PATCH 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects > > From: Ioana Radulescu > > Add the command build/parse APIs for operating on DPIO objects through > the DPAA2 Management Complex. > > S

RE: [PATCH 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

2016-11-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuart.yo...@nxp.com] > Sent: Friday, October 21, 2016 9:02 AM > To: gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li > ; Roy Pledge ; Roy Pledg

RE: [PATCH 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-11-04 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuart.yo...@nxp.com] > Sent: Friday, October 21, 2016 9:02 AM > To: gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li > ; Roy Pledge ; Stuart Yo

RE: [PATCH 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface

2016-11-04 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuart.yo...@nxp.com] > Sent: Friday, October 21, 2016 9:02 AM > To: gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li > ; Roy Pledge ; Roy Pled

RE: [PATCH 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs

2016-11-04 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder > Sent: Friday, November 04, 2016 4:32 PM > To: Ruxandra Ioana Radulescu ; > gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org; ag...@suse.de; a...@arndb.de; Leo Li >

RE: [PATCH 8/9] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver

2016-11-04 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder > Sent: Thursday, November 03, 2016 4:38 PM > To: Ruxandra Ioana Radulescu > Subject: FW: [PATCH 8/9] bus: fsl-mc: dpio: add the DPAA2 DPIO object > driver > > > > -Original Message- > From: Stuart Y

RE: [PATCH v2 8/9] staging: fsl-dpaa2/eth: Add TODO file

2017-04-20 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Stuart Yoder [mailto:stuyo...@gmail.com] > Sent: Wednesday, April 19, 2017 6:44 AM > To: Ruxandra Ioana Radulescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; Alexander Graf ; Arnd Bergmann

RE: [PATCH v3 1/9] bus: fsl-mc: add DPCON object APIs

2017-04-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, April 28, 2017 3:24 PM > To: Ruxandra Ioana Radulescu > Cc: de...@driverdev.osuosl.org; stuyo...@gmail.com; a...@arndb.de; > Haiying Wang ; Roy Pledge > ; Alexandru Margi

RE: [PATCH 1/2] staging: fsl-dpaa2/eth: Fix address translations

2017-05-25 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Laurentiu Tudor > Sent: Wednesday, May 24, 2017 3:34 PM > To: Ruxandra Ioana Radulescu ; > gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > ag...@suse.de; a...@arndb.de; linux-arm-ker...@list

RE: [PATCH] staging: fsl-dpaa2/eth: fix a couple of implicit includes

2017-06-22 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: laurentiu.tu...@nxp.com [mailto:laurentiu.tu...@nxp.com] > Sent: Thursday, June 22, 2017 3:52 PM > To: gre...@linuxfoundation.org; Ruxandra Ioana Radulescu > > Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Bogdan > Purcarea

RE: [PATCH] staging: fsl-dpaa2/eth: add ETHERNET dependency

2017-05-17 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, May 16, 2017 2:30 PM > To: Greg Kroah-Hartman ; Arnd Bergmann > > Cc: Ruxandra Ioana Radulescu ; > de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org > Subject: [PATCH] sta

RE: [PATCH 15/18] staging: fsl-dpaa2/eth: Reorder priv fields

2017-06-14 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, June 13, 2017 1:04 PM > To: Ruxandra Ioana Radulescu > Cc: de...@driverdev.osuosl.org; stuyo...@gmail.com; a...@arndb.de; > linux-kernel@vger.kernel.org; ag...@suse.de; Bharat

RE: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, September 28, 2017 3:49 PM > To: Ruxandra Ioana Radulescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; > a...@arndb.de; stuyo...@gmail.com; Roy Pledg

RE: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread Ruxandra Ioana Radulescu
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 28, 2017 4:18 PM > To: Ruxandra Ioana Radulescu > Cc: Dan Carpenter ; > de...@driverdev.osuosl.org; a...@arndb.de; stuyo...@gmail.com; Roy >

<    1   2