Re: Partition renumbering under 2.4.0

2001-01-17 Thread James Bottomley
Note that the ext2 logical partition is called "hdb9" by 2.2.16 and "hdb5" by 2.4.0. This makes it difficult to manage multi-boot systems with 2.2.x and 2.4.x kernels, as it requires updating fstab between boots. Switching to other identification strategies such as ext2 labels - as discussed

Re: Linux not adhering to BIOS Drive boot order?

2001-01-17 Thread James Bottomley
are off. If there is sufficient interest in this, I could look at putting together a patch to 2.4.x which would implement the scheme. James Bottomley - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the F

[NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-12 Thread James Bottomley
of most of the later drivers) so it makes much more sense to give it its own driver. The chip driver is currently I/O mapped (because the only cards I know using the chip are I/O mapped), but could easily be made memory mapped as well, just let me know. James Bottomley Hansen Partnership

Re: [NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-13 Thread James Bottomley
[EMAIL PROTECTED] said: If I am not mistaken, Richard Hirst has also done work on this thing. The Panther/lp486e/PWS/... has on-board ethernet (82596) and this now works under both 2.2 and 2.4. It also has on-board SCSI (NCR 53c700-66), maybe memory mapped, I forget. Maybe nobody knows the

Panic in initrd umount on 2.4.5 with analysis and fix

2001-05-31 Thread James Bottomley
that everybody's initrd works OK purely because the stack crud populating i_bdev in the fake inode happens to be dereferenceable. James Bottomley - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH] 1 line fix to smc-mca in 2.4.2-ac8

2001-03-03 Thread James Bottomley
This, along with the previous ac fixes finally get the smc-mca driver working for me on my quirky MCA box. James Bottomley Index: smc-mca.c === RCS file: /home/jejb/CVSROOT/linux/2.4/drivers/net/smc-mca.c,v retrieving revision

Re: SMP on assym. x86

2001-03-21 Thread James Bottomley
around I find is just to make sure that the boot CPU has the lowest capability set (i.e. boot off a 486). Could you just swap the order of your processors to achieve the same effect? James Bottomley - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: Linux Cluster using shared scsi

2001-04-27 Thread James Bottomley
have a redhat or other distribution patched version. Most distributions include the Steeleye SCSI clustering patches which correct reservation handling. I've attached the complete patch, which fixes both the old and the new error handlers in the 2.2 kernel it applies against 2.2.18. James

Re: Linux Cluster using shared scsi

2001-05-01 Thread James Bottomley
[EMAIL PROTECTED] said: Does this package also tell the kernel to re-establish a reservation for all devices after a bus reset, or at least inform a user level program? Finding out when there has been a bus reset has been a stumbling block for me. [EMAIL PROTECTED] said: You cannot rely

Re: Linux Cluster using shared scsi

2001-05-01 Thread James Bottomley
[EMAIL PROTECTED] said: So, will Linux ever support the scsi reservation mechanism as standard? That's not within my gift. I can merely write the code that corrects the behaviour. I can't force anyone else to accept it. [EMAIL PROTECTED] said: Isn't there a standard that says if you scsi

Re: Linux Cluster using shared scsi

2001-05-03 Thread James Bottomley
[EMAIL PROTECTED] said: Correct, if you hold a reservation on a device for which you have multiple paths, you have to use the correct path. As far as multi-path scsi reservations go, the SCSI-2 standards (and this includes the completion in the SCSI-3 SPC) is very malleable. The standard is

Re: Linux Cluster using shared scsi

2001-05-03 Thread James Bottomley
There is another nasty in multi-port arrays that I should perhaps point out: a bus reset isn't supposed to drop the reservation if it was taken on another port. A device or LUN reset will drop reservations on all ports. This behaviour, although clearly mandated by the SCSI-3-SPC, is rather

[PATCH] fix for initrd panic in 2.4.5

2001-06-05 Thread James Bottomley
in fake_inode to make any other problems like this show up. James Bottomley Index: fs/block_dev.c === RCS file: /home/jejb/CVSROOT/linux/2.4/fs/block_dev.c,v retrieving revision 1.1.1.10 diff -u -r1.1.1.10 block_dev.c --- fs

NFS PANIC and FIX in 2.4

2001-06-09 Thread James Bottomley
the d_child list invalid, so any subsequent call to list_del on d_child could panic. I think the correct fix (attached below) is to change the NFS list_del to list_del_init. James Bottomley Steeleye technology. Index: linux/2.4/fs/nfsd/nfsfh.c diff -u linux/2.4/fs/nfsd/nfsfh.c:1.1.1.8.4.1 linux

[PATCH] 2.4.1 SCSI reservation/reset handling

2001-02-12 Thread James Bottomley
code, but they are fairly essential to those of us working in clustering and using reservations for I/O fencing. I've run the patch through a 12 hour stress test in a two node cluster using the sym53c875 and aic7xxx (AHA 2944/UW) SCSI cards. James Bottomley Index: linux/drivers/scsi/scsi.c

Re: Flushing buffer and page cache

2001-02-17 Thread James Bottomley
all the buffers from the cache. We use it as a tool to move a SAN device around a cluster, which is similar to what you want to do. James Bottomley - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majo

Re: [RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 09:25 -0400, Josef Bacik wrote: Looking through everything I came to the conclusion that we don't really need the scsi_sysfs_add_devices in scsi_finish_async_scan, which gets run everytime we do a do_scan_async. In doing the scanning, if we come upon anything we will

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 15:09 +, Miller, Mike (OS Dev) wrote: Nak. You still haven't told where you saw these warnings. What compiler are you using? I do not see these in my 32-bit environment. I think it's seen with CONFIG_LBD=n on 32 bits In that configuration, sector_t is a u32 (it's u64

RE: [PATCH] cciss: Fix warnings during compilation under 32bit environment

2007-04-19 Thread James Bottomley
On Thu, 2007-04-19 at 16:12 +, Miller, Mike (OS Dev) wrote: Nak. You still haven't told where you saw these warnings. What compiler are you using? I do not see these in my 32-bit environment. I think it's seen with CONFIG_LBD=n on 32 bits In that configuration, sector_t is a

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
by cmd_alloc() and doesn't need to be zeroed a 2nd time. -- steve -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thu 4/19/2007 11:22 AM To: Miller, Mike (OS Dev) Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
On Fri, 2007-04-20 at 11:43 -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 09:10:41 -0400 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-04-19 at 22:20 -0700, Andrew Morton wrote: On Thu, 19 Apr 2007 16:27:26 - Cameron, Steve [EMAIL PROTECTED] wrote: Something

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
On Fri, 2007-04-20 at 12:30 -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 14:50:06 -0400 James Bottomley [EMAIL PROTECTED] wrote: CONFIG_LBD=y gives us an additional 3kb of instructions on i386 allnoconfig. Other architectures might do less well. It's not a huge difference

Re: qla2xxx hba crashes with older 2310 cards

2007-04-20 Thread James Bottomley
On Fri, 2007-04-20 at 13:24 -0700, David Miller wrote: From: Robert Peterson [EMAIL PROTECTED] Date: Fri, 20 Apr 2007 10:40:30 -0500 I've seen some chatter about the qla2xxx driver but not paid attention, so I'm sorry if this is a known issue. I've got an older qlogic hba, and recent

Re: [PATCH] dma_declare_coherent_memory wrong allocation

2007-04-22 Thread James Bottomley
On Fri, 2007-04-13 at 20:08 +0200, Guennadi Liakhovetski wrote: Either I've finally gone blind on this Friday 13th or... Looks like this almost 3 year old function has a bug. Patch below compile-tested... in a way. No, it's a longstanding bug in the x86 implementation, thanks for finding it.

Re: [PATCH] sas_scsi_host: Convert to use the kthread API

2007-04-22 Thread James Bottomley
On Sun, 2007-04-22 at 20:38 +0100, Christoph Hellwig wrote: On Thu, Apr 19, 2007 at 05:37:53PM -0700, Andrew Morton wrote: On Thu, 19 Apr 2007 01:58:38 -0600 Eric W. Biederman [EMAIL PROTECTED] wrote: From: Eric W. Biederman [EMAIL PROTECTED] This patch modifies the sas scsi host

Re: [PATCH] dma_declare_coherent_memory wrong allocation

2007-04-23 Thread James Bottomley
On Mon, 2007-04-23 at 00:45 +0200, Guennadi Liakhovetski wrote: Right, thinko. How about using his: + int pages = DIV_ROUND_UP(size, PAGE_SIZE); Actually, no ... this has to be size PAGE_SHIFT. The reason being that the allocator is designed to allocate pages out of a device memory

Re: [RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-04-23 Thread James Bottomley
On Mon, 2007-04-23 at 14:13 -0400, Josef Bacik wrote: Ok I have a new patch that I've built and tested on both my UP and SMP machine and it appears to work fine. I took the async check out of scsi_add_lun, I don't really see the point in waiting to do the sysfs registration stuff (if theres a

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-08 Thread James Bottomley
On Thu, 2007-03-08 at 17:22 +0800, Joe Jin wrote: While a scsi device hw error occured, device's status maybe setting to SDEV_OFFLINE, So at scsi_dispatch_cmd function, we should checking if device have offline, if yes, do nothing and just return error to user directly. What's the error

Re: [PATCH] SCSI: Delete unused header file.

2007-03-10 Thread James Bottomley
On Sat, 2007-03-10 at 17:16 -0500, Robert P. J. Day wrote: Delete apparently unused header file drivers/scsi/pci2000.h. This was apparently missed by Christoph when he removed the driver ... I'll add it to the queue. For future SCSI work, could you cc linux-scsi@vger.kernel.org please? That

Re: [PATCH] [scsi]: Add offline state checking while dispatch a scsi cmd

2007-03-11 Thread James Bottomley
On Fri, 2007-03-09 at 09:40 +0800, Joe Jin wrote: What's the error you're trying to fix? scsi_dispatch_cmd() is only called from scsi_request_fn() which already has an equivalent of this check in it just prior to calling dispatch. Yeah, I have saw the cheking at scsi_request_fn(),

[PATCH] fix process crash caused by randomisation and 64k pages

2007-03-16 Thread James Bottomley
This bug was seen on ppc64, but it could have occurred on any architecture with a page size of 64k or above. The problem is that fs/binfmt_elf.c:randomize_stack_top() randomizes the stack to within 0x7ff pages. On 4k page machines, this is 8MB; on 64k page boxes, this is 128MB. The problem is

Re: [PATCH] scsi: megaraid_sas - throttle io if cmds are in risk of being timed-out

2007-03-16 Thread James Bottomley
On Thu, 2007-03-01 at 13:29 -0800, Sumant Patro wrote: Driver to throttle IO to reduce risk of OS timing out cmds. Implemented a circular queue to keep track of pending OS cmds in FW. This queue is periodically (every 10 sec) checked by a timer routine. If there is any cmd that is in risk

[GIT PATCH] SCSI updates for 2.6.20

2007-02-10 Thread James Bottomley
): ipr: remove duplicate device id Hannes Reinecke (1): aic79xx: use dma_get_required_mask() James Bottomley (1): NCR_D700: needs burst length setting to 8 Jiri Kosina (1): Buslogic: local_irq_disable() is redundant after local_irq_save() Kai Makisara (1): st

Re: [GIT PATCH] SCSI updates for 2.6.20

2007-02-12 Thread James Bottomley
On Mon, 2007-02-12 at 11:29 +0100, Rolf Eike Beer wrote: Am Sonntag, 11. Februar 2007 schrieb James Bottomley: This is the accumulated SCSI tree for 2.6.20. It is available at master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git You once again have not included this two

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread James Bottomley
On Tue, 2007-02-13 at 15:35 +1100, Stephen Rothwell wrote: OK, I have thought about this some more and I *think* the only architecture that needs compat_sys_epoll_ctl or compat_sys_epoll_wait is ia64 where the 64 bit version of struct epoll_event is different from the 32 bit version. On

Re: [PATCH 3/5] scsi: megaraid_sas - throttle io if FW is busy

2007-02-15 Thread James Bottomley
On Tue, 2007-02-06 at 14:11 -0800, Sumant Patro wrote: Checks added in megasas_queue_command to know if FW is able to process commands within timeout period. If number of retries is 2 or greater, the driver stops sending cmd to FW. IO is resumed if pending cmd count reduces to 16 or 5 seconds

Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-02-16 Thread James Bottomley
On Mon, 2007-02-12 at 12:27 -0800, Andrew Morton wrote: Given that we now have a standard kernel-wide, c99-friendly way of expressing true and false, I'd suggest that this decision can be revisited. Because a true is significantly more meaningful (and hence readable) thing than a bare 1.

RE: [PATCH 3/5] scsi: megaraid_sas - throttle io if FW is busy

2007-02-16 Thread James Bottomley
On Thu, 2007-02-15 at 19:53 -0700, Patro, Sumant wrote: Hello James, I re-submitted the patch yesterday with the space issue fixed (adhering to coding guideline). I will check for alternative to calculate the time driver have been sending host busy to OS. Will check with

Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-02-16 Thread James Bottomley
On Fri, 2007-02-16 at 19:04 +0100, Richard Knutsson wrote: James Bottomley wrote: On Mon, 2007-02-12 at 12:27 -0800, Andrew Morton wrote: Given that we now have a standard kernel-wide, c99-friendly way of expressing true and false, I'd suggest that this decision can be revisited

Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-02-16 Thread James Bottomley
On Fri, 2007-02-16 at 10:34 -0800, Andrew Morton wrote: On Fri, 16 Feb 2007 10:42:12 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-02-12 at 12:27 -0800, Andrew Morton wrote: Given that we now have a standard kernel-wide, c99-friendly way of expressing true and false, I'd

Re: 2.6.20-git: undefined reference to `smp_call_function_single'

2007-02-17 Thread James Bottomley
On Sat, 2007-02-17 at 11:25 +0100, Thomas Gleixner wrote: On Fri, 2007-02-16 at 21:08 -0500, Len Brown wrote: Yes, an obscure .config, but it used to build before today: kernel/built-in.o: In function `tick_broadcast_on_off': (.text+0x1b6f0): undefined reference to

Re: Which architectures need to sync vmalloc mappings between processes?

2007-02-18 Thread James Bottomley
On Sat, 2007-02-17 at 21:29 -0800, Jeremy Fitzhardinge wrote: I'm looking at making all architectures export a vmalloc_sync_all() function, so that generic code can be sure that a particular vmalloc mapping is present in all address spaces. I need this to implement a function to reserve a

[GIT PATCH] final SCSI updates for 2.6.20

2007-02-18 Thread James Bottomley
: better initialization for sdev-scsi_level scsi_proc.c: display sdev-scsi_level correctly scsi_scan.c: handle bad inquiry responses FUJITA Tomonori (1): tgt: fix the user/kernel ring buffer interface James Bottomley (1): aic94xx: tie driver to the major number

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread James Bottomley
On Mon, 2007-03-19 at 12:49 -0500, Mike Christie wrote: I can't even say if the tapes are written correctly as I can't read them (one does not reboot production machines back to 2.4.x just to try to read a backup tape - I don't have 2.6.x older than 2.6.20 on these machines). Could you

Re: 2.6.20.3: kernel BUG at mm/slab.c:597 try#2

2007-03-19 Thread James Bottomley
On Mon, 2007-03-19 at 17:47 -0400, Gene Heskett wrote: James, could this also be the cause of a tar based backup going crazy and thinking all data is new under any 2.6.21-rc* kernel I've tested so far with amanda, which in my case uses tar? I've tried the fedora patched tar-1.15-1, and one

Re: some PCMCIA SCSI drivers can be built *only* as modules

2007-03-26 Thread James Bottomley
On Mon, 2007-03-26 at 21:02 +0100, Christoph Hellwig wrote: it would seem to make no sense that the depends on clause for this option includes m, forcing this (and all other four entries in that Kconfig file, by the way) to be built as modules, while the help text for all five

Re: some PCMCIA SCSI drivers can be built *only* as modules

2007-03-26 Thread James Bottomley
On Mon, 2007-03-26 at 21:38 +0100, Christoph Hellwig wrote: On Mon, Mar 26, 2007 at 03:35:47PM -0500, James Bottomley wrote: I agree the non-legacy (CardBus and beyond) ones can be built in. I thought the legacy 8 and 16 bit type I and II still had to be modular because they still need

Re: CONFIG_SCSI_WAIT_SCAN=m

2007-03-27 Thread James Bottomley
On Tue, 2007-03-27 at 17:25 +0100, Hugh Dickins wrote: I'm not using an initrd, most of my kernel is builtin, just a few modules for occasional filesystems. CONFIG_MODULES=y CONFIG_SCSI=y CONFIG_SCSI_SCAN_ASYNC=y CONFIG_SCSI_WAIT_SCAN=m 2.6.21-rc5-mm2 VFS panics unable to find my root

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-05 Thread James Bottomley
On Thu, 2007-04-05 at 15:36 -0700, David Miller wrote: From: Andrew Burgess [EMAIL PROTECTED] Date: Thu, 5 Apr 2007 15:13:27 -0700 David, do you see any other problems with scsi_send_eh_cmnd? I've switched back to 2.6.18 which seems to not oops and am happy to try patches. Does

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-05 Thread James Bottomley
On Thu, 2007-04-05 at 17:15 -0700, David Miller wrote: This won't work I believe. There are cases that use smaller sense buffers than the minimum specified by the SCSI layer. One example is that do_sr_ioctl() stuff when the cgc passed in has a sense buffer. That will only be as large as

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread James Bottomley
On Thu, 2007-04-05 at 19:21 -0700, Andrew Burgess wrote: 2.6.20.4 with your patch dies in the memcpy (as does 21-gitN) 2.6.20.4 without your patch dies in the subsequent __free_page with a null pointer ref at 000...008 James should I try your posted patch? On which kernel? Well, mine will

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread James Bottomley
On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote: Yes. The 3w-.c driver changed between 2.6.18 and 2.6.20 but nothing jumps out to my untrained eyes. Here's the diff: Also, I should mention that the working kernel is a fedora rpm (2.6.18-1.2798.fc6) so I don't know what patches are

Re: CONFIG_SCSI_WAIT_SCAN=m

2007-04-06 Thread James Bottomley
Sorry, was waiting for a reply on this one ... didn't realise it hadn't cc'd linux-scsi ... James On Tue, 2007-03-27 at 17:25 +0100, Hugh Dickins wrote: I'm not using an initrd, most of my kernel is builtin, just a few modules for occasional filesystems. CONFIG_MODULES=y CONFIG_SCSI=y

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread James Bottomley
On Fri, 2007-04-06 at 08:51 -0700, Andrew Burgess wrote: James Bottomley wrote: It's actually a long standing bug in the 3w- driver. Apparently it assumes request sense is always the use_sg == 0 case. This is what it does on a request sense: static int tw_scsiop_request_sense

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread James Bottomley
On Fri, 2007-04-06 at 12:32 -0400, Douglas Gilbert wrote: That last line should be: request_buffer[7] = 10; /* minimum size per SPC: 18 bytes */ Er, yes, I'm afraid when I see n-7 I always think n is the lenght, not n is the last byte ... James - To unsubscribe from this list:

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread James Bottomley
On Fri, 2007-04-06 at 11:32 -0700, David Miller wrote: From: James Bottomley [EMAIL PROTECTED] Date: Fri, 06 Apr 2007 10:27:57 -0500 On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote: Yes. The 3w-.c driver changed between 2.6.18 and 2.6.20 but nothing jumps out to my

Re: [PATCH 1/1] cciss: kconfig patch to make cciss dependent on scsi for SG_IO ioctl

2007-04-12 Thread James Bottomley
On Thu, 2007-04-12 at 16:27 -0500, Mike Miller (OS Dev) wrote: This kconfig patch makes cciss dependent on scsi for the new SG_IO ioctl we just added. If cciss is built into the kernel it makes sures that scsi is also statically linked. If scsi is a module then cciss will also be built as a

Last SCSI bug fix for 2.6.21

2007-04-14 Thread James Bottomley
Mon Sep 17 00:00:00 2001 From: James Bottomley [EMAIL PROTECTED] Date: Fri, 6 Apr 2007 11:14:56 -0500 Subject: [SCSI] 3w-: fix oops caused by incorrect REQUEST_SENSE handling 3w- emulates a REQUEST_SENSE response by simply returning nothing. Unfortunately, it's assuming

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread James Bottomley
On Thu, 2007-02-22 at 13:24 -0800, Andrew Morton wrote: On Thu, 22 Feb 2007 10:51:23 -0600 Mike Miller (OS Dev) [EMAIL PROTECTED] wrote: On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote: On Wed, 21 Feb 2007 15:10:39 -0600 Mike Miller (OS Dev) [EMAIL PROTECTED] wrote:

Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier)

2007-02-22 Thread James Bottomley
On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: .remove = __devexit_p(cciss_remove_one), .id_table = cciss_pci_device_id,/* id_table */ + .shutdown = cciss_remove_one, You need a __devexit_p() wrapper for this one too. James - To unsubscribe from

Re: [Patch 1/2] cciss: fix for 2TB support

2007-02-22 Thread James Bottomley
On Thu, 2007-02-22 at 16:02 -0600, Mike Miller (OS Dev) wrote: Will this patch for my patch work for now? Yes, I think that should be fine ... it's only a theoretical worry; at the moment sector_t is unsigned ... but just in case. James - To unsubscribe from this list: send the line

Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations

2007-02-27 Thread James Bottomley
On Tue, 2007-02-27 at 00:13 -0800, Jeremy Fitzhardinge wrote: plain text document attachment (kill-HAVE_ARCH_MM_LIFETIME.patch) akpm: Can we lose __HAVE_ARCH_MM_LIFETIME? Just define these (preferably in C, not in cpp) in the appropriate include/asm-foo/ files? Signed-off-by: Jeremy

Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations

2007-02-27 Thread James Bottomley
On Tue, 2007-02-27 at 09:21 -0800, Jeremy Fitzhardinge wrote: You mean add the two stubs to asm-generic/mmu_context.h, and then include that in all these files? That would be cleaner, but it wouldn't remove the need to touch all these files, would it? it would if you added

Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations

2007-02-27 Thread James Bottomley
On Tue, 2007-02-27 at 09:56 -0800, Jeremy Fitzhardinge wrote: include/asm-generic isn't in the compile include path; its contents are only ever used if they're explicitly included by some other asm/ header. I seem to remember there was some debate about this, but I don't really understand the

Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations

2007-02-27 Thread James Bottomley
On Tue, 2007-02-27 at 10:48 -0800, Jeremy Fitzhardinge wrote: Well, I'm happy to create asm-generic/mm_hooks.h or something, and reduce all the changes to asm-*/mmu_context.h to a one-liner. If no-one else objects, that will certainly make my life easier, thanks! James - To unsubscribe from

[GIT PATCH] SCSI bug fixes for 2.6.21-rc5

2007-03-27 Thread James Bottomley
This is a fairly basic rollup of 3 basic double free or oops based bug fixes. The patch is available from: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git The Short Changelog is Joerg Dorchain (1): gdth: fix oops in gdth_copy_cmd() Judith Lebzelter (1):

Re: [RFD driver-core] Lifetime problems of the current driver model

2007-03-30 Thread James Bottomley
On Fri, 2007-03-30 at 18:43 +0900, Tejun Heo wrote: Orphaning sysfs nodes on unregistration is a big step in this direction. With sysfs reference counting out of the picture, implementing 'disconnect immediate' interface only on a few components (including request_queue) should suffice for

Re: [RFD driver-core] Lifetime problems of the current driver model

2007-03-30 Thread James Bottomley
On Fri, 2007-03-30 at 09:15 -0400, Dmitry Torokhov wrote: If you want to manage lifetime rules independently you might want to not embed struct device into you subsystems objects but attach them via pointers and use device_create(). Now that we orphan sysfs access upon unregistering device

Re: [RFD driver-core] Lifetime problems of the current driver model

2007-03-30 Thread James Bottomley
On Fri, 2007-03-30 at 22:38 +0900, Tejun Heo wrote: My plan was to make sysfs more independent from struct device/kobject. e.g. Something like the following. That's sort of what I was reaching for too ... it just looks to me that all the sysfs glue is in kobject, so they make a good candidate

Re: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-03-31 Thread James Bottomley
On Fri, 2007-03-30 at 15:21 -0700, Ed Lin wrote: The internal id/lun mapping of st_vsc and st_vsc1 controllers is different from st_shasta. The original driver code can only map first 16 'entities' for st_vsc and st_vsc1 while there are actually 128 available. Also the

Re: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-03-31 Thread James Bottomley
On Fri, 2007-03-30 at 15:21 -0700, Ed Lin wrote: After reset completed, the scsi error handler sends out START_STOP and TEST_UNIT_READY to the device. For 'normal' devices these commands will be handled by firmware. However, because the RAID console only interfaces to scsi mid layer, the

Re: [PATCH] Block layer: separate out queue-oriented ioctls Re: [PATCH] Block layer: separate out queue-oriented ioctls

2007-04-02 Thread James Bottomley
On Mon, 2007-04-02 at 16:23 +0200, Jens Axboe wrote: FWIW, it had my ack, I think we were just waiting for Doug to ack the sg bits. And there's really nothing I can do (well, except write the thing) since the changes are not in any SCSI pieces I maintain directly ... they're block and sg.

RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-04-02 Thread James Bottomley
On Mon, 2007-04-02 at 11:14 -0700, Ed Lin wrote: I just saw the routine name scsi_eh_try_stu, and didn't notice the allow_restart (partly because I thought it was not harmful...). But the TEST_UNIT_READY must stay. Sure ... I was just checking since your change log implied you'd seen the

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-04 Thread James Bottomley
On Wed, 2007-04-04 at 10:31 -0700, Ed Lin wrote: Sorry. It seems the mail server has problem. The patch is here in plain text. I hope this time it does not mess up. I have problem with linux-scsi mail list, if you have comment please cc me. Thanks. --Ed Lin The lines are still broken, I'm

Re: [PATCH] Perverting cciss

2007-04-05 Thread James Bottomley
On Thu, 2007-04-05 at 11:03 +0100, Christoph Hellwig wrote: On Thu, Apr 05, 2007 at 11:58:06AM +0200, Hannes Reinecke wrote: Hi All, this patch adds the SG_IO ioctl to the cciss driver. As the driver is capable of sending SCSI CDBs to the controller there is no reason why we shouldn't

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:38 +1100, Rusty Russell wrote: On Sunday 06 January 2008 02:31:12 James Bottomley wrote: On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: This patch series is the start of my attempt to simplify and make explicit the chained scatterlist logic. It's

Re: [RFC/PARTIAL PATCH 0/3] dma: passing attributes to dma_map_* routines

2008-01-08 Thread James Bottomley
On Mon, 2008-01-07 at 21:32 -0500, [EMAIL PROTECTED] wrote: The following patchset allows additional attributes to be passed to dma_map_*/dma_unmap_* implementations. (The reason why this is useful/necessary has been mentioned several times, most

Re: [RFC/PARTIAL PATCH 0/3] dma: passing attributes to dma_map_* routines

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 09:42 -0800, Roland Dreier wrote: I'm already on record saying I don't think attributes in the generic code is the right approach. All of the attributes I can see adding are bus specific (even to the extent that PCIe ones wouldn't apply to PCI for instance). I

Re: [RFC/PARTIAL PATCH 0/3] dma: passing attributes to dma_map_* routines

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 10:05 -0800, Roland Dreier wrote: I think the case before us that Arthur is dealing with is a counterexample for this: there's nothing bus-specific about it all. The issue is related to reordering of DMAs within the Altix system fabric, after they've left the

Re: [RFC/PARTIAL PATCH 0/3] dma: passing attributes to dma_map_* routines

2008-01-09 Thread James Bottomley
On Wed, 2008-01-09 at 13:00 -0800, Roland Dreier wrote: What it wants to do is set strict ordering for the bus ... well, that is an attribute in the PCIe standard (it just happens to be the default one for a standard bus, whereas relaxed is the default for altix). However, set bus

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-09 Thread James Bottomley
On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: We're always open to new APIs (or more powerful and expanded old ones). The way we've been doing the sg_chain conversion is to slide API layers into the drivers so sg_chain

[GIT PATCH] another SCSI bug fix for 2.6.24-rc7

2008-01-10 Thread James Bottomley
: note: 'req_cnt' was declared here Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] Signed-off-by: James Bottomley [EMAIL PROTECTED] --- drivers/scsi/qla1280.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 146d540

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 13:01 +1100, Rusty Russell wrote: On Thursday 10 January 2008 09:10:37 James Bottomley wrote: On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: We're always open to new APIs (or more powerful

Re: Driver 'sd' needs updating

2008-01-10 Thread James Bottomley
751bf4d7865e4ced406be93b04c7436d866d3684 Author: James Bottomley [EMAIL PROTECTED] Date: Wed Jan 2 11:14:30 2008 -0600 [SCSI] scsi_sysfs: restore prep_fn when ULD is removed It would be better to silence this warning. James, we need to reset prep_fn in each ULD? though it's not nice... Really not nice

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 19:05 +0100, Andre Noll wrote: [Resent with proper subject and to additional recipients] This patch against linus-current is compile-tested on x86 and x86-64. Please review This is rather long. For the utility of what you've just done, what's wrong with just making

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 19:59 +0100, Andi Kleen wrote: Really, all this is doing is open coding what the ioctl handler is doing anyway, isn't it? in which case, why bother to change it at all? Because once it's open coded it is visible and can then be eliminated. Does SCSI need the BKL at

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 20:45 +0100, Andre Noll wrote: On 20:29, Andi Kleen wrote: Sure, I can do that if James likes the idea. Since not all case statements need the BKL, we could add it only to those for which it isn't clear that it is unnecessary. And this would actually

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: I took another look at the compat approach, to see if it is feasible to keep the compat handling

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 16:46 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Thu, 10 Jan 2008 14:55 -0600: On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL

Re: INITIO scsi driver fails to work properly

2008-01-10 Thread James Bottomley
On Fri, 2008-01-04 at 02:18 +0200, Filippos Papadopoulos wrote: First of all let me wish a happy new year. I come back from the vacations and i compiled the initio driver with #define DEBUG_INTERRUPT 1 #define DEBUG_QUEUE 1 #define DEBUG_STATE 1 #define INT_DISC1 I used

Re: INITIO scsi driver fails to work properly

2008-01-11 Thread James Bottomley
On Fri, 2008-01-11 at 11:54 +0200, Filippos Papadopoulos wrote: On Jan 11, 2008 7:16 AM, James Bottomley [EMAIL PROTECTED] wrote: On Fri, 2008-01-04 at 02:18 +0200, Filippos Papadopoulos wrote: First of all let me wish a happy new year. I come back from the vacations and i compiled

Re: INITIO scsi driver fails to work properly

2008-01-11 Thread James Bottomley
On Fri, 2008-01-11 at 18:44 +0200, Filippos Papadopoulos wrote: On Jan 11, 2008 5:44 PM, James Bottomley [EMAIL PROTECTED] wrote: I havent reported initio: I/O port range 0x0 is busy. Sorry ... we appear to have several reporters of different bugs in this thread. That message

Re: INITIO scsi driver fails to work properly

2008-01-11 Thread James Bottomley
On Fri, 2008-01-11 at 17:01 +, Alan Cox wrote: Yes it works under 2.6.16.13. See the beginning of this thread, i mention there some things about newer versions. It worked (ish.. it has problems and always has had) before the big updates, and according to my tester after the big

Re: [PATCH] Only print SCSI data direction warning once for a command

2008-01-12 Thread James Bottomley
On Wed, 2008-01-02 at 07:03 +0100, Andi Kleen wrote: When I use cdparanoia my logs get spammed a lot by printk: 464 messages suppressed. sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in; program cdparanoia not setting count and/or reply_len properly

Re: new runtime scsi warnings in 2.6.24-rc6+git

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 20:58 +0100, Rafael J. Wysocki wrote: On Friday, 4 of January 2008, Meelis Roos wrote: Todays git gives the following warning during bootup on a Intel 845+PATA PC (using libata to drive PATA): Driver 'sd' needs updating - please use bus_type methods Driver 'sr'

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 13:25 -0600, Robert Hancock wrote: Alexander wrote: Robert Hancock wrote: There's this patch which was intended to fix it: http://lkml.org/lkml/2007/11/22/148 I applied this patch to 2.6.24-rc7. Now at boot time my DVD-RW is normaly detected as: sr0:

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: I don't think the problem is that there's some buffer which is getting allocated above 4GB and never bounced, since the problem goes away if ADMA is disabled entirely and the DMA mask remains 32-bit always. My guess is something is

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-12 Thread James Bottomley
On Sat, 2008-01-12 at 19:38 -0600, Robert Hancock wrote: James Bottomley wrote: On Sat, 2008-01-12 at 17:04 -0600, Robert Hancock wrote: I don't think the problem is that there's some buffer which is getting allocated above 4GB and never bounced, since the problem goes away if ADMA

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-13 Thread James Bottomley
On Sun, 2008-01-13 at 13:33 +, Alan Cox wrote: Other than that, I guess the solutions would be to just set a 32-bit mask on the device if either port has an ATAPI device connected (which is fairly ugly, considering that you could do things like hotplug an ATAPI device when the

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-01-13 Thread James Bottomley
On Sun, 2008-01-13 at 16:29 +, Alan Cox wrote: Yes, I concur for the short term. The other two possible courses of action either involve long discussions (the different device one) or you'll never quite be sure you got all the paths (the GFP_DMA32 one). At least with this one, you

  1   2   3   4   5   6   7   8   9   10   >