Re: file system for solid state disks

2007-08-22 Thread Jan Engelhardt
On Aug 23 2007 01:01, Richard Ballantyne wrote: What file system that is already in the linux kernel do people recommend I use for my laptop that now contains a solid state disk? If I had to choose, the list of options seems to be: - logfs [unmerged] - UBI layer with any fs you like [just

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-23 Thread Jan Engelhardt
On Aug 22 2007 11:47, Casey Schaufler wrote: As we have to maintain selinux, anyway, I don't see why simplification layer is a problem. It's an issue if you want to do simple things, have the resources to do simple things, but go over budget because the simple things are built on top of

Re: plea for project idea

2007-08-23 Thread Jan Engelhardt
On Aug 22 2007 10:58, Willy Tarreau wrote: On Wed, Aug 22, 2007 at 02:11:58PM +0530, shaneed cm wrote: can u plz suggest some idea 4 final year BTech(BE) project in linux kernel - duration 1 year thank you I sincerely doubt you will get any useful response if you cannot even write

Re: fs corruption by doing nothing

2007-08-23 Thread Jan Engelhardt
On Aug 23 2007 15:59, Martin Vogt wrote: Its unclear if this is a knoppix bug, but reiserfs simply tries to correct something which is wrong. I agree that this should not happen, especially not on RAID1 if the RAID superblock is of version 0.90 or 1.0. ReiserFS: sda2: found reiserfs format 3.6

Re: nf_conntrack_ipv4 must be loaded explicitly

2007-08-23 Thread Jan Engelhardt
On Aug 23 2007 16:53, Patrick McHardy wrote: After loading nf_conntrack_ipv4.ko, everything works again (also with the bad ff09b7). But I have to load it explicitly, and I think that unfortunately breaks a lot of setups (such as mine) which assume ipv4 connection tracking is always there. I

Re: division and cpu usage

2007-08-24 Thread Jan Engelhardt
On Aug 24 2007 07:34, linux-os (Dick Johnson) wrote: I'm new to kernel development and have some questions. 1. Why can't I divide with regular casting to double ((double)a / (double)b)? It gives me strange errors when compiling: WARNING: __divdf3 [/root] undefined! WARNING: __addf3

Re: [PATCH] memchr (trivial) optimization

2007-08-24 Thread Jan Engelhardt
On Aug 23 2007 19:13, Matt Mackall wrote: And you can do even better with this: void *memchr(const void *s, int c, size_t n) { const unsigned char *p = s, *e = s + n; const unsigned char *e = p + n; Uhm, you have two es in there. for (; p e ; p++) if

Re: [PATCH][RFC] dynamic pipe resizing

2007-08-24 Thread Jan Engelhardt
On Aug 24 2007 10:52, Jens Axboe wrote: Hi, Dabbling around with splice a bit, I added some code to change the size of a pipe. Currently it's hardcoded as 16 pages, with this patch you can shrink (if you wanted) or grow (the likely scenario) if you want to increase the size of your in-kernel

errno codes intertwined

2007-08-24 Thread Jan Engelhardt
Hello lists, I am currently working on a FUSE-based filesystem much like nfs/sshfs. I pass the syscall on to the storage server, where it is executed, and get back the result, or errno code. Let's jump into the real world example where the storage unit is x86_64 and the mount side is

Re: What's up with CONFIG_BLK_DEV?

2007-08-24 Thread Jan Engelhardt
On Aug 24 2007 15:17, Rob Landley wrote: CONFIG_BLOCK disables the block layer. CONFIG_BLK_DEV disables the block devices. menuconfig BLK_DEV bool Block devices depends on BLOCK default y ---help--- Say Y here to get to see options for various different

Re: What's up with CONFIG_BLK_DEV?

2007-08-24 Thread Jan Engelhardt
On Aug 24 2007 22:34, Jan Engelhardt wrote: On Aug 24 2007 15:17, Rob Landley wrote: CONFIG_BLOCK disables the block layer. CONFIG_BLK_DEV disables the block devices. menuconfig BLK_DEV bool Block devices depends on BLOCK default y ---help--- Say Y here

Re: [2.6 patch] fix export_report.pl

2007-08-24 Thread Jan Engelhardt
On Aug 24 2007 23:04, Adrian Bunk wrote: This patch fixes an annoying bug of export_report.pl missing the usages of some exports. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 14 Aug 2007 --- a/scripts/export_report.pl +++ b/scripts/export_report.pl @@

Re: What's up with CONFIG_BLK_DEV?

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 01:08, Rob Landley wrote: On Friday 24 August 2007 3:36:54 pm Jan Engelhardt wrote: Is there _ever_ a time you want the block layer but no block devices? Well, where do you think your hard disk drivers come from? Definitely not from the BLK_DEV menu... Now that I look I see

Re: [patch v2 1/1] md: Software Raid autodetect dev list not array

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 04:51, Michael J. Evans wrote: { - if (dev_cnt = 0 dev_cnt 127) - detected_devices[dev_cnt++] = dev; + struct detected_devices_node *node_detected_dev; + node_detected_dev = kzalloc(sizeof(*node_detected_dev), GFP_KERNEL);\ What's the \ good for,

Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 15:28, Denys Vlasenko wrote: What exactely would using kcalloc() over kzalloc() here buy us? technically, nothing. The idea of calloc is that it can check for underflow in parameter. Actually, overflow. calloc(0x, 0x1000) = will return NULL malloc(0x *

Re: Slow, persistent memory leak in 2.6.20

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 11:51, Fred Tyler wrote: On 8/26/07, Fred Tyler [EMAIL PROTECTED] wrote: I think I've come across a memory leak in 2.6.20. I've upgraded to the latest 2.6.20.17, but it didn't seem to help. Sorry to keep replying to my own post, but further investigation suggests that the memory

Re: Slow, persistent memory leak in 2.6.20

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 12:16, Fred Tyler wrote: Please rule out filesystem caches by issuing sync; echo 3 /proc/sys/vm/drop_caches; (Sorry if this goes to the list twice... Mailer problems.) alright.. Ok, I did this on a non-production machine that has only been up for a few hours,

Re: Slow, persistent memory leak in 2.6.20

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 12:49, Fred Tyler wrote: So I guess you are not seeing any memory leak at all, but just the regular caching? I certainly hope that is the case, but until I try it on the production machine tonight I won't know for sure. Note that not all kernels have the 'drop_caches' control

Re: Slow, persistent memory leak in 2.6.20

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 12:58, Fred Tyler wrote: So I guess you are not seeing any memory leak at all, but just the regular caching? Also, how can you explain the differences between the graphs of long-term memory usage? This first graph is from a server running 2.6.16 that never has memory problems:

Re: Slow, persistent memory leak in 2.6.20

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 13:41, Fred Tyler wrote: I'm going to run drop_caches on the 2.6.20 machines tonight and see what happens... Better add Slab to your graphs, that looks like it's the amount of non-cache kernel memory used. Jan -- - To unsubscribe from this list: send the line

Re: [parisc-linux] errno codes intertwined

2007-08-26 Thread Jan Engelhardt
On Aug 26 2007 13:45, Mike Frysinger wrote: can I rely on the same errno across Linuxes? nope And should the errno values be fixed up? i guess that depends on whether you think it's even broken :) no spec requires any errno symbol have an exact numeric value ... i'm guessing your FUSE is

Re: division and cpu usage

2007-08-28 Thread Jan Engelhardt
On Aug 28 2007 00:07, Luka Napotnik wrote: 2. I'm trying to get the percentage of CPU used for a certain task_struct and figured the following formula: (task-utime + task-stime) / jiffies This formula just doesn't work. I have a task with 99% CPU (top) but the result of that formula is

Re: division and cpu usage

2007-08-28 Thread Jan Engelhardt
On Aug 28 2007 12:41, Luka Napotnik wrote: How about this: === old_stime = task-stime; old_utime = task-utime old_j = jiffies; set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(1 * HZ); new_stime = task-stime; new_utime = task-utime; new_j = jiffies; sum =

Re: [patch v3 1/1] md: Software Raid autodetect dev list not array

2007-08-28 Thread Jan Engelhardt
On Aug 28 2007 06:08, Michael Evans wrote: Oh, I see. I forgot about the changelogs. I'd send out version 5 now, but I'm not sure what kernel version to make the patch against. 2.6.23-rc4 is on kernel.org and I don't see any git snapshots. 2.6.23-rc4 is a snapshot in itself, a tagged one at

Re: ok to kill ether= kernel parm?

2007-08-28 Thread Jan Engelhardt
On Aug 28 2007 10:23, H. Peter Anvin wrote: What's the upside of changing? What's the downside? The upside is so infinitesimal that that leaving ether= in indefinitely seems like a good move to me. Then why did it change to netdev= in the first place... Jan -- - To unsubscribe

Re: cpufreq affects traffic control rates

2007-08-29 Thread Jan Engelhardt
On Aug 28 2007 15:23, Stephen Hemminger wrote: I noticed lately that my traffic control rates were being very slow, about 40% less than expected, and finally spotted the problem: cpufreq. Looks like HTB puts buckets according to the requested rate but assuming that the CPU is

NFS4 authentification / fsuid

2007-08-30 Thread Jan Engelhardt
Hi, with NFS3, there is this 'root hole', i.e. any person who has a root account (perhaps by use of a laptop) can mount an export (let's say this export had the root_squash option), and still have a look at the user files, because he can locally setuid() into another user. So I was looking

Re: NFS4 authentification / fsuid

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 10:29, Trond Myklebust wrote: On Thu, 2007-08-30 at 16:12 +0200, Jan Engelhardt wrote: with NFS3, there is this 'root hole', i.e. any person who has a root account (perhaps by use of a laptop) can mount an export (let's say this export had the root_squash option), and still

Re: file system for solid state disks

2007-08-30 Thread Jan Engelhardt
On Aug 25 2007 09:41, Just Marc wrote: On SSDs which contain built in wear leveling, pretty much any file system can be used. For SSDs that lack such low level housekeeping, use stuff like JFFS2. The question is, how can you find out whether it does automatic wear-leveling? (Perhaps when

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 20:55, Denys Vlasenko wrote: Fwiw I do like your debloat patch a lot; it's just only half the equation ... if you also do the namespace fixes, I bet the driver debloats even more... Yes, I know, and I am happy to do that too. I just don't know whether patches will be accepted.

Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 21:49, Andrew Morton wrote: Umm, no way we're ever going to remove a syscall like this. Please stop this deprecration crap. Just make sure no ones adds more binary sysctls. I think it's worth a try. It might take two, three or five years, who knows? If it turns out to be

Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel

2007-08-30 Thread Jan Engelhardt
On Aug 27 2007 23:59, Thomas Bleher wrote: + for (cp = data - 1; cp != NULL; cp = strchr(cp + 1, '\n')) { + if (*++cp == '\0') + break; + if (sscanf(cp, %14s %30s\n, name, target) != 2) { + printk(%s:%d bad

Re: [PATCH] Use helpers to obtain task pid in printks (arch code)

2007-08-30 Thread Jan Engelhardt
On Aug 27 2007 11:01, Joe Perches wrote: On Mon, 2007-08-27 at 11:30 +0400, Pavel Emelyanov wrote: From: Alexey Dobriyan [EMAIL PROTECTED] One of the easiest things to isolate is the pid printed in kernel log. There was a patch, that made this for arch-independent code, this one makes so

Re: Pausing kernel boot messages

2007-08-30 Thread Jan Engelhardt
On Aug 27 2007 14:13, Hans-Jürgen Koch wrote: How do you pause the kernel boot messages ? ^S, Pause and Scroll lock do nothing and you can't Shift-Page-Up after a kernel panic. These are functions of a shell (like bash), Definitely not. The shell is not a console driver, it only

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 01:33, Alexey Dobriyan wrote: On Mon, Aug 27, 2007 at 01:40:31PM -0700, Joe Perches wrote: Add const to some struct task_struct * uses Why, oh, why? So that you can actually pass in a const struct task_struct * without having to cast it back to [non-const]. Why one would have

Re: Problems with IDE on linux 2.6.22.X

2007-08-30 Thread Jan Engelhardt
On Aug 28 2007 19:05, Rene Herman wrote: Okay Rene, I activated SCSI CD-ROM support in kernel config and now all works again. It's strange, because I never used this option to get my DVD device on. Sheesh. How could anyone _not_ understand you need SCSI CD-ROM support for your IDE DVD-RW

Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 16:54, Al Boldi wrote: What's the max length of a 40wire cable to sustain 80wire cable characteristics? Hard to tell, since some (most?) laptops have sort of a backplane and there might be no real cable you could see because it's all mainboard wire paths already. Jan

Re: Average number of instructions per line of kernel code

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 12:29, J. Scott Kasten wrote: On Thu, 30 Aug 2007, Mohamed Bamakhrama wrote: Hi all, I have a question regarding the average number of assembly instructions per line of kernel code. I know that this is a difficult question since it depends on many factors such as the

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 13:02, Matthew Wilcox wrote: Well, you can send it to Linus/Andrew, that will usually upset people and they start commenting on it. Or they don't, and everything is fine. (The default y approach so to speak ;-) The problem is that we don't really have a maintainer for the

Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814

2007-08-30 Thread Jan Engelhardt
On Aug 30 2007 15:47, Lennart Sorensen wrote: On Thu, Aug 30, 2007 at 09:38:23PM +0200, Jan Engelhardt wrote: Hard to tell, since some (most?) laptops have sort of a backplane and there might be no real cable you could see because it's all mainboard wire paths already. Makes you wonder why

Re: [PATCH] trivial - constify sched.h

2007-08-30 Thread Jan Engelhardt
On Aug 31 2007 02:11, Satyam Sharma wrote: So that you can actually pass in a const struct task_struct * without having to cast it back to [non-const]. ... which makes zero sense, because ... Why one would have a const struct task_struct * in the first place is a different matter. ...

Re: possible build system oddity

2007-08-31 Thread Jan Engelhardt
On Aug 31 2007 11:51, Oliver Neukum wrote: Am Freitag 31 August 2007 schrieb Sam Ravnborg: On Fri, Aug 31, 2007 at 01:14:26PM +0400, Alexey Dobriyan wrote: On 8/31/07, Oliver Neukum [EMAIL PROTECTED] wrote: I only touched sound/usb/usbaudio.c Nevertheless the whole subtree und sound/ is

Re: [RFD] Layering: Use-Case Composers (was: DRBD - what is it, anyways? [compare with e.g. NBD + MD raid])

2007-08-13 Thread Jan Engelhardt
On Aug 12 2007 20:21, [EMAIL PROTECTED] wrote: per the message below MD (or DM) would need to be modified to work reasonably well with one of the disk components being over an unreliable link (like a network link) Does not dm-multipath do something like that? are the MD/DM maintainers

RE: [PATCH] [470/2many] MAINTAINERS - TCP LOW PRIORITY MODULE

2007-08-13 Thread Jan Engelhardt
On Aug 13 2007 00:07, Joe Perches wrote: Hung Hing Lun (Chinese full name), Mike (English name) Wong Hoi Sing (Chinese full name), Edison (English name) Regards, Edison I believe commas will cause problems with some emailers. If you weren't allowed to use a comma, what would you choose to

Re: why use memcpy when memmove is there?

2007-08-13 Thread Jan Engelhardt
On Aug 13 2007 11:55, sk malik wrote: Subject: why use memcpy when memmove is there? memcpy copies a part of memory to some other location but It will not work for all cases of overlapping blocks.(if the start of destination block falls between the source block) while memove copes with

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

2007-08-13 Thread Jan Engelhardt
On Aug 13 2007 14:08, Jiri Kosina wrote: On Sun, 12 Aug 2007, David Miller wrote: Ok, 374 patches is just rediculious. So many patches eats up an enormous amount of mailing list resources, and for these patches in particular there are few reasons to split them up at all. The fact that the

Re: [1/2] 2.6.23-rc3: known regressions with patches

2007-08-13 Thread Jan Engelhardt
On Aug 13 2007 19:59, Michal Piotrowski wrote: Subject : Kconfig prompts without help text References : http://lkml.org/lkml/2007/7/16/326 Last known good : ? Submitter : Stefan Richter [EMAIL PROTECTED] Caused-By : ? Handled-By : Jan Engelhardt [EMAIL PROTECTED

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

2007-08-13 Thread Jan Engelhardt
On Aug 14 2007 00:02, Satyam Sharma wrote: Better solution is to have multiple MAINTAINERS files distributed in the kernel tree, IMHO -- say a drivers/net/MAINTAINERS for maintainer info on all various net drivers, drivers/kvm/MAINTAINERS for KVM maintainer info, fs/ext3/MAINTAINERS for ext3

Re: [PATCH] [133/2many] MAINTAINERS - CONEXANT ACCESSRUNNER USB DRIVER

2007-08-13 Thread Jan Engelhardt
On Aug 13 2007 11:43, Joe Perches wrote: There isn't _that_ much difference between sending a 200KB patch file and what I sent. Nail could use the ability to add a threading header though. On a technical side, there is a difference. 200 KB + 3 KB mail header = 203 KB. 550 mails each 3 KB =

Re: I have two 1394 port in my computer, why did I get only one eth1394 interface?

2007-08-14 Thread Jan Engelhardt
On Aug 13 2007 17:24, Stefan Richter wrote: 3. If I must plug my firewire line in some port, can I change the default port to use? The PHY may have several ports, but all of these ports belong to the same FireWire bus. The PHY not only connect the link layer controller with each port, it

Re: Distributed storage. Mirroring to any number of devices.

2007-08-14 Thread Jan Engelhardt
On Aug 14 2007 20:29, Evgeniy Polyakov wrote: I'm pleased to announce second release of the distributed storage subsystem, which allows to form a storage on top of remote and local nodes, which in turn can be exported to another storage as a node to form tree-like storages. I'll be quick: what

Re: O_NONBLOCK is broken

2007-08-14 Thread Jan Engelhardt
On Aug 14 2007 13:33, Alan Cox wrote: b) Make recv(fd, buf, size, flags) and send(fd, buf, size, flags); work with non-socket fds too, for flags==0 or flags==MSG_DONTWAIT. (it's ok to fail with socket op on non-socket fd for other values of flags) I think that makes a lot of sense,

Re: System call interposition/unprotecting the table

2007-08-14 Thread Jan Engelhardt
On Aug 14 2007 21:50, Andi Kleen wrote: Hajime Inoue [EMAIL PROTECTED] writes: Just protecting the table does not stop rootkits. A highly referenced phrack article explains how to bypass the table. During .23-pre for some time the kernel text was protected too (that would have likely

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, C guarantees that. but the constant value 0 when used in pointer context is always a null pointer

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 15 2007 10:37, Rene Herman wrote: On 08/15/2007 09:28 AM, Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, C

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 15 2007 11:58, Rene Herman wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, He said the null _pointer_ isn't guaranteed to be all-bits zero. And it isn't. Read the standard or the faq. 0 is all-bits-zero. NULL is 0. (It is.,

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 15 2007 09:58, Kyle Moffett wrote: Irrespective of whatever the standard says, EVERY platform and compiler anybody makes nowadays has a NULL pointer value with all bits clear. Theoretically the standard allows otherwise, but such a decision would break so much code. Linux

Re: Fork Bombing Patch

2007-08-16 Thread Jan Engelhardt
On Aug 16 2007 13:19, Krzysztof Halasa wrote: At least make that configurable - on some systems users are allowed 50 processes or so and I'm sure admins don't really want to know which particular users are currently close to limits. I don't really find the above useful. Perhaps we should warn

Re: which drive to pluck?

2007-08-16 Thread Jan Engelhardt
On Aug 16 2007 23:20, Dexter Filmore wrote: So I got 4 disks on the array, all on one controller. Now if I have to replace a drive, how do I tell which one to pull out? I really wouldn't know which one is sdb and which sdc. lsscsi. (And when you have the [a:b:c:d] tuple, just follow the

Re: nanosleep() accuracy

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 11:44, GolovaSteek wrote: How do you measure this? If you want to have something done every 300 microseconds, you must not sleep for 300 microseconds in each iteration, because you'd accumulate errors. Use a periodic timer or use the current time to compute how long to sleep

Re: nf_conntrack_ipv4 must be loaded explicitly

2007-08-17 Thread Jan Engelhardt
On Aug 2 2007 20:33, Patrick McHardy wrote: End result: After loading nf_conntrack_ipv4.ko, everything works again (also with the bad ff09b7). But I have to load it explicitly, and I think that unfortunately breaks a lot of setups (such as mine) which assume ipv4 connection tracking is

Re: [another git patch] move USB net drivers to drivers/net

2007-08-17 Thread Jan Engelhardt
Hi, On May 10 2007 18:12, Jan Engelhardt wrote: Subject: Re: [another git patch] move USB net drivers to drivers/net Hi Jeff, On May 9 2007 21:38, Jeff Garzik wrote: diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 59c0459..c5d8423 100644 --- a/drivers/net/Makefile +++ b/drivers

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 01:06, Atsushi Nemoto wrote: Add an MODULE_ALIAS() to make this platform driver hotplug-aware. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c index b2e5481..4bd22dc 100644 --- a/drivers/rtc/rtc-ds1742.c +++

Re: [PATCH] Make checkpatch rant about trailing ; at the end of if expr

2007-08-17 Thread Jan Engelhardt
On Aug 16 2007 10:21, Andy Whitcroft wrote: +if ($line =~ /\bif\s*\([^\)]*\)\s*\;/) { Heh, you are the second person to suggest this check today, do I detect some ripped out hair due to one of these! I've taken this idea and expanded it to cover if, for and while which can all

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 08:23, David Brownell wrote: On Friday 17 August 2007, Jan Engelhardt wrote: On Aug 17 2007 01:06, Atsushi Nemoto wrote: Add an MODULE_ALIAS() to make this platform driver hotplug-aware. ... +MODULE_ALIAS(ds1742); Why exactly is this needed? What script refers

Re: kfree(0) - ok?

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 11:22, Andrew Morton wrote: Which is getting pretty idiotic: akpm:/usr/src/25 grep ZERO_OR_NULL_PTR */*.c mm/slab.c: BUG_ON(ZERO_OR_NULL_PTR(cachep-slabp_cache)); mm/slab.c: if (unlikely(ZERO_OR_NULL_PTR(cachep))) mm/slab.c: if

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread Jan Engelhardt
On Aug 17 2007 12:50, David Brownell wrote: On Friday 17 August 2007, Kay Sievers wrote: On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote: On Friday 17 August 2007, Kay Sievers wrote: Again, Again? We exchanges several mails a few weeks ago after the Debian bug caused by a

Re: kfree(0) - ok?

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 01:40, Thomas Gleixner wrote: Do we really ? If yes, who invented this 1980s reminiscence, where you got valid pointers for malloc(0) ? This is completely stupid. You do not go into a bar and order an empty glass, just because you might eventually become thirsty later.

Re: Panic with XFS on RHEL5 (2.6.18-8.1.8.el5)

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 13:31, Måns Rullgård wrote: BUG: unable to handle kernel paging request at virtual address b8af9d60 printing eip: c0415974 *pde = Oops: [#1] SMP last sysfs file: /block/loop7/dev Modules linked in: loop nfsd exportfs lockd nfs_acl iscsi_trgt(U) autofs4 hidp

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 20:07, Satyam Sharma wrote: On Fri, 17 Aug 2007, Geert Uytterhoeven wrote: On Thu, 16 Aug 2007, NeilBrown wrote: [...] dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from %lu\n, - __func__, __LINE__, i,

Re: power off disk drives while running

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 12:08, Marty Leisner wrote: In embedded system design, it may be useful to poweroff the disks (as opposed to merely spinning them down). We want to leave the system running while the disk is powered down, and let the disk powerup when it needs to be spun up. That means you also

Re: Panic with XFS on RHEL5 (2.6.18-8.1.8.el5)

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 17:28, Chris Boot wrote: I will. This will probably be on Monday now, since the machine isn't accepting SysRq requests over the serial console. :-( Ah yeah, stupid null-modem cables! You can also trigger sysrq from /proc/sysrq-trigger (well, as long as the system lives)

Re: how to add debug information into the vmlinux

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 21:49, Xu Yang wrote: I tried as what you told me. and the vmlinux does contain debug information. but the start address of this vmlinux is 0xc0008000. when I tried to run this vmlinux, the program always exit at 0x80a0. I checked out that here is the place mmu is turned on. so I

Re: power off disk drives while running

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 14:22, Robert Hancock wrote: I see this a a very important feature in the embedded system relm, I have worked on two projects that required extreme power management, and massive data storage. The ability to fully turn off a drive while the system is running is key. It seems

Re: how to add debug information into the vmlinux

2007-08-18 Thread Jan Engelhardt
On Aug 18 2007 22:01, Xu Yang wrote: this vmlinux file is running on my software virtual prototype system. and my software enviorment can only load elf file, so I am using this real vmlinux file. Maybe there is a problem in your virtual prototype system (VM?). Jan -- - To unsubscribe

Re: variable length argument support (was: [OT] Re: The vi editor causes brain damage)

2007-08-19 Thread Jan Engelhardt
On Aug 19 2007 14:39, Paolo Ornati wrote: WT Under unix, the shell resolves * and passes the 1 file names WT to the rm command. Now, execve() may fail because 1 names in WT arguments can require too much memory. That's why find and xargs WT were invented! It would be very handy if

[no patch] Remove more double inclusions

2007-08-19 Thread Jan Engelhardt
Hi, Pipes for the world... find . -type f -iname *.[ch] -print0 | \ xargs -0 grep -P '#\s*include' /dev/null | \ sort | \ uniq -c | \ sort -gr | \ less -MSi turns up all the double-inclusions. Needs someone to review, because odd things like

Re: convert #include linux/... to #include linux/... [PATCH]s follow

2007-08-19 Thread Jan Engelhardt
On Aug 19 2007 15:17, Joe Perches wrote: There are several files that: #include linux/file not #include linux/file #include asm/file not #include asm/file Not only that. All directories in include should be checked against (e.g. net/*) Jan -- - To unsubscribe from this list: send the

Re: [PATCH] Make checkpatch rant about trailing ; at the end of if expr

2007-08-20 Thread Jan Engelhardt
On Aug 20 2007 13:52, Bodo Eggert wrote: But. The above regex does not seem to handle if ((a = b)); oops; I have tried to come up with a superduper regex that handles multiple (), but my regex fu seems to stop above two pairs of (). This is because you can't do that using finite regular

Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

2007-08-20 Thread Jan Engelhardt
On Aug 20 2007 13:21, Geert Uytterhoeven wrote: dev_dbg(dev-sbd.core, %s:%u: bio %u: %u segs %u sectors from %lu\n, - __func__, __LINE__, i, bio_segments(bio), - bio_sectors(bio), sector); -

[patch] Refine FAT chmod checks

2007-08-20 Thread Jan Engelhardt
with the on-disk format. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- fs/fat/file.c | 47 +++ 1 file changed, 43 insertions(+), 4 deletions(-) Index: linux-2.6.22/fs/fat/file.c === --- linux

Re: [patch] Refine FAT chmod checks

2007-08-20 Thread Jan Engelhardt
Hi, On Aug 21 2007 00:17, OGAWA Hirofumi wrote: Jan Engelhardt [EMAIL PROTECTED] writes: when a vfat filesystem is mounted without the quiet option, chown fails, but chmod still succeeds. I think that is wrong. Could you explain why this is wrong more? Suppose a vfat filesystem is mounted

Re: [patch] Refine FAT chmod checks

2007-08-20 Thread Jan Engelhardt
is not reread from disk, and chown will silently do nothing, not even return the new uid/gid in stat(). Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- fs/fat/file.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) Index: linux-2.6.22/fs/fat

Re: How Linux /proc filesystem convert a fd to the actual pathname?

2007-08-20 Thread Jan Engelhardt
In the Linux proc filesystem, /proc/[pid]/fd is a link to the actually the actual pathname of the opened file. I am curious how Linux convert an fd to the pathname? Does it recursively walk back from current dentry to the root? AFAICS the fd has a pointer to the vma of the file (don't ask me

Re: Trouble booting with new 2.6.22.3 kernel

2007-08-21 Thread Jan Engelhardt
On Aug 21 2007 12:29, Hex Star wrote: Btw, I am not using a initramfs image.. success = (using_initramfs ide == 'M') || ide == 'Y'; HTH. Jan -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Trouble booting with new 2.6.22.3 kernel

2007-08-21 Thread Jan Engelhardt
On Aug 21 2007 12:42, Hex Star wrote: On 8/21/07, Jan Engelhardt [EMAIL PROTECTED] wrote: success = (using_initramfs ide == 'M') || ide == 'Y'; Thanks for the replies guys, I am building the ata_piix and ata_generic drivers into the kernel now...hope this works :) You do not need ata_generic

Re: Trouble booting with new 2.6.22.3 kernel

2007-08-21 Thread Jan Engelhardt
On Aug 21 2007 22:56, Ismail Dönmez wrote: On Tuesday 21 August 2007 22:27:25 you wrote: On 8/21/07, Hex Star [EMAIL PROTECTED] wrote: Ah so the IDE/SATA driver should not be a module (if it is a module it'll cause this issue)? One more thing, are there any other critical kernel components

Re: [PATCH] Console keyboard events and accessibility

2007-08-21 Thread Jan Engelhardt
On Aug 21 2007 02:57, Samuel Thibault wrote: Some external modules like Speakup need to use the PC keyboard to control them and also need to get keyboard feedback (caps lock status, etc.) This adds a keyboard notifier that such modules can use to get the keyboard events and possibly eat them,

Re: [Patch] panic.c

2007-08-05 Thread Jan Engelhardt
On Aug 5 2007 17:28, Jörg Hoffmann wrote: Hello everybody, (This is the first time i send in a patch, so correct me if I’m doing something wrong) See Documentation/SubmittingPatches. (And perhaps, U+0092 should be replaced by something visible ;-) This patch causes the cpu to stop instead of

Re: MODULE_LICENSE usage

2007-08-06 Thread Jan Engelhardt
On Aug 6 2007 17:53, Nathan Williams wrote: Hi, I'm working on a driver for an ADSL modem which requires the use of a binary library from the chipset manufacturer. All my source code is GPL, [...] I've given permission for the binary library file to be used with the GPL source code and be

Few interrupts with NO_HZ

2007-08-06 Thread Jan Engelhardt
Hi, this more of an informational question. So: kernel version is 2.6.22.1 on i686 /proc/uptime 9917.81 9140.90 (2h45m) /proc/cpuinfo: CPU0 0:282 IO-APIC-edge timer this is kinda neat, I expected much more interrupts than just 282 since boot. What kernel code

Re: Few interrupts with NO_HZ

2007-08-06 Thread Jan Engelhardt
On Aug 6 2007 09:47, Chris Snook wrote: this more of an informational question. So: kernel version is 2.6.22.1 on i686 /proc/uptime 9917.81 9140.90 (2h45m) /proc/cpuinfo: CPU0 0:282 IO-APIC-edge timer this is kinda neat, I expected much more interrupts than

Re: Linux 2.6.23-rc2

2007-08-06 Thread Jan Engelhardt
On Aug 5 2007 21:26, Jeff Chua wrote: Here's what see when I cat /dev/vcs1 ... ÿÿÿ The pattern repeats and fill the whole screen. That looks pretty much like all-one-bits (ÿ = 255). What about vcsa1 (use hexdump -C)? Jan --

Re: [PATCH] take sched_debug.c out of nasal demon territory

2007-08-06 Thread Jan Engelhardt
On Aug 6 2007 04:26, Al Viro wrote: C99 6.10.3[11]: preprocessing directive within the argument list of macro invocation = undefined behaviour. Don't do that... String concatenation (a b) is not a preprocessing directive. $ gcc -E test.c # 1 test.c # 1 built-in # 1 command line # 1

Re: Linux 2.6.23-rc2

2007-08-06 Thread Jan Engelhardt
On Aug 7 2007 00:06, Jeff Chua wrote: On 8/6/07, Jan Engelhardt [EMAIL PROTECTED] wrote: ÿÿÿ That looks pretty much like all-one-bits (ÿ = 255). What about vcsa1 (use hexdump -C)? # hexdump -C /dev/vcsa1 19 50 00 18 ff ff ff ff ff ff ff ff ff ff

Re: + remove-current-defines-and-uses-of-pr_err-add-pr_emerg.patch added to -mm tree

2007-08-07 Thread Jan Engelhardt
On Aug 7 2007 09:10, Joe Perches wrote: On Sat, 2007-08-04 at 18:47 +0200, Jean Delvare wrote: On 8/4/2007, Jan Engelhardt [EMAIL PROTECTED] wrote: Ugh. What do we have printk for then? I do not like this. For pr_debug() it makes sense because its semantics change with -DDEBUG and -UDEBUG

Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.

2007-08-07 Thread Jan Engelhardt
On Aug 7 2007 13:43, Greg KH wrote: added this 64-bit bug: unsigned int flags; spin_lock_irqsave(task-lock, flags); irq 'flags' must be unsigned long, not unsigned int. The -rt tree has strict checks about this on 64-bit so this triggered a build

Re: [2.6.22.2 review 18/84] Fix sparc32 udelay() rounding errors.

2007-08-07 Thread Jan Engelhardt
On Aug 7 2007 13:44, Greg KH wrote: --- a/arch/sparc/kernel/entry.S +++ b/arch/sparc/kernel/entry.S @@ -1749,8 +1749,8 @@ fpload: __ndelay: save%sp, -STACKFRAME_SZ, %sp mov %i0, %o0 - call.umul - mov0x1ad, %o1 ! 2**32 / (1 000 000 000 / HZ)

Re: [2.6.22.2 review 26/84] make timerfd return a u64 and fix the __put_user

2007-08-07 Thread Jan Engelhardt
On Aug 7 2007 13:44, Greg KH wrote: --- a/fs/timerfd.c +++ b/fs/timerfd.c @@ -95,7 +95,7 @@ static ssize_t timerfd_read(struct file { struct timerfd_ctx *ctx = file-private_data; ssize_t res; - u32 ticks = 0; + u64 ticks = 0; DECLARE_WAITQUEUE(wait, current);

Re: why are some atomic_t's not volatile, while most are?

2007-08-07 Thread Jan Engelhardt
On Aug 7 2007 15:38, Chris Friesen wrote: Even now, powerpc (as an example) defines atomic_t as: typedef struct { volatile int counter; } atomic_t That volatile is there precisely to force the compiler to dereference it every single time. Actually, the dereference will be done once (or

<    3   4   5   6   7   8   9   10   11   12   >