[PATCH 1/4] printk: Hand over printing to console if printing too long

2015-08-19 Thread Jan Kara
From: Jan Kara j...@suse.cz Currently, console_unlock() prints messages from kernel printk buffer to console while the buffer is non-empty. When serial console is attached, printing is slow and thus other CPUs in the system have plenty of time to append new messages to the buffer while one CPU

[PATCH 2/4] printk: Start printing handover kthreads on demand

2015-08-19 Thread Jan Kara
From: Jan Kara j...@suse.cz Start kthreads for handing over printing only when printk.offload_chars is set to value 0 (i.e., when print offloading gets enabled). Signed-off-by: Jan Kara j...@suse.cz --- kernel/printk/printk.c | 65 +++--- 1 file

[PATCH 0/4] printk: Softlockup avoidance

2015-08-19 Thread Jan Kara
From: Jan Kara j...@suse.cz Hello, since lately there were several attempts at dealing with softlockups due to heavy printk traffic [1] [2] and I've been also privately pinged by couple of people about the state of the patch set, I've decided to respin the patch set. To remind the original

[PATCH 4/4] printk: Add config option for disabling printk offloading

2015-08-19 Thread Jan Kara
From: Jan Kara j...@suse.cz Necessity for offloading of printing was observed only for large systems. So add a config option (disabled by default) which removes most of the overhead added by this functionality. Signed-off-by: Jan Kara j...@suse.cz --- Documentation/kernel-parameters.txt | 13

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

2015-08-24 Thread Jan Kara
. Honza -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

2015-08-24 Thread Jan Kara
this thread is indeed fixing the real problem but the comment in sync_inodes_sb() should be fixed to mention wait_sb_inodes() must be called in all cases... Tejun, will you fixup the comment please? Honza -- Jan Kara j...@suse.com SUSE

Re: [GIT PULL] ext4 changes for 4.2-rc1

2015-06-29 Thread Jan Kara
with the revert Linus did. That's the best we can do now. I'm now trying to figure out what could have gone wrong. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [GIT PULL] ext4 changes for 4.2-rc1

2015-06-29 Thread Jan Kara
is violated to make sure we don't see false positives. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 26/51] writeback: let balance_dirty_pages() work on the matching cgroup bdi_writeback

2015-06-30 Thread Jan Kara
(); if (unlikely(current-nr_dirtied = ratelimit)) - balance_dirty_pages(mapping, current-nr_dirtied); + balance_dirty_pages(mapping, wb, current-nr_dirtied); + + wb_put(wb); } EXPORT_SYMBOL(balance_dirty_pages_ratelimited); -- 2.4.0 -- Jan Kara j...@suse.cz

Re: [PATCH 25/51] writeback: attribute stats to the matching per-cgroup bdi_writeback

2015-06-30 Thread Jan Kara
, this doesn't lead to visible behavior differences. v2: Updated for per-inode wb association. Signed-off-by: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Jan Kara j...@suse.cz Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz

Re: [PATCH 31/51] writeback: implement WB_has_dirty_io wb_state flag

2015-06-30 Thread Jan Kara
|wb}_has_dirty_io()'s return values to bool. These functions were returning 0 and 1 before. Also, add a comment explaining the synchronization of wb_state flags. Looks good. You can add: Reviewed-by: Jan Kara j...@suse.com Honza

Re: [PATCH 27/51] writeback: make congestion functions per bdi_writeback

2015-06-30 Thread Jan Kara
is swapped for cosmetic reason. This patch just adds the new wb based functions. The following patches will apply them. Looks good to me. You can add: Reviewed-by: Jan Kara j...@suse.com Honza v2: Updated for bdi_writeback_congested

Re: [PATCH 32/51] writeback: implement backing_dev_info-tot_write_bandwidth

2015-06-30 Thread Jan Kara
just compute the total write bandwidth when needed, instead of maintaining it all the time? Honza Signed-off-by: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Jan Kara j...@suse.cz --- fs/fs-writeback.c

Re: [PATCH 30/51] writeback: implement and use inode_congested()

2015-06-30 Thread Jan Kara
independent from the asking task. Drop @task. Spotted by Vivek. Also, converted to take @inode instead of @mapping and renamed to inode_congested(). Signed-off-by: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Jan Kara j...@suse.cz Cc: Vivek Goyal vgo...@redhat.com

Re: [PATCH 34/51] writeback: don't issue wb_writeback_work if clean

2015-06-30 Thread Jan Kara
writeback support as we may end up issuing noop work items to a lot of clean wb's. Signed-off-by: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Jan Kara j...@suse.cz Looks good. You can add: Reviewed-by: Jan Kara j...@suse.com

Re: [PATCH 29/51] writeback, blkcg: propagate non-root blkcg congestion state

2015-06-30 Thread Jan Kara
(). Note that we still need those tests when !CONFIG_CGROUP_WRITEBACK as otherwise we'll end up flipping root blkcg wb's congestion state for events happening on other blkcgs. v2: Updated for bdi_writeback_congested. Looks good. You can add: Reviewed-by: Jan Kara j...@suse.com

Re: [PATCH 28/51] writeback, blkcg: restructure blk_{set|clear}_queue_congested()

2015-06-30 Thread Jan Kara
to block/blk-core.c. This patch doesn't introduce any noticeable behavior difference. Looks good. You can add: Reviewed-by: Jan Kara j...@suse.com BTW, I'd prefer if this was merged with the following patch. I was wondering for a while about the condition at the beginning of blk_clear_congested

Re: [RFCv2][PATCH 3/7] fs: fsnotify: replace memory barrier in __sb_end_write() with RCU

2015-06-26 Thread Jan Kara
-by: Jan Kara j...@suse.cz Honza Cc: Jan Kara j...@suse.cz Cc: Alexander Viro v...@zeniv.linux.org.uk Cc: linux-fsde...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Tim Chen

Re: [RFCv2][PATCH 2/7] fs: use RCU for free_super() vs. __sb_start_write()

2015-06-26 Thread Jan Kara
the current RCU period finishes. And synchronize_rcu() must make sure that any code (loads / stores) after it execute only after the RCU period has finished... The patch looks good to me. You can add: Reviewed-by: Jan Kara j...@suse.com

Re: [PATCH 33/51] writeback: make bdi_has_dirty_io() take multiple bdi_writeback's into account

2015-06-30 Thread Jan Kara
: Jan Kara j...@suse.cz --- fs/fs-writeback.c| 5 +++-- include/linux/backing-dev-defs.h | 8 ++-- include/linux/backing-dev.h | 10 +- mm/backing-dev.c | 5 - mm/page-writeback.c | 10 +++--- 5 files changed, 25

Re: [PATCH 32/51] writeback: implement backing_dev_info-tot_write_bandwidth

2015-06-30 Thread Jan Kara
On Tue 30-06-15 18:14:58, Jan Kara wrote: On Fri 22-05-15 17:13:46, Tejun Heo wrote: cgroup writeback support needs to keep track of the sum of avg_write_bandwidth of all wb's (bdi_writeback's) with dirty inodes to distribute write workload. This patch adds bdi-tot_write_bandwidth

Re: [PATCH 19/51] bdi: make inode_to_bdi() inline

2015-06-30 Thread Jan Kara
in description as suggested by Jan. Signed-off-by: Tejun Heo t...@kernel.org Reviewed-by: Jens Axboe ax...@kernel.dk Cc: Christoph Hellwig h...@infradead.org Looks good. Reviewed-by: Jan Kara j...@suse.com Honza --- fs/block_dev.c

Re: [PATCH 23/51] writeback: make backing_dev_info host cgroup-specific bdi_writebacks

2015-06-30 Thread Jan Kara
kind of obvious once you realize that ;). Other than that the patch looks good so you can add: Reviewed-by: Jan Kara j...@suse.com A few nits below. +/** + * wb_find_current - find wb for %current on a bdi + * @bdi: bdi of interest + * + * Find the wb of @bdi which matches both the memcg

Re: [PATCH 4/4] change sb_writers to use percpu_rw_semaphore

2015-07-28 Thread Jan Kara
improve on code readability... Anyway, you can add: Reviewed-by: Jan Kara j...@suse.com Honza Note: with this change both freeze_super() and thaw_super() will do synchronize_sched_expedited() 3 times. This is just ugly

Re: [PATCH 3/4] shift percpu_counter_destroy() into destroy_super_work()

2015-07-28 Thread Jan Kara
-by: Jan Kara j...@suse.com Honza --- fs/super.c | 23 +++ include/linux/fs.h |3 ++- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/fs/super.c b/fs/super.c index b4db3ee

Re: [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure

2015-08-05 Thread Jan Kara
parts will be dropped in the next merge window anyway so it doesn't really matter. You can add: Reviewed-by: Jan Kara j...@suse.com Honza Signed-off-by: Michal Hocko mho...@suse.com --- fs/jbd/transaction.c | 11

Re: [RFC 5/8] ext4: Do not fail journal due to block allocator

2015-08-05 Thread Jan Kara
add: Reviewed-by: Jan Kara j...@suse.com Honza Signed-off-by: Michal Hocko mho...@suse.com --- fs/ext4/mballoc.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4

Re: [FYI] tux3: Core changes

2015-08-03 Thread Jan Kara
in mmapped memory... Honza -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [FYI] tux3: Core changes

2015-08-03 Thread Jan Kara
On Fri 31-07-15 13:44:44, OGAWA Hirofumi wrote: Jan Kara j...@suse.cz writes: Yes, if userspace truncates the file, the situation we end up with is basically the same. However for truncate to happen some malicious process has to come and truncate the file - a failure scenario

Re: [PATCH 0/3] Remove ext3 filesystem driver

2015-07-29 Thread Jan Kara
On Wed 29-07-15 15:20:06, Konstantin Khlebnikov wrote: On 15.07.2015 13:26, Jan Kara wrote: Hello, so I have created this patch set which removes ext3 driver (and some related support code) from the kernel. See changelog of patch 2/3 for more details. If noone objects, I

Re: [PATCH, RFC 2/2] dax: use range_lock instead of i_mmap_lock

2015-08-11 Thread Jan Kara
or faulting) * mm-mmap_sem + *mapping-mapping_lock * page-flags PG_locked (lock_page) * mapping-i_mmap_rwsem * anon_vma-rwsem -- 2.5.0 -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [patch] quota: remove an unneeded condition

2015-08-11 Thread Jan Kara
) -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/4] change sb_writers to use percpu_rw_semaphore

2015-08-11 Thread Jan Kara
On Tue 11-08-15 15:16:26, Oleg Nesterov wrote: On 08/11, Dave Chinner wrote: On Mon, Aug 10, 2015 at 04:59:42PM +0200, Jan Kara wrote: One would like to construct the lock chain as: CPU0 (chown foo dir) CPU1 (readdir dir) CPU2 (page fault) process Y process X

Re: [PATCH, RFC 2/2] dax: use range_lock instead of i_mmap_lock

2015-08-11 Thread Jan Kara
or not. Honza -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

2015-08-14 Thread Jan Kara
into bdi_split_work_to_wbs(). * Making bdi_split_work_to_wbs() consider the b_dirty_time list for WB_SYNC_ALL writebacks. Signed-off-by: Tejun Heo t...@kernel.org Fixes: e79729123f63 (writeback: don't issue wb_writeback_work if clean) Cc: Ted Ts'o ty...@google.com Cc: Jan Kara j...@suse.com So the patch

Re: [PATCH 0/4] change sb_writers to use percpu_rw_semaphore

2015-08-10 Thread Jan Kara
; + sb_freeze_release(sb); up_write(sb-s_umount); return 0; } -- 1.5.5.1 -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [FYI] tux3: Core changes

2015-08-10 Thread Jan Kara
On Sun 09-08-15 22:42:42, OGAWA Hirofumi wrote: Jan Kara j...@suse.cz writes: I'm not sure about which ENOSPC issue you are speaking BTW. Can you please ellaborate? 1. GUP simulate page fault, and prepare to modify 2. writeback clear dirty, and make PTE read-only 3. snapshot/reflink

Re: Warning at mm/truncate.c:740

2015-08-10 Thread Jan Kara
on the same inode (whether there isn't something else protecting this). Al should know better... Honza -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] fs: create and use seq_show_option for escaping

2015-08-10 Thread Jan Kara
. Signed-off-by: Kees Cook keesc...@chromium.org Cc: sta...@vger.kernel.org Looks good to me. You can add: Acked-by: Jan Kara j...@suse.com Honza --- fs/ceph/super.c | 2 +- fs/cifs/cifsfs.c | 6

Re: [PATCH 3.19.y-ckt 096/107] fsnotify: fix oops in fsnotify_clear_marks_by_group_flags()

2015-08-06 Thread Jan Kara
-- From: Jan Kara j...@suse.cz commit a2673b6e040663bf16a552f8619e6bde9f4b9acf upstream. fsnotify_clear_marks_by_group_flags() can race with fsnotify_destroy_marks() so when fsnotify_destroy_mark_locked() drops mark_mutex, a mark from the list iterated by fsnotify_clear_marks_by_group_flags

Re: fs: Remove ext3 filesystem driver In-Reply-To: 20150715124709.ga11...@quack.suse.cz

2015-07-22 Thread Jan Kara
/15 15:52, Jan Kara wrote: The functionality of ext3 is fully supported by ext4 driver. Major distributions (SUSE, RedHat) already use ext4 driver to handle ext3 filesystems for quite some time. There is some ugliness in mm resulting from jbd cleaning buffers in a dirty page without cleaning

Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore

2015-07-21 Thread Jan Kara
. Thanks! Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[GIT PULL] UDF fix for 4.2

2015-07-21 Thread Jan Kara
corrupt unalloc spacetable when writing it The diffstat is fs/udf/inode.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) Thanks Honza -- Jan Kara j

Re: [PATCH 1/4] introduce __sb_{acquire,release}_write() helpers

2015-07-21 Thread Jan Kara
Nice. You can add: Reviewed-by: Jan Kara j...@suse.com Honza --- fs/btrfs/transaction.c |8 ++-- fs/xfs/xfs_aops.c |6 ++ include/linux/fs.h |5 + 3 files changed, 9 insertions(+), 10 deletions

Re: [PATCH 4/4] change thaw_super() to re-acquire s_writers.lock_map

2015-07-21 Thread Jan Kara
(). Signed-off-by: Oleg Nesterov o...@redhat.com Ah, I was confused for a moment why this doesn't trigger a lockdep warning because of lock inversion between s_umount and freeze protection but you use trylock in sb_freeze_acquire(). So things are fine. You can add: Reviewed-by: Jan Kara j

Re: [PATCH 2/4] fix the broken lockdep logic in __sb_start_write()

2015-07-21 Thread Jan Kara
and it will be trivial: just kill __sb_start_write() and rename do_sb_start_write() back to __sb_start_write(). The patch looks good. Did you test this BTW? You can add: Reviewed-by: Jan Kara j...@suse.com Honza Signed-off-by: Oleg

Re: [PATCH 3/4] move rwsem_release() from sb_wait_write() to freeze_super()

2015-07-21 Thread Jan Kara
the write locks we hold when we call s_op-freeze_fs(sb). Signed-off-by: Oleg Nesterov o...@redhat.com Good. You can add: Reviewed-by: Jan Kara j...@suse.com Honza --- fs/super.c | 16 ++-- 1 files changed, 10

Re: [PATCH] mm/Kconfig: NEED_BOUNCE_POOL: clean-up condition

2015-07-23 Thread Jan Kara
y if TILE USB_OHCI_HCD config NR_QUICK int -- 1.9.1 -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: linux-next: manual merge of the akpm-current tree with the FIXME tree

2015-07-23 Thread Jan Kara
have fixed up MAINTAINERS file in my tree (amended the original commit). Honza -- Jan Kara j...@suse.com SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [RFC][PATCH] fs: Prevent syncing frozen file system

2015-07-13 Thread Jan Kara
On Fri 10-07-15 22:42:40, Lukáš Czerner wrote: On Fri, 10 Jul 2015, Jan Kara wrote: Date: Fri, 10 Jul 2015 16:25:25 +0200 From: Jan Kara j...@suse.cz To: Dave Chinner da...@fromorbit.com Cc: Lukas Czerner lczer...@redhat.com, v...@zeniv.linux.org.uk, bfie...@fieldses.org, linux

Re: [PATCH 07/10] dax: Add huge page fault support

2015-07-13 Thread Jan Kara
__dax_mkwrite(vma, vmf, gb, iod) __dax_fault(vma, vmf, gb, iod) -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara j

Re: [PATCH 1/4] change get_super_thawed() to use sb_start/end_write()

2015-07-14 Thread Jan Kara
... Honza put_super(s); } } -- 1.5.5.1 -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore

2015-07-14 Thread Jan Kara
conversion idea looks good to me. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore

2015-07-16 Thread Jan Kara
On Wed 15-07-15 20:19:20, Oleg Nesterov wrote: On 07/15, Jan Kara wrote: So I'm also in favor of Oleg's approach as well. We just have to wait until he fixes the outstanding issues with his code. Yes. I'll try to make the working version, hopefully this week. But, Dave, just send

Re: [PATCH 0/3] Remove ext3 filesystem driver

2015-07-16 Thread Jan Kara
On Wed 15-07-15 08:01:05, Joe Perches wrote: On Wed, 2015-07-15 at 12:26 +0200, Jan Kara wrote: I have created this patch set which removes ext3 driver (and some related support code) from the kernel. See changelog of patch 2/3 for more details. It'd be nice if you regenerate 2/3 using

Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore

2015-07-16 Thread Jan Kara
On Thu 16-07-15 00:30:27, Dave Hansen wrote: On 07/16/2015 12:26 AM, Jan Kara wrote: So Dave's patches would go in only in the next merge window anyway so we still have like two-three weeks to decide which patchset to take. If you think it will take you longer, then merging Dave's patches

Re: [PATCH 0/3] Remove ext3 filesystem driver

2015-07-16 Thread Jan Kara
On Wed 15-07-15 10:18:36, Ted Tso wrote: On Wed, Jul 15, 2015 at 12:26:24PM +0200, Jan Kara wrote: so I have created this patch set which removes ext3 driver (and some related support code) from the kernel. See changelog of patch 2/3 for more details. If noone objects, I

Re: [PATCH 2/3] fs: Remove ext3 filesystem driver

2015-07-16 Thread Jan Kara
On Wed 15-07-15 09:58:22, Andrew Morton wrote: On Wed, 15 Jul 2015 12:26:26 +0200 Jan Kara j...@suse.com wrote: From: Jan Kara j...@suse.cz The functionality of ext3 is fully supported by ext4 driver. Major distributions (SUSE, RedHat) already use ext4 driver to handle ext3

[PATCH 0/4 v2] Remove ext3 filesystem driver

2015-07-16 Thread Jan Kara
Hello, here is the second iteration of my patches to remove ext3 filesystem driver. Changes since the first version are: * Regenerated the patch removing ext3 (using git format-patch -D) so that it's not so huge * Added Kconfig option handling so that old configs with EXT3_FS set but not

[PATCH 4/4] ext4: Improve ext4 Kconfig test

2015-07-16 Thread Jan Kara
Now that ext4 driver must be used to access ext3 filesystems, improve the Kconfig help text to better explain that using ext4 driver to access the filesystem is fully compatible with the old ext3 driver. Signed-off-by: Jan Kara j...@suse.com --- fs/ext4/Kconfig | 13 +++-- 1 file changed

[PATCH 2/4] fs: Remove ext3 filesystem driver

2015-07-16 Thread Jan Kara
From: Jan Kara j...@suse.cz The functionality of ext3 is fully supported by ext4 driver. Major distributions (SUSE, RedHat) already use ext4 driver to handle ext3 filesystems for quite some time. There is some ugliness in mm resulting from jbd cleaning buffers in a dirty page without cleaning

[PATCH 3/4] block: Remove forced page bouncing under IO

2015-07-16 Thread Jan Kara
From: Jan Kara j...@suse.cz JBD layer wrote back data buffers without setting PageWriteback bit. Thus standard mechanism for guaranteeing stable pages under IO did not work. Since JBD is gone now and there is no other user of the functionality, just remove it. Acked-by: Jens Axboe ax

[PATCH 1/4] doc: Update doc about journalling layer

2015-07-16 Thread Jan Kara
misleading and outdated. Signed-off-by: Jan Kara j...@suse.com --- Documentation/DocBook/filesystems.tmpl | 178 + 1 file changed, 67 insertions(+), 111 deletions(-) diff --git a/Documentation/DocBook/filesystems.tmpl b/Documentation/DocBook/filesystems.tmpl index

Re: [PATCH RFC 0/4] change sb_writers to use percpu_rw_semaphore

2015-07-15 Thread Jan Kara
usually merges fsnotify stuff. Thanks. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH 3/3] block: Remove forced page bouncing under IO

2015-07-15 Thread Jan Kara
From: Jan Kara j...@suse.cz JBD layer wrote back data buffers without setting PageWriteback bit. Thus standard mechanism for guaranteeing stable pages under IO did not work. Since JBD is gone now and there is no other user of the functionality, just remove it. CC: Jens Axboe ax...@kernel.dk

[PATCH 1/3] doc: Update doc about journalling layer

2015-07-15 Thread Jan Kara
misleading and outdated. Signed-off-by: Jan Kara j...@suse.com --- Documentation/DocBook/filesystems.tmpl | 178 + 1 file changed, 67 insertions(+), 111 deletions(-) diff --git a/Documentation/DocBook/filesystems.tmpl b/Documentation/DocBook/filesystems.tmpl index

[PATCH 0/3] Remove ext3 filesystem driver

2015-07-15 Thread Jan Kara
Hello, so I have created this patch set which removes ext3 driver (and some related support code) from the kernel. See changelog of patch 2/3 for more details. If noone objects, I will queue the series in my tree for the next merge window. Jens, are you OK with me merging patch 3/3 or do

Re: [PATCH 0/3] Remove ext3 filesystem driver

2015-07-15 Thread Jan Kara
On Wed 15-07-15 14:02:56, Nikolay Borisov wrote: On 07/15/2015 01:26 PM, Jan Kara wrote: Hello, so I have created this patch set which removes ext3 driver (and some related support code) from the kernel. See changelog of patch 2/3 for more details. If noone objects, I

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

2015-08-24 Thread Jan Kara
On Mon 24-08-15 15:32:42, Tejun Heo wrote: Hello, Jan. On Mon, Aug 24, 2015 at 09:08:47PM +0200, Jan Kara wrote: Inode may contain writeback pages (but not dirty pages) without being on any of the dirty lists. That is correct. Josef Bacik had patches to create Hmmm... Can you please

Re: [PATCH 5/5] block: enable dax for raw block devices

2015-10-24 Thread Jan Kara
On Thu 22-10-15 23:41:27, Williams, Dan J wrote: > On Thu, 2015-10-22 at 23:08 +0200, Jan Kara wrote: > > On Thu 22-10-15 16:05:46, Williams, Dan J wrote: > > > On Thu, 2015-10-22 at 11:35 +0200, Jan Kara wrote: > > > > On Thu 22-10-15 02:42:11, Dan Williams wrot

Re: [PATCH 5/5] block: enable dax for raw block devices

2015-10-24 Thread Jan Kara
On Fri 23-10-15 16:32:57, Dan Williams wrote: > On Thu, Oct 22, 2015 at 2:08 PM, Jan Kara <j...@suse.cz> wrote: > > On Thu 22-10-15 16:05:46, Williams, Dan J wrote: > [..] > >> This text was aimed at the request from Ross to document the differences > >

Re: [PATCH RFC] fsnotify: destroy marks with call_srcu instead of dedicated thread

2015-10-24 Thread Jan Kara
f marks by group->i_fsnotify_marks. Also reused for queueing >* mark into destroy_list when it's waiting for the end of SRCU period >* before it can be freed. [group->mark_mutex] */ Please update this comment to not speak about destroy_

Re: Triggering non-integrity writeback from userspace

2015-10-24 Thread Jan Kara
grity fix) which changed do_sync_mapping_range() to use WB_SYNC_ALL because it had other users which relied WB_SYNC_ALL semantics. Later that got copied over to the current sync_file_range() implementation. I think we should just revert to the very explicitely documented behavior of sync_file_range

Re: [PATCH] printk: Don't discard earlier unprinted messages to make space

2015-10-22 Thread Jan Kara
*need* to have a mode where serial console is actually *reliable*, > and we can know that the message has been sent out the port before the > printk() call returns. > > What happened to it? And how do we fix it? Hard to fix since you'd easily get RCU stalls and softlockup message

Re: [PATCH v2 4/5] block: introduce bdev_file_inode()

2015-10-22 Thread Jan Kara
On Thu 22-10-15 13:10:38, Dan Williams wrote: > Similar to the file_inode() helper, provide a helper to lookup the inode for a > raw block device itself. > > Cc: Al Viro <v...@zeniv.linux.org.uk> > Suggested-by: Jan Kara <j...@suse.cz> > Signed-off-by: Dan Will

Re: [PATCH 5/5] block: enable dax for raw block devices

2015-10-22 Thread Jan Kara
On Thu 22-10-15 16:05:46, Williams, Dan J wrote: > On Thu, 2015-10-22 at 11:35 +0200, Jan Kara wrote: > > On Thu 22-10-15 02:42:11, Dan Williams wrote: > > > If an application wants exclusive access to all of the persistent memory > > > provided by an NVDIMM namespace it

Re: [PATCH 4/5] block: introduce file_bd_inode()

2015-10-22 Thread Jan Kara
t; ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *to) > { > struct file *file = iocb->ki_filp; > - struct inode *bd_inode = file->f_mapping->host; > + struct inode *bd_inode = file_bd_inode(file); > loff_t size = i_size_read(bd_inode); > loff_t pos = iocb->ki_pos; > > -- Jan Kara <j...@suse.com> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 5/5] block: enable dax for raw block devices

2015-10-22 Thread Jan Kara
sors wanting to provision persistent memory for > guests. > > Cc: Jan Kara <j...@suse.cz> > Cc: Jeff Moyer <jmo...@redhat.com> > Cc: Christoph Hellwig <h...@lst.de> > Cc: Dave Chinner <da...@fromorbit.com> > Cc: Andrew Morton <a...@linux-foundation.org

Re: [PATCH 2/5] dax: increase granularity of dax_clear_blocks() operations

2015-10-22 Thread Jan Kara
introducing a dax_map_atomic() operation that temporarily pins a dax > mapping move the call to cond_resched() to the outer loop. > > Signed-off-by: Dan Williams <dan.j.willi...@intel.com> The patch looks good to me. You can add: Reviewed-

[PATCH 5/7] printk: Add config option for disabling printk offloading

2015-10-25 Thread Jan Kara
From: Jan Kara <j...@suse.cz> Necessity for offloading of printing was observed only for large systems. So add a config option (disabled by default) which removes most of the overhead added by this functionality. Signed-off-by: Jan Kara <j...@suse.cz> --- Documentation/kernel-pa

[PATCH 4/7] panic: Always flush printk buffer before panic

2015-10-25 Thread Jan Kara
console buffer printed out on crash is top priority. So zap printk locks and print logbuf contents after all cpus have been stopped. Based on patch by Vitaly Kuznetsov. CC: Vitaly Kuznetsov <vkuzn...@redhat.com> Reported-and-tested-by: Vitaly Kuznetsov <vkuzn...@redhat.com> Signed-off-

[PATCH 1/7] printk: Hand over printing to console if printing too long

2015-10-25 Thread Jan Kara
From: Jan Kara <j...@suse.cz> Currently, console_unlock() prints messages from kernel printk buffer to console while the buffer is non-empty. When serial console is attached, printing is slow and thus other CPUs in the system have plenty of time to append new messages to the buffer while o

[PATCH 0/6 v2] printk: Softlockup avoidance

2015-10-25 Thread Jan Kara
From: Jan Kara <j...@suse.cz> Hello, here is another posting of the revived patch set to avoid lockups during heavy printing. Lately there were several attempts at dealing with softlockups due to heavy printk traffic [1] [2] and I've been also privately pinged by couple of people about the

[PATCH 6/7] printk: Avoid scheduling printing threads on the same CPU

2015-10-25 Thread Jan Kara
to take over printing. CPU hotplug makes this more difficult than it should be but we cope by redistributing kthreads among CPUs when some kthread is not able to run anywhere. Signed-off-by: Jan Kara <j...@suse.com> --- kernel/printk/printk.c | 105 --

[PATCH 3/7] kernel: Avoid softlockups in stop_machine() during heavy printing

2015-10-25 Thread Jan Kara
From: Jan Kara <j...@suse.cz> When there are lots of messages accumulated in printk buffer, printing them (especially over serial console) can take a long time (tens of seconds). stop_machine() will effectively make all cpus spin in multi_cpu_stop() waiting for the CPU doing printing to pri

[PATCH 2/7] printk: Start printing handover kthreads on demand

2015-10-25 Thread Jan Kara
From: Jan Kara <j...@suse.cz> Start kthreads for handing over printing only when printk.offload_chars is set to value > 0 (i.e., when print offloading gets enabled). Signed-off-by: Jan Kara <j...@suse.cz> --- kernel/printk/printk.c | 78 +--

Re: [PATCH 3/7] kernel: Avoid softlockups in stop_machine() during heavy printing

2015-10-25 Thread Jan Kara
Hmph, sorry for the x/7 numbering. Patch 7 was the debug patch which I didn't send... Honza On Mon 26-10-15 05:52:46, Jan Kara wrote: > From: Jan Kara <j...@suse.cz> > > When there are lots of messages accumu

Re: [PATCH 5/5] block: enable dax for raw block devices

2015-10-26 Thread Jan Kara
ould keep it hidden in fs/super.c and fs/block_dev.c). I can have a look at that once ext4 dax support works unless someone beats me to it... Honza -- Jan Kara <j...@suse.com> SUSE Labs, CR -- To unsubscribe from this lis

[GIT PULL] ext2 changes for 4.4-rc1

2015-11-09 Thread Jan Kara
/ext4/Kconfig | 2 +- 5 files changed, 105 insertions(+), 5 deletions(-) Thanks Honza -- Jan Kara <j...@suse.com> SUSE Labs, CR -- To unsubscribe from this list: send th

Re: [RFC] namei: prevent sgid-hardlinks for unmapped gids

2015-11-10 Thread Jan Kara
e you want to hook into but quite a few filesystems (most notably ext4, xfs, btrfs) overload ->page_mkwrite() callbacks to their own functions so each filesystem that does this needs to be updated separately... Honza -- Jan Kara <j...@suse.com> SUSE

Re: [lkp] [ext4] dfbd72d0d6: -100.0% xfstests.ext4.001.seconds

2015-11-10 Thread Jan Kara
On Tue 10-11-15 13:26:51, kernel test robot wrote: > FYI, we noticed the below changes on > > https://github.com/0day-ci/linux > Jan-Kara/ext4-Fix-races-between-page-faults-and-hole-punching/20151105-002716 > commit dfbd72d0d6f10086064b918419fb2094ff9fbdb6 ("ext4: Fix r

Re: [GIT PULL] ext2 changes for 4.4-rc1

2015-11-10 Thread Jan Kara
On Mon 09-11-15 17:40:11, Linus Torvalds wrote: > On Mon, Nov 9, 2015 at 5:09 AM, Jan Kara <j...@suse.cz> wrote: > > > > to get fixes for DAX for ext2 and a minor fixup for ext4 Kconfig > > description (leftover from ext3 removal). > > You already sent the ext4 K

Re: [patch] ncpfs: don't allow negative timeouts

2015-11-10 Thread Jan Kara
rqdata.timeout = > NCP_LOCK_DEFAULT_TIMEOUT; > else if (rqdata.timeout > > NCP_LOCK_MAX_TIMEOUT) > rqdata.timeout = > NCP_LOCK_MAX_TIMEOUT; -- Jan Kara <j...@suse.com> SUSE Labs,

Re: [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Jan Kara
ying bio-based dm-crypt to form larger chunks for encryption HW would be superior in this regard. You mentioned that you use requests because of size limitations on bios - I had a look and current struct bio can easily describe 1MB requests (that's assuming 64-bit architecture, 4KB pages) w

Re: [PATCH] mm: Allow GFP_IOFS for page_cache_read page cache allocation

2015-11-12 Thread Jan Kara
I think it makes sense to discuss it even out of that scope. > > I would like to hear FS and other MM people about the proposed interface. > Using mapping_gfp_mask blindly doesn't sound good to me and vm_fault > looks like a proper channel to communicate between MM and FS layers.

Re: [PATCH] jbd2: redefine jbd2_get_transaction to jbd2_init_transaction

2015-11-12 Thread Jan Kara
in our case. > > Also remove the return value as it is unused. > > Signed-off-by: Alexandru Moise <00moses.alexande...@gmail.com> This is a border-line of a pointless churn but the original name was poor so OK. You can add: Review

Re: [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Jan Kara
On Thu 12-11-15 17:40:59, Baolin Wang wrote: > On 12 November 2015 at 17:17, Jan Kara <j...@suse.cz> wrote: > > On Thu 12-11-15 10:15:32, Baolin Wang wrote: > >> On 11 November 2015 at 17:48, Christoph Hellwig <h...@infradead.org> wrote: > >> > On Wed, Nov

Re: [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Jan Kara
On Thu 12-11-15 19:46:26, Baolin Wang wrote: > On 12 November 2015 at 19:06, Jan Kara <j...@suse.cz> wrote: > > On Thu 12-11-15 17:40:59, Baolin Wang wrote: > >> On 12 November 2015 at 17:17, Jan Kara <j...@suse.cz> wrote: > >> > On Thu 12-11-15 10:15:32,

Re: [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Jan Kara
On Thu 12-11-15 20:51:10, Baolin Wang wrote: > On 12 November 2015 at 20:24, Jan Kara <j...@suse.cz> wrote: > > On Thu 12-11-15 19:46:26, Baolin Wang wrote: > >> On 12 November 2015 at 19:06, Jan Kara <j...@suse.cz> wrote: > >> > On Thu 12-11-15 17:40:59,

Re: Flush requests not going through IO scheduler

2015-11-12 Thread Jan Kara
Also blk_insert_flush() can add request directly to q->queue_head when no flushing is required. I've sent patch to fix that to go through IO scheduler but it is mostly a non-issue as usually generic_make_request_checks() removes FLUSH and FUA flags when they are not needed.

<    1   2   3   4   5   6   7   8   9   10   >