t;
> In this case thread 1 returns before the data for the dirty entry is
> actually durable on media.
>
> Fix this by only clearing the PAGECACHE_TAG_TOWRITE flag after all flushing
> is complete.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Repo
On Thu 21-01-16 10:46:02, Ross Zwisler wrote:
> Several of the subtleties and assumptions of the DAX fsync/msync
> implementation are not immediately obvious, so document them with comments.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Reported-by: J
e same time and don't flush entries that are beyond end_index.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Just one nit below. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
> ---
> fs/dax.c | 39 +++
> 1 file chan
get something helpful from
> bh.b_bdev for error messages and not have to worry about whether it was set
> by get_block() or not.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Reported-by: Jan Kara <j...@suse.cz>
Looks g
on
> non-allocating page faults.
>
> Instead, keep track of when get_block() actually gives us storage so that
> we can be sure to only remove zero pages that were covering holes.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Reported-by: Jan Kara <j
ing removed, we delay the reaper job slightly when
> queueing it, to allow several to gather on the list.
>
> Cc: Jan Kara <j...@suse.com>
> Cc: Eric Paris <epa...@parisplace.org>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Cc: Eryu Guan <guan
hout
this information I don't think the discussion would be very useful. So can
you provide some rough numbers?
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
; + inode_to_wb(inode) == isw->new_wb)
> + goto out_unlock;
> +
> + if (!atomic_inc_not_zero(>i_sb->s_active))
> + goto out_unlock;
> +
> inode->i_state |= I_WB_SWITCH;
> spin_unlock(>i_lock);
>
> @@ -489,6 +494,8 @@ static void inode_switch_wbs(struct inode *inode, int
> new_wb_id)
> call_rcu(>rcu_head, inode_switch_wbs_rcu_fn);
> return;
>
> +out_unlock:
> + spin_unlock(>i_lock);
> out_free:
> if (isw->new_wb)
> wb_put(isw->new_wb);
> --
> 2.5.0
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
This allows us to have strict DAX vs non-DAX paths in the writeback code.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/ext
lt in data corruption. This was observed with xfstests ext4/307 and
> ext4/308.
>
> Fix this by only allowing online defrag for non-DAX files.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
We need to handle this eventually but for now we are fine. You can
and raw block device code to pass in an appropriate struct block_device.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Suggested-by: Dan Williams <dan.j.willi...@intel.com>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
ses so using DAX regresses some
functionality.
Honza
> Cc: Jan Kara <j...@suse.cz>
> Cc: Jens Axboe <ax...@fb.com>
> Cc: Al Viro <v...@ftp.linux.org.uk>
> Cc: Dave Chinner <da...@fromorbit.com>
> Cc: Ross Zwisler <ross.zwis...@linux.int
] mount_bdev+0x180/0x1b0
> [] ? ext4_calculate_overhead+0x370/0x370
> [] ext4_mount+0x15/0x20
> [] mount_fs+0x38/0x170
>
> Mark the support broken so its disabled by default, but otherwise still
> available for testing.
>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Jens Axboe
(IS_DAX(inode)) {
> > + ext4_msg(sb, KERN_ERR,
> > +"Online defrag not supported with DAX");
> > + err = -EOPNOTSUPP;
> > + goto mext_out;
> > }
> >
> > err = mnt_want_write_file(filp);
> > --
> > 2.5.0
> >
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Wed 17-02-16 16:07:44, Tejun Heo wrote:
> Hello, Jan.
>
> On Wed, Feb 17, 2016 at 09:57:21PM +0100, Jan Kara wrote:
> > Well, but this has the side-effect that trying to umount a filesystem while
> > migrations are happening will result in EBUSY error. Without o
es, we need a
reference for each mountpoint. s_umount is used when we want to block any
umount operation until we are done. For example sync(2) is using it to make
sure superblock doesn't disappear and so that we don't keep superblock
alive after admin called umount(2).
On Wed 17-02-16 21:51:56, Shaun Tancheff wrote:
> On Wed, Feb 17, 2016 at 5:36 PM, Dave Chinner <da...@fromorbit.com> wrote:
>
> On Wed, Feb 17, 2016 at 04:21:55PM +0100, Jan Kara wrote:
> > On Sat 13-02-16 01:50:09, Changho Choi-SSI wrote:
> &g
Hi Tejun,
On Thu 18-02-16 08:00:33, Tejun Heo wrote:
> On Thu, Feb 18, 2016 at 10:55:38AM +0100, Jan Kara wrote:
> > I'm not sure I understand the question. Do you mean why both s_active and
> > s_umount rwsem exist? s_active is a reference count keeping superblock
>
> Ye
off-by: Tejun Heo <t...@kernel.org>
> Reported-by: Tahsin Erdogan <tah...@google.com>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Al Viro <v...@zeniv.linux.org.uk>
> Link:
> http://lkml.kernel.org/g/caaeu0ancq7lgodvvgru-ou_o-6enii5ey0p1c26d1zzywkd...@mail.gmail.com
> Fix
tree and commit:
>
> 74c66bcb7eda ("ext4: Fix data exposure after failed AIO DIO")
>
> from the xfs tree.
>
> I fixed it up (see below) and can carry the fix as necessary (no action
> is required).
Thanks. The merge looks correct.
tree and commit:
>
> 74c66bcb7eda ("ext4: Fix data exposure after failed AIO DIO")
>
> from the xfs tree.
>
> I fixed it up (see below) and can carry the fix as necessary (no action
> is required).
Thanks! This merge looks correct as well.
On Wed 09-03-16 15:09:50, Sergey Senozhatsky wrote:
> Hello Jan,
>
> On (03/07/16 13:16), Jan Kara wrote:
> [..]
> > > So if this will be a problem in practice, using a kthread will probably be
> > > the easiest solution.
> >
> > Hum, and thinking more
e'd need to make inode_to_bdi() result stable while we work with the
block device inode. Christoph, do you have any idea how to cleanly achieve
that? All I'm able to come up with are ugly hacks...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
);
> + irq_work_queue(this_cpu_ptr(_up_klogd_work));
You cannot call wake_up() from a scheduler context - i.e., if in_sched is
true, you have to use irq work unconditionally. You can wake up kthread
from irq work or just directly print the message there. Otherwise the patch
loo
On Fri 11-03-16 12:56:10, Tejun Heo wrote:
> Hello, Jan.
>
> On Thu, Mar 03, 2016 at 10:33:10AM +0100, Jan Kara wrote:
> > > Ugh... that's nasty. I wonder whether the right thing to do is making
> > > writeback workers non-freezable. IOs are supposed to be blocked fr
On Mon 14-03-16 10:37:22, Alan Stern wrote:
> On Mon, 14 Mar 2016, Jan Kara wrote:
>
> > On Fri 11-03-16 12:56:10, Tejun Heo wrote:
> > > Hello, Jan.
> > >
> > > On Thu, Mar 03, 2016 at 10:33:10AM +0100, Jan Kara wrote:
> > > > > Ugh...
if (console_trylock())
console_unlock();
}
}
...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Mon 14-03-16 18:42:58, Rabin Vincent wrote:
> (fixed Jens' address)
>
> On Thu, Mar 10, 2016 at 06:37:27PM +0100, Jan Kara wrote:
> > On Thu 10-03-16 13:26:03, Rabin Vincent wrote:
> > > If a block device is closed while iterate_bdevs() is handling it, the
>
d, can you please pick it up? Thanks!
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 07-04-16 21:08:26, Sergey Senozhatsky wrote:
> Hello,
>
> On (04/07/16 18:48), Sergey Senozhatsky wrote:
> > On (04/06/16 10:27), Jan Kara wrote:
> > [..]
> > > > Well, it's good that we have this.
> > > >
> > > > It would
On Mon 04-04-16 15:51:49, Andrew Morton wrote:
> On Tue, 5 Apr 2016 01:57:27 +0900 Sergey Senozhatsky
> <sergey.senozhat...@gmail.com> wrote:
>
> > From: Jan Kara <j...@suse.cz>
> >
> > Currently, printk() sometimes waits for message to be printed to cons
+ wb->dirty_sleeping = 1;
> io_schedule_timeout(pause);
> + wb->dirty_sleeping = 0;
Huh, but wb->dirty_sleeping is shared by all the processes in the system.
So this is seriously racy, isn't it? You rather need a counter for this to
work.
gt; - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
>
> - page_cache_get() -> get_page();
>
> - page_cache_release() -> put_page();
>
> Signed-off-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
gt; - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
>
> - page_cache_get() -> get_page();
>
> - page_cache_release() -> put_page();
>
> Signed-off-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
> Cc: Jan Kara <j...@suse.com>
R
gt; - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
>
> - page_cache_get() -> get_page();
>
> - page_cache_release() -> put_page();
>
> Signed-off-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
> Cc: Jan Kara <j...@suse.com>
et %llu, size %zd\n",
> - iocb->private, io_end->inode->i_ino, iocb, offset,
> - size);
> + io_end, io_end->inode->i_ino, iocb, offset, size);
>
> + iocb->private = NULL;
The line above should not exist in the result.
t; Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> Hi,
>
> Noticed this issue when running make htmldocs.
>
> It gives
ink you need to mention the
console_unlock() async patch when it is not part of the series. BTW, you
seemed to have dropped my patch to skip if there are too many buffered
messages when oops is in progress. Any reason for that?
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
ly need more clever logic in detecting when to
skip. Let's drop it for now and revisit it later if it is an issue. Thanks
for explanation.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
.
>
> According to POSIX, zero length reads "do not modify the last data access
> timestamp" and thus, the IOCB_DIRECT behaviour is POSIXly correct.
>
> Let generic_file_read_iter() unconditionally check the requested read
> length at its entry and return immediate
struct pcpu_list_node, list);
> + return true;
Waiman, I repeat it for the third time as you keep ignoring it: This is
*racy*. The list for state->cpu can be empty by the time you acquire
state->lock and thus state->curr will point somewhere around the head of
the list but def
on issues for printk_deferred() messages which are supposed to be
working from under rq->lock and similar. So I think you have to keep this
section outside of logbuf_lock.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Mon 21-03-16 23:58:32, Sergey Senozhatsky wrote:
> Hello Jan,
>
> On (03/21/16 15:32), Jan Kara wrote:
> [..]
> > > we have 2 spin locks in vprintk_emit() -- logbuf_lock and sem->lock. and N
> > > CPUs can concurrently lockup on those two locks, which al
uota: Fixup comments about return value of Q_[X]GETNEXTQUOTA
ext4: Make Q_GETNEXTQUOTA work for quota in hidden inodes
Jan Kara (8):
Merge branch 'xfs-get-next-dquot-4.6' of
git://git.kernel.org/.../dgc/linux-xfs into for_next
quota: Allow Q_GETQUOTA for frozen filesystem
udf:
d from panic_cpu can go via async printk.
>
> I though that it actually could be an advantage. console_verbore() is
> called also by oops_begin() and it does not need to be fatal. But you
> are right that it does not need to be the righ approach.
If we oops, I want printk to be sync regardl
On Wed 23-03-16 23:30:20, Sergey Senozhatsky wrote:
> Hello,
>
> On (03/23/16 14:20), Jan Kara wrote:
> [..]
> > > I though that it actually could be an advantage. console_verbore() is
> > > called also by oops_begin() and it does not need to be fatal. But yo
On Mon 07-03-16 11:52:48, Jan Kara wrote:
> On Mon 07-03-16 19:12:33, Sergey Senozhatsky wrote:
> > Hello,
> >
> > On (03/07/16 09:22), Jan Kara wrote:
> > [..]
> > > > hm, just for note, none of system-wide wqs seem to have a ->rescu
On Mon 07-03-16 19:12:33, Sergey Senozhatsky wrote:
> Hello,
>
> On (03/07/16 09:22), Jan Kara wrote:
> [..]
> > > hm, just for note, none of system-wide wqs seem to have a ->rescuer thread
> > > (WQ_MEM_RECLAIM).
> > >
> > > [..]
&g
deleting locked entry so that we catch when someone doesn't properly obey
the locking protocol... But I'm still somewhat hesitating whether it would
not be better to move the locking out of generic radix tree code since it
is not quite as generic as I'd like and e.g. clear_exceptional_entry()
would us
.@newtec.dk>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
The patch looks good. Thanks for fixing this! You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
>
> Maybe we sh
Signed-off-by: Jan Kara <j...@suse.cz>
---
kernel/printk/printk.c | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 03f5278b47b4..8ac60219059a 100644
--- a/kernel/printk/printk.c
and then the oops message.
Signed-off-by: Jan Kara <j...@suse.cz>
---
kernel/printk/printk.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 73ec760a4bc8..03f5278b47b4 100644
--- a/kernel/
ble purpose: exclusive printk() lock and a
> console_drivers list lock.
Well, but changing how console locking works is a separate issue, isn't it?
So please as a separate patch set if you want to try it.
Actually I don't think changing the locking will be so easy.
console_lock/unlock is used e.g. for console blanking where you need to
block any printing while you call ->unblank() for each console. That being
said I don't think improvement is impossible, just given my experiences
with console / printk code there will be surprises waiting for you :).
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
to the original printk behavior.
Signed-off-by: Jan Kara <j...@suse.cz>
---
Documentation/kernel-parameters.txt | 10 +++
kernel/printk/printk.c | 146 +---
2 files changed, 97 insertions(+), 59 deletions(-)
diff --git a/Documentation/kernel-parameters.
benefit much from this
>feature.
Hum, it seems you've missed my comment in [1] regarding a race I found.
[1] http://www.spinics.net/lists/linux-fsdevel/msg95052.html
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> type)
>
> dquots = i_dquot(inode);
>
> + memset(got, 0, 3 * sizeof(struct dquot *));
> +
> /* First get references to structures we might need. */
> for (cnt = 0; cnt < MAXQUOTAS; cnt++) {
> struct kqid qid;
> --
> 2.5
filesystems and there are issues
with that (Jiri Kosina was the last one which was trying to make this work
AFAIR). And I think you need to stop writeback (and generally any IO) to be
generated so that it doesn't interact in a strange way with device drivers
being frozen. So IMO until suspend freezes filesystems & devices properly
you have to freeze writeback workqueue.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 03-03-16 20:26:55, Tetsuo Handa wrote:
> On 2016/03/03 0:59, Jan Kara wrote:
> > This patch makes printk() completely asynchronous (similar to what
> > printk_deferred() did until now). It appends message to the kernel
> > printk buffer and queues work to do th
ctive(wq)) {
> + struct wait_bit_key key = {.flags = root, .bit_nr = -2,
> +.timeout = index};
> + __wake_up(wq, TASK_NORMAL, 1, );
> + }
> +}
> +EXPORT_SYMBOL(radix_tree_unlock);
> +
> +void radix_tree_delet
On Tue 01-03-16 18:22:25, Denys Vlasenko wrote:
> On Mon, Oct 26, 2015 at 5:52 AM, Jan Kara <j...@suse.com> wrote:
> > This patch implements a mechanism where after printing specified number
> > of characters (tunable as a kernel parameter printk.offload_chars), CPU
&g
king much by doing it in this cycle, so I'd vote for
> doing it now.
Yeah, without CGROUP_WRITEBACK enabled this patch is NOP so I don't care
much when this gets merged.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
c() won't loop forever
when there's nothing to print. And that is all we need...
I think the simplicity of this is worth the possible extra loops in
printk_kthread_func().
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
Hello Linus,
could you please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_linus
to get fixes for oops when the new quotactl gets used with quotas disabled.
Top of the tree is 8f9e8f5fcc05. The full shortlog is:
Jan Kara (2):
quota: Handle
On Sat 02-04-16 13:58:19, Andy Lutomirski wrote:
> [cc Jan Kara]
>
> On Sat, Apr 2, 2016 at 1:47 PM, Borislav Petkov <b...@alien8.de> wrote:
> > On Sat, Apr 02, 2016 at 01:13:37PM -0700, Andy Lutomirski wrote:
> >> Given that I this isn't really a regression wit
e message in the buffer, not before. Doesn't
matter for correctness now but may be more future-proof.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
Identifier and Volume Set Identifier fields.
> The function is also renamed to udf_dstrCS0toUTF8 to distinctly
> indicate that it handles 'dstring' input.
Thanks. I've merged the patch to my tree.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
ore of "why we do this?" than pure
"what we do".
> +
> + if (!stat_sample_valid(stat))
> + return LAT_UNKNOWN;
> +
> + /*
> + * If the 'min' latency exceeds our target, step down.
> + */
> + if (stat[0].min > rwb->min_lat_nsec) {
> + trace_wbt_lat(rwb->bdi, stat[0].min);
> + trace_wbt_stat(rwb->bdi, stat);
> + return LAT_EXCEEDED;
> + }
> +
> + if (rwb->scale_step)
> + trace_wbt_stat(rwb->bdi, stat);
> +
> + return LAT_OK;
> +}
> +
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Wed 27-04-16 14:59:15, Jens Axboe wrote:
> On Wed, Apr 27 2016, Jens Axboe wrote:
> > On Wed, Apr 27 2016, Jens Axboe wrote:
> > > On 04/27/2016 12:01 PM, Jan Kara wrote:
> > > >Hi,
> > > >
> > > >On Tue 26-04-16 09:55:23, Jens Axboe
QUOTA_NL_A_DEV_MINOR,
> QUOTA_NL_A_CAUSED_ID,
> + QUOTA_NL_A_PAD,
> __QUOTA_NL_A_MAX,
> };
> #define QUOTA_NL_A_MAX (__QUOTA_NL_A_MAX - 1)
> --
> 2.8.1
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
otational SATA drive with writeback cache, queue depth of the
disk reported in /sys/block/sdb/device/queue_depth is 1.
So I think we still need some tweaking on the low end of the storage
spectrum so that we don't lose 10% of throughput for simple cases like
this.
On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote:
> Le 26/04/2016 13:08, Jan Kara a écrit :
> > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> >> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com>
> >
> > OK, so I somewhat miss a description
uture. Something like 'can_print_async()'? But I don't
feel too strongly about that so feel free to add:
Reviewed-by: Jan Kara <j...@suse.cz>
regardless whether you change this or not.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
in DAX code? Or just provide stable page guarantees
from DAX and do the redundancy from device mapper? This needs more
thought...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
; >^
> > > include/linux/dax.h:39:5: error: unknown type name ___dax_iodone_t___
> > > dax_iodone_t di)
> > > ^
> > > In file included from mm/vmscan.c:49:0:
> > > include/linux/dax.h:14:3: error: unknown type name ___dax_iodone_t___
&
ed this patch to my tree, I have just changed
s_partition_ref to s_phys_partition_ref and added a comment about it to
udf_sb.h..
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
(IS_ERR(inode))
> return 0x;
> retblk = udf_try_read_meta(inode, block, partition, offset);
> }
> --
> 2.5.5
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
inode, block, partition, offset);
> if (retblk == 0x && mdata->s_metadata_fe) {
> udf_warn(sb, "error reading from METADATA, trying to read from
> MIRROR\n");
> --
> 2.1.4
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
c, map->s_partition_num);
> + if (IS_ERR(mdata->s_mirror_fe))
> + mdata->s_mirror_fe = NULL;
> mdata->s_flags |= MF_MIRROR_FE_LOADED;
> }
>
> --
> 2.1.4
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Wed 11-05-16 08:25:10, Toshi Kani wrote:
> On Wed, 2016-05-11 at 10:05 +0200, Jan Kara wrote:
> > On Tue 10-05-16 10:23:57, Toshi Kani wrote:
> > >
> > > blkdev_dax_capable() is similar to bdev_dax_supported(), but needs
> > > to remain as a separate i
On Tue 03-05-16 14:17:19, Jan Kara wrote:
> The question remains how common a pattern where throttling of background
> writeback delays also something else is. I'll schedule a couple of
> benchmarks to measure impact of your patches for a wider range of workloads
> (but sadly pretty
istoph Hellwig <h...@infradead.org>
> Cc: Dave Chinner <da...@fromorbit.com>
> Cc: Jan Kara <j...@suse.cz>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Signed-off-by: Vishal Verma <vishal.l.ve...@intel
g <h...@lst.de>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
BTW: You are supposed to add your Signed-off-by when forwarding patches
like this...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
gets freed with scsi-mq or deadline IO scheduler so that we
have 100% certain config.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
istoph Hellwig <h...@infradead.org>
> Cc: Dave Chinner <da...@fromorbit.com>
> Cc: Jan Kara <j...@suse.cz>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
...
> +static bool dax_range_is_aligned(struc
lines is
actually reporting appropriate mount error in dmesg and that is
fs-dependent so it needs to stay in the filesystem... So what do you have
in mind?
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> Reported-by: Micah Parrish <micah.parr...@hpe.com>
> Signed-off-by: Toshi Kani <toshi.k...@hpe.com>
> Cc: "Theodore Ts'o" <ty...@mit.edu>
> Cc: Andreas Dilger <adilger.ker...@dilger.ca>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Dan Williams &l
that
> window, then treat that case as if it had completed but exceeded the min
> latency. And then scale back.
>
> We'll always treat a state sample with 1 read as valuable, but for this
> case, we don't have that sample until it completes.
>
> Does that make more sense?
OK, makes sense. Thanks for explanation.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Tue 03-05-16 08:40:11, Chris Mason wrote:
> On Tue, May 03, 2016 at 02:17:19PM +0200, Jan Kara wrote:
> > On Thu 28-04-16 12:46:41, Jens Axboe wrote:
> > > >>- rwb->wb_max = 1 + ((depth - 1) >> min(31U, rwb->scale_step));
> > > >
(but inherent in its journal design) and we
have a way to deal with this either by enabling delayed allocation or by
turning off the writeback throttling...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
gt; Signed-off-by: Toshi Kani <toshi.k...@hpe.com>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Dan Williams <dan.j.willi...@intel.com>
> Cc: Ross Zwisler <ross.zwis...@linux.intel.com>
> Cc: Christoph Hellwig <h...@infradead.org>
> Cc: Boaz Harrosh <b...@plex
On Tue 03-05-16 17:40:32, Jan Kara wrote:
> On Tue 03-05-16 11:34:10, Jan Kara wrote:
> > Yeah, once I'll hunt down that regression with old disk, I can have a look
> > into how writeback throttling plays together with blkio-controller.
>
> So I've tried the following scrip
On Tue 03-05-16 08:23:27, Jens Axboe wrote:
> On 05/03/2016 03:34 AM, Jan Kara wrote:
> >On Thu 28-04-16 12:53:50, Jens Axboe wrote:
> >>>2) As far as I can see in patch 8/8, you have plugged the throttling above
> >>>the IO scheduler. When there are e.g
On Tue 03-05-16 11:34:10, Jan Kara wrote:
> Yeah, once I'll hunt down that regression with old disk, I can have a look
> into how writeback throttling plays together with blkio-controller.
So I've tried the following script (note that you need cgroup v2 for
writeback IO to be thr
in mind and was wondering if you are OK with it
> since I am incline to keep the ext2/4 message style as majority rule. :)
> https://lkml.org/lkml/2016/5/3/543
>
> Assuming that's OK, I will make this change.
Yeah, just send me ext2 changes on top of your v2 and I can pull it to my
tree.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
; a month ago but the bug is still present.
Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
le is
rather harsh for persistent memory as well...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
With patch % change
> - --
> Read-only 16499MB/s 17215MB/s+4.3%
> Read-write 4361MB/s4794MB/s+9.9%
>
> Signed-off-by: Waiman Long <waiman.l...@hpe.com>
The patch looks good
On Thu 05-05-16 07:27:48, Christoph Hellwig wrote:
> On Thu, May 05, 2016 at 04:16:37PM +0200, Jan Kara wrote:
> > We cannot easily do this currently - the reason is that in several places we
> > wait for i_dio_count to drop to 0 (look for inode_dio_wait()) while
> > ho
t being that reducing the span of the
> dax request may avoid the error region.
>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
501 - 600 of 6478 matches
Mail list logo
