t; those, that is now redundant, so remove those paragraphs
>
> Cc: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
> Signed-off-by: Matthew Wilcox <matthew.r.wil...@intel.com>
> [vishal: Also remove the dax_clear_sectors function entirely]
> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
gt; + length / bdev_logical_block_size(bdev),
> + GFP_NOFS, true);
This is actually wrong. blkdev_issue_zeroout() expects length to be simply
in units of 512-bytes. So you need length >> 9 here.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Tue 03-05-16 09:42:40, Chris Mason wrote:
> On Tue, May 03, 2016 at 03:06:09PM +0200, Jan Kara wrote:
> > On Tue 03-05-16 08:40:11, Chris Mason wrote:
> > > On Tue, May 03, 2016 at 02:17:19PM +0200, Jan Kara wrote:
> > > > On Thu 28-04-16 12:46:41, Jens Axboe wrot
el.com>
> Reviewed-by: Ross Zwisler <ross.zwis...@linux.intel.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> include/linux/radix-tree.h | 5 +
> kernel/irq/irqd
des this partition alignment check.
>
> Reported-by: Micah Parrish <micah.parr...@hpe.com>
> Signed-off-by: Toshi Kani <toshi.k...@hpe.com>
> Cc: "Theodore Ts'o" <ty...@mit.edu>
> Cc: Andreas Dilger <adilger.ker...@dilger.ca>
> Cc: Jan Kara <j...@
ow I'd
leave DAX in ext2.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
des this partition alignment check.
>
> Signed-off-by: Toshi Kani <toshi.k...@hpe.com>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Dan Williams <dan.j.willi...@intel.com>
> Cc: Ross Zwisler <ross.zwis...@linux.intel.com>
> Cc: Christoph Hellwig <h...@infradead.org>
we really
need to play tricks when logical offset in the file where mmap is starting
is not aligned (and similarly for map length). Whether allowing PMD
mappings for unaligned file offsets is worth the complication is IMO a
valid question.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
+ if (!IS_ERR_VALUE(addr_pmd)) {
> + addr_pmd += (off - addr_pmd) & (PMD_SIZE - 1);
> + return addr_pmd;
Otherwise the patch looks good to me.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
plication is just snapshotting the fs and will unfreeze it
eventually.
In the first case you need additional thaw, in the second case you must not
thaw the fs. That's why we kept the decision about thawing the fs to the
administrator...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
e <ax...@fb.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/block_dev.c| 2 +-
> fs/buffer.c | 2 +-
> fs/f2fs/data.c| 2 +-
> f
il.com>
I finally found time to have a look. The patch looks good to me. You can
add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
onsumed only about 0.04% of CPU time at startup phase. The
> percpu_list_del() function consumed about 0.4% of CPU time at exit
> phase. There were still some spinlock contention, but they happened
> elsewhere.
>
> Signed-off
id that once, but it's a real development timing issue
> https://lkml.org/lkml/2012/10/17/41
As much as that may be a useful excercise, I don't think it really belongs
in this rather small patch set.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
to the list_for_each_entry() and list_for_each_entry_safe() macros
> respectively. The iteration states are keep in a pcpu_list_state
> structure that is passed to the iteration functions.
>
> Signed-off-by: Waiman Long <waiman.l..
it could work. Or is there anything which still exposes the
fact that actual pages are 4k even in huge=always case?
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
ole
> during suspend"
> */
> void suspend_console(void)
> {
> + force_printk_sync = true;
> +
> if (!console_suspend_enabled)
> return;
> printk("Suspending console(s) (use no_console_suspend to debug)\n");
> @@ -2173,6 +2181,8 @@ void suspend_console(void)
>
> void resume_console(void)
> {
> + force_printk_sync = false;
> +
> if (!console_suspend_enabled)
> return;
> down_console_sem();
> --
> 2.9.0.rc1
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
ose loads. Probably not in the
cases where you get a boost from percpu lists but if the workload is mostly
single-threaded, additional cpu cost may be measurable. So IMO we should
check whether a load which creates tons of empty inodes in tmpfs from a
single process doesn't regress with this change.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 14-07-16 23:34:50, Sergey Senozhatsky wrote:
> Hello Jan,
>
> On (07/14/16 16:12), Jan Kara wrote:
> [..]
> > > *** a printk() call from here will kill the system. either it will
> > > recurse printk(), or spin forever in 'nested' printk() on one of
>
On Thu 14-07-16 16:33:38, Rafael J. Wysocki wrote:
> On Thursday, July 14, 2016 04:12:16 PM Jan Kara wrote:
> > On Wed 13-07-16 14:45:07, Sergey Senozhatsky wrote:
> > > Cc Petr Mladek.
> > >
> > > On (07/12/16 16:19), Viresh Kumar wrote:
> > > [..]
&
On Thu 14-07-16 16:47:11, Rafael J. Wysocki wrote:
> On Thursday, July 14, 2016 04:39:39 PM Jan Kara wrote:
> > On Thu 14-07-16 16:33:38, Rafael J. Wysocki wrote:
> > > On Thursday, July 14, 2016 04:12:16 PM Jan Kara wrote:
> > > > On Wed 13-07-16 14:45:07, Sergey S
sue on our side, and gave your patch a try, and it
> fixed the issue.
>
> Is there any chance to get this patch accepted upstream ?
Thanks for testing. Can I add your 'Tested-by' tag? I'll send the patch to
Jens for inclusion.
On Thu 14-07-16 15:12:51, Viresh Kumar wrote:
> On 14-07-16, 16:12, Jan Kara wrote:
> > Exactly. Calling printk() from certain parts of the kernel (like scheduler
> > code or timer code) has been always unsafe because printk itself uses these
> > parts and so it can lead to
gt; Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> diff --git a/fs/dax.c b/fs/dax.c
> index e207f8f..432b9e6 100644
>
I wasn't able to backport it cleanly to 3.10 yet to see it makes thing
> work better though. But it looks like it was targeting similar
> problems.
>
> @Jan Kara, Right ?
Yes. We have similar problems as you observe on machines when they do a lot
of printing (usually due to devic
bdi_cap_writeback_dirty(wb->bdi)
>
> So we call locked_inode_to_wb_and_lock_list, and then get the
> bdi_writeback->bdi,
> which actually is null. As a matter of fact the whole struct bdi_writeback is
> null
> (not the pointer to it). Is this possible to stem from the same issue
> discussed
> in the referenced email threads or is it a different, btrfs-specific problem.
>
> Regards,
> Nikolay
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
lt in a 4 KiB zero page or a 2 MiB zero page.
>
> _ext4_get_block() has the hole size information from ext4_map_blocks(), so
> populate bh->b_size.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks good. You can
ze = 1 << inode->i_blkbits;
IMO it's better to have things consistent between DAX & !DAX whenever
possible.
Honza
> + /*
> + * We have hit a hole. Tell DAX it is 4k in size so that it
> + * uses PTE faults.
> +
oid dax_wake_mapping_entry_waiter(struct address_space *mapping,
> -pgoff_t index, bool wake_all);
> +void dax_wake_mapping_entry_waiter(void **slot, bool wake_all);
>
> #ifdef CONFIG_FS_DAX
> struct page *read_dax_sector(struct block_device *bdev, sector_t n);
> diff --git a/mm/filemap
ntel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/fs/dax
sler <ross.zwis...@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.c | 22 +-
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
> diff -
or dirty DAX exceptional entries.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Thanks. The patch looks correct, you can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Although why don't we just simplify the test below to
mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)? After a
e:
> > >> On Mon, Aug 15, 2016 at 12:09 PM, Ross Zwisler
> > >> <ross.zwis...@linux.intel.com> wrote:
> > >> > DAX PMDs have been disabled since Jan Kara introduced DAX radix tree
> > >> > based
> > >> > locking. Th
On Wed 17-08-16 14:25:56, Ross Zwisler wrote:
> On Tue, Aug 16, 2016 at 11:28:16AM +0200, Jan Kara wrote:
> > On Mon 15-08-16 13:09:16, Ross Zwisler wrote:
> > > DAX radix tree locking currently locks entries based on the unique
> > > combination of the 'mapping' poi
_load_avg) calls WARN_ON from scheduler while
holding rq_lock which has been always forbidden. Sergey and Petr were doing
some work to prevent similar deadlocks but I'm not sure how far they
went...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> wake_up(>j_wait_done_commit);
> jbd_debug(1, "Journal thread exiting.\n");
> + write_unlock(>j_state_lock);
> return 0;
> }
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
> Foundation Collaborative Project.
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> being outside the unlikely statement. It is likely that dom->period_time
> will be set, but unlikely that it wont be. Move the not into the unlikely
> statement.
>
> Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org>
Yeah, good catch. You can add:
Reviewed-by: Jan
try the fault, returning
VM_FAULT_NOPAGE is a more common way to do that...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 02-02-17 18:28:02, Al Viro wrote:
> On Thu, Feb 02, 2017 at 03:48:17PM +0100, Jan Kara wrote:
>
> > > * ->page_mkwrite() instances sometimes return VM_FAULT_RETRY; AFAICS,
> > > it's only (ab)used there as 'not zero, but doesn't contain any error
> > &
ot;Inappropriate ioctl for device While reading flags on ..."
>
> As suggested by Jan Kara, if arg is NULL with a correct ioctl,
> we return -VM_FAULT_SIGBUS to report error.
You cannot return -VM_FAULT_SIGBUS from ioctl handler! Just look how it is
defined - it is an internal error co
return put_user(UDF_I(inode)->i_lenEAttr, (int __user *)arg);
> case UDF_GETEABLOCK:
> - result = copy_to_user((char __user *)arg,
> + return copy_to_user((char __user *)arg,
> UDF_I(inode)->i_ext.i_data,
>
was a one line change to bdev_get_queue() to
> >> prevent a shutdown crash when del_gendisk() races the final
> >> __blkdev_put().
> >>
> >> While it is known at del_gendisk() time that the queue is still alive,
> >> Jan Kara points to other paths [2] that
errors
udf: simplify udf_ioctl()
Jan Kara (1):
udf: Make stat on symlink report symlink length as st_size
Kinglong Mee (1):
fanotify: simplify the code of fanotify_merge
Steve Kenton (1):
fs/udf: make #ifdef UDF_PREALLOCATE unconditional
The diffstat is
fs/notify/fanotify
on). Furthermore if we
postponed i_disksize updates after IO submission even for non-allocating
writes (as you essentially do in your patch), we would have to deal with
difficult issues of having to update i_disksize when page writeback happens
from jbd2 process committing a transaction or from kswapd cleaning dirty
pages on memory pressure.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> This series applies cleanly to the current mmots/master:
>
> commit 35aa45ffe8d9 ("pci: test for unexpectedly disabled bridges")
>
> and I'm hoping that it'll end up going to Linus through akpm's -mm tree.
I li
c)
> - */
> - ext4_mark_inode_dirty(handle, inode);
> +
> + /*
> + * We need to mark the inode to be inserted
> + * into transaction by kworker thread later.
> + */
> +down_write(_I(inode)->i_data_sem);
> +ei->i_flags |= EXT4_MARK_DIRTY_FL;
> +up_write(_I(inode)->i_data_sem);
> }
> }
>
> @@ -3047,7 +3099,7 @@ static int ext4_da_write_end(struct file *file,
> ret2 = ext4_da_write_inline_data_end(inode, pos, len, copied,
>page);
> else
> - ret2 = generic_write_end(file, mapping, pos, len, copied,
> + ret2 = ext4_block_write_end(file, mapping, pos, len, copied,
> page, fsdata);
>
> copied = ret2;
> --
> 2.7.4
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 19-01-17 09:39:56, Michal Hocko wrote:
> On Tue 17-01-17 18:29:25, Jan Kara wrote:
> > On Tue 17-01-17 17:16:19, Michal Hocko wrote:
> > > > > But before going to play with that I am really wondering whether we
> > > > > need
> > > > >
d to be several years ago and we likely do not need as much
GFP_NOFS protection as we used to.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
dev, );
> }
> return 0;
Shouldn't we rather have some callback in dax_ops for clearing memory?
If we had all accesses to persistent memory inside DAX code wrapped inside
appropriate device wrappers that can report errors, we can have proper
error handling for the case we hit MCE,
).
> The later being the reason for the RFC; we have that case when mounting
> a 4kb blocksize against other values but maybe VRS is not mandatory
> there ?
>
> Tested with 512, 1024, 2048 and 4096 blocksize
>
> Reported-by: Jan Kara <j...@suse.com>
> Signed-off-b
(copy_to_user((char __user *)arg,
> @@ -220,6 +214,8 @@ long udf_ioctl(struct file *filp, unsigned int cmd,
> unsigned long arg)
> UDF_I(inode)->i_ext.i_data,
> UDF_I(inode)->i_lenEAttr) ? -EFAULT : 0;
> goto out;
> + default:
> + return -ENOIOCTLCMD;
> }
>
> out:
> --
> 2.9.3
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
recursion
inside the printk code itself easily and so far the answer was - use
printk_deferred() in the scheduler and don't use WARN...
Hum, maybe we could add lockdep annotation to a WARN_ON and BUG_ON macros so
that it would grab and release console_sem (even if the condition is false).
That way we'
On Thu 02-03-17 11:44:53, Al Viro wrote:
> On Wed, Mar 01, 2017 at 03:29:09PM +0100, Jan Kara wrote:
>
> > The problem is writeback code (from flusher work or through sync(2) -
> > generally inode_to_bdi() users) can be looking at bdev inode independently
> > from it bein
unhash bdev inode when the device
gets removed from the system so that it cannot be found by bdget() anymore.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Wed 01-03-17 15:29:09, Jan Kara wrote:
> On Mon 27-02-17 18:27:55, Al Viro wrote:
> > On Mon, Feb 27, 2017 at 06:11:11PM +0100, Dmitry Vyukov wrote:
> > > Hello,
> > >
> > > The following program triggers GPF in bdi_put:
> > &g
that
> the tools in CentOS 6 are so old that it's not worth worrying about. For
> reference, the kernel in CentOS 6 is based on 2.6.32. :) DAX was introduced
> in v4.0.
Hum, can you post 'dumpe2fs -h /dev/pmem0' output from that system when the
md5sum fails? Because the only idea I have is that mkfs.ext4 in CentOS 6
creates the filesystem with a different set of features than more recent
e2fsprogs and so we hit some untested path...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
blk() in jbd2_journal_init_dev() should be getblk_unmovable() so that
would be a good preparatory fix to remove the need of the gfp argument.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
heckpatch.pl by the way.
>
> Signed-off-by: Geliang Tang <geliangt...@gmail.com>
The patch looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
&g
; would also allow better performance.
I'm not sure how much this problem would be helped by a per-event
waitqueue. Also it would add a significant memory cost to permission
events and I prefer them small as there can be a lot of them queued...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
> affs, bfs, ext2, hfs, hfsplus, jffs2, jfs, logfs, minix, msdos, nilfs2,
> omfs, reiserfs, sysvfs, ubifs, udf, ufs, vfat.
ext2, UDF, and reiserfs changes look fine. You can add:
Acked-by: Jan Kara <j...@suse.cz>
Honza
>
e config it had sent me and see what's going on (likely
spin_is_locked() does not do what I thought under some configs...).
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Thu 08-09-16 14:47:08, Ross Zwisler wrote:
> On Tue, Sep 06, 2016 at 05:06:20PM +0200, Jan Kara wrote:
> > On Thu 01-09-16 20:57:38, Ross Zwisler wrote:
> > > On Wed, Aug 31, 2016 at 04:44:47PM +0800, Xiao Guangrong wrote:
> > > > On 08/31/201
-and-tested-by: Nikolay Borisov <ker...@kyup.com>
> Signed-off-by: Oleg Nesterov <o...@redhat.com>
> Cc: sta...@vger.kernel.org
The patch looks good. Thanks!
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
gt; goto out;
> }
>
> + sb_freeze_acquire(sb);
> +
> if (sb->s_op->unfreeze_fs) {
> error = sb->s_op->unfreeze_fs(sb);
> if (error) {
> printk(KERN_ERR
> "VFS:Filesystem thaw failed\n");
> + sb_freeze_release(sb);
> up_write(>s_umount);
> return error;
> }
> --
> 2.5.0
>
>
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Wed 05-10-16 08:47:42, Mateusz Guzik wrote:
> On Tue, Oct 04, 2016 at 11:06:15AM +0200, Jan Kara wrote:
> > On Tue 04-10-16 10:53:40, Pierre Morel wrote:
> > > When triggering thaw-filesystems via magic sysrq, the system enters a
> > > loop in do_thaw_one(), as thaw_b
radix
> tree node
>
> When the underflow checks were added to workingset_node_shadow_dec(),
> they triggered immediately:
FWIW the patch looks good to me. So you can add:
Reviewed-by: Jan Kara <j...@suse.cz>
And I agree that the games workingset code plays with node->count a
k & __GFP_FS)
> lock_map_release(_fs_map);
> }
>
> and now we can remove task_struct->lockdep_reclaim_gfp and all other
> RECLAIM_FS hacks in lockdep.c. Plus we can easily extend this logic to
> check more GFP_ flags.
Yeah, looks possible to me. I've added Peter to CC since he's most likely
to know.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
when you are using a vmf, but we pass them as a pair
> everywhere.
Actually, vma pointer will be in struct vm_fault after my DAX
write-protection series. So once that lands, we can clean up whatever
duplicit function parameters...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Tue 04-10-16 15:56:39, Al Viro wrote:
> On Tue, Oct 04, 2016 at 11:00:41AM +0200, Jan Kara wrote:
> > Hi!
> >
> > On Mon 03-10-16 16:30:55, Tony Lindgren wrote:
> > > I'm seeing a repeatable oops with Linux next while running
> > > update-initram
from [] (iterate_dir+0x14c/0x194)
> [] (iterate_dir) from [] (SyS_getdents+0x7c/0x118)
> [] (SyS_getdents) from [] (ret_fast_syscall+0x0/0x1c)
> Code: e5923000 e3130001 1a62 e92d4070 (e593c004)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
e code a bit at the same time).
>
> Reviewed-by: Eric Farman <far...@linux.vnet.ibm.com>
> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>
> Signed-off-by: Pierre Morel <pmo...@linux.vnet.ibm.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@su
either
> > unsetting IOMAP_WRITE or by setting 'written' to the size of the fault.
> >
> > For #2 or #3, probably add a comment explaining the deadlock and why we need
> > to never call ext2_write_failed() while handling a page fault.
> >
> > Thoughts?
>
>
On Tue 20-09-16 22:05:00, Michael Ellerman wrote:
> Andrew Morton <a...@linux-foundation.org> writes:
> > On Tue, 20 Sep 2016 11:10:35 +1000 Michael Ellerman <m...@ellerman.id.au>
> > wrote:
> >> Jan Kara <j...@suse.cz> writes:
> >> >
> &
rectly with the inotify/fanotify tests in LTP.
>
> Signed-off-by: Aihua Zhang <zhangaih...@huawei.com>
> Signed-off-by: Miklos Szeredi <mszer...@redhat.com>
> Cc: Jan Kara <j...@suse.cz>
> Cc: Eric Paris <epa...@redhat.com>
> ---
> include/linux/fsnotif
_wait_for_commit() before actually releasing the j_state_lock.
I'll send a fix. I'm surprised this didn't hit in my testing...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
nch_hole() only looks for dirty page cache pages in the radix tree,
> > not for dirty DAX exceptional entries.
> >
> > Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> > Reviewed-by: Jan Kara <j...@suse.cz>
> > Cc: <sta...@vger.kernel.org>
&g
loody cares about a deadlock later ;-)
Yeah, the trouble is that you usually won't see the WARN message
before deadlocking. So WARN_ON in scheduler is usually equivalent to
if (condition)
while (1);
;) Not really helping debugging much...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Fri 16-09-16 04:10:38, Guenter Roeck wrote:
> On 09/15/2016 11:45 PM, Jan Kara wrote:
> >Hi,
> >
> >On Thu 15-09-16 19:20:10, Guenter Roeck wrote:
> >>I see various architectures crashing in -next with the following error.
> >>
> >>-
e threads writing a single shared
> >> + * file given each thread is writing to a non-overlapping portion of the
> >> + * file.
> >> + *
> >> + * Refer to the possible upstream kernel version of range lock by
> >> + * Jan Kara <j...@suse.cz>: https://lkml.org
face instead.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.c| 213
>
rdering of arguments would look more logical to me like:
dax_wake_mapping_entry_waiter(mapping, index, entry, wake_all)
Other than that the patch looks good to me.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
has scope local to fs/dax.c, and to make sparse happy.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks fine. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.
ext2 a
> bit faster since they will no longer have to call the PMD fault handler
> only to get a response of VM_FAULT_FALLBACK.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@
b_mapping_entry() and
> dax_unlock_mapping_entry().
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.c | 34 ++
ot;dax" namespace and not the "iomap" namespace.
> Rename them to dax_iomap_rw(), dax_iomap_fault() and dax_iomap_actor()
> respectively.
>
> Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>
> Suggested-by: Dave Chinner <da...@fromorbit.com>
Lo
On Thu 29-09-16 16:49:28, Ross Zwisler wrote:
> DAX PMDs have been disabled since Jan Kara introduced DAX radix tree based
> locking. This patch allows DAX PMDs to participate in the DAX radix tree
> based locking scheme so that they can be re-enabled using the new struct
> iomap
On Mon 26-09-16 18:55:25, Oleg Nesterov wrote:
> On 09/26, Jan Kara wrote:
> >
> > On Mon 26-09-16 18:08:06, Oleg Nesterov wrote:
> > > +/*
> > > + * Tell lockdep we are holding these locks before we call
> > > ->unfreeze_fs(sb).
> > > + */
&
can carry the fix as necessary. This
Thanks! The resolution looks good to me.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
t propagates from __do_fault() or do_page_mkwrite() is fine
because at that point it is correct. But once we grab filesystem locks
which are not reclaim safe, we should update vmf->gfp_mask we pass further
down into DAX code to not contain __GFP_FS (that's a bug we apparently have
there). And inside DAX code, we definitely are not generally safe to add
__GFP_FS to mapping_gfp_mask(). Maybe we'd be better off propagating struct
vm_fault into this function, using passed gfp_mask there and make sure
callers update gfp_mask as appropriate.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
the proc
> mount and the euid of current? I think this is a good approach, but
> let's wait and see if anyone will have objections to completely
> eliminating those sysctls.
Well, I believe just discarding those sysctls is not an option - I'm pretty
sure there are scripts out there which tune these sysctls and those would
stop working. IMO not acceptable regression.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Mon 10-10-16 09:28:28, Lorenzo Stoakes wrote:
> On Mon, Oct 10, 2016 at 09:47:12AM +0200, Jan Kara wrote:
> > Yeah, so my cleanups where mostly concerned about mmap_sem locking and
> > reducing number of places which cared about those. Regarding flags for
> > get_user_pages
On Wed 26-10-16 14:15:09, Johannes Weiner wrote:
> On Wed, Oct 26, 2016 at 11:21:07AM +0200, Jan Kara wrote:
> > On Mon 24-10-16 14:47:39, Johannes Weiner wrote:
> > > From: Johannes Weiner <han...@cmpxchg.org>
> > > Date: Mon, 17 Oct 2016 09:00:04 -0400
>
On Sun 30-10-16 10:44:37, Jan Kara wrote:
> On Sat 29-10-16 13:09:25, Linus Torvalds wrote:
> > On Sat, Oct 29, 2016 at 12:17 PM, Al Viro <v...@zeniv.linux.org.uk> wrote:
> > >
> > > AFAICS, the possibility of dropping the last reference to struct file
> &g
p coverage for all the code behind iter_op(). The downside is we
cannot keep helpers as elegant as you suggested in your patch but I believe
it's bearable and worth the additional lockdep coverage. I'll send patches
shortly...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
. It is used in arch/arm/.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
On Tue 08-11-16 11:12:45, Johannes Weiner wrote:
> On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote:
> > On Mon 07-11-16 14:07:36, Johannes Weiner wrote:
> > > The radix tree counts valid entries in each tree node. Entries stored
> > > in the tree cannot be remov
On Tue 08-11-16 08:25:52, Jens Axboe wrote:
> On 11/08/2016 06:30 AM, Jan Kara wrote:
> >On Tue 01-11-16 15:08:49, Jens Axboe wrote:
> >>For legacy block, we simply track them in the request queue. For
> >>blk-mq, we track them on a per-sw queue basis, which we
On Sun 06-11-16 08:45:54, Amir Goldstein wrote:
> On Sat, Nov 5, 2016 at 11:34 PM, Jan Kara <j...@suse.cz> wrote:
> > On Wed 02-11-16 23:09:26, Miklos Szeredi wrote:
> >> We've got a report where a fanotify daemon that implements permission
> >> checks
> &
On Tue 08-11-16 08:41:09, Jens Axboe wrote:
> On Tue, Nov 08 2016, Jan Kara wrote:
> > On Tue 01-11-16 15:08:50, Jens Axboe wrote:
> > > We can hook this up to the block layer, to help throttle buffered
> > > writes.
> > >
> > > wbt registers a fe
601 - 700 of 6478 matches
Mail list logo
