mmap2 causes SIGBUS on 2.4.4-ac6

2001-05-10 Thread Jesper Juhl
gather, then please let me know and I'll be happy to provide it. I tried searching for mmap2 and SIGBUS on http://www.uwsg.indiana.edu/hypermail/linux/kernel/ but could not find any posts related to this, so I thought it would be ok to post this. Best regards, Jesper Juhl - [EMAIL PROTECTED

[PATCH] missing return value from pci_xircom_fn() in drivers/char/serial.c

2001-05-13 Thread Jesper Juhl
/drivers/char/serial.c.orig Sun May 13 23:13:02 2001 +++ linux-2.4.4-ac8/drivers/char/serial.c Sun May 13 23:13:24 2001 @@ -4190,6 +4190,7 @@ { __set_current_state(TASK_UNINTERRUPTIBLE); schedule_timeout(HZ/10); + return(0); } /* Best regards, Jesper Juhl

alloc_skb called nonatomically from interrupt

2000-09-23 Thread Jesper Juhl
anymore - upgraded to 2.2.17). My hardware is a IBM Thinkpad 600 - 233Mhz Pentium MMX with 64MB RAM. I hope this is usefull to you guys! BTW: Please CC me any replies to this, as I'm not on the list. Best regards, Jesper Juhl [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Strange warnings about .modinfo when compiling 2.2.18 on Alpha

2000-12-19 Thread Jesper Juhl
)) for this, and as far as I remember that's not the recommended compiler on Alpha (but it's all I have at the moment). If this is a known issue with gcc 2.95.2, then I appologize for the inconvenience. Best regards, Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe

Platform string wrong for AlphaServer 400 4/233

2000-12-19 Thread Jesper Juhl
to see it fixed (if it is at all possible to tell the two different systems apart from the kernels point of view). Best regards, Jesper Juhl [EMAIL PROTECTED] PS. Please CC all replies to me as I am not subscribed to the list. - To unsubscribe from this list: send the line "unsubscribe

Re: RTC !

2001-04-20 Thread Jesper Juhl
7 8 9 10 11 12 13 14 15 16 17 18 19 20 *** Test complete *** Typing "cat /proc/interrupts" will show 131 more events on IRQ 8. bash-2.04$ Regards, Jesper Juhl [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: Current status of NTFS support

2001-04-20 Thread Jesper Juhl
to modify the NTFS partition (but why not just create the NTFS partition of a smaller size and then use the unpartitioned space for a ext2 partition?). Best regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

'make dep' warning with 2.4.3 : computed checksums did NOT match

2001-04-20 Thread Jesper Juhl
regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] pedantic code cleanup - am I wasting my time with this?

2001-04-23 Thread Jesper Juhl
this stuff alone? Best regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] pedantic code cleanup - am I wasting my time with this?

2001-04-23 Thread Jesper Juhl
Sean Hunter wrote: On Mon, Apr 23, 2001 at 05:26:27PM +0200, Jesper Juhl wrote: last entry should not have a trailing comma. Sadly not. This isn't a gcc thing: ANSI says that trailing comma is ok (KR Second edition, A8.7 - pg 218 219 in my copy) You are right, I just consulted my own

Re: [PATCH] pedantic code cleanup - am I wasting my time with this?

2001-04-23 Thread Jesper Juhl
Richard Gooch wrote: Jesper Juhl writes: All the above does is to remove the last comma from 3 enumeration lists. I know that gcc has no problem with that, but to be strictly correct the last entry should not have a trailing comma. But it's more people-friendly to have that trailing

Patch to improve readability of sock_rcvlowat() - comments wanted...

2001-05-07 Thread Jesper Juhl
, int len) { - return (waitall ? len : min(sk-rcvlowat, len)) ? : 1; + int r = len; + if (!waitall) + r = min(sk-rcvlowat, len); + return max(1,r); } /* Alas, with timeout socket operations are not restartable. Best regards, Jesper Juhl - [EMAIL PROTECTED

Re: [PATCH] x86 page fault handler not interrupt safe

2001-05-07 Thread Jesper Juhl
fpu_exception : yes cpuid level : 1 wp : yes flags : fpu vme de pse tsc msr mce cx8 mmx bogomips: 463.67 Best regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: Patch to improve readability of sock_rcvlowat() - comments wanted...

2001-05-08 Thread Jesper Juhl
Ronald Bultje wrote: On 2001.05.08 01:04:57 +0200 Jesper Juhl wrote: static inline int sock_rcvlowat(struct sock *sk, int waitall, int len) { int r = len; if (!waitall) r = min(sk-rcvlowat, len); return max(1,r); } return max(1

MCradiolists: line 2: syntax error near unexpected token

2001-05-09 Thread Jesper Juhl
Best regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: MCradiolists: line 2: syntax error near unexpected token

2001-05-09 Thread Jesper Juhl
had a bug in bracket handling the new config file tripped I extracted the menuconfig related parts from 2.4.4-ac6 and applied them - with 100% success... I can now select the CPU type. Thank you! Best regards, Jesper Juhl - [EMAIL PROTECTED] - To unsubscribe from this list: send the line

[PATCH] Fix chapter reference in CodingStyle

2007-04-23 Thread Jesper Juhl
Greetings, commit 226a6b84aaaf1fac7a5d41cf4e7387fd9ba895d5 renumbered Chapter 11 in Documentation/CodingStyle to Chapter 12, but it didn't update the reference to that chapter further down in the file. This patch corrects the chapter reference. Signed-off-by: Jesper Juhl [EMAIL PROTECTED

2.6.20.3 - possible recursive locking detected - in XFS

2007-04-25 Thread Jesper Juhl
/0x30 [c0102f7e] sysenter_past_esp+0x5f/0x99 === ... -- Jesper Juhl [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [KJ] Basics of linux kernel development.

2007-02-14 Thread Jesper Juhl
if you want a good general Linux reference. http://www.amazon.co.uk/Linux-Nutshell-OReilly-Ellen-Siever/dp/0596009305/ref=pd_bxgy_b_img_b/203-7856448-7676754 -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http

Re: GPL vs non-GPL device drivers

2007-02-16 Thread Jesper Juhl
there, it's just that people got a way to make that a lot more explicit. [1] Except the first very few versions that used a licence written by Linus himself. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please

[PATCH][0/5][resend] floppy.c: first round of cleanup patches - the simple stuff

2007-03-19 Thread Jesper Juhl
addresses) etc. Andrew: Could you please merge these into -mm? And if you could push them to Linus after a bit of time in -mm that would be greatly appreciated as well. Kind regards, Jesper Juhl [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup

2007-03-19 Thread Jesper Juhl
and such out of the way from the beginning (and of course also to make it conform better to the CodingStyle document). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- diff --git a/drivers/block

[PATCH][2/5][resend] floppy.c: Remove pointless register keywords

2007-03-19 Thread Jesper Juhl
the variables and I doubt very much that in this day and age optimizing access to variables via 'register' makes any sense for a floppy driver. Let's just get rid of it. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH][3/5][resend] floppy.c: Remove dead/commented out code

2007-03-19 Thread Jesper Juhl
this code then they can still find it in the revision history. Let's kill the cruft :) Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index

[PATCH][4/5][resend] floppy.c: Add explicit/better printk() levels

2007-03-19 Thread Jesper Juhl
of them to not be KERN_WARNING. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 9a52ca6..577c621 100644 --- a/drivers/block/floppy.c

[PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-19 Thread Jesper Juhl
This fixes the warning warning: ignoring return value of `device_create_file', declared with attribute warn_unused_result in function `floppy_init'. It does this by checking the return value and printing a warning message in case of no success. Signed-off-by: Jesper Juhl

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-19 Thread Jesper Juhl
the user know that something failed is better than the current situation of just failing silently I'd say. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-19 Thread Jesper Juhl
On Monday 19 March 2007 16:20:00 Andi Kleen wrote: On Monday 19 March 2007 16:16, Jesper Juhl wrote: On 19/03/07, Andi Kleen [EMAIL PROTECTED] wrote: - device_create_file(floppy_device[drive].dev,dev_attr_cmos); + err = device_create_file(floppy_device[drive

Re: [PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup

2007-03-19 Thread Jesper Juhl
On Monday 19 March 2007 16:31:59 Randy Dunlap wrote: On Mon, 19 Mar 2007 16:10:13 +0100 Jesper Juhl wrote: This is a basic CodingStyle cleanup for drivers/block/floppy.c [snip] -#define LAST_OUT(x) if (output_byte(x)0){ reset_fdc();return;} +#define LAST_OUT(x) if (output_byte(x) 0

Re: [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-19 Thread Jesper Juhl
desc-irqs_unhandled = 0; } + +void set_timer_interrupt(unsigned int irq) Just one blank line between functions, as pr CodingStyle: In source files, separate functions with one blank line. ... -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0)

2007-03-19 Thread Jesper Juhl
On 19/03/07, Bernhard Walle [EMAIL PROTECTED] wrote: * Jesper Juhl [EMAIL PROTECTED] [2007-03-19 19:29]: -void +int register_percpu_irq (ia64_vector vec, struct irqaction *action) { Each and every function example in Documentation/CodingStyle has the return type on the same line

Re: [PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup

2007-03-19 Thread Jesper Juhl
On 19/03/07, Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Mar 19, 2007 at 07:18:38PM +0100, Jesper Juhl wrote: ... The second reason is that indenting two tabs seems to make the most sense for a few reasons; a) not indenting at all is ugly, plain and simple. void function

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-20 Thread Jesper Juhl
On 20/03/07, Mikael Pettersson [EMAIL PROTECTED] wrote: On Mon, 19 Mar 2007 18:42:22 +0100, Jesper Juhl wrote: --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4302,7 +4302,12 @@ static int __init floppy_init(void) if (err) goto

Re: kernel BUG at net/core/skbuff.c in linux-2.6.21-rc6

2007-04-10 Thread Jesper Juhl
that out, just wanted to point it out just in case :-) -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 3/10] I386 mcheck p4 grotesque and needless warning fix.patch

2007-04-10 Thread Jesper Juhl
? + intel_get_extended_msrs(dbg); printk (KERN_DEBUG CPU %d: EIP: %08x EFLAGS: %08x\n, smp_processor_id(), dbg.eip, dbg.eflags); printk (KERN_DEBUG \teax: %08x ebx: %08x ecx: %08x edx: %08x\n, -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http

[PATCH][trivial] Magic number prefix consistency change to Documentation/magic-number.txt

2007-04-11 Thread Jesper Juhl
. Change to a lower-case x to match the rest of the file. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- Documentation/magic-number.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/magic-number.txt b/Documentation/magic-number.txt index 0e740c8..bd450e7

2.6.13.4 kernel Oops - proc related

2007-04-12 Thread Jesper Juhl
2.0.11 Net-tools 1.60 Console-tools 0.3.3 Sh-utils 2.0.11 Modules Loaded iptable_nat -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com

Re: so what *is* obsolete and removable?

2007-04-15 Thread Jesper Juhl
, but it still reveals a pile of stuff that's obsolete (whatever that means in the context in which it's used). so what's really obsolete? IIRC Adrian Bunk is handling the removal of obsolete OSS drivers and doing a nice job at it. Dunno about the rest of the stuff. -- Jesper Juhl [EMAIL PROTECTED] Don't

Re: ZFS with Linux: An Open Plea

2007-04-15 Thread Jesper Juhl
then for compatibility. I'd personally like to see it - but, settle the license issue first. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list

2.6.13.4 - lockd: weird return 1 for CANCEL call

2007-02-21 Thread Jesper Juhl
manager! lockd: weird return 1 for CANCEL call lockd: weird return 1 for CANCEL call The server seems to be running fine, so I'm not really worried, but I thought maybe someone would like to know. :-) -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top

Re: 2.6.13.4 - lockd: weird return 1 for CANCEL call

2007-02-21 Thread Jesper Juhl
that it didn't own any such lock. Thanks a lot for that very nice explanation. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line

Re: off topic: Dolphin massacre in Japan

2007-02-23 Thread Jesper Juhl
. Thank you David. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

nfs_update_inode: inode 309229856 mode changed, 0100644 to 0040755 - kernel 2.6.13.4

2007-02-26 Thread Jesper Juhl
on the server... So a file changed type and permissions out of the blue. A few questions about that: Any way I can identify the file (or is it a dir now ;) ? Does anyone know if this is a known bug that's been fixed? I couldn't find anything via google or git that looked like a fix. -- Jesper Juhl [EMAIL

Hang when shutting down - seems umount and NFS related - kernel version 2.6.18.1

2007-02-26 Thread Jesper Juhl
went wrong and a way to fix it in the future (if it's not already fixed) :-) -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line

Re: Hang when shutting down - seems umount and NFS related - kernel version 2.6.18.1

2007-02-27 Thread Jesper Juhl
On 27/02/07, Chuck Ebbert [EMAIL PROTECTED] wrote: Jesper Juhl wrote: I have a server that has the sole job of serving up a bunch of NFS filesystems to webservers. The server is running kernel 2.6.18.1 A few days ago when attempting to reboot the server, the shutdown process hung

Re: nfs_update_inode: inode 309229856 mode changed, 0100644 to 0040755 - kernel 2.6.13.4

2007-03-01 Thread Jesper Juhl
On 26/02/07, Jesper Juhl [EMAIL PROTECTED] wrote: I have a webserver running a rather old 2.6.13.4 kernel that a few minutes ago surprised me by logging the following message : kernel: nfs_update_inode: inode 309229856 mode changed, 0100644 to 0040755 I just got one more of these (well

Re: Performance Stats: Kernel patch

2007-04-04 Thread Jesper Juhl
adds a syscall counter to /proc/PID/status. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: Kernel Oops?

2008-01-07 Thread Jesper Juhl
/netconsole.txt for details. That should do it for a few starting points. :-) -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Jesper Juhl
/onlinepubs/009695399/functions/mmap.html ... I agree that our current behaviour is certainly not what the standard (sensibly) requires. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com

[PATCH 1/2] irda: return -ENOMEM upon failure to allocate new ias_obj

2008-01-12 Thread Jesper Juhl
think it's a lot nicer to simply return -ENOMEM to the caller here where we know a memory allocation failed, rather than hitting an assertion later. note: I don't have any means of actually testing this, so it has been compile tested only. Signed-off-by: Jesper Juhl [EMAIL PROTECTED

[PATCH 2/2] irda: avoid potential memory leak in irda_setsockopt()

2008-01-12 Thread Jesper Juhl
new ias_obj The Coverity checker gets credit for pointing its finger towards this. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- af_irda.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index e33f0a5..352e8a7 100644

[PATCH] Documentation: Add 00-INDEX file for AoE

2008-01-12 Thread Jesper Juhl
Documentation/aoe/ is missing a 00-INDEX file. Add one. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- 00-INDEX | 18 ++ 1 file changed, 18 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/aoe/00-INDEX2008-01-13 02:37

[PATCH] AMD 5536 UDC - Remove unneeded memset()

2007-09-12 Thread Jesper Juhl
In drivers/usb/gadget/amd5536udc.c::udc_pci_probe() - We allocate storage for 'dev' with kzalloc(), so it is already zero, no need for an extra memset(). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/usb/gadget/amd5536udc.c |1 - 1 files changed, 0 insertions(+), 1 deletions

Re: [linux-kernel]how to get the latest kernel source tree?

2007-09-13 Thread Jesper Juhl
-- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[PATCH] cifs: Fix a small memory leak in directory creation code.

2007-09-16 Thread Jesper Juhl
'. This patch adds a kfree() call to free the storage just before jumping to the label, thus getting rid of the leak. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- inode.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- linux-2.6/fs/cifs/inode.c~ 2007-09-16 23:01:52.0

[PATCH] Remove an unused variable from the Intel I/OAT DMA engine driver

2007-09-16 Thread Jesper Juhl
-by: Jesper Juhl [EMAIL PROTECTED] --- ioatdma.c |1 - 1 file changed, 1 deletion(-) --- linux-2.6/drivers/dma/ioatdma.c~2007-09-16 23:24:20.0 +0200 +++ linux-2.6/drivers/dma/ioatdma.c 2007-09-16 23:24:20.0 +0200 @@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources

[PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak the storage allocated for 'abort' by returning from the function without using or freeing it. This happens in case sctp_auth_recv_cid(SCTP_CID_ABORT, asoc) is true and we jump to the 'discard

[PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But, the struct is actually 60 bytes in size. So change the define

mm_release() call in exit_mm() looks dangerous

2007-11-11 Thread Jesper Juhl
currently there looks a little shaky.. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH] Let 'make help' output info about includecheck

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] 'make includecheck' is useful and we want people to run it, so let 'make help' output information about its existence. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED

Re: [PATCH] Let 'make help' output info about includecheck

2007-11-14 Thread Jesper Juhl
On 14/11/2007, WANG Cong [EMAIL PROTECTED] wrote: On Mon, Nov 12, 2007 at 12:56:35AM +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] 'make includecheck' is useful and we want people to run it, so let 'make help' output information about its existence. Signed-off-by: Jesper

Re: mm_release() call in exit_mm() looks dangerous

2007-11-15 Thread Jesper Juhl
On 13/11/2007, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Jesper Juhl wrote: In kernel/exit.c we have this code : static void exit_mm(struct task_struct * tsk) { struct mm_struct *mm = tsk-mm; mm_release(tsk, mm); if (!mm) return

Re: Where is the interrupt going?

2007-11-21 Thread Jesper Juhl
the trivial causes. Could it be that you've simply not configured your system to log messages at the loglevel that your printk() is using? -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com

Re: [RFT] Port 0x80 I/O speed

2007-12-12 Thread Jesper Juhl
, in 1712 cycles: out 1761, in 1723 cycles: out 1771, in 1715 cycles: out 1770, in 1709 -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send

Re: yield API

2007-12-12 Thread Jesper Juhl
the new scheduler is doing fine in this regard. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFT] Port 0x80 I/O speed

2007-12-13 Thread Jesper Juhl
here: http://lkml.org/lkml/2007/12/12/399 -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH] UBI: silence warning about possibly uninitialized use of variable in drivers/mtd/ubi/vmt.c ...

2007-12-13 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] This patch silences the following warning : drivers/mtd/ubi/vmt.c:73: warning: 'ret' may be used uninitialized in this function gcc can't see that we always initialize ret in all situations where it is actually used. The one case where it's

Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Jesper Juhl
, doesn't (as far as I can tell) change the way the code works, makes checkpatch less noisy. All good. Feel free to add Reviewed-by: Jesper Juhl [EMAIL PROTECTED] if you like. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails

[PATCH 0/3] Nuke a few duplicate includes

2008-01-01 Thread Jesper Juhl
Including the same header twice (or more) in a .c file, outside any #ifdef's and whatnot, serves no purpose except generating more work for the compiler, so here are 3 patches that get rid of some pointless duplicate includes. Kind regards, Jesper Juhl [EMAIL PROTECTED] -- To unsubscribe

[PATCH 1/3] Nuke duplicate include from printk.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] Remove the duplicate inclusion of linux/jiffies.h from kernel/printk.c Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- printk.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/printk.c b/kernel/printk.c index 89011bf..b4bca0d 100644

[PATCH 2/3] Nuke a duplicate include from profile.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] Remove duplicate inclusion of linux/profile.h from kernel/profile.c Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- profile.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/profile.c b/kernel/profile.c index 5e95330..ffaebea 100644

[PATCH 3/3] Nuke duplicate header from sysctl.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] Don't include linux/security.h twice in kernel/sysctl.c Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- sysctl.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index c68f68d..01b12c3 100644 --- a/kernel/sysctl.c

Re: [PATCH] This patch to profile.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Jesper Juhl
On 04/01/2008, Paolo Ciarrocchi [EMAIL PROTECTED] wrote: Before: total: 25 errors, 13 warnings, 602 lines checked After: total: 3 errors, 13 warnings, 602 lines checked Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] Looks sane to me. Reviewed-by: Jesper Juhl [EMAIL PROTECTED

Re: [PATCH] This patch to printk.c fixes a few errors reported by checkpatch.pl

2008-01-03 Thread Jesper Juhl
cleanup. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED

Re: [3/6] kgdb: core

2008-02-10 Thread Jesper Juhl
accidentally end up with someone mistakenly turning it into if (foo) bar(); baz(); -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list

[PATCH] ACPICA: Don't leak next_walk_state in acpi_ds_call_control_method()

2012-10-21 Thread Jesper Juhl
If acpi_ds_create_walk_state() succeeds, but the call to ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function without properly freeing 'next_walk_state'. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/acpi/acpica/dsmethod.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [PATCH] staging: csr: remove a number of unneeded includes of version.h

2012-10-23 Thread Jesper Juhl
On Mon, 22 Oct 2012, Greg Kroah-Hartman wrote: On Thu, Oct 18, 2012 at 09:51:56PM +0200, Jesper Juhl wrote: Signed-off-by: Jesper Juhl j...@chaosbits.net Someone already beat you to this patch, sorry. Heh. That happens - no problem - as long as it gets fixed :) -- Jesper Juhl j

[PATCH] ACPI: Fix memory leak in acpi_bind_one()

2012-10-12 Thread Jesper Juhl
'physical_node' go out of scope and leak the memory we allocated. This patch fixes the leak by simply freeing the unused/unneeded memory pointed to by 'physical_node' just before we jump to 'err:'. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/acpi/glue.c |1 + 1 files changed, 1

[PATCH] [media] stk1160: Remove dead code from stk1160_i2c_read_reg()

2012-10-12 Thread Jesper Juhl
There are two checks for 'rc' being less than zero with no change to 'rc' between the two, so the second is just dead code - remove it. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/media/usb/stk1160/stk1160-i2c.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff

Re: [PATCH] ACPICA: Don't leak next_walk_state in acpi_ds_call_control_method()

2012-10-28 Thread Jesper Juhl
On Thu, 25 Oct 2012, Rafael J. Wysocki wrote: On Sunday 21 of October 2012 22:35:46 Jesper Juhl wrote: If acpi_ds_create_walk_state() succeeds, but the call to ACPI_ALLOCATE_ZEROED() fails, then we'll return from the function without properly freeing 'next_walk_state'. Signed-off

[PATCH 1/2] [media] rc: Fix double free in gpio_ir_recv_probe()

2012-10-28 Thread Jesper Juhl
rc_unregister_device(). That fixes the problem since rc_free_device() just does nothing if passed NULL and there's no further use of 'rcdev' after the call to rc_free_device() so it's not needed there. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/media/rc/gpio-ir-recv.c |2 +- 1 files

[PATCH 2/2] [media] rc: Fix double free in gpio_ir_recv_remove()

2012-10-28 Thread Jesper Juhl
Since rc_unregister_device() frees its argument there's no need to subsequently call rc_free_device() on the same variable - in fact it's a double free bug. Easily fixed by just removing the rc_free_device() call. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/media/rc/gpio-ir-recv.c

Re: [PATCH] [media] stk1160: Remove dead code from stk1160_i2c_read_reg()

2012-10-15 Thread Jesper Juhl
On Sat, 13 Oct 2012, Ezequiel Garcia wrote: On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl j...@chaosbits.net wrote: There are two checks for 'rc' being less than zero with no change to 'rc' between the two, so the second is just dead code - remove it. Signed-off-by: Jesper Juhl j

[PATCH] [resend] ACPI: Fix memory leak in acpi_bind_one() (fwd)

2012-10-15 Thread Jesper Juhl
Ok, so I had a little problem with my mail servers clock that caused the mail below to be timestamped a few years in the past, so I assume noone saw it - thus, resending. -- Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top

[PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-15 Thread Jesper Juhl
On Mon, 15 Oct 2012, Jesper Juhl wrote: On Sat, 13 Oct 2012, Ezequiel Garcia wrote: On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl j...@chaosbits.net wrote: There are two checks for 'rc' being less than zero with no change to 'rc' between the two, so the second is just dead code - remove

Re: [PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-15 Thread Jesper Juhl
On Mon, 15 Oct 2012, Ezequiel Garcia wrote: On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl j...@chaosbits.net wrote: On Mon, 15 Oct 2012, Jesper Juhl wrote: On Sat, 13 Oct 2012, Ezequiel Garcia wrote: [...] Currently there are two checks for 'rc' being less than zero with no change

Re: [PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-16 Thread Jesper Juhl
On Mon, 15 Oct 2012, Ezequiel Garcia wrote: On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl j...@chaosbits.net wrote: On Mon, 15 Oct 2012, Ezequiel Garcia wrote: On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl j...@chaosbits.net wrote: On Mon, 15 Oct 2012, Jesper Juhl wrote: On Sat, 13

[PATCH] [media] s5p-tv: don't include linux/version.h in mixer_video.c

2012-10-18 Thread Jesper Juhl
The header is not needed, so remove it. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/media/platform/s5p-tv/mixer_video.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-tv/mixer_video.c b/drivers/media/platform/s5p-tv

[PATCH] staging: remove version.h include from dgrp/dgrp_sysfs.c

2012-10-18 Thread Jesper Juhl
The file uses nothing from linux/version.h, so the include is pointless - remove it. Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/staging/dgrp/dgrp_sysfs.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/dgrp/dgrp_sysfs.c b/drivers/staging

[PATCH] Staging: silicom: Fix up version.h includes

2012-10-18 Thread Jesper Juhl
drivers/staging/silicom/bypasslib/bplibk.h actually uses stuff from version.h so it should include the header. drivers/staging/silicom/bp_proc.c and drivers/staging/silicom/bypasslib/bypass.c currently include the header but use nothing from it so they don't need to. Signed-off-by: Jesper Juhl j

[PATCH] staging: csr: remove a number of unneeded includes of version.h

2012-10-18 Thread Jesper Juhl
Signed-off-by: Jesper Juhl j...@chaosbits.net --- drivers/staging/csr/csr_framework_ext.c|1 - drivers/staging/csr/csr_time.c |1 - drivers/staging/csr/io.c |1 - drivers/staging/csr/monitor.c |1 - drivers/staging/csr/netdev.c

Re: [PATCH v2] Documentation DMA-API-HOWTO.txt Add dma mapping error check usage examples

2012-10-18 Thread Jesper Juhl
+ mapping error is detected in the middle) + ... if buffers are allocated in a loop... -- Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line

Re: - eepro100-avoid-potential-null-pointer-deref-in-speedo_init_rx_ring.patch removed from -mm tree

2007-10-02 Thread Jesper Juhl
is in the tree it makes sense to apply fixes to it. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH 1/5] Add a missing 00-INDEX file for Documentation/vm/

2007-08-31 Thread Jesper Juhl
This patch adds a 00-INDEX file to Documentation/vm/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- 00-INDEX | 20 1 file changed, 20 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ Documentation/vm/00-INDEX 2007-08-31 23:16:00.0 +0200

[PATCH 2/5][resend] Add a 00-INDEX file to Documentation/mips/

2007-08-31 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/mips/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- 00-INDEX |8 1 file changed, 8 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/mips/00-INDEX 2007-08-11 22:56:26.0 +0200

[PATCH 3/5][resend] Add a 00-INDEX file to Documentation/sysctl/

2007-08-31 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/sysctl/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- 00-INDEX | 16 1 file changed, 16 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/sysctl/00-INDEX 2007-08-11 23:52:50.0

[PATCH 4/5][resend] Add a 00-INDEX file to Documentation/telephony/

2007-08-31 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/telephony/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- 00-INDEX |4 1 file changed, 4 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/telephony/00-INDEX 2007-08-11 23:55:54.0 +0200

[PATCH 5/5] Update Documentation/fb/00-INDEX - add new files, remove entries for deleted ones

2007-08-31 Thread Jesper Juhl
An update to Documentation/fb/00-INDEX is long overdue. This patch adds entries for new files in the directory and removes entries for files that no longer exist. The files are now also sorted alphabetically. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- Documentation/fb/00-INDEX | 46

  1   2   3   4   5   6   7   8   9   10   >