Re: [PATCH] scsi: acornscsi: fix build error

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: 4.13+git: undefined references to bsg_setup_queue and bsg_job_done

get 'vmlinux' failed > make: *** [vmlinux] Error 1 There's a fix from Arnd [1] for this and it is in Martin's queue. [1] 580b71e9f64e0e6e9063466fce4564c56156695d Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: 4.13+git: undefined references to bsg_setup_queue and bsg_job_done

get 'vmlinux' failed > make: *** [vmlinux] Error 1 There's a fix from Arnd [1] for this and it is in Martin's queue. [1] 580b71e9f64e0e6e9063466fce4564c56156695d Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH 5/6] lightnvm: pblk: fix write I/O sync stat

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 5/6] lightnvm: pblk: fix write I/O sync stat

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 4/6] lightnvm: pblk: free padded entries in write buffer

On Wed, Sep 06, 2017 at 05:01:04PM +0200, Javier González wrote: > the completion pah. This might require some sectors to be padded in ^ path Looks good otherwise, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes

Re: [PATCH 4/6] lightnvm: pblk: free padded entries in write buffer

On Wed, Sep 06, 2017 at 05:01:04PM +0200, Javier González wrote: > the completion pah. This might require some sectors to be padded in ^ path Looks good otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthu

Re: [PATCH 3/6] lightnvm: pblk: use right flag for GC allocation

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 3/6] lightnvm: pblk: use right flag for GC allocation

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 2/6] lightnvm: pblk: initialize debug stat counter

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 2/6] lightnvm: pblk: initialize debug stat counter

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

On Wed, Sep 06, 2017 at 09:09:29AM -0600, Jens Axboe wrote: > On 09/06/2017 09:08 AM, Johannes Thumshirn wrote: > > On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote: > >> Check for failed mempool allocations and act accordingly. > > > > Are you s

Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

On Wed, Sep 06, 2017 at 09:09:29AM -0600, Jens Axboe wrote: > On 09/06/2017 09:08 AM, Johannes Thumshirn wrote: > > On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote: > >> Check for failed mempool allocations and act accordingly. > > > > Are you s

Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

contexts. (it might fail if called from an IRQ context.) [...]" Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

contexts. (it might fail if called from an IRQ context.) [...]" Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [PATCH v4 04/11] libsas: rename notify_port_event() for consistency

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH v4 04/11] libsas: rename notify_port_event() for consistency

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH v4 03/11] libsas: remove unused port_gone_completion and DISCE_PORT_GONE

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH v4 03/11] libsas: remove unused port_gone_completion and DISCE_PORT_GONE

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH v4 02/11] libsas: remove the numbering for each event enum

I guess it boils down to personal preference, but Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnb

Re: [PATCH v4 02/11] libsas: remove the numbering for each event enum

I guess it boils down to personal preference, but Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane

Re: [PATCH v4 01/11] libsas: kill useless ha_event and do some cleanup

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH v4 01/11] libsas: kill useless ha_event and do some cleanup

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH v2] Kbuild: enable -Wunused-macros warning for "make W=2"

We have lots of dead defines and macros in drivers, lets offer users a way to detect and eventually remove them. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Notes: Changes to v1: * Change from W=1 to W=2 scripts/Makefile.extrawarn | 1 + 1 file changed, 1 ins

[PATCH v2] Kbuild: enable -Wunused-macros warning for "make W=2"

We have lots of dead defines and macros in drivers, lets offer users a way to detect and eventually remove them. Signed-off-by: Johannes Thumshirn --- Notes: Changes to v1: * Change from W=1 to W=2 scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts

[PATCH] qla2xxx: add missing includes for qla_isr

definition of 'struct fc_ba_rjt' from scsi/fc/fc_fs.h) to the header files included by qla_isr.c. Fixes: 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/qla2xxx/qla_isr.c | 2 ++ 1 file changed, 2

[PATCH] qla2xxx: add missing includes for qla_isr

definition of 'struct fc_ba_rjt' from scsi/fc/fc_fs.h) to the header files included by qla_isr.c. Fixes: 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") Signed-off-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_isr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH 0/2] MCB Patches for 4.14

Hi Greg, Here are the collected MCB patches for Kernel v4.14. Christophe's patch fixes an error handling issue and Michael introduces a new device id for LPC bus attached MCB devices. I also tagged this patch for inclusion into stable. All of them have been in my git tree at

[PATCH 0/2] MCB Patches for 4.14

Hi Greg, Here are the collected MCB patches for Kernel v4.14. Christophe's patch fixes an error handling issue and Michael introduces a new device id for LPC bus attached MCB devices. I also tagged this patch for inclusion into stable. All of them have been in my git tree at

[PATCH 2/2] mcb: Fix an error handling path in 'chameleon_parse_cells()'

erates a warning ("warning: ‘ret’ may be used uninitialized in this function")) Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/mcb/mcb-parse.c | 6 -- 1 file changed, 4 insertions(+), 2 deleti

[PATCH 2/2] mcb: Fix an error handling path in 'chameleon_parse_cells()'

used uninitialized in this function")) Signed-off-by: Christophe JAILLET Signed-off-by: Johannes Thumshirn --- drivers/mcb/mcb-parse.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c index ee7fb6ec96bd..7369bda34

[PATCH 1/2] MCB: add support for SC31 to mcb-lpc

ag] Cc: <sta...@vger.kernel.org> (v4.9+) Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/mcb/mcb-lpc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/mcb/mcb-lpc.c b/drivers/mcb/mcb-lpc.c index d072c088ce73..945091a88354 100644 --- a/drivers/mcb/mcb

[PATCH 1/2] MCB: add support for SC31 to mcb-lpc

From: Michael Moese This patch adds the resources and DMI ID's for the MEN SC31, which uses a different address region to map the LPC bus than the one used for the existing SC24. Signed-off-by: Michael Moese [jth add stable tag] Cc: (v4.9+) Signed-off-by: Johannes Thumshirn --- drivers/mcb

Re: [PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

Applied to mcb-for-4.14 branch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton

Re: [PATCH] mcb: Fix an error handling path in 'chameleon_parse_cells()'

Applied to mcb-for-4.14 branch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton

Re: [PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"

Sure, I'll send a v2 in a few days. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton H

Re: [PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"

Sure, I'll send a v2 in a few days. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton H

Re: [PATCH v2 2/2] Introduce 8250_men_mcb

for uartclk. A reasonable default is included in > addition to the support of three boards. Additional values for other > boards will be added later. > > This v2 has some whitespace fixes, I screwed this up yesterday. Nit: this should go below the '---' marker. Apart from that, Reviewe

Re: [PATCH v2 2/2] Introduce 8250_men_mcb

for uartclk. A reasonable default is included in > addition to the support of three boards. Additional values for other > boards will be added later. > > This v2 has some whitespace fixes, I screwed this up yesterday. Nit: this should go below the '---' marker. Apart from that, Reviewe

Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762

rning by switching to dev64_ul(). div64_ul() ^ Otherwise, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX Gm

Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762

rning by switching to dev64_ul(). div64_ul() ^ Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

annes >From 469957522c4b356a313cb369e3e14fdac104370f Mon Sep 17 00:00:00 2001 From: Johannes Thumshirn <jthumsh...@suse.de> Date: Thu, 27 Jul 2017 09:11:26 +0200 Subject: [PATCH] scsi: sg: only check for dxfer_len greater than 256M commit f930c7043663188429cd9b254e9d761edfc101ce upstream Don't

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

annes >From 469957522c4b356a313cb369e3e14fdac104370f Mon Sep 17 00:00:00 2001 From: Johannes Thumshirn Date: Thu, 27 Jul 2017 09:11:26 +0200 Subject: [PATCH] scsi: sg: only check for dxfer_len greater than 256M commit f930c7043663188429cd9b254e9d761edfc101ce upstream Don't make any assumptions on

[PATCH v2] nvme: Fix nvme reset command timeout handling

titive returns mean the controller is still usable. bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325 Signed-off-by: Keith Busch <keith.bu...@intel.com> Cc: Martin Peres <martin.pe...@intel.com> [jth consolidated cleanup path ] Signed-off-by: Johannes Thumshirn <jthumsh..

[PATCH v2] nvme: Fix nvme reset command timeout handling

is still usable. bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325 Signed-off-by: Keith Busch Cc: Martin Peres [jth consolidated cleanup path ] Signed-off-by: Johannes Thumshirn --- Notes: Changes in v2: * Consolidated cleanup path drivers/nvme/host/core.c | 27

Re: [RFC PATCH 6/6] bsg: reduce unnecessary arguments for blk_complete_sgv4_hdr_rq()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [RFC PATCH 6/6] bsg: reduce unnecessary arguments for blk_complete_sgv4_hdr_rq()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [RFC PATCH 5/6] bsg: reduce unnecessary arguments for bsg_map_hdr()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [RFC PATCH 5/6] bsg: reduce unnecessary arguments for bsg_map_hdr()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [RFC PATCH 4/6] bsg: refactor ioctl to use regular BSG-command infrastructure for SG_IO

onstruct. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [RFC PATCH 4/6] bsg: refactor ioctl to use regular BSG-command infrastructure for SG_IO

onstruct. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

n Linus' tree (Yes I know I explicitly sent it to stable, mea culpa) Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [PATCH 4.12 004/106] scsi: sg: fix SG_DXFER_FROM_DEV transfers

n Linus' tree (Yes I know I explicitly sent it to stable, mea culpa) Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imen

Re: [PATCH] IB/core: fix memory leak on ah on error return path

B core code but hns code. The reference to the patch which introduced the leak is given byu the fixes line. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeld

Re: [PATCH] IB/core: fix memory leak on ah on error return path

B core code but hns code. The reference to the patch which introduced the leak is given byu the fixes line. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeld

Re: [PATCH] IB/core: fix memory leak on ah on error return path

Shouldn't the subject start with "IB/hns:" given it's touching drivers/infiniband/hw/hns/hns_roce_ah.c? Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH,

Re: [PATCH] IB/core: fix memory leak on ah on error return path

Shouldn't the subject start with "IB/hns:" given it's touching drivers/infiniband/hw/hns/hns_roce_ah.c? Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH,

Re: [PATCH 00/29] constify scsi pci_device_id.

On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote: > However, having a bazillion identical commit messages is also really > annoying. So for automated changes like this, I'd rather just have a > single patch. Thought so ;-) -- Johannes

Re: [PATCH 00/29] constify scsi pci_device_id.

On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote: > However, having a bazillion identical commit messages is also really > annoying. So for automated changes like this, I'd rather just have a > single patch. Thought so ;-) -- Johannes

Re: [PATCH] loop: fix to a race condition due to the early registration of device

or nit. Anyways, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smit

Re: [PATCH] loop: fix to a race condition due to the early registration of device

or nit. Anyways, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 212

Re: [PATCH] loop: fix to a race condition due to the early registration of device

On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote: > +err_out: > return err; Any reason you can't just use return err; at the respective callsites? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@s

Re: [PATCH] loop: fix to a race condition due to the early registration of device

On Mon, Aug 07, 2017 at 03:37:50PM +0300, Anton Volkov wrote: > +err_out: > return err; Any reason you can't just use return err; at the respective callsites? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@s

Re: [PATCH] MCB: add support for SC31 to mcb-lpc

Applied, Thanks -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [PATCH] MCB: add support for SC31 to mcb-lpc

Applied, Thanks -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

[PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"

We have lots of dead defines and macros in drivers, lets offer users a way to detect and eventually remove them. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.extrawarn b/s

[PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"

We have lots of dead defines and macros in drivers, lets offer users a way to detect and eventually remove them. Signed-off-by: Johannes Thumshirn --- scripts/Makefile.extrawarn | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index

[PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/host/rdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index da04df1af231..57ac96ff9acb

[PATCH 1/2] nvme: rdma: remove NVME_RDMA_MAX_SEGMENT_SIZE

NVME_RDMA_MAX_SEGMENT_SIZE is not used anywhere, zap it. Signed-off-by: Johannes Thumshirn --- drivers/nvme/host/rdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c index da04df1af231..57ac96ff9acb 100644 --- a/drivers/nvme/host/rdma.c

[PATCH 2/2] nvmet: fcloop: remove ALL_OPTS define

ALL_OPTS isn't used anywhere, remove it. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/nvme/target/fcloop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 1bb9d5b311b1..1cb9847ec261 100644 --- a/d

[PATCH 2/2] nvmet: fcloop: remove ALL_OPTS define

ALL_OPTS isn't used anywhere, remove it. Signed-off-by: Johannes Thumshirn --- drivers/nvme/target/fcloop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/nvme/target/fcloop.c b/drivers/nvme/target/fcloop.c index 1bb9d5b311b1..1cb9847ec261 100644 --- a/drivers/nvme/target

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

dd indentation. > Please reformat to have type and variable on one line. And use Linux types and no CamelCase and no typedefs (especially not for pointers), you're not on Windows here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh..

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

dd indentation. > Please reformat to have type and variable on one line. And use Linux types and no CamelCase and no typedefs (especially not for pointers), you're not on Windows here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh..

Re: [PATCH 00/29] constify scsi pci_device_id.

parate patch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnber

Re: [PATCH 00/29] constify scsi pci_device_id.

parate patch. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnber

Re: [PATCH 00/29] constify scsi pci_device_id.

h instead of replicating the same patch 29 times? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham N

Re: [PATCH 00/29] constify scsi pci_device_id.

h instead of replicating the same patch 29 times? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham N

[PATCH] scsi: sg: only check for dxfer_len greater than 256M

Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the sg_io_hdr_t::dxferp in order to determine if it is a valid request. The only way we can check for bad requests is by checking if the length exceeds 256M. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>

[PATCH] scsi: sg: only check for dxfer_len greater than 256M

Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the sg_io_hdr_t::dxferp in order to determine if it is a valid request. The only way we can check for bad requests is by checking if the length exceeds 256M. Signed-off-by: Johannes Thumshirn Fixes: 28676d869bbb (scsi: sg: check

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote: > Ah, it was only below the "---" line, so I'll skip the resending > unless you want me > to add a comment in the Kconfig file. Nah no need, really. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote: > Ah, it was only below the "---" line, so I'll skip the resending > unless you want me > to add a comment in the Kconfig file. Nah no need, really. Reviewed-by: Johannes Thumshirn --

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

m, the current symbol can only be "m" or > "n", while "X=y" means it can have any value. > > So for "depends on X || X=n", the current symbol cannot be "y" when "X=m", > but otherwise can have any of t

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

m, the current symbol can only be "m" or > "n", while "X=y" means it can have any value. > > So for "depends on X || X=n", the current symbol cannot be "y" when "X=m", > but otherwise can have any of t

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

is black magic, but X || X=n ? I have no doubt you do the right thing, I just don't understand it. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr.

Re: [PATCH, RESEND] scsi: lpfc: fix linking against modular NVMe support

is black magic, but X || X=n ? I have no doubt you do the right thing, I just don't understand it. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr.

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Tue, Jul 25, 2017 at 01:25:07PM -0500, Jason L Tibbitts III wrote: > >>>>> "JT" == Johannes Thumshirn <jthumsh...@suse.de> writes: > ioctl(3, SG_IO, {interface_id='S', dxfer_direction=SG_DXFER_TO_DEV, > cmd_len=12, cmdp="\xa5\x00\x00\x00\x00\

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Tue, Jul 25, 2017 at 01:25:07PM -0500, Jason L Tibbitts III wrote: > >>>>> "JT" == Johannes Thumshirn writes: > ioctl(3, SG_IO, {interface_id='S', dxfer_direction=SG_DXFER_TO_DEV, > cmd_len=12, cmdp="\xa5\x00\x00\x00\x00\x01\x03\xe9\x00\x00\x00\x00"

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

care combinations was, that user-space could then easily crash the kernel. This is the reason I introduced sg_is_valid_dxfer(). It's sole purpuse was to avoid more CVEs, but unfortunately it turned into quite some regressions. Thanks, Johannes -- Johannes Thumshirn

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

care combinations was, that user-space could then easily crash the kernel. This is the reason I introduced sg_is_valid_dxfer(). It's sole purpuse was to avoid more CVEs, but unfortunately it turned into quite some regressions. Thanks, Johannes -- Johannes Thumshirn

Re: [PATCH v2] scsi: qedf: Limit number of CQs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH v2] scsi: qedf: Limit number of CQs

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Fri, Jul 21, 2017 at 02:23:16PM -0500, Jason L Tibbitts III wrote: > I can also apply the debugging patch and try again if that would give > you more useful information. Yes please (on top of the snippet I've sent you last). Thanks a lot, Johannes -- Johannes Thu

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

On Fri, Jul 21, 2017 at 02:23:16PM -0500, Jason L Tibbitts III wrote: > I can also apply the debugging patch and try again if that would give > you more useful information. Yes please (on top of the snippet I've sent you last). Thanks a lot, Johannes -- Johannes Thu

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

Doug, On Wed, Jul 19, 2017 at 10:36:54AM +0200, Johannes Thumshirn wrote: > On Wed, Jul 19, 2017 at 03:13:34AM -0500, Jason L Tibbitts III wrote: > > [ 46.304530] sg_is_valid_dxfer: dxfer_direction: -2, dxfer_len: 0 > > Ahh now I see the -2 (SG_DXFER_TO_DEV) is the crucial poin

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

Doug, On Wed, Jul 19, 2017 at 10:36:54AM +0200, Johannes Thumshirn wrote: > On Wed, Jul 19, 2017 at 03:13:34AM -0500, Jason L Tibbitts III wrote: > > [ 46.304530] sg_is_valid_dxfer: dxfer_direction: -2, dxfer_len: 0 > > Ahh now I see the -2 (SG_DXFER_TO_DEV) is the crucial poin

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

0, can we rely on dxferp being present? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Gr

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

0, can we rely on dxferp being present? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Gr

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

g_io_hdr_t *hp) { + + pr_info("%s: dxfer_direction: %d, dxfer_len: %d\n", + __func__, hp->dxfer_direction, hp->dxfer_len); + switch (hp->dxfer_direction) { case SG_DXFER_NONE: if (hp->dxferp || hp->dxfer_len > 0) Than

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

g_io_hdr_t *hp) { + + pr_info("%s: dxfer_direction: %d, dxfer_len: %d\n", + __func__, hp->dxfer_direction, hp->dxfer_len); + switch (hp->dxfer_direction) { case SG_DXFER_NONE: if (hp->dxferp || hp->dxfer_len > 0) Than

Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control

is fixed with: commit 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47 Author: Johannes Thumshirn <jthumsh...@suse.de> Date: Fri Jul 7 10:56:38 2017 +0200 scsi: sg: fix SG_DXFER_FROM_DEV transfers SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set it to NULL for the old s

<    2   3   4   5   6   7   8   9   10   11   >