Hi Jeff,
On Thu, 31 Jan 2008, Jeff Chua wrote:
> On the bad run, I got the following message ...
>
> boston kernel: nf_ct_tcp: invalid packed ignored IN= OUT=
> SRC=127.0.0.1 DST=127.0.0.1 LEN=60 TOS=0x00 PREC=0x00 TTL=64 ID=8162
> DF PROTO=TCP SPT=1016 DPT=515 SEQ=3834958843 ACK=0 WINDOW=32792
Hi Jeff,
On Fri, 1 Feb 2008, Jeff Chua wrote:
> I recaptured it again, and attached are the logs.
[...]
Thank you! One can see a plain connection-initiating SYN, which triggers
the message. No reply from the server, then three seconds later comes a
retransmitted SYN and immediately after the S
d ignored'
and all other kernel messages or both suppresses them and produces normal
printing speed?
commit 2067ab64ef876efaa0f4dd8fe73f48f50e215369
Author: Jozsef Kadlecsik <[EMAIL PROTECTED]>
Date: Sun Feb 3 17:14:22 2008 +0100
Handle active close for both sides, it is not res
On Tue, 5 Feb 2008, Jeff Chua wrote:
> On Feb 5, 2008 4:17 AM, Jozsef Kadlecsik <[EMAIL PROTECTED]> wrote:
>
> > Actively closed connections are not handled properly, i.e. the initiator of
> > the active close should not be taken into account. So could you give a try
>
newest
git tree - Jeff spotted it, thanks! So here follows the patch against the
newest git tree which corrects the mistake. Please review and commit.
commit 1177898d185f382f491afaee3cdc752729c74bd2
Author: Jozsef Kadlecsik <[EMAIL PROTECTED]>
Date: Thu Feb 14 15:51:21 2008 +0100
Mi
will cause the printing to slow down to 1 print every 3
> > seconds after printing 500 times.
>
> I bisected the kernel since the last known good 2.6.23 and zeroed in to this
> commit.
>
> commit 17311393f969090ab060540bd9dbe7dc885a76d5
> Author: Jozsef Kadlecsik
Hi,
On Mon, 30 Oct 2017, Gustavo A. R. Silva wrote:
> Make use of the swap macro and remove unnecessary variables tmp.
> This makes the code easier to read and maintain.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> net/netfilter/ipset/
Hi,
On Sat, 28 Oct 2017, Gustavo A. R. Silva wrote:
> Make use of the swap macro and remove unnecessary variable tmp.
> This makes the code easier to read and maintain.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva
Please resubmit the tree patc
Hi,
On Sun, 25 Oct 2015, Gerhard Wiesinger wrote:
> On 25.10.2015 10:46, Willy Tarreau wrote:
> > ipset *triggered* the problem. The whole stack dump would tell more.
>
> OK, find the stack traces in the bug report:
> https://bugzilla.redhat.com/show_bug.cgi?id=1272645
>
> Kernel 4.1.10 trigge
On Sun, 25 Oct 2015, Gerhard Wiesinger wrote:
> On 25.10.2015 21:08, Gerhard Wiesinger wrote:
> > On 25.10.2015 20:46, Jozsef Kadlecsik wrote:
> > > Hi,
> > >
> > > On Sun, 25 Oct 2015, Gerhard Wiesinger wrote:
> > >
> > > > On 25.10.20
On Sun, 25 Oct 2015, Gerhard Wiesinger wrote:
> On 25.10.2015 20:46, Jozsef Kadlecsik wrote:
> > Hi,
> >
> > On Sun, 25 Oct 2015, Gerhard Wiesinger wrote:
> >
> > > On 25.10.2015 10:46, Willy Tarreau wrote:
> > > > ipset *triggered* the problem
g: net/netfilter/ipset: work around gcc-4.4.4 initializer bug
>
> I can confirm this patch (which I couldn't find on any mailing list) is also
> needed for gcc 4.1.2.
>
> Note that the issue is in mainline since last night.
Sorry, I haven't checked the patch with older
On Sat, 30 May 2015, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: ?IPSET_ERR_TYPE_SPECIFIC? undeclared here (not in a function)
> IPSET_ERR_BITMAP_RANGE = IPSET_ERR_TYPE_SPECIFIC,
What kind of userspace compilation generates the error message above? How
can one reproduc
On Sat, 27 Mar 2021, Wan Jiabing wrote:
> struct ip_set is declared twice. One is declared at 79th line,
> so remove the duplicate.
Yes, it's a duplicate. Pablo, could you apply it?
> Signed-off-by: Wan Jiabing
Acked-by: Jozsef Kadlecsik
Best regards,
Jozsef
> ---
> inc
On Wed, 12 Mar 2014, Joe Perches wrote:
> The use of __constant_ has been unnecessary for quite awhile now.
>
> Make these uses consistent with the rest of the kernel.
>
> Signed-off-by: Joe Perches
Acked-by: Jozsef Kadlecsik
> ---
> net/netfilter/ipset/pfxlen.c | 4
On Sun, 2 Mar 2014, Jason A. Donenfeld wrote:
> This code path is hit everytime a new network namespace is created,
> which means it runs everytime I start Chromium, resulting in needless
> noise in my logs. This message doesn't add very much at all, and isn't
> triggered at the correct place anyw
On Thu, 13 Feb 2014, Ilia Mirkin wrote:
> I've recently noticed a lot of
>
> [356872.380595] ip_set: protocol 6
That means the ip_set module has been loaded in multiple times.
> messages in my dmesg. This might be because of some local
> configuration changes I've made, or perhaps a kernel upg
On Tue, 15 Oct 2013, Thierry Reding wrote:
> Today's linux-next merge of the trivial tree got conflicts in
>
> net/netfilter/xt_set.c
>
> caused by commits 3f79410 (treewide: Fix common typo in "identify") and
> bd3129f (netfilter: ipset: order matches and targets separatedly in
> xt_set.c
On Wed, 16 Oct 2013, Pablo Neira Ayuso wrote:
> On Wed, Oct 16, 2013 at 11:20:04AM +0200, Jiri Kosina wrote:
> > On Wed, 16 Oct 2013, Jozsef Kadlecsik wrote:
> >
> > > > Today's linux-next merge of the trivial tree got conflicts in
> > >
lter/ipset/ip_set_hash_gen.h | 12 ++--
> net/netfilter/xt_connbytes.c | 2 +-
> net/netfilter/xt_hashlimit.c | 2 +-
> net/netfilter/xt_set.c| 36
> ---
> 5 files changed, 35 insertions(+), 40 deletions(-)
A
On Thu, 13 Feb 2014, Florian Westphal wrote:
> Ilia Mirkin wrote:
> > > Maybe printing "using protocol version X" will make it appear less like
> > > a debugging message referring to packet contents or something similar.
> >
> > With pr_info it'll still appear in dmesg, and it'll still be "rando
On Wed, 23 Oct 2013, Michael Opdenacker wrote:
> This patch removes a duplicate define from
> net/netfilter/ipset/ip_set_hash_gen.h
>
> Signed-off-by: Michael Opdenacker
Patch is applied to the ipset git tree, thanks.
Best regards,
Jozsef
-
E-mail : kad...@blackhole.kfki.hu, kadlecsik.joz...@
On Sat, 14 May 2016, Muhammad Falak R Wani wrote:
> Use setup_timer() and instead of init_timer(), being the preferred way
> of setting up a timer.
>
> Also, quoting the mod_timer() function comment:
> -> mod_timer() is a more efficient way to update the expire field of an
>active timer (if t
Hi,
On Mon, 29 Feb 2016, Julia Lawall wrote:
> The file net/netfilter/ipset/ip_set_bitmap_ipmac.c seems to contain a lot
> of static functions that are not used in the file:
>
> bitmap_ipmac_add_timeout
> bitmap_ipmac_do_add
> bitmap_ipmac_do_del
> bitmap_ipmac_do_head
> bitmap_ipmac_do_list
> b
On Thu, 14 May 2015, Pablo Neira Ayuso wrote:
> On Wed, May 06, 2015 at 04:28:57PM +0200, Denys Vlasenko wrote:
> > On x86 allyesconfig build:
> > The function compiles to 489 bytes of machine code.
> > It has 25 callsites.
> >
> > textdata bss dec hex filename
> > 8244137
bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> CC: Jozsef Kadlecsik
> Signed-off-by: Fengguang Wu
Patch is applied, thanks.
Best regards,
Jozsef
> ---
>
&g
On Fri, 6 Mar 2015, Alexander Drozdov wrote:
> All the ipset functions respect skb->network_header value,
> except for ip_set_get_ip4_port() & ip_set_get_ip6_port(). The
> functions should use skb_network_offset() to get the transport
> header offset.
>
> Signed-off-by: Alexander Drozdov
Patch
On Wed, 11 Mar 2015, Pablo Neira Ayuso wrote:
> Hi Jozsef,
>
> On Wed, Mar 11, 2015 at 08:08:26PM +0100, Jozsef Kadlecsik wrote:
> > On Wed, 11 Feb 2015, kbuild test robot wrote:
> >
> > > net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function
> &g
nless you have any objection, I'm going to apply this.
No objection, just go ahead.
Acked-by: Jozsef Kadlecsik
Best regards,
Jozsef
> > CC: Jozsef Kadlecsik
> > Signed-off-by: Fengguang Wu
> > ---
> >
> > xt_set.c |4 ++--
> > 1 file changed, 2 ins
linux/netfilter/ipset/ip_set.h
> @@@ -2,7 -1,11 +2,7 @@@
> /* Copyright (C) 2000-2002 Joakim Axelsson
>* Patrick Schaaf
>* Martin Josefsson
> - * Copyright (C) 2003-2013 Jozsef Kadlecsik
> + * Copyright (C) 2003-2013 Jozse
Hi Francesco,
On Thu, 8 Oct 2020, Francesco Ruggeri wrote:
> On Wed, Oct 7, 2020 at 12:32 PM Francesco Ruggeri wrote:
> >
> > If the first packet conntrack sees after a re-register is an outgoing
> > keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to
> > SND.NXT-1. When the
Hi Florian,
On Fri, 9 Oct 2020, Florian Westphal wrote:
> Jozsef Kadlecsik wrote:
> > > The reproducer has two files. client_server.py creates both ends of
> > > a tcp connection, bounces a few packets back and forth, and then
> > > blocks on a recv on the clien
On Fri, 9 Oct 2020, Florian Westphal wrote:
> Matches/targets that need conntrack increment a refcount. So, when all
> rules are flushed, refcount goes down to 0 and conntrack is disabled
> because the hooks get removed..
>
> Just doing iptables-restore doesn't unregister as long as both the ol
Hi Pablo,
On Fri, 14 Apr 2017, Pablo Neira Ayuso wrote:
> On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote:
> > There are no in-tree callers.
>
> @Jozsef, let me know if I should just take this to save you a pull
> request.
Just take it, thank you.
Acked-by
Hi,
[Sorry, at holiday I just cursory watched the mailing lists.]
On Tue, 1 Aug 2017, David Laight wrote:
> From: Arnd Bergmann
> > Sent: 31 July 2017 11:09
> > Using gcc-7 with UBSAN enabled, we get this false-positive warning:
> >
> > net/netfilter/ipset/ip_set_core.c: In function 'ip_set_soc
truct ip_set, which is used instead of the struct
> timer_list .data field.
Please add the same changes to net/netfilter/ipset/ip_set_list.c too, in
order to handle all ipset modules in a single patch. I don't see a way
either to avoid the introduction of the new pointer.
Acked-by: Joz
36 matches
Mail list logo
