Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Kai-Heng Feng
Hi, > On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman > wrote: > > From: Dmitry Fleytman Dmitry Fleytman > > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

2017-12-20 Thread Kai Heng Feng
> On 20 Dec 2017, at 7:11 AM, Brian Norris <briannor...@chromium.org> wrote: > > Hi Kai, > > On Tue, Dec 19, 2017 at 12:28:17PM +0800, Kai Heng Feng wrote: >>> On 19 Dec 2017, at 2:13 AM, Brian Norris <briannor...@chromium.org> wrote: >>> On Mon,

[PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth

2017-12-20 Thread Kai-Heng Feng
<dr...@endlessm.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index a10b346b9777..96951104c45b 100644 --- a/drivers/usb/core/

[PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-20 Thread Kai-Heng Feng
. Cc: sta...@vger.kernel.org Cc: Leif Liddy <leif.li...@gmail.com> Cc: Matthias Kaehlcke <m...@chromium.org> Cc: Brian Norris <briannor...@chromium.org> Cc: Daniel Drake <dr...@endlessm.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- Daniel, Cc you becau

[PATCH] usb: quirks: Add no-lpm quirk for KY-688 USB 3.1 Type-C Hub

2017-11-13 Thread Kai-Heng Feng
KY-688 USB 3.1 Type-C Hub internally uses a Genesys Logic hub to connect to Realtek r8153. Similar to commit ("7496cfe5431f2 usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter"), no-lpm can make r8153 ethernet work. Signed-off-by: Kai-Heng Feng <kai.heng.f...@

Re: [PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-11-20 Thread Kai Heng Feng
> On 12 Oct 2017, at 1:16 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > > On Fri, Sep 22, 2017 at 4:27 PM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when >&g

[PATCH v2] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-11-21 Thread Kai-Heng Feng
From: Kai Heng Feng <kai.heng.f...@canonical.com> On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when battery is full and AC is plugged. However rate_now is correct under this circumstance, hence we can use "rate_now == 0" as a predicate to report bat

[PATCH] ALSA: hda/realtek: Add headset mic support for Intel NUC Skull Canyon

2017-11-19 Thread Kai-Heng Feng
Users have been using knob "model=dell-headset-multi" on Intel Skull Canyon for a while. Add the equivalent quirk, ALC269_FIXUP_DELL1_MIC_NO_PRESENCE for Skull Canyon. BugLink: https://bugs.launchpad.net/bugs/1732034 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

2017-11-15 Thread Kai Heng Feng
> On 15 Nov 2017, at 6:53 PM, David Miller <da...@davemloft.net> wrote: > > From: Kai-Heng Feng <kai.heng.f...@canonical.com> > Date: Wed, 15 Nov 2017 04:00:18 -0500 > >> Commit ("r8169: enable ALDPS for power saving") caused a regression on &g

[PATCH] Input: elan_i2c - add ELAN060C to the ACPI table

2017-11-07 Thread Kai-Heng Feng
ELAN060C touchpad uses elan_i2c as its driver. It can be found on Lenovo ideapad 320-14AST. BugLink: https://bugs.launchpad.net/bugs/1727544 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/input/mouse/elan_i2c_core.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] nvme-pci: disable APST on Samsung SSD 960 EVO + ASUS PRIME B350M-A

2017-11-08 Thread Kai-Heng Feng
-Heng Feng <kai.heng.f...@canonical.com> --- drivers/nvme/host/pci.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 32c413ec818c..3bb8c1915334 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host

[PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

2017-12-05 Thread Kai-Heng Feng
[ 549.116746] usb usb4: root hub lost power or was reset Based on previous guesswork, the issue can be workaround by doing PCI reset on [1b21:1343] (04:00.0). Cc: Joe Lee <asmt.sw...@gmail.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/pci/quirks.c | 2

Re: [PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 10:10 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote: >> Trying quirks in usbcore needs to rebuild the driver or the entire >> kernel if it's builtin. It can save a lot of

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 5:13 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: >> +/* Works only for digits and letters, but small and fast */ >> +#define TOLOWER(x) ((x) | 0x20) > > What is wrong with

[PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- Documentation/admin-guide/kernel-param

[PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: use in-kernel tolower() function.

Re: [PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

2017-12-06 Thread Kai-Heng Feng
On Wed, Dec 6, 2017 at 1:14 AM, Bjorn Helgaas <helg...@kernel.org> wrote: > [+cc Rafael, linux-pm] > > On Wed, Dec 06, 2017 at 12:22:42AM +0800, Kai-Heng Feng wrote: >> The board in question has three XHCI HCs: >> 02:00.0 USB controller [0c03]: Advanced Micro Devices,

[PATCH v4] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-05-07 Thread Kai-Heng Feng
se to true, because we want to find the deepest state that the device can still generate PME#. In this case, it's D0 for the device in question. Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-H

Re: [PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-05-04 Thread Kai Heng Feng
Hi Dmitry, On Apr 19, 2018, at 4:49 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: From: Kai Heng Feng <kai.heng.f...@canonical.com> Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woke

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

2018-05-10 Thread Kai-Heng Feng
VC 1.5 compatibility. However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been reported to work well. I think this should also Cc: stable. Tested-by: Kai-Heng Feng <kai.heng.f...@canonical.com> Signed-off-by: ming_qian <ming_q...@realsil.com.cn> --- drivers/media/usb/u

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

2018-05-22 Thread Kai Heng Feng
tor out code to helper function, update size checks] Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> I tested this new patch and it works well. Tested-by: Kai-Heng Feng <kai.heng.f...@canonical.com> diff --git a/drivers/media/usb/uvc/uvc_video.c b/dr

Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-05-24 Thread Kai Heng Feng
at 10:30 PM, mario.limoncie...@dell.com wrote: -Original Message- From: Pali Rohár [mailto:pali.ro...@gmail.com] Sent: Friday, April 20, 2018 2:29 AM To: Kai-Heng Feng Cc: mj...@srcf.ucam.org; dvh...@infradead.org; a...@infradead.org; Limonciello, Mario; platform-driver

[PATCH 2/2] r8169: Reinstate ASPM Support

2018-06-12 Thread Kai-Heng Feng
-off-by: Kai-Heng Feng --- v2: - Remove module parameter. - Remove pci_disable_link_state(). drivers/net/ethernet/realtek/r8169.c | 41 +++- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek

Re: Possible regression caused by commit a192aa923b66a

2018-06-12 Thread Kai Heng Feng
n 11, 2018 at 8:26 AM, Kai-Heng Feng wrote: Hi Rafael, There's a regression report [1] that says commit a192aa923b66a ("ACPI / LPSS: Consolidate runtime PM and system sleep handling") is the first bad commit. From the looks of it, it didn't introduce any behavioral change. So your help

Possible regression caused by commit a192aa923b66a

2018-06-11 Thread Kai-Heng Feng
Hi Rafael, There's a regression report [1] that says commit a192aa923b66a ("ACPI / LPSS: Consolidate runtime PM and system sleep handling") is the first bad commit. From the looks of it, it didn't introduce any behavioral change. So your help is appreciated. [1]

[RESEND] [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-05-31 Thread Kai-Heng Feng
with type 0x0010 and code 0xe008 pressed These events are for notification purpose, so we can ignore them. This patch is tested on XPS 9370. Reviewed-by: Pali Rohár Reviewed-by: Mario Limonciello Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/dell-wmi.c | 14 ++ 1 file changed

[PATCH net-next v4 2/2] r8169: Reinstate ASPM Support

2018-06-21 Thread Kai-Heng Feng
on the work from Chunhao Lin . Signed-off-by: Kai-Heng Feng --- v4: - Improve commit message. - Move the empty line to where it belongs. v3: - Change commit message wording. - Rename the function to rtl_hw_aspm_clkreq_enable(). v2: - Remove module parameter. - Remove pci_disable_link_state

Re: [PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-26 Thread Kai Heng Feng
On Apr 25, 2018, at 12:26 AM, Takashi Iwai <ti...@suse.de> wrote: On Fri, 20 Apr 2018 11:44:30 +0200, Kai-Heng Feng wrote: This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: K

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-26 Thread Kai Heng Feng
On Apr 25, 2018, at 5:13 AM, Lukas Wunner <lu...@wunner.de> wrote: On Mon, Apr 23, 2018 at 04:18:35PM +0800, Kai Heng Feng wrote: On Apr 23, 2018, at 4:08 PM, Pali Rohár <pali.ro...@gmail.com> wrote: On Monday 23 April 2018 16:04:55 Kai Heng Feng wrote: On Apr 20, 2018, at 8:10

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-04-26 Thread Kai Heng Feng
On Apr 13, 2018, at 3:29 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: On Friday, April 13, 2018 8:58:11 AM CEST Kai Heng Feng wrote: Hi Bjorn and Rafael, On Apr 1, 2018, at 12:40 AM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: USB controller ASM1042 stops working

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-05-04 Thread Kai Heng Feng
Hi Rafael, On Apr 26, 2018, at 10:36 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: On Thursday, April 26, 2018 3:55:45 PM CEST Bjorn Helgaas wrote: On Fri, Apr 13, 2018 at 09:29:56AM +0200, Rafael J. Wysocki wrote: On Friday, April 13, 2018 8:58:11 AM CEST Kai Heng Feng wrote: Hi

[PATCH] Input: elan_i2c - add ELAN0611 to the ACPI table

2017-10-19 Thread Kai-Heng Feng
ELAN0611 touchpad uses elan_i2c as its driver. It can be found on Lenovo ideapad 320-15IKB. So add it to ACPI table to enable the touchpad. BugLink: https://bugs.launchpad.net/bugs/1723736 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/input/mouse/elan_i2c_core

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread Kai Heng Feng
> On 18 Jan 2018, at 10:50 PM, David Miller wrote: > > From: Hayes Wang > Date: Thu, 18 Jan 2018 03:04:08 + > >> [...] r8153 on Dell TB15/16 dock corrupts rx packets. This change is suggested by Realtek. They guess that the XHCI

[PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-16 Thread Kai-Heng Feng
Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: - Disable RX aggregation instead of disable RX checksum - Use bcdDevice and iSerialNumber to uniquely identify Dell TB16 drivers/net/usb/r8152.c | 13 + 1 file

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-17 Thread Kai Heng Feng
> On 18 Jan 2018, at 11:04 AM, Hayes Wang wrote: > > [...] >>> r8153 on Dell TB15/16 dock corrupts rx packets. >>> >>> This change is suggested by Realtek. They guess that the XHCI >>> controller doesn't have enough buffer, and their guesswork is correct, >>> once the RX

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-30 Thread Kai Heng Feng
> On 31 Jan 2018, at 2:17 AM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. &g

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-30 Thread Kai Heng Feng
r.kernel.org>; Mario Limonciello <mario.limoncie...@dell.com> >> Subject: Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS >> 9570 and >> Precision M5530 >> >> On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng >> <kai.heng.f...@canonical.c

[PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-30 Thread Kai-Heng Feng
y: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: Put the function under right #ifdef, comment adjustment v2: Andy's suggestion, merge to a single quirk table. drivers/acpi/bus.c | 40 +--- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/

[PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-28 Thread Kai-Heng Feng
can be correctly set up, and _INI can get run. The ACPI table in this machine is designed to get parsed this way. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515 Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com>

[PATCH] ACPI / battery: Add quirk for Asus UX360UA and UX410UAK

2018-01-28 Thread Kai-Heng Feng
Same issue as other Asus laptops, ACPI incorrectly reports discharging when battery is full and AC is plugged. Use the same battery quirk can workaround the issue. BugLink: https://bugs.launchpad.net/bugs/1661876 BugLink: https://bugs.launchpad.net/bugs/1745032 Signed-off-by: Kai-Heng Feng

Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 2 Feb 2018, at 11:51 PM, JackStocker wrote: > > From: Jack Stocker > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516, > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to > start correctly at boot. > >

Re: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 5 Feb 2018, at 12:18 AM, JackStocker wrote: > > Do you mean like this? Yes, with proper commit message. > > Signed-off-by: JackStocker > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-29 Thread Kai Heng Feng
> On 29 Jan 2018, at 8:56 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Mon, Jan 29, 2018 at 8:10 AM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. &g

[PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-29 Thread Kai-Heng Feng
y: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Andy's suggestion, merge to a single quirk table. drivers/acpi/bus.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 4d0979e02a28..

Re: [PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-02-04 Thread Kai Heng Feng
> On Feb 4, 2018, at 4:26 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > > On Wed, Jan 31, 2018 at 5:56 AM, Kai-Heng Feng > <kai.heng.f...@canonical.com> wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. >>

[PATCH v4] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-02-04 Thread Kai-Heng Feng
y: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v4: Remove unnecessary message for user. v3: Put the function under right #ifdef, comment adjustment v2: Andy's suggestion, merge to a single quirk table. drivers/acpi/bus.c | 38 +++--- 1 file changed, 31 inse

[PATCH] ath9k: turn on btcoex_enable as default

2018-02-07 Thread Kai-Heng Feng
Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink: https://bugs.launchpad.net/bugs/1746164 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drive

Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

2018-02-07 Thread Kai Heng Feng
A user with i386 instead of AMD64 machine reports [1] that commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly”) causes a regression. BUG_ON(PageHighMem(pg)) in drivers/media/common/saa7146/saa7146_core.c always gets triggered after that commit. Commit 704b862f9efd ("mm/vmalloc.c:

[PATCH] drm/amdgpu: add new device to use atpx quirk

2018-02-08 Thread Kai-Heng Feng
The affected system (0x0813) is pretty similar to another one (0x0812), it also needs to use ATPX power control. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/d

tg3 crashes under high load, when using 100Mbits

2018-02-08 Thread Kai Heng Feng
Hi Broadcom folks, We are now enabling a new platform with tg3 nic, unfortunately we observed the bug [1] that dated back to 2015. I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to 2048”) but it does’t work. Do you have any idea how to solve the issue? [1]

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-08 Thread Kai Heng Feng
Hi Felix, On Feb 8, 2018, at 7:02 PM, Felix Fietkau <n...@nbd.name> wrote: On 2018-02-08 06:28, Kai-Heng Feng wrote: Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. B

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-11 Thread Kai Heng Feng
> On 10 Feb 2018, at 10:05 PM, Felix Fietkau <n...@nbd.name> wrote: > > On 2018-02-10 14:56, Kai Heng Feng wrote: >> >>> On 9 Feb 2018, at 3:16 PM, Kalle Valo <kv...@codeaurora.org> wrote: >>> Sure, but we have to make sure that we don't create reg

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-10 Thread Kai Heng Feng
> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: > Sure, but we have to make sure that we don't create regressions on > existing systems. For example, did you test this with any system which > don't support btcoex? (just asking, haven't tested this myself) No not really, but

Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

2018-02-09 Thread Kai Heng Feng
Hi Matthew, On Feb 9, 2018, at 12:08 PM, Matthew Wilcox wrote: Alternatively, try this. It passes in GFP_DMA32 from vmalloc_32, regardless of whether ZONE_DMA32 exists or not. If ZONE_DMA32 doesn't exist, then we clear it in __vmalloc_area_node(), after using it to

[PATCH] nvme-pci: do a PCI reset after S3 on Samsung 960 EVO/PM961/SM961 + Razer Blade Stealth

2018-02-15 Thread Kai-Heng Feng
hould make this quirk mandatory. BugLink: https://bugs.launchpad.net/bugs/1746340 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/nvme/host/nvme.

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-18 Thread Kai-Heng Feng
> On 16 Feb 2018, at 8:10 PM, Hans de Goede wrote: > > > Ok, I've asked the reporter of: > > https://bugzilla.redhat.com/show_bug.cgi?id=1514836 > > Which is how I got involved in this to provide DMI data and > I will whip up a patch for his machine and ask him to test

Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-02-20 Thread Kai-Heng Feng
> On 20 Feb 2018, at 4:24 PM, Mathias Nyman <mathias.ny...@linux.intel.com> > wrote: > > Hi > > On 19.02.2018 21:06, Kai-Heng Feng wrote: >> When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the >> xHC stops working: >> [ 549.114587

Re: libata: disable LPM for Crucial BX100 SSD drives

2018-02-16 Thread Kai-Heng Feng
> On 16 Feb 2018, at 6:34 PM, Hans de Goede <hdego...@redhat.com> wrote: > > Hi, > > On 15-02-18 20:00, Kai-Heng Feng wrote: >> After Laptop Mode Tools starts to use min_power for LPM, a user found >> out Crucial BX100 SSD can't get mounted. >> C

[PATCH] libata: disable LPM for Crucial BX100 SSD drives

2018-02-15 Thread Kai-Heng Feng
://bugs.launchpad.net/bugs/1726930 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/ata/libata-core.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 3c09122bf038..577cf820eed4 100644 --- a/drivers/ata/libata-core.c

[PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

2018-02-18 Thread Kai-Heng Feng
fall back to 18 bpp when sink capability is unknown"") BugLink: https://bugs.launchpad.net/bugs/1749420 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b

[PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive

2018-02-18 Thread Kai-Heng Feng
://bugs.launchpad.net/bugs/1726930 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Only apply the quirk to 500GB variant with firmware version MU02, also reorder the quirk entry to make it next to other Crucial disks. drivers/ata/libata-core.c | 3 +++ 1 file changed, 3 inse

[PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-02-19 Thread Kai-Heng Feng
(hcd_pci_runtime_suspend returned -110) Delay before running xHC command CMD_RUN can workaround the issue. Use a new quirk to make the delay only targets to the affected xHC. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Instead of doing xHC reset and disabling D3cold, a simple del

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2018-01-02 Thread Kai Heng Feng
> On 21 Dec 2017, at 7:43 PM, Daniel Drake <dr...@endlessm.com> wrote: > > On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris <briannor...@chromium.org> > wrote: >> >> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote: >>> This commit causes

[PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-He

Re: [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from S3

2018-07-25 Thread Kai-Heng Feng
Hi Rafael, > On 2018Jul24, at 18:36, Rafael J. Wysocki wrote: > > On Tuesday, July 24, 2018 11:13:42 AM CEST Rafael J. Wysocki wrote: >> On Tuesday, July 24, 2018 10:46:09 AM CEST Kai Heng Feng wrote: >>> Hi Rafael, >>> >>>> On Jun 1

Re: [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from S3

2018-07-26 Thread Kai-Heng Feng
> On 2018Jul26, at 16:14, Rafael J. Wysocki wrote: > > On Thu, Jul 26, 2018 at 5:46 AM, Kai-Heng Feng > wrote: >> Hi Rafael, >> >>> On 2018Jul24, at 18:36, Rafael J. Wysocki wrote: >>> >>> On Tuesday, July 24, 2018 11:13:42 AM CEST Rafa

[PATCH] Bluetooth: btusb: Disable Bluetooth controller during S3

2018-07-31 Thread Kai-Heng Feng
://bugzilla.kernel.org/show_bug.cgi?id=199451 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200039 Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btusb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 572fd75fbcf6..60f2832c4ff2

Re: [PATCH 4/5] memstick: rtsx_usb_ms: Support runtime power management

2018-08-23 Thread Kai-Heng Feng
Hi Ulf, Sorry for the late reply. at 21:14, Ulf Hansson wrote: On 31 July 2018 at 08:17, Kai-Heng Feng wrote: In order to let host's parent device, rtsx_usb, to use USB remote wake up signaling to do card detection, it needs to be suspended. Hence it's necessary to add runtime PM support

Re: [PATCH 4/5] memstick: rtsx_usb_ms: Support runtime power management

2018-08-23 Thread Kai-Heng Feng
at 21:29, Ulf Hansson wrote: [...] -#ifdef CONFIG_PM_SLEEP -static int rtsx_usb_ms_suspend(struct device *dev) +#ifdef CONFIG_PM +static int rtsx_usb_ms_runtime_suspend(struct device *dev) { struct rtsx_usb_ms *host = dev_get_drvdata(dev); struct memstick_host *msh =

Re: [PATCH] ACPI / LPSS: Avoid PM quirks on suspend and resume from S3

2018-07-24 Thread Kai Heng Feng
: Consolidate runtime PM and system sleep handling) Link: https://bugs.launchpad.net/bugs/1774950 Reported-by: Kai-Heng Feng Tested-by: Kai-Heng Feng Signed-off-by: Rafael J. Wysocki --- drivers/acpi/acpi_lpss.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) Index: linux-pm

[PATCH 1/5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection

2018-07-25 Thread Kai-Heng Feng
Although rtsx_usb doesn't support card removal detection, card insertion will resume rtsx_usb by USB remote wakeup signaling. When rtsx_usb gets resumed, also resumes its child devices, rtsx_usb_sdmmc and rtsx_usb_ms, to notify them there's a card in its slot. Signed-off-by: Kai-Heng Feng

[PATCH 0/5 v3] Keep rtsx_usb suspended when there's no card

2018-07-25 Thread Kai-Heng Feng
Hi, This is based on Ulf's work [1] [2]. This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel platforms and ~1.5W on AMD platforms. [1] https://patchwork.kernel.org/patch/10440583/ [2] https://patchwork.kernel.org/patch/10445725/ Kai-Heng Feng (5): misc: rtsx_usb: Use USB

[PATCH 3/5] memstick: rtsx_usb_ms: Use ms_dev() helper

2018-07-25 Thread Kai-Heng Feng
Use ms_dev() helper for consistency. Signed-off-by: Kai-Heng Feng --- drivers/memstick/host/rtsx_usb_ms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c index 4f64563df7de..cd12f3d1c088 100644

[PATCH 2/5] memstick: Prevent memstick host from getting runtime suspended during card detection

2018-07-25 Thread Kai-Heng Feng
on, so the host can be inadvertently suspended. Increment rpm count before calling memstick_check(), and decrement rpm count afterward, as now we are sure the memstick host should be suspended or not. Signed-off-by: Kai-Heng Feng --- drivers/memstick/core/memstick.c | 4 1 file changed, 4

[PATCH 4/5] memstick: rtsx_usb_ms: Support runtime power management

2018-07-25 Thread Kai-Heng Feng
from kthread to delayed_work, which can be scheduled when the host is resumed and can be canceled when the host is suspended. Use an idle function check if there's no card and the power mode is MEMSTICK_POWER_OFF. If both criteria are met, put the device to suspend. Signed-off-by: Kai-Heng Feng

[PATCH 5/5] misc: rtsx_usb: / memstick: rtsx_usb_ms: Avoid long delay before system suspend

2018-07-25 Thread Kai-Heng Feng
There's a long power-on delay at the end of rtsx_usb_ms_set_param(). This delay is noticeable right before system suspend. To prevent already suspended memstick host from getting powered on by PM core, use DPM_FLAG_SMART_SUSPEND to avoid the situation. Signed-off-by: Kai-Heng Feng --- drivers

[PATCH] Revert "ACPI / bus: Parse tables as term_list for Dell XPS 9570 and Precision M5530"

2018-07-19 Thread Kai-Heng Feng
Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- drivers/acpi/bus.c | 38 +++--- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 84b4a62018eb..f61f8927d843 100644 --- a/drivers/acpi/bus.c +++ b/drivers/

[PATCH v2] HID: i2c-hid: Don't reset device upon system resume

2018-09-05 Thread Kai-Heng Feng
. There's still one device uses I2C_HID_QUIRK_RESEND_REPORT_DESCR so keep it there. Cc: Aaron Ma Cc: AceLan Kao Signed-off-by: Kai-Heng Feng --- v2: Remove Raydium devices' ID and quirk. Rewording. drivers/hid/hid-ids.h | 4 drivers/hid/i2c-hid/i2c-hid.c | 13 +++-- 2 files

Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-03-06 Thread Kai Heng Feng
Hi Matthias, Do you have any concern about this patch? Hopefully this can get merged for v4.16… Kai-Heng

[PATCH v5] usb: core: Add "quirks" parameter for usbcore

2018-03-07 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-H

[PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-07 Thread Kai-Heng Feng
On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Signed-off-by: Kai-Heng Feng <kai.heng.f...@

[PATCH 1/2] dell-led: Change dell-led.h to dell-common.h

2018-03-07 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell-led.h => dell-common.h} | 4 ++-- sound/pci/hda/dell_wmi

Re: [PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-08 Thread Kai Heng Feng
On Mar 8, 2018, at 3:34 PM, mario.limoncie...@dell.com wrote: -Original Message- From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] Sent: Thursday, March 8, 2018 3:12 PM To: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradead.org; a...@infradead.org; Limonciello, Mario

[PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-08 Thread Kai-Heng Feng
, it hangs when runtime suspend kicks in: [ 12.796265] snd_hda_intel :01:00.1: Disabling via vga_switcheroo [ 12.796367] snd_hda_intel :01:00.1: Cannot lock devices! Since the discrete audio controller isn't useful when SG enabled, we should just disable the device. Signed-off-by: Kai

[PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-08 Thread Kai-Heng Feng
On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Signed-off-by: Kai-Heng Feng <kai.heng.f...@

[PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h

2018-03-08 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Mario suggested to squash the HDA part into the same series. drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell

Re: [alsa-devel] [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-08 Thread Kai Heng Feng
On Mar 8, 2018, at 5:38 PM, Lukas Wunner <lu...@wunner.de> wrote: On Thu, Mar 08, 2018 at 05:10:23PM +0800, Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compa

[PATCH] Bluetooth: btusb: Add Dell OptiPlex 3060 to btusb_needs_reset_resume_table

2018-02-28 Thread Kai-Heng Feng
omium.org> Cc: Hans de Goede <hdego...@redhat.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/bluetooth/btusb.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index c5cebf53eae5..e98fb

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-13 Thread Kai Heng Feng
On Mar 12, 2018, at 9:30 AM, mario.limoncie...@dell.com wrote: I think the missing aspect is that this is only used in AIO and laptop form factors where the discrete graphics is in a non-removable form factor. Why we are not checking if kernel is running on AIO or laptop form factor

[PATCH v6] usb: core: Add "quirks" parameter for usbcore

2018-03-13 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Fen

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-13 Thread Kai Heng Feng
On Mar 10, 2018, at 2:50 PM, Lukas Wunner <lu...@wunner.de> wrote: On Fri, Mar 09, 2018 at 05:30:15PM +0800, Kai Heng Feng wrote: On Thursday 08 March 2018 17:10:23 Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics&q

Re: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-09 Thread Kai Heng Feng
On Mar 9, 2018, at 12:38 AM, Pali Rohár <pali.ro...@gmail.com> wrote: On Thursday 08 March 2018 17:10:22 Kai-Heng Feng wrote: +int dell_switchable_gfx_enabled(bool *enabled); What about following API? bool dell_switchable_gfx_is_enabled(void); Are you really interested in

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-09 Thread Kai Heng Feng
On Mar 9, 2018, at 5:02 PM, Pali Rohár <pali.ro...@gmail.com> wrote: On Thursday 08 March 2018 17:10:23 Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compa

Re: [alsa-devel] [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-09 Thread Kai Heng Feng
On Mar 8, 2018, at 7:30 PM, Lukas Wunner <lu...@wunner.de> wrote: On Thu, Mar 08, 2018 at 06:38:45PM +0800, Kai Heng Feng wrote: On Mar 8, 2018, at 5:38 PM, Lukas Wunner <lu...@wunner.de> wrote: On Thu, Mar 08, 2018 at 05:10:23PM +0800, Kai-Heng Feng wrote: Some Dell platform

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

2018-03-13 Thread Kai Heng Feng
Matthew Wilcox <wi...@infradead.org> wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or + override the built-in usb core quirk list.

[PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-11 Thread Kai-Heng Feng
up_enable(), which gets called by i8042_pnp_kbd_probe(), runs before device_set_wakeup_capable(), which gets called by i8042_register_ports(). So device_set_wakeup_enable() doesn't really enable wakeup for keyboard. We can enable keyboard wakeup in i8042_register_ports() directly. Signed-off-by: Kai-Heng Fen

[PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-12 Thread Kai-Heng Feng
, it hangs when runtime suspend kicks in: [ 12.796265] snd_hda_intel :01:00.1: Disabling via vga_switcheroo [ 12.796367] snd_hda_intel :01:00.1: Cannot lock devices! Since the discrete audio controller isn't useful when SG enabled, we should just disable the device. Signed-off-by: Kai

[PATCH v3 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-12 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: Simplify dell_switchable_gfx_is_enabled() by returning bool instead of error c

[PATCH v3 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-04-12 Thread Kai-Heng Feng
m> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: Simplify dell_switchable_gfx_is_enabled() by returning bool instead of error code. Use DMI_DEV_TYPE_OEM_STRING to match Dell System. v2: Mario suggested to squash the HDA part into the same series. drivers/plat

Re: [PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-12 Thread Kai-Heng Feng
at 6:50 PM, Takashi Iwai <ti...@suse.de> wrote: On Thu, 12 Apr 2018 12:42:39 +0200, Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compatible controller: Intel Co

<    1   2   3   4   5   6   7   8   9   10   >