Re: [PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

at 6:59 PM, Pali Rohár wrote: On Thursday 12 April 2018 12:50:02 Takashi Iwai wrote: +#if IS_ENABLED(CONFIG_DELL_LAPTOP) +static bool check_dell_switchable_gfx(struct pci_dev *pdev) +{ + bool (*dell_switchable_gfx_is_enabled_func)(void); + bool enabled; + +

Re: tg3 crashes under high load, when using 100Mbits

Hi Satish, > On 2018Mar21, at 00:57, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: > > Satish Baddipadige <satish.baddipad...@broadcom.com> wrote: > >> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >> <siva.kal...@broadcom.com> wrote: >&g

Re: [PATCH] xhci: Fix USB ports for Dell Inspiron 5775

Hi Matthias, On Mar 18, 2018, at 11:11 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: The Dell Inspiron 5775 is a Raven Ridge. The Enable Slot command timed out when a USB device gets plugged: [ 212.156326] xhci_hcd :03:00.3: Error while assigning device slot ID [ 212.

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Hi Bjorn and Rafael, On Apr 1, 2018, at 12:40 AM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The device in question is not power managed by p

Re: [PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

Hi, On Mar 26, 2018, at 2:06 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. Add the device to the id_table to make it work. *Gentle ping* I am hoping this patch can get merged in v4.17. Kai-Heng BugLink:

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

Hi, On Apr 3, 2018, at 4:51 PM, Thomas Gleixner wrote: Bah. The patch is broken. New version written with brain awake below. Actually I can't reproduce this issue anymore on latest Linus' tree. I'll do a bisect and ask linux-stable maintainer to include the commit.

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

at 5:57 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 ke

[PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

From: Kai Heng Feng <kai.heng.f...@canonical.com> Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e6e15a862a0 ("Input: enable

[PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them. Tested on XPS 9370. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- I ordered them functionally instead of alphabetica

Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

On Apr 19, 2018, at 3:46 PM, Pali Rohár <pali.ro...@gmail.com> wrote: On Thursday 19 April 2018 15:24:49 Kai-Heng Feng wrote: There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them.

[PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

with type 0x0010 and code 0xe008 pressed These events are for notification purpose, so we can ignore them. This patch is tested on XPS 9370. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Reorder alphabetically. More detailed changelog. drivers/platform/x86/dell-wmi.

[PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello <mario.limoncie...@dell.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v4: Change the commit message to clarify there's no more runtime pm warning.

[PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

, it hangs the system. Since the discrete audio controller isn't useful when SG is enabled, we should just disable the device. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v4: Change the commit message to clarify there's no more runtime pm warning. Als

[PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

m> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v4: Change the commit message to clarify there's no more runtime pm warning. Also skip the check for thunderbolt attached devices. v3: Simplify dell_switchable_gfx_is_enabled() by returning bool instead

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Apr 20, 2018, at 8:10 PM, Takashi Iwai <ti...@suse.de> wrote: On Fri, 20 Apr 2018 11:44:32 +0200, Kai-Heng Feng wrote: Now it's a typical discrete-only system. HDMI audio comes from AMD audio controller, others from Intel audio controller. When SG is enabled, the unused AMD

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Apr 23, 2018, at 4:08 PM, Pali Rohár <pali.ro...@gmail.com> wrote: On Monday 23 April 2018 16:04:55 Kai Heng Feng wrote: On Apr 20, 2018, at 8:10 PM, Takashi Iwai <ti...@suse.de> wrote: On Fri, 20 Apr 2018 11:44:32 +0200, Kai-Heng Feng wrote: Now it's a typical discrete

[PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. Add the device to the id_table to make it work. BugLink: https://bugs.launchpad.net/bugs/1620762 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/media/usb/cx231xx/cx231xx-cards.c | 3 +++ 1 file c

Re: [PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Hi Bjorn, Rafael, On Mar 19, 2018, at 10:09 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The device in question is not power managed by p

Re: [PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Rafael J. Wysocki <r...@rjwysocki.net> wrote: On Monday, March 26, 2018 7:54:35 AM CEST Kai Heng Feng wrote: Hi Bjorn, Rafael, On Mar 19, 2018, at 10:09 PM, Kai-Heng Feng <kai.heng.f...@canonical.com> wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 (&quo

Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

Hi Thomas, A user reported [1] that the Realtek ethernet r8169 stops working after S3 since v4.15-rc6. The issue still exists in Linus' tree: [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not ready [ 150.944101] do_IRQ: 3.37 No irq handler for vector [ 150.944105] r8169

Re: `do_IRQ: 1.55 No irq handler for vector` on ASRock E350M1

Hi Tom & Thomas, On Feb 27, 2018, at 12:42 AM, Tom Lendacky wrote: On 2/26/2018 10:37 AM, Morton, Eric wrote: Thomas, Yazen dug out PLAT-21393 as sounding like this issue. I haven't had a chance to digest it. Yes, internally to AMD, that was the bug that tracked

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

Thomas Gleixner <t...@linutronix.de> wrote: On Sat, 31 Mar 2018, Kai-Heng Feng wrote: A user reported [1] that the Realtek ethernet r8169 stops working after S3 since v4.15-rc6. The issue still exists in Linus' tree: [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not

[PATCH] sky2: Increase D3 delay to sky2 stops working after suspend

sta...@vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 9fe85300e7b6..5754116

[PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

because we want to find the deepest state that the device can still generate PME#. Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v3: State the reaso

[PATCH] xhci: Fix USB ports for Dell Inspiron 5775

-port3: couldn't allocate usb_device AMD suggests that a delay before xHC suspends can fix the issue. I can confirm it fixes the issue, so use the suspend delay quirk for Raven Ridge's xHC. Cc: sta...@vger.kernel.org Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/us

[PATCH] PCI / PM: Always check PME wakeup capability for runtime wakeup support

_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/pci/pci.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..e026d8f313ec 100644 --- a/drivers/pci/pci

Re: [PATCH] PCI / PM: Always check PME wakeup capability for runtime wakeup support

On Mar 19, 2018, at 6:00 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: On Sunday, March 18, 2018 8:12:15 PM CET Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The de

[PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- v2: Explicitly check dev->pme_support. drivers/pci/pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

Kai Heng Feng <kai.heng.f...@canonical.com> wrote: Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently ALDPS and ASPM for r8169 is enabled in different commercial products, just not in Linux mainline. Hayes and Realtek folks, How do we make this patch going forwa

[PATCH v7] usb: core: Add "quirks" parameter for usbcore

ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

Kai Heng Feng <kai.heng.f...@canonical.com> wrote: Matthew Wilcox <wi...@infradead.org> wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or +

[PATCH 1/2] usb: core: Copy parameter string correctly and remove superfluous null check

the superfluous null check. This is found by Smatch. Fixes: 027bd6cafd9a ("usb: core: Add "quirks" parameter for usbcore") Cc: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/usb/core/quirks.c | 9 +++

[PATCH 2/2] usb: core: Add USB_QUIRK_DELAY_CTRL_MSG to usbcore quirks

There's a new quirk, USB_QUIRK_DELAY_CTRL_MSG. Add it to usbcore quirks for completeness. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- Documentation/admin-guide/kernel-parameters.txt | 4 +++- drivers/usb/core/quirks.c | 3 +++ 2 files chan

Re: tg3 crashes under high load, when using 100Mbits

Satish Baddipadige <satish.baddipad...@broadcom.com> wrote: On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: On Fri, Feb 9, 2018 at 10:41 AM, Kai Hen

[PATCH v4] usb: core: Add "quirks" parameter for usbcore

ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox <wi...@infradead.org> wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may nee

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

On 28 Feb 2018, at 10:47 PM, Matthew Wilcox <wi...@infradead.org> wrote: On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote: +static char quirks_param[128]; +module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); +MODULE_PARM_DESC(quirks, "Add/modify

[PATCH] ALSA: hda: Add AZX_DCAPS_PM_RUNTIME for AMD Raven Ridge

This patch can make audio controller in AMD Raven Ridge gets runtime suspended to D3, to save ~1W power when it's not in use. Cc: Vijendar Mukunda Signed-off-by: Kai-Heng Feng --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda

Re: [PATCH v2] HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

Hi Jiri and Benjamin, > On Oct 5, 2018, at 12:46, Kai-Heng Feng wrote: > > Raydium touchpanel (2386:4B33) sometimes does not work in desktop session > although it works in display manager. > > During user logging, the display manager exits, close the HID device, > then th

Re: [PATCH v2] HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

> On Oct 15, 2018, at 16:04, Benjamin Tissoires > wrote: > > On Fri, Oct 5, 2018 at 6:46 AM Kai-Heng Feng > wrote: >> >> Raydium touchpanel (2386:4B33) sometimes does not work in desktop session >> although it works in display manager. >> >> D

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

Hi Bjorn, > On Sep 17, 2018, at 16:19, Kai-Heng Feng wrote: > > at 18:54, Shah, Nehal-bakulchandra wrote: > >> From: Nehal-bakulchandra Shah >> >> This contains two drivers. >> 1)i2c-amd-platdrv: This is based on I2C framework of >> linux kern

Re: [v5] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

> > Signed-off-by: Elie Morisse Re-test v5 on Dell Latitude 5495, works good. Tested-by: Kai-Heng Feng > --- > Changes since v1:(https://www.spinics.net/lists/linux-i2c/msg34650.html) > -> Add fix for IOMMU > -> Add depedency of ACPI > -> Add locks to avoid the

[PATCH] HID: i2c-hid: Disable runtime PM for LG touchscreen

resumed and received an ON command. - In the shutdown callback, it receives another SLEEP command. I failed to find a reliable interval between ON/SLEEP commands that can make it work, so let's simply disable runtime PM for the device. Signed-off-by: Kai-Heng Feng --- drivers/hid/hid-ids.h

[PATCH] HID: multitouch: Add pointstick support for Cirque Touchpad

Cirque Touchpad/Pointstick combo is similar to Alps devices, it requires MT_CLS_WIN_8_DUAL to expose its pointstick as a mouse. Signed-off-by: Kai-Heng Feng --- drivers/hid/hid-ids.h| 3 +++ drivers/hid/hid-multitouch.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/drivers

Re: [PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

Hi, > On Nov 9, 2018, at 08:21, Bjorn Helgaas wrote: > > On Tue, Nov 06, 2018 at 03:12:13PM +0800, AceLan Kao wrote: >> It leads to the power consumption raises to 2.2W during s2idle, while >> it consumes less than 1W during long idle if put SK hynix nvme to D3 >> and then enter s2idle. >> From

[PATCH v2] HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

device, then the device gets runtime resumed and powered on. If the trasition from display manager to desktop sesesion is fast, the touchpanel cannot switch from powered off to powered on in short timeframe. So add a small delay to workaround the issue. Signed-off-by: Kai-Heng Feng --- v2: - Use

[PATCH] HID: i2c-hid: Add a small delay after powering on/off the device

device, then the device gets runtime resumed and powered on. If the trasition from display manager to desktop sesesion is fast, the touchpanel cannot switch from powered off to powered on in short timeframe. So add a small delay to workaround the issue. Signed-off-by: Kai-Heng Feng --- drivers/hid

Re: [PATCH] HID: i2c-hid: Add a small delay after powering on/off the device

On Oct 1, 2018, at 3:00 PM, Benjamin Tissoires wrote: On Mon, Oct 1, 2018 at 5:53 AM Kai-Heng Feng wrote: Raydium touchpanel (2386:4B33) sometimes does not workin desktop session although it works in display manager. During user logging, the display manager exits, close the HID device

[PATCH 2/3] Bluetooth: btusb: Load firmware exclusively for Intel BT

To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when IWLWIFI is enabled. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btusb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[PATCH 1/3] Bluetooth: btintel: Add firmware lock function

and iwlwifi load firmwares exclusively can avoid the issue, so introduce a lock to use in btusb and iwlwifi. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btintel.c | 14 ++ drivers/bluetooth/btintel.h | 10 ++ include/linux/intel-wifi-bt.h | 8 3 files

[RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when BT_INTEL is enabled. Signed-off-by: Kai-Heng Feng --- .../net/wireless/intel/iwlwifi/pcie/trans.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git

[RESEND] [PATCH 2/3] Bluetooth: btusb: Load firmware exclusively for Intel BT

To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when IWLWIFI is enabled. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btusb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

[RESEND] [PATCH 1/3] Bluetooth: btintel: Add firmware lock function

and iwlwifi load firmwares exclusively can avoid the issue, so introduce a lock to use in btusb and iwlwifi. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btintel.c | 14 ++ drivers/bluetooth/btintel.h | 10 ++ include/linux/intel-wifi-bt.h | 8 3 files

[PATCH] HID: usbhid: Add quirk for Redragon/Dragonrise Seymur 2

ink: https://bugs.launchpad.net/bugs/1793846 Signed-off-by: Kai-Heng Feng --- drivers/hid/hid-ids.h| 1 + drivers/hid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index bc49909aba8e..0e0aa7f0e6fc 100644 --- a/drivers/hid/hid-i

Re: [PATCH] HID: usbhid: Add quirk for Redragon/Dragonrise Seymur 2

Hi Benjamin, > On Oct 11, 2018, at 16:34, Benjamin Tissoires > wrote: > > Hi Kai-Heng, > > On Thu, Oct 11, 2018 at 9:56 AM Kai-Heng Feng > wrote: >> >> Redragon Seymur 2 stops working since commit 190d7f02ce8e ("HID: input: >> do not increment us

[PATCH] ALSA: hda/realtek - Cannot adjust speaker's volume on Dell XPS 27 7760

gs/1775068 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 6f3c8e888c2a..69283633ae91 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch

Re: [PATCH] HID: i2c-hid: Add a small delay after powering on/off the device

> On Oct 3, 2018, at 5:10 PM, Jiri Kosina wrote: > > On Mon, 1 Oct 2018, Kai-Heng Feng wrote: > >> Raydium touchpanel (2386:4B33) sometimes does not workin desktop session >> although it works in display manager. >> >> During user logging, the display

Re: [PATCH] HID: i2c-hid: Don't reset device upon system resume

Hi Benjamin, I forgot to include mailing list, first time -in-reply-to user :) at 17:39, Benjamin Tissoires wrote: On Mon, Sep 3, 2018 at 11:09 AM Kai-Heng Feng wrote: Raydium touchscreen triggers interrupt storm after system-wide suspend: [ 179.085033] i2c_hid i2c-CUST:00

[PATCH] ALSA: hda: Add support for AMD Stoney Ridge

It's similar to other AMD audio devices, it also supports D3, which can save some power drain. Signed-off-by: Kai-Heng Feng --- sound/pci/hda/hda_intel.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index d8eb2b5f51ae

[PATCH] igb: Fix an issue that PME is not enabled during runtime suspend

es the PCI PME. To fix the issue, let's not to save PCI states when it's runtime suspend, to let the PCI subsytem enables PME. Fixes: 42eca2302146 ("PCI: Don't touch card regs after runtime suspend D3") Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/igb/igb_main.c | 8 +--

Elantech SMBus support regression

Hi Benjamin, It appears the Elantech SMBus support breaks some users’ touchpad. Please have a look at [1] [2], thanks! [1] https://bugs.launchpad.net/bugs/1803600 [2] https://bugs.archlinux.org/task/59714 Kai-Heng

Re: [PATCH v3] i2c:amd I2C Driver based on PCI Interface for upcoming, platform

is responsible to talk with Mp2 and does all C2P/P2C communication or reading/writing from DRAM in case of more data. Reviewed-by: S-k, Shyam-sundar Reviewed-by: Sandeep Singh Signed-off-by: Nehal-bakulchandra Shah The I2C touchpad on Latitude 5495 works with this patch. Tested-by: Kai-Heng Feng

Re: [PATCH v4] usb: core: Add "quirks" parameter for usbcore

On 28 Feb 2018, at 10:47 PM, Matthew Wilcox wrote: On Mon, Feb 26, 2018 at 11:04:57PM +0800, Kai-Heng Feng wrote: +static char quirks_param[128]; +module_param_string(quirks, quirks_param, sizeof(quirks_param), 0644); +MODULE_PARM_DESC(quirks, "Add/modify USB quirks by specifying q

[PATCH] Bluetooth: btusb: Add Dell OptiPlex 3060 to btusb_needs_reset_resume_table

Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btusb.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index c5cebf53eae5..e98fb5343a00 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -389,6 +389,13 @@ st

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

Matthew Wilcox wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or + override the built-in usb core quirk list. List + entries

Re: [PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Hi Bjorn, Rafael, On Mar 19, 2018, at 10:09 PM, Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The device in question is not power managed by platform firmware, furthermore, it only su

[PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. Add the device to the id_table to make it work. BugLink: https://bugs.launchpad.net/bugs/1620762 Signed-off-by: Kai-Heng Feng --- drivers/media/usb/cx231xx/cx231xx-cards.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] nvme-pci: do a PCI reset after S3 on Samsung 960 EVO/PM961/SM961 + Razer Blade Stealth

hould make this quirk mandatory. BugLink: https://bugs.launchpad.net/bugs/1746340 Signed-off-by: Kai-Heng Feng --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 10 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 8e

[PATCH] libata: disable LPM for Crucial BX100 SSD drives

://bugs.launchpad.net/bugs/1726930 Signed-off-by: Kai-Heng Feng --- drivers/ata/libata-core.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 3c09122bf038..577cf820eed4 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c

[PATCH v6] usb: core: Add "quirks" parameter for usbcore

ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-He

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Mar 12, 2018, at 9:30 AM, mario.limoncie...@dell.com wrote: I think the missing aspect is that this is only used in AIO and laptop form factors where the discrete graphics is in a non-removable form factor. Why we are not checking if kernel is running on AIO or laptop form factor

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Mar 10, 2018, at 2:50 PM, Lukas Wunner wrote: On Fri, Mar 09, 2018 at 05:30:15PM +0800, Kai Heng Feng wrote: On Thursday 08 March 2018 17:10:23 Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is e

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

Kai Heng Feng wrote: Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently ALDPS and ASPM for r8169 is enabled in different commercial products, just not in Linux mainline. Hayes and Realtek folks, How do we make this patch going forward? Do you find the root cause

[PATCH 1/2] usb: core: Copy parameter string correctly and remove superfluous null check

the superfluous null check. This is found by Smatch. Fixes: 027bd6cafd9a ("usb: core: Add "quirks" parameter for usbcore") Cc: Dan Carpenter Signed-off-by: Kai-Heng Feng --- drivers/usb/core/quirks.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --gi

[PATCH 2/2] usb: core: Add USB_QUIRK_DELAY_CTRL_MSG to usbcore quirks

There's a new quirk, USB_QUIRK_DELAY_CTRL_MSG. Add it to usbcore quirks for completeness. Signed-off-by: Kai-Heng Feng --- Documentation/admin-guide/kernel-parameters.txt | 4 +++- drivers/usb/core/quirks.c | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff

Re: `do_IRQ: 1.55 No irq handler for vector` on ASRock E350M1

Hi Tom & Thomas, On Feb 27, 2018, at 12:42 AM, Tom Lendacky wrote: On 2/26/2018 10:37 AM, Morton, Eric wrote: Thomas, Yazen dug out PLAT-21393 as sounding like this issue. I haven't had a chance to digest it. Yes, internally to AMD, that was the bug that tracked the issue I was

Re: [PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Rafael J. Wysocki wrote: On Monday, March 26, 2018 7:54:35 AM CEST Kai Heng Feng wrote: Hi Bjorn, Rafael, On Mar 19, 2018, at 10:09 PM, Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm

Re: [PATCH v6] usb: core: Add "quirks" parameter for usbcore

Kai Heng Feng wrote: Matthew Wilcox wrote: On Tue, Mar 13, 2018 at 03:26:19PM +0800, Kai-Heng Feng wrote: + usbcore.quirks= + [USB] A list of quirks entries to supplement or + override the built-in usb core quirk list. List

Re: tg3 crashes under high load, when using 100Mbits

Satish Baddipadige wrote: On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam wrote: On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng wrote: Hi Broadcom folks, We are now enabling a new platform with tg3 nic, unfortunately we

[PATCH 1/2] dell-led: Change dell-led.h to dell-common.h

This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell-led.h => dell-common.h} | 4 ++-- sound/pci/hda/dell_wmi_helper.c | 2 +- 3 files changed

[PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Signed-off-by: Kai-Heng Feng --- drivers/platfor

Re: [PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

On Mar 8, 2018, at 3:34 PM, mario.limoncie...@dell.com wrote: -Original Message- From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] Sent: Thursday, March 8, 2018 3:12 PM To: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradead.org; a...@infradead.org; Limonciello, Mario

[PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

, it hangs when runtime suspend kicks in: [ 12.796265] snd_hda_intel :01:00.1: Disabling via vga_switcheroo [ 12.796367] snd_hda_intel :01:00.1: Cannot lock devices! Since the discrete audio controller isn't useful when SG enabled, we should just disable the device. Signed-off-by: Kai

[PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Signed-off-by: Kai-Heng Feng --- v2: Mario suggested

[PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h

This header will be used for more than just led. Change it to a more generic name. Signed-off-by: Kai-Heng Feng --- v2: Mario suggested to squash the HDA part into the same series. drivers/platform/x86/dell-laptop.c | 2 +- include/linux/{dell-led.h => dell-common.h} | 4 ++-- so

Re: [alsa-devel] [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Mar 8, 2018, at 5:38 PM, Lukas Wunner wrote: On Thu, Mar 08, 2018 at 05:10:23PM +0800, Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compatible control

Re: [PATCH v2 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

On Mar 9, 2018, at 12:38 AM, Pali Rohár wrote: On Thursday 08 March 2018 17:10:22 Kai-Heng Feng wrote: +int dell_switchable_gfx_enabled(bool *enabled); What about following API? bool dell_switchable_gfx_is_enabled(void); Are you really interested in errors? Then what about? Not really

Re: [alsa-devel] [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Mar 8, 2018, at 7:30 PM, Lukas Wunner wrote: On Thu, Mar 08, 2018 at 06:38:45PM +0800, Kai Heng Feng wrote: On Mar 8, 2018, at 5:38 PM, Lukas Wunner wrote: On Thu, Mar 08, 2018 at 05:10:23PM +0800, Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS

Re: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Mar 9, 2018, at 5:02 PM, Pali Rohár wrote: On Thursday 08 March 2018 17:10:23 Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compatible controller: Intel Corporat

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

On Apr 13, 2018, at 3:29 PM, Rafael J. Wysocki wrote: On Friday, April 13, 2018 8:58:11 AM CEST Kai Heng Feng wrote: Hi Bjorn and Rafael, On Apr 1, 2018, at 12:40 AM, Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag

Re: [PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

On Apr 25, 2018, at 12:26 AM, Takashi Iwai wrote: On Fri, 20 Apr 2018 11:44:30 +0200, Kai-Heng Feng wrote: This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng BTW, wouldn't it be better postpone the rename

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

On Apr 25, 2018, at 5:13 AM, Lukas Wunner wrote: On Mon, Apr 23, 2018 at 04:18:35PM +0800, Kai Heng Feng wrote: On Apr 23, 2018, at 4:08 PM, Pali Rohár wrote: On Monday 23 April 2018 16:04:55 Kai Heng Feng wrote: On Apr 20, 2018, at 8:10 PM, Takashi Iwai wrote: On Fri, 20 Apr 2018 11:44

Re: [PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

Hi Dmitry, On Apr 19, 2018, at 4:49 PM, Kai-Heng Feng wrote: From: Kai Heng Feng Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

Hi Rafael, On Apr 26, 2018, at 10:36 PM, Rafael J. Wysocki wrote: On Thursday, April 26, 2018 3:55:45 PM CEST Bjorn Helgaas wrote: On Fri, Apr 13, 2018 at 09:29:56AM +0200, Rafael J. Wysocki wrote: On Friday, April 13, 2018 8:58:11 AM CEST Kai Heng Feng wrote: Hi Bjorn and Rafael, On Apr

[PATCH v4] PCI / PM: Always check PME wakeup capability for runtime wakeup support

se to true, because we want to find the deepest state that the device can still generate PME#. In this case, it's D0 for the device in question. Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been reported to work well. I think this should also Cc: stable. Tested-by: Kai-Heng Feng Signed-off-by: ming_qian --- drivers/media/usb/uvc/uvc_video.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/uvc

Re: [PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

On Wed, Jul 12, 2017 at 11:39 AM, Kai-Heng Feng wrote: > Similar to other Gigabyte laptops, the touchpad on P57 requires a > keyboard reset to detect Elantech touchpad correctly. > > BugLink: https://bugs.launchpad.net/bugs/1594214 > Signed-off-by: Kai-Heng Feng > --- >

[PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

? [77122.622952] handle_tx_event: 541 callbacks suppressed No more warning messages with XHCI_TRUST_TX_LENGTH applied. BugLink: https://bugs.launchpad.net/bugs/1710548 Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

Hi, On Fri, Aug 18, 2017 at 3:22 PM, Felipe Balbi wrote: > > hi, > > Kai-Heng Feng writes: >> When plugging Logitech C920 webcam, warning messages filled up dmesg: >> [77117.655018] xhci_hcd :0c:00.0: WARN Successful completion on short >> TX: ne

[PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Like other Plantronics devices, P610 does not support sample rate reading. Apply sample rate quirk to it. BugLink: https://bugs.launchpad.net/bugs/1719853 Signed-off-by: Kai-Heng Feng --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb

<    1   2   3   4   5   6   7   8   9   10   >