Re: [PATCH resend] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-05 Thread Kai-Heng Feng
Hi Hans, On Fri, Oct 6, 2017 at 2:04 AM, Hans de Goede wrote: > Hi All, > > This is a resend with Kai Heng Feng added to the Cc. Kai can you please > test this patch. This patch replaces yours, as many devices seem to be > affected so a whitelist is the better approach

Re: [PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

2017-10-05 Thread Kai-Heng Feng
Hi, On Fri, Oct 6, 2017 at 2:22 AM, Takashi Iwai wrote: > On Thu, 05 Oct 2017 20:04:06 +0200, > Kai-Heng Feng wrote: >> >> Like other Plantronics devices, P610 does not support sample >> rate reading. Apply sample rate quirk to it. >> >> BugLink: htt

Re: btusb "firmware request while host is not available" at resume

2017-10-05 Thread Kai-Heng Feng
Hi Luis, On Wed, Oct 4, 2017 at 8:20 AM, Luis R. Rodriguez wrote: > So please retest now that the revert happened: commit > f007cad159e99fa2acd3b2e9364fbb32ad28b971 ("Revert "firmware: add sanity check > on shutdown/suspend"). I can confirm the issue is gone after the commit. Also, thanks for

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-10-05 Thread Kai-Heng Feng
On Thu, Oct 5, 2017 at 5:17 AM, Luis R. Rodriguez wrote: > On Tue, Aug 22, 2017 at 03:52:46PM +0800, Kai-Heng Feng wrote: >> Currently, firmware will only be chached if assign_firmware_buf() gets >> called. > > True, but also more importantly we peg the fw cache to the dev

Re: [PATCH resend] platform/x86: peaq-wmi: Add DMI check before binding to the WMI interface

2017-10-07 Thread Kai-Heng Feng
Hi, On Fri, Oct 6, 2017 at 12:23 PM, Kai-Heng Feng wrote: > Hi Hans, > > On Fri, Oct 6, 2017 at 2:04 AM, Hans de Goede wrote: >> Hi All, >> >> This is a resend with Kai Heng Feng added to the Cc. Kai can you please >> test this patch. This patch rep

Re: [PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-10-11 Thread Kai-Heng Feng
On Fri, Sep 22, 2017 at 4:27 PM, Kai-Heng Feng wrote: > On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when > battery is full and AC is plugged. > > However rate_now is correct under this circumstance, hence we can use > "rate_now == 0" as a predica

[PATCH] platform/x86: peaq-wmi: Blacklist Lenovo ideapad 700-15ISK

2017-10-01 Thread Kai-Heng Feng
peaq-wmi on Lenovo ideapad 700-15ISK keeps sending KEY_SOUND, which makes user's repeated keys gets interrupted. The system does not have Dolby button, let's blacklist it. BugLink: https://bugs.launchpad.net/bugs/1720219 Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/peaq-wmi.c | 19

[PATCH 1/1] Revert "HID: multitouch: Support ALPS PTP stick with pid 0x120A"

2017-10-02 Thread Kai-Heng Feng
This reverts commit fcaa4a07d2a4b541e91da7a55d8b3331f96d1865. As noted by Masaki [1], 0x120A + trackpoint will not be used in mass production machines, so remove the ID accordingly. [1] http://www.spinics.net/lists/linux-input/msg53222.html Signed-off-by: Kai-Heng Feng --- drivers/hid/hid

Re: btusb "firmware request while host is not available" at resume

2017-10-02 Thread Kai-Heng Feng
Hi Luis, On Thu, Sep 14, 2017 at 1:39 AM, Luis R. Rodriguez wrote: [snipped] > Would a fw_cache_hint(device, name_list) be reasonable then sometime *before* > suspend? All this would do is ask the firmware API to extend the fw cache > list with the entries. It would not load firmware

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

2017-12-18 Thread Kai Heng Feng
Hi Brian, > On 19 Dec 2017, at 2:13 AM, Brian Norris wrote: > > Hi Greg, > > On Mon, Dec 18, 2017 at 12:43:48PM +0100, Greg Kroah-Hartman wrote: >> On Fri, Dec 15, 2017 at 07:05:39PM -0800, Matthias Kaehlcke wrote: >>> We identified the above patch as the culprit, in combination with USB >>>

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

2017-12-20 Thread Kai Heng Feng
> On 20 Dec 2017, at 7:11 AM, Brian Norris wrote: > > Hi Kai, > > On Tue, Dec 19, 2017 at 12:28:17PM +0800, Kai Heng Feng wrote: >>> On 19 Dec 2017, at 2:13 AM, Brian Norris wrote: >>> On Mon, Dec 18, 2017 at 12:43:48PM +0100, Greg Kroah-Hartman wrote: >&g

[PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2017-12-20 Thread Kai-Heng Feng
. Cc: sta...@vger.kernel.org Cc: Leif Liddy Cc: Matthias Kaehlcke Cc: Brian Norris Cc: Daniel Drake Signed-off-by: Kai-Heng Feng --- Daniel, Cc you because this also affects your original quirk patch for Realtek btusb. drivers/bluetooth/btusb.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth

2017-12-20 Thread Kai-Heng Feng
inal issue, but we should do it before btusb_open(). Hence, add reset-resume quirk in usb core intead of btusb. Cc: sta...@vger.kernel.org Cc: Leif Liddy Cc: Matthias Kaehlcke Cc: Brian Norris Cc: Daniel Drake Signed-off-by: Kai-Heng Feng --- drivers/usb/core/quirks.c | 3 +++ 1 file

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-28 Thread Kai Heng Feng
> On 27 Nov 2017, at 11:13 PM, > wrote: > > This is quite surprising to me too. The externally plugged in r8153 dongle, > was it connected over type C port or over type A port? AFAIK Type C port is > actually Alpine ridge pass through port. It is not connected to XHCI > controller > or

[PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

2017-12-05 Thread Kai-Heng Feng
[ 549.116746] usb usb4: root hub lost power or was reset Based on previous guesswork, the issue can be workaround by doing PCI reset on [1b21:1343] (04:00.0). Cc: Joe Lee Signed-off-by: Kai-Heng Feng --- drivers/pci/quirks.c | 2 ++ drivers/usb/host/pci-quirks.c | 3 +++ 2 files changed, 5

[PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng --- Documentation/admin-guide/kernel-parameters.txt | 55 + dri

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai Heng Feng
> On 6 Dec 2017, at 5:13 PM, Greg KH wrote: > > On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: >> +/* Works only for digits and letters, but small and fast */ >> +#define TOLOWER(x) ((x) | 0x20) > > What is wrong with the in-kernel version of

[PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng --- v2: use in-kernel tolower() function. Documentation/admin-guide/kern

Re: [PATCH] xhci: Fix front USB ports on ASUS PRIME B350M-A

2017-12-06 Thread Kai-Heng Feng
On Wed, Dec 6, 2017 at 1:14 AM, Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Wed, Dec 06, 2017 at 12:22:42AM +0800, Kai-Heng Feng wrote: >> The board in question has three XHCI HCs: >> 02:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] USB 3.1 >>

Re: [PATCH 4.13 03/28] Bluetooth: btusb: fix QCA Rome suspend/resume

2017-12-17 Thread Kai Heng Feng
Hi, > On 16 Dec 2017, at 11:05 AM, Matthias Kaehlcke wrote: > stable branches are currently broken for BTUSB_QCA_ROME with USB > autosuspend enabled, since the above patch is not included (I only > checked v4.4 and v4.9), so we probably want to integrate it. Thanks for this information. I

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e

2017-12-18 Thread Kai-Heng Feng
Hi, > On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman > wrote: > > From: Dmitry Fleytman Dmitry Fleytman > > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an issue with some Logitech webcams. > > There is one more

[PATCH] usb: quirks: Add no-lpm quirk for KY-688 USB 3.1 Type-C Hub

2017-11-13 Thread Kai-Heng Feng
KY-688 USB 3.1 Type-C Hub internally uses a Genesys Logic hub to connect to Realtek r8153. Similar to commit ("7496cfe5431f2 usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter"), no-lpm can make r8153 ethernet work. Signed-off-by: Kai-Heng Feng --- drivers/usb/core/qu

[PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-09-22 Thread Kai-Heng Feng
d.net/bugs/1482390 Signed-off-by: Kai-Heng Feng --- drivers/acpi/battery.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 13e7b56e33ae..f9f008cf3da7 100644 --- a/drivers/acpi/battery.c +++ b/dr

[PATCH] ALSA: usb-audio: Add sample rate quirk for Plantronics C310/C520-M

2017-09-19 Thread Kai-Heng Feng
Like other Plantronics devices, C310 and C520-M do not support sample rate reading. Add them to the sample rate quirk accordingly. BugLink: https://bugs.launchpad.net/bugs/1708499 BugLink: https://bugs.launchpad.net/bugs/1709282 Signed-off-by: Kai-Heng Feng --- sound/usb/quirks.c | 2 ++ 1 file

[PATCH] nvme-pci: disable APST on Samsung SSD 960 EVO + ASUS PRIME B350M-A

2017-11-08 Thread Kai-Heng Feng
-Heng Feng --- drivers/nvme/host/pci.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 32c413ec818c..3bb8c1915334 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2438,7 +2438,7 @@ static

[PATCH] Input: elan_i2c - add ELAN0608 to the ACPI table

2017-08-10 Thread Kai-Heng Feng
Similar to commit 722c5ac708b4f ("Input: elan_i2c - add ELAN0605 to the ACPI table"), ELAN0608 should be handled by elan_i2c. This touchpad can be found in Lenovo ideapad 320-14IKB. BugLink: https://bugs.launchpad.net/bugs/1708852 Signed-off-by: Kai-Heng Feng --- drivers/i

[PATCH] ALSA: hda/realtek: Add headset mic support for Intel NUC Skull Canyon

2017-11-19 Thread Kai-Heng Feng
Users have been using knob "model=dell-headset-multi" on Intel Skull Canyon for a while. Add the equivalent quirk, ALC269_FIXUP_DELL1_MIC_NO_PRESENCE for Skull Canyon. BugLink: https://bugs.launchpad.net/bugs/1732034 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c |

Re: [PATCH] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-11-20 Thread Kai Heng Feng
> On 12 Oct 2017, at 1:16 PM, Kai-Heng Feng wrote: > > On Fri, Sep 22, 2017 at 4:27 PM, Kai-Heng Feng > wrote: >> On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when >> battery is full and AC is plugged. >> >> However rate_now is corre

[PATCH v2] ACPI / battery: add quirk for Asus GL502VSK and UX305LA

2017-11-21 Thread Kai-Heng Feng
From: Kai Heng Feng On Asus GL502VSK and UX305LA, ACPI incorrectly reports discharging when battery is full and AC is plugged. However rate_now is correct under this circumstance, hence we can use "rate_now == 0" as a predicate to report battery full status correctly. BugL

[PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

2017-08-04 Thread Kai-Heng Feng
The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm quirk can make it work. Since another r8153 dongle at my hand does not have the issue, so add the quirk to the hub instead. Signed-off-by: Kai-Heng Feng --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

2017-08-07 Thread Kai-Heng Feng
On Mon, Aug 7, 2017 at 12:49 PM, Kai-Heng Feng wrote: > In icm_ar_is_supported(), icm->upstream_port will be uninitialized if > the hardware is not an Apple one. > > The uninitialized icm->upstream_port will later be dereferenced in > pcie2cio_write(), causes a NULL poin

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

2017-08-07 Thread Kai-Heng Feng
On Mon, Aug 7, 2017 at 3:02 PM, Mika Westerberg wrote: > On Mon, Aug 07, 2017 at 02:50:49PM +0800, Kai-Heng Feng wrote: >> On Mon, Aug 7, 2017 at 12:49 PM, Kai-Heng Feng >> wrote: >> > In icm_ar_is_supported(), icm->upstream_port will be uninitialized if >> &

Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge

2017-08-07 Thread Kai-Heng Feng
On Mon, Aug 7, 2017 at 3:51 PM, Mika Westerberg wrote: > At this point we should find out that the ICM is already running and the > function never calls pci2cio_write(). I guess you mean this code section: /* Check if the ICM firmware is already running */ val =

Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

2017-08-07 Thread Kai-Heng Feng
On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum wrote: > Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng: >> The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm >> quirk can make it work. > > So can you confirm it works with LPM on another hub

[PATCH] firmware: add firmware to new device's devres list for second time cache

2017-08-22 Thread Kai-Heng Feng
time the system suspend, those firmware won't be cached. Hence, we should add the firmware name to the devres when the firmware is found in cache, to make the firmware cacheable next time. Signed-off-by: Kai-Heng Feng --- drivers/base/firmware_class.c | 4 1 file changed, 4 insertions

[PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-22 Thread Kai-Heng Feng
fected, so revert the commit. Conflicts: drivers/usb/host/xhci-pci.c drivers/usb/host/xhci.h Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci-hub.c | 3 --- drivers/usb/host/xhci-pci.c | 12 drivers/usb/host/xhci.h | 2 +- 3 files changed, 1 insert

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-08-28 Thread Kai-Heng Feng
On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman wrote: > On 28.08.2017 12:29, Greg KH wrote: >> >> On Tue, Aug 22, 2017 at 05:14:47PM +0800, Kai-Heng Feng wrote: >>> >>> This reverts commit dec08194ffeccfa1cf085906b53d301930eae18f. >>> >>> Commi

[PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

2017-08-08 Thread Kai-Heng Feng
-off-by: Kai-Heng Feng --- v2: Clarify that the adapter uses a hub internally. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 3116edfcdc18..c96daf34431e 100644 --- a/drivers/usb/core/quirks.c +++ b

Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

2017-08-08 Thread Kai-Heng Feng
On Tue, Aug 8, 2017 at 4:28 PM, Oliver Neukum wrote: > Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng: >> Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to >> connect to Realtek r8153. >> >> The Realtek r8153 ethernet does not work

[PATCH v3] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

2017-08-08 Thread Kai-Heng Feng
instead. Signed-off-by: Kai-Heng Feng --- v3: Update comment to reflect the quirk is for the hub. v2: Clarify that the adapter uses a hub internally. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index

Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C

2017-08-24 Thread Kai-Heng Feng
On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman wrote: > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an issue with some Logitech webcams. > > Apparently model C920-C has the same issue so applying > the same quirk as

[PATCH 2/2] Bluetooth: btusb: ath3k: Cache firmware for already patched Bluetooth chip

2017-08-24 Thread Kai-Heng Feng
by calling request_firmware() even if the chip is already updated - now the firmware_class knows what to cache. In this case, we don't really need to wait for the firmware content, so we use the async version of request_firmware(). Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/ath3k.c | 49

[PATCH 1/2] Bluetooth: btusb: ath3k: Decide firmware name before checking update status

2017-08-24 Thread Kai-Heng Feng
Decide firmware name before checking patch update status. Firmware name is required for caching. Also, version information in btusb_setup_qca() is being calculated twice, reduce it to one. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/ath3k.c | 10 +++ drivers/bluetooth/btusb.c | 72

Re: [PATCH 2/2] Bluetooth: btusb: ath3k: Cache firmware for already patched Bluetooth chip

2017-08-24 Thread Kai-Heng Feng
ass knows what to cache. >> >> In this case, we don't really need to wait for the firmware content, so >> we use the async version of request_firmware(). >> >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/bluetooth/ath3k.c | 49

[PATCH v2 1/4] Bluetooth: btusb: Add firmware caching function for already patched Bluetooth chip

2017-08-25 Thread Kai-Heng Feng
by calling request_firmware() even if the chip is already updated - now the firmware_class knows what to cache. In this case, we don't really need to wait for the firmware content, so we use the async version of request_firmware(). Signed-off-by: Kai-Heng Feng --- v2: Split patches for different vendors

[PATCH v2 4/4] Bluetooth: ath3k: Cache firmware for Atheros Bluetooth

2017-08-25 Thread Kai-Heng Feng
For Intel Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Verified on DW1707 wireless module (0cf3:e005). Signed-off-by: Kai-Heng Feng --- v2: Split patches for different vendors. drivers/bluetooth/ath3k.c | 59

[PATCH v2 2/4] Bluetooth: btusb: Cache firmware for Intel Bluetooth

2017-08-25 Thread Kai-Heng Feng
For Intel Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Verified on Intel 7265 wireless module (8087:0a2a). Signed-off-by: Kai-Heng Feng --- v2: Split patches for different vendors. drivers/bluetooth/btusb.c

[PATCH v2 3/4] Bluetooth: btusb: Cache firmware for QCA Bluetooth

2017-08-25 Thread Kai-Heng Feng
For QCA Bluetooth that downloads firmware based on patched status, it should still call request_firmware() once if download is not needed. Also, version information was converted twice, reduce it to one. Verified on DW1810 wireless module (0cf3:e009). Signed-off-by: Kai-Heng Feng --- v2: Split

[PATCH] usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard

2017-08-15 Thread Kai-Heng Feng
the quirk for Corsair Strafe RGB. BugLink: https://bugs.launchpad.net/bugs/1678477 Signed-off-by: Kai-Heng Feng --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 574da2b4529c..1ea5060dae69 100644 --- a/drivers

Re: [PATCH] firmware: add firmware to new device's devres list for second time cache

2017-09-15 Thread Kai-Heng Feng
On Tue, Aug 22, 2017 at 12:52 AM, Kai-Heng Feng wrote: > Currently, firmware will only be chached if assign_firmware_buf() gets > called. > > When a device loses its power or a USB device gets plugged to another > port under suspend, request_firmware() can still find

Re: [PATCH] Revert "xhci: Limit USB2 port wake support for AMD Promontory hosts"

2017-09-15 Thread Kai-Heng Feng
On Mon, Aug 28, 2017 at 9:56 PM, Kai-Heng Feng wrote: > On Mon, Aug 28, 2017 at 6:14 PM, Mathias Nyman > wrote: >> On 28.08.2017 12:29, Greg KH wrote: >> >> Adding more people who were involved in the original patch. >> >> Users are now seeing the unrespons

[PATCH v3 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-12 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v3: Simplify dell_switchable_gfx_is_enabled() by returning bool instead of error code. Use DMI_DEV_TYPE_OEM_STRING to match Dell System. v2: Mario

[PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-12 Thread Kai-Heng Feng
, it hangs when runtime suspend kicks in: [ 12.796265] snd_hda_intel :01:00.1: Disabling via vga_switcheroo [ 12.796367] snd_hda_intel :01:00.1: Cannot lock devices! Since the discrete audio controller isn't useful when SG enabled, we should just disable the device. Signed-off-by: Kai

[PATCH v3 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-04-12 Thread Kai-Heng Feng
On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Cc: Mario Limonciello Signed-off-by: Kai-Heng Fe

Re: [PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-12 Thread Kai-Heng Feng
at 6:50 PM, Takashi Iwai wrote: On Thu, 12 Apr 2018 12:42:39 +0200, Kai-Heng Feng wrote: Some Dell platforms (Preicsion 7510/7710/7520/7720) have a BIOS option "Switchable Graphics" (SG). When SG is enabled, we have: 00:02.0 VGA compatible controller: Intel Corporation Device 59

Re: [PATCH v3 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-12 Thread Kai-Heng Feng
at 6:59 PM, Pali Rohár wrote: On Thursday 12 April 2018 12:50:02 Takashi Iwai wrote: +#if IS_ENABLED(CONFIG_DELL_LAPTOP) +static bool check_dell_switchable_gfx(struct pci_dev *pdev) +{ + bool (*dell_switchable_gfx_is_enabled_func)(void); + bool enabled; + + /* Only need to

Re: [PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-04-13 Thread Kai Heng Feng
Hi Bjorn and Rafael, On Apr 1, 2018, at 12:40 AM, Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The device in question is not power managed by platform firmware, furthermore, it onl

Re: [PATCH] media: cx231xx: Add support for AverMedia DVD EZMaker 7

2018-04-13 Thread Kai Heng Feng
Hi, On Mar 26, 2018, at 2:06 PM, Kai-Heng Feng wrote: User reports AverMedia DVD EZMaker 7 can be driven by VIDEO_GRABBER. Add the device to the id_table to make it work. *Gentle ping* I am hoping this patch can get merged in v4.17. Kai-Heng BugLink: https://bugs.launchpad.net/bugs

Re: tg3 crashes under high load, when using 100Mbits

2018-04-14 Thread Kai-Heng Feng
Hi Satish, > On 2018Mar21, at 00:57, Kai-Heng Feng wrote: > > Satish Baddipadige wrote: > >> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >> wrote: >>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam >>> wrote: >>>> On F

[PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-20 Thread Kai-Heng Feng
with type 0x0010 and code 0xe008 pressed These events are for notification purpose, so we can ignore them. This patch is tested on XPS 9370. Signed-off-by: Kai-Heng Feng --- v2: Reorder alphabetically. More detailed changelog. drivers/platform/x86/dell-wmi.c | 14 ++ 1 file

[PATCH v4 1/3] dell-led: Change dell-led.h to dell-common.h

2018-04-20 Thread Kai-Heng Feng
This header will be used for more than just led. Change it to a more generic name. Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v4: Change the commit message to clarify there's no more runtime pm warning. Also skip the check for thunderbolt attached devices. v3: Simplify

[PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-20 Thread Kai-Heng Feng
, it hangs the system. Since the discrete audio controller isn't useful when SG is enabled, we should just disable the device. Signed-off-by: Kai-Heng Feng --- v4: Change the commit message to clarify there's no more runtime pm warning. Also skip the check for thunderbolt attached de

[PATCH v4 2/3] platform/x86: dell-*: Add interface for switchable graphics status query

2018-04-20 Thread Kai-Heng Feng
On some Dell platforms, there's a BIOS option "Enable Switchable Graphics". This information is useful if we want to do different things based on this value, e.g. disable unused audio controller that comes with the discrete graphics. Cc: Mario Limonciello Signed-off-by: Kai-Heng Fe

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-23 Thread Kai Heng Feng
On Apr 20, 2018, at 8:10 PM, Takashi Iwai wrote: On Fri, 20 Apr 2018 11:44:32 +0200, Kai-Heng Feng wrote: Now it's a typical discrete-only system. HDMI audio comes from AMD audio controller, others from Intel audio controller. When SG is enabled, the unused AMD audio contoller still

Re: [alsa-devel] [PATCH v4 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-04-23 Thread Kai Heng Feng
On Apr 23, 2018, at 4:08 PM, Pali Rohár wrote: On Monday 23 April 2018 16:04:55 Kai Heng Feng wrote: On Apr 20, 2018, at 8:10 PM, Takashi Iwai wrote: On Fri, 20 Apr 2018 11:44:32 +0200, Kai-Heng Feng wrote: Now it's a typical discrete-only system. HDMI audio comes from AMD audio

Re: [PATCH] xhci: Fix USB ports for Dell Inspiron 5775

2018-04-09 Thread Kai Heng Feng
Hi Matthias, On Mar 18, 2018, at 11:11 PM, Kai-Heng Feng wrote: The Dell Inspiron 5775 is a Raven Ridge. The Enable Slot command timed out when a USB device gets plugged: [ 212.156326] xhci_hcd :03:00.3: Error while assigning device slot ID [ 212.156340] xhci_hcd :03:00.3: Max

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

2018-04-10 Thread Kai Heng Feng
Hi, On Apr 3, 2018, at 4:51 PM, Thomas Gleixner wrote: Bah. The patch is broken. New version written with brain awake below. Actually I can't reproduce this issue anymore on latest Linus' tree. I'll do a bisect and ask linux-stable maintainer to include the commit. Thanks for your help!

[PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-11 Thread Kai-Heng Feng
up_enable(), which gets called by i8042_pnp_kbd_probe(), runs before device_set_wakeup_capable(), which gets called by i8042_register_ports(). So device_set_wakeup_enable() doesn't really enable wakeup for keyboard. We can enable keyboard wakeup in i8042_register_ports() directly. Signed-off-by: Kai-Heng Feng

Re: [PATCH] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-17 Thread Kai-Heng Feng
at 5:57 AM, Dmitry Torokhov wrote: On Wed, Apr 11, 2018 at 04:59:05PM +0800, Kai-Heng Feng wrote: Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default.

Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

2018-03-30 Thread Kai-Heng Feng
Hi Thomas, A user reported [1] that the Realtek ethernet r8169 stops working after S3 since v4.15-rc6. The issue still exists in Linus' tree: [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not ready [ 150.944101] do_IRQ: 3.37 No irq handler for vector [ 150.944105] r8169

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

2018-03-31 Thread Kai-Heng Feng
Thomas Gleixner wrote: On Sat, 31 Mar 2018, Kai-Heng Feng wrote: A user reported [1] that the Realtek ethernet r8169 stops working after S3 since v4.15-rc6. The issue still exists in Linus' tree: [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not ready [ 150.944101] do_IRQ: 3.37

[PATCH] sky2: Increase D3 delay to sky2 stops working after suspend

2018-03-31 Thread Kai-Heng Feng
-by: Kai-Heng Feng --- drivers/net/ethernet/marvell/sky2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 9fe85300e7b6..5754116a6a4d 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers

[PATCH v3] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-03-31 Thread Kai-Heng Feng
because we want to find the deepest state that the device can still generate PME#. Fixes: de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng --- v3: State the reason why the wakeup flag gets changed. v2:

[PATCH] xhci: Fix USB ports for Dell Inspiron 5775

2018-03-18 Thread Kai-Heng Feng
-port3: couldn't allocate usb_device AMD suggests that a delay before xHC suspends can fix the issue. I can confirm it fixes the issue, so use the suspend delay quirk for Raven Ridge's xHC. Cc: sta...@vger.kernel.org Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci-pci.c | 5 - 1 file

[PATCH] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-03-18 Thread Kai-Heng Feng
_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng --- drivers/pci/pci.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..e026d8f313ec 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -2125

Re: [PATCH] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-03-19 Thread Kai Heng Feng
On Mar 19, 2018, at 6:00 PM, Rafael J. Wysocki wrote: On Sunday, March 18, 2018 8:12:15 PM CET Kai-Heng Feng wrote: USB controller ASM1042 stops working after commit de3ef1eb1cd0 ("PM / core: Drop run_wake flag from struct dev_pm_info"). The device in question is not pow

[PATCH v2] PCI / PM: Always check PME wakeup capability for runtime wakeup support

2018-03-19 Thread Kai-Heng Feng
_info") Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Kai-Heng Feng --- v2: Explicitly check dev->pme_support. drivers/pci/pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index f6a4dd10d9b0..52821a21fc07 100644 --- a/

[PATCH v7] usb: core: Add "quirks" parameter for usbcore

2018-03-19 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng

[PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-19 Thread Kai-Heng Feng
There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them. Tested on XPS 9370. Signed-off-by: Kai-Heng Feng --- I ordered them functionally instead of alphabetically, I can re-order them

Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

2018-04-19 Thread Kai Heng Feng
On Apr 19, 2018, at 3:46 PM, Pali Rohár wrote: On Thursday 19 April 2018 15:24:49 Kai-Heng Feng wrote: There are two new events generated by dell-wmi, rfkill and fn-lock, from Dell Systems. These events are for notification purpose, so we can ignore them. Tested on XPS 9370. Signed-off

[PATCH v2] Input: i8042 - Fix KBD port cannot wake up system from suspend-to-idle

2018-04-19 Thread Kai-Heng Feng
From: Kai Heng Feng Commit f13b2065de81 ("Input: i8042 - allow KBD and AUX ports to wake up from suspend-to-idle") make system in s2idle can be woken up by i8042 keyboard, but it's disabled by default. In commit 3e6e15a862a0 ("Input: enable remote wakeup for PNP i8042 keyboard

Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-03-06 Thread Kai Heng Feng
Hi Matthias, Do you have any concern about this patch? Hopefully this can get merged for v4.16… Kai-Heng

[PATCH v5] usb: core: Add "quirks" parameter for usbcore

2018-03-07 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng

[PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng Feng -

Re: [PATCH v3] usb: core: Add "quirks" parameter for usbcore

2018-02-25 Thread Kai-Heng Feng
On Sun, Feb 25, 2018 at 11:18 PM, Matthew Wilcox wrote: > On Sun, Feb 25, 2018 at 08:38:33PM +0800, Kai-Heng Feng wrote: >> v2: Use in-kernel tolower() function. > > ... why are you using tolower at all? > > You've got 13 quirks already; you may need to use upper case as w

Re: [PATCH] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 2 Feb 2018, at 11:51 PM, JackStocker wrote: > > From: Jack Stocker > > Following on from this patch: https://lkml.org/lkml/2017/11/3/516, > Corsair K70 RGB keyboards also require the DELAY_INIT quirk to > start correctly at boot. > > Device ids found here: > usb 3-3: New USB device

Re: [PATCH v2] Add delay-init quirk for Corsair K70 RGB keyboards

2018-02-04 Thread Kai Heng Feng
> On 5 Feb 2018, at 12:18 AM, JackStocker wrote: > > Do you mean like this? Yes, with proper commit message. > > Signed-off-by: JackStocker > --- > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c >

Re: [PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-02-04 Thread Kai Heng Feng
> On Feb 4, 2018, at 4:26 PM, Rafael J. Wysocki wrote: > > On Wed, Jan 31, 2018 at 5:56 AM, Kai-Heng Feng > wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. >> >> The touchpad relies on its _INI method to up

[PATCH v4] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-02-04 Thread Kai-Heng Feng
can be correctly set up, and _INI can get run. The ACPI table in this machine is designed to get parsed this way. Also, change the quirk table to a more generic name. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515 Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v4: Remove

[PATCH v4] usb: core: Add "quirks" parameter for usbcore

2018-02-26 Thread Kai-Heng Feng
ce this new "dynamic" function. Now users can use "usbcore.quirks=" as short term workaround before the next kernel release. Also, the quirk parameter can XOR the builtin quirks for debugging purpose. This is inspired by usbhid and usb-storage. Signed-off-by: Kai-Heng

Re: libata: disable LPM for Crucial BX100 SSD drives

2018-02-16 Thread Kai-Heng Feng
> On 16 Feb 2018, at 6:34 PM, Hans de Goede wrote: > > Hi, > > On 15-02-18 20:00, Kai-Heng Feng wrote: >> After Laptop Mode Tools starts to use min_power for LPM, a user found >> out Crucial BX100 SSD can't get mounted. >> Crucial BX100 SSD drives don't wo

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-02-18 Thread Kai-Heng Feng
> On 16 Feb 2018, at 8:10 PM, Hans de Goede wrote: > > > Ok, I've asked the reporter of: > > https://bugzilla.redhat.com/show_bug.cgi?id=1514836 > > Which is how I got involved in this to provide DMI data and > I will whip up a patch for his machine and ask him to test > and once that is

[PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

2018-02-18 Thread Kai-Heng Feng
fall back to 18 bpp when sink capability is unknown"") BugLink: https://bugs.launchpad.net/bugs/1749420 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ddd5379

[PATCH v2] libata: disable LPM for Crucial BX100 SSD 500GB drive

2018-02-18 Thread Kai-Heng Feng
://bugs.launchpad.net/bugs/1726930 Signed-off-by: Kai-Heng Feng --- v2: Only apply the quirk to 500GB variant with firmware version MU02, also reorder the quirk entry to make it next to other Crucial disks. drivers/ata/libata-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/libata

[PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-02-19 Thread Kai-Heng Feng
(hcd_pci_runtime_suspend returned -110) Delay before running xHC command CMD_RUN can workaround the issue. Use a new quirk to make the delay only targets to the affected xHC. Signed-off-by: Kai-Heng Feng --- v2: Instead of doing xHC reset and disabling D3cold, a simple delay can workaround the issue. Now both

Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-02-20 Thread Kai-Heng Feng
> On 20 Feb 2018, at 4:24 PM, Mathias Nyman > wrote: > > Hi > > On 19.02.2018 21:06, Kai-Heng Feng wrote: >> When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the >> xHC stops working: >> [ 549.114587] xhci_hcd :02:00.0: WARN:

Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

2018-01-02 Thread Kai Heng Feng
> On 21 Dec 2017, at 7:43 PM, Daniel Drake wrote: > > On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris > wrote: >> >> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote: >>> This commit causes a regression on some QCA ROME chips. The USB devic

Re: [PATCH v2] nvme: explicitly disable APST on quirked devices

2017-06-26 Thread Kai-Heng Feng
On Tue, Jun 27, 2017 at 2:05 AM, Andy Lutomirski wrote: > On Mon, Jun 26, 2017 at 12:01 AM, Kai-Heng Feng > wrote: >> A user reports APST is enabled, even when the NVMe is quirked or with >> option "default_ps_max_latency_us=0". >> >> The current logic wi

[PATCH] Input: i8042 - add Gigabyte P57 to the keyboard reset table

2017-07-11 Thread Kai-Heng Feng
Similar to other Gigabyte laptops, the touchpad on P57 requires a keyboard reset to detect Elantech touchpad correctly. BugLink: https://bugs.launchpad.net/bugs/1594214 Signed-off-by: Kai-Heng Feng --- drivers/input/serio/i8042-x86ia64io.h | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH] r8152: disable rx checksum offload on Dell TB dock

2017-11-22 Thread Kai-Heng Feng
bugs/1729674 Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- drivers/net/usb/r8152.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index d51d9abf7986..58b80b5e7803 100644 --- a/dri

<    1   2   3   4   5   6   7   8   9   10   >