Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

2020-10-23 Thread Kai-Heng Feng
> On Oct 23, 2020, at 19:34, Takashi Iwai wrote: > > On Fri, 23 Oct 2020 12:23:36 +0200, > Kai-Heng Feng wrote: >> >> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev) >> __azx_runtime_suspend(chip); >> else >>

Re: [PATCH 3/4] ALSA: hda: Refactor controller PM to use direct-complete optimization

2020-10-23 Thread Kai-Heng Feng
> On Oct 23, 2020, at 19:36, Takashi Iwai wrote: > > On Fri, 23 Oct 2020 12:23:37 +0200, > Kai-Heng Feng wrote: >> @@ -1103,10 +1096,8 @@ static int azx_runtime_suspend(struct device *dev) >> chip = card->private_data; >> >>

[PATCH v2] Bluetooth: btrtl: Ask 8821C to drop old firmware

2020-10-26 Thread Kai-Heng Feng
this issue so we only use this trick for old 8821C firmware version. Suggested-by: Max Chou Signed-off-by: Kai-Heng Feng --- v2: - Fix incorrect parAnthesis on le16_to_cpu. - Ensure firmware gets re-uploaded in initialization. drivers/bluetooth/btrtl.c | 46

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk forLenovo A630Z TIO built-in usb-audio card

2020-11-19 Thread Kai-Heng Feng
> On Nov 19, 2020, at 21:59, Greg Kroah-Hartman > wrote: > > On Thu, Nov 19, 2020 at 09:41:32PM +0800, Kai-Heng Feng wrote: >> Hi penghao, >> >>> On Nov 19, 2020, at 20:17, 彭浩 wrote: >>> >>> root@uos-PC:/sys/bus/usb/devices/usb7# dmesg &

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk forLenovo A630Z TIO built-in usb-audio card

2020-11-19 Thread Kai-Heng Feng
> On Nov 19, 2020, at 22:23, Greg Kroah-Hartman > wrote: > > On Thu, Nov 19, 2020 at 10:12:02PM +0800, Kai-Heng Feng wrote: >> >> >>> On Nov 19, 2020, at 21:59, Greg Kroah-Hartman >>> wrote: >>> >>> On Thu, Nov 19, 20

[PATCH] ALSA: usb-audio: Use ALC1220-VB-DT mapping for ASUS ROG Strix TRX40 mobo

2020-11-15 Thread Kai-Heng Feng
ASUS ROG Strix also uses ALC1220-VB-DT, so adjust the mapping and add profile name to let userspace pick correct UCM profile. BugLink: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1031 Signed-off-by: Kai-Heng Feng --- sound/usb/card.c | 4 sound/usb/mixer_maps.c | 3

[PATCH] Bluetooth: btrtl: Ask 8821C to drop old firmware after shutdown

2020-10-22 Thread Kai-Heng Feng
this issue so we only use this trick for old 8821C firmware version. Signed-off-by: Kai-Heng Feng --- drivers/bluetooth/btrtl.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 3a9afc905f24..2f3843fb2b95

[PATCH v2 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization

2020-10-26 Thread Kai-Heng Feng
core will suspend and resume the device as normal. - If codec is runtime-suspended, PM core will try to keep it suspended. If it's still suspended after system resume, we use hda_codec_pm_complete() to resume codec if it's needed. Signed-off-by: Kai-Heng Feng --- v2: - Also resume when codec

[PATCH v2 0/4] HDA controller and PM cleanups

2020-10-26 Thread Kai-Heng Feng
t-complete for it if conditions are met. So make runtime and system PM distinctive to always apply correct wake up setting. At least point, hopefully all runtime PM issues are solved, let's enable runtime PM by default again. Kai-Heng Feng (4): ALSA: hda: Refactor codec PM to use direct-complete optimization

[PATCH v2 2/4] ALSA: hda: Stop mangling PCI IRQ

2020-10-26 Thread Kai-Heng Feng
, as most modern systems won't have that issue. Signed-off-by: Kai-Heng Feng --- v2: - Wording. - Add info on IRQ # can change on old hardwares. sound/pci/hda/hda_intel.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index

[PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-26 Thread Kai-Heng Feng
, to not break direct-complete for codecs. While at it, also remove AZX_DCAPS_SUSPEND_SPURIOUS_WAKEUP, as the original bug commit a6630529aecb ("ALSA: hda: Workaround for spurious wakeups on some Intel platforms") solves doesn't happen with this patch. Signed-off-by: Kai-Heng Feng --- v

[PATCH v2 4/4] ALSA: hda: Reinstate runtime_allow() for all hda controllers

2020-10-26 Thread Kai-Heng Feng
The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA: hda: fix jack detection with Realtek codecs when in D3"), let's try enabling runtime PM by default again. Signed-off-by: Kai-Heng Feng --- v2: - No change. sound/pci/hda/hda_intel.c | 1 + 1 file changed, 1

Re: [PATCH v2 2/4] ALSA: hda: Stop mangling PCI IRQ

2020-10-27 Thread Kai-Heng Feng
> On Oct 27, 2020, at 15:36, Takashi Iwai wrote: > > On Tue, 27 Oct 2020 06:39:59 +0100, > Kai-Heng Feng wrote: >> >> The code predates 2005, it should be unnecessary now as PCI core handles >> IRQ much better nowadays. >> >> So stop PC

Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Kai-Heng Feng
> On Oct 27, 2020, at 16:15, Takashi Iwai wrote: > > On Tue, 27 Oct 2020 09:12:07 +0100, > Takashi Iwai wrote: >> >> On Tue, 27 Oct 2020 08:46:05 +0100, >> Takashi Iwai wrote: @@ -1103,10 +1115,8 @@ static int azx_runtime_suspend(struct device *dev) chip = card->private_data;

Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Kai-Heng Feng
Hi Kai, > On Oct 27, 2020, at 19:38, Kai Vehmanen wrote: > > Hi, > > thanks, this looks like a good improvement! Some minor notes: > > On Tue, 27 Oct 2020, Kai-Heng Feng wrote: > >> Both pm_runtime_force_suspend() and pm_runtime_force_resume() have >>

[PATCH v3 3/3] ALSA: hda: Reinstate runtime_allow() for all hda controllers

2020-10-27 Thread Kai-Heng Feng
The broken jack detection should be fixed by commit a6e7d0a4bdb0 ("ALSA: hda: fix jack detection with Realtek codecs when in D3"), let's try enabling runtime PM by default again. Signed-off-by: Kai-Heng Feng --- v3: - No change. v2: - No change. sound/pci/hda/hda_intel.c | 1

[PATCH v3 0/3] HDA controller PM and codec PM cleanups

2020-10-27 Thread Kai-Heng Feng
t-complete for it if conditions are met. So make runtime and system PM distinctive to always apply correct wake up setting. At least point, hopefully all runtime PM issues are solved, let's enable runtime PM by default again. v3: - Drop "ALSA: hda: Stop mangling PCI IRQ" Kai-Heng Feng (3): ALSA: hd

[PATCH v3 2/3] ALSA: hda: Separate runtime and system suspend

2020-10-27 Thread Kai-Heng Feng
, to not break direct-complete for codecs. While at it, also remove AZX_DCAPS_SUSPEND_SPURIOUS_WAKEUP, as the original bug commit a6630529aecb ("ALSA: hda: Workaround for spurious wakeups on some Intel platforms") solves doesn't happen with this patch. Signed-off-by: Kai-Heng Feng ---

[PATCH v3 1/3] ALSA: hda: Refactor codec PM to use direct-complete optimization

2020-10-27 Thread Kai-Heng Feng
core will suspend and resume the device as normal. - If codec is runtime-suspended, PM core will try to keep it suspended. If it's still suspended after system resume, we use hda_codec_pm_complete() to resume codec if it's needed. Signed-off-by: Kai-Heng Feng --- v3: - No change v2: - Also

Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-30 Thread Kai-Heng Feng
> On Oct 29, 2020, at 01:39, Tyler Hicks wrote: > > On 2020-10-28 11:30:11, Tyler Hicks wrote: >> So, we need help from Kai, Kenneth, or Mimi to verify my assumption that >> their firmware is providing an empty main event log and a populated >> final event log. > > Hi Kai, Kenneth, and Mimi -

[PATCH] PM / reboot: Use S5 for reboot

2020-10-30 Thread Kai-Heng Feng
ccurs when a system restart is requested" [1], so let's do the same here. [1] https://docs.microsoft.com/en-us/windows/win32/power/system-power-states Signed-off-by: Kai-Heng Feng --- kernel/reboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/reboot.c b/kernel/rebo

Re: [PATCH] PM / reboot: Use S5 for reboot

2020-10-30 Thread Kai-Heng Feng
Hi Hans, > On Oct 30, 2020, at 15:06, Kai-Heng Feng wrote: > > After reboot, it's not possible to use hotkeys to enter BIOS setup and > boot menu on some HP laptops. > > BIOS folks identified the root cause is the missing _PTS call, and BIOS > is expecting _PTS to do pro

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card

2020-11-18 Thread Kai-Heng Feng
Hi penghao, > On Nov 18, 2020, at 19:06, penghao wrote: > > Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in > usb-audio. when A630Z going into S3,the system immediately wakeup 7-8 > seconds later by usb-audio disconnect interrupt to avoids the issue. > > Seeking a better

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card

2020-11-18 Thread Kai-Heng Feng
Hi penghao, > On Nov 18, 2020, at 20:30, penghao wrote: > > Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in > usb-audio. when A630Z going into S3,the system immediately wakeup 7-8 > seconds later by usb-audio disconnect interrupt to avoids the issue. > eg dmesg: > > [

[PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-29 Thread Kai-Heng Feng
ling method. So add an indication to let thermal core know it should leave thermal device to userspace to handle. Signed-off-by: Kai-Heng Feng --- drivers/thermal/thermal_core.c | 3 +++ include/linux/thermal.h| 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/thermal/thermal_core

[PATCH 3/3] thermal: intel: intel_pch_thermal: Indicate userspace usage

2020-11-29 Thread Kai-Heng Feng
The device isn't present under ACPI ThermalZone, and there's a dedicated userspace daemon for this thermal device. Let thermal core know it shouldn't handle trips to avoid surprising thermal shutdown. Signed-off-by: Kai-Heng Feng --- drivers/thermal/intel/intel_pch_thermal.c | 11

[PATCH 2/3] thermal: int340x: Indicate userspace usage

2020-11-29 Thread Kai-Heng Feng
The device isn't present under ACPI ThermalZone, and there's a dedicated userspace daemon for this thermal device. Let thermal core know it shouldn't handle trips to avoid surprising thermal shutdown. Signed-off-by: Kai-Heng Feng --- drivers/thermal/intel/int340x_thermal/int3400_thermal.c

Re: [PATCH 2/3] thermal: int340x: Indicate userspace usage

2020-11-29 Thread Kai-Heng Feng
> On Nov 30, 2020, at 13:29, Srinivas Pandruvada > wrote: > > On Sun, 2020-11-29 at 01:54 +0800, Kai-Heng Feng wrote: >> The device isn't present under ACPI ThermalZone, and there's a >> dedicated >> userspace daemon for this thermal device. >> >>

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Kai-Heng Feng
> On Nov 30, 2020, at 15:57, Daniel Lezcano wrote: > > > [Added Srinivas] > > On 28/11/2020 18:54, Kai-Heng Feng wrote: >> We are seeing thermal shutdown on Intel based mobile workstations, the >> shutdown happens during the first trip handle in >> therm

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Kai-Heng Feng
> On Dec 1, 2020, at 00:19, Srinivas Pandruvada > wrote: > > On Mon, 2020-11-30 at 16:23 +0800, Kai-Heng Feng wrote: >>> On Nov 30, 2020, at 15:57, Daniel Lezcano < >>> daniel.lezc...@linaro.org> wrote: >>> >>> >>> [Added Srini

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Kai-Heng Feng
> On Dec 1, 2020, at 02:13, Srinivas Pandruvada > wrote: [snipped] >>> What about creating an new callback >>> >>> enum thermal_trip_status { >>> THERMAL_TRIP_DISABLED = 0, >>> THERMAL_TRIP_ENABLED, >>> }; >>> >>> int get_trip_status(struct thermal_zone_device *, int trip, enum

[PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

2020-11-23 Thread Kai-Heng Feng
/switches. So when putting the root port to D3cold as last step, ACPI GPE is untouched as it's already enabled. However, platform may need PCI devices to be in D3hot or PME enabled prior enabling GPE to make it work. So re-enable ACPI GPE to address this. Signed-off-by: Kai-Heng Feng --- drivers

[Regression] Can only do S3 once after "tpm: take TPM chip power gating out of tpm_transmit()"

2020-12-06 Thread Kai-Heng Feng
Hi Jarkko, A user report that the system can only do S3 once. Subsequent S3 fails after commit a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()"). Dmesg with the issue, collected under 5.10-rc2: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1891502/comments/14 Dmesg

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-12-06 Thread Kai-Heng Feng
> On Dec 1, 2020, at 02:39, Srinivas Pandruvada > wrote: > > On Tue, 2020-12-01 at 02:22 +0800, Kai-Heng Feng wrote: >>> On Dec 1, 2020, at 02:13, Srinivas Pandruvada < >>> srinivas.pandruv...@linux.intel.com> wrote: >> >> [snipped

[PATCH] igc: Report speed and duplex as unknown when device is runtime suspended

2020-12-01 Thread Kai-Heng Feng
wever, igc is like igb, runtime resume routine uses rtnl_lock() which upper ethtool layer also uses. So to prevent a deadlock on rtnl, take a different approach, use pm_runtime_suspended() to avoid reading register while device is runtime suspended. Cc: Signed-off-by: Kai-Heng Feng --- drivers/

Re: [PATCH 1/2][v3] e1000e: Leverage direct_complete to speed up s2ram

2020-12-02 Thread Kai-Heng Feng
gt; > After the patch: > echo disabled > //sys/devices/pci\:00/\:00\:19.0/power/wakeup > becomes 0 usecs because the hooks will be skipped. > > Suggested-by: Kai-Heng Feng > Signed-off-by: Chen Yu Well, I was intended to send it, but anyway :) > --- > v2:

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-26 Thread Kai-Heng Feng
> On Nov 26, 2020, at 19:10, Chen Yu wrote: > > On Thu, Nov 26, 2020 at 02:36:42PM +0800, Kai-Heng Feng wrote: >>>> >>>> What about plugging ethernet cable and using WoL after system is suspended? >>>> Commit "e1000e: Exclud

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-27 Thread Kai-Heng Feng
> On Nov 26, 2020, at 22:45, Chen Yu wrote: > > On Thu, Nov 26, 2020 at 08:05:02PM +0800, Kai-Heng Feng wrote: >> >> >>> On Nov 26, 2020, at 19:10, Chen Yu wrote: >>> >>> On Thu, Nov 26, 2020 at 02:36:42PM +0800, Kai-Heng Feng wrote: &

[PATCH 3/3] thermal: intel: intel_pch_thermal: Indicate userspace usage

2020-11-28 Thread Kai-Heng Feng
The device isn't present under ACPI ThermalZone, and there's a dedicated userspace daemon for this thermal device. Let thermal core know it shouldn't handle trips to avoid surprising thermal shutdown. Signed-off-by: Kai-Heng Feng --- drivers/thermal/intel/intel_pch_thermal.c | 11

[PATCH 2/3] thermal: int340x: Indicate userspace usage

2020-11-28 Thread Kai-Heng Feng
The device isn't present under ACPI ThermalZone, and there's a dedicated userspace daemon for this thermal device. Let thermal core know it shouldn't handle trips to avoid surprising thermal shutdown. Signed-off-by: Kai-Heng Feng --- drivers/thermal/intel/int340x_thermal/int3400_thermal.c

[PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-28 Thread Kai-Heng Feng
ling method. So add an indication to let thermal core know it should leave thermal device to userspace to handle. Signed-off-by: Kai-Heng Feng --- drivers/thermal/thermal_core.c | 3 +++ include/linux/thermal.h| 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/thermal/thermal_core

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirkforLenovo A630Z TIO built-in usb-audio card

2020-11-24 Thread Kai-Heng Feng
gt; dlaz richard.o.dodd > kerneldev linux-usb > linux-kernel > Sent: 2020-11-20 02:27 > Subject: Re:Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND > quirkforLenovo A630Z TIO built-in usb-audio card > > > > > On Nov 19, 2020, at 22:23, Greg Kroah-Ha

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-24 Thread Kai-Heng Feng
Hi Yu, > On Nov 24, 2020, at 23:32, Chen Yu wrote: > > The NIC is put in runtime suspend status when there is no wire connected. > As a result, it is safe to keep this NIC in runtime suspended during s2ram > because the system does not rely on the NIC plug event nor WOL to wake up > the system.

Re: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

2020-11-24 Thread Kai-Heng Feng
> On Nov 24, 2020, at 22:00, Rafael J. Wysocki wrote: > > On Tue, Nov 24, 2020 at 8:36 AM Kai-Heng Feng > wrote: >> >> Dell Precision 5550 fails to detect Thunderbolt device hotplug events, >> once the Thunderbolt device and its root port are runtime-suspen

Re: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

2020-11-24 Thread Kai-Heng Feng
> On Nov 25, 2020, at 01:48, Rafael J. Wysocki wrote: > > On Tuesday, November 24, 2020 6:31:56 PM CET Kai-Heng Feng wrote: >> >>> On Nov 24, 2020, at 22:00, Rafael J. Wysocki wrote: >>> >>> On Tue, Nov 24, 2020 at 8:36 AM Kai-Heng Feng >&g

Re: [PATCH] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram

2020-11-25 Thread Kai-Heng Feng
> On Nov 25, 2020, at 18:36, Chen Yu wrote: > > Hi Kai-Heng, > On Wed, Nov 25, 2020 at 01:17:28AM +0800, Kai-Heng Feng wrote: >> Hi Yu, >> >>> On Nov 24, 2020, at 23:32, Chen Yu wrote: >>> >>> The NIC is put in runtime suspend stat

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

2019-07-30 Thread Kai-Heng Feng
at 01:14, wrote: -Original Message- From: Keith Busch Sent: Tuesday, July 30, 2019 9:42 AM To: Rafael J. Wysocki Cc: Busch, Keith; Limonciello, Mario; Kai-Heng Feng; Christoph Hellwig; Sagi Grimberg; linux-nvme; Linux PM; Linux Kernel Mailing List; Rajat Jain Subject: Re

[PATCH 1/2] serial: 8250_pci: Add support for Sunix serial boards

2019-08-08 Thread Kai-Heng Feng
Add support to Sunix serial boards with up to 16 ports. Sunix board need its own setup callback instead of using Timedia's, to properly support more than 4 ports. Cc: Morris Ku Cc: Debbie Liu Signed-off-by: Kai-Heng Feng --- drivers/tty/serial/8250/8250_pci.c | 93

[PATCH 2/2] parport: parport_serial: Add support for Sunix Multi I/O boards

2019-08-08 Thread Kai-Heng Feng
Sunix Multi I/O boards are different to Timedia's. This patch adds proper support for Sunix MIO boards with 1 parallel and up to 4 serial ports. Cc: Morris Ku Cc: Debbie Liu Signed-off-by: Kai-Heng Feng --- drivers/parport/parport_serial.c | 44 +++- 1 file

[PATCH] platform/x86: hp_accel: Add support for HP ZBook 17 G5

2019-07-09 Thread Kai-Heng Feng
HP ZBook 17 G5 needs a non-standard mapping, x_inverted. Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/hp_accel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c index f61b8a176e20..cfc0e36a7a5e 100644 --- a/drivers

[PATCH] serial: 8250_pci: Merge 8250_moxa to 8250_pci

2019-08-16 Thread Kai-Heng Feng
Moxa serial boards only need a special setup function, we can use generic 8250 framework for other parts. So let's merge 8250_moxa to 8250_pci. Signed-off-by: Kai-Heng Feng --- drivers/tty/serial/8250/8250_moxa.c | 155 drivers/tty/serial/8250/8250_pci.c | 113

Re: [PATCH] PCI: PM: Skip devices in D0 for suspend-to-idle

2019-06-13 Thread Kai-Heng Feng
figuration of devices left in D0 (whatever the reason) during suspend-to-idle need not be changed and attempting to put them into D0 again by force may confuse some firmware, so explicitly avoid doing that. Fixes: d491f2b75237 ("PCI: PM: Avoid possible suspend-to-idle issue") Reported-by: K

[PATCH] HID: multitouch: Add pointstick support for ALPS Touchpad

2019-06-14 Thread Kai-Heng Feng
There's a new ALPS touchpad/pointstick combo device that requires MT_CLS_WIN_8_DUAL to make its pointsitck work as a mouse. The device can be found on HP ZBook 17 G5. Signed-off-by: Kai-Heng Feng --- drivers/hid/hid-ids.h| 1 + drivers/hid/hid-multitouch.c | 4 2 files changed, 5

Re: [PATCH v3] Input: elantech: Enable SMBus on new (2018+) systems

2019-07-23 Thread Kai-Heng Feng
Hi Dmitry, at 16:17, Dmitry Torokhov wrote: Hi Kai-Heng, On Mon, Jul 22, 2019 at 03:40:55PM +0800, Kai-Heng Feng wrote: There are some new HP laptops with Elantech touchpad don't support multitouch. Currently we use ETP_NEW_IC_SMBUS_HOST_NOTIFY() to check if SMBus is supported

Re: linux-next: build warning after merge of the input-current tree

2019-07-23 Thread Kai-Heng Feng
Hi Stephen, at 07:54, Stephen Rothwell wrote: Hi all, After merging the input-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify': drivers/input/mouse/elantech.c:1843:6: warning: this

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai Heng Feng
Hi Christoph, > On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: >> New Intel laptops with VMD cannot reach deeper power saving state, >> renders very short battery time. > > So what about j

[PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-25 Thread Kai-Heng Feng
iginal fix. Fixes: 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") BugLink: https://bugs.launchpad.net/bugs/1791312 BugLink: https://bugs.launchpad.net/bugs/1861554 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon_display.c | 2 +- 1 file changed, 1 inse

[PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-25 Thread Kai-Heng Feng
LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai-Heng Feng
> On Aug 25, 2020, at 14:56, Christoph Hellwig wrote: > > On Tue, Aug 25, 2020 at 02:39:55PM +0800, Kai Heng Feng wrote: >> Hi Christoph, >> >>> On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: >>> >>> On Fri, Aug 21, 2020 at 08:32

Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio

2020-08-19 Thread Kai-Heng Feng
> On Aug 20, 2020, at 01:18, Takashi Iwai wrote: > > [ Adding a few more relevant people to Cc. ] > > On Wed, 19 Aug 2020 13:57:57 +0200, > penghao wrote: >> >> TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens >> enter sleep mode, USB-audio will disconnect from USB bus port, >>

[PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-21 Thread Kai-Heng Feng
is a root complex integrated endpoint that doesn't have ASPM capability, so we can't propagate the ASPM settings to devices under it. Hence, simply apply ASPM_STATE_ALL to the links under VMD domain, unsupported states will be cleared out anyway. Signed-off-by: Kai-Heng Feng --- drivers/pci/pcie

Re: [Regression] "iommu/amd: Relax locking in dma_ops path" makes tg3 ethernet transmit queue timeout

2020-08-21 Thread Kai-Heng Feng
Hi Joerg, > On Aug 21, 2020, at 21:43, Joerg Roedel wrote: > > Hi Kai, > > On Mon, Jun 29, 2020 at 08:33:22PM +0800, Kai-Heng Feng wrote: >> I am still seeing the issue on v5.8-rc3. The issue goes away as soon >> as "iommu=off" is added. > > Can

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-09-01 Thread Kai-Heng Feng
> On Sep 1, 2020, at 03:48, Ville Syrjälä wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä >>> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15P

[PATCH] ALSA: hda/realtek: Fix pin default on Intel NUC 8 Rugged

2020-08-07 Thread Kai-Heng Feng
config. [1] https://www.intel.com/content/dam/support/us/en/documents/mini-pcs/NUC8CCH_TechProdSpec.pdf BugLink: https://bugs.launchpad.net/bugs/1875199 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda

[PATCH] iwlwifi: mvm: Increase session protection duration for association

2020-09-24 Thread Kai-Heng Feng
because EAPOL hasn't finished. Increase the session protection duration to 1200TU can eliminate the problem. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209237 Signed-off-by: Kai-Heng Feng --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-24 Thread Kai-Heng Feng
. So we don't know beforehand. > > I would prefer this doesn't get accepted in its current state. Of course. I think we need to find the root cause for your case before applying this one. Kai-Heng > > Abhishek > > On Wed, Sep 23, 2020 at 10:56 AM Kai-Heng Feng > wrote:

Re: [PATCH] e1000e: Power cycle phy on PM resume

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 23, 2020, at 23:37, Andrew Lunn wrote: > > On Wed, Sep 23, 2020 at 10:44:10PM +0800, Kai-Heng Feng wrote: >> Hi Andrew, >> >>> On Sep 23, 2020, at 20:17, Andrew Lunn wrote: >>> >>> On Wed, Sep 23, 2020 at 03:47:51P

[PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
As Andrew Lunn pointed out, MDIO has nothing to do with phy, and indeed increase polling iteration can resolve the issue. While at it, also move the delay to the end of loop, to potentially save 50 us. Signed-off-by: Kai-Heng Feng --- v2: - Increase polling iteration instead of powering down

Re: [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
Hi Andrew, > On Sep 24, 2020, at 23:53, Andrew Lunn wrote: > > On Thu, Sep 24, 2020 at 11:09:58PM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1

[PATCH v3] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
As Andrew Lunn pointed out, MDIO has nothing to do with phy, and indeed increase polling iteration can resolve the issue. The root cause is quite likely Intel ME, since it's a blackbox to the kernel so the only approach we can take is to be patient and wait longer. Signed-off-by: Kai-Heng Feng

Re: [PATCH v3] e1000e: Increase iteration on polling MDIC ready bit

2020-09-24 Thread Kai-Heng Feng
> On Sep 25, 2020, at 03:57, Andrew Lunn wrote: > > On Fri, Sep 25, 2020 at 12:45:42AM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1000e :

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Abhishek, > On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi > wrote: > > + Alex Lu (who contributed the original change) > > Hi Kai-Heng, > > > On Thu, Sep 24, 2020 at 12:10 AM Kai-Heng Feng > wrote: >> >> [+Cc linux-usb] >> >> Hi

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
> On Sep 25, 2020, at 14:40, 陆朱伟 wrote: > > Hi Abhishek, > >> On September 25, 2020 at 11:34, Abhishek Pandit-Subedi wrote: >> >> + Alex Lu (who contributed the original change) >> >> Hi Kai-Heng, >> >> >> On Thu, Sep 24, 2020

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 15:04, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On September 25, 2020 14:04, Kai-Heng Feng wrote: >> >> Hi Abhishek, >>> On Sep 25, 2020, at 11:33, Abhishek Pandit-Subedi >> wrote: >>> >>> + Ale

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 15:42, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On 25 September 2020 at 15:14, Kai-Heng Feng wrote: >> >> Hi Alex, [snipped] >> Apparently for my case, RTL8821CE, firmware was kept without setting >> remote wakeup. >

[PATCH] memstick: Skip allocating card when removing host

2020-09-25 Thread Kai-Heng Feng
is called by memstick_remove_host(). Soe let's skip allocating card to prevent this issue. Fixes: 6827ca573c03 ("memstick: rtsx_usb_ms: Support runtime power management") Signed-off-by: Kai-Heng Feng --- drivers/memstick/core/memstick.c | 4 include/linux/memstick.h | 1 + 2 files c

Re: [PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-25 Thread Kai-Heng Feng
Hi Alex, > On Sep 25, 2020, at 16:23, 陆朱伟 wrote: > > Hi Kai-Heng, > >> On September 25, 2020 at 15:56, Kai-Heng Feng wrote: >> >> Hi Alex, >> >>> On Sep 25, 2020, at 15:42, 陆朱伟 wrote: >>> >>> Hi Kai-Heng, >>> >

Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"

2020-09-22 Thread Kai-Heng Feng
> On Sep 21, 2020, at 16:40, Takashi Iwai wrote: > > On Tue, 15 Sep 2020 12:39:23 +0200, > Kai-Heng Feng wrote: >> >> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e. >> >> According to Realtek, volume FU works for line-in. >> >>

[PATCH] e1000e: Power cycle phy on PM resume

2020-09-23 Thread Kai-Heng Feng
Since we don't know what platform firmware may do to the phy, so let's power cycle the phy upon system resume to resolve the issue. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-23 Thread Kai-Heng Feng
t; On Thu, 2020-09-10 at 12:38 -0500, Bjorn Helgaas wrote: >>>>> On Thu, Sep 10, 2020 at 04:33:39PM +, Derrick, Jonathan wrote: >>>>>> On Wed, 2020-09-09 at 20:55 -0500, Bjorn Helgaas wrote: >>>>>>> On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-H

Re: [PATCH] e1000e: Power cycle phy on PM resume

2020-09-23 Thread Kai-Heng Feng
Hi Andrew, > On Sep 23, 2020, at 20:17, Andrew Lunn wrote: > > On Wed, Sep 23, 2020 at 03:47:51PM +0800, Kai-Heng Feng wrote: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.844232] e1

Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume

2020-09-23 Thread Kai-Heng Feng
Hi Paul, > On Sep 23, 2020, at 21:28, Paul Menzel wrote: > > Dear Kai-Heng, > > > Am 23.09.20 um 09:47 schrieb Kai-Heng Feng: >> We are seeing the following error after S3 resume: >> [ 704.746874] e1000e :00:1f.6 eno1: Setting page 0x6020 >> [ 704.8

[PATCH] Bluetooth: btusb: Avoid unnecessary reset upon system resume

2020-09-23 Thread Kai-Heng Feng
-by: Kai-Heng Feng --- drivers/bluetooth/btusb.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 8d2608ddfd08..de86ef4388f9 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -4255,17 +4255,15

[PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-09-28 Thread Kai-Heng Feng
with software. Signed-off-by: Kai-Heng Feng --- v4: - States that this patch just papers over the symptom. v3: - Moving delay to end of loop doesn't save anytime, move it back. - Point out this is quitely likely caused by Intel ME. v2: - Increase polling iteration instead of powering down

Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-09-28 Thread Kai-Heng Feng
> On Jun 8, 2020, at 11:56, Kai-Heng Feng wrote: > > > >> On May 5, 2020, at 01:16, Kai-Heng Feng wrote: >> >> Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was >> runtime suspended previously: >> [ 370.080359] pci :02:

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-09-28 Thread Kai-Heng Feng
Hi Jani, > On Jul 10, 2020, at 23:48, Kai-Heng Feng wrote: > > > >> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote: >> >> >>> On Jun 10, 2020, at 15:55, Kai-Heng Feng >>> wrote: >>> >>> On HP 800 G4 DM, if HDMI cable isn'

[Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Commit 7f3d176f5f7e "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes a null pointer dereference on all laptops I have: [0.00] microcode: microcode updated early to revision 0xd6, date = 2020-04-27 [0.00] Linux version 5.8.0-rc6+ (gcc (Ubuntu

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Hi Jarkko, > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > wrote: > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: >> Commit 7f3d176f5f7e "tpm: Require that all digests are present in >> TCG_PCR_EVENT2 structures" causes a null pointer de

[PATCH v2] rtw88: pci: Power cycle device during shutdown

2020-09-28 Thread Kai-Heng Feng
Signed-off-by: Kai-Heng Feng --- v2: - Add more detail in commit log. drivers/net/wireless/realtek/rtw88/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index 3413973bc475..7f1f5073b9f4 100644 --- a/d

Re: [PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-09-29 Thread Kai-Heng Feng
> On Sep 29, 2020, at 05:42, Mathias Nyman > wrote: > > On 28.9.2020 12.10, Kai-Heng Feng wrote: >> >> >>> On Jun 8, 2020, at 11:56, Kai-Heng Feng wrote: >>> >>> >>> >>>> On May 5, 2020, at 01:16, Kai-Heng Feng

[PATCH] nvme-pci: Disable Write Zeroes on Sandisk Skyhawk

2020-10-13 Thread Kai-Heng Feng
0 So also disable Write Zeroes command on Sandisk Skyhawk. BugLink: https://bugs.launchpad.net/bugs/1899503 Signed-off-by: Kai-Heng Feng --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 8984796db0c8..d310d7317

Re: [PATCH v2] Bluetooth: btrtl: Ask 8821C to drop old firmware

2020-11-02 Thread Kai-Heng Feng
> On Oct 26, 2020, at 16:28, Kai-Heng Feng wrote: > > Some platforms keep USB power even when they are powered off and in S5, > this makes Realtek 8821C keep its firmware even after a cold boot, and > make 8821C never load new firmware. > > So use vendor specific HCI

[PATCH] r8169: Add support for another RTL8168FP

2021-02-01 Thread Kai-Heng Feng
According to the vendor driver, the new chip with XID 0x54b is essentially the same as the one with XID 0x54a, but it doesn't need the firmware. So add support accordingly. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/realtek/r8169.h | 1 + drivers/net/ethernet/realtek

Re: [PATCH] rtw88: 8821c: Add RFE 2 support

2021-02-01 Thread Kai-Heng Feng
On Tue, Feb 2, 2021 at 3:02 PM Larry Finger wrote: > > On 2/2/21 12:29 AM, Kalle Valo wrote: > > Kai-Heng Feng writes: > > > >> On Wed, Aug 5, 2020 at 7:24 PM Kai-Heng Feng > >> wrote: > >>> > >>> Hi Tony, > >>> > >&g

[PATCH v2] r8169: Add support for another RTL8168FP

2021-02-01 Thread Kai-Heng Feng
According to the vendor driver, the new chip with XID 0x54b is essentially the same as the one with XID 0x54a, but it doesn't need the firmware. So add support accordingly. Signed-off-by: Kai-Heng Feng --- v2: - Add phy support. - Rebase on net-next. drivers/net/ethernet/realtek/r8169.h

Re: [PATCH] r8169: Add support for another RTL8168FP

2021-02-01 Thread Kai-Heng Feng
On Tue, Feb 2, 2021 at 2:54 AM Heiner Kallweit wrote: > > On 01.02.2021 17:47, Kai-Heng Feng wrote: > > According to the vendor driver, the new chip with XID 0x54b is > > essentially the same as the one with XID 0x54a, but it doesn't need the > > firmware. > >

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2021-02-03 Thread Kai-Heng Feng
On Thu, Feb 4, 2021 at 12:09 PM Furquan Shaikh wrote: > > On Wed, Feb 3, 2021 at 6:37 PM Kai-Heng Feng > wrote: > > > > Hi Furquan, > > > > On Wed, Jan 13, 2021 at 10:31 PM Dmitry Osipenko wrote: > > [snipped] > > > Thank you all for addres

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2021-02-03 Thread Kai-Heng Feng
Hi Furquan, On Wed, Jan 13, 2021 at 10:31 PM Dmitry Osipenko wrote: [snipped] > Thank you all for addressing this problem! Are you still working on the alternate solution? This patch can address S5 power consumption issue for some laptops:

[PATCH 2/2] PCI/DPC: Disable DPC interrupt during suspend

2021-01-27 Thread Kai-Heng Feng
em suspend and resume, respectively. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209149 Fixes: 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in hint") Signed-off-by: Kai-Heng Feng --- drivers/pci/pcie/dpc.c | 49 -- 1 file changed,

[PATCH 1/2] PCI/AER: Disable AER interrupt during suspend

2021-01-27 Thread Kai-Heng Feng
and enable it on system suspend and resume, respectively. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209149 Fixes: 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in hint") Signed-off-by: Kai-Heng Feng --- drivers/pci/pcie/aer.c | 18 ++ 1 file ch

<    1   2   3   4   5   6   7   8   9   10   >