Re: [PATCH 1/2] PCI/AER: Disable AER interrupt during suspend

On Thu, Jan 28, 2021 at 4:51 AM Bjorn Helgaas wrote: > > On Thu, Jan 28, 2021 at 01:31:00AM +0800, Kai-Heng Feng wrote: > > Commit 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in > > hint") enables ACS, and some platforms lose its NVMe af

Re: [PATCH] PM: sleep: core: Resume suspended device if direct-complete is disabled

On Thu, Jan 28, 2021 at 4:09 PM Takashi Iwai wrote: > > On Thu, 31 Dec 2020 07:03:19 +0100, > Kai-Heng Feng wrote: > > > > HDA controller can't be runtime-suspended after commit 215a22ed31a1 > > ("ALSA: hda: Refactor codjc PM to use direct-complete optimiza

[PATCH v2 2/3] Bluetooth: btusb: Load firmware exclusively for Intel BT

To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when IWLWIFI is enabled. BugLink: https://bugs.launchpad.net/bugs/1832988 Signed-off-by: Kai-Heng Feng --- v2: - Add bug report link. - Rebase on latest wireless-next. drivers/bluetooth

[PATCH v2 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when BT_INTEL is enabled. BugLink: https://bugs.launchpad.net/bugs/1832988 Signed-off-by: Kai-Heng Feng --- v2: - Add bug report link. - Rebase on latest wireless-next. .../net/wireless

[PATCH v2 1/3] Bluetooth: btintel: Add firmware lock function

and iwlwifi load firmwares exclusively can avoid the issue, so introduce a lock to use in btusb and iwlwifi. This issue still occurs with latest WiFi and Bluetooth firmwares. BugLink: https://bugs.launchpad.net/bugs/1832988 Signed-off-by: Kai-Heng Feng --- v2: - Add bug report link. - Rebase

Re: [PATCH v2 1/3] Bluetooth: btintel: Add firmware lock function

: hci0: Failed to send firmware data (-38) Let btusb and iwlwifi load firmwares exclusively can avoid the issue, so introduce a lock to use in btusb and iwlwifi. This issue still occurs with latest WiFi and Bluetooth firmwares. BugLink: https://bugs.launchpad.net/bugs/1832988 Signed-off-by: Kai-Heng

Re: [PATCH v2 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound

Hi Bjorn, On Thu, Sep 5, 2019 at 11:35 PM Bjorn Helgaas wrote: > > On Thu, Aug 29, 2019 at 02:01:28AM +0800, Kai-Heng Feng wrote: > > It's a common practice to let dGPU unbound and use PCI platform power > > management to disable its power through _OFF method of power r

[PATCH v3 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a driver

the runtime suspend requirement for dGPU's HDA function, to disable the power source to save lots of power. BugLink: https://bugs.launchpad.net/bugs/1840835 Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") Signed-off-by: Kai-Heng Feng --- v3: - Make changelog more clear. v2: - Chang

Re: [PATCH] libata: Use per port sync for detach

Hi John, > On May 18, 2020, at 23:21, John Garry wrote: > > On 18/05/2020 10:06, John Garry wrote: >> On 15/05/2020 18:48, Kai-Heng Feng wrote: >>>> 841] ret_from_fork+0x10/0x1c >>>> [ 28.393400] ---[ end trace 9972785c7052048f ]--- >>>

[PATCH 2/2] xhci: Poll for U0 after disabling USB2 LPM

sed as 400us, which is still not enough based on my testing result. So let's use the maximum permitted latency, 1, to poll for U0 status to solve the issue. Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci.

[PATCH 1/2] xhci: Return if xHCI doesn't support LPM

Just return if xHCI is quirked to disable LPM. We can save some time from reading registers and doing spinlocks. Signed-off-by: Kai-Heng Feng --- drivers/usb/host/xhci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c

Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL

> On May 27, 2020, at 20:15, Benjamin Tissoires > wrote: > > On Wed, May 27, 2020 at 11:24 AM Benjamin Tissoires > wrote: >> >> On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng >> wrote: >>> >>> >>> >>>> On May 26, 20

Re: [PATCH] HID: multitouch: enable multi-input as a quirk for some devices

vents are already mapped, and simply ignores them. > > To be able to report events from the tracktick, add a new quirked > class for it, and manually add the 2 devices we know about. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=207235 > Cc: sta...@vger.kernel.org > Sig

Re: [PATCH] HID: multitouch: Remove MT_CLS_WIN_8_DUAL

> On May 26, 2020, at 16:43, Benjamin Tissoires > wrote: > > On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote: >> >> On Tue, 14 Apr 2020, Kai-Heng Feng wrote: >> >>> After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes&q

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

> On 29 Jan 2018, at 8:56 PM, Andy Shevchenko wrote: > > On Mon, Jan 29, 2018 at 8:10 AM, Kai-Heng Feng > wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. >> >> The touchpad relies on its _INI method to up

[PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

can be correctly set up, and _INI can get run. The ACPI table in this machine is designed to get parsed this way. Also, change the quirk table to a more generic name. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515 Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v2: Andy's

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

> On 31 Jan 2018, at 2:17 AM, Andy Shevchenko wrote: > > On Tue, Jan 30, 2018 at 8:07 AM, Kai-Heng Feng > wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. >> >> The touchpad relies on its _INI method to up

Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

> On 31 Jan 2018, at 2:37 AM, Schmauss, Erik wrote: > > Hi, >> -Original Message- >> From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- >> ow...@vger.kernel.org] On Behalf Of Andy Shevchenko >> Sent: Tuesday, January 30, 2018 10:18 AM >

[PATCH v3] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

can be correctly set up, and _INI can get run. The ACPI table in this machine is designed to get parsed this way. Also, change the quirk table to a more generic name. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515 Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- v3: Put

[PATCH] Input: elan_i2c - add ELAN0611 to the ACPI table

ELAN0611 touchpad uses elan_i2c as its driver. It can be found on Lenovo ideapad 320-15IKB. So add it to ACPI table to enable the touchpad. BugLink: https://bugs.launchpad.net/bugs/1723736 Signed-off-by: Kai-Heng Feng --- drivers/input/mouse/elan_i2c_core.c | 1 + 1 file changed, 1 insertion

[PATCH 1/2] r8169: reinstate ALDPS for power saving

Hayes Wang Cc: Jörg Otte Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/realtek/r8169.c | 58 +--- 1 file changed, 48 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index e0

[PATCH 2/2] r8169: reinstate internal ASPM and clock request settings

: Francois Romieu Cc: Hayes Wang Cc: Jörg Otte Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/realtek/r8169.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 54

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

> On 15 Nov 2017, at 6:53 PM, David Miller wrote: > > From: Kai-Heng Feng > Date: Wed, 15 Nov 2017 04:00:18 -0500 > >> Commit ("r8169: enable ALDPS for power saving") caused a regression on >> RTL8168evl/8111evl [1], so it got reverted. >> >

[PATCH] ath9k: turn on btcoex_enable as default

Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink: https://bugs.launchpad.net/bugs/1746164 Signed-off-by: Kai-Heng Feng --- drivers/net/wireless/ath/ath9k/init.c | 10

Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

A user with i386 instead of AMD64 machine reports [1] that commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly”) causes a regression. BUG_ON(PageHighMem(pg)) in drivers/media/common/saa7146/saa7146_core.c always gets triggered after that commit. Commit 704b862f9efd ("mm/vmalloc.c:

[PATCH] drm/amdgpu: add new device to use atpx quirk

The affected system (0x0813) is pretty similar to another one (0x0812), it also needs to use ATPX power control. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c

Re: [PATCH] ath9k: turn on btcoex_enable as default

Hi Felix, On Feb 8, 2018, at 7:02 PM, Felix Fietkau wrote: On 2018-02-08 06:28, Kai-Heng Feng wrote: Without btcoex_enable, WiFi activies make both WiFi and Bluetooth unstable if there's a bluetooth connection. Enable this option when bt_ant_diversity is disabled. BugLink: https

tg3 crashes under high load, when using 100Mbits

Hi Broadcom folks, We are now enabling a new platform with tg3 nic, unfortunately we observed the bug [1] that dated back to 2015. I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS to 2048”) but it does’t work. Do you have any idea how to solve the issue? [1]

Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

Hi Matthew, On Feb 9, 2018, at 12:08 PM, Matthew Wilcox wrote: Alternatively, try this. It passes in GFP_DMA32 from vmalloc_32, regardless of whether ZONE_DMA32 exists or not. If ZONE_DMA32 doesn't exist, then we clear it in __vmalloc_area_node(), after using it to determine that we

Re: [PATCH] ath9k: turn on btcoex_enable as default

> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: > Sure, but we have to make sure that we don't create regressions on > existing systems. For example, did you test this with any system which > don't support btcoex? (just asking, haven't tested this myself) No not really, but I will definitely

Re: [PATCH] ath9k: turn on btcoex_enable as default

> On 10 Feb 2018, at 10:05 PM, Felix Fietkau wrote: > > On 2018-02-10 14:56, Kai Heng Feng wrote: >> >>> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: >>> Sure, but we have to make sure that we don't create regressions on >>> existing systems. For

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

> On 18 Jan 2018, at 11:04 AM, Hayes Wang wrote: > > [...] >>> r8153 on Dell TB15/16 dock corrupts rx packets. >>> >>> This change is suggested by Realtek. They guess that the XHCI >>> controller doesn't have enough buffer, and their guesswork is correct, >>> once the RX aggregation gets

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

> On 18 Jan 2018, at 10:50 PM, David Miller wrote: > > From: Hayes Wang > Date: Thu, 18 Jan 2018 03:04:08 + > >> [...] r8153 on Dell TB15/16 dock corrupts rx packets. This change is suggested by Realtek. They guess that the XHCI controller doesn't have enough buffer,

[PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

Limonciello Signed-off-by: Kai-Heng Feng --- v2: - Disable RX aggregation instead of disable RX checksum - Use bcdDevice and iSerialNumber to uniquely identify Dell TB16 drivers/net/usb/r8152.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net

[PATCH] ACPI / battery: Add quirk for Asus UX360UA and UX410UAK

Same issue as other Asus laptops, ACPI incorrectly reports discharging when battery is full and AC is plugged. Use the same battery quirk can workaround the issue. BugLink: https://bugs.launchpad.net/bugs/1661876 BugLink: https://bugs.launchpad.net/bugs/1745032 Signed-off-by: Kai-Heng Feng

[PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

can be correctly set up, and _INI can get run. The ACPI table in this machine is designed to get parsed this way. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515 Cc: Mario Limonciello Signed-off-by: Kai-Heng Feng --- drivers/acpi/bus.c | 41 + 1

[PATCH] Input: synaptics - enable RMI on ThinkPad T580

Like the ThinkPad T560 case, now we can use RMI on T580 to have a more responsive touchpad. Signed-off-by: Kai-Heng Feng --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b8ec301025b7

[PATCH] e1000e: Make speed detection on hotplugging cable more reliable

interrupt. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index e4baa13b3cda..c83bf5349

Re: [Intel-wired-lan] [PATCH] e1000e: Make speed detection on hotplugging cable more reliable

at 4:52 PM, Paul Menzel wrote: Dear Kai-Heng, Thank you for the patch. On 7/15/19 10:43 AM, Kai-Heng Feng wrote: After hotplugging an 1Gbps ethernet cable with 1Gbps link partner, the MII_BMSR may reports 10Mbps, renders the network rather slow. s/may reports/may report/ s/renders

Re: [Intel-wired-lan] [PATCH] e1000e: Make speed detection on hotplugging cable more reliable

at 5:06 PM, Paul Menzel wrote: Dear Kai Heng, (with or without hyphen?) On 7/15/19 11:00 AM, Kai Heng Feng wrote: at 4:52 PM, Paul Menzel wrote: On 7/15/19 10:43 AM, Kai-Heng Feng wrote: After hotplugging an 1Gbps ethernet cable with 1Gbps link partner, the MII_BMSR may reports 10Mbps

[PATCH v2] e1000e: Make speed detection on hotplugging cable more reliable

interrupt. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/e1000e/netdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index e4baa13b3cda..c83bf5349d53 100644 ---

Re: [PATCH] HID: Increase maximum report size allowed by hid_field_extract()

> On May 21, 2019, at 9:58 PM, Benjamin Tissoires > wrote: > > On Thu, May 9, 2019 at 9:30 PM Jiri Kosina wrote: >> >> On Fri, 26 Apr 2019, Kai-Heng Feng wrote: >> >>>> Ronald (Cc-ed) raised quite a good point: >>>> what's the

[PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

Signed-off-by: Kai-Heng Feng --- drivers/pci/pci-driver.c | 5 + drivers/pci/pci.c| 2 +- include/linux/pci.h | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index cae630fe6387..15a6310c5d7b 100644

Re: [PATCH v2 1/2] Bluetooth: Disable LE Advertising in hci_suspend_dev()

Hi Marcel, at 5:25 PM, Kai-Heng Feng wrote: LE Advertising may wake up system during system-wide sleep, disable it to prevent this issue from happening. Do the reverse in hci_resume_dev(). Do you have any suggestion for this patch? Kai-Heng Signed-off-by: Kai-Heng Feng --- v2

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

at 6:23 AM, Bjorn Helgaas wrote: [+cc Mathias, linux-usb] On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: There's an xHC device that doesn't wake when a USB device gets plugged to its USB port. The driver's own runtime suspend callback was called, PME signaling was enabled

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

> On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote: >> at 6:23 AM, Bjorn Helgaas wrote: >>> On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: >>>> There's an xHC device that

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

> On May 23, 2019, at 2:53 AM, Lukas Wunner wrote: > > On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: >> According to Kai, PME signalling doesn't work in D0 -- or at least, it >> is _documented_ not to work in D0 -- even though it is enabled and the >> device claims to support

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

at 04:52, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: On Wed, 22 May 2019, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 11:42:14AM +0800

[PATCH v2] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

require wakeup capability, carry out driver's runtime suspend as usual, which may have logic to save its power internally. [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/device-working-state-d0 Signed-off-by: Kai-Heng Feng --- v2: - Changes wording - Keep old behaviour

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

Hi Rafael, at 17:51, Rafael J. Wysocki wrote: Hi Keith, Unfortunately, commit d916b1be94b6dc8d293abed2451f3062f6af7551 Author: Keith Busch Date: Thu May 23 09:27:35 2019 -0600 nvme-pci: use host managed power state for suspend doesn't universally improve things. In fact, in some

Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default

at 15:55, Greg KH wrote: On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote: The procfs provides many useful information for debugging, but it may be too much for normal usage, routines like proc_get_sec_info() reports various security related information. So disable

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

at 01:03, Rafael J. Wysocki wrote: On Thu, Jul 25, 2019 at 6:24 PM wrote: +Rajat -Original Message- From: Kai-Heng Feng Sent: Thursday, July 25, 2019 9:03 AM To: Rafael J. Wysocki Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux- n...@lists.infradead.org; Limonciello

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

at 04:02, Rafael J. Wysocki wrote: On Thursday, July 25, 2019 9:52:59 PM CEST Keith Busch wrote: On Thu, Jul 25, 2019 at 09:48:57PM +0200, Rafael J. Wysocki wrote: NVME Identify Controller: vid : 0x1c5c ssvid : 0x1c5c sn : MS92N171312902J0N mn : PC401 NVMe SK hynix 256GB fr

Re: [PATCH v2] USB: Disable USB2 LPM at shutdown

at 22:17, Alan Stern wrote: On Thu, 6 Jun 2019, Kai-Heng Feng wrote: at 15:55, Kai-Heng Feng wrote: at 18:22, Kai-Heng Feng wrote: at 00:01, Kai-Heng Feng wrote: On Jan 30, 2019, at 16:21, Greg KH wrote: On Thu, Jan 24, 2019 at 02:16:43PM +0800, Kai-Heng Feng wrote: The QCA Rome

Re: [PATCH] PCI: PM: Avoid possible suspend-to-idle issue

Hi Rafael, at 19:02, Rafael J. Wysocki wrote: On Friday, May 17, 2019 11:08:50 AM CEST Rafael J. Wysocki wrote: From: Rafael J. Wysocki If a PCI driver leaves the device handled by it in D0 and calls pci_save_state() on the device in its ->suspend() or ->suspend_late() callback, it can

[Regression] Commit "ACPI: PM: Allow transitions to D0 to occur in special cases"

Hi, After commit "ACPI: PM: Allow transitions to D0 to occur in special cases”, Thunderbolt on XPS 9380 spews the following when it runtime resumes: [ 36.136554] pci_raw_set_power_state: 25 callbacks suppressed [ 36.136558] pcieport :03:00.0: Refused to change power state, currently

Re: [PATCH] ACPI: PM: Fix regression in acpi_device_set_power()

aved value in a subsequent check. Fixes: f850a48a0799 ("ACPI: PM: Allow transitions to D0 to occur in special cases") Reported-by: Kai-Heng Feng Reported-by: Mario Limonciello Signed-off-by: Rafael J. Wysocki Tested-by: Kai-Heng Feng --- drivers/acpi/device_pm.c |4 +++- 1 file c

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

at 06:33, Rafael J. Wysocki wrote: On Thu, Aug 1, 2019 at 12:22 AM Keith Busch wrote: On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote: A couple of remarks if you will. First, we don't know which case is the majority at this point. For now, there is one example of each,

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

at 06:26, Rafael J. Wysocki wrote: On Thu, Aug 1, 2019 at 9:05 PM wrote: -Original Message- From: Rafael J. Wysocki Sent: Thursday, August 1, 2019 12:30 PM To: Kai-Heng Feng; Keith Busch; Limonciello, Mario Cc: Keith Busch; Christoph Hellwig; Sagi Grimberg; linux-nvme; Linux PM

Re: [Intel-wired-lan] Opportunistic S0ix blocked by e1000e when ethernet is in use

at 19:56, Neftin, Sasha wrote: On 6/24/2019 10:03, Kai-Heng Feng wrote: Hi Jeffrey, at 19:08, Kai-Heng Feng wrote: Hi Jeffrey, There are several platforms that uses e1000e can’t enter Opportunistic S0ix (PC10) when the ethernet has a link partner. This behavior also exits in out

Re: [Intel-wired-lan] Opportunistic S0ix blocked by e1000e when ethernet is in use

at 6:25 PM, Neftin, Sasha wrote: On 6/24/2019 18:06, Kai-Heng Feng wrote: at 19:56, Neftin, Sasha wrote: [Snipped] Current HW have a limitation. Please, try follow workaround on your platform: echo 3 > /sys/kernel/debug/pmc_core/ltr_ignore Yes, this does the trick. On 4.15 based ker

Re: RX CRC errors on I219-V (6) 8086:15be

Hi Sasha at 5:09 PM, Kai-Heng Feng wrote: Hi Jeffrey, We’ve encountered another issue, which causes multiple CRC errors and renders ethernet completely useless, here’s the network stats: I also tried ignore_ltr for this issue, seems like it alleviates the symptom a bit for a while

[PATCH] staging: rtl8723bs: Disable procfs debugging by default

The procfs provides many useful information for debugging, but it may be too much for normal usage, routines like proc_get_sec_info() reports various security related information. So disable it by defaultl. Signed-off-by: Kai-Heng Feng --- drivers/staging/rtl8723bs/include/autoconf.h | 4

[PATCH] ALSA: line6: Fix wrong altsetting for LINE6_PODHD500_1

Move altsetting to properties") Signed-off-by: Kai-Heng Feng --- sound/usb/line6/podhd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c index f0662bd4e50f..27bf61c177c0 100644 --- a/sound/usb/line6/podhd.c +++ b/sound/usb/lin

[PATCH v3] Input: elantech: Enable SMBus on new (2018+) systems

old ICs, only enables SMBus on systems manufactured after 2018, alongsides aforementioned checks. Lastly, consolidats all check into elantech_use_host_notify() and use it to determine whether to use PS/2 or SMBus. Signed-off-by: Kai-Heng Feng Signed-off-by: Your Name --- v3: - Put

Re: [PATCH v3 0/8] PM / ACPI: sleep: Additional changes related to suspend-to-idle

=pm-s2idle-testing I’ve just tested the full series on Latitude 5300, and the additional spurious wake up is gone. Tested-by: Kai-Heng Feng Please refer to the changelogs for details. Thanks, Rafael

Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems

at 19:04, Rafael J. Wysocki wrote: On Fri, Aug 2, 2019 at 12:55 PM Kai-Heng Feng wrote: at 06:26, Rafael J. Wysocki wrote: On Thu, Aug 1, 2019 at 9:05 PM wrote: -Original Message- From: Rafael J. Wysocki Sent: Thursday, August 1, 2019 12:30 PM To: Kai-Heng Feng; Keith Busch

[PATCH] xhci: Increase STS_SAVE timeout in xhci_suspend()

ch is much less than the old one. Increase the timeout to make ASMedia xHCI able to suspend again. BugLink: https://bugs.launchpad.net/bugs/1844021 Fixes: f7fac17ca925 ("xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()") Signed-off-by: Kai-Heng Feng --- drivers/usb/h

[PATCH] Revert "Input: elantech - enable SMBus on new (2018+) systems"

, but it'll be enabled via a whitelist. Signed-off-by: Kai-Heng Feng --- drivers/input/mouse/elantech.c | 55 ++ 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 04fe43440a3c

Re: [PATCH] Revert "Input: elantech - enable SMBus on new (2018+) systems"

Hi Benjamin, > On Oct 1, 2019, at 15:08, Kai-Heng Feng wrote: > > This reverts commit 883a2a80f79ca5c0c105605fafabd1f3df99b34c. > > Apparently use dmi_get_bios_year() as manufacturing date isn't accurate > and this breaks older laptops with new BIOS update. > > So

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

at 21:45, Bjorn Helgaas wrote: On Fri, Jul 05, 2019 at 03:02:01PM +0800, Kai-Heng Feng wrote: at 19:57, Bjorn Helgaas wrote: On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: I'm wondering if this platform has a firmware defect. Here's my thinking. The xHC is a Root

[PATCH] x86/PCI: Remove D0 PME capability on AMD FCH xHCI

tps://bugzilla.kernel.org/show_bug.cgi?id=203673 Signed-off-by: Kai-Heng Feng --- arch/x86/pci/fixup.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 527e69b12002..0851a05d092f 100644 --- a/arch/x86/pci/fixup.c +++ b/arch/x86/pci/fixu

Re: [PATCH] x86/hpet: Disable HPET on Intel Coffe Lake

Hi Thomas, > On Aug 30, 2019, at 03:45, Thomas Gleixner wrote: > > On Thu, 29 Aug 2019, Kai-Heng Feng wrote: >> at 20:13, Thomas Gleixner wrote: >>> On Thu, 29 Aug 2019, Kai-Heng Feng wrote: >>> >>>> Some Coffee Lake platforms have skewed HPET time

Re: [PATCH] x86/PCI: Remove D0 PME capability on AMD FCH xHCI

> On Oct 2, 2019, at 08:07, Bjorn Helgaas wrote: > > [+cc Alan, Mathias, Rafael, Lukas] > > On Mon, Sep 02, 2019 at 10:52:52PM +0800, Kai-Heng Feng wrote: >> There's an xHCI device that doesn't wake when a USB 2.0 device gets >> plugged to its USB 3.0 port. The d

[PATCH] Revert "usb: Avoid unnecessary LPM enabling and disabling during suspend and resume"

inside Dell WD15 depends on. Fixes: d590c2311150 ("usb: Avoid unnecessary LPM enabling and disabling during suspend and resume") Signed-off-by: Kai-Heng Feng --- drivers/usb/core/hub.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c

[PATCH] ALSA: hda/realtek: Reduce the Headphone static noise on XPS 9350/9360

touchable by userspace. Fixes: 717f43d81afc ("ALSA: hda/realtek - Update headset mode for ALC256") BugLink: https://bugs.launchpad.net/bugs/1654448 BugLink: https://bugs.launchpad.net/bugs/1845810 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 24 +--- 1 fil

Re: [PATCH] Revert "usb: Avoid unnecessary LPM enabling and disabling during suspend and resume"

> On Oct 2, 2019, at 23:47, Alan Stern wrote: > > On Wed, 2 Oct 2019, Kai-Heng Feng wrote: > >> This reverts commit d590c23111505635e1beb01006612971e5ede8aa. >> >> Dell WD15 dock has a topology like this: >> /: Bus 04.Port 1: Dev 1, Class=root_hub, Drive

Re: [PATCH] Revert "usb: Avoid unnecessary LPM enabling and disabling during suspend and resume"

> On Oct 3, 2019, at 22:26, Alan Stern wrote: > > On Thu, 3 Oct 2019, Kai-Heng Feng wrote: > >>> On Oct 2, 2019, at 23:47, Alan Stern wrote: >>> >>> On Wed, 2 Oct 2019, Kai-Heng Feng wrote: >>> >>>> This reverts commit d590c23

Re: [PATCH 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence

Hi Bjorn, I didn't find your reply in my mailbox earlier. On Mon, Sep 9, 2019 at 1:41 PM Bjorn Helgaas wrote: > > Maybe: > > PCI: Add pci_pr3_present() to check for Power Resources for D3hot Ok, this is a good title. > > On Tue, Aug 27, 2019 at 09:47:55PM +0800, K

[PATCH] staging: rtl8723bs: Remove debugging information exposed via procfs

The procfs provides many useful information for debugging, but it may be too much for normal usage, routines like proc_get_sec_info() reports various security related information. So let's remove it. Signed-off-by: Kai-Heng Feng --- drivers/staging/rtl8723bs/Makefile|1

Re: [PATCH v2 1/2] serial: 8250_pci: Add support for Sunix serial boards

Hi Andy, at 21:18, Andy Shevchenko wrote: On Fri, Aug 9, 2019 at 10:05 PM Kai-Heng Feng wrote: Add support to Sunix serial boards with up to 16 ports. Sunix board need its own setup callback instead of using Timedia's, to properly support more than 4 ports. Can you, please, split out

[PATCH v3] usb: Add a new quirk to let buggy hub enable and disable LPM during suspend and resume

("usb: Avoid unnecessary LPM enabling and disabling during suspend and resume") Signed-off-by: Kai-Heng Feng --- v3: - Add forgotten patch revision changelog. v2: - Explained by Alan, the hub should properly handle U3 -> U0 transition. So use a quirk to target this bugg

[PATCH v2] usb: Add a new quirk to let buggy hub enable and disable LPM during suspend and resume

("usb: Avoid unnecessary LPM enabling and disabling during suspend and resume") Signed-off-by: Kai-Heng Feng --- Documentation/admin-guide/kernel-parameters.txt | 3 +++ drivers/usb/core/hub.c | 15 +++ drivers/usb/core/quirks.c

[PATCH] r8152: Set macpassthru in reset_resume callback

set MAC address again in reset_resume callback. Also remove unnecessary lock as no other locking attempt will happen during reset_resume. Signed-off-by: Kai-Heng Feng --- drivers/net/usb/r8152.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b

Re: e1000e regression - 5.4rc1

Hi Tobias > On Oct 4, 2019, at 18:34, Tobias Klausmann > wrote: > > Hello all, > > While testing the 5.4rc1 release, i noticed my Ethernet never coming fully > up, seemingly having a timeout problem. While bisecting this i landed at the > commit dee23594d587386e9fda76732aa5f5a487709510

Re: [PATCH] r8152: Set macpassthru in reset_resume callback

> On Oct 5, 2019, at 19:46, Simon Horman wrote: > > On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote: >> r8152 may fail to establish network connection after resume from system >> suspend. >> >> If the USB port connects to r8152 lost its power

[PATCH 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence

A driver may want to know the existence of _PR3, to choose different runtime suspend behavior. A user will be add in next patch. This is mostly the same as nouveau_pr3_present(). Signed-off-by: Kai-Heng Feng --- drivers/pci/pci.c | 20 include/linux/pci.h | 2 ++ 2

[PATCH 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound

gs/1840835 Signed-off-by: Kai-Heng Feng --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 99fc0917339b..d4ee070e1a29 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c

Re: [PATCH 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound

at 21:47, Kai-Heng Feng wrote: It's a common practice to let dGPU unbound and use PCI port PM to disable its power through _PR3. When the dGPU comes with an HDA function, the HDA won't be suspended if the dGPU is unbound, so the dGPU power can't be disabled. Commit 37a3a98ef601 ("ALSA

Re: [PATCH 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence

at 23:25, Takashi Iwai wrote: On Tue, 27 Aug 2019 15:47:55 +0200, Kai-Heng Feng wrote: A driver may want to know the existence of _PR3, to choose different runtime suspend behavior. A user will be add in next patch. This is mostly the same as nouveau_pr3_present(). Then it'd be nice

Alps touchpad generates IRQ storm after S3

Hi Masaki, The Alps touchpad (044E:1220) on Dell Precision 7530 causes IRQ storm after system suspend (S3). Commit "HID: i2c-hid: Don't reset device upon system resume” which solves the same issue for other vendors, cause the issue on Alps touchpad. So I’d like to know the correct command

Re: Alps touchpad generates IRQ storm after S3

regards, Jason -Original Message- From: 太田 真喜 Masaki Ota Sent: Wednesday, August 28, 2019 2:35 PM To: 曹 曉建 Xiaojian Cao ; Kai-Heng Feng Cc: Mario Limonciello ; open list:HID CORE LAYER ; Linux Kernel Mailing List ; 斉藤 直樹 Naoki Saito Subject: RE: Alps touchpad generates IRQ storm

Re: [PATCH 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound

Hi Bjorn, at 06:31, Bjorn Helgaas wrote: On Tue, Aug 27, 2019 at 09:47:56PM +0800, Kai-Heng Feng wrote: It's a common practice to let dGPU unbound and use PCI port PM to disable its power through _PR3. When the dGPU comes with an HDA function, the HDA won't be suspended if the dGPU

Re: Alps touchpad generates IRQ storm after S3

hanks, -Original Message- From: Kai-Heng Feng Sent: Wednesday, August 28, 2019 1:58 AM To: Xiaojian Cao Cc: Masaki Ota; Limonciello, Mario; open list:HID CORE LAYER; Linux Kernel Mailing List; Naoki Saito Subject: Re: Alps touchpad generates IRQ storm after S3 [EXTERNAL EMAIL] Hi Xiaojian,

[PATCH v2 2/2] ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound

A function, to save lots of power. BugLink: https://bugs.launchpad.net/bugs/1840835 Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers”) Signed-off-by: Kai-Heng Feng --- v2: - Change wording. - Rebase to Tiwai's branch. sound/pci/hda/hda_intel.c | 6 +- 1 file changed, 5 insertions

[PATCH] x86/hpet: Disable HPET on Intel Coffe Lake

://lore.kernel.org/lkml/20190516090651.1396-1-harry@intel.com/ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203183 Signed-off-by: Kai-Heng Feng --- arch/x86/kernel/hpet.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index

Re: [PATCH] x86/hpet: Disable HPET on Intel Coffe Lake

at 20:13, Thomas Gleixner wrote: On Thu, 29 Aug 2019, Kai-Heng Feng wrote: Some Coffee Lake platforms have skewed HPET timer once the SoCs entered PC10, and marked TSC as unstable clocksource as result. So here you talk about Coffee Lake and in the patch you use KABYLAKE. Coffeelake has

[PATCH v2 1/2] serial: 8250_pci: Add support for Sunix serial boards

Add support to Sunix serial boards with up to 16 ports. Sunix board need its own setup callback instead of using Timedia's, to properly support more than 4 ports. Cc: Morris Ku Cc: Debbie Liu Signed-off-by: Kai-Heng Feng --- v2: use div64_s64() instead of do_div() drivers/tty/serial/8250

[PATCH v2 2/2] parport: parport_serial: Add support for Sunix Multi I/O boards

Sunix Multi I/O boards are different to Timedia's. This patch adds proper support for Sunix MIO boards with 1 parallel and up to 4 serial ports. Cc: Morris Ku Cc: Debbie Liu Signed-off-by: Kai-Heng Feng --- drivers/parport/parport_serial.c | 44 +++- 1 file

[PATCH 1/2] usb: core: Make port power cycle a separate helper function

usb_hub_set_port_power(), since we can get *hdev from *hub directly. Signed-off-by: Kai-Heng Feng --- drivers/usb/core/hub.c | 29 +++-- drivers/usb/core/hub.h | 3 +-- drivers/usb/core/port.c | 4 ++-- 3 files changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/usb/core

<    2   3   4   5   6   7   8   9   10   11   >