Re: [v2] mwifiex: advertise low priority scan feature

org> > Tested-by: Wei-Ning Huang <wnhu...@chromium.org> > Acked-by: Amitkumar Karwar <akar...@marvell.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: brcmfmac: sdio: remove unused variable retry_limit

<julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

l.org; >> net...@vger.kernel.org; linux-kernel@vger.kernel.org >> Cc: Reizer, Eyal >> Subject: [PATCH] wlcore: spi: add wl18xx support Please edit your quotes and don't top most. A oneliner and then followed by almost 400 lines unnecessary text for example makes it harder to use patchwork: https://patchwork.kernel.org/patch/8696181/ -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

;, .data = _data}, >> >{ } >> >> Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it >> only >> mentions about ti,wl1271 and not anything about the rest. > > You are right! Will be fixed in v2 Thanks. Also remember to CC devicetree list. -- Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

805", .data = _data}, > + { .compatible = "ti,wl1807", .data = _data}, > + { .compatible = "ti,wl1831", .data = _data}, > + { .compatible = "ti,wl1835", .data = _data}, > + { .compatible = "ti,wl1837", .data = _data}, > { } Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it only mentions about ti,wl1271 and not anything about the rest. Adding devicetree list for further comments. -- Kalle Valo

Re: wl12xx: remove redundant null check on wl->scan.ssid

> From: Colin Ian King <colin.k...@canonical.com> > > ssid is an array of u8, so it can never be null, so the null check on > wl->scan.ssid is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

"Machani, Yaniv" <yani...@ti.com> writes: > More than that, wl1251 family is not officially supported via the > mainline Linux. I guess you mean not officially supported by TI? Because wl1251 driver has been in mainline for ages and reportedly working. -- Kalle Valo

Re: [RESEND] mwifiex: fix NULL pointer dereference error

> In mwifiex_enable_hs, we need to check if > priv->wdev.wiphy->wowlan_config is NULL before accessing its member. > This sometimes cause kernel panic when suspend/resume. > > Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: mwifiex: ie_list is an array, so no need to check if NULL

Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: Kernel crash on startup - bisected to commit 3b24d854cb35

er <da...@davemloft.net> > > No, I did not have that patch. After pulling from net-next to get it, > my system no longer panics. > > Note to linux-wireless readers. At the moment, a system built from > wireless-drivers-next will have this problem. I'm currently writing a pull request to Dave and once he pulls it I'll fast forward wireless-drivers-next to latest net-next. Usually this take two days or so. -- Kalle Valo

Re: [1/2] bcma: fix building without OF_IRQ

Arnd Bergmann <a...@arndb.de> writes: > On Wednesday 23 March 2016 15:52:43 Kalle Valo wrote: >> > The bcma driver core can be built with or without DT support, but >> > it fails to build when CONFIG_OF=y and CONFIG_OF_IRQ=n, which >> > can happen on platf

Re: [PATCH 4/5] ath9k: fix misleading indentation

d-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 499afaccf6f3 ("ath9k: Isolate ath9k_use_chanctx module parameter") > Fixes: eb61f9f623f7 ("ath9k: advertise p2p dev support when chanctx") Dave already applied this so I can skip this. -- Kalle Valo

Re: [PATCH 3/5] ath9k: fix buffer overrun for ar9287

es all three > instances to use that variable. The other two instances were > already correct, but it's more consistent this way. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 940cd2c12ebf ("ath9k_hw: merge the ar9287 version of > ath9k_hw_get_gain_boundaries_pdadcs") Dave already applies this so I can skip this. -- Kalle Valo

Re: [PATCH] mwifiex: advertise low priority scan feature

The From line states that this is written by Amitkumar but there's no Signed-off-By line from him. I can't take this without that, please resend. (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) -- Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

, can you help? It's a long time ago but IIRC wl1251 has not ever supported AP mode and wl1271 was the first one to support it. But I might be wrong of course. -- Kalle Valo

Re: [1/2] bcma: fix building without OF_IRQ

ess if needed"). > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: b43: Fix memory leaks in b43_bus_dev_ssb_init andb43_bus_dev_bcma_init

; > Thanks Michael for his suggestion. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> > Acked-by: Michael Büsch <m...@bues.ch> > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: rtlwifi: fix gcc-6 indentation warning

-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers.git. Kalle Valo

Re: mwifiex: Use to_delayed_work()

iner_of(a, struct delayed_work, work) > + to_delayed_work(a) > // > > Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: at76c50x-usb: avoid double usb_put_dev() after downloading internalfirmware in at76_probe()

> There is no need in usb_put_dev() if at76_load_internal_fw() succeed. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

change just affects just the rx_command_packet calls. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

> Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter, > RT chipset 3593 > > Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com> > Cc: sta...@vger.kernel.org > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails

a fields are free'd. Fix this by not free'ing the > dma_buf if the ivp allocation fails. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

n use an IS_ENABLED() check > to avoid defining the structure when CONFIG_PM is not set without > the #ifdef. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: pull-request: wireless-drivers 2016-02-18

(Adding Larry) Geert Uytterhoeven <ge...@linux-m68k.org> writes: > On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <kv...@codeaurora.org> wrote: > >> rtlwifi >> >> * fix broken VHT (802.11ac) support, reported by Linus > > That's commit d76d65fd269514

pull-request: wireless-drivers 2016-03-04

(1): ssb: host_soc depends on sprom Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-02-25' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: mvm: inc pending frames counter also when txing non-sta Matti Gottlieb (1): iwlwifi: mvm: Fix paging

Re: [PATCH v2] bcma: use of_dma_configure() to set initial dma mask

ergmann <a...@arndb.de> > --- > This patch needs to be tested to ensure we don't introduce > regressions, and should probably go into 4.7 as a cleanup. Is anyone able to test this? The full patch is here: https://patchwork.kernel.org/patch/8608751/ -- Kalle Valo

Re: [PATCH RESEND] mwifiex: fix NULL pointer dereference error

Wei-Ning Huang <wnhu...@google.com> writes: > Kalle, can you help amend the message if this patch is accepted? Sure, I'll fix the typo in the commit log. But please try to avoid top posting, it makes it more difficult to follow the threads. -- Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

t and that's I'm not thrilled to take big patches like this for dormant drivers. -- Kalle Valo

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

ing Huang <wnhu...@chromium.org> Is this really a proper way to fix the issue? This is the first time I'm hearing about the flag and there isn't even a single user in drivers/net. I would like to get confirmation from others that __GFP_REPEAT is really ok to use in a wireless driver before I can take this. -- Kalle Valo

Re: [PATCH] ath5k: Change led pin configuration for compaq c700 laptop

b8d ("ath5k: add led pin > configuration for compaq c700 laptop") > > Signed-off-by: Joseph Salisbury <joseph.salisb...@canonical.com> > Cc: sta...@vger.kernel.org Applied to ath.git, thanks. I just fixed the Fixes line to be one continuous line. -- Kalle Valo

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

7, that introduces this > helper function. Do you want me to resend, or can you apply the patches > out of order? It's better that you resend the whole patchset as v2. -- Kalle Valo

Re: [PATCH v3 00/18] wcn36xx fixes

ex instead of hard coded > wcn36xx: Clear encrypt_type when deleting bss key > wcn36xx: Track association state > wcn36xx: Implement multicast filtering > wcn36xx: Use correct command struct for EXIT_BMPS_REQ All applied, thanks. -- Kalle Valo

pull-request: wireless-drivers 2016-04-25

Ayala Beker (1): iwlwifi: mvm: avoid to WARN about gscan capabilities Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-04-12_2' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti Gottlieb (1): iwlwifi: mvm: fix accessing Null pointer during fw dump

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

macros, SHOW_*, pc_debug, maybe >> more) as well. > > Seems reasonable. > > Maybe we should Cc the maintainer, but I suspect that since the driver > is marked Obsolete anyway Luis won't care either :) I'm planning to apply this patch anyway, the debugging infrastructure removal can be a followup patch. But please let me know if I should drop this instead. -- Kalle Valo

Re: [PATCH 1/5] ti: Convert wl1271_ logging macros to dev_ or pr_

vers/net/wireless/ti/wl18xx/event.c Auto-merging drivers/net/wireless/ti/wl18xx/debugfs.c Auto-merging drivers/net/wireless/ti/wl18xx/cmd.c Auto-merging drivers/net/wireless/ti/wl12xx/scan.c Auto-merging drivers/net/wireless/ti/wl12xx/main.c Failed to merge in the changes. -- Kalle Valo

Re: [v3] prism54: isl_38xx: Replace 'struct timeval'

<a...@arndb.de> Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds

gt; > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Applied, thanks. -- Kalle Valo

Re: [RFC][PATCH 00/31] implement atomic_fetch_$op

e: > 0day bot is working on your tree (no worry about out-of-service) and > reached a major milestone. Thanks, this is very useful information. But would it be also possible to get a report about the P2 completion (or failure)? -- Kalle Valo

Re: get_maintainer.pl and MAINTAINERS file

Mauro Carvalho Chehab <mche...@osg.samsung.com> writes: > Em Thu, 19 May 2016 16:25:45 +0200 > Richard Weinberger <richard.weinber...@gmail.com> escreveu: > >> On Thu, May 19, 2016 at 2:57 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> > (Changed the s

Re: [GIT] Networking

"Coelho, Luciano" <luciano.coe...@intel.com> writes: > Kalle, David, what is the status with the fix that is on the way via > your trees? It would be best if you could send a patch either directly to Dave or Linus to resolve this quickly. -- Kalle Valo

Re: [GIT] Networking

Linus Torvalds <torva...@linux-foundation.org> writes: > On Wed, May 18, 2016 at 11:58 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> >> It would be best if you could send a patch either directly to Dave or >> Linus to resolve this quickly. > > I'm comm

get_maintainer.pl and MAINTAINERS file

anisation, and had to make numerous changes to MAINTAINERS in the process, I have been CCed to all sorts of patchsets to which I have nothing to do with (this one included). I suspect get_maintainer.pl is to blame here. -- Kalle Valo

pull-request: wireless-drivers-next 2016-05-13 (take two)

: rtl818x: constify rtl_intf_ops structures Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2016-05-10' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Liad Kaufman (4): iwlwifi: mvm: allocate queue for probe response in dqa mode iwlwifi: mvm

Re: [PATCH 33/54] MAINTAINERS: Add file patterns for wireless device tree bindings

Geert Uytterhoeven <ge...@linux-m68k.org> writes: > Submitters of device tree binding documentation may forget to CC > the subsystem maintainer if this is missing. > > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Kalle Valo <kv...@cod

Re: [PATCH 0/7] fix typo

know in advance what tree you are planning to submit these for. For example, should I take ath6kl and mwifiex patches or someone else? -- Kalle Valo

Re: [PATCH 0/7] fix typo

Julia Lawall <julia.law...@lip6.fr> writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall <julia.law...@lip6.fr> writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

(uintptr_t)skb_info->driver_data[0]); tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I'm going to propose this to Dave in my pending pull request[1]. But I would appreciate if someone else would double check this. [1] https://patchwork.ozlabs.org/patch/621953/ -- Kalle Valo

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

tx_cmd->life_time = cpu_to_le32(TX_CMD_LIFE_TIME_INFINITE); tx_cmd->sta_id = sta_id; I wasn't expecting that skb_info variable is removed. Do we now have merge damage somewhere? Luca, what do you think? -- Kalle Valo

Re: Use of deleted Kconfig option B43_PCMCIA

different? > > We even got patch for this, but it wasn't submitted correctly (didn't > go to linux-wireless): > https://lkml.org/lkml/2015/11/2/154 Nobody resubmitted that patch? -- Kalle Valo

Re: [v2] rtlwifi: pci: use dev_kfree_skb_irq instead of kfree_skb inrtl_pci_reset_trx_ring

wang yanqing wrote: > We can't use kfree_skb in irq disable context, because spin_lock_irqsave > make sure we are always in irq disable context, use dev_kfree_skb_irq > instead of kfree_skb is better than dev_kfree_skb_any. > > This patch fix below kernel warning: > [

Re: mwifiex: fixup error messages

Wei-Ning Huang wrote: > Use dev_err instead of pr_err and add newline character at the end. > > Signed-off-by: Wei-Ning Huang Thanks, 1 patch applied to wireless-drivers-next.git: 50d4d8feb913 mwifiex: fixup error messages -- Sent by pwcli

Re: rtlwifi: rtl818x: constify rtl_intf_ops structures

Julia Lawall wrote: > The rtl_intf_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, 1 patch applied to wireless-drivers-next.git: 1bfcfdcca142 rtlwifi:

Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode

wang yanqing wrote: > In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and > rtl_lps_enter() to use work queue"), the tests for enter/exit > power-save mode were inverted. With this change applied, the > wifi connection becomes much more stable. > > Fixes:

Re: rtlwifi: rtl818x: silence uninitialized variable warning

Dan Carpenter wrote: > What about if "rtlphy->pwrgroup_cnt" is 2? In that case we would use an > uninitialized "chnlgroup" variable and probably crash. Maybe that can't > happen for some reason which is not obvious but in that case this patch > is harmless. > >

Re: [v2] rtlwifi: Remove double check for cnt_after_linked

wang yanqing wrote: > rtl_lps_enter does two successive check for cnt_after_linked > to make sure some time has elapsed after linked. The second > check isn't necessary, because if cnt_after_linked is bigger > than 5, it is bigger than 2 of course! > > This patch remove the

Re: atmel: potential underflow in atmel_set_freq()

Dan Carpenter wrote: > Smatch complains that we cap the upper bound of "fwrq->m" but not the > lower bound. I don't know if it can actually happen but it's simple > enough to check for negatives. > > Signed-off-by: Dan Carpenter Thanks, 1

Re: rtlwifi: rtl818x: Deinline indexed IO functions, save 21568 bytes

il.com.cn> > CC: linux-wirel...@vger.kernel.org > CC: linux-kernel@vger.kernel.org Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: linux-next: manual merge of the net-next tree with the wireless-drivers tree

to fix this by merging wireless-drivers to wireless-drivers-next later today and most likely tomorrow send a wireless-drivers-next pull request to Dave. -- Kalle Valo

pull-request: wireless-drivers 2016-05-09

) Emmanuel Grumbach (1): iwlwifi: mvm: don't override the rate with the AMSDU len Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-05-04' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/intel/iwlwifi/mvm

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

t; > Have you picked up these patches yet? > > As I was debugging a firmware crash when trying to start hostap on the > DragonBoard410c I found an issue with this patch, would like to know if > I should send an incremental patch or resend this one. I haven't applied these yet, so please resend the whole series as v3. -- Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Patch failed at 0001 rtlwifi: Fix reusable codes in core.c Please rebase and resend. -- Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

Julian Calaby <julian.cal...@gmail.com> writes: > Hi Kalle, > > On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Byeoungwook Kim <quddnr...@gmail.com> writes: >> >>> rtl_*_delay() functions were reused same co

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> Lauri Kasanen <c...@gmx.com> writes: >> >> > --- a/drivers/net/wireless/ath/carl9170/Kconfig >> > +++ b/drivers/net/wireless/ath/c

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied, thanks. -- Kalle Valo

Re: [PATCH] rtl8xxxu: hide unused tables

into device specific >> functions") >> --- >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 >> 1 file changed, 4 insertions(+) > > I'll apply it to my tree! Actually I would prefer to apply this directly to wireless-drivers-next so that the warnings are quickly fixed. -- Kalle Valo

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Replace an explicit initialisation for one local variable at the beginning >> by a conditional assignment. >> >> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > > This looks sane to me. > > Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Applied, thanks. -- Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

Christian Lamparter <chunk...@googlemail.com> writes: > On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote: >> Christian Lamparter <chunk...@googlemail.com> writes: >> >> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote: >> > >> >

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Eliad Peller <el...@wizery.com> writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <j...@perches.com> wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches <j...@perches.com> writes: >>> > On Wed, 2016-03-30 at 14:51

Re: rtl8xxxu: hide unused tables

"rtl8xxxu: Add TX power base values for gen1 parts") > Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific > functions") Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

s/Drivers/carl9170> Why even mention anything about a "special firmware" as the firmware is already available from linux-firmware.git? That's default location for all firmware images and I think most, if not all, distros should have it available. So wouldn't it be better not to mention anything about firmware at all? -- Kalle Valo

pull-request: wireless-drivers 2016-04-13

Grumbach (1): iwlwifi: pcie: lower the debug level for RSA semaphore access Jia-Ju Bai (1): b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-03-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Matti

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

.cal...@gmail.com> Before I commit I'll just change the commit title to: ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel() -- Kalle Valo

pull-request: wireless-drivers-next 2016-07-22

if dma_mapping_error() fails in dma_rxfill brcmsmac: Initialize power in brcms_c_stf_ss_algo_channel_get() Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-07-11' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

>> consistently). >> >> Regards, >> Christian > > I wonder if this is something that is only affecting certain NIC's? > For example, it see this issue on sun4u boxes with tigon3 and hme > interfaces. But on my sun4v boxes that have e1000 interfaces > everything works fine. Kernel configuration might also make a difference. Trying to find an Kconfig option which affects this could be useful. -- Kalle Valo

Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

>> opposed to current implementation that handles STA only). >> 5. Bumped the firmware version to support new Mesh functionality >> >> Signed-off-by: Maital Hahn <mait...@ti.com> >> Signed-off-by: Yaniv Machani <yani...@ti.com> >> --- > > Any comments on this patch ? Can this be pulled ? I'm away this week, will look at it next week. But it's on my queue: https://patchwork.kernel.org/patch/9202707/ -- Kalle Valo

Re: [PATCHv5 wl-drv-next 0/2] register-field manipulation macros

see an ack from someone else like Andrew Morton or Dave Miller. I don't feel comfortable adding new files to include/ without some sort of support from others. Or maybe Andrew could even take these directly to his tree? -- Kalle Valo

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

u can use function names or something else. Adding "(2)" is not the way to do that. -- Kalle Valo

Re: [PATCH 1/1 v2] rtlwifi: remove superfluous condition

ry Finger <larry.fin...@lwfinger.net> > --- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The change log goes under the "---" line so that git can automatically strip it away while committing the patch. I can fix it this time but please keep this in mind in the future. -- Kalle Valo

Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

x-wireless, adding it now. Others can find the full discussion here: http://lkml.kernel.org/g/20160804124314.7636-2-maxim.alts...@ti.com -- Kalle Valo

Re: [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure

) so lots of wireless people missed this patch. Please resend. -- Kalle Valo

Re: [PATCH 2/2] wlcore: Remove wl pointer from wl_sta structure

) so lots of wireless people missed this patch. Please resend. -- Kalle Valo

Re: [BUGFIX PATCH 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

alle: I'm acking this as bugfix for 4.8 release. Ok. I'll wait few days for more comments before I apply this. (I assume you are talking only about patch 1) -- Kalle Valo

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Please don't top post, it breaks patchwork which is extremely annoying for me: https://patchwork.kernel.org/patch/9266265/ https://patchwork.kernel.org/patch/9266617/ -- Kalle Valo

pull-request: wireless-drivers-next 2016-07-13

Q code iwlwifi: remove useless enum values iwlwifi: change fw.mvm_fw to fw.type iwlwifi: remove iwl_ht_params.smps_mode iwlwifi: store cipher scheme independent of mac80211 iwlwifi: tracing: decouple from mac80211 iwlwifi: decouple PCIe transport from mac80211 Kalle V

Re: iwlwifi: add missing type declaration

Arnd Bergmann wrote: > The iwl-debug.h header relies in implicit inclusion of linux/device.h and > we get a lot of warnings without that: > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:44:23: error: 'struct device' > declared inside parameter list will not be visible outside

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

d like a good idea. I would rather try to fix the thermal interface to handle the cases when the measurement is not available. -- Kalle Valo

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

Prarit Bhargava <pra...@redhat.com> writes: > On 07/13/2016 02:50 AM, Kalle Valo wrote: >> Prarit Bhargava <pra...@redhat.com> writes: >> >>>> We implement thermal zone because we do support it, but the problem is >>>> that we need t

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

out. It looks like just moving some code around.] Another option, but still a bad one I don't like, is that you change the kernel interface to ignore all errors from drivers (like iwlwifi). This way drivers don't need to make ugly workarounds. > The bottom line is that lm-sensors is currently broken with this change in > iwlwifi. AFAICT, no other thermal device returns an error this way, and IMO > that means the iwlwifi driver is doing something new and unexpected wrt to > userspace. I haven't checked but I suspect ath10k has a similar problem when interface is down. -- Kalle Valo

Re: linux-next: build warning after merge of the wireless-drivers-next tree

, it's usually quite good to catch warnings like this. Anyway, I have pushed the fix to wireless-drivers-next: cb6a11518850 wlcore: spi: fix build warning caused by redundant variable -- Kalle Valo

Re: [PATCH] wlcore: spi: fix build warning caused by redundant variable

"Reizer, Eyal" <ey...@ti.com> writes: > The ret variable is unused in wlcore_probe_of() > Remove it for fixing build warning. > > Fixes: 01efe65aba65 ("wlcore: spi: add wl18xx support") > Signed-off-by: Eyal Reizer <ey...@ti.com> Applied to wireless-drivers-next, thanks. -- Kalle Valo

Re: linux-next: build failure after merge of the wireless-drivers-next tree

Brian Norris <computersforpe...@gmail.com> writes: > Just to head this off, since I noticed it... > > On Tue, Jul 19, 2016 at 05:08:59PM +0300, Kalle Valo wrote: >> Rafał Miłecki <zaj...@gmail.com> writes: >> > I sent a patch seconds ago, you may just take a

Re: [PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

mentation that handles STA only). > 5. Bumped the firmware version to support new Mesh functionality > > Signed-off-by: Maital Hahn <mait...@ti.com> > Signed-off-by: Yaniv Machani <yani...@ti.com> Does this depend on any mac80211 patches? To not break anything I can't apply this until all the dependencies are in my tree. -- Kalle Valo

Re: [PATCH v5] wlcore: spi: add wl18xx support

; v5 is corrupted somehow in patchwork: https://patchwork.kernel.org/patch/9233597/ The "former" v5 again looks ok: https://patchwork.kernel.org/patch/9222403/ I can't immeaditely see why that happened, but please resend. -- Kalle Valo

Re: [1/2, v4] wlcore/wl18xx: Add functionality to accept TX rate per link

Maxim Altshul wrote: > FW will provide a TX rate per link for each FW status, > and wlcore will be able to store the information for > the use of the mesh hwmp module. > > This is used mainly in mesh. > Rates are reported when a mesh interface is up. > > Signed-off-by:

Re: bcma: allow enabling serial flash support on non-MIPS SoCs

Rafał Miłecki wrote: > So far we had only MIPS devices with serial flash connected to the SoC's > ChipCommon. ARM devices got a separated SPI controller and weere using > standard SPI drivers. > This has changed with the wireless SoC BCM47189B0. It's ARM based but > has serial flash attached just

Re: [v4] mwifiex: Reduce endian conversion for REG Host Commands

Prasun Maiti wrote: > For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS, > HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are > saved to driver. So, "leX_to_cpu" conversion is required too many > times afterwards in driver. > > This

Re: wlcore/wl18xx: mesh: added initial mesh support for wl8

"Machani, Yaniv" wrote: > From: Maital Hahn > > 1. Added support for interface and role of mesh type. > 2. Enabled enable/start of mesh-point role, >and opening and closing a connection with a mesh peer. > 3. Added multirole combination of mesh and ap >

Re: [FIX,4.6+] bcma: add PCI ID for Foxconn's BCM43142 device

Rafał Miłecki wrote: > After discovering there are 2 very different 14e4:4365 PCI devices we > made ID tables less generic. Back then we believed there are only 2 such > devices: > 1) 14e4:4365 1028:0016 with SoftMAC BCM43142 chipset > 2) 14e4:4365 14e4:4365 with FullMAC BCM4366 chipset > > >From

Re: brcmfmac: respect hidden_ssid for AP interfaces

Rafał Miłecki wrote: > This was succesfully tested with 4366B1. A small workaround is needed > for the main interface otherwise it would stuck at the hidden state. > > Signed-off-by: Rafał Miłecki Thanks, 1 patch applied to wireless-drivers-next.git: c940de10d45e brcmfmac:

<    1   2   3   4   5   6   7   8   9   10   >