Re: zd1211rw: fix spelling mistake "firmeware" -> "firmware"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks, 1 patch applied

Re: rtlwifi/rtl8192de: Fix print format string

Oleg Drokin wrote: > %ul was likely meant as %lu to print an unsigned long, > not an unsigned with a letter l at the end. > But in fact the value printed is u32 anyway, so just drop > the l completely. > > Signed-off-by: Oleg Drokin > Acked-by: Larry

Re: wcn36xx: Implement print_reg indication

Bjorn Andersson wrote: > Some firmware versions sends a "print register indication", handle this > by printing out the content. > > Cc: Nicolas Dechesne > Signed-off-by: Bjorn Andersson This doesn't apply anymore, please

Re: [v2] bcma: use of_dma_configure() to set initial dma mask

Arnd Bergmann wrote: > While fixing another bug, I noticed that bcma manually sets up > a dma_mask pointer for its child devices. We have a generic > helper for that now, which should be able to cope better with > any variations that might be needed to deal with cache coherency, >

Re: [v2] ErrHandling:Make IS_ERR_VALUE_U32 as generic API to avoid IS_ERR_VALUE abuses.

Arvind Yadav wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an 'unsigned int' reflects an error. > As they pass an 'unsigned int' into a function that takes an > 'unsigned long' argument. This happens to work

Re: [2/2,v2] wlcore: Remove wl pointer from wl_sta structure

Maxim Altshul wrote: > This field was added to wl_sta struct to get hw in situations > where it was not given to driver by mac80211. In our case, > get_expected_throughput op did not send hw to driver. > > This patch reverts the change, as it is no longer needed due to

Re: [v2,1/1] brcmfmac: fix pmksa->bssid usage

Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const u8 *bssid; > > contrary to struct brcmf_pmksa, which uses: > > u8 bssid[ETH_ALEN]; > > Therefore in brcmf_cfg80211_del_pmksa(), >bssid takes the address > of this field

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> I'm planning to queue this to 4.8 if no objections. -- Sent by pwcli https://patchwork.kernel.org/patch/9309829/

Re: [v2] bcma: use of_dma_configure() to set initial dma mask

Arnd Bergmann <a...@arndb.de> writes: > On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote: >> Arnd Bergmann <a...@arndb.de> wrote: >> > While fixing another bug, I noticed that bcma manually sets up >> > a dma_mask pointer for its child

Re: ath9k: bring back direction setting in ath9k_{start_stop}

Kalle Valo <kv...@qca.qualcomm.com> writes: > Giedrius Statkevi?ius <giedrius.statkevic...@gmail.com> wrote: >> A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup >> led_pin initial") that broken the WLAN status led on my laptop with &g

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-next branch of ath.git: 088a

Re: ath9k: bring back direction setting in ath9k_{start_stop}

well. > > Cc: Miaoqing Pan <miaoq...@codeaurora.org> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Cc: <sta...@vger.kernel.org> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevic...@gmail.com> Thanks, 1 patch applied to ath-current branch of ath.git:

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

les changed, 86 insertions(+), 66 deletions(-) So I don't actually need to enable COMPILE_TEST anymore? Nice, thanks. -- Kalle Valo

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

;> 1 file changed, 13 insertions(+) >> > > This is fine. > > Acked-by: Andy Gross <andy.gr...@linaro.org> Thanks. I'll then apply this to my ath.git tree and it will go to Linus via net-next. -- Kalle Valo

pull-request: wireless-drivers 2016-09-08

iwlwifi: mvm: don't use ret when not initialised Giedrius Statkevičius (1): ath9k: bring back direction setting in ath9k_{start_stop} Kalle Valo (2): Merge tag 'iwlwifi-for-kalle-2016-08-29' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Merge ath-current from ath.git

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

om_smd_set_drvdata(struct qcom_smd_channel *channel, void *data) +static inline void qcom_smd_set_drvdata(struct qcom_smd_channel *channel, void *data) { /* This shouldn't be possible */ WARN_ON(1); -- Kalle Valo

Re: rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby I assume Jes will take

Re: [1/1,v2] rtlwifi: remove superfluous condition

Heinrich Schuchardt wrote: > If sta == NULL, the changed line will not be reached. > So no need to check that sta != NULL here. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to

Re: rt2x00usb: Fix error return code

Christophe Jaillet wrote: > We know that 'retval = 0' because it has been tested a few lines above. > So, if 'devm_kmalloc' fails, 0 will be returned instead of an error code. > Return -ENOMEM instead. > > Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage

Re: mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

Colin Ian King wrote: > From: Colin Ian King > > The IEEE80211_STYPE_ACTION case is missing a break in the switch > statement, causing it to fall through to the default case that > reports a debug message about an unknown frame subtype. Fix

Re: wl3501_cs: Add spinlock to wl3501_reset

Pavel Andrianov wrote: > Likely wl3501_reset should acquire spinlock as wl3501_{open, close}. > One of calls of wl3501_reset has been already protected. > The others were unprotected and might lead to a race condition. > The patch adds spinlock into the wl3501_reset and

Re: [1/1] mwifiex: remove superfluous condition

Heinrich Schuchardt wrote: > for_each_property_of_node is only executed if the > property prop is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git:

Re: [v4] brcmfmac: add missing header dependencies

Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: > no previous prototype for '__brcmf_err' [-Wmissing-prototypes] > > In fact, this function is declared in

Re: fix:rtl8xxxu_core: mark symbols static where possible

Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the rtl8xxxu rtl8xxxu_core.c when building with W=1: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no > previous prototype for 'rtl8xxxu_gen1_h2c_cmd'

Re: bcma: support BCM53573 series of wireless SoCs

Rafał Miłecki wrote: > BCM53573 seems to be the first series of Northstar family with wireless > on the chip. The base models are BCM53573-s (A0, A1) and there is also > BCM47189B0 which seems to be some small modification. > > The only problem with these chipsets seems to be watchdog. It's

Re: [1/2] mwifiex: fix the length parameter of a memset

Christophe Jaillet wrote: > In 'mwifiex_get_ver_ext', we have: >struct mwifiex_ver_ext ver_ext; > >memset(_ext, 0, sizeof(struct host_cmd_ds_version_ext)); > > This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. > Remove the

Re: [1/1] mwifiex: key_material_v2 remove superfluous condition

Heinrich Schuchardt wrote: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to

Re: [2/2,v2] wlcore: Remove wl pointer from wl_sta structure

Maxim Altshul wrote: > This field was added to wl_sta struct to get hw in situations > where it was not given to driver by mac80211. > > In our case, get_expected_throughput op did not send hw to driver. > > This patch reverts the change, as it is no longer needed due to >

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. > > Signed-off-by: Javier Martinez Canillas What's the

pull-request: wireless-drivers 2016-08-29

Cathy Luo (1): mwifiex: fix large amsdu packets causing firmware hang Felix Fietkau (2): ath9k: fix client mode beacon configuration ath9k: fix using sta->drv_priv before initializing it Kalle Valo (1): Merge ath-current from ath.git mhira...@kernel.org

Re: checkkpatch (in)sanity ?

Joe Perches <j...@perches.com> writes: > On Mon, 2016-08-29 at 14:15 +0300, Kalle Valo wrote: >> I wish that checkpatch would have a way to enable/disable warnings per >> directory (or file). For example, there would be >> drivers/net/wireless/ath/ath10k/.che

Re: [PATCH v4] brcmfmac: add missing header dependencies

> increases a noise and patchwork handles this just fine, see: > https://patchwork.kernel.org/patch/9303285/ > https://patchwork.kernel.org/patch/9303285/mbox/ > > > Do I need to resend a patch that fixes two typos(build/add)? or you modify > them > on your way? I can fix those when I commit the patch. -- Kalle Valo

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

Bjorn Andersson <bjorn.anders...@linaro.org> writes: > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >> >>> The wcn36xx wifi driver follows the life cycle of the WL

Re: Stability connection problems in ath9k kernel 4.7

Valerio Passini <valerio.pass...@unicam.it> writes: > On mercoledì 7 settembre 2016 11:32:24 CEST Kalle Valo wrote: >> Valerio Passini <valerio.pass...@unicam.it> writes: >> > I have found some connection problems since 4.7 release using ath9k that >> >

Re: [1/2] carl9170: Fix wrong completion usage

Daniel Wagner wrote: > From: Daniel Wagner > > carl9170_usb_stop() is used from several places to flush and cleanup any > pending work. The normal pattern is to send a request and wait for the > irq handler to call complete(). The completion is not

Re: [06/26] ath: constify local structures

Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

just afraid that the hassle would outweight the benefit. > Or we can wait till -rc1 To keep things simple I prefer this option. Of course it means waiting few more extra weeks, but when working with new subsystems that can happen. The crystall ball[1] says that 4.9-rc1 would be released on 2016-10-16 so it's not that far away. [1] http://phb-crystal-ball.org/ -- Kalle Valo

Re: [V2] ath10k: fix memory leak on caldata on error exit path

Colin Ian King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > caldata is not being free'd on the error exit path, causing > a memory leak and data definitely should not be freed. Free > caldata instead of data. > >

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

211_band band; > > chan = *buf++; > - if (!chan) > + if (!chan) { > + kfree(regd); > return NULL; > + } Bob sent a similar fix and he also did more: mwifiex: fix error handling in mwifiex_create_custom_regdomain https://patchwork.kernel.org/patch/9331337/ -- Kalle Valo

pull-request: wireless-drivers-next 2016-09-15

evice on module unload if still attached Julia Lawall (3): ath: constify local structures iwlegacy: constify local structures rtlwifi: rtl818x: constify local structures Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-08-30-2' of git://git.kernel.org/.../iwlwifi/iw

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

t; >drivers/net/wireless/marvell/mwifiex/main.c: In function > 'mwifiex_shutdown_sw': >>> drivers/net/wireless/marvell/mwifiex/main.c:1433:1: warning: label >>> 'exit_remove' defined but not used [-Wunused-label] > exit_remove: > ^~~ Looks like a valid warning to me, so please resend. -- Kalle Valo

Re: [v2] bcma: use of_dma_configure() to set initial dma mask

Arnd Bergmann wrote: > While fixing another bug, I noticed that bcma manually sets up > a dma_mask pointer for its child devices. We have a generic > helper for that now, which should be able to cope better with > any variations that might be needed to deal with cache coherency, >

Re: mwifiex: scan: Simplify code

Christophe Jaillet wrote: > This patch: >- improves code layout >- removes a useless memset(0) for some memory allocated with kzalloc >- removes a useless if. We know that 'if (chan_band_tlv)' will succeed > because it has been tested a few lines

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

ORKING DRIVERS)" in the CC list, I have to edit them away everytime I reply. Does anyone have any ideas why that's happening just to me? -- Kalle Valo

Re: brcmfmac: fix memory leak in brcmf_fill_bss_param

Rafał Miłecki wrote: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > > Signed-off-by: Rafał Miłecki > Fixes: 1f0dc59a6de ("brcmfmac:

Re: brcmfmac: drop unused fields from struct brcmf_pub

Rafał Miłecki wrote: > From: Rafał Miłecki > > They seem to be there from the first day. We calculate these values but > never use them. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. 2df86ad959c9 brcmfmac: drop unused

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

gt; Reason: The benefit is not clear. > > How do you think about to reduce the source code a bit at these places? hostap is an obsolete driver, it's waste of time doing style fixes to it as nobody maintains it anymore. -- Kalle Valo

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

Joe Perches <j...@perches.com> writes: > On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: >> hostap is an obsolete driver, it's waste of time doing style fixes to it >> as nobody maintains it anymore. > > Dunno know if Jouni is still maintaining this at all >

Re: [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring 2

pull-request: wireless-drivers-next 2016-09-29

Malinen (1): MAINTAINERS: hostap: Mark the Host AP driver obsolete Kalle Valo (4): Merge tag 'iwlwifi-next-for-kalle-2016-09-15-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge tag 'iwlwifi-next-for-kalle-2016-09-19-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ta

Re: pull-request: wireless-drivers-next 2016-09-29

Aaron Conole <acon...@redhat.com> writes: > David Miller <da...@davemloft.net> writes: > >> From: Kalle Valo <kv...@codeaurora.org> >> Date: Thu, 29 Sep 2016 19:57:28 +0300 >> > ... >>> Or actually I had one problem. While doing a test mer

Re: Regression in next with ext4 oops

Tony Lindgren <t...@atomide.com> writes: > * Kalle Valo <kv...@codeaurora.org> [161004 12:42]: >> Tony Lindgren <t...@atomide.com> writes: >> >> > And the patch below seems to fix the issue as the driver is now >> > using devm_kzalloc. Will do

Re: Regression in next with ext4 oops

wlcore driver or with SDIO/MMC. Or maybe it's a memory >> corruption issue. I don't know yet exactly what's going on here yet but >> I plan to find out after some lunch. > > And the patch below seems to fix the issue as the driver is now > using devm_kzalloc. Will do some more testing and then will post > a proper patch. The same issue might be there for SPI glue also. This was already posted and you even acked it :) wlcore: sdio: drop kfree for memory allocated with devm_kzalloc https://patchwork.kernel.org/patch/9353985/ -- Kalle Valo

Re: [PATCH 2/4] carl9170: fix debugfs crashes

gt; This breakage was caused by the introduction of intermediate >> fops in debugfs by commit 9fd4dcece43a >> ("debugfs: prevent access to possibly dead file_operations at file open") > > Because of this, these should all be backported to 4.7-stable, and > 4.8-stable, right? Via which tree should these go, Greg's or mine? -- Kalle Valo

Re: [PATCH 2/4] carl9170: fix debugfs crashes

Greg KH <gre...@linuxfoundation.org> writes: > On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote: >> Greg KH <gre...@linuxfoundation.org> writes: >> >> > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote: >> >> Ben Gr

pull-request: wireless-drivers 2016-09-20

frames Beni Lev (1): iwlwifi: mvm: update TX queue before making a copy of the skb Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-09-15' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/intel

Re: checkkpatch (in)sanity ?

MPARISON', 'MACRO_WITH_FLOW_CONTROL' Currently my workaround is to have a custom ath10k-check script[1] which runs checkpatch with those checks disabled. Oh, and it also filters out some of the warnings based on the symbol it is located in. https://github.com/qca/qca-swiss-army-knife/blob/master/tools/scripts/ath10k/ath10k-check -- Kalle Valo

Re: [PATCH linux-firmware] rt2870sta: Update rt3071.bin to match rt2870.bin

1 file changed, 0 insertions(+), 0 deletions(-) Please CC linux-wireless on wireless related changes. Not everyone follow lkml. -- Kalle Valo

Re: [BUGFIX, 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

mhira...@kernel.org wrote: > Check rtnl_lock is locked in brcmf_p2p_ifp_removed() by passing > rtnl_locked flag. Actually the caller brcmf_del_if() checks whether > the rtnl_lock is locked, but doesn't pass it to brcmf_p2p_ifp_removed(). > > Without this fix, wpa_supplicant goes softlockup with

Re: [PATCH] fix:gpio: mark symbols static where possible

io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The commit title should be: ath9k: mark ath_fill_led_pin() static Check the wiki how to create titles: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo

Re: [v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Stephan Mueller wrote: > The ATH9K driver implements an RNG which is completely bypassing the > standard Linux HW generator logic. > > The RNG may or may not deliver entropy. Considering the conservative > approach in treating entropy with respect to non-auditable sources,

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

;> I'd like to get it for 4.9 however, as this fixes bug that could lead >> to WARNING on every add_key/del_key call. We was struggling with these >> WARNINGs for some time and this fixes one of two problems causing them. Ok, I'll queue this for 4.9. > Please mark it for stable as well. I can add that. Any ideas how old releases stable releases should this go to? -- Kalle Valo

Re: [1/3] ath10k: use devm_clk_get() instead of clk_get()

Masahiro Yamada wrote: > Use the managed variant of clk_get() to simplify the failure path > and the .remove callback. > > Signed-off-by: Masahiro Yamada 3 patches applied to ath-next branch of ath.git, thanks. 828662753d60 ath10k:

Re: ath10k: Spelling and miscellaneous neatening

Joe Perches wrote: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches > Reviewed-by: Julian Calaby

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

nt idea but no luck: Signed-off-by: Rafa? Mi?ecki <ra...@milecki.pl> Acked-by: Arend van Spriel <ar...@broadcom.com> I'll add this to my patchwork wishlist though, I think it would be a really useful feature to have. (The question marks are because of my buggy copy paste, ignore those) -- Kalle Valo

Re: rtlwifi: Add switch variable to 'switch case not processed' messages

Joe Perches wrote: > Help along debugging by showing what switch/case variable is not > being processed in these messages. > > Signed-off-by: Joe Perches > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks.

Re: brcmfmac: replace WARNING on timeout with a simple error message

Rafał Miłecki wrote: > From: Rafał Miłecki > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover and > for that time it

Re: [V2, 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting for transmission that were passed to us > by netif. It means we checked every one of them looking for 802.1x > Ethernet type. When deleting flowring we have to use freeing function > that will check

Re: [1/3] hostap: Use memdup_user() rather than duplicating its implementation

SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:19:43 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the

Re: [19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman <hante.meule...@broadcom.com> >

pull-request: wireless-drivers-next 2016-10-30

Berg (1): iwlwifi: pcie: mark command queue lock with separate lockdep class Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-10-25' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Luca Coelho (4): iwlwifi: mvm: use ssize_t for len in iwl_debugfs_mem_read() iwlwifi: mvm

Re: [v2] cw1200: Don't leak memory if krealloc failes

Johannes Thumshirn wrote: > The call to krealloc() in wsm_buf_reserve() directly assigns the newly > returned memory to buf->begin. This is all fine except when krealloc() > failes we loose the ability to free the old memory pointed to by > buf->begin. If we just create a

Re: [PATCH] wireless: fix bogus maybe-uninitialized warning

1->addr2, ETH_ALEN); /* SA */ > break; Ideally we prefer that drivers/net/wireless and net/wireless changes are split into different patches as they get applied to different trees. Johannes, is it ok if I take this change through my tree this time? -- Kalle Valo

Re: brcmfmac: proto: add callback for queuing TX data

Rafał Miłecki wrote: > From: Rafał Miłecki > > So far our core code was calling brcmf_fws_process_skb which wasn't > a proper thing to do. If case of devices using msgbuf protocol fwsignal > shouldn't be used. It was an unnecessary extra layer simply calling > a protocol

Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

vger.kernel.org> I'm planning to push this to 4.9 if no objections. -- Kalle Valo

pull-request: wireless-drivers 2016-10-14

Hi Dave, first wireless-drivers pull request for 4.9 and this time we have unusually many fixes even before -rc1 is released. Most important here are the wlcore and rtlwifi commits which fix critical regressions, otherwise smaller impact fixes and one new sdio id for ath6kl. Please let me know

Regression: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

when > CONFIG_MODVERSIONS=y. > > Signed-off-by: Adam Borowski <kilob...@angband.pl> > Tested-by: Kalle Valo <kv...@codeaurora.org> > Acked-by: Nicholas Piggin <npig...@gmail.com> > Tested-by: Peter Wu <pe...@lekensteyn.nl> > Tested-by: Oliver Hartkopp <

pull-request: wireless-drivers-next 2016-11-25

irn (1): cw1200: Don't leak memory if krealloc failes Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-10-25-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Merge ath-next from git://git.kernel.org/.../kv

Re: linux-next: build warning after merge of the wireless-drivers-next tree

Barry Day <brise...@gmail.com> writes: > On Mon, Nov 28, 2016 at 09:25:30AM +0200, Kalle Valo wrote: >> Stephen Rothwell <s...@canb.auug.org.au> writes: >> >> > Hi all, >> > >> > After merging the wireless-drivers-next tree, today'

Re: linux-next: build warning after merge of the wireless-drivers-next tree

> Introduced by commit > > b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order to have > access to retry count") > > This is a correct diagnosis. Thanks for the report. Jes, can you send a patch to fix this? (Unless someone else beats to it.) -- Kalle Valo

Re: wireless: fix bogus maybe-uninitialized warning

Arnd Bergmann wrote: > The hostap_80211_rx() function is supposed to set up the mac addresses > for four possible cases, based on two bits of input data. For > some reason, gcc decides that it's possible that none of the these > four cases apply and the addresses remain

Re: p54: memset(0) whole array

t; [-Wmemset-elt-size] > > Fix that by passing the correct size to memset. > > Signed-off-by: Jiri Slaby <jsl...@suse.cz> > Cc: Christian Lamparter <chunk...@googlemail.com> > Cc: Kalle Valo <kv...@codeaurora.org> > Cc: linux-wirel...@vger.kernel.org > Cc

Re: brcmfmac: print name of connect status event

Rafał Miłecki wrote: > From: Rafał Miłecki > > This simplifies debugging. Format %s (%u) comes from similar debugging > message in brcmf_fweh_event_worker. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. e1c122d55f9e

Re: [v2] cw1200: fix bogus maybe-uninitialized warning

Arnd Bergmann wrote: > On x86, the cw1200 driver produces a rather silly warning about the > possible use of the 'ret' variable without an initialization > presumably after being confused by the architecture specific definition > of WARN_ON: > >

Re: wlcore: Allow scans when in AP mode

Xander Huff wrote: > From: James Minor > > When in AP mode, scans can be done without changing firmware to > the multi-role firmware. Allow the interface to scan if forced > in the scan request. > > Signed-off-by: James Minor >

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled > smem_state") > Acked-by: Andy Gross

Re: [4.9.0-rc5] AR9300 calibration problems with antenna selected

Krzysztof wrote: > Hi, > > I recently tried to select a single antenna on AR9300 and it works for > 30 seconds only. The subsequent calibration makes the RX signal level to > drop from the usual -30/-40 dBm to -70/-80 dBm, and the transmission > practically stops. > > With the attached patch it

Re: mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

Ricky Liang wrote: > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32

Re: mwifiex: printk() overflow with 32-byte SSIDs

Brian Norris wrote: > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length > when we print them out. > > This can be easily noticed by connecting to a network with a 32-octet > SSID: > > [ 3903.502925] mwifiex_pcie :01:00.0: info: trying to

Re: [1/1] ath10k: use the right length of "background"

Nicolas Iooss wrote: > The word "background" contains 10 characters so the third argument of > strncmp() need to be 10 in order to match this prefix correctly. > > Signed-off-by: Nicolas Iooss > Fixes: 855aed1220d2 ("ath10k: add spectral

Re: ath9k_htc: fix minor mistakes in dev_err messages

Colin Ian King wrote: > From: Colin Ian King > > Add missing space in a dev_err message and join wrapped text so > it does not span multiple lines. Fix spelling mistake on "unknown". > > Signed-off-by: Colin Ian King

Re: mwifiex: don't do unbalanced free()'ing in cleanup_if()

Brian Norris wrote: > The cleanup_if() callback is the inverse of init_if(). We allocate our > 'card' interface structure in the probe() function, but we free it in > cleanup_if(). That gives a few problems: > (a) we leak this memory if probe() fails before we reach

Re: pull-request: wireless-drivers-next 2016-10-30

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Sun, 30 Oct 2016 11:20:46 +0200 > >> few fixes for 4.9. I tagged this on the plane over a slow mosh >> connection while travelling to Plumbers so I might have done some

Re: [GIT PULL] kbuild changes for v4.9-rc1

Nicholas Piggin <npig...@gmail.com> writes: > On Thu, 27 Oct 2016 11:10:03 +0300 > Kalle Valo <kv...@codeaurora.org> wrote: > >> (Adding Thorsten because of a serious regression and Steven because he >> tried to fix something in the same commit) >> >&g

Re: [GIT PULL] kbuild changes for v4.9-rc1

r -22) [ 110.703688] bluetooth: disagrees about version of symbol mcount [ 110.703689] bluetooth: Unknown symbol mcount (err -22) -- Kalle Valo

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman <hante.meule...@broadcom.com> >

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

Arnd Bergmann <a...@arndb.de> writes: > On Wednesday, October 26, 2016 9:49:58 AM CEST Kalle Valo wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >> > A bugfix added a sanity check around the assignment and use of the >> > 'is_11d' variable, w

Re: ATH9 driver issues on ARM64

0 GICv2 160 Level > zynqmp-dma > 17: 0 0 0 0 GICv2 161 Level > zynqmp-dma > 18: 0 0 0 0 GICv2 162 Level > zynqmp-dma > 19: 0 0 0 0 GICv2 163 Level > zynqmp-dma > 20: 0 0 0 0 GICv2 164 Level > Mali_GP_MMU, Mali_GP, Mali_PP0_MMU, Mali_PP0, Mali_PP1_MMU, Mali_PP1 > 30: 0 0 0 0 GICv2 95 Level > eth0, eth0 > 206:314 0 0 0 GICv2 49 Level > cdns-i2c > 207: 40 0 0 0 GICv2 50 Level > cdns-i2c > 209: 0 0 0 0 GICv2 150 Level > nwl_pcie:misc > 214: 12 0 0 0 GICv2 47 Level > ff0f.spi > 215: 0 0 0 0 GICv2 58 Level > ffa6.rtc > 216: 0 0 0 0 GICv2 59 Level > ffa6.rtc > 217: 0 0 0 0 GICv2 165 Level > ahci-ceva[fd0c.ahci] > 218: 61 0 0 0 GICv2 81 Level mmc0 > 219: 0 0 0 0 GICv2 187 Level > arm-smmu global fault > 220:471 0 0 0 GICv2 53 Level > xuartps > 223: 0 0 0 0 GICv2 154 Level > fd4c.dma > 224: 3 0 0 0 dummy 1 Edge ath9k > 225: 0 0 0 0 GICv2 97 Level > xhci-hcd:usb1 > > Regards, > Bharat -- Kalle Valo

Re: [PATCH] ath9k: unlock rcu read when returning early

A fixes line and cc stable would be good to have: Fixes: d94a461d7a7d ("ath9k: use ieee80211_tx_status_noskb where possible") Cc: <sta...@vger.kernel.org> # v4.9 I can add those. I'm planning to push this to 4.10 but would prefer to see an ack from Felix (the author of d94a461d7a7d) first. I added him to Cc. -- Kalle Valo

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

I'm just wondering should I push this to 4.10 or -next. This is a driver for ancient hardware so I'm starting to lean for -next. -- Kalle Valo

<    2   3   4   5   6   7   8   9   10   11   >