Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN?

others as well! We have the same problem also on ath10k :) And it's confusing users a lot, especially as we also load calibration file and other files. So yes, something like this is very much needed. But in ath10k we use request_firmware() instead request_firmware_nowait(). So I would appreciate if you could add the support to both variants. -- Kalle Valo

Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations

Andy Lutomirski <l...@amacapital.net> writes: > On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Andy Lutomirski <l...@kernel.org> writes: >> >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>

Re: [PATCH v3] add equivalent of BIT(x) for bitfields

are not constants as > proposed by Linus. > Indeed, 'lsb' is used twice so it cannot have side-effects; > 'msb' is subjected to same constraints for consistency. (I missed there was v3 already, but I'll repeat what I said in v1.) Please check FIELD_PREP() from include/linux/bitfield.h, doesn't it already do the same? Adding Jakub to comment more. -- Kalle Valo

Re: [PATCH] bitops: add equivalent of BIT(x) for bitfields

,0xff) = 0xff00 > + * SETBITFIELD(6, 6, 1) = 0x0040 == BIT(6) > + */ > +#define SETBITFIELD(msb, lsb, val) \ > + (((val) << (lsb)) & (GENMASK((msb), (lsb > +#define SETBITFIELD_ULL(msb, lsb, val) \ > + (((val) << (lsb)) & (GENMASK_ULL((msb), (lsb > +#endif Pleaes check FIELD_PREP() from include/linux/bitfield.h, doesn't it already do the same? Adding Jakub to comment more. -- Kalle Valo

Re: [PATCH 1/1] net: wireless: intersil: fix improper return value

t;orinoco:", more info: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo

Re: wl1251 & mac address & calibration data

from user space (if device tree is not available), I just don't know what that could be :) But if we would start to use request_firmware() for this at least there should be a wider concensus about that and it should be properly documented, just like the device tree bindings. -- Kalle Valo

Re: [GIT] Networking

t was a critical fix. Sorry about that, I'll send a new pull request to Dave first thing tomorrow. It's too late now for me. -- Kalle Valo

Re: [1/2] ath9k: ar9002_mac: kill off ACCESS_ONCE()

gt; > > virtual patch > > @ depends on patch @ > expression E1, E2; > @@ > > - ACCESS_ONCE(E1) = E2 > + WRITE_ONCE(E1, E2) > > @ depends on patch @ > expression E; > @@ > > - ACCESS_ONCE(E) > + READ_ONCE(E) > > > Signed-off-by: Mark Ru

Re: net: wireless: ath: wil6210: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled > smem_state") > Acked-by: Andy Gross

Re: ath9k: fix spelling mistake: "meaurement" -> "measurement"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath_err message > > Signed-off-by: Colin Ian King Patch applied to ath-next branch of ath.git, thanks. 714ee339ff90 ath9k: fix

Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

iver's private data, and vice versa. The USB driver failed to store the address of ieee80211_hw in the private data. Although this bug has been present for a long time, it was not exposed until commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"). Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save") Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Signed-off-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo

Re: linux-next: build warning after merge of the wireless-drivers-next tree

t; 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag") > > This is not a false positive since "reg" could be NULL just above > (otherwise it would be tested for). Thanks, I noticed this myself yesterday (after I had applied the patch) and I have asked Marvell to send a fix. -- Kalle Valo

pull-request: wireless-drivers 2017-01-10

Hi Dave, here's the pull request with the important rtlwifi fix, more info in the tag below. During the long weekend we had here I finally updated Ubuntu on my workstation and git was updated along that. If you see anything funny or problems in my pull request due to the upgrade, please let me

pull-request: wireless-drivers-next 2016-12-01

rates from mac80211 rtl8xxxu: Pass tx_info to fill_txdesc in order to have access to retry count rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconnecting Jiri Slaby (1): bcma: add Dell Inspiron 3148 Kalle Valo (1): Merge ath-next from git://git.kernel.org/.

pull-request: wireless-drivers 2016-11-29

Hi Dave, if there's still time here's one more patch to 3.9. I think this is good to have in 3.9 as it fixes an issue where we were printing uninitialised memory in mwifiex. I had this in wireless-drivers already for some time as I was waiting for other fixes and nothing serious actually came up.

Re: mwifiex: pcie: implement timeout loop for FW programming doorbell

Brian Norris wrote: > Marvell Wifi PCIe modules don't always behave nicely for PCIe power > management when their firmware hasn't been loaded, particularly after > suspending the PCIe link one or more times. When this happens, we might > end up spinning forever in this

Re: bcma: add Dell Inspiron 3148

Jiri Slaby wrote: > This is what is in the laptop: > 01:00.0 Network controller [0280]: Broadcom Limited BCM43142 802.11b/g/n > [14e4:4365] (rev 01) > Subsystem: Dell Device [1028:0018] > Flags: bus master, fast devsel, latency 0, IRQ 18 > Memory at

Re: adm80211: add checks for dma mapping errors

Alexey Khoroshilov wrote: > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Patch

Re: pull-request: wireless-drivers 2016-11-29

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 29 Nov 2016 16:59:44 +0200 > >> if there's still time here's one more patch to 3.9. I think this is good >> to have in 3.9 as it fixes an issue where we were

Re: wireless: ath: ath9k: constify ath_bus_ops structure

Bhumika Goyal wrote: > Declare the structure ath_bus_ops as const as it is only passed as an > argument to the function ath9k_init_device. This argument is of type > const struct ath_bus_ops *, so ath_bus_ops structures with this property > can be declared as const. > Done

Re: ath5k: drop duplicate header vmalloc.h

Geliang Tang wrote: > Drop duplicate header vmalloc.h from ath5k/debug.c. > > Signed-off-by: Geliang Tang Patch applied to ath-next branch of ath.git, thanks. 384abd33d5d5 ath5k: drop duplicate header vmalloc.h --

Re: [PATCH 23/39] Annotate hardware config module parameters in drivers/net/wireless/

ivers/net/wireless/. > > Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Kalle Valo <kv...@codeaurora.org> > cc: linux-wirel...@vger.kernel.org > cc: net...@vger.kernel.org > --- > > drivers/net/

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

t; complex conflicts. The fix looks good, thanks. I sent a pull request to Dave yesteday which should fix this. -- Kalle Valo

Re: orinoco: Use shash instead of ahash for MIC calculations

Andrew Lutomirski wrote: > Eric Biggers pointed out that the orinoco driver pointed scatterlists > at the stack. > > Fix it by switching from ahash to shash. The result should be > simpler, faster, and more correct. > > Cc: sta...@vger.kernel.org # 4.9 only > Reported-by: Eric

Re: brcmfmac: fix spelling mistakes on "Ivalid"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fixes to spelling mistake "Ivalid" to "Invalid" in > brcmf_err error messages. > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel

Re: orinoco: Use shash instead of ahash for MIC calculations

Kalle Valo <kv...@codeaurora.org> writes: > Andrew Lutomirski <l...@kernel.org> wrote: >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >>

Re: rtlwifi: fix spelling mistake: "contry" -> "country"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Patch applied to

Re: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: orinoco: Use shash instead of ahash for MIC calculations

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Andrew Lutomirski <l...@kernel.org> wrote: >>> Eric Biggers pointed out that the orinoco driver pointed scatterlists >>> at the stack. >>> >&g

Re: net: wireless: ath: wil6210: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

Larry Finger wrote: > These drivers need to be able to reference "struct ieee80211_hw" from > the driver's private data, and vice versa. The USB driver failed to > store the address of ieee80211_hw in the private data. Although this > bug has been present for a long

Re: net: wireless: marvell: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: [PATCH][V2] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

ical.com> > --- > drivers/media/usb/dvb-usb/gp8psk.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Could you split the rtlwifi part to it's own patch? I can't apply patches touching media drivers. -- Kalle Valo

pull-request: wireless-drivers-next 2017-01-02

) fails Johannes Berg (1): iwlegacy: make il3945_mac_ops __ro_after_init Kalle Valo (1): Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Larry Finger (14): rtlwifi: Replace local debug macro RT_ASSERT rtlwifi: Remove RT_TRACE messages that use DBG_EMERG

Re: wlcore: fix spelling mistake in wl1271_warning

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake of function name in wl1271_warning, > should be dynamic_ps_timeout instead of dyanmic_ps_timeout. > > Signed-off-by: Colin Ian King

Re: [V3] rtlwifi: fix spelling mistake: "encrypiton" -> "encryption"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. e16e558e83ed rtlwifi: fix

Re: [GIT] Networking

er's private data 22b68b93ae25 rtlwifi: Fix kernel oops introduced with commit e49656147359 You should have 22b68b93ae25 in your tree, but not 60f59ce02785. The reason why you didn't get 60f59ce02785 in my pull request was that I committed it late: commit 60f59ce0278557f7896d5158ae6d12a4855a72cc A

Re: wl1251 & mac address & calibration data

Tony Lindgren <t...@atomide.com> writes: > * Kalle Valo <kv...@codeaurora.org> [161220 03:47]: >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >> >> > On 18-12-2016 13:09, Pali Rohár wrote: >> > >> >> File wl

Re: rtlwifi: Fix kernel oops introduced with commit e49656147359

Larry Finger wrote: > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of > kfree_skb"), the method used to free an skb was changed because the > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() > guards against a NULL value for

Re: [v2] ath9k: do not return early to fix rcu unlocking

Tobias Klausmann wrote: > Starting with commit d94a461d7a7d ("ath9k: use ieee80211_tx_status_noskb > where possible") the driver uses rcu_read_lock() && rcu_read_unlock(), yet on > returning early in ath_tx_edma_tasklet() the unlock is missing leading to >

Re: wl1251 & mac address & calibration data

ta;h=97875bd79a579a0010da3f60324b6ec966fe9c6a;hb=HEAD > But yeah, the default one from linux-firmware should never have been > there in the first place. Agreed. -- Kalle Valo

Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

uawei.com> > --- > Kalle, > > This change should be sent to mainline during the 4.10 merge period, > or as soon as possible. Ok, I'll queue this to 4.10. Most likely I'll send a pull request to Dave later this week or so. -- Kalle Valo

Re: Intel Wireless 7260 failed to work

Luca Coelho <l...@coelho.fi> writes: > On Wed, 2016-12-28 at 11:59 +0800, Peter Xu wrote: >> On Tue, Dec 27, 2016 at 09:46:55PM +0200, Kalle Valo wrote: >> > Peter Xu <pet...@redhat.com> writes: >> > >> > > Looks like latest Linux master (

Re: Intel Wireless 7260 failed to work

em." https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4b87e5af638b6056bd6c20b0954d09a5a58633be Adding luca. -- Kalle Valo

pull-request: wireless-drivers 2016-12-22

Hi Dave, before the holidays a really small pull request for 4.10. I just want to have the regressions in rtlwifi and ath9k fixed quickly so I send this earlier than I normally would. Please let me know if there are any problems. Kalle The following changes since commit

pull-request: wireless-drivers 2017-03-21

Hi Dave, few smallish fixes for 4.11. Please let me know if there are any problems. Kalle The following changes since commit 22a0e18eac7a9e986fec76c60fa4a2926d1291e2: net: properly release sk_frag.page (2017-03-15 15:37:45 -0700) are available in the git repository at:

Re: ath10k: remove redundant error check

Colin Ian King wrote: > From: Colin Ian King > > The check on ret for an error is redundant because it is already been > checked for non-zero earlier on and ret is never non-zero at this point. > Fix this by removing the redundant check and

Re: [1/4] mwifiex: pcie: don't leak DMA buffers when removing

Brian Norris wrote: > When PCIe FLR support was added, much of the remove/release code for > PCIe was migrated to ->down_dev(), but ->down_dev() is never called for > device removal. Let's refactor the cleanup to be done in both cases. > > Also, drop the comments above

Re: ath10k: remove redundant check of len with buf_len

Colin Ian King wrote: > From: Colin Ian King > > The check of len > buf_len is redundant as len is initialized > to 0 and buf_len to 4096, so this comparison is always false. > Remove it. > > Signed-off-by: Colin Ian King

Re: [PATCH] MAINTAINERS: Add the DT binding to the ath9k file list

d this to linux-wireless mailing list, otherwise patchwork won't see it. -- Kalle Valo

Re: [3/3] mwifiex: wake system up when receives a wake irq

Jeffy Chen wrote: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

Brian Norris wrote: > This code was duplicated as part of the PCIe FLR code added to this > driver. Let's de-duplicate it to: > > * make things easier to read (mwifiex_pcie_free_buffers() now has a >corresponding mwifiex_pcie_alloc_buffers()) > * reduce likelihood

Re: ipw2200: remove redundant check of rc < 0

Colin Ian King wrote: > From: Colin Ian King > > The check for rc < 0 is always false so the check is redundant > and can be removed. > > Detected with CoverityScan, CID#101143 ("Logically dead code") > > Signed-off-by: Colin Ian King

Re: [v3] mwifiex: fix kernel crash after shutdown command timeout

Brian Norris wrote: > We observed a SHUTDOWN command timeout during reboot stress test due to > a corner case firmware bug. It can lead to either a use-after-free + > OOPS (on either the adapter structure, or the 'card' structure) or an > abort (where, e.g., the PCI

Re: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

Brian Norris wrote: > We shouldn't be printing a kernel pointer as a decimal integer. But we > really shouldn't be printing this case at all; we should never get here > with NULL drvdata. We've eliminated this unnecessary conditional in > several other places, so kill it

Re: [2/2] zd1211rw: fix NULL-deref at probe

Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

Brian Norris <briannor...@chromium.org> writes: > On Mon, Mar 20, 2017 at 05:08:35PM +0000, Kalle Valo wrote: >> Brian Norris <briannor...@chromium.org> wrote: >> > This code was duplicated as part of the PCIe FLR code added to this >> > driver. Let's de-dup

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

| 11 --- >> net/qrtr/Kconfig | 2 +- >> net/qrtr/smd.c | 42 - >> 13 files changed, 108 insertions(+), 104 deletions(-) > > I think that it is best if Dave takes these directly then and I pu

Re: [2/2] zd1211rw: fix NULL-deref at probe

Johan Hovold <jo...@kernel.org> writes: > On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote: >> Johan Hovold <jo...@kernel.org> wrote: >> > Make sure to check the number of endpoints to avoid dereferencing a >> > NULL-pointer or accessing

pull-request: wireless-drivers-next 2017-04-03

bytes to debugfs causes a crash Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-03-29' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1): rtlwifi: Fix scheduling while atomic splat Liad Kaufman (1): iwlwifi: mvm: support ibss in dqa mode Sara Sharon (1

Re: [PATCH 15/16] drivers, net, intersil: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t

ireless/intersil/hostap/hostap_hw.c | 12 ++-- > drivers/net/wireless/intersil/hostap/hostap_wlan.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) The prefix should be "hostap:", I'll fix that. -- Kalle Valo

Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

less/intersil/orinoco/orinoco_usb.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) The prefix should be "orinoco_usb:", I'll fix that. -- Kalle Valo

Re: [PATCH RFC] remove custom Michael MIC implementation

g points to get familiar with the stack. And I guess you already saw the documentation: https://wireless.wiki.kernel.org/en/developers/documentation/mac80211 -- Kalle Valo

Re: [1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") > Cc:

Re: [PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices

'm just guessing. > Signed-off-by: Alban <al...@free.fr> Please use your full name both in From and S-o-b lines. -- Kalle Valo

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold <jo...@kernel.org> writes: > On Mon, Apr 03, 2017 at 01:02:28PM +0000, Kalle Valo wrote: >> Kalle Valo <kv...@codeaurora.org> writes: >> >> > Johan Hovold <jo...@kernel.org> writes: >> > >> >> On Mon, Mar 13, 2017 at

Re: [PATCH 1/3] rsi: Rename the file rsi_91x_pkt.c to rsi_91x_hal.c

ice > (frimware understandable) specific descriptors for the transmit frames, > it is moved to 'rsi_91x_hal.c' > > Signed-off-by: Prameela Rani Garnepudi <prameela.j0...@gmail.com> Always remember CC linux-wireless for wireless patches. So please resend. -- Kalle Valo

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Kalle Valo <kv...@codeaurora.org> writes: > Johan Hovold <jo...@kernel.org> writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessi

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

, I'm just lacking behing: https://patchwork.kernel.org/patch/9620723/ > As I mentioned earlier, I should have added a > > Cc: stable <sta...@vger.kernel.org> # 2.6.39 > > but left it out as I mistakingly thought the net recommendations to do > so applied also to wireless. Ok, I'll add that. -- Kalle Valo

Re: pull-request: wireless-drivers-next 2017-04-03

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Mon, 03 Apr 2017 14:26:10 +0300 > >> here few really small fixes. I'm hoping this to be the last pull request >> for 4.11. >> >> Please let me if there ar

Re: [PATCH] mwifiex: MAC randomization should not be persistent

romium.org> > --- > Should this be tagged for -stable? IMHO yes. -- Kalle Valo

Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

amit karwar <amitkar...@gmail.com> writes: > On Thu, Apr 13, 2017 at 6:47 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> Brian Norris <briannor...@chromium.org> writes: >> >>> His email is bouncing, and I expect he's not doing this work any m

Re: ath9k: Add cast to u8 to FREQ2FBIN macro

Matthias Kaehlcke wrote: > The macro results are assigned to u8 variables/fields. Adding the cast > fixes plenty of clang warnings about "implicit conversion from 'int' to > 'u8'". > > Signed-off-by: Matthias Kaehlcke Patch applied to ath-next branch of

pull-request: wireless-drivers-next 2017-04-21

/lower_32_bits where appropriate iwlwifi: pcie: use iwl_get_dma_hi_addr() iwlwifi: pcie: fix mutex leak in gen2 start iwlwifi: pcie: free context info in case of failures Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2017-04-13' of git://git.kernel.org/.../iwlwifi/iwlwifi-next

Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

> > Cc: Xinming Hu <h...@marvell.com> > Signed-off-by: Brian Norris <briannor...@chromium.org> > --- > Or alternatively, we can update his email address. I just don't want to keep > seeing bounced emails :) Me neither :) So Amitkumar, which one do you prefer? -- Kalle Valo

Re: [PATCH] mwifiex: MAC randomization should not be persistent

Brian Norris <briannor...@chromium.org> writes: > On Thu, Apr 06, 2017 at 07:02:15AM +0300, Kalle Valo wrote: >> Brian Norris <briannor...@chromium.org> writes: >> >> > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan >> > r

Re: ath6kl: Add __printf verification to ath6kl_dbg

Joe Perches wrote: > Fix fallout too. > > Signed-off-by: Joe Perches > Reviewed-by: Steve deRosier Patch applied to ath-next branch of ath.git, thanks. 169345d40d0f ath6kl: add __printf verification to ath6kl_dbg --

Re: [PATCH net-next] brcmfmac: fix build without CONFIG_BRCMFMAC_PROTO_BCDC

a from struct > brcmf_pub") > Signed-off-by: Arnd Bergmann <a...@arndb.de> The fix is actually for wireless-drivers-next, acf8ac41dd73 is not in net-next yet. And I already applied an identical fix from Arend: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=26ecfe01790381c4caa65ec9cce484c623f092c4 -- Kalle Valo

Re: mwifiex: MAC randomization should not be persistent

Brian Norris wrote: > nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan > request that should be randomized; the absence of such a flag means we > should not randomize. However, mwifiex was stashing the latest > randomization request and *always* using it

Re: [v2] MAINTAINERS: update Amitkumar's email address

Brian Norris wrote: > His email is bouncing, and he'd like to use this new one. > > Cc: Amitkumar Karwar > Cc: Nishant Sarmukadam > Cc: Ganapathi Bhat > Cc: Xinming Hu > Signed-off-by:

Re: [1/4] mwifiex: pcie: fix cmd_buf use-after-free in remove/reset

Brian Norris wrote: > Command buffers (skb's) are allocated by the main driver, and freed upon > the last use. That last use is often in mwifiex_free_cmd_buffer(). In > the meantime, if the command buffer gets used by the PCI driver, we map > it as DMA-able, and store

Re: ath9k_htc: Add support of AirTies 1eda:2315 AR9271 device

Dmitry Tunin wrote: > T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=01 Dev#= 7 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=ff Prot=ff MxPS=64 #Cfgs= 1 > P: Vendor=1eda ProdID=2315 Rev=01.08 > S: Manufacturer=ATHEROS > S: Product=USB2.0 WLAN > S: SerialNumber=12345 >

Re: wcn36xx: Fix error handling

Christophe Jaillet wrote: > Reorder 'out_free_dxe_pool' and 'out_free_dxe_ctl' error handling labels > in order to match the way resources have been allocated. > > Signed-off-by: Christophe JAILLET Patch applied to ath-next branch

Re: rtlwifi: fix spelling mistake: "conuntry" -> "country"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 3e062eb21df8 rtlwifi: fix

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

ables as >> 'static const' as I can without changing the actual code. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Arnd, via which tree are you planning to submit these? I'm not sure what I should do with the wireless drivers patches from this series. -- Kalle Valo

Re: [PATCH 10/26] brcmsmac: reindent split functions

c| 1507 >> +--- >> 1 file changed, 697 insertions(+), 810 deletions(-) >> Arend, please edit your quotes. Leaving 1000 lines of unnecessary quotes in your reply makes my use of patchwork horrible: https://patchwork.kernel.org/patch/9601155/ -- Kalle Valo

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

Arnd Bergmann <a...@arndb.de> writes: > On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >> >>> On 2-3-2017 17:38, Arnd Bergmann wrote: >>>> With KASAN and

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

UD, >> - " ===> althougth Path A, we load radiob.txt\n"); >> + " ===> though Path A, we load radiob.txt\n"); Wasn't this supposed to be "through"? Or did I miss something? -- Kalle Valo

Re: [PATCH RFC] remove custom Michael MIC implementation

driver and get out of staging :) So next step > is I guess study the ath6kl driver, learn how CFG80211 is done and > implement that interface in ks7010? Oh, and test that it works. Please keep linux-wireless list in loop so that people on that list can help. -- Kalle Valo

Re: pull-request: wireless-drivers-next 2017-04-03

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 04 Apr 2017 20:48:35 +0300 > >> David Miller <da...@davemloft.net> writes: >> >>> From: Kalle Valo <kv...@codeaurora.org> >>> Date:

Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

), 7 deletions(-) >> >> The prefix should be "orinoco_usb:", I'll fix that. > > Thanks for both! Will you take the patches in? You mean patches 15 and 16? I didn't even look rest of the patches. But not sure yet because Dave doesn't seem to like the interface and I want to follow the discussion first. -- Kalle Valo

Re: [1/2] mwifiex: fix use-after-free for FW reinit errors

Brian Norris wrote: > If we fail to reinit the FW when resetting the device (in the > synchronous version of mwifiex_init_hw_fw() -> mwifiex_fw_dpc()), > mwifiex_fw_dpc() will tear down the interface and free up the adapter. > But we don't actually check for all failure

Re: [V2] wlcore: fix spelling mistakes in wl1271_warning

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistakes in wl1271_warning error message, change > iligal to invalid and opperation to operation. > > Signed-off-by: Colin Ian King Patch

pull-request: wireless-drivers-next 2017-04-07

print the firmware version as an error brcmfmac: Do not complain about country code "00" brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler Jeffy Chen (1): mwifiex: wake system up when receives a wake irq Johan Hovold (1): zd1211rw: fi

pull-request: wireless-drivers-next 2017-07-28

Hi Dave, here's a pull request for net, more info the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: Merge tag 'iwlwifi-for-kalle-2017-07-21' of

Re: pull-request: wireless-drivers-next 2017-07-28

Kalle Valo <kv...@codeaurora.org> writes: > Hi Dave, > > here's a pull request for net, more info the signed tag below. Please > let me know if there are any problems. > > Kalle > > The following changes since commit d755cbc26e8295ae8e5d30425364e093b4247a85: >

Re: zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in PDEBUG debug message. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. af643fe9bbe0

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Arvind Yadav <arvind.yadav...@gmail.com> wrote: > >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work >> with const attribute_group. So

Re: [v3,04/10] ipw2200: constify attribute_group structures

Kalle Valo <kv...@codeaurora.org> writes: > Kalle Valo <kv...@codeaurora.org> writes: > >> Arvind Yadav <arvind.yadav...@gmail.com> wrote: >> >>> attribute_group are not supposed to change at runtime. All functions >>> working with attribute_

<    3   4   5   6   7   8   9   10   11   12   >