Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-29 Thread Kevin Chowski
I am incentivized to not drop the ball after fixing my immediate Pixelbook problem :) On Fri, Sep 25, 2020 at 10:53 AM Lyude Paul wrote: > > On Thu, 2020-09-24 at 17:46 -0600, Kevin Chowski wrote: > > cc back a few others who were unintentionally dropped from the thread > > earlier

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-24 Thread Kevin Chowski
0x83), PROD_ID(0x47, 0x41), > BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) }, > }; > > Also note that I think just about every panel on that list supports the Intel > HDR backlight interface, so it's -possible- that the VESA interface could be > broken on these panels. But, that would

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-18 Thread Kevin Chowski
ts you'd end > up with crazy stuff like this: > > [ 7 ... 0 ][7 ... 0] > [ 8 MSB ][][N LSB] > > so you couldn't even treat the value as a regular big endian > thing. Instead, if you squint a bit, it now looks like a funky > little endian value. So we'r

[PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
DP-1/i915_dpcd` on my laptop to verify that the registers were being set according to what the actual hardware expects; I also observe that the backlight is noticeably brighter with this patch. Signed-off-by: Kevin Chowski --- .../drm/i915/display/intel_dp_aux_backlight.c | 34 +++

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
> nouveau. We probably can figure out some other solution for handling this > quirk > if this isn't possible, but could we maybe use the panel's OUI here and add a > quirk to drm_dp_helper.c instead? > > On Thu, 2020-09-17 at 11:09 -0600, Kevin Chowski wrote: > > We

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Kevin Chowski
romebooks which do rely on LSB functionality, so unless we can find more examples of laptops wanting MSB it currently looks like Pixelbook is the outlier. On Thu, Sep 17, 2020 at 11:28 AM Jani Nikula wrote: > > On Thu, 17 Sep 2020, Kevin Chowski wrote: > > We have observed tha

Re: [Intel-gfx] [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-22 Thread Kevin Chowski
fault. Who can help me gather a list of OUIs that we need to add to the quirk? I can follow up with Puthikorn about the relevant Chromebooks, but I don't know what other types of laptops are using this driver. Thanks for your time, Kevin Chowski On Fri, Sep 18, 2020 at 12:16 PM Puthikorn Vora