Re: [PATCH v5 03/24] wfx: add Makefile/Kconfig

2021-03-15 Thread Leon Romanovsky
On Mon, Mar 15, 2021 at 02:24:40PM +0100, Jerome Pouiller wrote: > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > drivers/net/wireless/silabs/wfx/Kconfig | 12 +++ > drivers/net/wireless/silabs/wfx/Makefile | 26 > 2 files changed, 38 insertion

Re: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-19 Thread Leon Romanovsky
On Tue, Jan 19, 2021 at 03:25:10PM +0530, Shradha Todi wrote: > > -Original Message- > > From: Leon Romanovsky > > Subject: Re: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for - > > >get_features() > > > > On Tue, Jan 12, 2021

Re: [PATCH] infiniband/core: Fix a use after free in cm_work_handler

2021-03-11 Thread Leon Romanovsky
On Wed, Mar 10, 2021 at 06:21:53PM -0800, Lv Yunlong wrote: > In cm_work_handler, it calls destory_cm_id() to release > the initial reference of cm_id_priv taken by iw_create_cm_id() > and free the cm_id_priv. After destory_cm_id(), iwcm_deref_id > (cm_id_priv) will be called and cause a use after

Re: Re: [PATCH] infiniband/core: Fix a use after free in cm_work_handler

2021-03-11 Thread Leon Romanovsky
deref_id(cm_id_priv);" > to free the cm_id_priv. It is not enough to see double call to iwcm_deref_id() because it is protected with refcount to claim use-after-free. Did you hit the BUG_ON() for the second call to iwcm_deref_id()? And please don't do top-posting. Thanks > >

Re: Re: Re: [PATCH] infiniband/core: Fix a use after free in cm_work_handler

2021-03-11 Thread Leon Romanovsky
On Thu, Mar 11, 2021 at 08:03:23PM +0800, lyl2...@mail.ustc.edu.cn wrote: > > > > > -原始邮件- > > 发件人: "Leon Romanovsky" > > 发送时间: 2021-03-11 19:05:03 (星期四) > > 收件人: lyl2...@mail.ustc.edu.cn > > 抄送: dledf...@redhat.com, j...@ziepe.

[PATCH rdma-rc 2/2] RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc

2021-03-02 Thread Leon Romanovsky
From: Leon Romanovsky Fix the following W=1 compilation warning: drivers/infiniband/core/uverbs_ioctl.c:108: warning: expecting prototype for uverbs_alloc(). Prototype was for _uverbs_alloc() instead Fixes: 461bb2eee4e1 ("IB/uverbs: Add a simple allocator to uverbs_attr_bundle") Sig

[PATCH rdma-rc 0/2] W=1 compilation fixes leftovers

2021-03-02 Thread Leon Romanovsky
From: Leon Romanovsky Two extra fixes that were missed in Lee's W=1 cleanup. Leon Romanovsky (2): RDMA/mlx5: Set correct kernel-doc identifier RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc drivers/infiniband/core/uverbs_ioctl.c | 4 ++-- drivers/infiniband/hw/mlx5/odp.c

[PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier

2021-03-02 Thread Leon Romanovsky
From: Leon Romanovsky The W=1 allmodconfig build produces the following warning: drivers/infiniband/hw/mlx5/odp.c:1086: warning: wrong kernel-doc identifier on line: * Parse a series of data segments for page fault handling. Fix it by changing /** to be /* as it is written in kernel-doc

Re: [PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier

2021-03-02 Thread Leon Romanovsky
On Tue, Mar 02, 2021 at 09:31:09AM +, Lee Jones wrote: > On Tue, 02 Mar 2021, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > The W=1 allmodconfig build produces the following warning: > > drivers/infiniband/hw/mlx5/odp.c:1086: warning: wrong kern

Re: [PATCH rdma-rc 2/2] RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc

2021-03-02 Thread Leon Romanovsky
On Tue, Mar 02, 2021 at 09:32:23AM +, Lee Jones wrote: > On Tue, 02 Mar 2021, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > Fix the following W=1 compilation warning: > > drivers/infiniband/core/uverbs_ioctl.c:108: warning: expecting prototype >

Re: [PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier

2021-03-02 Thread Leon Romanovsky
On Tue, Mar 02, 2021 at 10:44:10AM +, Lee Jones wrote: > On Tue, 02 Mar 2021, Leon Romanovsky wrote: > > > On Tue, Mar 02, 2021 at 09:31:09AM +, Lee Jones wrote: > > > On Tue, 02 Mar 2021, Leon Romanovsky wrote: > > > > > > > From: Leon Romano

Re: [PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start()

2021-03-07 Thread Leon Romanovsky
> --- > drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Like Heiner said, the current code has correct behavior. The mlx5_fpga_device_load_check() has same mlx5_is_fpga_lookaside() check and it is not an error if it returns

Re: [PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

2021-03-07 Thread Leon Romanovsky
On Fri, Mar 05, 2021 at 10:20:00PM +0800, Zhu Lingshan wrote: > This commit bumps ifcvf driver version string to 1.0 > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/d

Re: [PATCH] infiniband: hw: cxgb4: fix error return code of pass_open_rpl()

2021-03-07 Thread Leon Romanovsky
On Sat, Mar 06, 2021 at 05:53:17AM -0800, Jia-Ju Bai wrote: > When ep is NULL, no error code of pass_open_rpl() is returned. > To fix this bug, pass_open_rpl() returns -EINVAL in this case. Why do you think that this is an error? > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- > d

Re: [PATCH] infiniband: hw: cxgb4: fix error return code of close_listsrv_rpl()

2021-03-07 Thread Leon Romanovsky
On Sat, Mar 06, 2021 at 05:55:48AM -0800, Jia-Ju Bai wrote: > When ep is NULL, no error code of close_listsrv_rpl() is returned. > To fix this bug, close_listsrv_rpl() returns -EINVAL in this case. I don't think that this is an error. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 01:07:57AM -0800, Jia-Ju Bai wrote: > When hif_scatter_req_get() returns NULL to scat_req, no error return > code of ath6kl_htc_rx_bundle() is assigned. > To fix this bug, status is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai

Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle()

2021-03-07 Thread Leon Romanovsky
On Sun, Mar 07, 2021 at 05:31:01PM +0800, Jia-Ju Bai wrote: > Hi Leon, > > I am quite sorry for my incorrect patches... > My static analysis tool reports some possible bugs about error handling > code, and thus I write some patches for the bugs that seem to be true in my > opinion. > Because I am n

Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

2021-03-08 Thread Leon Romanovsky
On Mon, Mar 08, 2021 at 04:35:25PM +0800, Zhu Lingshan wrote: > This commit removes the version number string, using kernel > version is enough. > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 -- > 1 file changed, 2 deletions(-) > T

Re: [PATCH 02/30] RDMA/hw/mlx5/qp: Demote non-conformant kernel-doc header

2021-01-21 Thread Leon Romanovsky
finiband/hw/mlx5/qp.c:5384: warning: Function parameter or member > 'counter' not described in 'mlx5_ib_qp_set_counter' > > Cc: Leon Romanovsky > Cc: Doug Ledford > Cc: Jason Gunthorpe > Cc: linux-r...@vger.kernel.org > Signed-off-by: Lee Jones > --- > dr

Re: [PATCH 01/30] RDMA/hw/mlx5/odp: Fix formatting and add missing descriptions in 'pagefault_data_segments()'

2021-01-21 Thread Leon Romanovsky
7;pagefault_data_segments' > drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member > 'total_wqe_bytes' not described in 'pagefault_data_segments' > drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member > 'receiv

Re: [PATCH] net/mlx5e: free page before return

2021-01-21 Thread Leon Romanovsky
/ethernet/mellanox/mlx5/core/en/health.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH V3 4/6] vDPA/ifcvf: remove the version number string

2021-03-10 Thread Leon Romanovsky
y added my ROB, but will add again. Thanks, Reviewed-by: Leon Romanovsky

Re: [PATCH] seccomp: Improve performance by optimizing memory barrier

2021-02-07 Thread Leon Romanovsky
On Mon, Feb 01, 2021 at 08:49:41PM +0800, wanghongzhe wrote: > If a thread(A)'s TSYNC flag is set from seccomp(), then it will > synchronize its seccomp filter to other threads(B) in same thread > group. To avoid race condition, seccomp puts rmb() between > reading the mode and filter in seccomp ch

Re: [RESEND PATCH v3 3/5] misc: Add Synopsys DesignWare xData IP driver to Kconfig

2021-02-07 Thread Leon Romanovsky
On Tue, Feb 02, 2021 at 05:56:36PM +0100, Gustavo Pimentel wrote: > Add Synopsys DesignWare xData IP driver to Kconfig. > > This driver enables/disables the PCIe traffic generator module > pertain to the Synopsys DesignWare prototype. > > Signed-off-by: Gustavo Pimentel > --- > drivers/misc/Kconf

Re: [PATCH 11/12] platform-msi: Add platform check for subdevice irq domain

2021-02-08 Thread Leon Romanovsky
> For x86, IMS is only supported on bare metal for now. We could enable it > in the virtualization environments in the future if interrupt HYPERCALL > domain is supported or the hardware has the capability of interrupt > isolation for subdevices. > > Cc: David Woodhouse >

Re: [PATCH v3 net-next] Remove buf_info from device accessible structures

2021-01-26 Thread Leon Romanovsky
On Mon, Jan 25, 2021 at 02:34:56PM -0800, Ronak Doshi wrote: > vmxnet3: Remove buf_info from device accessible structures This line should be part of the "Subject: ..." and not as separated line. Thanks > > buf_info structures in RX & TX queues are private driver data that > do not need to be vi

[PATCH rdma-next v1 0/2] Fixes to v5.11

2021-01-26 Thread Leon Romanovsky
From: Leon Romanovsky v1: * Improved grammar and add wake call to ib_umad_kill_port() v0: https://lore.kernel.org/linux-rdma/20201213132940.345554-1-l...@kernel.org/ Shay Drory (2): IB/umad: Return EIO in case of when device disassociated IB/umad: Return EPOLLERR in case of when device

Re: [PATCH v11 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2021-01-04 Thread Leon Romanovsky
On Mon, Jan 04, 2021 at 09:22:17AM +0100, Steen Hegelund wrote: > Add the Microchip Sparx5 ethernet serdes PHY driver for the 6G, 10G and 25G > interfaces available in the Sparx5 SoC. > > Signed-off-by: Bjarni Jonasson > Signed-off-by: Steen Hegelund > Reviewed-by: Andrew Lunn > --- > drivers/p

Re: [PATCH v11 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2021-01-04 Thread Leon Romanovsky
On Mon, Jan 04, 2021 at 02:16:38PM +0100, Steen Hegelund wrote: > Hi Leon, > > > On Mon, 2021-01-04 at 14:15 +0200, Leon Romanovsky wrote: > > > > <...> > > > > > +struct sparx5_sd10g28_args { > > > + bool skip_cmu_cf

Re: [RFC PATCH v3 1/2] iommu: Add capability IOMMU_CAP_VIOMMU

2021-01-16 Thread Leon Romanovsky
On Sat, Jan 16, 2021 at 09:20:16AM +0800, Lu Baolu wrote: > Hi, > > On 2021/1/15 14:31, Leon Romanovsky wrote: > > On Fri, Jan 15, 2021 at 07:49:47AM +0800, Lu Baolu wrote: > > > Hi Leon, > > > > > > On 1/14/21 9:26 PM, Leon Romanovsky wrote: > >

Re: [RFC PATCH v3 1/2] iommu: Add capability IOMMU_CAP_VIOMMU

2021-01-16 Thread Leon Romanovsky
On Sat, Jan 16, 2021 at 04:47:40PM +0800, Lu Baolu wrote: > Hi Leon, > > On 2021/1/16 16:39, Leon Romanovsky wrote: > > On Sat, Jan 16, 2021 at 09:20:16AM +0800, Lu Baolu wrote: > > > Hi, > > > > > > On 2021/1/15 14:31, Leon Romanovsky wrote: > >

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-05 Thread Leon Romanovsky
On Wed, Jan 06, 2021 at 10:27:49AM +0800, Lu Baolu wrote: > The pci_subdevice_msi_create_irq_domain() should fail if the underlying > platform is not able to support IMS (Interrupt Message Storage). Otherwise, > the isolation of interrupt is not guaranteed. > > For x86, IMS is only supported on bar

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Wed, Jan 06, 2021 at 06:10:09PM +0800, Lu Baolu wrote: > Hi Leon, > > On 2021/1/6 14:06, Leon Romanovsky wrote: > > On Wed, Jan 06, 2021 at 10:27:49AM +0800, Lu Baolu wrote: > > > The pci_subdevice_msi_create_irq_domain() should fail if the underlying > > > pl

Re: [PATCH v3] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-06 Thread Leon Romanovsky
On Wed, Jan 06, 2021 at 04:08:10PM +0530, Shradha Todi wrote: > get_features ops of pci_epc_ops may return NULL, causing NULL pointer > dereference in pci_epf_test_bind function. Let us add a check for > pci_epc_feature pointer in pci_epf_test_bind before we access it to avoid > any such NULL point

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: > On Wed, Jan 06, 2021 at 12:40:17PM +0200, Leon Romanovsky wrote: > > > I asked what will you do when QEMU will gain needed functionality? > > Will you remove QEMU from this list? If yes, how such "new"

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 02:04:29AM +, Tian, Kevin wrote: > > From: Leon Romanovsky > > Sent: Thursday, January 7, 2021 12:02 AM > > > > On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: > > > On Wed, Jan 06, 2021 at 12:40:17PM +0200, Leon Romano

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Leon Romanovsky
On Thu, Jan 07, 2021 at 06:55:16AM +, Tian, Kevin wrote: > > From: Leon Romanovsky > > Sent: Thursday, January 7, 2021 2:09 PM > > > > On Thu, Jan 07, 2021 at 02:04:29AM +, Tian, Kevin wrote: > > > > From: Leon Romanovsky > > &g

[PATCH rdma-rc 0/5] Fixes to v5.10

2020-12-13 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is another series with various fixes that can easily go to -next too. Thanks Leon Romanovsky (1): RDMA/cma: Don't overwrite sgid_attr after device is released Maor Gottlieb (2): RDMA/mlx5: Fix MR cache memory leak RDMA/ucma: Fix memory leak of conne

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > It is fix for semantic patch warning available in > scripts/coccinelle/misc/boolinit.cocci > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable > >

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote: > > > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > > > > It is

Re: [PATCH rdma-rc 0/5] Fixes to v5.10

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 03:27:22PM -0400, Jason Gunthorpe wrote: > On Sun, Dec 13, 2020 at 03:29:35PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This is another series with various fixes that can easily go to -next too. > >

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:37:34PM -0800, Joe Perches wrote: > On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > > I prefer revisions to single patches (as opposed to large patch series) > &

Re: [PATCH -next] infiniband: core: Delete useless kfree code

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:46:55PM +0800, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun > --- > drivers/infiniband/core/cma_configfs.c | 1 - > 1 file changed, 1 deletion(-) The best thing will be to delete w

Re: [PATCH -next] ulp/ipoib/ipoib_multicast: convert comma to semicolon

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:42:18PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Can you please do it in o

Re: [PATCH 050/141] RDMA/mlx5: Fix fall-through warnings for Clang

2020-11-23 Thread Leon Romanovsky
github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/mlx5/qp.c | 1 + > 1 file changed, 1 insertion(+) > Thanks, Acked-by: Leon Romanovsky

Re: [patch resend] mm: page_alloc: fix zone allocation fairness on UP

2014-09-11 Thread Leon Romanovsky
On Thu, Sep 11, 2014 at 3:36 PM, Johannes Weiner wrote: > On Wed, Sep 10, 2014 at 07:32:20AM +0300, Leon Romanovsky wrote: >> Hi Johaness, >> >> >> On Tue, Sep 9, 2014 at 4:15 PM, Johannes Weiner wrote: >> >> > The zone allocation batches can easily unde

Re: [PATCH] mm: page_alloc: Fix setting of ZONE_FAIR_DEPLETED on UP

2014-09-06 Thread Leon Romanovsky
3 long x = atomic_long_read(&zone->vm_stat[item]); 134 #ifdef CONFIG_SMP 135 if (x < 0) 136 x = 0; 137 #endif 138 return x; 139 } [1] https://git.kernel.org/cgit/linux/kernel/git/mhocko/mm.git/tree/include/linux/vmstat.h#n130 -- Leon Romanovsky | I

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-14 Thread Leon Romanovsky
On Thu, Apr 14, 2016 at 01:48:31PM -0400, Ira Weiny wrote: > On Thu, Apr 14, 2016 at 10:45:50AM -0600, Jason Gunthorpe wrote: > > On Thu, Apr 14, 2016 at 08:41:35AM -0700, Dennis Dalessandro wrote: > > > This patch series removes the write() interface for user access in favor > > > of an > > > ioc

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-15 Thread Leon Romanovsky
On Fri, Apr 15, 2016 at 12:17:55PM -0400, Ira Weiny wrote: > On Fri, Apr 15, 2016 at 07:01:26AM +0300, Leon Romanovsky wrote: > > On Thu, Apr 14, 2016 at 01:48:31PM -0400, Ira Weiny wrote: > > > On Thu, Apr 14, 2016 at 10:45:50AM -0600, Jason Gunthorpe wrote: > > > >

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-15 Thread Leon Romanovsky
On Fri, Apr 15, 2016 at 10:34:01AM -0700, Christoph Hellwig wrote: > On Fri, Apr 15, 2016 at 08:30:35PM +0300, Leon Romanovsky wrote: > > Great, did you show it to other RDMA stakeholders except Intel? > > I saw nothing posted on ML or proposed for initial discussion, which > >

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-15 Thread Leon Romanovsky
On Fri, Apr 15, 2016 at 05:44:48PM +, Woodruff, Robert J wrote: > > I fear it's kfabrics, which is an entirely crackpot idea and a total > > non-starter, but for some reason Intel and their buddies keep wasting time > > on it. > > What is being discussed her is not kfabrics. That is a totall

Re: [PATCH] i40iw: constify i40iw_vf_cqp_ops structure

2016-05-01 Thread Leon Romanovsky
On Sun, May 01, 2016 at 02:22:21PM +0200, Julia Lawall wrote: > The i40iw_vf_cqp_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Thanks Julia, Reviewed-by: Leon Romanovsky signature.asc De

Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing.

2016-05-01 Thread Leon Romanovsky
r commit message and don't need to resend, however the statements like "smaller code" need to be supported by ./scripts/bloat-o-meter and "faster code" by performance analysis. Reviewed-by: Leon Romanovsky > --- > drivers/staging/rdma/hfi1/init.c | 2 +- > 1 file ch

Re: [PATCH] i40e: constify i40e_client_ops structure

2016-05-01 Thread Leon Romanovsky
On Sun, May 01, 2016 at 02:07:23PM +0200, Julia Lawall wrote: > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Thanks Julia, Reviewed-by: Leon Romanovsky signature.asc De

Re: [PATCH v6 00/21] Add HiSilicon RoCE driver

2016-05-03 Thread Leon Romanovsky
On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoC

Re: [PATCH] RDMA/cxgb3: device driver frees DMA memory with different size

2016-05-22 Thread Leon Romanovsky
o_hal.c > @@ -327,7 +327,7 @@ int cxio_destroy_cq(struct cxio_rdev *rdev_p, struct > t3_cq *cq) > kfree(cq->sw_queue); > dma_free_coherent(&(rdev_p->rnic_info.pdev->dev), > (1UL << (cq->size_log2)) > - * sizeof(struc

Re: [PATCH v8 10/22] IB/hns: Add process flow to init RoCE engine

2016-05-25 Thread Leon Romanovsky
On Wed, May 25, 2016 at 11:05:13PM +0800, Lijun Ou wrote: > This patch mainly initialized the RoCE engine. It is absolutely > necessary to run RoCE. It mainly includes that configure DMAE > user, initialize doorbell and raq operations, enable port. > > Signed-off-by: Wei Hu > Signed-off-by: Nengl

Re: [PATCH] IB/mlx4: use list_for_each_entry_safe in search_relocate_mgid0_group

2015-12-07 Thread Leon Romanovsky
up, mgid0_list); > + list_for_each_entry_safe(group, n, &ctx->mcg_mgid0_list, mgid0_list) { > mutex_lock(&group->lock); > if (group->last_req_tid == tid) { > if (memcmp(new_mgid, &mgid0, sizeof mgid0)) { Thanks, Reviewed-by: Leon Rom

Re: [RFC PATCH v0] Add tw5864 driver

2016-01-02 Thread Leon Romanovsky
On Sun, Jan 03, 2016 at 03:41:42AM +0200, Andrey Utkin wrote: > +/* > + * TW5864 driver - Exp-Golomb code functions > + * > + * Copyright (C) 2015 Bluecherry, LLC > + * Copyright (C) 2015 Andrey Utkin I doubt that you have contract with your employer which permits you to claim copyright

Re: [PATCH] nes: handling failed allocation when creating workqueue

2016-02-17 Thread Leon Romanovsky
Please see my minor comments below. Reviewed-by: Leon Romanovsky On Wed, Feb 17, 2016 at 01:06:33PM -0500, Insu Yun wrote: > Since create_singlethread_workqueue uses kzalloc internally, > it can be failed in memory pressure, so need to handle it. s/can be failed/can fail/ > > S

[PATCH v2] mm: nommu: refactor debug and warning prints

2015-05-22 Thread Leon Romanovsky
acy prints code * Change title to reflect new changes. It was "[PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()" [3]. [1] https://lkml.org/lkml/2015/5/16/279 [2] https://lkml.org/lkml/2015/5/18/903 [3] https://lkml.org/lkml/2015/5/18/682 Signed-off-by: Leon

[RFC] Refactor kenter/kleave/kdebug macros

2015-05-16 Thread Leon Romanovsky
2887366b0eb226c2 Author: David Howells Date: Thu Jan 8 12:04:47 2009 + [2] List of all files there kdebug was defined: * arch/mn10300/kernel/mn10300-serial.c * arch/mn10300/mm/misalignment.c * fs/cachefiles/internal.h * fs/afs/internal.h * fs/fscache/internal.h * fs/binfmt_elf_f

Re: [RFC] Refactor kenter/kleave/kdebug macros

2015-05-16 Thread Leon Romanovsky
On Sat, May 16, 2015 at 8:09 PM, Joe Perches wrote: > On Sat, 2015-05-16 at 20:01 +0300, Leon Romanovsky wrote: [] >> My question is how we should handle such duplicated debug print code? >> As possible solutions, I see five options: >> 1. Leave it as is. >> 2. Move

Re: [RFC] Refactor kenter/kleave/kdebug macros

2015-05-18 Thread Leon Romanovsky
ced by empty functions which is thrown by compiler. Additionally, It looks like the output of these macros can be viewed by ftrace mechanism. Maybe we should delete them from mm/nommu.c as was pointed by Joe? > > > David -- Leon Romanovsky | Independent Linux Consulta

Re: [RFC] Refactor kenter/kleave/kdebug macros

2015-05-18 Thread Leon Romanovsky
On Mon, May 18, 2015 at 4:29 PM, David Howells wrote: > Leon Romanovsky wrote: > >> Blind conversion to pr_debug will blow the code because it will be always >> compiled in. > > No, it won't. Sorry, you are right. > >> Additionally, It looks like the o

mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
compiled in if "#define DEBUG" is not declared prior to that macros. Signed-off-by: Leon Romanovsky --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm

mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
compiled in if "#define DEBUG" is not declared prior to that macros. Signed-off-by: Leon Romanovsky --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm

[PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
compiled in if "#define DEBUG" is not declared prior to that macros. Signed-off-by: Leon Romanovsky --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm

Re: [RFC] Refactor kenter/kleave/kdebug macros

2015-05-18 Thread Leon Romanovsky
On Mon, May 18, 2015 at 6:20 PM, David Howells wrote: > Leon Romanovsky wrote: > >> >> Additionally, It looks like the output of these macros can be viewed by >> >> ftrace mechanism. >> > >> > *blink* It can? >> I was under strong impressio

[PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
compiled in if "#define DEBUG" is not declared prior to that macros. Signed-off-by: Leon Romanovsky --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm

Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
Sorry for this multiple resend, my mail client hid from me part of subject line :( On Mon, May 18, 2015 at 9:42 PM, Leon Romanovsky wrote: > kenter/kleave/kdebug are wrapper macros to print functions flow and debug > information. This set was written before pr_devel() was introduced, so &g

Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

2015-05-18 Thread Leon Romanovsky
On Tue, May 19, 2015 at 1:27 AM, Andrew Morton wrote: > On Mon, 18 May 2015 21:42:06 +0300 Leon Romanovsky wrote: > >> kenter/kleave/kdebug are wrapper macros to print functions flow and debug >> information. This set was written before pr_devel() was introduced, so >> i

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-07 Thread Leon Romanovsky
Hi Jaegeuk, > + /* for batched trimming */ > + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it can't be negative by definition. What do you think about it? -- To unsub

Re: [PATCH] Add tw5864 driver

2016-03-19 Thread Leon Romanovsky
On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > From: Andrey Utkin > > Support for boards based on Techwell TW5864 chip which provides > multichannel video & audio grabbing and encoding (H.264, MJPEG, > ADPCM G.726). > > Signed-off-by: Andrey Utkin > Tested-by: Andrey Utkin > -

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

2016-03-19 Thread Leon Romanovsky
On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: > >so, I continue to have it. > > I will continue to bash on your odd codingstyle. Please fix it! Jiri, Checkpatch errors is an easiest issue with this patch. It is full of functions without use, unconnected macros and if you replace "

Re: [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes

2016-04-10 Thread Leon Romanovsky
fter that feel free to add my RB tag. Reviewed-By: Leon Romanovsky signature.asc Description: Digital signature

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-04-05 Thread Leon Romanovsky
On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 > >> > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ > > ^^ > > Do you support v1 of R

Re: [PATCHv10 1/3] rdmacg: Added rdma cgroup controller

2016-04-05 Thread Leon Romanovsky
On Tue, Apr 05, 2016 at 05:55:26AM -0700, Parav Pandit wrote: > Hi Christoph, > > On Tue, Apr 5, 2016 at 5:42 AM, Christoph Hellwig wrote: > > On Tue, Apr 05, 2016 at 05:39:21AM -0700, Parav Pandit wrote: > >> I am not really trying to address OFED issues here. I am sure you > >> understand that

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-15 Thread Leon Romanovsky
On Fri, Apr 15, 2016 at 05:37:32PM -0600, Jason Gunthorpe wrote: > On Sat, Apr 16, 2016 at 12:23:28AM +0300, Leon Romanovsky wrote: > > > Intel as usual decided to do it in their way and the result is presented > > on this mailing list. > > Dennis was pretty clear

Re: [PATCH 0/7] IB/hfi1: Remove write() and use ioctl() for user access

2016-04-15 Thread Leon Romanovsky
On Fri, Apr 15, 2016 at 07:28:01PM -0400, Ira Weiny wrote: > On Sat, Apr 16, 2016 at 12:23:28AM +0300, Leon Romanovsky wrote: > Do you have a technical reason that this patch series does not fix the > write/writev issue brought up by Al? Sure, I truly believe that we can do common API in

Re: [PATCH] IB/ipoib: Add readout of statistics using ethtool

2016-04-19 Thread Leon Romanovsky
On Tue, Apr 19, 2016 at 05:50:23PM +0300, Erez Shitrit wrote: > On Fri, Apr 15, 2016 at 1:17 PM, Hans Westgaard Ry > wrote: > > IPoIB collects statistics of traffic including number of packets > > sent/received, number of bytes transferred, and certain errors. This > > patch makes these statistics

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-24 Thread Leon Romanovsky
On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. it will do a series of > initial works as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table >

Re: [PATCH v5 00/21] Add HiSilicon RoCE driver

2016-04-24 Thread Leon Romanovsky
On Sat, Apr 23, 2016 at 06:26:38PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoC

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-26 Thread Leon Romanovsky
On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: > On 2016/4/24 15:54, Leon Romanovsky wrote: > > On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: > >> This patch mainly setup hca for RoCE. it will do a series of > >> initial works as follows: &

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

2016-04-01 Thread Leon Romanovsky
On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific > operation

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

2015-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar > --- > drivers/staging/rdma/hfi1/user_sdma.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > /* Last packet in the r

Re: [PATCH][next] RDMA: fix allocation failure on pointer pd

2019-02-12 Thread Leon Romanovsky
andle PD allocations by IB/core") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks a lot, Reviewed-by: Leon Romanovsky

Re: [PATCH -next] RDMA/hns: Make hns_roce_cmq_send static

2019-03-20 Thread Leon Romanovsky
On Wed, Mar 20, 2019 at 09:50:47PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5: > warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/infiniband/hw

Re: [PATCH] ib_umem: fix type mismatch

2019-09-08 Thread Leon Romanovsky
On Fri, Sep 06, 2019 at 05:42:37PM +0200, Arnd Bergmann wrote: > On some 32-bit architectures, size_t is defined as 'int' rather > than 'long', causing a harmless warning: > > drivers/infiniband/core/umem_odp.c:220:7: error: comparison of distinct > pointer types ('typeof (umem_odp->umem.address)

Re: [PATCH RESEND] arch/microblaze: add support for get_user() of size 8 bytes

2019-08-31 Thread Leon Romanovsky
quot;microblaze: fix get_user/put_user side-effects") > Reported-by: kbuild test robot > Signed-off-by: Randy Dunlap > Cc: Al Viro > Cc: Steven J. Magnani > Cc: Michal Simek > Cc: Jason Gunthorpe > Cc: Leon Romanovsky > Cc: Andrew Morton > Cc: Doug Ledford >

Re: [PATCH net-next] net/mlx5e: Use PTR_ERR_OR_ZERO in mlx5e_tc_add_nic_flow()

2019-08-22 Thread Leon Romanovsky
On Thu, Aug 22, 2019 at 06:52:19AM +, YueHaibing wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Than

Re: [PATCH net-next,v4, 3/6] net/mlx5: Add wrappers for HyperV PCIe operations

2019-08-22 Thread Leon Romanovsky
On Thu, Aug 22, 2019 at 05:05:47AM +, Haiyang Zhang wrote: > From: Eran Ben Elisha > > Add wrapper functions for HyperV PCIe read / write / > block_invalidate_register operations. This will be used as an > infrastructure in the downstream patch for software communication. > > This will be ena

Re: [PATCH net-next,v4, 4/6] net/mlx5: Add HV VHCA infrastructure

2019-08-22 Thread Leon Romanovsky
On Thu, Aug 22, 2019 at 05:05:51AM +, Haiyang Zhang wrote: > From: Eran Ben Elisha > > HV VHCA is a layer which provides PF to VF communication channel based on > HyperV PCI config channel. It implements Mellanox's Inter VHCA control > communication protocol. The protocol contains control bloc

Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status

2019-08-27 Thread Leon Romanovsky
On Tue, Aug 27, 2019 at 10:08:30AM -0500, Josh Poimboeuf wrote: > On Mon, Aug 26, 2019 at 04:38:29PM -0700, Nathan Chancellor wrote: > > Looks like that comes from tune_qsfp, which gets inlined into > > tune_serdes but I am far from an objtool expert so I am not > > really sure what kind of issues

Re: [PATCH] IB/mlx5: Convert to use vm_map_pages_zero()

2019-08-27 Thread Leon Romanovsky
On Wed, Aug 28, 2019 at 08:57:19AM +0530, Souptick Joarder wrote: > On Tue, Aug 27, 2019 at 9:19 PM Jason Gunthorpe wrote: > > > > On Tue, Aug 27, 2019 at 01:48:57AM +0530, Souptick Joarder wrote: > > > On Mon, Aug 26, 2019 at 5:50 PM Jason Gunthorpe wrote: > > > > > > > > On Mon, Aug 26, 2019 at

Re: [PATCH v2] RDMA: release allocated skb

2019-10-03 Thread Leon Romanovsky
On Wed, Oct 02, 2019 at 04:35:06PM -0500, Navid Emamdoost wrote: > Hi Jason, > > Thanks for the feedback. Yes, you are right if the skb release is > moved under err4 label it will cause a double free as > c4iw_ref_send_wait will release skb in case of error. > So, in order to avoid leaking skb in c

Re: [PATCH] net/mlx5: fix memory leak in mlx5_fw_fatal_reporter_dump

2019-09-27 Thread Leon Romanovsky
On Fri, Sep 27, 2019 at 05:37:28PM -0500, Navid Emamdoost wrote: > In mlx5_fw_fatal_reporter_dump if mlx5_crdump_collect fails the > allocated memory for cr_data must be released otherwise there will be > memory leak. To fix this, this commit changes the return instruction > into goto error handlin

Re: Potential NULL pointer deference in RDMA

2019-10-09 Thread Leon Romanovsky
On Wed, Oct 09, 2019 at 09:44:58PM -0700, Yizhuo Zhai wrote: > Hi All: > drivers/infiniband/sw/rxe/rxe_verbs.c: > The function to_rdev() could return NULL, but no caller in this file > checks the return value but directly dereference them, which seems > potentially unsafe. Callers include rxe_query

Re: [PATCH] IB/mlx4: Fix memory leaks

2019-08-19 Thread Leon Romanovsky
ree > 'tun_qp->tx_ring' whenever an error occurs. > > Signed-off-by: Wenwen Wang > --- > drivers/infiniband/hw/mlx4/mad.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Acked-by: Leon Romanovsky

Re: [PATCH] infiniband: hfi1: fix a memory leak bug

2019-08-19 Thread Leon Romanovsky
e error. > > Signed-off-by: Wenwen Wang > --- > drivers/infiniband/hw/hfi1/fault.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky

<    1   2   3   4   5   6   7   8   9   10   >