Re: [PATCH for 4.9 07/59] clk: sunxi-ng: set the parent rate when adjustin CPUX clock on A33

2017-09-14 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 15, 2017 at 10:02:04AM +0800, icen...@aosc.io wrote: >在 2017-09-14 23:51,Levin, Alexander (Sasha Levin) 写道: >>From: Icenowy Zheng <icen...@aosc.xyz> >> >>[ Upstream commit bb021cda2ccf45ee9470bf0f8c55323ad1c761ae ] > >As DVFS for A33 doesn't exist in 4

Re: [PATCH for 4.9 01/39] net: core: Prevent from dereferencing null pointer when releasing SKB

2017-09-18 Thread Levin, Alexander (Sasha Levin)
On Mon, Sep 18, 2017 at 08:41:02AM +0200, Greg KH wrote: >On Mon, Sep 18, 2017 at 12:19:36AM +0000, Levin, Alexander (Sasha Levin) wrote: >> From: Myungho Jung <mhju...@gmail.com> >> >> [ Upstream commit 9899886d5e8ec5b343b1efe44f185a0e68dc6454 ] >> >> Added

Re: [PATCH for 4.9 01/39] net: core: Prevent from dereferencing null pointer when releasing SKB

2017-09-18 Thread Levin, Alexander (Sasha Levin)
On Mon, Sep 18, 2017 at 10:13:21AM -0400, Sasha Levin wrote: >On Mon, Sep 18, 2017 at 08:41:02AM +0200, Greg KH wrote: >>On Mon, Sep 18, 2017 at 12:19:36AM +0000, Levin, Alexander (Sasha Levin) >>wrote: >>>From: Myungho Jung <mhju...@gmail.co

[PATCH review for 4.4 27/47] audit: log 32-bit socketcalls

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Richard Guy Briggs [ Upstream commit 62bc306e2083436675e33b5bdeb6a77907d35971 ] 32-bit socketcalls were not being logged by audit on x86_64 systems. Log them. This is basically a duplicate of the call from net/socket.c:sys_socketcall(), but it addresses the impedance

[PATCH review for 3.18 12/30] IB/ipoib: Replace list_del of the neigh->list with list_del_init

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit c586071d1dc8227a7182179b8e50ee92cc43f6d2 ] In order to resolve a situation where a few process delete the same list element in sequence and cause panic, list_del is replaced with list_del_init. In this case if the first process that

[PATCH review for 3.18 28/30] md/raid10: submit bio directly to replacement disk

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit 6d399783e9d4e9bd44931501948059d24ad96ff8 ] Commit 57c67df(md/raid10: submit IO from originating thread instead of md thread) submits bio directly for normal disks but not for replacement disks. There is no point we shouldn't do this for

[PATCH review for 3.18 26/30] parisc: perf: Fix potential NULL pointer dereference

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Arvind Yadav [ Upstream commit 74e3f6e63da6c8e8246fba1689e040bc926b4a1a ] Fix potential NULL pointer dereference and clean up coding style errors (code indent, trailing whitespaces). Signed-off-by: Arvind Yadav Signed-off-by: Helge

[PATCH review for 4.4 42/47] iommu/io-pgtable-arm: Check for leaf entry before dereferencing it

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Oleksandr Tyshchenko [ Upstream commit ed46e66cc1b3d684042f92dfa2ab15ee917b4cac ] Do a check for already installed leaf entry at the current level before dereferencing it in order to avoid walking the page table down with wrong pointer to the next level.

[PATCH review for 4.4 07/47] MIPS: kexec: Do not reserve invalid crashkernel memory on boot

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Marcin Nowakowski [ Upstream commit a8f108d70c74d83574c157648383eb2e4285a190 ] Do not reserve memory for the crashkernel if the commandline argument points to a wrong location. This can happen if the location is specified wrong or if the same commandline is

[PATCH review for 4.4 39/47] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Thibault Saunier [ Upstream commit d7f3e33df4fbdc9855fb151f4a328ec46447e3ba ] In the case of semi planar formats cb and cr are in the same plane in memory, meaning that will be set to 'cb' whatever the format is, and whatever the (packed) order of those

[PATCH review for 4.4 04/47] RDS: RDMA: Fix the composite message user notification

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Santosh Shilimkar [ Upstream commit 941f8d55f6d613a460a5e080d25a38509f45eb75 ] When application sends an RDS RDMA composite message consist of RDMA transfer to be followed up by non RDMA payload, it expect to be notified *only* when the full message gets

[PATCH review for 4.4 22/47] USB: serial: mos7720: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit 0d130367abf582e7cbf60075c2a7ab53817b1d14 ] Make sure to log an error on short transfers when reading a device register. Also clear the provided buffer (which if often an uninitialised automatic variable) on errors as the driver currently

[PATCH review for 4.4 21/47] drm/amdkfd: fix improper return value on error

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 8bf793883da213864efc50c274d2b38ec0ca58b2 ] In function kfd_wait_on_events(), when the call to copy_from_user() fails, the value of return variable ret is 0. 0 indicates success, which is inconsistent with the execution status. This patch

[PATCH review for 4.4 18/47] IB/ipoib: Fix deadlock over vlan_mutex

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 1c3098cdb05207e740715857df7b0998e372f527 ] This patch fixes Deadlock while executing ipoib_vlan_delete. The function takes the vlan_rwsem semaphore and calls unregister_netdevice. The later function calls ipoib_mcast_stop_thread that

[PATCH review for 4.4 35/47] mmc: sdio: fix alignment issue in struct sdio_func

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 5ef1ecf060f28ecef313b5723f1fd39bf5a35f56 ] Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be used for DMA to be 8-byte-aligned. struct sdio_func has an embedded small DMA buffer not meeting this requirement. When

[PATCH review for 3.18 13/30] USB: serial: mos7720: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit 0d130367abf582e7cbf60075c2a7ab53817b1d14 ] Make sure to log an error on short transfers when reading a device register. Also clear the provided buffer (which if often an uninitialised automatic variable) on errors as the driver currently

[PATCH review for 4.4 43/47] rds: ib: add error handle

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Zhu Yanjun [ Upstream commit 3b12f73a5c2977153f28a224392fd4729b50d1dc ] In the function rds_ib_setup_qp, the error handle is missing. When some error occurs, it is possible that memory leak occurs. As such, error handle is added. Cc: Joe Jin

[PATCH review for 4.4 09/47] igb: re-assign hw address pointer on reset after PCI error

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Guilherme G Piccoli [ Upstream commit 69b97cf6dbce7403845a28bbc75d57f5be7b12ac ] Whenever the igb driver detects the result of a read operation returns a value composed only by F's (like 0x), it will detach the net_device, clear the hw_addr pointer and

[PATCH review for 4.4 20/47] IB/ipoib: Replace list_del of the neigh->list with list_del_init

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit c586071d1dc8227a7182179b8e50ee92cc43f6d2 ] In order to resolve a situation where a few process delete the same list element in sequence and cause panic, list_del is replaced with list_del_init. In this case if the first process that

[PATCH review for 3.18 01/30] drm: bridge: add DT bindings for TI ths8135

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Bartosz Golaszewski [ Upstream commit 2e644be30fcc08c736f66b60f4898d274d4873ab ] THS8135 is a configurable video DAC. Add DT bindings for this chip. Signed-off-by: Bartosz Golaszewski Reviewed-by: Laurent Pinchart

[PATCH review for 4.4 46/47] xfs: remove kmem_zalloc_greedy

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: "Darrick J. Wong" [ Upstream commit 08b005f1333154ae5b404ca28766e0ffb9f1c150 ] The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses it to grab 1-4 pages for staging of inobt records. The infinite loop in the greedy allocation function is

[PATCH review for 3.18 14/30] USB: serial: mos7840: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit cd8db057e93ddaacbec025b567490555d2bca280 ] Make sure to detect short transfers when reading a device register. The modem-status handling had sufficient error checks in place, but move handling of short transfers into the register accessor

[PATCH review for 3.18 30/30] libata: transport: Remove circular dependency at free time

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Gwendal Grignou [ Upstream commit d85fc67dd11e9a32966140677d4d6429ca540b25 ] Without this patch, failed probe would not free resources like irq. ata port tdev object currently hold a reference to the ata port object. Therefore the ata port object release function

[PATCH review for 4.4 28/47] usb: chipidea: vbus event may exist before starting gadget

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Peter Chen [ Upstream commit c3b674a04b8ab62a1d35e86714d466af0a0ecc18 ] At some situations, the vbus may already be there before starting gadget. So we need to check vbus event after switching to gadget in order to handle missing vbus event. The typical use cases are

[PATCH review for 4.4 02/47] drm: bridge: add DT bindings for TI ths8135

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Bartosz Golaszewski [ Upstream commit 2e644be30fcc08c736f66b60f4898d274d4873ab ] THS8135 is a configurable video DAC. Add DT bindings for this chip. Signed-off-by: Bartosz Golaszewski Reviewed-by: Laurent Pinchart

[PATCH review for 4.4 01/47] drm_fourcc: Fix DRM_FORMAT_MOD_LINEAR #define

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: "Kristian H. Kristensen" [ Upstream commit af913418261d6d3e7a29f06cf35f04610ead667c ] We need to define DRM_FORMAT_MOD_VENDOR_NONE for the fourcc_mod_code() macro to work correctly. Signed-off-by: Kristian H. Kristensen Signed-off-by: Daniel

[PATCH review for 4.4 30/47] MIPS: Lantiq: Fix another request_mem_region() return code check

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 98ea51cb0c8ce009d9da1fd7b48f0ff1d7a9bbb0 ] Hauke already fixed a couple of them, but one instance remains that checks for a negative integer when it should check for a NULL pointer: arch/mips/lantiq/xway/sysctrl.c: In function

[PATCH review for 4.4 03/47] GFS2: Fix reference to ERR_PTR in gfs2_glock_iter_next

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 14d37564fa3dc4e5d4c6828afcd26ac14e6796c5 ] This patch fixes a place where function gfs2_glock_iter_next can reference an invalid error pointer. Signed-off-by: Dan Carpenter Signed-off-by: Bob Peterson

[PATCH review for 4.4 17/47] tty: goldfish: Fix a parameter of a call to free_irq

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ] 'request_irq()' and 'free_irq()' should be called with the same dev_id. Signed-off-by: Christophe JAILLET Signed-off-by: Greg Kroah-Hartman

[PATCH review for 3.18 09/30] tty: goldfish: Fix a parameter of a call to free_irq

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ] 'request_irq()' and 'free_irq()' should be called with the same dev_id. Signed-off-by: Christophe JAILLET Signed-off-by: Greg Kroah-Hartman

[PATCH review for 4.4 45/47] i2c: meson: fix wrong variable usage in meson_i2c_put_data

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 3b0277f198ac928f323c42e180680d2f79aa980d ] Most likely a copy & paste error. Signed-off-by: Heiner Kallweit Acked-by: Jerome Brunet Signed-off-by: Wolfram Sang

[PATCH review for 4.4 44/47] md/raid10: submit bio directly to replacement disk

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit 6d399783e9d4e9bd44931501948059d24ad96ff8 ] Commit 57c67df(md/raid10: submit IO from originating thread instead of md thread) submits bio directly for normal disks but not for replacement disks. There is no point we shouldn't do this for

[PATCH review for 3.18 10/30] IB/ipoib: Fix deadlock over vlan_mutex

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 1c3098cdb05207e740715857df7b0998e372f527 ] This patch fixes Deadlock while executing ipoib_vlan_delete. The function takes the vlan_rwsem semaphore and calls unregister_netdevice. The later function calls ipoib_mcast_stop_thread that

[PATCH review for 4.4 33/47] team: fix memory leaks

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Pan Bian [ Upstream commit 72ec0bc64b9a5d8e0efcb717abfc757746b101b7 ] In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This

[PATCH review for 4.4 29/47] ASoC: dapm: fix some pointer error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 639467c8f26d834c934215e8b59129ce442475fe ] commit 66feeec9322132689d42723df2537d60f96f8e44 "RFC: ASoC: dapm: handle probe deferrals" forgot a to update some two sites where the call was used. The static codechecks quickly found

[PATCH review for 4.4 26/47] ASoC: dapm: handle probe deferrals

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 37e1df8c95e2c8a57c77eafc097648f6e40a60ff ] This starts to handle probe deferrals on regulators and clocks on the ASoC DAPM. I came to this patch after audio stopped working on Ux500 ages ago and I finally looked into it to see

[PATCH review for 4.4 38/47] MIPS: IRQ Stack: Unwind IRQ stack onto task stack

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Matt Redfearn [ Upstream commit db8466c581cca1a08b505f1319c3ecd246f16fa8 ] When the separate IRQ stack was introduced, stack unwinding only proceeded as far as the top of the IRQ stack, leading to kernel backtraces being less useful, lacking the trace of what was

[PATCH review for 4.4 25/47] partitions/efi: Fix integer overflow in GPT size calculation

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Alden Tondettar [ Upstream commit c5082b70adfe8e1ea1cf4a8eff92c9f260e364d2 ] If a GUID Partition Table claims to have more than 2**25 entries, the calculation of the partition table size in alloc_read_gpt_entries() will overflow a 32-bit integer and not enough

[PATCH review for 4.4 14/47] iio: adc: axp288: Drop bogus AXP288_ADC_TS_PIN_CTRL register modifications

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Hans de Goede [ Upstream commit fa2849e9649b5180ffc4cb3c3b005261c403093a ] For some reason the axp288_adc driver was modifying the AXP288_ADC_TS_PIN_CTRL register, changing bits 0-1 depending on whether the GP_ADC channel or another channel was written. These bits

[PATCH review for 3.18 18/30] net: core: Prevent from dereferencing null pointer when releasing SKB

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Myungho Jung [ Upstream commit 9899886d5e8ec5b343b1efe44f185a0e68dc6454 ] Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung

[PATCH review for 3.18 21/30] usb: plusb: Add support for PL-27A1

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Roman Spychała [ Upstream commit 6f2aee0c0de6501bbc26fe50c9c7b09a37f7 ] This patch adds support for the PL-27A1 by adding the appropriate USB ID's. This chip is used in the goobay Active USB 3.0 Data Link and Unitek Y-3501 cables. Signed-off-by: Roman Spychała

[PATCH review for 3.18 27/30] rds: ib: add error handle

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Zhu Yanjun [ Upstream commit 3b12f73a5c2977153f28a224392fd4729b50d1dc ] In the function rds_ib_setup_qp, the error handle is missing. When some error occurs, it is possible that memory leak occurs. As such, error handle is added. Cc: Joe Jin

[PATCH review for 3.18 23/30] netfilter: invoke synchronize_rcu after set the _hook_ to NULL

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit 3b7dabf029478bb80507a6c4500ca94132a2bc0b ] Otherwise, another CPU may access the invalid pointer. For example: CPU0CPU1 - rcu_read_lock(); - pfunc = _hook_; _hook_ = NULL;

[PATCH review for 3.18 15/30] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show()

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Markus Elfring [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ] Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the

[PATCH review for 3.18 22/30] mmc: sdio: fix alignment issue in struct sdio_func

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 5ef1ecf060f28ecef313b5723f1fd39bf5a35f56 ] Certain 64-bit systems (e.g. Amlogic Meson GX) require buffers to be used for DMA to be 8-byte-aligned. struct sdio_func has an embedded small DMA buffer not meeting this requirement. When

[PATCH review for 3.18 05/30] sh_eth: use correct name for ECMR_MPDE bit

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Niklas Söderlund [ Upstream commit 6dcf45e514974a1ff10755015b5e06746a033e5f ] This bit was wrongly named due to a typo, Sergei checked the SH7734/63 manuals and this bit should be named MPDE. Suggested-by: Sergei Shtylyov

[PATCH review for 4.4 06/47] MIPS: Ensure bss section ends on a long-aligned address

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Paul Burton [ Upstream commit 3f00f4d8f083bc61005d0a1ef592b149f5c88bbd ] When clearing the .bss section in kernel_entry we do so using LONG_S instructions, and branch whilst the current write address doesn't equal the end of the .bss section minus the size of a

[PATCH review for 4.4 41/47] parisc: perf: Fix potential NULL pointer dereference

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Arvind Yadav [ Upstream commit 74e3f6e63da6c8e8246fba1689e040bc926b4a1a ] Fix potential NULL pointer dereference and clean up coding style errors (code indent, trailing whitespaces). Signed-off-by: Arvind Yadav Signed-off-by: Helge

[PATCH review for 4.4 31/47] net: core: Prevent from dereferencing null pointer when releasing SKB

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Myungho Jung [ Upstream commit 9899886d5e8ec5b343b1efe44f185a0e68dc6454 ] Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung

[PATCH review for 4.4 34/47] usb: plusb: Add support for PL-27A1

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Roman Spychała [ Upstream commit 6f2aee0c0de6501bbc26fe50c9c7b09a37f7 ] This patch adds support for the PL-27A1 by adding the appropriate USB ID's. This chip is used in the goobay Active USB 3.0 Data Link and Unitek Y-3501 cables. Signed-off-by: Roman Spychała

[PATCH review for 3.18 03/30] MIPS: Ensure bss section ends on a long-aligned address

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Paul Burton [ Upstream commit 3f00f4d8f083bc61005d0a1ef592b149f5c88bbd ] When clearing the .bss section in kernel_entry we do so using LONG_S instructions, and branch whilst the current write address doesn't equal the end of the .bss section minus the size of a

[PATCH review for 4.4 23/47] USB: serial: mos7840: fix control-message error handling

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Johan Hovold [ Upstream commit cd8db057e93ddaacbec025b567490555d2bca280 ] Make sure to detect short transfers when reading a device register. The modem-status handling had sufficient error checks in place, but move handling of short transfers into the register accessor

[PATCH review for 4.4 24/47] pinctrl: mvebu: Use seq_puts() in mvebu_pinconf_group_dbg_show()

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Markus Elfring [ Upstream commit 420dc61642920849d824a0de2aa853db59f5244f ] Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the

[PATCH review for 4.4 40/47] netfilter: nfnl_cthelper: fix incorrect helper->expect_class_max

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit ae5c682113f9f94cc5e76f92cf041ee624c173ee ] The helper->expect_class_max must be set to the total number of expect_policy minus 1, since we will use the statement "if (class > helper->expect_class_max)" to validate the CTA_EXPECT_CLASS

[PATCH review for 4.4 16/47] ARM: 8635/1: nommu: allow enabling REMAP_VECTORS_TO_RAM

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Afzal Mohammed [ Upstream commit 8a792e9afbce84a0fdaf213fe42bb97382487094 ] REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on DRAM_BASE is redundant as whenever

[PATCH review for 4.4 37/47] netfilter: invoke synchronize_rcu after set the _hook_ to NULL

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit 3b7dabf029478bb80507a6c4500ca94132a2bc0b ] Otherwise, another CPU may access the invalid pointer. For example: CPU0CPU1 - rcu_read_lock(); - pfunc = _hook_; _hook_ = NULL;

[PATCH review for 4.4 08/47] MIPS: ralink: Fix incorrect assignment on ralink_soc

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Colin Ian King [ Upstream commit 08d90c81b714482dceb5323d14f6617bcf55ee61 ] ralink_soc sould be assigned to RT3883_SOC, replace incorrect comparision with assignment. Signed-off-by: Colin Ian King Fixes: 418d29c87061 ("MIPS: ralink:

[PATCH review for 4.4 05/47] ARM: dts: r8a7790: Use R-Car Gen 2 fallback binding for msiof nodes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Simon Horman [ Upstream commit 654450baf2afba86cf328e1849ccac61ec4630af ] Use recently added R-Car Gen 2 fallback binding for msiof nodes in DT for r8a7790 SoC. This has no run-time effect for the current driver as the initialisation sequence is the same for

[PATCH review for 4.4 19/47] IB/ipoib: rtnl_unlock can not come after free_netdev

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ] The ipoib_vlan_add function calls rtnl_unlock after free_netdev, rtnl_unlock not only releases the lock, but also calls netdev_run_todo. The latter function browses the net_todo_list array and

[PATCH review for 4.4 15/47] iio: adc: hx711: Add DT binding for avia,hx711

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Andreas Klinger [ Upstream commit ff1293f67734da68e23fecb6ecdae7112b8c43f9 ] Add DT bindings for avia,hx711 Add vendor avia to vendor list Signed-off-by: Andreas Klinger Acked-by: Rob Herring Signed-off-by: Jonathan Cameron

[PATCH review for 4.4 13/47] hwmon: (gl520sm) Fix overflows and crash seen when writing into limit attributes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Guenter Roeck [ Upstream commit 87cdfa9d60f4f40e6d71b04b10b36d9df3c89282 ] Writes into limit attributes can overflow due to multplications and additions with unbound input values. Writing into fan limit attributes can result in a crash with a division by zero if very

[PATCH review for 4.4 11/47] sh_eth: use correct name for ECMR_MPDE bit

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Niklas Söderlund [ Upstream commit 6dcf45e514974a1ff10755015b5e06746a033e5f ] This bit was wrongly named due to a typo, Sergei checked the SH7734/63 manuals and this bit should be named MPDE. Suggested-by: Sergei Shtylyov

[PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Nicholas Mc Guire [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] The delay here is not in atomic context and does not seem critical with respect to precision, but usleep_range(min,max) with min==max results in giving the timer subsystem no room to optimize

[PATCH review for 3.18 08/30] ARM: 8635/1: nommu: allow enabling REMAP_VECTORS_TO_RAM

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Afzal Mohammed [ Upstream commit 8a792e9afbce84a0fdaf213fe42bb97382487094 ] REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on DRAM_BASE is redundant as whenever

[PATCH review for 3.18 06/30] clk: wm831x: fix usleep_range with bad range

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Nicholas Mc Guire [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] The delay here is not in atomic context and does not seem critical with respect to precision, but usleep_range(min,max) with min==max results in giving the timer subsystem no room to optimize

[PATCH review for 4.4 36/47] bridge: netlink: register netdevice before executing changelink

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Ido Schimmel [ Upstream commit 5b8d5429daa05bebef6ffd3297df3b502cc6f184 ] Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference

[PATCH review for 3.18 02/30] RDS: RDMA: Fix the composite message user notification

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Santosh Shilimkar [ Upstream commit 941f8d55f6d613a460a5e080d25a38509f45eb75 ] When application sends an RDS RDMA composite message consist of RDMA transfer to be followed up by non RDMA payload, it expect to be notified *only* when the full message gets

[PATCH review for 3.18 07/30] hwmon: (gl520sm) Fix overflows and crash seen when writing into limit attributes

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Guenter Roeck [ Upstream commit 87cdfa9d60f4f40e6d71b04b10b36d9df3c89282 ] Writes into limit attributes can overflow due to multplications and additions with unbound input values. Writing into fan limit attributes can result in a crash with a division by zero if very

[PATCH review for 3.18 04/30] MIPS: kexec: Do not reserve invalid crashkernel memory on boot

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Marcin Nowakowski [ Upstream commit a8f108d70c74d83574c157648383eb2e4285a190 ] Do not reserve memory for the crashkernel if the commandline argument points to a wrong location. This can happen if the location is specified wrong or if the same commandline is

[PATCH review for 3.18 11/30] IB/ipoib: rtnl_unlock can not come after free_netdev

2017-09-19 Thread Levin, Alexander (Sasha Levin)
From: Feras Daoud [ Upstream commit 89a3987ab7a923c047c6dec008e60ad6f41fac22 ] The ipoib_vlan_add function calls rtnl_unlock after free_netdev, rtnl_unlock not only releases the lock, but also calls netdev_run_todo. The latter function browses the net_todo_list array and

Re: [PATCH review for 4.4 12/47] clk: wm831x: fix usleep_range with bad range

2017-09-23 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 22, 2017 at 09:46:28AM +0100, Charles Keepax wrote: >On Wed, Sep 20, 2017 at 04:45:02AM +0000, Levin, Alexander (Sasha Levin) wrote: >> From: Nicholas Mc Guire <hof...@osadl.org> >> >> [ Upstream commit ed784c532a3d0959db488f40a96c5127f63d42dc ] >> &

Re: [PATCH for 4.9 39/59] arm: dts: mt2701: Add subsystem clock controller device nodes

2017-09-17 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 15, 2017 at 01:15:43PM +0200, Matthias Brugger wrote: >On 09/14/2017 05:51 PM, Levin, Alexander (Sasha Levin) wrote: >>From: James Liao <jamesjj.l...@mediatek.com> >> >>[ Upstream commit f235c7e7a75325f28a33559a71f25a0eca6112db ] >> >>Add MT27

[PATCH for 4.9 15/39] drivers/rapidio/devices/tsi721.c: make module parameter variable name unique

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Randy Dunlap [ Upstream commit 4785603bd05b0b029c647080937674d9991600f9 ] kbuild test robot reported a non-static variable name collision between a staging driver and a RapidIO driver, with a generic variable name of 'dbg_level'. Both drivers should be changed so

[PATCH for 4.9 09/39] bridge: netlink: register netdevice before executing changelink

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Ido Schimmel [ Upstream commit 5b8d5429daa05bebef6ffd3297df3b502cc6f184 ] Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference

[PATCH for 4.9 01/39] net: core: Prevent from dereferencing null pointer when releasing SKB

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Myungho Jung [ Upstream commit 9899886d5e8ec5b343b1efe44f185a0e68dc6454 ] Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung

[PATCH for 4.9 10/39] Btrfs: fix segmentation fault when doing dio read

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Liu Bo [ Upstream commit 97bf5a5589aa3a59c60aa775fc12ec0483fc5002 ] Commit 2dabb3248453 ("Btrfs: Direct I/O read: Work on sectorsized blocks") introduced this bug during iterating bio pages in dio read's endio hook, and it could end up with segment fault of the dio

[PATCH for 4.9 04/39] usb: plusb: Add support for PL-27A1

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Roman Spychała [ Upstream commit 6f2aee0c0de6501bbc26fe50c9c7b09a37f7 ] This patch adds support for the PL-27A1 by adding the appropriate USB ID's. This chip is used in the goobay Active USB 3.0 Data Link and Unitek Y-3501 cables. Signed-off-by: Roman Spychała

[PATCH for 4.9 12/39] sata_via: Enable hotplug only on VT6421

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Ondrej Zary [ Upstream commit 3cf864520e877505158f09075794a08abab11bbe ] Commit 57e5568fda27 ("sata_via: Implement hotplug for VT6421") adds hotplug IRQ handler for VT6421 but enables hotplug on all chips. This is a bug because it causes "irq xx: nobody cared"

[PATCH for 4.9 17/39] MIPS: IRQ Stack: Unwind IRQ stack onto task stack

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Matt Redfearn [ Upstream commit db8466c581cca1a08b505f1319c3ecd246f16fa8 ] When the separate IRQ stack was introduced, stack unwinding only proceeded as far as the top of the IRQ stack, leading to kernel backtraces being less useful, lacking the trace of what was

[PATCH for 4.9 06/39] net: dsa: b53: Include IMP/CPU port in dumb forwarding mode

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Florian Fainelli [ Upstream commit a424f0de61638cbb5047e0a888c54da9cf471f90 ] Since Broadcom tags are not enabled in b53 (DSA_PROTO_TAG_NONE), we need to make sure that the IMP/CPU port is included in the forwarding decision. Without this change, switching between

[PATCH for 4.9 07/39] qed: Fix possible system hang in the dcbnl-getdcbx() path.

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: "sudarsana.kall...@cavium.com" [ Upstream commit 62289ba27558553871fd047baadaaeda886c6a63 ] qed_dcbnl_get_dcbx() API uses kmalloc in GFT_KERNEL mode. The API gets invoked in the interrupt context by qed_dcbnl_getdcbx callback. Need to invoke this kmalloc in

[PATCH for 4.9 02/39] net/packet: check length in getsockopt() called with PACKET_HDRLEN

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Alexander Potapenko [ Upstream commit fd2c83b35752f0a8236b976978ad4658df14a59f ] In the case getsockopt() is called with PACKET_HDRLEN and optlen < 4 |val| remains uninitialized and the syscall may behave differently depending on its value, and even copy garbage to

[PATCH for 4.9 16/39] netfilter: invoke synchronize_rcu after set the _hook_ to NULL

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Liping Zhang [ Upstream commit 3b7dabf029478bb80507a6c4500ca94132a2bc0b ] Otherwise, another CPU may access the invalid pointer. For example: CPU0CPU1 - rcu_read_lock(); - pfunc = _hook_; _hook_ = NULL;

[PATCH for 4.9 05/39] udp: disable inner UDP checksum offloads in IPsec case

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Ansis Atteka [ Upstream commit b40c5f4fde22fb98eff205b3aece05b471c24eed ] Otherwise, UDP checksum offloads could corrupt ESP packets by attempting to calculate UDP checksum when this inner UDP packet is already protected by IPsec. One way to reproduce this bug is to have

[PATCH for 4.9 19/39] [media] exynos-gsc: Do not swap cb/cr for semi planar formats

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Thibault Saunier [ Upstream commit d7f3e33df4fbdc9855fb151f4a328ec46447e3ba ] In the case of semi planar formats cb and cr are in the same plane in memory, meaning that will be set to 'cb' whatever the format is, and whatever the (packed) order of those

[PATCH for 4.9 27/39] x86/acpi: Restore the order of CPU IDs

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Dou Liyang [ Upstream commit 2b85b3d22920db7473e5fed5719e7955c0ec323e ] The following commits: f7c28833c2 ("x86/acpi: Enable acpi to register all possible cpus at boot time") and 8f54969dc8 ("x86/acpi: Introduce persistent storage for cpuid <-> apicid

[PATCH for 4.9 20/39] MIPS: smp-cps: Fix retrieval of VPE mask on big endian CPUs

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Matt Redfearn [ Upstream commit fb2155e3c30dc2043b52020e26965067a3e7779c ] The vpe_mask member of struct core_boot_config is of type atomic_t, which is a 32bit type. In cps-vec.S this member was being retrieved by a PTR_L macro, which on 64bit systems is a 64bit

[PATCH for 4.9 25/39] ibmvnic: Free tx/rx scrq pointer array when releasing sub-crqs

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Nathan Fontenot [ Upstream commit 9501df3cd9204f5859f649182431616a31ee88a1 ] The pointer array for the tx/rx sub crqs should be free'ed when releasing the tx/rx sub crqs. Signed-off-by: Nathan Fontenot Signed-off-by: David S. Miller

[PATCH for 4.9 18/39] iommu/exynos: Block SYSMMU while invalidating FLPD cache

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Marek Szyprowski [ Upstream commit 7d2aa6b814476a2e2794960f844344519246df72 ] Documentation specifies that SYSMMU should be in blocked state while performing TLB/FLPD cache invalidation, so add needed calls to sysmmu_block/unblock. Fixes: 66a7ed84b345d

[PATCH for 4.9 31/39] rds: ib: add error handle

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Zhu Yanjun [ Upstream commit 3b12f73a5c2977153f28a224392fd4729b50d1dc ] In the function rds_ib_setup_qp, the error handle is missing. When some error occurs, it is possible that memory leak occurs. As such, error handle is added. Cc: Joe Jin

[PATCH for 4.9 30/39] mm/cgroup: avoid panic when init with low memory

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Laurent Dufour [ Upstream commit bfc7228b9a9647e1c353e50b40297a2929801759 ] The system may panic when initialisation is done when almost all the memory is assigned to the huge pages using the kernel command line parameter hugepage=. Panic may occur like

[PATCH for 4.9 35/39] xfs: remove kmem_zalloc_greedy

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: "Darrick J. Wong" [ Upstream commit 08b005f1333154ae5b404ca28766e0ffb9f1c150 ] The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses it to grab 1-4 pages for staging of inobt records. The infinite loop in the greedy allocation function is

[PATCH for 4.9 32/39] md/raid10: submit bio directly to replacement disk

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit 6d399783e9d4e9bd44931501948059d24ad96ff8 ] Commit 57c67df(md/raid10: submit IO from originating thread instead of md thread) submits bio directly for normal disks but not for replacement disks. There is no point we shouldn't do this for

[PATCH for 4.9 37/39] libata: transport: Remove circular dependency at free time

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Gwendal Grignou [ Upstream commit d85fc67dd11e9a32966140677d4d6429ca540b25 ] Without this patch, failed probe would not free resources like irq. ata port tdev object currently hold a reference to the ata port object. Therefore the ata port object release function

[PATCH for 4.9 38/39] ARM: dts: BCM5301X: Fix memory start address

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Jon Mason [ Upstream commit 88d1fa70c21d7b431386cfe70cdc514d98b0c9c4 ] Memory starts at 0x8000, not 0. 0 "works" due to mirrior of the first 128M of RAM to that address. Anything greater than 128M will quickly find nothing there. Correcting the starting

[PATCH for 4.9 29/39] arm64: kasan: avoid bad virt_to_pfn()

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Mark Rutland [ Upstream commit b0de0ccc8b9edd8846828e0ecdc35deacdf186b0 ] Booting a v4.11-rc1 kernel with DEBUG_VIRTUAL and KASAN enabled produces the following splat (trimmed for brevity): [0.00] virt_to_phys used for non-linear address: 2808

[PATCH for 4.9 36/39] ASoC: wm_adsp: Return an error on write to a disabled volatile control

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Charles Keepax [ Upstream commit 67430a39ca7a6af28aade5acb92d43ee257c1014 ] Volatile controls should only be accessed when the firmware is active, currently however writes to these controls will succeed, but the data will be lost, if the firmware is

[PATCH for 4.9 24/39] nfs: make nfs4_cb_sv_ops static

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Jason Yan [ Upstream commit 05fae7bbc237bc7de0ee9c3dcf85b2572a80e3b5 ] Fixes the following sparse warning: fs/nfs/callback.c:235:21: warning: symbol 'nfs4_cb_sv_ops' was not declared. Should it be static? Signed-off-by: Jason Yan Signed-off-by:

[PATCH for 4.9 34/39] i2c: meson: fix wrong variable usage in meson_i2c_put_data

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Heiner Kallweit [ Upstream commit 3b0277f198ac928f323c42e180680d2f79aa980d ] Most likely a copy & paste error. Signed-off-by: Heiner Kallweit Acked-by: Jerome Brunet Signed-off-by: Wolfram Sang

[PATCH for 4.9 39/39] tools/power turbostat: bugfix: GFXMHz column not changing

2017-09-17 Thread Levin, Alexander (Sasha Levin)
From: Len Brown [ Upstream commit 22048c5485503749754b3b5daf9d99ef89fcacdc ] turbostat displays a GFXMHz column, which comes from reading /sys/class/graphics/fb0/device/drm/card0/gt_cur_freq_mhz But GFXMHz was not changing, even when a manual cat

<    1   2   3   4   5   6   7   8   9   10   >