[PATCH review for 4.9 50/50] PCI: Avoid possible deadlock on pci_lock and p->pi_lock

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Bjorn Helgaas [ Upstream commit cdcb33f9824429a926b971bf041a6cec238f91ff ] pci_lock is an IRQ-safe spinlock that protects all accesses to PCI configuration space (see PCI_OP_READ() and PCI_OP_WRITE() in pci/access.c). The pci_cfg_access_unlock() path acquires

[PATCH review for 4.4 05/24] mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Hans de Goede [ Upstream commit 1af468ebe45591651ec3bafc2e9ddc6fdef70ae0 ] The R in PEK_DBR stands for rising, so it should be mapped to AXP288_IRQ_POKP where the last P stands for positive edge. Likewise PEK_DBF should be mapped to the falling edge, aka the

[PATCH review for 4.4 10/24] drm/amdgpu: when dpm disabled, also need to stop/start vce.

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Rex Zhu [ Upstream commit 28ed5504ab4b211a4e589e648e5ebd1e0caa7a6a ] Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher Acked-by: Christian König Signed-off-by: Alex Deucher

[PATCH review for 4.9 47/50] [media] bt8xx: fix memory leak

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Sudip Mukherjee [ Upstream commit 6792eb0cf9310ec240b7e7c9bfa86dff4c758c68 ] If dvb_attach() fails then we were just printing an error message and exiting but the memory allocated to state was not released. Signed-off-by: Sudip Mukherjee

[PATCH review for 4.9 08/50] mfd: ab8500-sysctrl: Handle probe deferral

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Linus Walleij [ Upstream commit 7e9c40c63933a643908d686bd89dfc2315e8c70a ] In the current boot, clients making use of the AB8500 sysctrl may be probed before the ab8500-sysctrl driver. This gives them -EINVAL, but should rather give -EPROBE_DEFER. Before this,

[PATCH review for 4.9 25/50] ath10k: fix reading sram contents for QCA4019

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Ashok Raj Nagarajan [ Upstream commit 7f622593cc5add77a99cd39404e8a851be9de792 ] With QCA4019 platform, SRAM address can be accessed directly from host but currently, we are assuming sram addresses cannot be accessed directly and hence we convert the addresses.

[PATCH review for 4.9 46/50] s390/crypto: Extend key length check for AES-XTS in fips mode.

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Harald Freudenberger [ Upstream commit a4f2779ecf2f42b0997fedef6fd20a931c40a3e3 ] In fips mode only xts keys with 128 bit or 125 bit are allowed. This fix extends the xts_aes_set_key function to check for these valid key lengths in fips mode. Signed-off-by:

[PATCH review for 4.4 02/24] mmc: s3cmci: include linux/interrupt.h for tasklet_struct

2017-10-07 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit e1c6ec26b853e9062f0b3daaf695c546d0702953 ] I got this new build error on today's linux-next drivers/mmc/host/s3cmci.h:69:24: error: field 'pio_tasklet' has incomplete type struct tasklet_struct pio_tasklet; drivers/mmc/host/s3cmci.c: In

Re: [PATCH 3/4] sched: WARN when migrating to an offline CPU

2017-10-06 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 29, 2017 at 01:11:26PM +0200, Peter Zijlstra wrote: >I can't seem to trigger :-( > >Can you please run with the below patch and: > > # echo 1 > /proc/sys/kernel/traceoff_on_warning The call stack trace looks like so: [ 2073.492089] Unregister pv shared memory for cpu 2 [

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-06 Thread Levin, Alexander (Sasha Levin)
On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >Hi Greg, > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >> 4.9-stable review patch. If anyone has any objections, please let me know. > >I'm a little confused as to why this is being backported, given it

[PATCH v2 1/4] kmemcheck: remove annotations

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Remove kmemcheck annotations, and calls to kmemcheck from the kernel. Signed-off-by: Sasha Levin --- arch/arm/include/asm/dma-iommu.h| 1 - arch/openrisc/include/asm/dma-mapping.h | 1 - arch/x86/Makefile | 5 -

[PATCH v2 2/4] kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Convert all allocations that used a NOTRACK flag to stop using it. Signed-off-by: Sasha Levin --- arch/arm/include/asm/pgalloc.h | 2 +- arch/arm64/include/asm/pgalloc.h | 2 +- arch/powerpc/include/asm/pgalloc.h | 2 +- arch/sh/kernel/dwarf.c

[PATCH v2 3/4] kmemcheck: rip it out

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Fix up makefiles, remove references, and git rm kmemcheck. Signed-off-by: Sasha Levin --- Documentation/admin-guide/kernel-parameters.txt | 7 - Documentation/dev-tools/index.rst | 1 - Documentation/dev-tools/kmemcheck.rst | 733

[PATCH v2 4/4] kmemcheck: remove whats left of NOTRACK flags

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Now that kmemcheck is gone, we don't need the NOTRACK flags. Signed-off-by: Sasha Levin --- arch/x86/include/asm/pgtable.h | 5 - arch/x86/include/asm/pgtable_types.h | 13 - include/linux/gfp.h | 9 -

[PATCH v2 0/4] kmemcheck: kill kmemcheck

2017-10-06 Thread Levin, Alexander (Sasha Levin)
2 Years ago I proposed to kill kmemcheck: > As discussed on LSF/MM, kill kmemcheck. > > KASan is a replacement that is able to work without the limitation of > kmemcheck (single CPU, slow). KASan is already upstream. > > We are also not aware of any users of kmemcheck (or users who don't consider

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 01:42:26PM +0200, Greg Kroah-Hartman wrote: >On Mon, Oct 09, 2017 at 11:06:53AM +0100, Will Deacon wrote: >> On Mon, Oct 09, 2017 at 10:14:50AM +0100, Mark Brown wrote: >> > On Sat, Oct 07, 2017 at 03:10:06AM +, Levin, Alexander (Sasha Levin) >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 02:00:53PM +0000, Levin, Alexander (Sasha Levin) wrote: > >> In this case, for example, this patch had a "review cycle" of 18 days >> where 4 different emails regarding this patch were

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 05:30:03PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 04:23:21PM +0000, Levin, Alexander (Sasha Levin) wrote: > >> Okay, so something like [REVIEW automatic-patch-selection for 4.X] >> is sort of what you're suggesting? > >Yeah (perhaps a

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-10 Thread Levin, Alexander (Sasha Levin)
(Cc'ed Julia) On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote: >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: >> We are experimenting with using neural network to aid with patch >> selection for stable kernel trees. There are quite a few commi

Re: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs

2017-10-13 Thread Levin, Alexander (Sasha Levin)
On Fri, Oct 13, 2017 at 09:11:21AM +0200, Michal Hocko wrote: >On Thu 12-10-17 19:22:05, Sasha Levin wrote: >> We have missed removing some code as part of removing the kmemcheck >> hooks. >> >> Unfourtenatly this got missed during my review, and the code was >> still building. >> >> Reported-by:

Re: [PATCH] 9p: set page uptodate when required in write_end()

2017-10-11 Thread Levin, Alexander (Sasha Levin)
Linus, Al, Can one of you please pick this one directly? This has been on LKML since April, but the 9p maintainers seem to be MIA? On Thu, Jun 01, 2017 at 10:31:09PM -0400, Sasha Levin wrote: >Ping? > >On Mon, Apr 10, 2017 at 02:46:57PM -0400, Sasha Levin wrote: >> From: Alexander Levin

[PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs

2017-10-12 Thread Levin, Alexander (Sasha Levin)
We have missed removing some code as part of removing the kmemcheck hooks. Unfourtenatly this got missed during my review, and the code was still building. Reported-by: Michal Hocko Signed-off-by: Sasha Levin --- include/linux/dma-mapping.h | 4

Re: Stable/distro kernel testing in Plumbers 2017

2017-09-11 Thread Levin, Alexander (Sasha Levin)
Hello all, The stable & distro kernel testing BoF was scheduled for Thursday, Sept. 14th at 6:30pm in room "Platinum E". More details are availalbe at: https://www.linuxplumbersconf.org/2017/ocw/proposals/4722 . It'll be great to have folks who are interested in discussion this subject at the

[PATCH review for 4.9 30/50] qed: Reserve doorbell BAR space for present CPUs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ram Amrani [ Upstream commit c2dedf8773e873474535bd4a158609b9eda5403d ] Reserving doorbell BAR space according to the currently active CPUs may result in a bug if disabled CPUs are later enabled but no doorbell space was reserved for them. Signed-off-by: Ram Amrani

[PATCH review for 3.18 11/14] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t

[PATCH review for 4.4 18/26] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Petazzoni [ Upstream commit 36fb7435b6ac4d288a2d4deea8934f9456ab46b6 ] The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the

[PATCH review for 4.4 12/26] sparc64: Migrate hvcons irq to panicked cpu

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Vijay Kumar [ Upstream commit 7dd4fcf5b70694dc961eb6b954673e4fc9730dbd ] On panic, all other CPUs are stopped except the one which had hit panic. To keep console alive, we need to migrate hvcons irq to panicked CPU. Signed-off-by: Vijay Kumar

[PATCH review for 3.18 03/14] irqchip/crossbar: Fix incorrect type of local variables

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in

[PATCH review for 3.18 02/14] watchdog: kempld: fix gcc-4.3 build

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 3736d4eb6af37492aeded7fec0072dedd959c842 ] gcc-4.3 can't decide whether the constant value in kempld_prescaler[PRESCALER_21] is built-time constant or not, and gets confused by the logic in do_div(): drivers/watchdog/kempld_wdt.o: In

[PATCH review for 4.9 44/50] powerpc/perf: Add restrictions to PMC5 in power9 DD1

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Madhavan Srinivasan [ Upstream commit 8d911904f3ce412b20874a9c95f82009dcbb007c ] PMC5 on POWER9 DD1 may not provide right counts in all sampling scenarios, hence use PM_INST_DISP event instead in PMC2 or PMC3 in preference. Signed-off-by: Madhavan Srinivasan

[PATCH review for 4.9 11/50] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Michael Zoran [ Upstream commit 6cf1bf636a067eb308cb3a8322b9d6b1844a075d ] The original github source allowed for the cache-line-size property to be missing. Since recent firmwares also require this property, it makes sense to always require it in the driver as well.

[PATCH review for 4.9 22/50] mm/memory_hotplug: set magic number to page->freelist instead of page->lru.next

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Yasuaki Ishimatsu [ Upstream commit ddffe98d166f4a93d996d5aa628fd745311fc1e7 ] To identify that pages of page table are allocated from bootmem allocator, magic number sets to page->lru.next. But page->lru list is initialized in reserve_bootmem_region(). So when

[PATCH review for 4.4 26/26] cpufreq: CPPC: add ACPI_PROCESSOR dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit a578884fa0d2768f13d37c6591a9e1ed600482d3 ] Without the Kconfig dependency, we can get this warning: warning: ACPI_CPPC_CPUFREQ selects ACPI_CPPC_LIB which has unmet direct dependencies (ACPI && ACPI_PROCESSOR) Fixes: 5477fb3bd1e8 (ACPI /

[PATCH review for 4.9 43/50] nfsd/callback: Cleanup callback cred on shutdown

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Kinglong Mee [ Upstream commit f7d1ddbe7648af7460d23688c8c131342eb43b3a ] The rpccred gotten from rpc_lookup_machine_cred() should be put when state is shutdown. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

[PATCH review for 3.18 08/14] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 3.18 13/14] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data

[PATCH review for 4.4 11/26] md/linear: shutup lockdep warnning

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit d939cdfde34f50b95254b375f498447c82190b3e ] Commit 03a9e24(md linear: fix a race between linear_add() and linear_congested()) introduces the warnning. Acked-by: Coly Li Signed-off-by: Shaohua Li Signed-off-by: Sasha

[PATCH review for 4.9 45/50] drm/nouveau/gr/gf100-: fix ccache error logging

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ben Skeggs [ Upstream commit 1894054dc1b6e4395048b2c0f28832a3f4320fd3 ] Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH review for 4.4 14/26] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 4.9 48/50] EDAC, mce_amd: Print IPID and Syndrome on a separate line

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Yazen Ghannam [ Upstream commit 75bf2f6478cab9b0c1d7f5f674a765d1e2ad530e ] Currently, the IPID and Syndrome are printed on the same line as the Address. There are cases when we can have a valid Syndrome but not a valid Address. For example, the MCA_SYND register

[PATCH review for 4.9 50/50] cpufreq: CPPC: add ACPI_PROCESSOR dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit a578884fa0d2768f13d37c6591a9e1ed600482d3 ] Without the Kconfig dependency, we can get this warning: warning: ACPI_CPPC_CPUFREQ selects ACPI_CPPC_LIB which has unmet direct dependencies (ACPI && ACPI_PROCESSOR) Fixes: 5477fb3bd1e8 (ACPI /

[PATCH review for 4.9 37/50] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6

[PATCH review for 4.4 02/26] watchdog: kempld: fix gcc-4.3 build

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 3736d4eb6af37492aeded7fec0072dedd959c842 ] gcc-4.3 can't decide whether the constant value in kempld_prescaler[PRESCALER_21] is built-time constant or not, and gets confused by the logic in do_div(): drivers/watchdog/kempld_wdt.o: In

[PATCH review for 4.4 17/26] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.9 39/50] IB/hfi1: Use static CTLE with Preset 6 for integrated HFIs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Easwar Hariharan [ Upstream commit 39e2afa8d042a53d855137d4c5a689a6f5492b39 ] After extended testing, it was found that the previous PCIe Gen 3 recipe, which used adaptive CTLE with Preset 4, could cause an NMI/Surprise Link Down in about 1 in 100 to 1 in 1000

[PATCH review for 4.9 36/50] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t

[PATCH review for 4.9 27/50] drm/amdgpu: refuse to reserve io mem for split VRAM buffers

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Nicolai Hähnle [ Upstream commit 4694335dad7357e9b3d7822ab13049014d74d8b0 ] When the fast blit path fails while attempting to move a buffer from RAM to VRAM, we fall back to a CPU-based memcpy that cannot handle split VRAM buffers. Instead of crashing, simply fail

[PATCH review for 4.9 49/50] genirq: Clarify logic calculating bogus irqreturn_t values

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeremy Kerr [ Upstream commit 5d4bac9a5f4ef24b2482529bda6661a58e5b5b65 ] Although irqreturn_t is an enum, we treat it (and its enumeration constants) as a bitmask. However, bad_action_ret() uses a less-than operator to determine whether an irqreturn_t falls within

[PATCH review for 4.9 23/50] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 4.9 25/50] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.9 46/50] regulator: core: Resolve supplies before disabling unused regulators

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Javier Martinez Canillas [ Upstream commit 3827b64dba27ebadb4faf51f2c91143e01ba1f6d ] After commit 66d228a2bf03 ("regulator: core: Don't use regulators as supplies until the parent is bound"), input supplies aren't resolved if the input supplies parent device has

[PATCH review for 4.9 34/50] ceph: fix bogus endianness change in ceph_ioctl_set_layout

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ] sparse says: fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64 preferred_osd is a __s64 so we don't need to do any conversion. Also, just remove the cast in ceph_ioctl_get_layout as

[PATCH review for 4.9 31/50] qed: Read queue state before releasing buffer

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ram Amrani [ Upstream commit c5212b943d4b52a7d9e0d9f747e7ad59c50d31f1 ] Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz Signed-off-by: David S.

[PATCH review for 4.4 01/26] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on

[PATCH review for 4.4 10/26] f2fs: do not wait for writeback in write_begin

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jaegeuk Kim [ Upstream commit 86d54795c94532075d862aa0a79f0c981dab4bdd ] Otherwise we can get livelock like below. [79880.428136] dbench D0 18405 18404 0x [79880.428139] Call Trace: [79880.428142] __schedule+0x219/0x6b0 [79880.428144]

[PATCH review for 4.4 15/26] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 4.9 47/50] btmrvl: avoid double-disable_irq() race

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeffy Chen [ Upstream commit 9af02d86e11dc409e5c3de46e81c0a492ba58905 ] It's much the same as what we did for mwifiex in: b9da4d2 mwifiex: avoid double-disable_irq() race "We have a race where the wakeup IRQ might be in flight while we're calling

[PATCH review for 3.18 04/14] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to

[PATCH review for 4.4 03/26] irqchip/crossbar: Fix incorrect type of local variables

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in

[PATCH review for 4.4 16/26] slub: do not merge cache if slub_debug contains a never-merge flag

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Grygorii Maistrenko [ Upstream commit c6e28895a4372992961888ffaadc9efc643b5bfe ] In case CONFIG_SLUB_DEBUG_ON=n, find_mergeable() gets debug features from commandline but never checks if there are features from the SLAB_NEVER_MERGE set. As a result selected by

[PATCH review for 3.18 06/14] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides

[PATCH review for 4.9 38/50] ibmvnic: Handle processing of CRQ messages in a tasklet

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Falcon [ Upstream commit 6c267b3dea09aebe84752cfedcab140c908830bb ] Create a tasklet to process queued commands or messages received from firmware instead of processing them in the interrupt handler. Note that this handler does not process network

[PATCH review for 4.9 40/50] IB/hfi1: Allocate context data on memory node

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Sebastian Sanchez [ Upstream commit b448bf9a0df6093dbadac36979a55ce4e012a677 ] There are some memory allocation calls in hfi1_create_ctxtdata() that do not use the numa function parameter. This can cause cache lines to be filled over QPI. Reviewed-by: Mike

[PATCH review for 4.9 28/50] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Petazzoni [ Upstream commit 36fb7435b6ac4d288a2d4deea8934f9456ab46b6 ] The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the

[PATCH review for 4.9 35/50] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to

[PATCH review for 4.4 05/26] mac80211: fix power saving clients handling in iwlwifi

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Emmanuel Grumbach [ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ] iwlwifi now supports RSS and can't let mac80211 track the PS state based on the Rx frames since they can come out of order. iwlwifi is now advertising AP_LINK_PS, and uses explicit

[PATCH review for 4.9 03/50] watchdog: kempld: fix gcc-4.3 build

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 3736d4eb6af37492aeded7fec0072dedd959c842 ] gcc-4.3 can't decide whether the constant value in kempld_prescaler[PRESCALER_21] is built-time constant or not, and gets confused by the logic in do_div(): drivers/watchdog/kempld_wdt.o: In

[PATCH review for 4.9 10/50] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Dumazet [ Upstream commit 47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf ] The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in

[PATCH review for 4.9 04/50] irqchip/crossbar: Fix incorrect type of local variables

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in

[PATCH review for 4.9 02/50] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on

[PATCH review for 4.9 05/50] initramfs: finish fput() before accessing any binary from initramfs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Lokesh Vutla [ Upstream commit 08865514805d2de8e7002fa8149c5de3e391f412 ] Commit 4a9d4b024a31 ("switch fput to task_work_add") implements a schedule_work() for completing fput(), but did not guarantee calling __fput() after unpacking initramfs. Because of this, there

[PATCH review for 4.9 12/50] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to

[PATCH review for 4.9 01/50] xen-netback: Use GFP_ATOMIC to allocate hash

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Anoob Soman [ Upstream commit 9f674e48c13dcbc31ac903433727837795b81efe ] Allocation of new_hash, inside xenvif_new_hash(), always happen in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new hash allocation. Signed-off-by: Anoob Soman

[PATCH review for 4.9 06/50] mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Johannes Berg [ Upstream commit ff4dd73dd2b4806419f8ff65cbce11d5019548d0 ] Unfortunately, the nla policy was defined to have HWSIM_ATTR_RADIO_NAME as an NLA_STRING, rather than NLA_NUL_STRING, so we can't use it as a NUL-terminated string in the kernel. Rather

[PATCH review for 4.4 23/26] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data

[PATCH review for 3.18 09/14] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 4.4 07/26] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to

[PATCH review for 4.4 20/26] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to

[PATCH review for 3.18 01/14] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on

[PATCH review for 3.18 12/14] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6

[PATCH review for 4.4 09/26] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides

[PATCH review for 4.4 04/26] mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Johannes Berg [ Upstream commit ff4dd73dd2b4806419f8ff65cbce11d5019548d0 ] Unfortunately, the nla policy was defined to have HWSIM_ATTR_RADIO_NAME as an NLA_STRING, rather than NLA_NUL_STRING, so we can't use it as a NUL-terminated string in the kernel. Rather

[PATCH review for 4.4 08/26] iio: adc: xilinx: Fix error handling

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit ca1c39ef76376b67303d01f94fe98bb68bb3861a ] Reorder error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET Acked-by: Lars-Peter

[PATCH review for 4.4 06/26] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Dumazet [ Upstream commit 47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf ] The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in

[PATCH review for 4.4 21/26] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t

[PATCH review for 3.18 10/14] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.9 09/50] mac80211: fix power saving clients handling in iwlwifi

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Emmanuel Grumbach [ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ] iwlwifi now supports RSS and can't let mac80211 track the PS state based on the Rx frames since they can come out of order. iwlwifi is now advertising AP_LINK_PS, and uses explicit

[PATCH review for 4.9 13/50] iio: adc: xilinx: Fix error handling

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit ca1c39ef76376b67303d01f94fe98bb68bb3861a ] Reorder error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET Acked-by: Lars-Peter

[PATCH review for 4.9 19/50] sparc64: Migrate hvcons irq to panicked cpu

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Vijay Kumar [ Upstream commit 7dd4fcf5b70694dc961eb6b954673e4fc9730dbd ] On panic, all other CPUs are stopped except the one which had hit panic. To keep console alive, we need to migrate hvcons irq to panicked CPU. Signed-off-by: Vijay Kumar

[PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 4.9 16/50] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides

[PATCH review for 4.9 32/50] i2c: at91: ensure state is restored after suspending

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Alexandre Belloni [ Upstream commit e3ccc921b7d8fd1fcd10a00720e09823d8078666 ] When going to suspend, the I2C registers may be lost because the power to VDDcore is cut. Restore them when resuming. Signed-off-by: Alexandre Belloni

[PATCH review for 4.9 33/50] ceph: don't update_dentry_lease unless we actually got one

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit 80d025ffede88969f6adf7266fbdedfd5641148a ] This if block updates the dentry lease even in the case where the MDS didn't grant one. Signed-off-by: Jeff Layton Reviewed-by: Yan, Zheng Signed-off-by:

[PATCH review for 4.9 08/50] qed: Don't use attention PTT for configuring BW

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Mintz, Yuval" [ Upstream commit 6f437d431930ff86e4a971d29321951faadb97c7 ] Commit 653d2ffd6405 ("qed*: Fix link indication race") introduced another race - one of the inner functions called from the link-change flow is explicitly using the slowpath context

[PATCH review for 4.9 20/50] net/mlx4_core: Fix VF overwrite of module param which disables DMFS on new probed PFs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Majd Dibbiny [ Upstream commit 95f1ba9a24af9769f6e20dfe9a77c863f253f311 ] In the VF driver, module parameter mlx4_log_num_mgm_entry_size was mistakenly overwritten -- and in a manner which overrode the device-managed flow steering option encoded in the parameter.

[PATCH review for 4.9 42/50] hrtimer: Catch invalid clockids again

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Marc Zyngier [ Upstream commit 336a9cde10d641e70bac67d90ae91b3190c3edca ] commit 82e88ff1ea94 ("hrtimer: Revert CLOCK_MONOTONIC_RAW support") removed unfortunately a sanity check in the hrtimer code which was part of that MONOTONIC_RAW patch series. It would have

[PATCH review for 4.9 14/50] f2fs: do SSR for data when there is enough free space

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Yunlong Song [ Upstream commit 035e97adab26c1121cedaeb9bd04cf48a8e8cf51 ] In allocate_segment_by_default(), need_SSR() already detected it's time to do SSR. So, let's try to find victims for data segments more aggressively in time. Signed-off-by: Yunlong Song

[PATCH review for 4.9 26/50] ASoC: mediatek: add I2C dependency for CS42XX8

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 72cedf599fcebfd6cd2550274d7855838068d28c ] We should not select drivers that depend on I2C when that is disabled, as it results in a build error: warning: (SND_SOC_MT2701_CS42448) selects SND_SOC_CS42XX8_I2C which has unmet direct

[PATCH review for 4.9 29/50] qede: Prevent index problems in loopback test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Sudarsana Reddy Kalluru [ Upstream commit afe981d664aeeebc8d1bcbd7d2070b5432edaecb ] Driver currently utilizes the same loop variable in two nested loops. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz

[PATCH review for 4.9 24/50] slub: do not merge cache if slub_debug contains a never-merge flag

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Grygorii Maistrenko [ Upstream commit c6e28895a4372992961888ffaadc9efc643b5bfe ] In case CONFIG_SLUB_DEBUG_ON=n, find_mergeable() gets debug features from commandline but never checks if there are features from the SLAB_NEVER_MERGE set. As a result selected by

<    1   2   3   4   5   6   7   8   9   10   >