[PATCH v2 0/2] i2c: fix two wrong mem release

2013-05-09 Thread Libo Chen
fix two wrong mem release * Changelog from v1: * exchange out_error_no_irq and out_error_pin_mux suggested by Sonic * add some new tag , make code cleanly Libo Chen (2): i2c: i2c-bfin-twi: don`t free peripheral before it init successful i2c: pxa: no need release_mem_region before

[PATCH v2 2/2] i2c: pxa: no need release_mem_region before request_mem_region successful

2013-05-09 Thread Libo Chen
When kzalloc fail, there is no reason to release_mem_region fix confuse tag, add new tag: emem, eirq, edt and make it cleanly Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-pxa.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful

2013-05-09 Thread Libo Chen
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-bfin-twi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c index

Re: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful

2013-05-09 Thread Libo Chen
On 2013/5/9 16:33, Zhang, Sonic wrote: > Hi Libo, > >> -Original Message----- >> From: Libo Chen [mailto:libo.c...@huawei.com] >> Sent: Thursday, May 09, 2013 4:27 PM >> To: Zhang, Sonic; w...@the-dreams.de >> Cc: uclinux-dist-de...@blackfin.uclin

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Libo Chen
On 2013/5/10 2:02, Chris Metcalf wrote: > On 5/9/2013 2:08 AM, Libo Chen wrote: >> When usb_create_hcd fail, we should call gxio_usb_host_destroy >> >> Signed-off-by: Libo Chen >> --- >> drivers/usb/host/ohci-tilegx.c |7 +-- >> 1 file

Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-09 Thread Libo Chen
On 2013/5/10 9:09, Libo Chen wrote: > On 2013/5/10 2:02, Chris Metcalf wrote: >> On 5/9/2013 2:08 AM, Libo Chen wrote: >>> When usb_create_hcd fail, we should call gxio_usb_host_destroy >>> >>> Signed-off-by: Libo Chen >>> --- >>> driv

[PATCH v2] usb: ohci: fix goto wrong tag in err case

2013-05-09 Thread Libo Chen
fix goto wrong tag in usb_hcd_nxp_probe * Changelog from v1: * instead of all these statement labels suggested by Alan Stern Signed-off-by: Libo Chen --- drivers/usb/host/ohci-nxp.c | 46 +- 1 files changed, 23 insertions(+), 23 deletions(-) diff

[RFC PATCH] usb: fsl: add missing platform_driver owner

2013-05-10 Thread Libo Chen
From: Libo Chen set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/host/ehci-fsl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 3be3df2

[PATCH] menuconfig: print more info for symbol without prompts

2013-04-26 Thread Libo Chen
e: Symbol: GENERIC_SMP_IDLE_THREAD [=y] Type : boolean Selected by: X86 [=y] after: Symbol: GENERIC_SMP_IDLE_THREAD [=y] Type : boolean Defined at arch/Kconfig:213 Selected by: X86 [=y] Signed-off-by: Weng Meiling Signed-off-by: Libo Chen --- scripts/kconfig/menu.c | 27

Re: [PATCH 4/4] usb: tilegx: fix memleak when create hcd fail

2013-05-16 Thread Libo Chen
Hi Greg, On 2013/5/17 8:34, Greg KH wrote: > On Thu, May 09, 2013 at 12:58:11PM +0800, Libo Chen wrote: >> From: Libo Chen >> >> When usb_create_hcd fail, we should call gxio_usb_host_destroy >> >> Signed-off-by: Libo Chen >> --- >> drivers/usb/

Re: [PATCH] usb: omap2430: fix memleak in err case

2013-05-16 Thread Libo Chen
On 2013/5/15 19:55, Sergei Shtylyov wrote: > Hello. > > On 15-05-2013 5:35, Libo Chen wrote: > >> when omap_get_control_dev fail, we should release relational platform_device > >s/fail/fails/, s/relational/related/? > >> Signed-off-by: Libo Chen >

[PATCH] cdrom: gdrom: fix device number leak

2013-05-16 Thread Libo Chen
without this patch, gdrom_major will leak when gd.cd_info alloc faild Signed-off-by: Libo Chen --- drivers/cdrom/gdrom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index 4afcb65..5980cb9 100644 --- a/drivers/cdrom

[PATCH] MIPS: drivers: fix clk leak

2013-05-16 Thread Libo Chen
when gptu_r32 fail, we should put clk before return Signed-off-by: Libo Chen --- arch/mips/lantiq/xway/gptu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c index 9861c86..4fa577c 100644 --- a/arch/mips

Re: [PATCH v2 0/2] i2c: fix two wrong mem release

2013-05-18 Thread Libo Chen
于 2013-5-17 17:43, Wolfram Sang 写道: On Thu, May 09, 2013 at 04:27:22PM +0800, Libo Chen wrote: >fix two wrong mem release > >* Changelog from v1: > * exchange out_error_no_irq and out_error_pin_mux suggested by Sonic > * add some new tag , make code cleanly Thanks for th

[PATCH] cdrom: gdrom: fix device number leak

2013-05-19 Thread Libo Chen
"repost with Jens Axboe added" suggest by Tejun Heo without this patch, gdrom_major will leak when gd.cd_info alloc faild Signed-off-by: Libo Chen --- drivers/cdrom/gdrom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cdrom/gdrom.c b/dri

[PATCH 1/3] x86: msi-laptop: fix memleak

2013-05-19 Thread Libo Chen
1. fix two visible mistakes: * when load_scm_model_init faild, we should call platform_device_del(msipf_device) * msipf_attribute_group should be remove in err case 2. change some tags, give them real meaning. Signed-off-by: Libo Chen --- drivers/platform/x86/msi-laptop.c | 24

[PATCH 0/3] fix x86 driver memleak

2013-05-19 Thread Libo Chen
fix memleak or invalite point acesss about x86 platform drivers Libo Chen (3): x86: msi-laptop: fix memleak x86: asus-laptop: fix invalid point access x86 platform drivers: fix gpio leak drivers/platform/x86/asus-laptop.c | 1 - drivers/platform/x86/intel_pmic_gpio.c | 5

[PATCH 3/3] x86 platform drivers: fix gpio leak

2013-05-19 Thread Libo Chen
when request_irq faild, we should release gpiochip Signed-off-by: Libo Chen --- drivers/platform/x86/intel_pmic_gpio.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c diff --git a/drivers/platform/

[PATCH 2/3] x86: asus-laptop: fix invalid point access

2013-05-19 Thread Libo Chen
asus->name is null or point to const string,so it is not suitable to kfree it. Signed-off-by: Libo Chen --- drivers/platform/x86/asus-laptop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c index 0eea09c..8e26

[PATCH 05/19] drivers/ust/renesas_usbhs: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/renesas_usbhs/common.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs

[PATCH 11/19] drivers/net/ethernet/natsemi: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/natsemi/xtsonic.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/natsemi/xtsonic.c b/drivers/net

[PATCH 04/19] drivers/usb/dwc3: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/dwc3/core.c|1 + drivers/usb/dwc3/dwc3-exynos.c |1 + drivers/usb/dwc3/dwc3-omap.c |1 + 3 files changed, 3 insertions(+), 0 deletions

[PATCH 07/19] drivers/usb/gadget: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/gadget/r8a66597-udc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597

[PATCH 16/19] drivers/net/wan: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/wan/ixp4xx_hss.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c index

[PATCH 14/19] drivers/net/wireless/brcm80211/brcmfmac: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmfmac

[PATCH 17/19] drivers/net/ethernet/nxp: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/nxp/lpc_eth.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp

[PATCH 13/19] drivers/net/ethernet/calxeda: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/calxeda/xgmac.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet

[PATCH 03/19] drivers/usb/chipidea: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/chipidea/ci13xxx_msm.c |2 +- drivers/usb/chipidea/core.c|1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb

[PATCH 12/19] drivers/net/ethernet/xscale: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/xscale/ixp4xx_eth.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net

[PATCH 15/19] drivers/net/irda: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/irda/bfin_sir.c |1 + drivers/net/irda/sh_irda.c|1 + drivers/net/irda/sh_sir.c |1 + drivers/net/irda/smsc-ircc2.c |1 + 4 files

[PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/marvell/mvneta.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net

[PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-20 Thread Libo Chen
I find a lot of mistakes using struct platform_driver without owner. So I pick up some of them including usb and net modules Libo Chen (19): drivers/usb/musb: add missing platform_driver owner drivers/usb/host: add missing platform_driver owner drivers/usb/chipidea: add missing

[PATCH 08/19] drivers/net/ethernet/amd: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/amd/am79c961a.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/amd/am79c961a.c b/drivers/net/ethernet

[PATCH 01/19] drivers/usb/musb: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/musb/am35x.c|1 + drivers/usb/musb/blackfin.c |1 + drivers/usb/musb/da8xx.c|1 + drivers/usb/musb/davinci.c |1 + drivers/usb/musb

[PATCH 19/19] drivers/net/ethernet/renesas: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/renesas/sh_eth.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net

[PATCH 02/19] drivers/usb/host: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/host/ehci-atmel.c |1 + drivers/usb/host/ehci-msm.c |1 + drivers/usb/host/ehci-mv.c |1 + drivers/usb/host/ehci-mxc.c |1

[PATCH 09/19] drivers/net/ethernet: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/dnet.c |3 ++- drivers/net/ethernet/korina.c |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 06/19] drivers/usb/phy: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/usb/phy/phy-rcar-usb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rcar-usb.c

[PATCH 10/19] drivers/net/ethernet/freescale: add missing platform_driver owner

2013-05-20 Thread Libo Chen
set the owner of platform_driver, to ensure that the caller of driver holds a module refernece Signed-off-by: Libo Chen --- drivers/net/ethernet/freescale/xgmac_mdio.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Libo Chen
On 2013/5/21 16:00, Gu Zheng wrote: > On 05/21/2013 02:41 PM, Thomas Petazzoni wrote: > >> Dear David Miller, >> >> On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote: >>> From: Libo Chen >>> Date: Tue, 21 May 2013 10:42:00 +0800 >

Re: [PATCH 00/19] driver:usb&net: add missing platform_driver owner

2013-05-21 Thread Libo Chen
On 2013/5/21 17:06, Thomas Petazzoni wrote: > Dear Gu Zheng, > > On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote: > >>> Or, maybe make the existing module_platform_driver() macro do this? >> >> But not all the modules use module_platform_driver() macro to replace the >> module init/exit. > >

Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne

2013-05-21 Thread Libo Chen
On 2013/5/21 21:11, Sergei Shtylyov wrote: > Hello. > > On 21-05-2013 6:42, Libo Chen wrote: > >> set the owner of platform_driver, to ensure that the >> caller of driver holds a module refernece > >> Signed-off-by: Libo Chen >> --- >> drivers/

[PATCH v2] usb: omap2430: fix memleak in err case

2013-05-21 Thread Libo Chen
when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei Signed-off-by: Libo Chen --- drivers/usb/musb/omap2430.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Libo Chen
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Signed-off-by: Libo Chen Acked-by: Rafał Miłecki --- drivers/mtd/devices/bcm47xxsflash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) * add Acked-by: Rafał Miłecki * change send list diff --git

Re: [PATCH] bestcomm: no need to free when kzalloc fail

2013-05-21 Thread Libo Chen
ping... On 2013/5/5 16:38, chenlib...@gmail.com wrote: > From: Libo Chen > > There is no need to free bcom_eng if kzalloc fail > > Signed-off-by: Libo Chen > --- > drivers/dma/bestcomm/bestcomm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-21 Thread Libo Chen
ping... On 2013/5/15 12:47, Libo Chen wrote: > > This patch merge two patch that I sended before: > 1. msm: iommu: add missing platform_device_unregister() in err case > 2. msm: iommu: no need kfree before kzalloc successful > > It fixes two obvious problems: >

Re: [PATCH] bestcomm: no need to free when kzalloc fail

2013-05-21 Thread Libo Chen
On 2013/5/22 12:58, Li Zefan wrote: > On 2013/5/22 12:49, Libo Chen wrote: >> >> ping... >> >> On 2013/5/5 16:38, chenlib...@gmail.com wrote: >>> From: Libo Chen >>> >>> There is no need to free bcom_eng if kzalloc fail >>> > &

Re: [PATCH] bestcomm: no need to free when kzalloc fail

2013-05-21 Thread Libo Chen
On 2013/5/22 14:06, Benjamin Herrenschmidt wrote: > On Wed, 2013-05-22 at 12:49 +0800, Libo Chen wrote: >> ping... > > This is pointless. We routinely avoid adding such crap by having > the various free(...) routines cope with NULL. You just need to make > sure you are ind

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-22 Thread Libo Chen
On 2013/5/23 6:29, David Brown wrote: > On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote: > >> > ping... > This is the first I've seen this patch. The original appears to have > been sent to Andrew Morton and lkml. I'll reply with an Ack there. &

[PATCH RFC v3 3/3] i2c: pxa: use module_platform_driver() replace init/exit

2013-05-23 Thread Libo Chen
use module_platform_driver() macro to replace the module init/exit Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-pxa.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 7b10102..e9c3524

[PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Libo Chen
peripheral_request_list has got free if any one faild, so no need to free again in err case. aovid this, convert them to devm_* API Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-bfin-twi.c | 38 +--- 1 files changed, 10 insertions(+), 28 deletions

[PATCH RFC v3 0/3] i2c: fix bugs and update API

2013-05-23 Thread Libo Chen
this patchset does 3 jobs: 1. fix two bugs in probe 2. convert to devm_* API 3. use module_platform_driver() replace init/exit v2->v3: * convert to devm_* API suggested by Wolfram Sang * use module_platform_driver() replace init/exit Libo Chen (3): i2c: i2c-bfin-twi: convert to de

[PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API

2013-05-23 Thread Libo Chen
when i2c malloc faild, we should not try to call release_mem_region. aovid this, convert them to devm_* API. Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-pxa.c | 63 ++ 1 files changed, 15 insertions(+), 48 deletions(-) diff --git a/drivers/i2c

Re: [PATCH RFC v3 3/3] i2c: pxa: use module_platform_driver() replace init/exit

2013-05-23 Thread Libo Chen
maybe I make a mistake, please drop it. 于 2013-5-23 20:00, Libo Chen 写道: > use module_platform_driver() macro to replace the module init/exit > > Signed-off-by: Libo Chen > --- > drivers/i2c/busses/i2c-pxa.c | 10 +- > 1 files changed, 1 insertions(+), 9 deletions(

[PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Libo Chen
we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 846f475..195b095 100644 --- a/drivers/scsi/megaraid.c +++ b

Re: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Libo Chen
On 2013/5/24 10:49, Zhang, Sonic wrote: >> >- iface = kzalloc(sizeof(struct bfin_twi_iface), GFP_KERNEL); >> >+ iface = devm_kzalloc(&pdev->dev, sizeof(struct bfin_twi_iface), >> >+ GFP_KERNEL); >> > if (!iface) { >> > dev_err(&pdev->dev, "Cannot a

Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API

2013-05-23 Thread Libo Chen
On 2013/5/24 11:35, Gu Zheng wrote: > Hi Libo, >I think you can merge patch 1/3 and 2/3, they e thdo the saming that using > devm_* API to simplify > and make the code clean, and the additional goal is it also can fix a bug. > Besides, maybe you need to > change the title and make it clear a

Re: [PATCH] scsi: megaraid: check kzalloc

2013-05-24 Thread Libo Chen
On 2013/5/24 11:20, Santosh Y wrote: > On Fri, May 24, 2013 at 7:52 AM, Libo Chen > wrote: >> >> we should check kzalloc, avoid to hit oops >> >> Signed-off-by: Libo Chen >> --- >> drivers/scsi/megaraid.c |4 >> 1 files changed, 4

[PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-24 Thread Libo Chen
we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) instead of checking scmd->device, sdev is more appropriate. diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c in

[PATCH] module: use a macro instead of platform_driver_register

2013-05-24 Thread Libo Chen
I found a lot of mistakes using struct platform_driver without owner so I make a macro instead of the function platform_driver_register. It can set owner in it, then guys don`t care about module owner again. Signed-off-by: Libo Chen --- drivers/base/platform.c |8 +--- include

[PATCH 03/24] drivers/scsi/dmx3191d: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/scsi/dmx3191d.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c old mode 100644 new mode 100755 index 4b0dd8c

[PATCH 09/24] drivers/pci/ioapic: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/pci/ioapic.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/pci/ioapic.c b/drivers/pci/ioapic.c index 3c6bbdd..1b90579 100644 --- a/drivers/pci

[PATCH 12/24] drivers/memstick/host/r592: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/memstick/host/r592.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c index 9718661..1b6e913 100644

[PATCH 07/24] drivers/ide/delkin_cb: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/ide/delkin_cb.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/ide/delkin_cb.c b/drivers/ide/delkin_cb.c index 7e27d32..300daab 100644 --- a/drivers

[PATCH 05/24] drivers/scsi/mvumi: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/scsi/mvumi.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c old mode 100644 new mode 100755 index c3601b5

[PATCH 01/24] drivers/scsi/a100u2w: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. --- drivers/scsi/a100u2w.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c old mode 100644 new mode 100755 index 0163457..db3710f --- a/drivers/scsi/a10

[PATCH 06/24] drivers/net/irda/donauboe: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/net/irda/donauboe.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c old mode 100644 new mode 100755

[PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/scsi/initio.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c old mode 100644 new mode 100755 index 280d5af

[PATCH 11/24] drivers/ptp/ptp_pch: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean Signed-off-by: Libo Chen --- drivers/ptp/ptp_pch.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index bea9451..e63ca00 100644 --- a/drivers/ptp

[PATCH 10/24] drivers/mfd/lpc_ich: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/mfd/lpc_ich.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c index 9f12f91..06431df 100644 --- a/drivers/mfd

[PATCH 16/24] drivers/media/pci/mantis/mantis_cards: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean Signed-off-by: Libo Chen --- drivers/media/pci/mantis/mantis_cards.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis

[PATCH 14/24] drivers/platform/x86/intel_ips: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/platform/x86/intel_ips.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c index 5051aa9

[PATCH 20/24] drivers/media/pci/pluto2/pluto2: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/media/pci/pluto2/pluto2.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/pluto2/pluto2.c b/drivers/media/pci/pluto2/pluto2.c index 2290fae

[PATCH 23/24] drivers/pcmcia/pd6729: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/pcmcia/pd6729.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/pcmcia/pd6729.c b/drivers/pcmcia/pd6729.c index b29d97e..9a7fc88 100644 --- a/drivers

[PATCH 24/24] drivers/pcmcia/yenta_socket: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/pcmcia/yenta_socket.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c index 6b4ff09..dc18a3a

[PATCH 22/24] drivers/media/radio/radio-maxiradio: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean Signed-off-by: Libo Chen --- drivers/media/radio/radio-maxiradio.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/radio/radio-maxiradio.c b/drivers/media/radio/radio-maxiradio.c

[PATCH 17/24] drivers/media/pci/dm1105/dm1105: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/media/pci/b2c2/flexcop-pci.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/b2c2/flexcop-pci.c b/drivers/media/pci/b2c2/flexcop-pci.c index

[PATCH 21/24] drivers/media/pci/pt1/pt1: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/media/pci/pt1/pt1.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c index e921108..75ce142 100644

[PATCH 15/24] drivers/memstick/host/jmb38x_ms: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/memstick/host/jmb38x_ms.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index c37d375

[PATCH 08/24] drivers/atm/he: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/atm/he.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 507362a..80f9743 100644 --- a/drivers/atm/he.c +++ b/drivers

[PATCH 13/24] drivers/uwb/whci: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/uwb/whci.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/uwb/whci.c b/drivers/uwb/whci.c index f48093e..deeeba4 100644 --- a/drivers/uwb/whci.c +++ b

[PATCH 18/24] drivers/media/pci/mantis/hopper_cards: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/media/pci/mantis/hopper_cards.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/mantis/hopper_cards.c b/drivers/media/pci/mantis

[PATCH 19/24] drivers/media/pci/dm1105/dm1105: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/media/pci/dm1105/dm1105.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index 026767b

Re: [PATCH 00/25] Convert to module_pci_driver replace init/exit

2013-05-26 Thread Libo Chen
sorry, only 24! On 2013/5/27 10:28, Libo Chen wrote: > use module_pci_driver instead of init/exit, make code clean. > > Libo Chen (25): > drivers/scsi/a100u2w: Convert to module_pci_driver replace init/exit > drivers/scsi/dc395x: Convert to module_pci_driver > dri

[PATCH 02/24] drivers/scsi/dc395x: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/scsi/dc395x.c | 24 +--- 1 files changed, 1 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c old mode 100644 new mode 100755 index

[PATCH RESEND 01/24] drivers/scsi/a100u2w: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen --- drivers/scsi/a100u2w.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) * add "Signed-off-by: Libo Chen " diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.

Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-27 Thread Libo Chen
On 2013/5/27 14:38, James Bottomley wrote: > On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: >> use module_pci_driver instead of init/exit, make code clean. > > For the ancient drivers, like this, the principal is that we really > don't touch except for tested bug fixes

Re: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-27 Thread Libo Chen
thanks for your review. I will update later. Libo On 2013/5/24 11:19, Sachin Kamat wrote: > On 23 May 2013 17:30, Libo Chen wrote: >> peripheral_request_list has got free if any one faild, so no need to free >> again in err case. >> aovid this, convert them to devm_* AP

Re: [PATCH] module: use a macro instead of platform_driver_register

2013-05-28 Thread Libo Chen
On 2013/5/25 20:22, Greg KH wrote: > On Sat, May 25, 2013 at 12:40:50PM +0800, Libo Chen wrote: >> >> I found a lot of mistakes using struct platform_driver without owner >> so I make a macro instead of the function platform_driver_register. >> It can set owner in it,

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-28 Thread Libo Chen
On 2013/5/28 20:27, Joerg Roedel wrote: > On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote: >>> >>> This patch merge two patch that I sended before: >>> 1. msm: iommu: add missing platform_device_unregister() in err case >>> 2. msm: iommu:

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
ping... On 2013/5/22 11:51, Libo Chen wrote: > > mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its > member. > > Signed-off-by: Libo Chen > Acked-by: Rafał Miłecki > --- > drivers/mtd/devices/bcm47xxsflash.c | 2 +- > 1 file changed,

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen
ping... On 2013/5/22 11:30, Libo Chen wrote: > > when omap_get_control_dev faild, we should release related platform_device > > * Changelog from v1: > * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei > > > Signed-off-by: Libo Chen > --- >

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen
On 2013/5/28 23:34, Andy Shevchenko wrote: > No go. > > Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a > And update you tree, please. > > -- > With Best Regards, > Andy Shevchenko > > It had been changed :( Thanks, Libo -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH] driver: tty: add missing unregister in err case

2013-05-28 Thread Libo Chen
when platform_driver_register broken, we should unregister ucc_uart_driver Signed-off-by: Libo chen --- drivers/tty/serial/ucc_uart.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 7355303..f86f447

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Libo Chen
On 2013/5/28 23:29, Andy Shevchenko wrote: > This is good fix, but I rather prefer not to see it in this shape. > See comments below. > > On Wed, May 22, 2013 at 6:51 AM, Libo Chen > wrote: >> >> mtd is just member of bcm47xxsflash, so we should free bcm47x

Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Libo Chen
On 2013/5/29 1:40, Sergei Shtylyov wrote: > Hello. > > On 22-05-2013 7:30, Libo Chen wrote: > >> when omap_get_control_dev faild, we should release related platform_device > >> * Changelog from v1: >> * fix spell: s/fail/fails/, s/relational/related/ , t

Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-12-10 Thread Libo Chen
On 11/30/20 7:25 PM, Steven Rostedt wrote: On Sun, 29 Nov 2020 20:32:56 -0500 Masayoshi Mizuma wrote: On Fri, Nov 20, 2020 at 06:12:43PM -0800, Libo Chen wrote: This issue was first noticed when I was testing different kernels on Oracle Linux 8 which as Fedora 30+ adopts BLS as default

Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-12-10 Thread Libo Chen
On 12/10/20 4:45 PM, Steven Rostedt wrote: On Thu, 10 Dec 2020 15:09:46 -0800 Libo Chen wrote: Hi Steven, Just wanna check in and check on the status of it. I have it applied in my local repo (even in my for-next, which I forgot to push :-p) I've been testing it on all my build mac

[PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-11-20 Thread Libo Chen
T_TYPE is "grub2bls" then we can boot to the correct kernel. Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option") Signed-off-by: Libo Chen --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/

Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-07 Thread Libo Chen
On 2014/1/3 13:34, David Miller wrote: > From: Libo Chen > Date: Fri, 3 Jan 2014 11:11:04 +0800 > >> >> introduce backup_classid to struct skbuff, >> we can use it to backup sk_classid when net_ns switch. >> >> Signed-off-by: Libo Chen > >

<    1   2   3   >