set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
.../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/nxp/lpc_eth.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c
b/drivers/net/ethernet/nxp
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/calxeda/xgmac.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c
b/drivers/net/ethernet
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/chipidea/ci13xxx_msm.c |2 +-
drivers/usb/chipidea/core.c|1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/usb
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/xscale/ixp4xx_eth.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c
b/drivers/net
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/irda/bfin_sir.c |1 +
drivers/net/irda/sh_irda.c|1 +
drivers/net/irda/sh_sir.c |1 +
drivers/net/irda/smsc-ircc2.c |1 +
4 files
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/marvell/mvneta.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net
I find a lot of mistakes using struct platform_driver without owner.
So I pick up some of them including usb and net modules
Libo Chen (19):
drivers/usb/musb: add missing platform_driver owner
drivers/usb/host: add missing platform_driver owner
drivers/usb/chipidea: add missing
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/amd/am79c961a.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/amd/am79c961a.c
b/drivers/net/ethernet
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/musb/am35x.c|1 +
drivers/usb/musb/blackfin.c |1 +
drivers/usb/musb/da8xx.c|1 +
drivers/usb/musb/davinci.c |1 +
drivers/usb/musb
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/renesas/sh_eth.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/host/ehci-atmel.c |1 +
drivers/usb/host/ehci-msm.c |1 +
drivers/usb/host/ehci-mv.c |1 +
drivers/usb/host/ehci-mxc.c |1
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/dnet.c |3 ++-
drivers/net/ethernet/korina.c |1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/usb/phy/phy-rcar-usb.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/phy/phy-rcar-usb.c b/drivers/usb/phy/phy-rcar-usb.c
set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece
Signed-off-by: Libo Chen
---
drivers/net/ethernet/freescale/xgmac_mdio.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
b/drivers
On 2013/5/21 16:00, Gu Zheng wrote:
> On 05/21/2013 02:41 PM, Thomas Petazzoni wrote:
>
>> Dear David Miller,
>>
>> On Mon, 20 May 2013 23:26:19 -0700 (PDT), David Miller wrote:
>>> From: Libo Chen
>>> Date: Tue, 21 May 2013 10:42:00 +0800
>
On 2013/5/21 17:06, Thomas Petazzoni wrote:
> Dear Gu Zheng,
>
> On Tue, 21 May 2013 16:00:19 +0800, Gu Zheng wrote:
>
>>> Or, maybe make the existing module_platform_driver() macro do this?
>>
>> But not all the modules use module_platform_driver() macro to replace the
>> module init/exit.
>
On 2013/5/21 21:11, Sergei Shtylyov wrote:
> Hello.
>
> On 21-05-2013 6:42, Libo Chen wrote:
>
>> set the owner of platform_driver, to ensure that the
>> caller of driver holds a module refernece
>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/
when omap_get_control_dev faild, we should release related platform_device
* Changelog from v1:
* fix spell: s/fail/fails/, s/relational/related/ , thank Sergei
Signed-off-by: Libo Chen
---
drivers/usb/musb/omap2430.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions
mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its
member.
Signed-off-by: Libo Chen
Acked-by: Rafał Miłecki
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
* add Acked-by: Rafał Miłecki
* change send list
diff --git
ping...
On 2013/5/5 16:38, chenlib...@gmail.com wrote:
> From: Libo Chen
>
> There is no need to free bcom_eng if kzalloc fail
>
> Signed-off-by: Libo Chen
> ---
> drivers/dma/bestcomm/bestcomm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
ping...
On 2013/5/15 12:47, Libo Chen wrote:
>
> This patch merge two patch that I sended before:
> 1. msm: iommu: add missing platform_device_unregister() in err case
> 2. msm: iommu: no need kfree before kzalloc successful
>
> It fixes two obvious problems:
>
On 2013/5/22 12:58, Li Zefan wrote:
> On 2013/5/22 12:49, Libo Chen wrote:
>>
>> ping...
>>
>> On 2013/5/5 16:38, chenlib...@gmail.com wrote:
>>> From: Libo Chen
>>>
>>> There is no need to free bcom_eng if kzalloc fail
>>>
>
&
On 2013/5/22 14:06, Benjamin Herrenschmidt wrote:
> On Wed, 2013-05-22 at 12:49 +0800, Libo Chen wrote:
>> ping...
>
> This is pointless. We routinely avoid adding such crap by having
> the various free(...) routines cope with NULL. You just need to make
> sure you are ind
On 2013/5/23 6:29, David Brown wrote:
> On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote:
>
>> > ping...
> This is the first I've seen this patch. The original appears to have
> been sent to Andrew Morton and lkml. I'll reply with an Ack there.
>
use module_platform_driver() macro to replace the module init/exit
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-pxa.c | 10 +-
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 7b10102..e9c3524
peripheral_request_list has got free if any one faild, so no need to free again
in err case.
aovid this, convert them to devm_* API
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-bfin-twi.c | 38 +---
1 files changed, 10 insertions(+), 28 deletions
this patchset does 3 jobs:
1. fix two bugs in probe
2. convert to devm_* API
3. use module_platform_driver() replace init/exit
v2->v3:
* convert to devm_* API suggested by Wolfram Sang
* use module_platform_driver() replace init/exit
Libo Chen (3):
i2c: i2c-bfin-twi: convert to de
when i2c malloc faild, we should not try to call release_mem_region.
aovid this, convert them to devm_* API.
Signed-off-by: Libo Chen
---
drivers/i2c/busses/i2c-pxa.c | 63 ++
1 files changed, 15 insertions(+), 48 deletions(-)
diff --git a/drivers/i2c
maybe I make a mistake, please drop it.
于 2013-5-23 20:00, Libo Chen 写道:
> use module_platform_driver() macro to replace the module init/exit
>
> Signed-off-by: Libo Chen
> ---
> drivers/i2c/busses/i2c-pxa.c | 10 +-
> 1 files changed, 1 insertions(+), 9 deletions(
we should check kzalloc, avoid to hit oops
Signed-off-by: Libo Chen
---
drivers/scsi/megaraid.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 846f475..195b095 100644
--- a/drivers/scsi/megaraid.c
+++ b
On 2013/5/24 10:49, Zhang, Sonic wrote:
>> >- iface = kzalloc(sizeof(struct bfin_twi_iface), GFP_KERNEL);
>> >+ iface = devm_kzalloc(>dev, sizeof(struct bfin_twi_iface),
>> >+ GFP_KERNEL);
>> > if (!iface) {
>> > dev_err(>dev, "Cannot allocate
On 2013/5/24 11:35, Gu Zheng wrote:
> Hi Libo,
>I think you can merge patch 1/3 and 2/3, they e thdo the saming that using
> devm_* API to simplify
> and make the code clean, and the additional goal is it also can fix a bug.
> Besides, maybe you need to
> change the title and make it clear
On 2013/5/24 11:20, Santosh Y wrote:
> On Fri, May 24, 2013 at 7:52 AM, Libo Chen
> wrote:
>>
>> we should check kzalloc, avoid to hit oops
>>
>> Signed-off-by: Libo Chen
>> ---
>> drivers/scsi/megaraid.c |4
>> 1 files changed,
we should check kzalloc, avoid to hit oops
Signed-off-by: Libo Chen
---
drivers/scsi/megaraid.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
instead of checking scmd->device, sdev is more appropriate.
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
in
: GENERIC_SMP_IDLE_THREAD [=y]
Type : boolean
Selected by: X86 [=y]
after:
Symbol: GENERIC_SMP_IDLE_THREAD [=y]
Type : boolean
Defined at arch/Kconfig:213
Selected by: X86 [=y]
Signed-off-by: Weng Meiling
Signed-off-by: Libo Chen
---
scripts/kconfig/menu.c | 27 ---
1
assid and put it in skb->sk pointer. can we put sk_classid form
struct sock to struct sk_buff? then sk_classid will not be affected
by dev_forward_skb()->skb_scrub_packet() ?
any comment are welcome!
thanks,
Libo
On 2013/12/12 20:18, Libo Chen wrote:
> ping...
>
> On 2013
hello network hackers,
A linux container was builded with veth pair(veth0 inside container,
veth1 outside container),
the config as below:
lxc.network.type = veth
lxc.network.flags = up
lxc.network.link = br0 // base on eth0
lxc.network.name = eth0
lxc.network.ipv4 =
hi,
my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on
3.4.24stable, startup 50 same process, every process is sample:
#include
int main()
{
for (;;)
{
unsigned int i = 0;
On 2014/5/26 15:56, Mike Galbraith wrote:
> On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote:
>> hi,
>> my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on
>> 3.4.24stable, startup 50 same process, every process is sample:
>>
>>
On 2014/5/26 13:11, Mike Galbraith wrote:
> On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote:
>> hi,
>> my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on
>> 3.4.24stable, startup 50 same process, every process is sample:
>>
>>
On 2014/5/26 22:03, Mike Galbraith wrote:
> On Mon, 2014-05-26 at 19:49 +0800, Libo Chen wrote:
>
>> how to turn off SD_SHARE_PKG_RESOURCES in userspace ?
>
> I use a script Ingo gave me years and years ago to
> twiddle /proc/sys/kernel/sched_domain/cpuN/domainN/flags
On 2014/5/26 22:19, Mike Galbraith wrote:
> On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote:
>> On 2014/5/26 13:11, Mike Galbraith wrote:
>
>>> Your synthetic test is the absolute worst case scenario. There has to
>>> be work between wakeups for select_idl
On 2014/5/27 17:55, Mike Galbraith wrote:
> On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote:
>> > On 2014/5/26 22:19, Mike Galbraith wrote:
>>> > > On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote:
>>>> > >> On 2014/5/26 13:11, Mike Galbraith
On 2014/5/27 17:48, Peter Zijlstra wrote:
> So:
>
> 1) what kind of weird ass workload is that? Why are you waking up so
> often to do no work?
it's just a testcase, I agree it doesn`t exist in real world.
>
> 2) turning on/off share_pkg_resource is a horrid hack whichever way
> aruond you
On 2014/5/27 18:55, Mike Galbraith wrote:
> On Tue, 2014-05-27 at 12:43 +0200, Peter Zijlstra wrote:
>> On Tue, May 27, 2014 at 12:05:33PM +0200, Mike Galbraith wrote:
>>> On Tue, 2014-05-27 at 11:48 +0200, Peter Zijlstra wrote:
>>>
So I suppose this is due to the select_idle_sibling()
On 2014/5/27 21:20, Mike Galbraith wrote:
> On Tue, 2014-05-27 at 20:50 +0800, Libo Chen wrote:
>
>> in my box:
>>
>> perf top -g --sort=symbol
>>
>> Events: 3K cycles
>> 73.27% [k] read_hpet
>> 4.30% [k] _raw_spin_lock_irqsave
>> 1.
On 2014/5/28 4:53, Thomas Gleixner wrote:
> On Tue, 27 May 2014, Libo Chen wrote:
>> On 2014/5/27 17:55, Mike Galbraith wrote:
>>> On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote:
>>>>> On 2014/5/26 22:19, Mike Galbraith wrote:
>>>>>>&
On 2014/5/28 9:53, Mike Galbraith wrote:
> On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote:
>
>> oh yes, no tsc only hpet in my box.
>
> Making poor E5-2658 box a crippled wreck.
yes,it is. But cpu usage will be down from 15% to 5% when binding cpu, so maybe
read_hpet
is
On 2014/5/28 17:08, Thomas Gleixner wrote:
> On Wed, 28 May 2014, Libo Chen wrote:
>
>> On 2014/5/28 9:53, Mike Galbraith wrote:
>>> On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote:
>>>
>>>> oh yes, no tsc only hpet in my box.
>>>
>
On 2014/5/28 17:08, Thomas Gleixner wrote:
> On Wed, 28 May 2014, Libo Chen wrote:
>
>> On 2014/5/28 9:53, Mike Galbraith wrote:
>>> On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote:
>>>
>>>> oh yes, no tsc only hpet in my box.
>>>
>
On 2014/5/28 19:55, Mike Galbraith wrote:
> On Wed, 2014-05-28 at 19:43 +0800, Libo Chen wrote:
>> On 2014/5/28 17:08, Thomas Gleixner wrote:
>>> On Wed, 28 May 2014, Libo Chen wrote:
>>>
>>>> On 2014/5/28 9:53, Mike Galbraith wrote:
>>>>&
On 11/30/20 7:25 PM, Steven Rostedt wrote:
On Sun, 29 Nov 2020 20:32:56 -0500
Masayoshi Mizuma wrote:
On Fri, Nov 20, 2020 at 06:12:43PM -0800, Libo Chen wrote:
This issue was first noticed when I was testing different kernels on
Oracle Linux 8 which as Fedora 30+ adopts BLS as default
On 12/10/20 4:45 PM, Steven Rostedt wrote:
On Thu, 10 Dec 2020 15:09:46 -0800
Libo Chen wrote:
Hi Steven,
Just wanna check in and check on the status of it.
I have it applied in my local repo (even in my for-next, which I forgot
to push :-p)
I've been testing it on all my build machines
OT_TYPE is "grub2bls" then we can boot to
the correct kernel.
Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option")
Signed-off-by: Libo Chen
---
tools/testing/ktest/ktest.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/ktest
From: Libo Chen
On 2013-1-29 4:23, Kirill Tkhai wrote:
> Just switched pinned task is not able to be pushed. If the rq had had
> several RT tasks before they have already been considered as candidates
> to be pushed (or pulled).
>
> Signed-off-by: Kirill V Tkhai
> CC: St
On 2013/8/22 9:53, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han
> ---
It looks good.
Acked-by: Libo
decrease device_node refcount np1 in err case.
Signed-off-by: Libo Chen
---
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
b/drivers/net/ethernet/xilinx
decrease device_node refcount np after task completion
Signed-off-by: Libo Chen
---
drivers/edac/cell_edac.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/edac/cell_edac.c b/drivers/edac/cell_edac.c
index c2eaf33..493dc30 100644
--- a/drivers/edac/cell_edac.c
decrease np device_node refcount after task completion
Signed-off-by: Libo Chen
---
drivers/power/max8925_power.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/power/max8925_power.c b/drivers/power/max8925_power.c
index 0ee1e14..b4513f2 100644
--- a/drivers
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen
---
drivers/usb/host/ohci-at91.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ohci
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with >dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen
---
drivers/usb/renesas_usbhs/common.c |2 +-
1 files changed, 1 inserti
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with >dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen
---
drivers/usb/host/r8a66597-hcd.c |4 ++--
1 files changed, 2 inserti
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with >dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen
---
drivers/usb/phy/phy-tegra-usb.c |2 +-
1 files changed, 1 inserti
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with >dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen
---
drivers/usb/gadget/fotg210-udc.c |4 ++--
1 files changed, 2 inserti
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with >dev,
so we can directly pass a struct platform_device.
Libo Chen (4):
usb: fotg210-udc: use platform_{get,set}_drvdata()
usb: r8a66597-hcd: use platform_{
when request_irq fails, we should release gpiochip
v2:
fix warning: ignoring return value of 'gpiochip_remove
Signed-off-by: Libo Chen
---
drivers/platform/x86/intel_pmic_gpio.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86
use module_pci_driver instead of init/exit, make code clean.
Signed-off-by: Libo Chen
Cc: Bill Pemberton
Cc: Greg Kroah-Hartman
Cc: Eric Miao
Cc: Dominik Brodowski
Signed-off-by: Andrew Morton
---
drivers/pcmcia/pd6729.c | 13 +
1 files changed, 1 insertions(+), 12 deletions
401 - 468 of 468 matches
Mail list logo
