RE: [PATCH 0/9] Enable dw-mmc multi-card support

2017-10-16 Thread Liming Sun
-kernel-ow...@vger.kernel.org] On Behalf Of Liming Sun Sent: Friday, October 6, 2017 3:21 PM To: Ulf Hansson ; Rob Herring ; Mark Rutland ; Jaehoon Chung ; Kukjin Kim ; Krzysztof Kozlowski Cc: Liming Sun ; linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux

RE: [PATCH 0/9] Enable dw-mmc multi-card support

2017-10-17 Thread Liming Sun
wrong. Thanks, Liming -Original Message- From: Shawn Lin [mailto:shawn@rock-chips.com] Sent: Monday, October 16, 2017 9:36 PM To: Liming Sun ; Jaehoon Chung Cc: Ulf Hansson ; Rob Herring ; Mark Rutland ; Kukjin Kim ; Krzysztof Kozlowski ; shawn@rock-chips.com;

[PATCH v1 1/1] mmc: core: control EXT_CSD_CACHE_CTRL from device tree

2018-11-20 Thread Liming Sun
Currently the EXT_CSD_CACHE_CTRL register is controlled by API mmc_card_broken_hpi(), which only works for the quirks settings. This commit enhances it to use card->ext_csd.hpi instead. This flag works for both the quirks and the broken-hpi configuration in the device tree. Signed-off-by: Lim

RE: [PATCH v1 1/1] mmc: core: control EXT_CSD_CACHE_CTRL from device tree

2018-12-04 Thread Liming Sun
Thanks for the comment. Yes, I actually have the same question. The change here is to fix a condition based on the existing code. Probably a better fix is to get rid of the 'connection'... -Original Message- From: Alex Lemberg Sent: Tuesday, December 4, 2018 11:27 AM To:

[PATCH v1 1/1] mmc: dw_mmc-bluefield: simplify the probe() function

2018-10-19 Thread Liming Sun
This commit removes the unnecessary of-node check since the dw_mci_bluefield_match[] structure has only one entry. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc-bluefield.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/mmc/host/dw_mmc

[PATCH v3 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-04-30 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host

[PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-04-30 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Signed-off-by: Liming Sun --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Doc

[PATCH v3 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-04-30 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b

RE: [PATCH v2 2/3] Documentation: bluefield-dw-mshc: add DT description

2018-04-30 Thread Liming Sun
Thanks. Updated in v3 2/3. - Liming > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Friday, April 27, 2018 3:51 PM > To: Liming Sun > Cc: Ulf Hansson ; Mark Rutland > ; Jaehoon Chung ; > Catalin Marinas ; Will Deacon > ; linux-...@vg

[PATCH v4 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-01 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host

[PATCH v4 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-01 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Signed-off-by: Liming Sun --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Doc

RE: [PATCH v3 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-01 Thread Liming Sun
Sorry, my mistake. I missed the last one in the v3 comments. Fixed it in v4 2/3. Thanks, Liming > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, May 1, 2018 8:48 AM > To: Liming Sun > Cc: Ulf Hansson ; Mark Rutland > ; Jaehoon Chung ;

[PATCH v4 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-05-01 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b

[PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-01 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Cc: sta...@kernel.org Signed-off-by: Liming Sun Reviewed-by: David Woods --- drivers/mmc/host/Kconfig| 9 + drivers/mmc/host

[PATCH v5 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-05-01 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Cc: sta...@kernel.org Signed-off-by: Liming Sun Reviewed-by: David Woods --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion

[PATCH v5 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-01 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Cc: sta...@kernel.org Signed-off-by: Liming Sun Reviewed-by: David Woods Reviewed-by: Rob Herring --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 +++

RE: [PATCH v4 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-01 Thread Liming Sun
Thanks! Updated in v5 2/3. > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, May 1, 2018 12:25 PM > To: Liming Sun > Cc: Ulf Hansson ; Mark Rutland > ; Jaehoon Chung ; > Catalin Marinas ; Will Deacon > ; linux-...@vg

RE: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-02 Thread Liming Sun
Please see response inline. Thanks, Liming > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Tuesday, May 1, 2018 9:02 PM > To: Liming Sun ; Mark Rutland > ; Jaehoon Chung ; > Catalin Marinas ; Will Deacon > > Cc: Ulf Hansson

RE: [PATCH v9] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-28 Thread Liming Sun
Thanks Andy for the comments. Please see the responses below. I'll also post the v10 patch after this email. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Wednesday, February 13, 2019 1:11 PM > To: Liming Sun > Cc: David Woods ; Andy Shevche

[PATCH v10] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-28 Thread Liming Sun
Signed-off-by: Liming Sun --- v9->v10: Fixes for comments from Andy: - Use devm_ioremap_resource() instead of devm_ioremap(). - Use kernel-doc comments. - Keep Makefile contents sorted. - Use same fixed format for offsets. - Use SZ_1K/SZ_32K instead of 1024/23*1024. - Rem

[PATCH v8 0/2] TmFifo platform driver for Mellanox BlueField SoC

2019-01-28 Thread Liming Sun
Pasternak during Mellanox internal review. Patch v8 2/2 was reviewed by Rob Herring before, but might need a second look since the location of the driver code is moved. Liming Sun (2): platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc dt-bindings: soc: Add TmFifo binding for Mellanox

[PATCH v8 2/2] dt-bindings: soc: Add TmFifo binding for Mellanox BlueField SoC

2019-01-28 Thread Liming Sun
Add devicetree bindings for the TmFifo which is found on Mellanox BlueField SoCs. Reviewed-by: Rob Herring Reviewed-by: David Woods Signed-off-by: Liming Sun --- .../devicetree/bindings/soc/mellanox/tmfifo.txt| 23 ++ 1 file changed, 23 insertions(+) create mode

[PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-01-28 Thread Liming Sun
-off-by: Liming Sun --- drivers/platform/mellanox/Kconfig | 13 +- drivers/platform/mellanox/Makefile|1 + drivers/platform/mellanox/mlxbf-tmfifo-regs.h | 67 ++ drivers/platform/mellanox/mlxbf-tmfifo.c | 1289 + 4 files changed, 1369

[PATCH v11] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-26 Thread Liming Sun
Signed-off-by: Liming Sun --- v11->v11: rebase & resend, no new changes v10->v11: Fixes for comments from Andy: - Use GENMASK_ULL() instead of GENMASK() in mlxbf-tmfifo-regs.h - Removed the cpu_to_le64()/le64_to_cpu() conversion since readq()/writeq() already takes

RE: [PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-19 Thread Liming Sun
Uffe, Can I confirm whether you meant the 'master' branch or some other branch? I did a rebase of master and didn't see Shawn Lin's changes in the sdhci-of-dwcmshc.c Thanks, Liming > -Original Message- > From: Ulf Hansson > Sent: Friday, March 19, 2021 10

[PATCH v3] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-22 Thread Liming Sun
lock value will be returned in function dwcmshc_get_max_clock(). Signed-off-by: Liming Sun Reviewed-by: Khalil Blaiech --- v2->v3: Rebase to mmc next. v1->v2: Changes for comments from Adrian Hunter : - Make changes in sdhci-of-dwcmshc instead. v1: Initial version which was done

RE: [PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-22 Thread Liming Sun
> -Original Message- > From: Ulf Hansson > Sent: Monday, March 22, 2021 5:51 AM > To: Liming Sun > Cc: Adrian Hunter ; Khalil Blaiech > ; linux-mmc ; Linux > Kernel Mailing List > Subject: Re: [PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for > BlueFiel

RE: [PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA BlueField-3 SoC

2021-03-15 Thread Liming Sun
Monday, March 15, 2021 4:34 AM > To: Liming Sun ; Ulf Hansson ; > Khalil Blaiech > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA > BlueField-3 SoC > > On 12/03/21 3:48 pm, Liming Sun wrote: &g

[PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-16 Thread Liming Sun
lock value will be returned in function dwcmshc_get_max_clock(). Signed-off-by: Liming Sun Reviewed-by: Khalil Blaiech --- v1->v2: Changes for comments from Adrian Hunter : - Make changes in sdhci-of-dwcmshc instead. v1: Initial version which was done in sdhci-acpi.c --- drivers/mmc/

RE: [PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA BlueField-3 SoC

2021-03-17 Thread Liming Sun
> -Original Message- > From: Adrian Hunter > Sent: Monday, March 15, 2021 3:20 PM > To: Liming Sun ; Khalil Blaiech ; > Ulf Hansson > Cc: linux-...@vger.kernel.org; Linux Kernel Mailing List ker...@vger.kernel.org> > Subject: Re: [PATCH v1 1/1] mmc: sdhci-acpi

[PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA BlueField-3 SoC

2021-03-12 Thread Liming Sun
This commit adds ACPI support for the BlueField-3 SoC which uses the DWC_mshc eMMC controller. The boundary check logic in static function dwcmshc_adma_write_desc() comes from sdhci-of-dwcmshc.c. Signed-off-by: Liming Sun Reviewed-by: Khalil Blaiech --- drivers/mmc/host/sdhci-acpi.c | 64

[PATCH v6 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-10-07 Thread Liming Sun
to prevent failure during boot partition upgrade. Reviewed-by: Vadim Pasternak Signed-off-by: Liming Sun --- v5->v6: Fixes for comments from Mark: - Changed to use device attributes (DEVICE_ATTR_xx) instead of driver attributes (DRIVER_ATTR_xx) for the exported sy

[PATCH v6 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions

2019-10-07 Thread Liming Sun
This commit adds the ABI definitions exposed to userspace for the platform/mellanox/mlxbf-bootctl driver. Reviewed-by: Vadim Pasternak Signed-off-by: Liming Sun --- v5->v6: Fixes for comments from Mark: - Changed to use device attributes (DEVICE_ATTR_xx) instead of dri

RE: [PATCH v9] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-14 Thread Liming Sun
Thanks Andy. Please see my response and questions on some of the comments below. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Wednesday, February 13, 2019 1:11 PM > To: Liming Sun > Cc: David Woods ; Andy Shevchenko ; > Darren Hart ; Vadim &

[PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-29 Thread Liming Sun
This commit adds the bootctl platform driver for Mellanox BlueField Soc, which controls the eMMC boot partition swapping and related watchdog configuration. Reviewed-by: David Woods Signed-off-by: Liming Sun --- drivers/platform/mellanox/Kconfig | 15 +- drivers/platform/mellanox

[PATCH v1 1/1] mmc: dw_mmc-bluefield: : Fix the license information

2019-01-18 Thread Liming Sun
The SPDX license identifier and the boiler plate text are contradicting. Only the SPDX license identifier is needed. The other one is removed. Fixes: 86958dcc5ad7 ("mmc: dw_mmc-bluefield: Add driver extension") Cc: sta...@vger.kernel.org Reviewed-by: David Woods Signed-off-by:

[PATCH v4] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-02-01 Thread Liming Sun
BootRom will switch the boot partition to the previous one. Signed-off-by: Liming Sun --- v4: Update Kconfig for the dependency on ACPI. Fixed a typo which caused build error for kernel module. v3: More coding style fixes, revised the uuid matching code. v2: Fix the Kconfig and coding

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-02-01 Thread Liming Sun
Thanks for the information! Patch v4 1/1 has been posted to solve these issues. Best regards, Liming > -Original Message- > From: kbuild test robot > Sent: Friday, February 1, 2019 12:17 AM > To: Liming Sun > Cc: kbuild-...@01.org; Andy Shevchenko ; Darren Hart >

RE: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-22 Thread Liming Sun
e. Once the driver is loaded, it exposes sysfs to userspace tools. Essentially, all the driver does is proxying the SMC calls into ATF, since user-space doesn't have the permission to do SMC call itself. Thanks, Liming > -Original Message- > From: Mark Rutland > Sent: Wedne

RE: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-22 Thread Liming Sun
Thanks Arnd for the comments! Please also see my response below. > -Original Message- > From: Arnd Bergmann > Sent: Tuesday, May 21, 2019 3:59 AM > To: Liming Sun > Cc: Greg KH ; Andy Shevchenko > ; Darren Hart ; Vadim > Pasternak ; David Woods ; > platform-dr

RE: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions

2019-05-17 Thread Liming Sun
Thanks Greg for the comments! Please see my response inline. Regards, - Liming > -Original Message- > From: Greg Kroah-Hartman > Sent: Friday, May 17, 2019 1:59 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Wo

RE: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions

2019-05-20 Thread Liming Sun
Please see response inline. > -Original Message- > From: Greg Kroah-Hartman > Sent: Saturday, May 18, 2019 2:35 AM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Woods ; platform-driver-...@vger.kernel.org; > linux-kernel@

RE: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-20 Thread Liming Sun
> -Original Message- > From: Greg KH > Sent: Monday, May 20, 2019 11:57 AM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Woods ; platform-driver-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATC

RE: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-20 Thread Liming Sun
> -Original Message- > From: Greg KH > Sent: Monday, May 20, 2019 3:12 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Woods ; platform-driver-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATC

[PATCH v13] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-04 Thread Liming Sun
Signed-off-by: Liming Sun --- v12->v13: Rebase and resubmit (no new changes). v11->v12: Fixed the two unsolved comments from v11. - "Change macro mlxbf_vdev_to_tmfifo() to one line" Done. Seems not hard. - "Is it appropriate use of devm_* for 'tm_vdev

RE: [PATCH v13] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-05 Thread Liming Sun
\n"); 1075 ret = -ENOMEM; 1076 goto vdev_fail; 1077 } ... 1097 vdev_fail: 1098 mlxbf_tmfifo_free_vrings(fifo, tm_vdev); Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Friday, April 5, 2019 11:44 AM > To:

[PATCH v14] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-06 Thread Liming Sun
Signed-off-by: Liming Sun --- v13->v14: Fixes for comments from Andy: - Add a blank line to separate the virtio header files; - Update the comment for 'union mlxbf_tmfifo_msg_hdr' to be more clear how this union is used; - Update the 'mlxbf_tmfifo_net_de

Re: [PATCH v13] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-06 Thread Liming Sun
Thanks Andy! I just posted v14, which addresses all the comments you mentioned below for v13. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Friday, April 5, 2019 11:44 AM > To: Liming Sun > Cc: David Woods ; Andy Shevchenko ; > Darren Hart ;

[PATCH v12] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-28 Thread Liming Sun
Signed-off-by: Liming Sun --- v11->v12: Fixed the two unsolved comments from v11. - "Change macro mlxbf_vdev_to_tmfifo() to one line" Done. Seems not hard. - "Is it appropriate use of devm_* for 'tm_vdev = devm_kzalloc'" Yes, understand the comm

[PATCH v16] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-05-03 Thread Liming Sun
Signed-off-by: Liming Sun --- v15->v16: Rebase and resubmit (no new changes). v14->v15: Fixes for comments from Andy: - Remove the 'union' definition of mlxbf_tmfifo_msg_hdr and use on-the-fly conversion when sending the 8-byte message header into the FIFO;

[PATCH v11] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-08 Thread Liming Sun
Signed-off-by: Liming Sun --- v10->v11: Fixes for comments from Andy: - Use GENMASK_ULL() instead of GENMASK() in mlxbf-tmfifo-regs.h - Removed the cpu_to_le64()/le64_to_cpu() conversion since readq()/writeq() already takes care of it. - Remove the "if (irq)&q

RE: [PATCH v10] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-08 Thread Liming Sun
Andy, The v11 has been posted. Thanks! Liming > -Original Message- > From: Liming Sun > Sent: Wednesday, March 6, 2019 3:01 PM > To: 'Andy Shevchenko' > Cc: David Woods ; Andy Shevchenko ; > Darren Hart ; Vadim > Pasternak ; Linux Kernel Maili

[PATCH v9] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-13 Thread Liming Sun
This commit adds the TmFifo platform driver for Mellanox BlueField Soc. TmFifo is a shared FIFO which enables external host machine to exchange data with the SoC via USB or PCIe. The driver is based on virtio framework and has console and network access enabled. Signed-off-by: Liming Sun

RE: [PATCH v8 1/2] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-13 Thread Liming Sun
. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Tuesday, January 29, 2019 5:07 PM > To: Liming Sun > Cc: Rob Herring ; Mark Rutland ; > Arnd Bergmann ; David Woods > ; Andy Shevchenko ; Darren Hart > ; Vadim Pasternak > ; devicetree ; Linu

RE: [PATCH v9] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-02-13 Thread Liming Sun
Thanks Andy. We actually had some internal reviews as you mentioned. I'll try to solve the comments and update the 'Reviewed-by' in next revision. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Wednesday, February 13, 2019 1:11 PM >

RE: [PATCH v10] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-06 Thread Liming Sun
Thanks Andy! Please see my response below. If no further comments, I'll try to post v11 after more testing. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Tuesday, March 5, 2019 10:34 AM > To: Liming Sun > Cc: David Woods ; Andy Shevche

RE: [PATCH v7 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-05-21 Thread Liming Sun
Thanks! I'll try to send this one to arm soc. Best regards, Liming > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Monday, May 21, 2018 7:36 AM > To: Liming Sun > Cc: Rob Herring ; Mark Rutland > ; Jaehoon Chung ; > Cat

RE: [PATCH 1/2] mmc: dw_mmc-bluefield: Add driver extension

2018-04-23 Thread Liming Sun
Thanks Uffe. I'll submit patch 2 as suggested. Best regards, Liming > -Original Message- > From: Ulf Hansson [mailto:ulf.hans...@linaro.org] > Sent: Monday, April 23, 2018 5:32 AM > To: Liming Sun > Cc: Rob Herring ; Mark Rutland > ; Jaehoon Chung ; > Cat

[PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-04-23 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- drivers/mmc/host/Kconfig| 9 + drivers/mmc/host/Makefile | 1 + drivers/mmc/host

[PATCH v2 2/3] Documentation: bluefield-dw-mshc: add DT description

2018-04-23 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Signed-off-by: Liming Sun --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Doc

[PATCH v2 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-04-23 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b

RE: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-03 Thread Liming Sun
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Shawn Lin > Sent: Thursday, May 3, 2018 3:25 AM > To: Liming Sun ; Mark Rutland > ; Jaehoon Chung ; > Catalin Marinas ; Will Deacon &g

[PATCH v6 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-03 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun Reviewed-by: David Woods --- drivers/mmc/host/Kconfig| 9 drivers/mmc/host/Makefile | 1

[PATCH v6 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-03 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Signed-off-by: Liming Sun Reviewed-by: David Woods Reviewed-by: Rob Herring --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 ++ 1 file c

[PATCH v6 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-05-03 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun Reviewed-by: David Woods --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch

RE: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-03 Thread Liming Sun
, 2018 4:17 AM > To: Liming Sun ; Ulf Hansson > ; Rob Herring ; Mark > Rutland ; Catalin Marinas > ; Will Deacon > Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; sta...@kernel.org > Subject: Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield:

[PATCH 1/2] mmc: dw_mmc-bluefield: Add driver extension

2018-04-20 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 + drivers/mmc/host/Kconfig

[PATCH 2/2] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-04-20 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b

RE: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-08 Thread Liming Sun
Sorry Shawn, somehow I missed this comment... Will update it in v7 soon. > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Monday, April 23, 2018 9:11 PM > To: Liming Sun > Cc: Ulf Hansson ; Rob Herring > ; Mark Rutland ; Jaehoon > Ch

[PATCH v7 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-08 Thread Liming Sun
This commit adds extension to the dw_mmc driver for Mellanox BlueField SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on this SoC. Signed-off-by: Liming Sun Reviewed-by: David Woods --- drivers/mmc/host/Kconfig| 9 + drivers/mmc/host/Makefile | 1

[PATCH v7 2/3] dt-bindings: mmc: Add binding for BlueField SoC

2018-05-08 Thread Liming Sun
This commit adds "mellanox,bluefield-dw-mshc" for dwmmc driver extension on Mellanox BlueField SoC platform. Signed-off-by: Liming Sun Reviewed-by: David Woods Reviewed-by: Rob Herring --- .../devicetree/bindings/mmc/bluefield-dw-mshc.txt | 29 ++ 1 file c

[PATCH v7 3/3] arm64: defconfig: Enable dw_mmc-bluefield driver

2018-05-08 Thread Liming Sun
This patch updates arm64 defconfig to enable dw_mmc-bluefield, which is a driver extension of Synopsys Designware MMC for the Mellanox BlueField Soc. Signed-off-by: Liming Sun Reviewed-by: David Woods --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch

RE: [PATCH v2 1/3] mmc: dw_mmc-bluefield: Add driver extension

2018-05-08 Thread Liming Sun
Thanks Shawn. Patch v7 has been sent out to address these comments. > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Monday, April 23, 2018 9:11 PM > To: Liming Sun > Cc: Ulf Hansson ; Rob Herring > ; Mark Rutland ; Jaehoon > Ch

[PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-17 Thread Liming Sun
rebooting. In such case, ATF Boot ROM will switch the boot partition back to the previous one. Reviewed-by: Vadim Pasternak Signed-off-by: Liming Sun --- v4->v5: Fixes for comments from Andy: - Added ABI documentation; - Remove the extra 'const' in mlxbf_bootctl

[PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions

2019-05-17 Thread Liming Sun
This commit adds the ABI definitions exposed to userspace for the platform/mellanox/mlxbf-bootctl driver. Reviewed-by: Vadim Pasternak Signed-off-by: Liming Sun --- .../ABI/testing/sysfs-platform-mellanox-bootctl| 58 ++ MAINTAINERS

RE: [PATCH v4] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-05-17 Thread Liming Sun
Thanks Andy! v5 has been posted to address all the comments. You could also see the detailed response below. Regards, Liming > -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf Of Andy Shevchenko > Sent: Tuesday, February 5, 2019 12:22 PM >

RE: [PATCH v14] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-12 Thread Liming Sun
Thanks Andy! I'll try to post v15 to address these comments this weekend. (Please also see responses to each comments below). > -Original Message- > From: Andy Shevchenko > Sent: Thursday, April 11, 2019 10:10 AM > To: Liming Sun > Cc: David Woods ; Andy Shevche

RE: [PATCH v13] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-12 Thread Liming Sun
Thanks Andy. Please see my response below for this email as well. - Liming > -Original Message- > From: Andy Shevchenko > Sent: Thursday, April 11, 2019 10:13 AM > To: Liming Sun > Cc: David Woods ; Andy Shevchenko ; > Darren Hart ; Vadim > Pasternak ; Linu

[PATCH v15] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-04-12 Thread Liming Sun
Signed-off-by: Liming Sun --- v14->v15: Fixes for comments from Andy: - Remove the 'union' definition of mlxbf_tmfifo_msg_hdr and use on-the-fly conversion when sending the 8-byte message header into the FIFO; - Update comment of mlxbf_tmfifo_msg_hdr explainin

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-30 Thread Liming Sun
Tuesday, January 29, 2019 5:03 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Woods ; Platform Driver > ; Linux Kernel Mailing List ker...@vger.kernel.org> > Subject: Re: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for >

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-30 Thread Liming Sun
Thanks Vadim. Please see my response and questions below. Regards, Liming > -Original Message- > From: Vadim Pasternak > Sent: Wednesday, January 30, 2019 1:24 AM > To: Andy Shevchenko ; Liming Sun > > Cc: Andy Shevchenko ; Darren Hart ; > David Woods ; Plat

[PATCH v2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-31 Thread Liming Sun
BootRom will switch the boot partition to the previous one. Reviewed-by: David Woods Signed-off-by: Liming Sun --- drivers/platform/mellanox/Kconfig | 14 +- drivers/platform/mellanox/Makefile| 1 + drivers/platform/mellanox/mlxbf-bootctl.c | 306

RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-31 Thread Liming Sun
Thanks! v2 has been posted trying to solve all the comments. Please also see response inline. Regards, Liming > -Original Message- > From: Andy Shevchenko > Sent: Wednesday, January 30, 2019 4:17 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim

RE: [PATCH v2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-31 Thread Liming Sun
Please see my response inline. Will provide v3 once I solve the comments. Thanks, Liming > -Original Message- > From: Andy Shevchenko > Sent: Thursday, January 31, 2019 12:02 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Wo

RE: [PATCH v2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-31 Thread Liming Sun
v3 has been posted with Changelog added. Thanks! Liming > -Original Message- > From: Liming Sun > Sent: Thursday, January 31, 2019 12:18 PM > To: 'Andy Shevchenko' > Cc: Andy Shevchenko ; Darren Hart ; > Vadim Pasternak ; David > Woods ; Platform Driver

[PATCH v3] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc

2019-01-31 Thread Liming Sun
BootRom will switch the boot partition to the previous one. Signed-off-by: Liming Sun --- v3: More coding style fixes, revised the uuid matching code. v2: Fix the Kconfig and coding styles, propagate errors to caller. v1: Initial version. --- drivers/platform/mellanox/Kconfig | 14

[PATCH 0/9] Enable dw-mmc multi-card support

2017-10-06 Thread Liming Sun
the CMD register to multiplex requests to different cards when working in SD_MMC_CEATA mode, set the CTYPE / CLKENA / CDTHRCTL registers properly according to the spec, and parse the per-card configuration to match the Linux Documentation (bindings/mmc/synopsys-dw-mshc.txt). Liming Sun (9): Revert

[PATCH 3/9] Revert "mmc: dw_mmc: use the 'slot' instead of 'cur_slot'"

2017-10-06 Thread Liming Sun
This reverts commit 42f989c002f235557e3a03feac3b2f16b17d53f6. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc-exynos.c | 4 ++-- drivers/mmc/host/dw_mmc.c| 33 + drivers/mmc/host

[PATCH 1/9] Revert "Documentation: dw-mshc: deprecate num-slots"

2017-10-06 Thread Liming Sun
This reverts commit 3f5b4b79d4c0fa71fd7d74c2a44bbc0869c04c9b. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff

[PATCH 2/9] Revert "mmc: dw_mmc: remove the unnecessary slot variable"

2017-10-06 Thread Liming Sun
This reverts commit e47c0b96678c5fd731c125dca677880e06d6394c. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b

[PATCH 7/9] Revert "mmc: dw_mmc: deprecated the "num-slots" property"

2017-10-06 Thread Liming Sun
This reverts commit d30a8f7bdf6498e47bd3a6f31e5028f239deb208. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host

[PATCH 9/9] mmc: dw_mmc: Parse slot-specific configuration

2017-10-06 Thread Liming Sun
This commit adds code to parse the child-nodes for slot specific configuration in the dw_mmc host driver according to linux/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt This change is needed when the cards have different configuration like the 'bus-width'. Signed-off-by:

[PATCH 4/9] Revert "mmc: dw_mmc: remove the 'id' arguments about functions relevant to slot"

2017-10-06 Thread Liming Sun
This reverts commit e4a65ef7687b6aaf36bedb497d3fd1480163d2d5. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c

[PATCH 5/9] Revert "mmc: dw_mmc: change the array of slots"

2017-10-06 Thread Liming Sun
This reverts commit b23475faed77f6a9016013c8db6b4707466e74a8. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc.c | 21 - drivers/mmc/host/dw_mmc.h | 4 +++- 2 files changed, 15 insertions(+), 10

[PATCH 6/9] Revert "mmc: dw_mmc: remove the loop about finding slots"

2017-10-06 Thread Liming Sun
This reverts commit 58870241a67453be7dc9ab368d5a0cdc9c404616. The Mellanox BlueField SoC requires multiple slot dw-mmc support. Signed-off-by: Liming Sun --- drivers/mmc/host/dw_mmc.c | 115 +++--- 1 file changed, 79 insertions(+), 36 deletions(-) diff

[PATCH 8/9] mmc: dw_mmc: Support two SD_MMC_CE-ATA cards

2017-10-06 Thread Liming Sun
27; field in CMD register; - Program the CDTHRCTL register for the SD_MMC_CE-ATA mode which is mentioned as a must in the databook for version 270a. Signed-off-by: Liming Sun Reviewed-by: Chris Metcalf --- drivers/mmc/host/dw_mmc.c | 75 ++-

RE: [PATCH 0/9] Enable dw-mmc multi-card support

2017-10-20 Thread Liming Sun
Thanks Jaehoon. Please also see my response inline. - Liming > -Original Message- > From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] > Sent: Friday, October 20, 2017 10:06 AM > To: Liming Sun ; Shawn Lin chips.com> > Cc: Ulf Hansson ; Rob Herring > ; Mark